replace WallpaperFeatureDiscovered probe with WallpaperSettingsOpened

upstream-sync
Matt Tighe 2 years ago committed by mergify[bot]
parent a419a6963c
commit d23fb30151

@ -6956,11 +6956,10 @@ search_terms:
expires: "2022-12-01"
wallpapers:
discovered_wallpaper_feature:
type: boolean
lifetime: application
wallpaper_settings_opened:
type: event
description: |
Whether or not the user has discovered the wallpaper feature.
User has opened the wallpaper settings screen.
bugs:
- https://github.com/mozilla-mobile/fenix/issues/23381
data_reviews:

@ -676,7 +676,7 @@ sealed class Event {
sealed class Search
object WallpaperFeatureDiscovered : Event()
object WallpaperSettingsOpened : Event()
data class WallpaperSelected(val wallpaper: org.mozilla.fenix.wallpapers.Wallpaper) : Event()
data class WallpaperSwitched(val wallpaper: org.mozilla.fenix.wallpapers.Wallpaper) : Event()
data class ChangeWallpaperWithLogoToggled(val checked: Boolean) : Event()

@ -908,8 +908,8 @@ private val Event.wrapper: EventWrapper<*>?
is Event.JumpBackInGroupTapped -> EventWrapper<NoExtraKeys>(
{ SearchTerms.jumpBackInGroupTapped.record(it) }
)
is Event.WallpaperFeatureDiscovered -> EventWrapper<NoExtraKeys>(
{ Wallpapers.discoveredWallpaperFeature.set(true) }
is Event.WallpaperSettingsOpened -> EventWrapper<NoExtraKeys>(
{ Wallpapers.wallpaperSettingsOpened.record() }
)
is Event.WallpaperSelected -> EventWrapper<NoExtraKeys>(
{

@ -768,7 +768,6 @@ class HomeFragment : Fragment() {
binding.wordmark.setOnClickListener {
val manager = requireComponents.wallpaperManager
val newWallpaper = manager.switchToNextWallpaper()
requireComponents.analytics.metrics.track(Event.WallpaperFeatureDiscovered)
requireComponents.analytics.metrics.track(Event.WallpaperSwitched(newWallpaper))
manager.updateWallpaper(
wallpaperContainer = binding.homeLayout,

@ -41,7 +41,7 @@ class WallpaperSettingsFragment : Fragment() {
container: ViewGroup?,
savedInstanceState: Bundle?
): View? {
metrics.track(Event.WallpaperFeatureDiscovered)
metrics.track(Event.WallpaperSettingsOpened)
return ComposeView(requireContext()).apply {
setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed)
setContent {

Loading…
Cancel
Save