In the UX review of 8491 it was discovered that the proposed solution is not
optimal and we should actually better stick with the old implementation.
This ticket comes to help with that and revert the already merged patch for
8491 and so will add same gradient to the top toolbar as the bottom toolbar.
It's better to fail fast on pre-push hooks so devs can get feedback as
fast as possible. Assembling is faster than unit testing so we assemble
everything first before unit testing.
In order to eat the perceived performance costs, we initialize storage
once we're visually complete. This way, we're reducing chances of user performing
a UI action which will trigger storage init and delay said action.
Make sure that we actually lazily initialize our storage layers.
With this patch applied, storage layers (history, logins, bookmarks) will be initialized when first
accessed. We will no longer block GeckoEngine init, for example, on waiting for the logins storage
to initialize (which needs to access the costly securePrefStorage).
Similarly, BackgroundServices init will no longer require initialized instances of the storage
components - references to their "lazy wrappers" will suffice.
In practice, this change changes when our storage layers are initialized in the following ways.
Currently, we will initialize everything on startup. This includes loading our megazord, as well.
With this change, init path depends on if the user is signed-into FxA or not.
If user is not an FxA user:
- on startup, none of the storage layers are initialized
- history storage will be initialized once, whenever:
- first non-customTab page is loaded (access to the HistoryDelegate)
- first interaction with the awesomebar
- history UI is accessed
- bookmarks storage will be initialized once, whenever:
- something is bookmarked, or we need to figure out if something's bookmarked
- bookmarks UI is accessed
- logins storage will be initialized once, whenever:
- first page is loaded with a login/password fields that can be autofilled
- (or some other interaction by GV with the autofill/loginStorage delegates)
- logins UI is accessed
- all of these storages will be initialized if the user logs into FxA and starts syncing data
- except, if a storage is not chosen to be synced, it will not be initialized
If user is an FxA user:
- on startup, none of the storage layers are initialized
- sometime shortly after startup is complete, when a sync worker runs in the background, all storage
layers that are enabled to sync will be initialized.
This change also means that we delay loading the megazord until first access (as described above).
Mihai Branescu
Arturo Mejia
ekager
mcarare
Aaron Train
ValentinTimisica
Mozilla L10n Automation Bot
exobyte101
Sawyer Blatz
Kate Glazko
codrut.topliceanu
MickeyMoz
Amaan Marfatia
mcarare
ValentinTimisica
David Walsh
Michael Comella
Severin Rudie
Elise Richards
Mugurell
Johan Lorenzo
Sebastian Kaspari
Grisha Kruglov
Gregory Mierzwinski