Commit Graph

224 Commits (ec7f9f63f616a5d81e5d40a27664e681370c94aa)

Author SHA1 Message Date
Henry Wilson 7c8e7c6b6e Codechange: Use null pointer literal instead of the NULL macro 6 years ago
Patric Stout e3c639a09f Remove: ENABLE_NETWORK switch
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.

Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.

A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.

With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.

All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
6 years ago
Patric Stout 72c5f2b3ee Remove: DOS support
In 10 years there was no active development on DOS. Although it
turned out to still work, the FPS was very bad. There is little
interest in the current community to look into this.

Further more, we like to switch to c++11 functions for threads,
which are not implemented by DJGPP, the only current compiler
for DOS.

Additionally, DOS is the only platform which does not support
networking. It is the reason we have tons of #ifdefs to support
disabling networking.

By removing DOS support, we can both use c++11 functions for threads,
and remove all the code related to disabling network. Sadly, this
means we have to see DOS go.

Of course, if you feel up for the task, simply revert this commit,
and implement stub c++11 functions for threads and stub functions
for networking. We are more than happy to accept such Pull Request.
6 years ago
Patric Stout 45fbaa64c2 Codechange: check if a define is set directly, instead of indirectly
config.lib happens to set GLOBAL_DATA_DIR in case it is not DOS
and not OS2, but this kind of deduction is annoying to maintain.
It is better to just check if the define you want to use is set,
and leave it to config.lib to set it or not depending on the OS.
6 years ago
Patric Stout 1f57150d80 Codechange: "basedir.h" is a system include, not a local 6 years ago
Patric Stout 7784d77713 Remove: MorphOS / AmigaOS support
In 10 years there is no commit to change how MorphOS works, and we
have no active maintainer for it. It is unlikely it works in its
current state (but not impossible).

With the arrival of SDL2 (and removal of SDL), MorphOS is no longer
support. There is an SDL2 port for MorphOS, but it is not maintained
by upstream SDL2, and nobody can currently test it out.

If anyone wants to re-add MorphOS, please do (revert this patch,
fix the problems, and create a Pull Request). If you need any help
doing so, let us know! It is not that we don't like MorphOS, it is
that we don't have anyone fixing the problems :(
6 years ago
glx c540d72445 Fix: [Win32] WIN32 may not be defined, always prefer the compiler predefined macro _WIN32 6 years ago
Charles Pigott f5b1115039 Doc: Lots and lots of doxymentation fixes 6 years ago
Niels Martin Hansen 458e441a4c Codechange: Make FioCreateDirectory public 6 years ago
Patric Stout aef69443e7 Remove: WinCE support 7 years ago
frosch 2e20751c5f (svn r27954) -Cleanup [FS#6644]: Remove unused function (M3Henry) 7 years ago
frosch b4b98e5165 (svn r27893) -Codechange: Use fallthrough attribute. (LordAro) 7 years ago
frosch 4c50ecd958 (svn r27886) -Fix [FS#6575-ish]: Do not modify argv[0]. 7 years ago
rubidium 5ef2042819 (svn r26514) -Fix: rewrite link-in-tar handling so it doesn't use strncpy and it doesn't overrun its buffers anymore 11 years ago
rubidium 9ed12b0f07 (svn r26509) -Codechange: replace strdup with stredup (the latter ensures the return is not NULL) 11 years ago
rubidium 8960939b22 (svn r26499) -Codechange: replace strndup with stredup 11 years ago
rubidium 21f991e235 (svn r26489) -Codechange: properly account for the end of buffers in the file io code instead of assuming MAX_PATH is okay 11 years ago
frosch ef4c2ce031 (svn r26485) -Codechange: Replace ttd_strlcpy and ttd_strlcat with strecpy and strecat. 11 years ago
rubidium 0463dbdc9e (svn r26482) -Codechange: add an include that allows us to undefine/redefine "unsafe" functions to prevent them from being used, and thus having to care about certain aspects of their return values 11 years ago
rubidium d2ffba07bb (svn r26114) -Fix-ish: do our best to not get bit by getenv being unsafe as hell 11 years ago
rubidium 0ac9ed0b6b (svn r26089) -Fix: a number of minor memory leaks 11 years ago
rubidium 3eecd246eb (svn r26087) -Fix: file descriptor leak when finding a corrupt tar 11 years ago
rubidium b75e60124d (svn r26082) -Fix [FS#5816] (r26077): tar files with more than one file in the root directory would not be read properly (zydeco) 11 years ago
rubidium 5e2d22da79 (svn r26077) -Codechange: handle strings like strings when scanning a tar instead of merely blobs of memory 11 years ago
rubidium 5049e938f5 (svn r26076) -Codechange: upgrade some C-style named structs to C++-style named structs 11 years ago
rubidium 78a316d349 (svn r26061) -Fix: negative result of ftell wasn't handled correctly in some cases 11 years ago
rubidium 0e9c992104 (svn r26058) -Fix: handle the return value of a number of functions better 11 years ago
rubidium b934e528d9 (svn r26008) -Fix (r25975): uninitialised warning 11 years ago
rubidium ee137a5ced (svn r25975) -Feature [FS#5385]: XDG base directory support 11 years ago
rubidium def597fe31 (svn r25974) -Codechange: make the _personal_dir global const, since once it's set it shouldn't be changed anyhow 11 years ago
frosch 23ba42b66c (svn r25291) -Add: WindowDesc ability to load and store information in a config file. 12 years ago
planetmaker c24374f99c (svn r24900) -Fix [FS#5389]: Comments with typos (most fixes supplied by Eagle_rainbow) 12 years ago
rubidium d5d96ba683 (svn r24877) -Fix: some whitespace "errors" 12 years ago
frosch edd9c0553a (svn r24804) -Add: Separate subdirectory for screenshots. 12 years ago
rubidium 27cf8de733 (svn r23983) -Fix [FS#5083]: tarred heightmaps wouldn't be found 13 years ago
truebrain 963802e9a7 (svn r23612) -Add: allow importing libraries in the same way as AI does, only with GS prefix (and in game/library) 13 years ago
truebrain b4f832f29f (svn r23605) -Add: GAME_DIR and CONTENT_TYPE_GAME, and read gamescript from that directory 13 years ago
rubidium a3a2fdcfc2 (svn r23234) -Fix [FS#4840]: crash when after downloading content 13 years ago
frosch 1f6c9c6457 (svn r23228) -Fix (r23227): FileScanner::Scan() still did not scan all required directories for basesets. 13 years ago
frosch 7b86e3e109 (svn r23227) -Fix (r23219): The FileScanner should also consider the old directories. 13 years ago
frosch 52d3be2e05 (svn r23226) -Fix (r23219): If you find a file, also use it. 13 years ago
rubidium 86a168b2e9 (svn r23225) -Fix: create the newgrf/baseset/ai directories in the personal directory so the user has some clue where to place the different files 13 years ago
rubidium 2b897b4fa0 (svn r23219) -Change: different directories for basesets and newgrfs. So data to baseset or newgrf, and gm to baseset 13 years ago
rubidium 9e7174e540 (svn r23218) -Codechange: prepare code for a separate base set directory 13 years ago
rubidium 6d991b3b10 (svn r23217) -Codechange: introduce the concept of scanning only in a limited set of sub directories 13 years ago
rubidium 160294ff22 (svn r23216) -Codechange: introduce the concept of having different tar lists 13 years ago
rubidium 7fd1e1df81 (svn r23198) -Codechange: introduce a free that takes const pointers so we don't need to cast to void/non-const before being able to free 13 years ago
rubidium 414c397000 (svn r22904) -Codechange: add tar filename to file scanning 13 years ago
rubidium 672df52e0c (svn r22835) -Codechange: keep track of the subdirectory we are looking through in the file scanner 13 years ago
rubidium 41169291e3 (svn r22834) -Codechange: unify some code, and extend it to work for other filenames that should end in a particular way 13 years ago
rubidium 2a12c9df2f (svn r22825) -Codechange: pass subdir to FioOpenFile 13 years ago
rubidium 0061b5f184 (svn r22822) -Codechange: make a distinction between base sets and newgrfs for their directory 13 years ago
smatz 564dc66131 (svn r22719) -Fix: compilation with gcc 4.7 13 years ago
alberth 89c7193b8f (svn r22709) -Doc: Doxyment fileio.cpp. 13 years ago
alberth d55b380b69 (svn r22669) -Codechange: For non-windows, only test for file existence again if strtolower actually changed the name. 13 years ago
alberth 20c2b5fdde (svn r22668) -Codechange: FioFindFullPath tests already whether the file exists. 13 years ago
glx 986d5e950d (svn r22502) -Fix (r22501): WIN32 compilation 14 years ago
alberth 6e3ef9fa1a (svn r22501) -Codechange: Move FileExists to a better place. 14 years ago
frosch b319fb31d5 (svn r22465) -Fix [FS#4613]: When determining the executable path failed, the working directory was used instead, circumventing the not-home-directory check. 14 years ago
alberth 990ec6f0a9 (svn r22460) -Doc: Semantic documentation fixes, and doxygen additions (partly by planetmaker). 14 years ago
rubidium f7b2a87292 (svn r21247) -Fix: make the tar scanner forget about old (possibly removed) tars 14 years ago
alberth 7e48d85104 (svn r21060) -Doc: Improved wording of comments (mostly by __ln__) 14 years ago
alberth 9f5a96ead2 (svn r20689) -Codechange: Make some global functions used in 1 .cpp file static in that file. 14 years ago
alberth be6c058424 (svn r20211) -Codechange: Indented code should have curly braces around it. 14 years ago
rubidium 5b1fc7304a (svn r20194) -Fix: compilation with network disabled failed 14 years ago
rubidium b8487afe54 (svn r20192) -Cleanup: bye bye variables.h, bye bye VARDEF... you won't be missed :) 14 years ago
rubidium eb30ebe1a4 (svn r20188) -Codechange: unVARDEF the _[config|log|highscore]_file variables and move them to a more logical location 14 years ago
rubidium 6863b7539c (svn r20166) -Fix [FS#3949]: do not scan /data and ~/data (if they happen to be your working directory). If it's the directory where your binary is located it will still scan them. 14 years ago
yexo 258ca28819 (svn r20055) -Feature: save/load hotkeys to/from hotkeys.cfg 14 years ago
rubidium 08919d2747 (svn r19779) -Change: add a return type to AppendPathSeparator and use that to determine whether we could append the path separator. If not, do not recurse into that directory as the path would exceed the maximum path length 15 years ago
rubidium 948beec597 (svn r19777) -Change: use the file scanner to find the .tars 15 years ago
smatz 0ef33548c2 (svn r19614) -Codechange: "it's" => "its" where appropriate 15 years ago
rubidium 4ba69b572d (svn r19427) -Codechange: gracefully handle the case where we can't open a .tar file. 15 years ago
rubidium 0f6d82df7e (svn r19262) -Feature: finalise BaNaNaS support for music sets 15 years ago
rubidium 77214378ca (svn r19248) -Fix: DOS 'port' did not compile anymore 15 years ago
rubidium ef90fa7d02 (svn r19151) -Codechange [FS#3625]: Move home directory to a better place in Haiku (jrepan) 15 years ago
smatz 2b8f7f2078 (svn r19000) -Cleanup: remove redundant check 15 years ago
rubidium 15adbad2f4 (svn r18834) -Fix [FS#3538]: compilation failed on OpenBSD (matze) 15 years ago
rubidium 91747d72dc (svn r18611) -Fix (r18608): uppercase-to-lowercase conversion when opening a file wasn't applied when finding the full path of a file 15 years ago
smatz a84921f8f5 (svn r18032) -Codechange: add one const 15 years ago
glx 85a910f02e (svn r18029) -Fix (r18028): AppendPathSeparator() should stay global 15 years ago
rubidium 860b9b1cea (svn r18028) -Codechange: unglobalise some functions 15 years ago
rubidium 3702746756 (svn r18026) -Codechange: make a lookup table static that doesn't need to be 'exported' 15 years ago
rubidium f76ef2f6ce (svn r17686) -Fix [FS#3247]: make the -c <config file> location relative to the current directory instead of the directory of the binary 15 years ago
rubidium e9624fe0cc (svn r17682) -Codechange: remove erroneous space before some commas 15 years ago
rubidium e8ddf001c8 (svn r17570) -Fix: a number of Doxygen warnings about missing parameters, which were sometimes missing and sometimes just typos 15 years ago
rubidium 7fbc33dae1 (svn r17248) -Fix: add GPL license notice where appropriate 15 years ago
rubidium 98b4f1fce2 (svn r16590) -Fix [FS#2967]: don't crash when tars/newgrfs are removed, just tell the file could be opened/found. 16 years ago
rubidium 168ae6f7e2 (svn r16422) -Codechange: use const_cast for removing const and warn when const is (accidentally?) removed using C-style casts. 16 years ago
rubidium 0d99b6c71c (svn r16421) -Codechange: do not unnecessarily remove constness or unnecessarily add it. 16 years ago
smatz f5316c5cbd (svn r16269) -Codechange: use gcc's ability to check parameters sent to printf-like functions
-Fix: wrong number of parameters or wrong parameter types sent to printf-like functions at several places
16 years ago
rubidium bee930f9b3 (svn r16024) -Codechange: harden string copying on places where it's possible 16 years ago
orudge bcc870e3f8 (svn r15745) -Fix: Resolve compile error in fileio.cpp on OS/2 - base paths on OS/2 behave much like DOS 16 years ago
rubidium b25a4f8231 (svn r15718) -Cleanup: apply some comment coding style on the rest of the sources too 16 years ago
rubidium f5c1365471 (svn r15641) -Fix: some gcc compilers seem to be chosing the C++ standard for strrchr, others the C standard... 16 years ago
rubidium 15e9fdd47a (svn r15615) -Feature: show scenarios/heightmaps from both your home directory and installation directory.
-Change [FS#2692]: make it more likely that scenarios are saved to the directory where openttd.cfg is and not the installation directory (gives problems with e.g. Vista). The working directory still overrides the openttd.cfg directory though, but only if it has a scenario directory.
16 years ago
rubidium a52d50c62f (svn r15612) -Codechange: unduplicate directory creation 16 years ago
rubidium 0d8da02ec1 (svn r15610) -Change: allow loading of heightmaps and savegames (any form) that are in .tar files 16 years ago
rubidium 4f3da358ee (svn r15607) -Codechange: support searching files without filtering on extension. 16 years ago
rubidium d1d0778a54 (svn r15606) -Codechange: make it possible to not recursively search with the file scanner (i.e. only search a single directory). 16 years ago