Commit Graph

21334 Commits (e2c5eb3b65ee420a664abfee5128bc89cce68ef1)

Author SHA1 Message Date
Peter Nelson 6f35f3274f
Fix ab1a4c6c: Crash if the "No Music" set is loaded because there is no current set_index. (#11511)
Add a helper function to get the current set_index which which checks it is in range.
10 months ago
rubidium42 27082f9efa Codechange: pass std::string references to OpenBrowser 10 months ago
Jonathan G Rennison 8437b20fed Fix: Deleting towns did not check for waypoints referencing the town 10 months ago
Peter Nelson 7b0afec11f Codechange: Use max_element to find highest cargo amount. 10 months ago
Peter Nelson 3f853d8003 Codechange: Use range-for to simplify getting first non-zero value.
This reduces indexed array access.
10 months ago
Tyler Trahan 4181d3c1ff Codechange: Don't use a magic number for the number of DiagDirections 10 months ago
Tyler Trahan 2dad9263d7 Doc: Add, fix, and clean up documentation inside town_cmd.cpp 10 months ago
Tyler Trahan 745945c4d3 Codechange: Be consistent with how we name common parameters
TileIndex is always tile and Town is always *t. Don't use t and *town.
10 months ago
Tyler Trahan 1b14eca9d9 Codechange: Rename TryClearTile() for clarity
The function does not execute the clearing action.
10 months ago
Tyler Trahan a98fe9f317 Codechange: Rename MakeTownHouseBigger() for clarity 10 months ago
Tyler Trahan 060672428d Codechange: Merge confusingly-named helper functions into their timer 10 months ago
Tyler Trahan 1f41e773d6 Codechange: Use consistent name for bay road stops
As of #10494, this is how we describe original dead-end road stops.
10 months ago
translators 5f442c9127 Update: Translations from eints
english (us): 1 change by 2TallTyler
10 months ago
Peter Nelson 519fe33175
Fix ab1a4c6c: Changing baseset/playlist while shuffle is on does not change song. (#11510)
The change-playlist function relied on toggling shuffle to restart playing which is no longer the case, so always handle it when changing playlist instead.
10 months ago
Peter Nelson e3924f3231
Fix #10811: Allow dragging vehicle in depot to any free row. (#11508) 10 months ago
Peter Nelson e6d132d24b
Fix #10926: New free wagons no longer split by type. (#11507)
NormalizeTrainVehInDepot() should only be called if an engine was built, not for wagons.
10 months ago
Peter Nelson 3df7d1aff9
Codechange: Template input buffer type in audio mixer. (#11505)
This reduces code duplication.
10 months ago
Peter Nelson e5aed24395
Codechange: Use std::array for industry tile cargo acceptance. (#11498)
This avoids use of memcpy/memset to copy or fill.
10 months ago
Peter Nelson f268c90bd3
Change: Use sparse padding for content download window. (#11501) 10 months ago
Peter Nelson ab1a4c6c80 Change: Don't restart playback when toggling playlist shuffle.
Instead update the selected playlist entry for the current song.
10 months ago
Peter Nelson 6c91c4b99d Fix: Invalidate playlist window when (un)shuffling playlist. 10 months ago
Peter Nelson 4c6ccb5248
Change: Try stopping extmidi player with SIGINT first. (#11404)
This may give the player a chance to issue MIDI note-off commands.

The kill/waitpid cycle is also less aggressive, waiting 50ms each time.
10 months ago
Peter Nelson e3622da408
Fix #11500: Rename Textfile GUI's LinkType to HyperlinkType. (#11502)
This disambiguates it with LinkType in league tables.
10 months ago
Peter Nelson 46098449b6
Fix 7cfcf65: cargo_filter_criteria is now a CargoID instead of a index. (#11497) 10 months ago
Peter Nelson 7bee955a4b
Change: Set height of larger heightmap/scenario worldgen buttons by text height. (#11496)
This allows the button height to scale properly by font size.
10 months ago
Jonathan G Rennison c5a292c0df
Fix #11493: Incorrect flow values in LinkGraphJob::EdgeAnnotation (#11494) 10 months ago
translators c6b9227dbb Update: Translations from eints 10 months ago
Tyler Trahan d28caa3ced Codechange: Use ticks for timetable start date 10 months ago
Tyler Trahan 3902acb13d Codechange: Define a TickCounter variable type for TimerGameTick::counter 10 months ago
Peter Nelson bc1d49ebf4 Codechange: Add missing `ar` from `Toolb`. 10 months ago
Peter Nelson 5489b9fc0c Codechange: Undo #11447, drop down list divider lines are now explicit. 10 months ago
Peter Nelson 667be98ce8 Codechange: List toolbar menu items and dividers explicitly.
This makes it clearer what items will be shown in the list, allows for non-consecutive
string IDs, and means unused enum values are not necessary.
10 months ago
Peter Nelson 47eabe0cd9
Fix 7cfcf65: Check if last-remembered build vehicle cargo filter is valid. (#11486)
This can be invalid when switching between games with different cargoes loaded.
10 months ago
Peter Nelson 096da3e59f
Fix #11407: Don't steal focus from dropdown menus. (#11484) 10 months ago
Peter Nelson 09d01bd015
Fix: Restore original cargo legend 'blob' dimensions. (#11480)
An off-by-one in a previous life made the 'blob' too narrow.
10 months ago
Peter Nelson c2f19fed24
Fix: Widget without tooltip should use STR_NULL not STR_EMPTY. (#11482) 10 months ago
Peter Nelson c18a1494b7
Codechange: Remove FONT_HEIGHT_... macros. (#11481)
These make it look like we're dealing with a constant, but actually each is a call to `GetCharacterHeight(...)`.
10 months ago
translators 96ec9c1b47 Update: Translations from eints
indonesian: 67 changes by ekaknl22
10 months ago
Peter Nelson 0d60dc0353 Fix 96d98d08: Crash in text layouter due to trying to find height of string with zero-width.
96d98d08 removed the hardcoded minimum width in favour of all-calculated widths, however this does not work when determining multiline text sizes.
10 months ago
Peter Nelson 62d4fd0572 Codechange: Add method to guess the width/height required for a multiline string.
This is necessary for widget layouts where a minimum width is not yet known during UpdateWidgetSize().
10 months ago
Peter Nelson f281525492 Codechange: Add method to resize both width and height of a widget. 10 months ago
Peter Nelson d04fd4602d Codechange: Assert that max width passed to GetStringHeight is non-zero.
Max width of zero will cause text layouters to crash, potentially after exhausting memory first.
10 months ago
Peter Nelson 0578b8eaa9
Change: Use picker-spacing for scenario found town window. (#11478) 10 months ago
Peter Nelson a58a043402
Fix 6065122: Missing SetFill on worldgen spacer. (#11477) 10 months ago
Jonathan G Rennison 9822fa6584
Fix: Trivial autoreplace of mixed cargo articulated engines (#11253)
Do not fail autoreplace/autorenew of mixed cargo articulated engines
due to an inability to refit to mixed cargoes, when no refit is
required because the target engine already has a suitable set of cargoes.
Notably, this allows autorenew (autoreplace to same engine type)
to succeed.
10 months ago
Peter Nelson 96d98d08c8
Change: Use sparse padding for main intro menu. (#11475) 10 months ago
Peter Nelson c80fa7d752
Codechange: Simplify setting minimum width for game options dropdown lists. (#11474)
Height isn't necessary as drop down controls already have sufficient height, so we can use GetDropDownListDimension() to get the width.
10 months ago
Peter Nelson f58a7ef673
Codechange: Remove now-unnecessary containers in picker layouts. (#11473)
These are no longer necessary as the issue they work around was resolved by #11471
10 months ago
Peter Nelson 293a26f248
Change: Use sparse padding and SETTING_BUTTON sizes for custom currency window. (#11472) 10 months ago
Peter Nelson 05b55c4d43
Fix: Extra space allocated to container-within-container may not get allocated to children. (#11471)
Always derive additional length from contained widgets instead of from the container, as the container's minimal length may have been adjusted by an NC_EQUALSIZE parent container.
10 months ago