Commit Graph

53256 Commits

Author SHA1 Message Date
Jonathan G Rennison
dbc55274e2 Debug: Show callback ID names in sprite dump 2022-07-31 19:28:35 +01:00
Jonathan G Rennison
7af568f0f0 VarAction2: Handle case where expensive vars are only conditionally read
Within a JZ_LV and in prior DSGAF_SKIP_ON_ZERO op
2022-07-31 00:16:40 +01:00
Jonathan G Rennison
9a4c31b0da VarAction2: Add last_value variants of JZ/JNZ ops 2022-07-30 23:32:23 +01:00
Jonathan G Rennison
cbc6199542 VarAction2: Add a JNZ op analogous to JZ for OR ops 2022-07-30 22:40:41 +01:00
Jonathan G Rennison
5ec802a3d4 VarAction2: Allow substituting perm store loads through temp store 2022-07-30 21:17:00 +01:00
Jonathan G Rennison
cbabbb6db6 Fix train braking behaviour when lookahead is aspect limited
When lookahead end is within the reservation end
2022-07-30 20:39:16 +01:00
Jonathan G Rennison
71b6d7a502 Merge branch 'master' into jgrpp
# Conflicts:
#	src/lang/arabic_egypt.txt
#	src/station_cmd.cpp
#	src/station_cmd.h
#	src/timetable_cmd.cpp
#	src/train_cmd.cpp
2022-07-30 20:38:34 +01:00
translators
ccb9d99880 Update: Translations from eints
arabic (egypt): 13 changes by AviationGamerX
persian: 16 changes by pooyana84
finnish: 33 changes by lanurmi
2022-07-29 18:55:22 +00:00
translators
e3759931e7 Update: Translations from eints
english (us): 1 change by 2TallTyler
arabic (egypt): 62 changes by AviationGamerX
turkish: 1 change by ahmetlii
2022-07-28 18:56:27 +00:00
translators
97d79c8e52 Update: Translations from eints
spanish (mexican): 1 change by absay
catalan: 1 change by J0anJosep
2022-07-27 18:54:03 +00:00
Jonathan G Rennison
c6817fab6e Don't use implicit orders for conditional order waiting loops
Fixes vehicles never leaving when the only order is an implicit order
(because vehicles were released with no orders)
2022-07-26 20:35:12 +01:00
translators
d1d7e47896 Update: Translations from eints
russian: 1 change by Ln-Wolf
portuguese: 1 change by azulcosta
2022-07-25 18:56:07 +00:00
Jonathan G Rennison
70ef4c6d90
Merge pull request #407 from auge8472/lang-de
Translated most of the missing strings for German language, stand jgrpp 0.48.0
2022-07-25 18:14:34 +01:00
translators
77a8e3b649 Update: Translations from eints
polish: 1 change by pAter-exe
2022-07-24 18:55:01 +00:00
Heiko August
12aa409332 Change: translated most of the missing strings for German language 2022-07-24 19:38:07 +02:00
Nicolas Chappe
6d154e72dd Fix #8584: Vehicles with shared orders getting invalid or unexpected start dates 2022-07-24 09:28:01 +02:00
translators
67608350b6 Update: Translations from eints
finnish: 45 changes by lanurmi
portuguese (brazilian): 29 changes by rodigu
2022-07-23 18:52:50 +00:00
Jonathan G Rennison
67331fe946
Fix #9951: Scenario editor random industries button and persistent storage (#9952)
BasePersistentStorageArray::SwitchMode was not called
2022-07-21 16:21:38 +01:00
translators
8f772352ce Update: Translations from eints
italian: 1 change by Rivarossi
2022-07-20 18:57:16 +00:00
translators
b199779ad4 Update: Translations from eints
chinese (simplified): 26 changes by ZZY2357
korean: 1 change by telk5093
2022-07-19 18:55:56 +00:00
Jonathan G Rennison
0735c4b851 Ensure that disabling infra sharing can't break realistic braking reservations 2022-07-15 21:48:41 +01:00
Jonathan G Rennison
856cea576f Fix infrastructure sharing checks not being executed when disabling 2022-07-15 21:48:41 +01:00
Jonathan G Rennison
27d4900fde Fix text colour for infrastructure sharing error messages 2022-07-15 21:38:57 +01:00
Jonathan G Rennison
dc01d0cac4 Handle case where deleting a company removes part of a train's reservation
When realistic braking is enabled, which would ordinarily prevent
the track from being removed
2022-07-15 17:47:11 +01:00
Jonathan G Rennison
ed737e1a8f VarAction2: Do not remove redundant adjusts when this would break var 1C 2022-07-14 23:57:23 +01:00
Jonathan G Rennison
b9c22a0b9e VarAction2: Do not prune groups when this would break var 1C 2022-07-14 23:47:48 +01:00
Jonathan G Rennison
ae746a1af4 VarAction2: Fix tracking of whether a sprite group needs var 1C 2022-07-14 23:38:52 +01:00
Jonathan G Rennison
e497f0e78d Fix crash in tooltip window UpdateWidgetSize due to not using saved string 2022-07-14 23:21:23 +01:00
Jonathan G Rennison
cd4a9fba68 Fix viewport map mode bridges/tunnels not appearing dotted at high zoom 2022-07-14 23:06:15 +01:00
Jonathan G Rennison
9be7fef875 Documentation: Fix road stop one way state variable values 2022-07-14 17:38:13 +01:00
Patric Stout
77a85e9b4c
Fix: CmdSetAutoReplace didn't validate group type and engine type match (#9950)
Basically, you could setup an auto-replace in a group for trains
to replace a ship with another ship.

Most of the code is surprisingly okay with this, it is only the
group statistics that doesn't like this.
2022-07-09 20:06:22 +02:00
Patric Stout
979704271b
Fix: reverse train direction command did not validate the given vehicle properly (#9947)
You could give a wagon in the chain to reverse (which makes no
functional sense ofc). In result, only parts of the vehicle were
reversing, leading to weird crashes.
2022-07-09 12:28:20 +02:00
Patric Stout
055121df80
Fix: depot-related commands did not validate depot tiles properly (#9948)
The bug comes in two slices:

1) the functions never actually checked if "tile" was a depot tile.
   This allowed executing the function on tile 0, where are the
   things like shadows of aircrafts are.
2) BuildDepotVehicleList() first checked if a vehicle is in a depot
   before checking if it was a primary vehicle. This is invalid
   for aircraft.

Fixing the first hides the second, and fixing the second makes the
first non-exploitable. But, fixing both felt like the best thing
to do.
2022-07-09 12:28:09 +02:00
Patric Stout
100aca1848
Fix: CmdRemoveRoadStop didn't validate the height property properly (#9945)
Height was a unsigned 32bit integer, where TileAddWrap uses a
signed 32bit integer for the height. In result, there was an
implicit cast from unsigned to signed, messing things up.

But looking at it from a functional perspective, allowing such
large values is not sensible. In fact, width is restricted to
just a 8bit integer. By changing height to a 8bit integer too,
the implicit cast will never make a positive value negative anymore.
2022-07-09 12:27:58 +02:00
Patric Stout
9957675a66
Fix: autoreplace command did not validate the vehicle argument properly (#9946)
It first checked if the vehicle was in the depot, which for some types
is only a valid action for the primary vehicle. Afterwards, it checked
if the vehicle was a primary vehicle.
2022-07-09 11:25:17 +02:00
Patric Stout
4651ad94fe
Fix: commands with a RoadType in their arguments were not validated properly (#9944)
Although it was checked that RoadType was not 63 (INVALID_ROADTYPE),
and all values lower than 63 are fine, it also allowed values higher
than 63. As the RoadType is a "byte", it could contain values up
to 255.
2022-07-09 10:03:57 +02:00
Patric Stout
6810d09c1b
Fix: commands with Axis in their arguments were not validated properly (#9943)
When you don't type an Enum, it is a signed value. To validate
if an Axis is valid, it is checked to be lower than AXIS_END. Which
is the case for any value below 0.
2022-07-09 10:03:41 +02:00
Michael Lutz
dd93244853 Fix: The first tile in commands received from a client wasn't validated properly. 2022-07-08 22:37:41 +02:00
Jonathan G Rennison
23e057cfac Don't apply show signals using default graphics settings for custom styles 2022-07-05 18:14:52 +01:00
Jonathan G Rennison
23bd1cb567
Merge pull request #404 from telk5093/jgrpp
Update: Korean translation up to 0.48.0
2022-07-04 22:48:59 +01:00
TELK
f2838768ca Update: Korean translation up to 0.48.0 2022-07-04 20:57:03 +09:00
TELK
3cace09207 Update: Match the lines of Korean lang. file with english's one 2022-07-04 20:57:03 +09:00
Jonathan G Rennison
96c63ab7fc Remove incorrect comment 2022-07-03 22:15:58 +01:00
Jonathan G Rennison
c851c7a797 Documentation: Remove incorrect note about new landscape variables 2022-07-03 22:15:49 +01:00
Jonathan G Rennison
7c37208777 Correct spelling error in readme 2022-07-03 19:12:45 +01:00
Jonathan G Rennison
8c8dcb0002 Version: Committing version data for tag: jgrpp-0.48.0 2022-07-03 18:26:18 +01:00
Jonathan G Rennison
752e46dfcb Merge branch 'master' into jgrpp
# Conflicts:
#	src/station_cmd.cpp
2022-07-03 17:42:54 +01:00
glx22
44e3b05c50 Fix: Use more selectivity when building SSE specific code
See: https://github.com/OpenTTD/OpenTTD/issues/9935

(cherry picked from commit c3f55d53405af04bfe928d9e1a815e06c187ca50)
2022-07-03 17:38:16 +01:00
Jonathan G Rennison
432717b21d Enabled shared orders and occupancy buttons for competitor order windows 2022-07-03 17:32:03 +01:00
Jonathan G Rennison
4e8a8a5e0a Add conditional order to test if last/next dispatch slot is first/last 2022-07-03 15:49:29 +01:00