d70fb74ac6
Codechange: use setting name instead of index for CmdChange(Company)Setting ( #9306 )
...
This is mostly done as there are now constraints on settings.ini you might not
expected. For example, conditional settings always have to come last, as otherwise
they would influence the index.
3 years ago
5799402f7a
Codechange: Rename window related DeleteXXX to match new behaviour
3 years ago
994bf19aef
Fix f6d5c01: Delay deletion when closing windows
3 years ago
ef991b1772
Codechange: [Network] Use std::string in CommandPacket
3 years ago
2e136285e1
Codechange: move from C-string to std::string for DoCommand
3 years ago
661728558e
Codechange: let IsUnique.* functions accept std::string
3 years ago
b4aedef848
Codechange: add std::string variant of Utf8StringLength
3 years ago
0125ba82e8
Fix: Do not send vehicles towards incomplete PF nodes
...
YAPF could end up in a situation where it sets the best intermediate node
to a node whose construction is never finalized (i.e. it is never added to
the open list). The content of the node would be overwritten in the next
round, potentially sending the vehicle to an unwanted location.
3 years ago
7713c3e3cc
Codechange: move casting a "const char *" to "char *" to the caller
...
It is not nice to have your definition say you won't change a value
while in fact the whole reason for your existance is to change it.
3 years ago
665e3c1f45
Fix: ScriptObject::DoCommand could modify "text" while defined "const"
...
This could have unwanted side-effects, as it could change the
source for ever and ever.
3 years ago
b0f44d7eb1
Doc: describe what each settings-file is about
3 years ago
e58046c947
Codechange: move all settings.ini files to table/settings
3 years ago
ca9a7df752
Codechange: rename str_validate to StrMakeValid(InPlace) ( #9304 )
...
This to be more explicit the function changes the value, and not
returns yes/no.
3 years ago
4d74e51907
Fix #9281 : acquire a company uses special bookkeeping to make you rich ( #9300 )
...
When you buy-out a company, you got your shares back. This is
based on company-value, which includes values for the vehicles etc.
In other words, you not only got the vehicles, but you also got
paid to get them back.
Additionally, you also got the loan of the company, but not the
money for the loan (as that is subtracted from the company-value).
Solve this by changing the rules of a buy-out: don't sell your
shares, get the loan AND the balance and get the infrastructure.
3 years ago
4c0e083128
Cleanup: set the base in the setting templates, instead of defining the base for every setting
...
This has the added benefit of not getting mistaken that multiple bases can be used for the same SettingTable
3 years ago
4144e949ed
Fix: [Network] Prevent an empty server name to be set anywhere
3 years ago
08308d808c
Codechange: use separate pre and post callbacks for int settings
3 years ago
e2f5d9e561
Codechange: use separate pre and post callbacks for string settings
3 years ago
ea9715d970
Codechange: split Write_ValidateSetting to get separate functions for making ints valid and writing ints
3 years ago
208952f2ba
Codechange: split Write_ValidateSetting to get separate functions for making strings valid and writing strings
3 years ago
ce1c60699a
Update: Translations from eints
...
norwegian (bokmal): 3 changes by Anolitt
dutch: 3 changes by Afoklala
portuguese (brazilian): 3 changes by Vimerum
3 years ago
7b5c0b4236
Update: Translations from eints
...
chinese (traditional): 9 changes by benny30111
english (us): 3 changes by 2TallTyler
3 years ago
7648483364
Change: by default, make "unload all" leave stations empty ( #9301 )
3 years ago
8372c679e3
Codechange: add helper functions to read an int setting value
3 years ago
86c9ef8134
Codechange: remove SettingDescType in lieu of the actual classes
3 years ago
e666a962b1
Codechange: let OneOfMany and ManyOfMany be their own classes as well
3 years ago
860003458f
Codechange: make BoolSettingDesc its own sub class
3 years ago
72ec81325b
Cleanup: remove unneeded temporary variables and casts
3 years ago
0d6597a9e6
Codechange: move bits of SettingDesc down to the appropriate sub classes
...
And by doing so remove the hack where ints were put into pointers so "def" could either be an int or a string
3 years ago
f58611298e
Codechange: use IntSettingDesc in the settings GUI
3 years ago
f6723b53da
Codechange: make parsing of IniItems overridable functions of SettingDesc
3 years ago
1f8ff0e4f9
Codechange: make Write_ValidateSetting a function of StringSettingDesc
3 years ago
be28c95b30
Codechange: make Write_ValidateSetting a function of IntSettingDesc
3 years ago
024e584904
Cleanup: use (config) formatting for console settings functions
3 years ago
c3cd4a683d
Codechange: make formatting of values into strings a method of SettingDesc
3 years ago
d8125fa46e
Codechange: make sub classes of SettingDesc for the different types of settings
3 years ago
91b3d697c5
Codechange: make SettingDesc an instance in the setting table to allow for sub classes
3 years ago
cf6b91f30f
Codechange: do not use SettingDescBase directly when not needed
3 years ago
3bb6ce8827
Codechange: use initializer_lists for the settings tables
...
Not using vectors as those require copying from the initializer list and that
makes unique_ptrs to the actual SettingDesc objects later impossible.
3 years ago
425d50372f
Codechange: let SettingDesc extend SettingDescBase
3 years ago
ac99a38175
Cleanup: remove and/or fix some confusing comments
...
The comments for SettingDescType; it is a byte, so not 4 bytes and since it is not a flag there are about 250 other possibilities left instead of 9.
SettingGuiFlag is uint16 so has 2 bytes allocated.
SettingDescGlobVarList and related comments imply that global vars cannot be used elsewhere, but they are used for settings just fine. Even then the type is not used anywhere else but the definition of the table.
3 years ago
8ffb4122df
Codechange: just pass the SettingDesc to SetSettingValue and remove distinction between (non)company
3 years ago
db54e20825
Change: mark copy-assignment as deleted for classes with a copy-constructor that is not trivial
...
This to prevent the default copy-assignment getting used when during the assignment also some other memory needs to be allocated as that would otherwise be freed.
3 years ago
9197de39e4
Cleanup: remove unused copy-constructor without copy-assignment
3 years ago
6fe4d4ad7b
Codechange: linkgraph always iterates with NodeIDs over the Size(), so make Size() the same type to prevent infinite loops
3 years ago
ed9e38221a
Cleanup: remove dead code; ++ on ostreambuf_iterator is a no-op
3 years ago
b280f16316
Codechange: remove unneeded comparison and casts
...
Division by resize_y is already yielding an unsigned number, so when clicking in the WD_FRAMERECT_TOP you would already get a huge value, so sel would never be negative. So, leave sel an unsigned number and remove the <= check.
3 years ago
b9797a81c0
Codechange: pass large parameter by reference instead of value, especially in a recursive function
3 years ago
b791ffc6de
Fix: do not hide parameter by local variable with the same name
3 years ago
eaa3df1e8e
Fix: part of a tile might not be marked dirty upon terraforming
3 years ago
Patric Stout
glx22
rubidium42
Vít Šefl
translators