Archives/readability
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
292 Commits 14 Branches 0 Tags 29 MiB
8525c6af36
Commit Graph

292 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Brad Philips
8525c6af36 Fix relative URIs given <base> tags (#422) 2018-03-02 11:38:14 +00:00
Gijs Kruitbosch
d598baf02b Improve URL handling in JSDOMParser and Readability.js 
This change ups the required node version to 7.0 because it relies on the builtin url module.

We now pass a url when constructing a jsdom document or JSDOMParser document.
Because this is an API change, I'm increasing the package version.

Ultimately, I would like to remove the  argument from the readability constructor. It should
use the documentURI from the document it is passed.
 2018-02-28 11:29:29 +00:00
Andres Rey
834672ef86 Return longest text after failing to detect text longer than the configured value (#423) 
Save extracted text across attempts and return the longest one when all attempts fail, and add a test case from hukumusume
 2018-02-27 14:26:54 +00:00
Tom Z?hner
264b8e8968 Remove link elements when preparing article for display 2018-01-30 15:11:59 +00:00
Thomas Jaggi
fd1557560a [Docs] Fixed JSDOM usage note 2018-01-02 22:12:53 +00:00
Andres Rey
fa9d8bda48 Add la-nacion test case 2017-12-11 14:00:48 +00:00
Andres Rey
01ffd0c617 Remove "modal" from strings to remove 2017-12-11 14:00:48 +00:00
Gijs
8da91b9eed
Fix omitted semicolon 2017-12-05 13:22:32 +00:00
Gijs
0a30527c85
Explicitly mention lack of Node in node.js environments 2017-12-05 13:22:01 +00:00
Gijs Kruitbosch
807bf05aa3 Fix className usage so it deals correctly with SVG nodes (fixes #412). 2017-12-05 11:06:39 +00:00
Gijs Kruitbosch
c586aeb404 Fix generate-testcase.js script so it keeps caption classes 2017-11-30 10:41:15 +00:00
Gijs Kruitbosch
ad4dd26448 Update test expectations 2017-11-30 10:41:15 +00:00
Gijs Kruitbosch
092a8aeaff Revert removing ids from elements 2017-11-30 10:41:15 +00:00
Andres Rey
eb895b97a2 Add test case for title and h1 discrepancy 2017-11-27 15:53:38 +00:00
Andres Rey
9ce4d87232 Fall back to the original title if after trimming the text we have too many words before the colon. 2017-11-27 15:53:38 +00:00
Andres Rey
c2e370c2c7 Add telegraph test case 2017-11-22 21:14:14 +00:00
Andres Rey
5a5c8ba1a2 Add node to elementsToScore when _hasSinglePInsideElement is true 2017-11-22 21:14:14 +00:00
Cameron McCormack
5ad448f831 Update test expectations. 2017-11-21 10:04:59 +00:00
Cameron McCormack
d88c9afc63 Use a hard coded classesToPreserve in tests. 2017-11-21 10:04:59 +00:00
Cameron McCormack
6729538c77 Clean IDs and classes from output. 2017-11-21 10:04:59 +00:00
Tomas Dvorak
19b9f9de14 added npmignore for test and benchmarks resources 2017-11-13 13:32:23 +00:00
Björgvin Ragnarsson
c3ff1a2d2c remove dead code 2017-11-02 23:15:13 +00:00
Iqbal Ahmed
b3fde168cb Allow the word threshold parameter to be configurable 2017-09-19 15:38:10 +01:00
Taylor Hunt
b7c32feb25 Remove presentational HTML attributes (#385) 
* Remove presentational HTML attributes

Fixes #383

This patch loops through a list of known-presentational attributes in HTML, attempting to remove each from each cleaned element. (Checking for the attribute's existence first seems to just add needless overhead.)

The extra check for the HTML namespace is to avoid removing attributes that inline SVG needs.

* Only remove `width`/`height` for certain elements

Embedded media elements are allowed to have them, but not others.

* Address PR feedback

* Fix loop index formatting
* Only remove `width`/`height` from certain elements
* Combine logic into a single check/remove

* Attempt fixing my recursion

* One weird trick to get your loops to run

* Add inline SVG bailout

Try not to touch any styles for `<svg>`, because it's inherently presentational.

* Update tests to match newly-removed attributes

* Oh those wacky SVGs

The `position:absolute` is a trick to import clipping paths into the document without putting a big 300×150 empty space in it. (`display:none` and such disable the clipPath in some browsers.)

* Whoops, missed some `width`s

* Normalize SVG tagName

JSDOMParser differs from the official DOM here
 2017-08-09 20:26:34 +01:00
Gijs Kruitbosch
6f0bd81dfa Provide more useful output when attributes mismatch, r=me,test-only 2017-08-09 20:05:47 +01:00
Gijs Kruitbosch
c387d12bc4 Fix eslint issue by unpacking ternary into a proper if statement 2017-07-17 13:25:56 +01:00
Gijs
bfd14522c4 Update eslint to try to fix issues on infra 2017-07-17 13:08:19 +01:00
Gijs
f6443ed18b Match node version from package.json in travis.yml 2017-07-17 12:49:57 +01:00
Gijs
264946aa15 Require Node >=6.5 to have .includes available 
Per #382 and http://node.green/, 6.5 should be necessary/sufficient.
 2017-07-17 11:54:22 +01:00
SahilAgarwal321
f0edc77cb5 Fixed bugzilla bug list link 2017-05-05 19:08:19 +01:00
Gijs
ab09b706ed Mention you need a DOM document object 
Per #376 it doesn't seem to be clear that you need a DOM to use Readability. This is an attempt to include this information in the README.
 2017-04-26 12:32:19 +01:00
Evan Tseng
924017c686 Merge pull request #370 from evanxd/bug-1347472 
Bug 1347472 - Tests for WordPress blogs, r=Gijs
 2017-03-17 11:09:14 +08:00
Evan Tseng
f6d0840b82 Bug 1347472 - Tests for WordPress blogs, r=Gijs 2017-03-15 17:46:07 +08:00
Evan Tseng
9561aff883 Merge pull request #368 from evanxd/bug-1346717 
Bug 1346717 - Tests for youth.cn, r=Gijs
 2017-03-14 11:29:16 +08:00
Evan Tseng
0e147aa722 Bug 1346717 - Tests for youth.cn, r=Gijs 2017-03-13 17:43:50 +08:00
Evan Tseng
630a0b7367 Bug 1346155 - Tests for gmw.cn, r=Gijs 2017-03-10 10:51:28 +00:00
Evan Tseng
fe6f7a4910 Merge pull request #362 from evanxd/bug-1345797 
Bug 1345797 - Tests for yahoo.co.jp, r=Gijs
 2017-03-10 11:36:09 +08:00
Evan Tseng
8976fb08bf Bug 1345797 - Tests for yahoo.co.jp, r=Gijs 2017-03-09 18:01:31 +08:00
Evan Tseng
3e07e06b1c Merge pull request #358 from evanxd/bug-1342355 
Bug 1342355 - Add tests for wikia.com, r=Gijs
 2017-03-01 16:59:15 +08:00
Gijs Kruitbosch
a63e63c91e Clarify title-splitting code (part of #357) 
This adds a number of comments and a wordCount helper function to try to make the code
a bit more readable (which seemed appropriate considering the number of regular expressions).
 2017-02-27 14:56:26 +00:00
Farbdose
aed7f10594 Remove general part of title when viewing websites with hierarchical titles 2017-02-27 14:56:26 +00:00
Gijs
5e56271e45 Add eslint into "Tests" section as well. 2017-02-27 14:14:13 +00:00
Gijs
b49483c772 Fix some formatting/grammar snafus 2017-02-27 14:12:15 +00:00
Gijs
eca9bd0cdd Clarify use of testcase generation script a little 2017-02-27 14:11:09 +00:00
Gijs
286f94bb35 Point to automated tests and eslint in readme 2017-02-27 14:08:17 +00:00
Evan Tseng
e48451c48c Bug 1342355 - Add tests for wikia.com, r=Gijs 2017-02-24 18:07:24 +08:00
Evan Tseng
c7c26382b9 Bug 1217007 - Remove nodes without any content, r=Gijs 2017-02-22 09:41:49 +00:00
Evan Tseng
0f147374b7 Bug 1323861 - Remove the readScript method, r=Gijs 2017-02-22 09:39:17 +00:00
Evan Tseng
27b97434a3 Merge pull request #352 from evanxd/bug-1338468 
Bug 1338468 - Tests for tumblr.com, r=Gijs
 2017-02-21 18:19:46 +08:00
Evan Tseng
913ecc7c31 Merge pull request #353 from evanxd/bug-1338475 
Bug 1338475 - Tests for pixnet.net, r=Gijs
 2017-02-21 18:03:53 +08:00