Nicolas Perriault
4424b0bad7
Refs #128 - Add support for options to Readability constructor. r=@gijsk
2015-04-09 11:56:58 +02:00
Nicolas Perriault
d9fc21155e
Merge pull request #123 from gijsk/fix-test-result-stream2
...
Fixed test result output being sent at once
2015-04-08 17:07:41 +02:00
Gijs Kruitbosch
c53ca31907
Fixed test result output being sent at once
2015-04-08 15:24:34 +01:00
Gijs
0251bc0817
Merge pull request #120 from mozilla/drop-social-buttons
...
Refs #117 - Drop social/share buttons.
2015-04-08 13:40:26 +01:00
Nicolas Perriault
4d41f5e4ed
Refs #117 - Drop social/share buttons.
2015-04-07 23:00:52 +02:00
Nicolas Perriault
56b45e3fa9
Merge pull request #100 from mozilla/fix-jsdomparser-localName-case
...
Fixes #99 - Fixed JSDOMParser tag name case handling.
2015-04-07 14:22:18 +02:00
Nicolas Perriault
d725ebc953
Fixes #99 : JSDOMParser tag name case handling. r=@gijsk
2015-04-07 14:19:54 +02:00
Gijs
3aa212547f
Merge pull request #80 from mozilla/fix-readability-to-work-with-real-dom
...
Fix readability to work with real dom (fixes #72 )
2015-04-03 22:49:24 +01:00
Gijs Kruitbosch
a04f9d9a68
Fix embedded video testcase to work with both jsdom and JSDOMParser
2015-04-03 22:42:29 +01:00
Gijs Kruitbosch
225adef137
Turn off JS when using JSDOM in tests.
2015-04-03 22:42:29 +01:00
Gijs Kruitbosch
b1f6c62b25
Fix tests for readability to also work with jsdom
...
For instance, jsdom's more spec-compliant parsing causes issues with auto-closing elements (lifehacker article) and with not having self-closing <img> and <br> tags. The former was fixed by removing offending markup, the latter by adjusting JSDOMParser to be more sane, and the expected outputs to cope with this.
Finally, JSDOMParser automatically drops comments. The test code needed to manually do this in the jsdom case.
2015-04-03 22:41:55 +01:00
Gijs Kruitbosch
7c60dba3b6
Fix Readability.js to work with jsdom's DOM implementation (in particular: no firstElementChild implementation...)
2015-04-03 22:32:13 +01:00
Gijs Kruitbosch
62801faa0e
Fix JSDOMParser to do some HTML escaping and identify as JSDOMParser + add tests
2015-04-03 22:32:06 +01:00
Margaret Leibovic
0f2f61d0a6
Merge pull request #96 from mozilla/isprob
...
Bug 1150695 - Move isProbablyReaderable function to Readability.js
2015-04-03 11:04:47 -04:00
Nicolas Perriault
3b636b59f0
Added readerable value to test pages metadata.
2015-04-03 15:14:49 +02:00
Margaret Leibovic
6b7834f798
add test for isProbablyReaderable
2015-04-02 17:40:06 -04:00
Margaret Leibovic
eb3a8e8dc4
Bug 1150695 - Move isProbablyReaderable function to Readability.js
2015-04-02 17:39:43 -04:00
Gijs
7430df7f23
Merge pull request #94 from mozilla/benchmark-folder
...
Fixed broken benchmark reporter code, moved benchmark code to its own folder
2015-04-02 14:51:10 +01:00
Nicolas Perriault
360c648579
Fixed broken benchmark reporter code, moved benchmark code to its own folder.
2015-04-02 15:43:09 +02:00
Gijs
c2b40ab630
Merge pull request #91 from gijsk/benchmark-avg-ops-and-readability
...
Add benchmark for readability and show averages by using custom reporter
2015-04-02 13:12:36 +01:00
Gijs Kruitbosch
02b7db3f7e
Add benchmark for readability itself instead of just JSDOMParser, add averages so the results are scannable.
2015-04-02 13:12:10 +01:00
Gijs
e51457d787
Merge pull request #90 from mozilla/benchmarks
...
Added benchmarks to be able to keep track of the speed of the parser and readability.
2015-04-01 23:05:05 +01:00
Nicolas Perriault
2bfa678cab
Added separate command for reference benchmark.
2015-04-01 22:35:06 +01:00
Nicolas Perriault
1e14d47bb7
Added benchmarks.
2015-04-01 21:58:42 +02:00
Gijs
f2b04930c1
Merge pull request #87 from gijsk/script-parsing-should-deal-with-comments
...
Fix script parsing to ignore closing tags in comments
2015-04-01 11:45:03 +01:00
Gijs Kruitbosch
8ddba60425
Fix script parsing to ignore closing tags in comments
2015-04-01 11:12:16 +01:00
Gijs
87e4fbb612
Merge pull request #82 from mozilla/keep-images
...
Fixes #81 - Keep article images.
2015-03-31 18:27:20 +01:00
Nicolas Perriault
f8d37e4276
Don't remove elements containing figures or having them as a parent.
2015-03-31 19:12:45 +02:00
Nicolas Perriault
b6730703a1
Fixes #81 - Keep article images.
2015-03-31 18:46:04 +02:00
Margaret Leibovic
0b3bce57bf
Merge pull request #86 from gijsk/fix-innerHTML-children
...
Fix innerHTML's children setter
2015-03-31 09:47:26 -04:00
Gijs Kruitbosch
cdcbd94cd5
Add tests for the lifehacker page
2015-03-30 20:52:05 +02:00
Gijs Kruitbosch
bc7873d313
Fix innerHTML children assignments to help fix issue #76 .
2015-03-30 15:57:16 +02:00
Gijs
194a5376c8
Merge pull request #63 from mozilla/preserve-embedded-tweets
...
Preserve inline tweets as they're part of article contents.
2015-03-25 13:57:34 +00:00
Nicolas Perriault
ec491127f4
Merge pull request #70 from gijsk/fix-parent-score-nullcheck
...
Fix an issue where we don't track scores for the parents appropriately.
2015-03-23 16:08:43 +01:00
Gijs
5eebd57d71
Merge pull request #69 from mozilla/print-err-stack-on-generation-failure
...
Log the exception stack trace when a test case generation fails
2015-03-23 15:02:05 +00:00
Nicolas Perriault
aeeabb7c79
Print exception stack when generating a test case fails.
2015-03-23 15:59:06 +01:00
Gijs Kruitbosch
b4332328f3
Fix an issue where we don't track scores for the parents appropriately.
2015-03-23 14:57:04 +00:00
Gijs
14b33b69db
Merge pull request #65 from mozilla/support-embed-videos
...
Fixes #56 - Updated support for embedded Youtube & Vimeo videos.
2015-03-23 14:48:00 +00:00
Gijs
b8b620631d
Merge pull request #68 from mozilla/fix-base-urls
...
Fixes #53 - Fixed dot-slash relative URI resolution.
2015-03-23 14:45:00 +00:00
Nicolas Perriault
ad52d8ee30
Fixes #53 - Fixed dot-slash relative URI resolution.
2015-03-23 12:54:46 +01:00
Nicolas Perriault
2d5f59f3eb
Fixes #56 - Updated support for embedded Youtube & Vimeo videos.
2015-03-23 10:07:04 +01:00
Gijs
f9ea568f3f
Merge pull request #64 from mozilla/fix-readme-with-tests
...
Updated README about tests.
2015-03-22 22:08:49 +00:00
Nicolas Perriault
c24821c247
Updated README about tests.
2015-03-22 18:29:05 +01:00
Nicolas Perriault
d83763c8a1
Preserve inline tweets as they're part of article contents.
2015-03-22 18:19:34 +01:00
Nicolas Perriault
9510715723
Merge pull request #61 from mozilla/strip-embed-tags
...
Refs #58 - Stripped embed tags.
2015-03-22 18:10:50 +01:00
Nicolas Perriault
cf3dce6cf2
Refs #58 - Stripped embed tags.
2015-03-22 17:52:23 +01:00
Gijs
6ad9dd9952
Merge pull request #52 from mozilla/forEach-loops
...
Use forEach when it makes sense.
2015-03-22 09:25:50 -07:00
Nicolas Perriault
eee224560b
Addressed review comments from @Gijsk.
2015-03-21 18:05:58 +01:00
Nicolas Perriault
4f9615cb9a
Use forEach when it makes sense.
2015-03-21 15:10:00 +01:00
Gijs
f7c0e4713f
Merge pull request #51 from gijsk/fix-medium-title
...
Fix the title to not update when we already have one
2015-03-20 20:34:38 -07:00