092a8aeaff
Revert removing ids from elements
7 years ago
eb895b97a2
Add test case for title and h1 discrepancy
7 years ago
9ce4d87232
Fall back to the original title if after trimming the text we have too many words before the colon.
7 years ago
c2e370c2c7
Add telegraph test case
7 years ago
5a5c8ba1a2
Add node to elementsToScore when _hasSinglePInsideElement is true
7 years ago
5ad448f831
Update test expectations.
7 years ago
d88c9afc63
Use a hard coded classesToPreserve in tests.
7 years ago
6729538c77
Clean IDs and classes from output.
7 years ago
19b9f9de14
added npmignore for test and benchmarks resources
7 years ago
c3ff1a2d2c
remove dead code
7 years ago
b3fde168cb
Allow the word threshold parameter to be configurable
7 years ago
b7c32feb25
Remove presentational HTML attributes ( #385 )
...
* Remove presentational HTML attributes
Fixes #383
This patch loops through a list of known-presentational attributes in HTML, attempting to remove each from each cleaned element. (Checking for the attribute's existence first seems to just add needless overhead.)
The extra check for the HTML namespace is to avoid removing attributes that inline SVG needs.
* Only remove `width`/`height` for certain elements
Embedded media elements are allowed to have them, but not others.
* Address PR feedback
* Fix loop index formatting
* Only remove `width`/`height` from certain elements
* Combine logic into a single check/remove
* Attempt fixing my recursion
* One weird trick to get your loops to run
* Add inline SVG bailout
Try not to touch any styles for `<svg>`, because it's inherently presentational.
* Update tests to match newly-removed attributes
* Oh those wacky SVGs
The `position:absolute` is a trick to import clipping paths into the document without putting a big 300×150 empty space in it. (`display:none` and such disable the clipPath in some browsers.)
* Whoops, missed some `width`s
* Normalize SVG tagName
JSDOMParser differs from the official DOM here
7 years ago
6f0bd81dfa
Provide more useful output when attributes mismatch, r=me,test-only
7 years ago
c387d12bc4
Fix eslint issue by unpacking ternary into a proper if statement
7 years ago
bfd14522c4
Update eslint to try to fix issues on infra
7 years ago
f6443ed18b
Match node version from package.json in travis.yml
7 years ago
264946aa15
Require Node >=6.5 to have `.includes` available
...
Per #382 and http://node.green/ , 6.5 should be necessary/sufficient.
7 years ago
f0edc77cb5
Fixed bugzilla bug list link
7 years ago
ab09b706ed
Mention you need a DOM document object
...
Per #376 it doesn't seem to be clear that you need a DOM to use Readability. This is an attempt to include this information in the README.
7 years ago
924017c686
Merge pull request #370 from evanxd/bug-1347472
...
Bug 1347472 - Tests for WordPress blogs, r=Gijs
7 years ago
f6d0840b82
Bug 1347472 - Tests for WordPress blogs, r=Gijs
7 years ago
9561aff883
Merge pull request #368 from evanxd/bug-1346717
...
Bug 1346717 - Tests for youth.cn, r=Gijs
7 years ago
0e147aa722
Bug 1346717 - Tests for youth.cn, r=Gijs
7 years ago
630a0b7367
Bug 1346155 - Tests for gmw.cn, r=Gijs
7 years ago
fe6f7a4910
Merge pull request #362 from evanxd/bug-1345797
...
Bug 1345797 - Tests for yahoo.co.jp, r=Gijs
7 years ago
8976fb08bf
Bug 1345797 - Tests for yahoo.co.jp, r=Gijs
7 years ago
3e07e06b1c
Merge pull request #358 from evanxd/bug-1342355
...
Bug 1342355 - Add tests for wikia.com, r=Gijs
7 years ago
a63e63c91e
Clarify title-splitting code (part of #357 )
...
This adds a number of comments and a wordCount helper function to try to make the code
a bit more readable (which seemed appropriate considering the number of regular expressions).
7 years ago
aed7f10594
Remove general part of title when viewing websites with hierarchical titles
7 years ago
5e56271e45
Add eslint into "Tests" section as well.
7 years ago
b49483c772
Fix some formatting/grammar snafus
7 years ago
eca9bd0cdd
Clarify use of testcase generation script a little
7 years ago
286f94bb35
Point to automated tests and eslint in readme
7 years ago
e48451c48c
Bug 1342355 - Add tests for wikia.com, r=Gijs
7 years ago
c7c26382b9
Bug 1217007 - Remove nodes without any content, r=Gijs
7 years ago
0f147374b7
Bug 1323861 - Remove the readScript method, r=Gijs
7 years ago
27b97434a3
Merge pull request #352 from evanxd/bug-1338468
...
Bug 1338468 - Tests for tumblr.com, r=Gijs
7 years ago
913ecc7c31
Merge pull request #353 from evanxd/bug-1338475
...
Bug 1338475 - Tests for pixnet.net, r=Gijs
7 years ago
b46e316034
Bug 1338468 - Tests for tumblr.com, r=Gijs
7 years ago
bd2d9f8100
Bug 1338475 - Tests for pixnet.net, r=Gijs
7 years ago
1369f923db
Merge pull request #348 from gijsk/1322674-table-divs
...
Fix bug 1322674 by only conditionally removing content from tables when the tables are layout tables, r=evanxd
7 years ago
66c013c4fb
Make it easier to find where errors are coming from based on the error message
8 years ago
9baea36169
Fix bug 1322674 by not removing content in data tables
8 years ago
498a7b2bf6
Merge pull request #347 from evanxd/bug-1259763
...
Bug 1259763 - Remove h2 when there is only one h2 and its text content substantially equals article title, r=Gijs
8 years ago
19f2124c82
Bug 1259763 - Remove h2 when there is only one h2 and its text content substantially equals article title, r=Gijs
8 years ago
ccc8e9bf4c
Bug 1330931 - Add tests for nytimes.com, r=Gijs
8 years ago
15e1f03261
Bug 1300697 - Reader View missed first few paragraphs on New York Times website, r=Gijs
8 years ago
5b1e69bdf2
Bug fix: still not grabbing full content from nytimes.com articles
...
Solution: strip one level of empty <DIV> elements so they don’t
obstruct merging adjacent content downstream.
8 years ago
486927ebd9
Bug fix: many pages only grab partial content (dirty.ru, nytimes.com)
...
1) Avoid conversion of whitespace text nodes into paragraphs. They
create a lot of noise and actually prevent sibling joining logic from
working in many pages.
2) Handle case when adjacent content is actually located in parent's
sibling node instead of top candidate’s sibling.
8 years ago
a58913d975
Bug 1300697 - Add test for New York Times website
8 years ago
Gijs Kruitbosch
Andres Rey
Cameron McCormack
Tomas Dvorak
Björgvin Ragnarsson
Iqbal Ahmed
Taylor Hunt
SahilAgarwal321
Evan Tseng
Evan Tseng
Farbdose
andrei-ch