You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
8f972a3e0e
In the metric test is a call to ncnmetric, which eventually calls
snprintf. Along the way is a size that is much larger than the actual
bufsize, but it shouldn't matter as the buffer size exceeds what we
print (or at least what is expected).
In testing with glibc 2.37 on armhf on Ubuntu Lunar, I found that these
metric tests can fail with some unexpected truncation of the values.
For example, in the following check,
```
impericize_ncmetric(0, 1, buf, 0, 1000, '\0');
CHECK(!strcmp("0.00", buf));
```
buf would actually be "0.0".
Using a more realistic buffer size produces a working result.
|
1 year ago | |
|---|---|---|
| .. | ||
| Exceptions.cpp | 3 years ago | |
| Ncpp.cpp | 3 years ago | |
| autogrow.cpp | 2 years ago | |
| bitmap.cpp | 2 years ago | |
| blit.cpp | 3 years ago | |
| cell.cpp | 2 years ago | |
| channels.cpp | 2 years ago | |
| direct.cpp | 2 years ago | |
| egcpool.cpp | 2 years ago | |
| erase.cpp | 3 years ago | |
| fade.cpp | 2 years ago | |
| fbuf.cpp | 3 years ago | |
| fds.cpp | 3 years ago | |
| fills.cpp | 3 years ago | |
| geom.cpp | 3 years ago | |
| internal.cpp | 3 years ago | |
| libunistring.cpp | 3 years ago | |
| main.cpp | 2 years ago | |
| main.h | 3 years ago | |
| media.cpp | 2 years ago | |
| menu.cpp | 3 years ago | |
| metric.cpp | 1 year ago | |
| multiselector.cpp | 3 years ago | |
| notcurses.cpp | 3 years ago | |
| output.cpp | 2 years ago | |
| palette.cpp | 3 years ago | |
| piles.cpp | 3 years ago | |
| plane.cpp | 2 years ago | |
| plot.cpp | 3 years ago | |
| progbar.cpp | 3 years ago | |
| reader.cpp | 3 years ago | |
| reel.cpp | 3 years ago | |
| reelgaps.cpp | 3 years ago | |
| resize.cpp | 3 years ago | |
| rotate.cpp | 3 years ago | |
| scrolling.cpp | 3 years ago | |
| selector.cpp | 3 years ago | |
| sixels.cpp | 2 years ago | |
| stacking.cpp | 3 years ago | |
| tabbed.cpp | 2 years ago | |
| tabs.cpp | 2 years ago | |
| textlayout.cpp | 2 years ago | |
| tree.cpp | 2 years ago | |
| version.cpp | 3 years ago | |
| visual.cpp | 3 years ago | |
| wide.cpp | 2 years ago | |
| zaxis.cpp | 1 year ago | |