2
0
mirror of https://github.com/lnbook/lnbook synced 2024-11-08 19:10:35 +00:00
Commit Graph

1561 Commits

Author SHA1 Message Date
Andreas M. Antonopoulos
b97cd977de
Merge pull request #576 from jerzybrzoska/patch-3
Consistency in spelling out the numbers that are < 10 (introduction)
2021-01-11 13:13:59 -06:00
Andreas M. Antonopoulos
4ddb41ab95
Merge pull request #577 from jerzybrzoska/patch-4
Corrected a typo "2-of-2" instead of "2-2"
2021-01-11 13:13:34 -06:00
Andreas M. Antonopoulos
6ed6712ddd
Merge pull request #578 from GustavoRSSilva/feature/minor-misspells-channel-description
Channel description - minor misspels
2021-01-11 13:13:26 -06:00
Andreas M. Antonopoulos
95b16c65d3
Merge pull request #579 from jerzybrzoska/patch-5
Consistent spelling of timelock (ch. 3)
2021-01-11 13:12:51 -06:00
Andreas M. Antonopoulos
eb7aff823d
Merge branch 'develop' into patch-5 2021-01-11 13:12:43 -06:00
Andreas M. Antonopoulos
e8e46646a8
Merge pull request #581 from jerzybrzoska/patch-6
Minor modification that removes ambiguity (ch. 3)
2021-01-11 13:11:26 -06:00
Andreas M. Antonopoulos
3b6dcc164e
Merge pull request #582 from jerzybrzoska/patch-7
Made one sentence out of these two.
2021-01-11 13:11:02 -06:00
Andreas M. Antonopoulos
1997ed28a7
Merge pull request #568 from johnsBeharry/develop
fix(glossary): BOLT === Basis Of Lightning Technology NOT Basics
2021-01-11 13:10:39 -06:00
Andreas M. Antonopoulos
bc8b34667b
Merge pull request #567 from ysangkok/patch-1
Update Eclair manual building instructions
2021-01-11 13:10:14 -06:00
Andreas M. Antonopoulos
1c139865e5
Merge pull request #563 from ImranLorgat/patch-47
Glossary - Feature Bits
2021-01-11 13:09:17 -06:00
Andreas M. Antonopoulos
629d6ecb76
Merge pull request #571 from Scott-Driscoll/minor-grammar-and-text-suggestions
Minor grammar and text suggestion
2021-01-11 13:08:14 -06:00
Andreas M. Antonopoulos
55a0e90db0
Merge pull request #580 from Roasbeef/gossip-chapter
ggch-channel-graph: initial draft of channel graph chapter
2021-01-11 13:05:25 -06:00
jerzybrzoska
f35b50dfd4
Made one sentence out of these two.
Someone better versed in the noise protocol may consider including 'authentication' and 'identity privacy', so that the glossary information on the noise protocol is parallel to [the one in ch.3](https://github.com/lnbook/lnbook/blob/develop/03_how_ln_works.asciidoc):
>The Noise Protocol Framework allows the construction of cryptographic communication protocols that offer authentication, encryption, forward secrecy and identity privacy.
2021-01-06 21:16:03 +01:00
jerzybrzoska
9cac112c96
Minor modification that removes ambiguity (ch. 3)
I removed "You have". Now it's all in one sentence -- less ambiguous and more concise I believe. The more verbose alternative would be: 
>You have *time* until ...
2021-01-06 10:39:10 +01:00
Olaoluwa Osuntokun
aff95b8b10 ch-channel-graph: initial draft of channel graph chapter
In this commit, we present an initial version of the chapter on the
channel graph itself, how to bootstrap a new peer to the network, how to
sync it, how to validate it, and how to maintain it once bootstrapped.

The current version of this chapter covers the following BOLTs: 07, 10.
BOLTs 09, 08, and 01 are alluded to along the way.

This is marked as a draft commit, as I still need to fill out the final
portion that covers how the current gossip network works, and the
protocol used to sync the channel graph based on block heights of
channels.

Due to the current length, we may want to consider eventually breaking
this chapter up, however I'm focusing on content first.
2021-01-04 10:56:33 -08:00
jerzybrzoska
41b06b0d7f
Consistent spelling of timelock (ch. 3)
Both "timelock" and "time lock" are correct but let us be consistent and stick to the one form.
2021-01-04 10:02:44 +01:00
Gustavo Silva
e460a145fb [fix] minor misspells 2021-01-02 17:51:33 +00:00
jerzybrzoska
d430b70149
Corrected a typo "2-of-2" instead of "2-2" 2020-12-30 10:29:15 +01:00
jerzybrzoska
0feaabb365
Consistency in spelling out the numbers that are < 10 (introduction)
It would be fine to maintain consistency in spelling out the numbers (provided that they are not code/math/ BTC amounts) that are < 10. I left out "8 GB" unchanged, though. "eight Gigabyte" would perhaps be more consistent, but at the same time would seem very
unusual, whereas "eight GB" just make no sense to me.  
[A post about style](https://www.grammarly.com/blog/when-to-spell-out-numbers/) for the reference.
>In scientific and technical writing, the prevailing style is to write out numbers under ten. While there are exceptions to these rules, your predominant concern should be expressing numbers consistently.
2020-12-30 10:15:54 +01:00
jerzybrzoska
28f1552be8
Update 03_how_ln_works.asciidoc
You are right [Umar](@bolatovumar) , I have not found a single source on the web with _two-of-two_, _2-of-2_ seems to be the standard. I edited my pull request, so now the changes do not include 2-of-2 modification. I find the issue of '2-of-2' vs 'two-of-two' interesting and may soon create a question on [English Stack Exchange](https://english.stackexchange.com/) in order to get their opinion.
2020-12-30 09:41:27 +01:00
jerzybrzoska
68ebd75d5b
Consistency in spelling out the numbers that are < 10
It would be well to maintain consistency in spelling out the numbers (provided that they are not code/math/ BTC amounts) that are < 10. I left out "chapter 6" and the like unchanged. 
[A post about style][1] for the reference.
>In scientific and technical writing, the prevailing style is to write out numbers under ten. While there are exceptions to these rules, your predominant concern should be expressing numbers consistently.

[1]: https://www.grammarly.com/blog/when-to-spell-out-numbers/
2020-12-28 19:42:53 +01:00
jerzybrzoska
6158b78123
Update e2e-presentation-layer.asciidoc
Added a period after the last sentence of a paragraph. After spotting it I could not help correcting it.
2020-12-27 18:11:44 +01:00
Scott-Driscoll
b0e3d9f5cd
We will not review these advanced... in depth 2020-12-27 08:46:44 -05:00
Scott-Driscoll
f70c014507
We will not revise these concepts --> We will not review 2020-12-22 19:36:30 -05:00
Johns Beharry
d3eae93bbe
refactor(glossary): differentiate bitcoin and lightning specs 2020-12-16 02:08:49 +01:00
Andreas M. Antonopoulos
adbd2efbad Routing chapter edits 2020-12-15 10:07:44 -06:00
Andreas M. Antonopoulos
eac6f28f77 node operations chapter status fix 2020-12-15 08:58:19 -06:00
Andreas M. Antonopoulos
a720529872 Updated README with publication date, chapter progress, and wordcount, 2020-12-15 08:56:58 -06:00
batmanscode
05b29ed36b
Minor wording and punctuation
**Changes:**

* Added some missing full stops.
* 'meaning a pre-defined process based on cryptography, used by the channel partners to re-distribute' to 'meaning a pre-defined process based on cryptography is used by the channel partners to re-distribute'
* 'Payment channels basics' to 'Payment channel basics'
* 'Channels partners can agree to announce' to 'Channel partners can agree to announce'
* 'don’t need to trust your channel to retrieve the balance of your channel' to 'don’t need to trust your channel partner to retrieve the balance of your channel'
* 'present a Lightning invoice to Alice as a QR code, or send it via email, or any other message channel' or 'present a Lightning invoice to Alice as a QR code, send it via email, or any other message channel'
* 'who just sent her an uninvitedly email' to 'who just uninvitedly sent her an email'
* 'addresses as part of payment channel on the Lightning Network' to 'addresses as part of payment channels on the Lightning Network'
* 'We looked at how payments are routed. Finally, we compared Lightning and Bitcoin and analyzed their differences and commonalities' to 'We looked at how payments are routed and finally, we compared Lightning with Bitcoin and analyzed their differences and commonalities'
2020-12-14 03:27:38 +05:30
seresistvanandras
293a05abcf Non-contentious fixes 3 2020-12-13 16:25:15 +01:00
seresistvanandras
0e663b5ec7 Non-contentious fixes 2 2020-12-13 16:01:17 +01:00
seresistvanandras
40d7b1e3ac Non-contentious fixes 2020-12-13 15:46:43 +01:00
István András Seres
796353d73a
Typo fix
Co-authored-by: Trellz <70897306+Trxlz@users.noreply.github.com>
2020-12-13 15:02:31 +01:00
István András Seres
468c6dfe36
Fixing the misspelling of lead in past tense
Co-authored-by: nopara73 <adam.ficsor73@gmail.com>
2020-12-13 14:59:32 +01:00
Johns Beharry
eec41ae02c
fix(glossary): resolve typo 2020-12-13 09:51:20 +01:00
Johns Beharry
4f2917d7d3
fix(glossary): lowercase protocol and of 2020-12-13 09:49:53 +01:00
Johns Beharry
ca79710601
refactor(glossary): simplify BOLT definition 2020-12-13 09:34:38 +01:00
Janus Troelsen
7231f5f102 Update Eclair manual building instructions
- Explain something that looks like a version number ("2.13").
- Explain how to skip tests, which are fragile on master and not run for the other clients.
2020-12-12 14:36:19 -06:00
Andreas M. Antonopoulos
2da8c72599 Merge branch 'fairness_protocol' into develop 2020-12-11 17:32:21 -06:00
Andreas M. Antonopoulos
b83245852c Finished fairness protocol section 2020-12-11 17:31:47 -06:00
Andreas M. Antonopoulos
6427d048f3
Merge pull request #565 from batmanscode/develop
minor wording fixes
2020-12-11 17:06:48 -06:00
Andreas M. Antonopoulos
7f9206a0aa
Merge pull request #566 from bitcoincoretech/issue_549b
Issue 549b
2020-12-11 10:14:18 -06:00
Vlad Stan
ebf409e0e0 #549 always restart containers 2020-12-11 17:52:25 +02:00
Vlad Stan
37e068de4a #5 update lnd version 2020-12-11 17:51:51 +02:00
Vlad Stan
52cb91bd44 #549 replace deprecated property
see https://github.com/ACINQ/eclair/issues/1505
2020-12-11 17:51:30 +02:00
Vlad Stan
060be23df1 #549 update eclair to latest version & commit 2020-12-11 17:50:53 +02:00
Vlad Stan
0c27defb00 #549 update lightningd to use a specific version 2020-12-11 17:50:27 +02:00
Imran
a1d30a7503
Update glossary.asciidoc 2020-12-10 17:14:23 +02:00
batmanscode
57eb42cb03
minor wording fixes
**changed:**

* 'mined since (and inclusive) the block' to 'mined since (and inclusive of) the block'
* 'Six confirmation is a best practice' to 'Six confirmations is best practice'
* 'without "on-chain" transaction' to 'without an "on-chain" transaction'
2020-12-10 07:32:59 +05:30
Imran
e6e30e27fc
Glossary - Feature Bits 2020-12-09 09:54:52 +02:00