2
0
mirror of https://github.com/lnbook/lnbook synced 2024-11-01 03:20:53 +00:00
Commit Graph

456 Commits

Author SHA1 Message Date
Hugo Doyon
27046411dd
then
Instead of "theh", should be writtent "then"
2020-05-06 10:50:56 -04:00
8go
cba3c55ff8
ch3: minor improvements to chapter "Thoughts about Trust"
- principal --> Major
- I would not call cost a risk. The opening fee IMHO is not a risk, it is simply a cost.
- commas
- in reference to time "immediately" better than "directly"
- added another example, to explain when not to create a channel
2020-05-05 19:50:23 -07:00
Andrea Cabral
5870e433c5
ch1+ch3: fix small typos 2020-05-05 19:48:46 -07:00
Olaoluwa Osuntokun
526be60ded
Merge pull request #216 from HugoDoyon/patch-5
feasable?
2020-05-05 19:41:45 -07:00
Olaoluwa Osuntokun
a42827c2a7
Merge pull request #215 from HugoDoyon/patch-4
Typos
2020-05-05 19:41:13 -07:00
Olaoluwa Osuntokun
75c2ebc9b0
Merge pull request #214 from HugoDoyon/patch-3
Learn and comma
2020-05-05 19:40:48 -07:00
Olaoluwa Osuntokun
e26eeb29ea
Merge pull request #209 from 8go/patch-35
addition to chapter "Comparison with Bitcoin" part 6
2020-05-05 19:38:09 -07:00
Olaoluwa Osuntokun
a349340160
Merge pull request #205 from 8go/patch-30
minor improvements to chapter "Comparison with Bitcoin" part 2
2020-05-05 19:32:52 -07:00
Olaoluwa Osuntokun
dbf37bdfe5
Merge pull request #204 from 8go/patch-29
minor improvements to chapter "Comparison with Bitcoin" part 1
2020-05-05 19:31:13 -07:00
Hugo Doyon
d17df44749
feasable?
feasible (typo)
2020-04-25 10:35:21 -04:00
Hugo Doyon
da50feeb3b
Typos
challanges & whith should be written: challenges and with
2020-04-24 12:06:35 -04:00
Hugo Doyon
a70fe1c24f
Learn and comma
Laern instead of Lear
2020-04-24 12:03:02 -04:00
Hugo Doyon
5bb60a65c6
typo (#212)
inormation should be in"f"ormation
2020-04-23 10:34:49 +02:00
Hugo Doyon
453606a107
Terrabyte sould be Terabyte (#211)
Typo
2020-04-23 10:30:00 +02:00
8go
f4688b692b
addition to chapter "Comparison with Bitcoin" part 6
- added new chapter
2020-04-22 19:16:22 +00:00
8go
5f876a4c59
minor improvements to chapter "Comparison with Bitcoin" part 2
- more details
- etc
2020-04-22 17:07:46 +00:00
Rene Pickhardt
43ce57298b
fix htlc typo that came in through find and replace 2020-04-22 19:04:59 +02:00
8go
e8bb86d45c
minor improvements to chapter "Comparison with Bitcoin" part 1
- no commas when subject is the same on both parts of sentence
- nothing seems to be gained by introducing concept of "traffic" --> removed it
- instead explained what the scarce resources are
- more explanations
- etc.
2020-04-22 16:56:13 +00:00
8go
3bfca36de6
minor improvements to chapter "Examining the ugly way" (#194)
- again, avoid extreme terms like "really high" that cannot be quantified.
- you do not gain the entire channel capacity, gain means "benefit", if 9 mBTC out of the 10 mBTC channel capacity were yours anyway, you would GET 10 mBTC but only GAIN 1 mBTC.
- additions
- mention of game theory
- etc
2020-04-22 18:54:20 +02:00
8go
1c3f3d7f52
minor improvements to chapter "Examining the bad way" (#193)
- simplified
- reduced sentence length
- comma after thus
- with respect to time "immediately" is better than "directly"
- avoid extremes, replaced "much higher" with "higher", later we specify the figure 5x anyway
- "additional" better than "more" 
- misc clarifications
- some additions
- etc
2020-04-22 18:51:56 +02:00
8go
a7f830d7f1
minor improvements to chapter "Examining the good way - mutual close" (#192)
- closing tx, shutdown tx, etc:  to avoid any confusion I took the "shutdown tx" out and simply named it the "on-chain tx"
- replaced "party" with "channel partner" for consistency
- removed "as many people think". If the book does a good job, not many people will think that ! In any case, this phrase does not help. Better to just state the facts. 
- etc
2020-04-22 18:49:59 +02:00
8go
ee3164c398
minor improvements to chapter "Closing the channel" (#191)
- Bitcoin: uppercase as it refers to fees on the Bitcoin protocol
- added more detail on importance of longevity of channel
- the last sentence was way too long and too complicated. restructured it.
- etc
2020-04-22 18:48:45 +02:00
8go
66f730a077
minor improvements to "Announcing the channel" (#190)
- added distinction between "public" and "private" channel, added the 2 terms
- rename 2-2 to 2-out-of-2 for consistency and to make it clearer
- simplified a few sentences
- added a few additional clarifying words
- etc
2020-04-22 18:45:41 +02:00
8go
97c8927d66
improvements to chapter "Commitment Transaction", part 2 (#189)
- comma after however
- when referring to time "immediately" is better and more meaningful than "directly"
- when referring to time duration "lasts" is better than "is"
- consistency: "channel partner" better than "party"
- etc
2020-04-22 18:40:14 +02:00
8go
05f8370259
Improvements to chapter "Commitment Transaction" (#188)
- replace "capacity" with "funds to reduce tech jargon
- replaced 2-2 with 2-out-of-2 for consistency and to clarify
- everyone --> singular  .. its funds .. not their funds
- "wallet" wrong, "address" better
- avoid "flaw", it might get misinterpreted, rephrased to clearly state that we present the design step-by-step
- "you probably have realized" and "hope you recognize that" puts the reader in a bind. If the reader does not see the problem we will feel "dumb" because the text implies "probably you realized". I suggest to rewrite it so, that the reader does not feel "dumb" just because he does not see the shortcut. --> see changes
- however requires comma
- avoid extremes like "rather high", use facts and measurable units, here simply "high"
- "to lose funds" incorrect, "loose" is correct
- took one long sentence and split it up into several short one making understanding a lot simpler
- etc
2020-04-22 18:38:13 +02:00
8go
af6b431265
added contributor name (#195)
+1 line  :)
2020-04-22 18:32:21 +02:00
8go
5b3a4ab256
minor improvements to chapter "Payment Hash" and "Additional Meta Data" (#198)
- repeated use of "also", --> furthermore, ...
- minor clarifications
- etc
2020-04-22 18:25:25 +02:00
8go
114387e822
minor improvements to chapter "Delivering the payment" (#199)
- peer-to-peer better than "peer 2 peer" , in acronyms p2p is ok
- English language guidelines recommend numbers up to 12 to be spelled out. 4 --> four
- minor additions/clarifications
2020-04-22 18:22:24 +02:00
8go
e2aaeca0df
minor improvements to chapter "Finding a path" (#200)
- added commas
- some sentences presented the ideas in the wrong order and the sentences were too long --> restructured sentences
- etc
2020-04-22 18:19:51 +02:00
8go
e7fd91964b
minor improvements to chapter "Missing bits" (#202)
- repeated use of "following"
- peer-to-peer instead "peer to peer"
- minor clarifications
- etc
2020-04-22 18:12:29 +02:00
Rene Pichardt
08c87e7fdf started to write about setteling htlcs 2020-04-20 20:00:56 +02:00
Andreas M. Antonopoulos
fd776b39c1 Relaxed Travis to avoid breaking builds while things are in flux
The travis linter is too strict and we keep failing builds. This is a bit like taking the batteries out of the smoke alarm, or using aluminum foil to replace a fuse, or both. Everything is fine!
2020-04-19 17:51:38 -04:00
Andreas M. Antonopoulos
473a259bfa
Merge pull request #154 from HAOYUatHZ/ln_msg
add "Ligtning Messages" section
2020-04-19 16:10:41 -04:00
Rene Pichardt
05e161596d added explainations how htlcs are being set up in payment channels to prepare routing 2020-04-19 16:46:11 +02:00
Rene Pichardt
03b0d87b8a added the fist version of the routing chapter. did no have time to do proof reading or editorial yet 2020-04-18 17:12:13 +02:00
Rene Pichardt
369400428b added some calaculations about onchain scaling 2020-04-18 11:39:04 +02:00
HAOYUatHZ
dae192a37c
add Transaction Malleability (#150)
* add Transaction Malleability

* fix https://github.com/lnbook/lnbook/pull/150#discussion_r379919498

* explain why non-malleability is needed

* fix typos
2020-04-18 11:03:19 +02:00
Kory Newton
f226a5fb1a
fix typos in chapter 3 (#166)
* fix typos Chapter 3

* additional ch3 typo fixes

Co-authored-by: Rene Pickhardt <rene@rene-pickhardt.de>
2020-04-18 10:57:17 +02:00
Roman
ae9d905f27
fix typos in ch1 and ch2 (#168)
* table indentation

* 'a' before consonant

* less commas

* wording

* unquote commas

* typo

* on chain -> on-chain

* need comma (IMHO)

* dot

* caps acronym

* wording

Co-authored-by: Rene Pickhardt <rene@rene-pickhardt.de>
2020-04-18 10:54:47 +02:00
8go
e7ea91fe81
minor improvements in "Example of a poor channel opening procedure" (#184)
- replace "committing attack" with "performing attack" to avoid that the reader incorrectly concludes that the term "commitment tx" has anything to do with "committing an attack"
- signed by, not signed from
2020-04-18 10:51:19 +02:00
8go
58f282ee38
minor improvements to Funding Transaction paragraphs (#183)
- consistently sticking to "2-out-of-2"
- rephrasing some sentences to make them more palatable. "obviously a lie" is a bit aggressive. 
- avoid using exaggerating terms like "very expensive", just state the facts without too many emotions
2020-04-18 10:50:33 +02:00
8go
a4e59ed614
improvements to Multisig addresses paragraphs (#182)
- as before "2-out-of-2" is more appropriate than "2-2" 
- "thus" is not what you wanted to express, "however" is what you wanted to say
- added missing comma
- etc
2020-04-18 10:49:06 +02:00
8go
26b0fb4e78
minor corrections in Payment channels paragraphs (#181)
- "the both of you": incorrect English, better "both of you"
- "cheat on you": spoken English, better "cheat you"
- "had to be", that sounds like you are guessing, better "was"
- if you give full names of some, give full names of all 
- added year to make it more precise
- etc.
2020-04-18 10:48:10 +02:00
8go
bf44a80973
minor improvements, corrections (#180)
- comma must follow "additionally" and "however" as they are introductory words or phrases
- same for "last but not least", comma missing
- "nothing else than", not perfect English; better "nothing but" 
- "get most use", not perfect English; better "get more benefits"
2020-04-18 10:45:20 +02:00
8go
a80f758b1f
minor improvements in Note (#179)
- 2-out-of-2 is more consistent (see usage above) and carries more information than 2-2
- comma after however needed
2020-04-18 10:44:16 +02:00
8go
b4204ba4cf
added a few words to improve definition paragraph (#178)
- consistent use of "partner"
- added "Bitcoin" to "Bitcoin smart contract" because there are many people out there that have heard the term "smart contract" exclusively in the context of Ethereum. It might be worth while to underline that Bitcoin also has its form of smart contracts. This should eliminate any possible doubts.
- imply that earlier states are no longer valid, added "invalidated" 
- channel member is singular, so "if they try" is wrong. better "if it tries"
2020-04-18 10:43:44 +02:00
8go
52aa362dcc
improved definition of LN (#177)
- removed incorrect comma in front of "as well as"
- added "both" to make it stronger that LN has 2 main functionalities
- "... on the network." leaves it undefined. The reader might ask to which netowrk it refers to? To the before mentioned netowrk of payment-channels? Added "Bitcoin" to clarify.
2020-04-18 10:42:52 +02:00
8go
6ec8035b52
clarifications and additions (#173)
* clarifiactions and additions

some modifications to improve, clarify

some additions to add more details where appropriate

... lightweight Bitcoin client (commonly referred to as Simplified Payment Verification (SPV)) to partially validate the correctness of their blockchain. --> partially? Probably you mean "indirectly" as you delegate to a third party. Also SPVs clients don't have a blockchain, so why "their blockchain"? --> to reduce this confusion --> lightweight Bitcoin client (commonly referred to as Simplified Payment Verification (SPV)) to interact with the blockchain

... lightning wallets ... --> ... Lightning wallets ...

centralized and added more details to definition of non-custodial wallet

* Update 02_getting_started.asciidoc

added the sentince back in

Co-authored-by: Rene Pickhardt <rene@rene-pickhardt.de>
2020-04-18 10:41:46 +02:00
8go
94bdc595c5
minor improvements and clarifications (#170)
- minor clarifications
- incorrect use of plural
- repetitive use of "this way" --> this fashion
- clarifying "each time" --> each payment
- added detail that LN txs are not stored permanently
- repetitive use of "explanation" --> clarification
- seeing --> revisiting
- etc.
2020-04-18 10:24:14 +02:00
Kory Newton
3ef507291a
fix glossary typos (#167) 2020-04-18 10:17:19 +02:00