Merge branch 'main' into db-traits-refactor

README.md

@@ -116,26 +116,7 @@ Each Lemmy server can set its own moderation policy; appointing site-wide admins
 
 ## Lemmy Projects
 
-### Apps
+- [awesome-lemmy - A community driven list of apps and tools for lemmy](https://github.com/dbeley/awesome-lemmy)
-
-- [lemmy-ui - The official web app for lemmy](https://github.com/LemmyNet/lemmy-ui)
-- [lemmyBB - A Lemmy forum UI based on phpBB](https://github.com/LemmyNet/lemmyBB)
-- [Jerboa - A native Android app made by Lemmy's developers](https://github.com/dessalines/jerboa)
-- [Mlem - A Lemmy client for iOS](https://github.com/buresdv/Mlem)
-- [Lemoa - A Gtk client for Lemmy on Linux](https://github.com/lemmy-gtk/lemoa)
-- [Liftoff - A Lemmy for Windows , Linux and Android ](https://github.com/liftoff-app/liftoff)
-
-### Libraries
-
-- [lemmy-js-client](https://github.com/LemmyNet/lemmy-js-client)
-- [lemmy-rust-client](https://github.com/LemmyNet/lemmy/tree/main/crates/api_common)
-- [go-lemmy](https://gitea.arsenm.dev/Arsen6331/go-lemmy)
-- [Dart API client](https://github.com/LemmurOrg/lemmy_api_client)
-- [Lemmy-Swift-Client](https://github.com/rrainn/Lemmy-Swift-Client)
-- [Reddit -> Lemmy Importer](https://github.com/rileynull/RedditLemmyImporter)
-- [lemmy-bot - Typescript library to make it easier to make bots for Lemmy](https://github.com/SleeplessOne1917/lemmy-bot)
-- [Reddit API wrapper for Lemmy](https://github.com/derivator/tafkars)
-- [Pythörhead - Python package for integrating with the Lemmy API](https://pypi.org/project/pythorhead/)
 
 ## Support / Donate
 

crates/api/src/community/follow.rs

@@ -26,24 +26,27 @@ impl Perform for FollowCommunity {
 
     let community_id = data.community_id;
     let community = Community::read(context.conn().await?, community_id).await?;
-    let community_follower_form = CommunityFollowerForm {
+    let mut community_follower_form = CommunityFollowerForm {
       community_id: data.community_id,
       person_id: local_user_view.person.id,
       pending: false,
     };
 
-    if community.local && data.follow {
+    if data.follow {
-      check_community_ban(
+      if community.local {
-        local_user_view.person.id,
+        check_community_ban(local_user_view.person.id, community_id, context.conn().await?).await?;
-        community_id,
-        context.conn().await?,
-      )
-      .await?;
         check_community_deleted_or_removed(community_id, context.conn().await?).await?;
 
         CommunityFollower::follow(context.conn().await?, &community_follower_form)
           .await
           .map_err(|e| LemmyError::from_error_message(e, "community_follower_already_exists"))?;
+      } else {
+        // Mark as pending, the actual federation activity is sent via `SendActivity` handler
+        community_follower_form.pending = true;
+        CommunityFollower::follow(context.conn().await?, &community_follower_form)
+          .await
+          .map_err(|e| LemmyError::from_error_message(e, "community_follower_already_exists"))?;
+      }
     }
     if !data.follow {
       CommunityFollower::unfollow(context.conn().await?, &community_follower_form)

crates/api/src/local_user/save_settings.rs

@@ -132,6 +132,7 @@ impl Perform for SaveUserSettings {
       .interface_language(data.interface_language.clone())
       .totp_2fa_secret(totp_2fa_secret)
       .totp_2fa_url(totp_2fa_url)
+      .open_links_in_new_tab(data.open_links_in_new_tab)
       .build();
 
     let local_user_res =

crates/api_common/src/person.rs

@@ -131,6 +131,8 @@ pub struct SaveUserSettings {
   /// None leaves it as is, true will generate or regenerate it, false clears it out.
   pub generate_totp_2fa: Option<bool>,
   pub auth: Sensitive<String>,
+  /// Open links in a new tab
+  pub open_links_in_new_tab: Option<bool>,
 }
 
 #[derive(Debug, Serialize, Deserialize, Clone, Default)]

crates/api_crud/src/post/create.rs

@@ -121,18 +121,9 @@ impl PerformCrud for CreatePost {
       .thumbnail_url(thumbnail_url)
       .build();
 
-    let inserted_post = match Post::create(context.conn().await?, &post_form).await {
+    let inserted_post = Post::create(context.conn().await?, &post_form)
-      Ok(post) => post,
+      .await
-      Err(e) => {
+      .map_err(|e| LemmyError::from_error_message(e, "couldnt_create_post"))?;
-        let err_type = if e.to_string() == "value too long for type character varying(200)" {
-          "post_title_too_long"
-        } else {
-          "couldnt_create_post"
-        };
-
-        return Err(LemmyError::from_error_message(e, err_type));
-      }
-    };
 
     let inserted_post_id = inserted_post.id;
     let protocol_and_hostname = context.settings().get_protocol_and_hostname();

crates/api_crud/src/post/update.rs

@@ -96,16 +96,9 @@ impl PerformCrud for EditPost {
       .build();
 
     let post_id = data.post_id;
-    let res = Post::update(context.conn().await?, post_id, &post_form).await;
+    Post::update(context.conn().await?, post_id, &post_form)
-    if let Err(e) = res {
+      .await
-      let err_type = if e.to_string() == "value too long for type character varying(200)" {
+      .map_err(|e| LemmyError::from_error_message(e, "couldnt_create_post"))?;
-        "post_title_too_long"
-      } else {
-        "couldnt_update_post"
-      };
-
-      return Err(LemmyError::from_error_message(e, err_type));
-    }
 
     build_post_response(
       context,

crates/apub/src/activities/unfederated.rs

@@ -5,8 +5,6 @@ use lemmy_api_common::{
     CommentResponse,
     DistinguishComment,
     GetComment,
-    GetComments,
-    GetCommentsResponse,
     ListCommentReports,
     ListCommentReportsResponse,
     ResolveCommentReport,
@@ -15,7 +13,6 @@ use lemmy_api_common::{
   community::{
     CommunityResponse,
     CreateCommunity,
-    GetCommunity,
     GetCommunityResponse,
     ListCommunities,
     ListCommunitiesResponse,
@@ -39,8 +36,6 @@ use lemmy_api_common::{
     GetBannedPersons,
     GetCaptcha,
     GetCaptchaResponse,
-    GetPersonDetails,
-    GetPersonDetailsResponse,
     GetPersonMentions,
     GetPersonMentionsResponse,
     GetReplies,
@@ -66,8 +61,6 @@ use lemmy_api_common::{
   post::{
     GetPost,
     GetPostResponse,
-    GetPosts,
-    GetPostsResponse,
     GetSiteMetadata,
     GetSiteMetadataResponse,
     ListPostReports,
@@ -110,10 +103,6 @@ use lemmy_api_common::{
     PurgePerson,
     PurgePost,
     RegistrationApplicationResponse,
-    ResolveObject,
-    ResolveObjectResponse,
-    Search,
-    SearchResponse,
     SiteResponse,
   },
 };
@@ -122,10 +111,6 @@ impl SendActivity for Register {
   type Response = LoginResponse;
 }
 
-impl SendActivity for GetPersonDetails {
-  type Response = GetPersonDetailsResponse;
-}
-
 impl SendActivity for GetPrivateMessages {
   type Response = PrivateMessagesResponse;
 }
@@ -142,10 +127,6 @@ impl SendActivity for GetSite {
   type Response = GetSiteResponse;
 }
 
-impl SendActivity for GetCommunity {
-  type Response = GetCommunityResponse;
-}
-
 impl SendActivity for ListCommunities {
   type Response = ListCommunitiesResponse;
 }
@@ -158,18 +139,10 @@ impl SendActivity for GetPost {
   type Response = GetPostResponse;
 }
 
-impl SendActivity for GetPosts {
-  type Response = GetPostsResponse;
-}
-
 impl SendActivity for GetComment {
   type Response = CommentResponse;
 }
 
-impl SendActivity for GetComments {
-  type Response = GetCommentsResponse;
-}
-
 impl SendActivity for Login {
   type Response = LoginResponse;
 }
@@ -286,14 +259,6 @@ impl SendActivity for PurgeComment {
   type Response = PurgeItemResponse;
 }
 
-impl SendActivity for Search {
-  type Response = SearchResponse;
-}
-
-impl SendActivity for ResolveObject {
-  type Response = ResolveObjectResponse;
-}
-
 impl SendActivity for TransferCommunity {
   type Response = GetCommunityResponse;
 }

crates/apub/src/api/list_comments.rs

@@ -1,9 +1,10 @@
 use crate::{
-  api::{listing_type_with_default, PerformApub},
+  api::listing_type_with_default,
   fetcher::resolve_actor_identifier,
   objects::community::ApubCommunity,
 };
 use activitypub_federation::config::Data;
+use actix_web::web::{Json, Query};
 use lemmy_api_common::{
   comment::{GetComments, GetCommentsResponse},
   context::LemmyContext,
@@ -16,19 +17,17 @@ use lemmy_db_schema::{
 use lemmy_db_views::comment_view::CommentQuery;
 use lemmy_utils::error::LemmyError;
 
-#[async_trait::async_trait]
+#[tracing::instrument(skip(context))]
-impl PerformApub for GetComments {
+pub async fn list_comments(
-  type Response = GetCommentsResponse;
+  data: Query<GetComments>,
-
+  context: Data<LemmyContext>,
-  #[tracing::instrument(skip(context))]
+) -> Result<Json<GetCommentsResponse>, LemmyError> {
-  async fn perform(&self, context: &Data<LemmyContext>) -> Result<GetCommentsResponse, LemmyError> {
+  let local_user_view = local_user_view_from_jwt_opt(data.auth.as_ref(), &context).await;
-    let data: &GetComments = self;
+  let local_site = LocalSite::read(context.pool()).await?;
-    let local_user_view = local_user_view_from_jwt_opt(data.auth.as_ref(), context).await;
-    let local_site = LocalSite::read(context.conn().await?).await?;
   check_private_instance(&local_user_view, &local_site)?;
 
   let community_id = if let Some(name) = &data.community_name {
-      resolve_actor_identifier::<ApubCommunity, Community>(name, context, &None, true)
+    resolve_actor_identifier::<ApubCommunity, Community>(name, &context, &None, true)
       .await
       .ok()
       .map(|c| c.id)
@@ -71,6 +70,5 @@ impl PerformApub for GetComments {
     .await
     .map_err(|e| LemmyError::from_error_message(e, "couldnt_get_comments"))?;
 
-    Ok(GetCommentsResponse { comments })
+  Ok(Json(GetCommentsResponse { comments }))
-  }
 }

crates/apub/src/api/list_posts.rs

@@ -1,9 +1,10 @@
 use crate::{
-  api::{listing_type_with_default, PerformApub},
+  api::listing_type_with_default,
   fetcher::resolve_actor_identifier,
   objects::community::ApubCommunity,
 };
 use activitypub_federation::config::Data;
+use actix_web::web::{Json, Query};
 use lemmy_api_common::{
   context::LemmyContext,
   post::{GetPosts, GetPostsResponse},
@@ -13,15 +14,13 @@ use lemmy_db_schema::source::{community::Community, local_site::LocalSite};
 use lemmy_db_views::post_view::PostQuery;
 use lemmy_utils::error::LemmyError;
 
-#[async_trait::async_trait]
+#[tracing::instrument(skip(context))]
-impl PerformApub for GetPosts {
+pub async fn list_posts(
-  type Response = GetPostsResponse;
+  data: Query<GetPosts>,
-
+  context: Data<LemmyContext>,
-  #[tracing::instrument(skip(context))]
+) -> Result<Json<GetPostsResponse>, LemmyError> {
-  async fn perform(&self, context: &Data<LemmyContext>) -> Result<GetPostsResponse, LemmyError> {
+  let local_user_view = local_user_view_from_jwt_opt(data.auth.as_ref(), &context).await;
-    let data: &GetPosts = self;
+  let local_site = LocalSite::read(context.pool()).await?;
-    let local_user_view = local_user_view_from_jwt_opt(data.auth.as_ref(), context).await;
-    let local_site = LocalSite::read(context.conn().await?).await?;
 
   check_private_instance(&local_user_view, &local_site)?;
 
@@ -30,7 +29,7 @@ impl PerformApub for GetPosts {
   let page = data.page;
   let limit = data.limit;
   let community_id = if let Some(name) = &data.community_name {
-      resolve_actor_identifier::<ApubCommunity, Community>(name, context, &None, true)
+    resolve_actor_identifier::<ApubCommunity, Community>(name, &context, &None, true)
       .await
       .ok()
       .map(|c| c.id)
@@ -41,11 +40,7 @@ impl PerformApub for GetPosts {
 
   let listing_type = listing_type_with_default(data.type_, &local_site, community_id)?;
 
-    let is_mod_or_admin = is_mod_or_admin_opt(
+  let is_mod_or_admin = is_mod_or_admin_opt(context.pool(), local_user_view.as_ref(), community_id)
-      context.conn().await?,
-      local_user_view.as_ref(),
-      community_id,
-    )
     .await
     .is_ok();
 
@@ -64,6 +59,5 @@ impl PerformApub for GetPosts {
     .await
     .map_err(|e| LemmyError::from_error_message(e, "couldnt_get_posts"))?;
 
-    Ok(GetPostsResponse { posts })
+  Ok(Json(GetPostsResponse { posts }))
-  }
 }

crates/apub/src/api/mod.rs

@@ -1,21 +1,12 @@
-use activitypub_federation::config::Data;
-use lemmy_api_common::context::LemmyContext;
 use lemmy_db_schema::{newtypes::CommunityId, source::local_site::LocalSite, ListingType};
 use lemmy_utils::error::LemmyError;
 
-mod list_comments;
+pub mod list_comments;
-mod list_posts;
+pub mod list_posts;
-mod read_community;
+pub mod read_community;
-mod read_person;
+pub mod read_person;
-mod resolve_object;
+pub mod resolve_object;
-mod search;
+pub mod search;
-
-#[async_trait::async_trait]
-pub trait PerformApub {
-  type Response: serde::ser::Serialize + Send;
-
-  async fn perform(&self, context: &Data<LemmyContext>) -> Result<Self::Response, LemmyError>;
-}
 
 /// Returns default listing type, depending if the query is for frontpage or community.
 fn listing_type_with_default(

crates/apub/src/api/read_community.rs

@@ -1,9 +1,6 @@
-use crate::{
+use crate::{fetcher::resolve_actor_identifier, objects::community::ApubCommunity};
-  api::PerformApub,
-  fetcher::resolve_actor_identifier,
-  objects::community::ApubCommunity,
-};
 use activitypub_federation::config::Data;
+use actix_web::web::{Json, Query};
 use lemmy_api_common::{
   community::{GetCommunity, GetCommunityResponse},
   context::LemmyContext,
@@ -18,17 +15,12 @@ use lemmy_db_schema::source::{
 use lemmy_db_views_actor::structs::{CommunityModeratorView, CommunityView};
 use lemmy_utils::error::LemmyError;
 
-#[async_trait::async_trait]
+#[tracing::instrument(skip(context))]
-impl PerformApub for GetCommunity {
+pub async fn read_community(
-  type Response = GetCommunityResponse;
+  data: Query<GetCommunity>,
-
+  context: Data<LemmyContext>,
-  #[tracing::instrument(skip(context))]
+) -> Result<Json<GetCommunityResponse>, LemmyError> {
-  async fn perform(
+  let local_user_view = local_user_view_from_jwt_opt(data.auth.as_ref(), &context).await;
-    &self,
-    context: &Data<LemmyContext>,
-  ) -> Result<GetCommunityResponse, LemmyError> {
-    let data: &GetCommunity = self;
-    let local_user_view = local_user_view_from_jwt_opt(data.auth.as_ref(), context).await;
   let local_site = LocalSite::read(context.conn().await?).await?;
 
   if data.name.is_none() && data.id.is_none() {
@@ -43,18 +35,15 @@ impl PerformApub for GetCommunity {
     Some(id) => id,
     None => {
       let name = data.name.clone().unwrap_or_else(|| "main".to_string());
-        resolve_actor_identifier::<ApubCommunity, Community>(&name, context, &local_user_view, true)
+      resolve_actor_identifier::<ApubCommunity, Community>(&name, &context, &local_user_view, true)
         .await
         .map_err(|e| e.with_message("couldnt_find_community"))?
         .id
     }
   };
 
-    let is_mod_or_admin = is_mod_or_admin_opt(
+  let is_mod_or_admin =
-      context.conn().await?,
+    is_mod_or_admin_opt(context.conn().await?, local_user_view.as_ref(), Some(community_id))
-      local_user_view.as_ref(),
-      Some(community_id),
-    )
       .await
       .is_ok();
 
@@ -67,12 +56,11 @@ impl PerformApub for GetCommunity {
   .await
   .map_err(|e| LemmyError::from_error_message(e, "couldnt_find_community"))?;
 
-    let moderators = CommunityModeratorView::for_community(context.conn().await?, community_id)
+  let moderators = CommunityModeratorView::for_community(context.pool(), community_id)
     .await
     .map_err(|e| LemmyError::from_error_message(e, "couldnt_find_community"))?;
 
-    let site_id =
+  let site_id = Site::instance_actor_id_from_url(community_view.community.actor_id.clone().into());
-      Site::instance_actor_id_from_url(community_view.community.actor_id.clone().into());
   let mut site = Site::read_from_apub_id(context.conn().await?, &site_id.into()).await?;
   // no need to include metadata for local site (its already available through other endpoints).
   // this also prevents us from leaking the federation private key.
@@ -85,14 +73,10 @@ impl PerformApub for GetCommunity {
   let community_id = community_view.community.id;
   let discussion_languages = CommunityLanguage::read(context.conn().await?, community_id).await?;
 
-    let res = GetCommunityResponse {
+  Ok(Json(GetCommunityResponse {
     community_view,
     site,
     moderators,
     discussion_languages,
-    };
+  }))
-
-    // Return the jwt
-    Ok(res)
-  }
 }

crates/apub/src/api/read_person.rs

@@ -1,5 +1,6 @@
-use crate::{api::PerformApub, fetcher::resolve_actor_identifier, objects::person::ApubPerson};
+use crate::{fetcher::resolve_actor_identifier, objects::person::ApubPerson};
 use activitypub_federation::config::Data;
+use actix_web::web::{Json, Query};
 use lemmy_api_common::{
   context::LemmyContext,
   person::{GetPersonDetails, GetPersonDetailsResponse},
@@ -13,23 +14,17 @@ use lemmy_db_views::{comment_view::CommentQuery, post_view::PostQuery};
 use lemmy_db_views_actor::structs::{CommunityModeratorView, PersonView};
 use lemmy_utils::error::LemmyError;
 
-#[async_trait::async_trait]
+#[tracing::instrument(skip(context))]
-impl PerformApub for GetPersonDetails {
+pub async fn read_person(
-  type Response = GetPersonDetailsResponse;
+  data: Query<GetPersonDetails>,
-
+  context: Data<LemmyContext>,
-  #[tracing::instrument(skip(self, context))]
+) -> Result<Json<GetPersonDetailsResponse>, LemmyError> {
-  async fn perform(
-    &self,
-    context: &Data<LemmyContext>,
-  ) -> Result<GetPersonDetailsResponse, LemmyError> {
-    let data: &GetPersonDetails = self;
-
   // Check to make sure a person name or an id is given
   if data.username.is_none() && data.person_id.is_none() {
     return Err(LemmyError::from_message("no_id_given"));
   }
 
-    let local_user_view = local_user_view_from_jwt_opt(data.auth.as_ref(), context).await;
+  let local_user_view = local_user_view_from_jwt_opt(data.auth.as_ref(), &context).await;
   let local_site = LocalSite::read(context.conn().await?).await?;
   let is_admin = local_user_view.as_ref().map(|luv| is_admin(luv).is_ok());
 
@@ -39,7 +34,7 @@ impl PerformApub for GetPersonDetails {
     Some(id) => id,
     None => {
       if let Some(username) = &data.username {
-          resolve_actor_identifier::<ApubPerson, Person>(username, context, &local_user_view, true)
+        resolve_actor_identifier::<ApubPerson, Person>(username, &context, &local_user_view, true)
           .await
           .map_err(|e| e.with_message("couldnt_find_that_username_or_email"))?
           .id
@@ -107,15 +102,13 @@ impl PerformApub for GetPersonDetails {
   }
   .await?;
 
-    let moderates =
+  let moderates = CommunityModeratorView::for_person(context.conn().await?, person_details_id).await?;
-      CommunityModeratorView::for_person(context.conn().await?, person_details_id).await?;
 
   // Return the jwt
-    Ok(GetPersonDetailsResponse {
+  Ok(Json(GetPersonDetailsResponse {
     person_view,
     moderates,
     comments,
     posts,
-    })
+  }))
-  }
 }

crates/apub/src/api/resolve_object.rs

@@ -1,8 +1,6 @@
-use crate::{
+use crate::fetcher::search::{search_query_to_object_id, SearchableObjects};
-  api::PerformApub,
-  fetcher::search::{search_query_to_object_id, SearchableObjects},
-};
 use activitypub_federation::config::Data;
+use actix_web::web::{Json, Query};
 use diesel::NotFound;
 use lemmy_api_common::{
   context::LemmyContext,
@@ -14,34 +12,29 @@ use lemmy_db_views::structs::{CommentView, PostView};
 use lemmy_db_views_actor::structs::{CommunityView, PersonView};
 use lemmy_utils::error::LemmyError;
 
-#[async_trait::async_trait]
+#[tracing::instrument(skip(context))]
-impl PerformApub for ResolveObject {
+pub async fn resolve_object(
-  type Response = ResolveObjectResponse;
+  data: Query<ResolveObject>,
-
+  context: Data<LemmyContext>,
-  #[tracing::instrument(skip(context))]
+) -> Result<Json<ResolveObjectResponse>, LemmyError> {
-  async fn perform(
+  let local_user_view = local_user_view_from_jwt(&data.auth, &context).await?;
-    &self,
-    context: &Data<LemmyContext>,
-  ) -> Result<ResolveObjectResponse, LemmyError> {
-    let local_user_view = local_user_view_from_jwt(&self.auth, context).await?;
   let local_site = LocalSite::read(context.conn().await?).await?;
   let person_id = local_user_view.person.id;
   check_private_instance(&Some(local_user_view), &local_site)?;
 
-    let res = search_query_to_object_id(&self.q, context)
+  let res = search_query_to_object_id(&data.q, &context)
     .await
     .map_err(|e| e.with_message("couldnt_find_object"))?;
   convert_response(res, person_id, context.conn().await?)
     .await
     .map_err(|e| e.with_message("couldnt_find_object"))
-  }
 }
 
 async fn convert_response(
   object: SearchableObjects,
   user_id: PersonId,
   mut conn: impl DbConn,
-) -> Result<ResolveObjectResponse, LemmyError> {
+) -> Result<Json<ResolveObjectResponse>, LemmyError> {
   use SearchableObjects::*;
   let removed_or_deleted;
   let mut res = ResolveObjectResponse::default();
@@ -67,5 +60,5 @@ async fn convert_response(
   if removed_or_deleted {
     return Err(NotFound {}.into());
   }
-  Ok(res)
+  Ok(Json(res))
 }

crates/apub/src/api/search.rs

@@ -1,9 +1,6 @@
-use crate::{
+use crate::{fetcher::resolve_actor_identifier, objects::community::ApubCommunity};
-  api::PerformApub,
-  fetcher::resolve_actor_identifier,
-  objects::community::ApubCommunity,
-};
 use activitypub_federation::config::Data;
+use actix_web::web::{Json, Query};
 use lemmy_api_common::{
   context::LemmyContext,
   site::{Search, SearchResponse},
@@ -18,15 +15,12 @@ use lemmy_db_views::{comment_view::CommentQuery, post_view::PostQuery};
 use lemmy_db_views_actor::{community_view::CommunityQuery, person_view::PersonQuery};
 use lemmy_utils::error::LemmyError;
 
-#[async_trait::async_trait]
+#[tracing::instrument(skip(context))]
-impl PerformApub for Search {
+pub async fn search(
-  type Response = SearchResponse;
+  data: Query<Search>,
-
+  context: Data<LemmyContext>,
-  #[tracing::instrument(skip(context))]
+) -> Result<Json<SearchResponse>, LemmyError> {
-  async fn perform(&self, context: &Data<LemmyContext>) -> Result<SearchResponse, LemmyError> {
+  let local_user_view = local_user_view_from_jwt_opt(data.auth.as_ref(), &context).await;
-    let data: &Search = self;
-
-    let local_user_view = local_user_view_from_jwt_opt(data.auth.as_ref(), context).await;
   let local_site = LocalSite::read(context.conn().await?).await?;
 
   check_private_instance(&local_user_view, &local_site)?;
@@ -47,7 +41,7 @@ impl PerformApub for Search {
   let listing_type = data.listing_type;
   let search_type = data.type_.unwrap_or(SearchType::All);
   let community_id = if let Some(name) = &data.community_name {
-      resolve_actor_identifier::<ApubCommunity, Community>(name, context, &local_user_view, false)
+    resolve_actor_identifier::<ApubCommunity, Community>(name, &context, &local_user_view, false)
       .await
       .ok()
       .map(|c| c.id)
@@ -204,12 +198,11 @@ impl PerformApub for Search {
   };
 
   // Return the jwt
-    Ok(SearchResponse {
+  Ok(Json(SearchResponse {
     type_: search_type,
     comments,
     posts,
     communities,
     users,
-    })
+  }))
-  }
 }

crates/db_schema/src/schema.rs

@@ -406,6 +406,7 @@ diesel::table! {
         accepted_application -> Bool,
         totp_2fa_secret -> Nullable<Text>,
         totp_2fa_url -> Nullable<Text>,
+        open_links_in_new_tab -> Bool,
     }
 }
 

crates/db_schema/src/source/community.rs

@@ -1,6 +1,9 @@
-use crate::newtypes::{CommunityId, DbUrl, InstanceId, PersonId};
 #[cfg(feature = "full")]
 use crate::schema::{community, community_follower, community_moderator, community_person_ban};
+use crate::{
+  newtypes::{CommunityId, DbUrl, InstanceId, PersonId},
+  source::placeholder_apub_url,
+};
 use serde::{Deserialize, Serialize};
 use serde_with::skip_serializing_none;
 #[cfg(feature = "full")]
@@ -42,9 +45,9 @@ pub struct Community {
   pub icon: Option<DbUrl>,
   /// A URL for a banner.
   pub banner: Option<DbUrl>,
-  #[serde(skip_serializing)]
+  #[serde(skip, default = "placeholder_apub_url")]
   pub followers_url: DbUrl,
-  #[serde(skip_serializing)]
+  #[serde(skip, default = "placeholder_apub_url")]
   pub inbox_url: DbUrl,
   #[serde(skip)]
   pub shared_inbox_url: Option<DbUrl>,

crates/db_schema/src/source/local_user.rs

@@ -51,6 +51,8 @@ pub struct LocalUser {
   pub totp_2fa_secret: Option<String>,
   /// A URL to add their 2-factor auth.
   pub totp_2fa_url: Option<String>,
+  /// Open links in a new tab.
+  pub open_links_in_new_tab: bool,
 }
 
 #[derive(Clone, TypedBuilder)]
@@ -78,6 +80,7 @@ pub struct LocalUserInsertForm {
   pub accepted_application: Option<bool>,
   pub totp_2fa_secret: Option<Option<String>>,
   pub totp_2fa_url: Option<Option<String>>,
+  pub open_links_in_new_tab: Option<bool>,
 }
 
 #[derive(Clone, TypedBuilder)]
@@ -102,4 +105,5 @@ pub struct LocalUserUpdateForm {
   pub accepted_application: Option<bool>,
   pub totp_2fa_secret: Option<Option<String>>,
   pub totp_2fa_url: Option<Option<String>>,
+  pub open_links_in_new_tab: Option<bool>,
 }

crates/db_schema/src/source/mod.rs

@@ -1,3 +1,6 @@
+use crate::newtypes::DbUrl;
+use url::Url;
+
 #[cfg(feature = "full")]
 pub mod activity;
 pub mod actor_language;
@@ -30,3 +33,13 @@ pub mod registration_application;
 pub mod secret;
 pub mod site;
 pub mod tagline;
+
+/// Default value for columns like [community::Community.inbox_url] which are marked as serde(skip).
+///
+/// This is necessary so they can be successfully deserialized from API responses, even though the
+/// value is not sent by Lemmy. Necessary for crates which rely on Rust API such as lemmy-stats-crawler.
+fn placeholder_apub_url() -> DbUrl {
+  DbUrl(Box::new(
+    Url::parse("http://example.com").expect("parse placeholer url"),
+  ))
+}

crates/db_schema/src/source/person.rs

@@ -1,6 +1,9 @@
-use crate::newtypes::{DbUrl, InstanceId, PersonId};
 #[cfg(feature = "full")]
 use crate::schema::{person, person_follower};
+use crate::{
+  newtypes::{DbUrl, InstanceId, PersonId},
+  source::placeholder_apub_url,
+};
 use serde::{Deserialize, Serialize};
 use serde_with::skip_serializing_none;
 #[cfg(feature = "full")]
@@ -40,7 +43,7 @@ pub struct Person {
   pub banner: Option<DbUrl>,
   /// Whether the person is deleted.
   pub deleted: bool,
-  #[serde(skip_serializing)]
+  #[serde(skip, default = "placeholder_apub_url")]
   pub inbox_url: DbUrl,
   #[serde(skip)]
   pub shared_inbox_url: Option<DbUrl>,

crates/db_views/src/registration_application_view.rs

@@ -295,6 +295,7 @@ mod tests {
         totp_2fa_secret: inserted_sara_local_user.totp_2fa_secret,
         totp_2fa_url: inserted_sara_local_user.totp_2fa_url,
         password_encrypted: inserted_sara_local_user.password_encrypted,
+        open_links_in_new_tab: inserted_sara_local_user.open_links_in_new_tab,
       },
       creator: Person {
         id: inserted_sara_person.id,

crates/utils/src/rate_limit/rate_limiter.rs

@@ -195,7 +195,9 @@ impl RateLimitStorage {
   /// Remove buckets older than the given duration
   pub(super) fn remove_older_than(&mut self, duration: Duration, now: InstantSecs) {
     // Only retain buckets that were last used after `instant`
-    let Some(instant) = now.to_instant().checked_sub(duration) else { return };
+    let Some(instant) = now.to_instant().checked_sub(duration) else {
+      return;
+    };
 
     let is_recently_used = |group: &RateLimitedGroup<_>| {
       group

crates/utils/src/utils/validation.rs

@@ -8,7 +8,7 @@ use url::Url;
 static VALID_ACTOR_NAME_REGEX: Lazy<Regex> =
   Lazy::new(|| Regex::new(r"^[a-zA-Z0-9_]{3,}$").expect("compile regex"));
 static VALID_POST_TITLE_REGEX: Lazy<Regex> =
-  Lazy::new(|| Regex::new(r".*\S{3,}.*").expect("compile regex"));
+  Lazy::new(|| Regex::new(r".*\S{3,200}.*").expect("compile regex"));
 static VALID_MATRIX_ID_REGEX: Lazy<Regex> = Lazy::new(|| {
   Regex::new(r"^@[A-Za-z0-9._=-]+:[A-Za-z0-9.-]+\.[A-Za-z]{2,}$").expect("compile regex")
 });

docker/docker-compose.yml

@@ -4,7 +4,7 @@ x-logging: &default-logging
   driver: "json-file"
   options:
     max-size: "50m"
-    max-file: 4
+    max-file: "4"
 
 services:
   proxy:

migrations/2023-06-24-072904_add_open_links_in_new_tab_setting/down.sql

@@ -0,0 +1 @@
+alter table local_user drop column open_links_in_new_tab;

migrations/2023-06-24-072904_add_open_links_in_new_tab_setting/up.sql

@@ -0,0 +1 @@
+alter table local_user add column open_links_in_new_tab boolean default false not null;

src/api_routes_http.rs

@@ -9,7 +9,6 @@ use lemmy_api_common::{
     DistinguishComment,
     EditComment,
     GetComment,
-    GetComments,
     ListCommentReports,
     RemoveComment,
     ResolveCommentReport,
@@ -23,7 +22,6 @@ use lemmy_api_common::{
     DeleteCommunity,
     EditCommunity,
     FollowCommunity,
-    GetCommunity,
     HideCommunity,
     ListCommunities,
     RemoveCommunity,
@@ -39,7 +37,6 @@ use lemmy_api_common::{
     DeleteAccount,
     GetBannedPersons,
     GetCaptcha,
-    GetPersonDetails,
     GetPersonMentions,
     GetReplies,
     GetReportCount,
@@ -62,7 +59,6 @@ use lemmy_api_common::{
     EditPost,
     FeaturePost,
     GetPost,
-    GetPosts,
     GetSiteMetadata,
     ListPostReports,
     LockPost,
@@ -95,12 +91,20 @@ use lemmy_api_common::{
     PurgeCommunity,
     PurgePerson,
     PurgePost,
-    ResolveObject,
-    Search,
   },
 };
 use lemmy_api_crud::PerformCrud;
-use lemmy_apub::{api::PerformApub, SendActivity};
+use lemmy_apub::{
+  api::{
+    list_comments::list_comments,
+    list_posts::list_posts,
+    read_community::read_community,
+    read_person::read_person,
+    resolve_object::resolve_object,
+    search::search,
+  },
+  SendActivity,
+};
 use lemmy_utils::rate_limit::RateLimitCell;
 use serde::Deserialize;
 
@@ -124,12 +128,12 @@ pub fn config(cfg: &mut web::ServiceConfig, rate_limit: &RateLimitCell) {
       .service(
         web::resource("/search")
           .wrap(rate_limit.search())
-          .route(web::get().to(route_get_apub::<Search>)),
+          .route(web::get().to(search)),
       )
       .service(
         web::resource("/resolve_object")
           .wrap(rate_limit.message())
-          .route(web::get().to(route_get_apub::<ResolveObject>)),
+          .route(web::get().to(resolve_object)),
       )
       // Community
       .service(
@@ -141,7 +145,7 @@ pub fn config(cfg: &mut web::ServiceConfig, rate_limit: &RateLimitCell) {
       .service(
         web::scope("/community")
           .wrap(rate_limit.message())
-          .route("", web::get().to(route_get_apub::<GetCommunity>))
+          .route("", web::get().to(read_community))
           .route("", web::put().to(route_post_crud::<EditCommunity>))
           .route("/hide", web::put().to(route_post::<HideCommunity>))
           .route("/list", web::get().to(route_get_crud::<ListCommunities>))
@@ -186,7 +190,7 @@ pub fn config(cfg: &mut web::ServiceConfig, rate_limit: &RateLimitCell) {
           )
           .route("/lock", web::post().to(route_post::<LockPost>))
           .route("/feature", web::post().to(route_post::<FeaturePost>))
-          .route("/list", web::get().to(route_get_apub::<GetPosts>))
+          .route("/list", web::get().to(list_posts))
           .route("/like", web::post().to(route_post::<CreatePostLike>))
           .route("/save", web::put().to(route_post::<SavePost>))
           .route("/report", web::post().to(route_post::<CreatePostReport>))
@@ -225,7 +229,7 @@ pub fn config(cfg: &mut web::ServiceConfig, rate_limit: &RateLimitCell) {
           )
           .route("/like", web::post().to(route_post::<CreateCommentLike>))
           .route("/save", web::put().to(route_post::<SaveComment>))
-          .route("/list", web::get().to(route_get_apub::<GetComments>))
+          .route("/list", web::get().to(list_comments))
           .route("/report", web::post().to(route_post::<CreateCommentReport>))
           .route(
             "/report/resolve",
@@ -283,7 +287,7 @@ pub fn config(cfg: &mut web::ServiceConfig, rate_limit: &RateLimitCell) {
       .service(
         web::scope("/user")
           .wrap(rate_limit.message())
-          .route("", web::get().to(route_get_apub::<GetPersonDetails>))
+          .route("", web::get().to(read_person))
           .route("/mention", web::get().to(route_get::<GetPersonMentions>))
           .route(
             "/mention/mark_as_read",
@@ -398,23 +402,6 @@ where
   perform::<Data>(data.0, context, apub_data).await
 }
 
-async fn route_get_apub<'a, Data>(
-  data: web::Query<Data>,
-  context: activitypub_federation::config::Data<LemmyContext>,
-) -> Result<HttpResponse, Error>
-where
-  Data: PerformApub
-    + SendActivity<Response = <Data as PerformApub>::Response>
-    + Clone
-    + Deserialize<'a>
-    + Send
-    + 'static,
-{
-  let res = data.perform(&context).await?;
-  SendActivity::send_activity(&data.0, &res, &context).await?;
-  Ok(HttpResponse::Ok().json(res))
-}
-
 async fn route_post<'a, Data>(
   data: web::Json<Data>,
   context: web::Data<LemmyContext>,