Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-07 15:20:38 +00:00
Code Issues Releases Wiki Activity
7,232 Commits 67 Branches 115 Tags 1.2 GiB
e7077466ff
Commit Graph

6042 Commits

Author SHA1 Message Date
Michael Comella
e7077466ff [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: suppress MaxLineLength in Fact.toEvent. 
These double comparisons are easier to read and see the pattern of on one line
so I'd rather keep them on one line. Additionally, it's difficult to
test each change individually so I'd rather not make additional changes.
To do this, I suppressed the max line length warning.
 2021-09-30 09:13:53 +00:00
Michael Comella
d0ceaf7a7a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: remove allocations in Fact.toEvent. 
This commit was generated primarily by a macro that:
- appends `== component &&`
- appends `== item`
- (if applicable) Skips to the ending brace
- Go down one line and move cursor to the front of the line to prep for repeat

My only intervention was to skip extra lines to line it up to run again
and specify how many times in a row it should run.

---

The `to` in this code is an infix function that calls instantiates a
Pair under the hood. Subjectively observed, when this method is called
it generally hits the else case so 35 Pairs are instantiated each call -
that's 560 bytes. This method is called frequently - for example, an estimated
4 times each time a letter is typed on the homescreen and a measured 116 times
in a simple navigation (see the issue). The latter generates an estimated
63.4 KiB.

It was straightforward to remove these allocations so that's what this
change does.

The primary risk from this change is that it's difficult to test each
case to ensure it's working.
 2021-09-30 09:13:53 +00:00
Michael Comella
08a11127aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: change when (condition) { when { in Fact.toEvent. 
This will not compile. However, it enables the subsequent PR to remove
allocations from Fact.toEvent.
 2021-09-30 09:13:53 +00:00
Michael Comella
32c8709148 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: add partial test for existing factToEvent code. 
When we refactor, this will help ensure we've done it correctly.
 2021-09-30 09:13:53 +00:00
codrut.topliceanu
ed55813676 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20762 - Adds grey border to inactive tabs 2021-09-30 08:42:46 +00:00
Mozilla L10n Automation Bot
738e7b68d5 [fenix] Import l10n. 2021-09-30 00:43:30 +00:00
Elise Richards
8a77a20614 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21574: Move the homescreen onboarding card behind a feature flag 2021-09-29 22:52:42 +00:00
Mugurell
ad0f428f39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21561 - Enable/Disable the feature from the customization menu 2021-09-29 19:55:26 +00:00
Mugurell
08a71a5366 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21391 - Final design composables 
Fonts are not exactly following the Figma design but do better suit the overall
design since the other fonts are also not respecting the latest specs.
 2021-09-29 19:15:07 +00:00
Andrei Joltan
710a94b9ed [fenix] For https://github.com/mozilla-mobile/fenix/issues/21442 fix flaky deleteMultipleSelectionTest UI test (https://github.com/mozilla-mobile/fenix/pull/21563) 
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-09-29 13:45:08 -04:00
Roger Yang
c0c59f266b [fenix] No issue: Improve rendering of jump back in 2021-09-29 11:43:49 -04:00
AndiAJ
7ed672d7ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/21478 fix flaky verifyOpenTopSiteNormalTab UI test 2021-09-29 15:21:34 +00:00
Oana Horvath
005d0f01a3 [fenix] Fixed verifyAboutFirefoxPreview test according with new steps 2021-09-29 16:01:35 +03:00
Oana Horvath
01e865fee0 [fenix] Fixed disabled UI test openExternalLinksInPrivateTest 2021-09-29 16:01:35 +03:00
Roger Yang
55da682e79 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21552: Remove Extra Subtitle In Jump Back In Item 2021-09-29 02:46:34 +00:00
Roger Yang
f90fd65ccd [fenix] Fix recent tabs intermittent tests (https://github.com/mozilla-mobile/fenix/pull/21557) 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-09-28 22:10:47 -04:00
Elise Richards
b777fa32ab [fenix] For https://github.com/mozilla-mobile/fenix/issues/21339: update styles for homescreen show all buttons and jump back in spacing (https://github.com/mozilla-mobile/fenix/pull/21342) 
For https://github.com/mozilla-mobile/fenix/issues/21339: Add ignores for intermittent ui tests

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-09-28 14:40:22 -07:00
Mugurell
219561d304 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21275 - Sort items by how many times they were actually shown 2021-09-28 20:25:25 +00:00
Christian Sadilek
4702a66203 [fenix] Do not capture search terms when user navigates away via app (https://github.com/mozilla-mobile/fenix/pull/21527) 
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>

Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
 2021-09-28 14:20:58 +00:00
AndiAJ
f4a38f0a65 [fenix] Delete browsing data tests UI tests 2021-09-28 09:50:00 +00:00
AndiAJ
c1d3d97cc8 [fenix] Fix disabled toggleSearchSuggestions UI Tets and refactoring work 2021-09-28 07:49:22 +00:00
Elise Richards
32d6ee0dd3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21313: renewing performance awesomebar metrics (https://github.com/mozilla-mobile/fenix/pull/21315) 2021-09-27 15:40:21 -07:00
Roger Yang
f65770a34f [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21451: Add active search term tab groups on home 2021-09-27 21:10:57 +00:00
Arturo Mejia
c4eb7ea28b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21493 show onboarding dialog for home sections 2021-09-27 19:22:34 +00:00
codrut.topliceanu
6da619deb7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20762 - Fixes NPE crash with nullchecks for binding 2021-09-27 13:32:06 -04:00
AndiAJ
012b854d69 [fenix] Fix disabled shortcutButtonTest UI test 2021-09-27 11:15:28 +00:00
Mugurell
d701a81103 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21045: Add categories support 2021-09-27 09:57:15 +00:00
Mugurell
c37f1e550b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21045: Cleanup 
- stick to one naming scheme: rename articles to stories and use this all
throughout the app.
- add some spacing above the new section (as per the current design)
 2021-09-27 09:57:15 +00:00
Mozilla L10n Automation Bot
5a5507b490 [fenix] Import l10n. 2021-09-27 00:38:26 +00:00
Mozilla L10n Automation Bot
f5588635a2 [fenix] Import l10n. 2021-09-26 00:30:23 +00:00
Mozilla L10n Automation Bot
9dd6d98748 [fenix] Import l10n. 2021-09-25 00:44:49 +00:00
codrut.topliceanu
7ea5cdbe39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21087: Updates Recently Saved design 2021-09-24 07:42:29 +00:00
Christian Sadilek
c9e1bfe3dc [fenix] Fix mapping between history visits and groups to use createdAt 
We currently have a 15s buffer to match metadata to its corresponding
visit. However, a existing metadata record can be updated more than
15s after it was created e.g. when closing the tab and updating
the view time.
 2021-09-23 21:15:48 +00:00
Aaron Train
7f17484989 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21441: Fix changeAccessibiltySettings 2021-09-23 19:59:59 +00:00
Jonathan Almeida
d7c1238dac [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21366: Speculative fix for failing test in TitleHeaderBindingTest 2021-09-23 18:42:53 +00:00
Christian Sadilek
a6a6b6f257 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20893: Dedupe urls/site in history groups 2021-09-23 16:09:43 +00:00
Gabriel Luong
cb4b5fc613 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21460 - Rename "Delete from history" to "Remove" for recent visit dropdown menu 2021-09-23 14:26:46 +00:00
Oana Horvath
bc452b6adc [fenix] For https://github.com/mozilla-mobile/fenix/issues/17847: adding back editCustomSearchEngineTest UI test 2021-09-23 08:58:52 +00:00
AndiAJ
cc65e13b50 [fenix] Improve coverage verifyEmptyBookmarksMenuTest and undoDeleteMultipleSelectionTest UI tests 2021-09-23 08:04:40 +00:00
AndiAJ
8976e193d9 [fenix] Fix for disabled saveLoginFromPromptTest 2021-09-23 07:09:15 +00:00
Mozilla L10n Automation Bot
ba990dd118 [fenix] Import l10n. 2021-09-23 01:06:49 +00:00
Gabriel Luong
e3bc494414 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21117 - Modify layout for items displayed under "Recently Visited" in the HomeScreen to follow latest UX designs 2021-09-22 21:30:45 +00:00
Arturo Mejia
e87af643cb [fenix] For https://github.com/mozilla-mobile/fenix/issues/21239 improve telemetry values for Allow users to customize their home screen 2021-09-22 16:28:43 +00:00
Oana Horvath
15a3e30bf0 [fenix] No issue: re-enabled swipeToSwitchTabTest 2021-09-22 15:59:28 +00:00
Travis Long
023612b87d [fenix] Fix logic so isFirstRun can be called multiple times on first run 2021-09-22 15:35:28 +00:00
Travis Long
b4886fe546 [fenix] [SDK-344] Pass in first-run information to Nimbus for targeting 2021-09-22 15:35:28 +00:00
Gabriel Luong
450055a729 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21413 - Remove unused OnboardingPrivateBrowsingViewHolder and OnboardingWhatsNewViewHolder 2021-09-22 14:20:16 +00:00
Aaron Train
4a6c5b8296 [fenix] Various UI test fixes and disabling of intermittents 2021-09-22 12:57:26 +00:00
Sebastian Kaspari
10f5aa228b [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21172: Refactor UI tests accessing awesomebar suggestions. 2021-09-22 12:57:26 +00:00
Sebastian Kaspari
74500adfb5 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21172: Replace BrowserAwesomeBar view with AwesomeBar() composable. 2021-09-22 12:57:26 +00:00