e7077466ff
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21294 : suppress MaxLineLength in Fact.toEvent.
...
These double comparisons are easier to read and see the pattern of on one line
so I'd rather keep them on one line. Additionally, it's difficult to
test each change individually so I'd rather not make additional changes.
To do this, I suppressed the max line length warning.
3 years ago
d0ceaf7a7a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21294 : remove allocations in Fact.toEvent.
...
This commit was generated primarily by a macro that:
- appends `== component &&`
- appends `== item`
- (if applicable) Skips to the ending brace
- Go down one line and move cursor to the front of the line to prep for repeat
My only intervention was to skip extra lines to line it up to run again
and specify how many times in a row it should run.
---
The `to` in this code is an infix function that calls instantiates a
Pair under the hood. Subjectively observed, when this method is called
it generally hits the else case so 35 Pairs are instantiated each call -
that's 560 bytes. This method is called frequently - for example, an estimated
4 times each time a letter is typed on the homescreen and a measured 116 times
in a simple navigation (see the issue). The latter generates an estimated
63.4 KiB.
It was straightforward to remove these allocations so that's what this
change does.
The primary risk from this change is that it's difficult to test each
case to ensure it's working.
3 years ago
08a11127aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21294 : change `when (condition) {` `when {` in Fact.toEvent.
...
This will not compile. However, it enables the subsequent PR to remove
allocations from Fact.toEvent.
3 years ago
32c8709148
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21294 : add partial test for existing factToEvent code.
...
When we refactor, this will help ensure we've done it correctly.
3 years ago
ed55813676
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20762 - Adds grey border to inactive tabs
3 years ago
2a2cfe2d71
[fenix] Update Android Components version to 94.0.20210929224637.
3 years ago
738e7b68d5
[fenix] Import l10n.
3 years ago
8a77a20614
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21574 : Move the homescreen onboarding card behind a feature flag
3 years ago
ad0f428f39
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21561 - Enable/Disable the feature from the customization menu
3 years ago
08a71a5366
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21391 - Final design composables
...
Fonts are not exactly following the Figma design but do better suit the overall
design since the other fonts are also not respecting the latest specs.
3 years ago
710a94b9ed
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21442 fix flaky deleteMultipleSelectionTest UI test ( https://github.com/mozilla-mobile/fenix/pull/21563 )
...
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
c0c59f266b
[fenix] No issue: Improve rendering of jump back in
3 years ago
7ed672d7ae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21478 fix flaky verifyOpenTopSiteNormalTab UI test
3 years ago
005d0f01a3
[fenix] Fixed verifyAboutFirefoxPreview test according with new steps
3 years ago
01e865fee0
[fenix] Fixed disabled UI test openExternalLinksInPrivateTest
3 years ago
55da682e79
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21552 : Remove Extra Subtitle In Jump Back In Item
3 years ago
f90fd65ccd
[fenix] Fix recent tabs intermittent tests ( https://github.com/mozilla-mobile/fenix/pull/21557 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
dd24847b89
[fenix] Update Android Components version to 94.0.20210928190108.
3 years ago
b777fa32ab
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21339 : update styles for homescreen show all buttons and jump back in spacing ( https://github.com/mozilla-mobile/fenix/pull/21342 )
...
For https://github.com/mozilla-mobile/fenix/issues/21339 : Add ignores for intermittent ui tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
219561d304
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21275 - Sort items by how many times they were actually shown
3 years ago
4702a66203
[fenix] Do not capture search terms when user navigates away via app ( https://github.com/mozilla-mobile/fenix/pull/21527 )
...
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
f4a38f0a65
[fenix] Delete browsing data tests UI tests
3 years ago
c1d3d97cc8
[fenix] Fix disabled toggleSearchSuggestions UI Tets and refactoring work
3 years ago
32d6ee0dd3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21313 : renewing performance awesomebar metrics ( https://github.com/mozilla-mobile/fenix/pull/21315 )
3 years ago
f65770a34f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21451 : Add active search term tab groups on home
3 years ago
c4eb7ea28b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21493 show onboarding dialog for home sections
3 years ago
6da619deb7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20762 - Fixes NPE crash with nullchecks for binding
3 years ago
b08c1b8b47
[fenix] Update Android Components version to 94.0.20210927143215.
3 years ago
012b854d69
[fenix] Fix disabled shortcutButtonTest UI test
3 years ago
d701a81103
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21045 : Add categories support
3 years ago
c37f1e550b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21045 : Cleanup
...
- stick to one naming scheme: rename articles to stories and use this all
throughout the app.
- add some spacing above the new section (as per the current design)
3 years ago
5a5507b490
[fenix] Import l10n.
3 years ago
371a402a0d
[fenix] Update Android Components version to 94.0.20210926133629.
3 years ago
f5588635a2
[fenix] Import l10n.
3 years ago
81b7118139
[fenix] Update Android Components version to 94.0.20210924143217.
3 years ago
9dd6d98748
[fenix] Import l10n.
3 years ago
7ea5cdbe39
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21087 : Updates Recently Saved design
3 years ago
d10d841c11
[fenix] Update Android Components version to 94.0.20210924002420.
3 years ago
c9e1bfe3dc
[fenix] Fix mapping between history visits and groups to use createdAt
...
We currently have a 15s buffer to match metadata to its corresponding
visit. However, a existing metadata record can be updated more than
15s after it was created e.g. when closing the tab and updating
the view time.
3 years ago
7f17484989
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21441 : Fix changeAccessibiltySettings
3 years ago
d7c1238dac
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21366 : Speculative fix for failing test in TitleHeaderBindingTest
3 years ago
dc624719b5
[fenix] Update Android Components version to 94.0.20210923143204.
3 years ago
a6a6b6f257
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20893 : Dedupe urls/site in history groups
3 years ago
cb4b5fc613
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21460 - Rename "Delete from history" to "Remove" for recent visit dropdown menu
3 years ago
bc452b6adc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17847 : adding back editCustomSearchEngineTest UI test
3 years ago
cc65e13b50
[fenix] Improve coverage verifyEmptyBookmarksMenuTest and undoDeleteMultipleSelectionTest UI tests
3 years ago
8976e193d9
[fenix] Fix for disabled saveLoginFromPromptTest
3 years ago
ba990dd118
[fenix] Import l10n.
3 years ago
19c17f7f23
[fenix] Update Android Components version to 94.0.20210922143147.
3 years ago
e3bc494414
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21117 - Modify layout for items displayed under "Recently Visited" in the HomeScreen to follow latest UX designs
3 years ago
Michael Comella
codrut.topliceanu
MickeyMoz
Mozilla L10n Automation Bot
Elise Richards
Mugurell
Andrei Joltan
Roger Yang
AndiAJ
Oana Horvath
Christian Sadilek
Arturo Mejia
Aaron Train
Jonathan Almeida
Gabriel Luong