Michael Comella
e83004d81b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add & integrate StartupTypeTelemetry.
2021-04-16 15:30:26 -07:00
Michael Comella
c7f94915cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add metric perf.startup.startup_type.
2021-04-16 15:30:26 -07:00
Michael Comella
1035ad0fd0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add StartupPathProvider + tests.
2021-04-16 15:30:26 -07:00
Michael Comella
bdca7337ce
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : address lint errors for StartupStateProvider*.
2021-04-16 15:30:26 -07:00
Michael Comella
825e035db6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add getStartupStateForStartedActivity method.
2021-04-16 15:30:26 -07:00
Michael Comella
4adb237b88
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add isHotStartForStartedActivity and tests.
2021-04-16 15:30:26 -07:00
Michael Comella
b7e04b6590
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add isWarmStartForStartedActivity, tests.
2021-04-16 15:30:26 -07:00
Michael Comella
d7ad0bb813
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : shorten isColdStart... and rm questionable test.
...
The test failed with the rewrite of the code because it violates
one of our assumptions that only one Activity will be started. However,
since it doesn't rely on observed behavior and we made up the events,
it's value is questionable so it seems okay to remove, especially for
the gain of conciseness in the code.
2021-04-16 15:30:26 -07:00
Michael Comella
895f8efe13
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add VIEW to warm and hot entries.
2021-04-16 15:30:26 -07:00
Michael Comella
f5943d894c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : refactor tests to forEachHotStartEntries.
2021-04-16 15:30:26 -07:00
Michael Comella
ca1364f3b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : refactor test into forEachWarmStartEntries.
2021-04-16 15:30:26 -07:00
Michael Comella
e7d166052c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : refactor tests into forEachColdStartEntries.
2021-04-16 15:30:26 -07:00
codrut.topliceanu
2b69fd5b2a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19023 - Expands tabsTray when tabs over certain number
...
TabsTray should be collapsed when there are only a few tabs on screen, otherwise it should go straight to STATE_EXPANDED.
2021-04-16 23:35:14 +04:00
Julien Cristau
b2a420f624
[fenix] Update A-C to 75.0.20210415213638
2021-04-16 12:01:51 -04:00
Mugurell
c2a4f16fe8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18439 - Open link from QR code only if activity is not null
2021-04-16 13:08:01 +03:00
Kate Glazko
68b17ba7e8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18520 : Add Empty Tab State To Browser Tray List
2021-04-16 05:22:44 +04:00
Mozilla L10n Automation Bot
d57bcda8ef
[fenix] Import l10n.
2021-04-16 00:29:09 +00:00
Jonathan Almeida
2ce93ef3a4
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19024 : Fix intermittent test failure in NavigationInteractor
2021-04-16 02:34:23 +04:00
Jonathan Almeida
da6cd0c128
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19030 : Allow homescreen to be scrollable with extra content
2021-04-16 02:33:53 +04:00
Jonathan Almeida
4f95404df6
[fenix] No issue: Set tray dismissal from background tap
2021-04-16 02:31:13 +04:00
Jonathan Almeida
c6b9bf80d5
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19045 : Dismiss tabstray when last tab in a page is closed
2021-04-16 02:31:13 +04:00
Elise Richards
395853235f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18867 : remove "signed in as" string in three-dot menu ( https://github.com/mozilla-mobile/fenix/pull/19035 )
...
* Remove signed in as string from sync menu item
* Nav to sync account settings on click
For https://github.com/mozilla-mobile/fenix/issues/18806 : navigate to settings account page or sign in on clicking menu item.
* Confirm account exists and retrieve item title
* Remove string
2021-04-15 12:49:19 -05:00
Christian Sadilek
f134595809
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18819 : Hide Credit Card pref by default (for settings w/o icons) ( https://github.com/mozilla-mobile/fenix/pull/19058 )
2021-04-15 13:29:22 -04:00
Gabriel Luong
fd0b41c798
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18274 - [Edit card] Update a saved credit card information ( https://github.com/mozilla-mobile/fenix/pull/19032 )
2021-04-15 12:40:48 -04:00
Gabriel Luong
baea2cdf4d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18273 - [Edit card] Delete a saved credit card ( https://github.com/mozilla-mobile/fenix/pull/19029 )
2021-04-15 11:18:29 -04:00
Codrut Topliceanu
1c24731b4f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18521 - Added scroll to current tab ( https://github.com/mozilla-mobile/fenix/pull/19021 )
...
* For https://github.com/mozilla-mobile/fenix/issues/18521 - Added scroll to current tab
* For https://github.com/mozilla-mobile/fenix/issues/18521 - Addressed comments
2021-04-15 18:09:22 +03:00
Arturo Mejia
2119cfadae
[fenix] Telemetry for https://github.com/mozilla-mobile/fenix/issues/18855 , https://github.com/mozilla-mobile/fenix/issues/18851 and https://github.com/mozilla-mobile/fenix/issues/18857
...
For https://github.com/mozilla-mobile/fenix/issues/18857 [Telemetry] Send a Glean event when users change their default browser
For https://github.com/mozilla-mobile/fenix/issues/18855 [Telemetry] Send an event when users open the toolbar menu
For https://github.com/mozilla-mobile/fenix/issues/18851 [Telemetry] Send an event when users click on the "set as default browser" entry in the toolbar menu
2021-04-15 11:29:13 +03:00
Roger Yang
d72289a43d
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19003 : Add account setting to tabstray synced tab menu ( https://github.com/mozilla-mobile/fenix/pull/19034 )
2021-04-15 00:46:26 -04:00
Mozilla L10n Automation Bot
1484a591c6
[fenix] Import l10n.
2021-04-15 00:36:37 +00:00
Roger Yang
4f9a341746
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18948 : Update tabstray telemetry ( https://github.com/mozilla-mobile/fenix/pull/19004 )
2021-04-14 15:32:45 -04:00
mcarare
8e8a872127
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18854 : Add metrics for home screen being displayed.
2021-04-14 21:21:28 +03:00
mcarare
c4609f6e35
[fenix] No issue: Fix indenting in onViewCreated.
2021-04-14 21:21:28 +03:00
mcarare
8f34c26bfb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18376 : Add experiment for set default browser settings card.
2021-04-14 19:28:38 +03:00
mcarare
9dede18ff5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18853 : Add metrics for default browser new tab experiment.
2021-04-14 19:22:27 +03:00
mcarare
4ff47f6c1d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18856 : Add metrics for opening settings screen from home menu.
2021-04-14 18:50:15 +03:00
mcarare
62f839d75a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18815 : Expand app bar on onboarding dismissal and browsing start.
2021-04-14 18:09:51 +03:00
Jonathan Almeida
d10792a96e
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19011 : Always have a click listener in TabTrayViewHolder
2021-04-14 19:08:39 +04:00
Jonathan Almeida
bc628f6770
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18934 : Do not nullify adapter on window detached
...
Previously, to fix a memory leak, we were removing the adapter reference
entirely in order to have the `onDetachedFromRecyclerView` callback
invoked. This causes a side-effect where we can no longer reference the
adapter any more when we re-attach.
The simpler solution is to just invoke the needed callback directly
instead.
2021-04-14 19:00:51 +04:00
Gabriel Luong
ac29b50dfa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18272 - [Edit card] Display a saved card information in the Edit card screen ( https://github.com/mozilla-mobile/fenix/pull/18884 )
2021-04-14 10:56:23 -04:00
Oana Horvath
0ad9590e60
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18986 & https://github.com/mozilla-mobile/fenix/issues/19016 : disabled failing tests changeThemeSetting & changeAccessibiltySettings
2021-04-14 13:34:58 +03:00
MarcLeclair
4c45f615bb
[fenix] 16900 make navgraph inflation asynchronous ( https://github.com/mozilla-mobile/fenix/pull/18889 )
...
* For https://github.com/mozilla-mobile/fenix/issues/16900 : implement async navgraph inflation
For https://github.com/mozilla-mobile/fenix/issues/16900 : removed nav graph from xml
For https://github.com/mozilla-mobile/fenix/issues/16900 : inflate navGraph programatically
For https://github.com/mozilla-mobile/fenix/issues/16900 : Made NavGraph inflation asynchronous
For https://github.com/mozilla-mobile/fenix/issues/16900 : Changed to block with runBlocking
For https://github.com/mozilla-mobile/fenix/issues/16900 : Refactored blocking call into a function
For 16900: NavGraph inflation is now async
We now attach the nav graph (or check if its attached) on every nav call ( an extension function for NavController).
This is done by checking the value of the job stored in PerfNavController.map which keeps track of the job with the NavController as a Key.
If the job hasn't been completed, it will block the main thread until the job is done. The job itself is responsible for attaching the navgraph
to the navcontroller (and the inflation of the latter too)
For 16900: rebased upstream master
For 16900: Rebase on master
For https://github.com/mozilla-mobile/fenix/issues/16900 : Fixed Async Navgraph navigation per review comments.
1)The Asynchronous method is now found in NavGraphProvider.kt. It creates a job on the IO dispatcher
2)The Job is tracked through a WeakHashMap from Controller --> NavGraph
3)The Coroutine scope doesn't use MainScope() anymore
4)The Coroutine is cancelled if the Activity is destroyed
5)The tests mockk the blockForNavGraphInflation method through the FenixReoboelectricTestApplication instead of calling the mock every setup()
For https://github.com/mozilla-mobile/fenix/issues/16900 : inflateNavGraphAsync now takes navController
For https://github.com/mozilla-mobile/fenix/issues/16900 : Pass lifecycleScope to NavGraphProvider
For https://github.com/mozilla-mobile/fenix/issues/16900 : removed unused mock
For https://github.com/mozilla-mobile/fenix/issues/16900 : Added linter rules for navigate calls
We need linting rules to make sure no one calls the NavController.navigate() methods
For https://github.com/mozilla-mobile/fenix/issues/16900 : Added TestRule to help abstract the mocks in the code
For 16900: Fix linting problems
For https://github.com/mozilla-mobile/fenix/issues/16900 : Cleaned duplicated code in tests
For https://github.com/mozilla-mobile/fenix/issues/16900 : cleaned up NavGraphTestRule for finished test
For https://github.com/mozilla-mobile/fenix/issues/16900 : had to revert an accidentally edited file
For https://github.com/mozilla-mobile/fenix/issues/16900 : rebased master
* For https://github.com/mozilla-mobile/fenix/issues/16900 : Review nits for async navgraph
This is composed of squash commits, the original messages can be found below:
-> DisableNavGraphProviderAssertionRule + kdoc.
Use test rule in RobolectricApplication.
Fix failing CrashReporterControllerTest
Fix blame by -> navigate in tests.
This commit was generated by the following commands only:
```
find app/src/test -type f -exec sed -i '' "/import org.mozilla.fenix.ext.navigateBlockingForAsyncNavGraph/d" {} \;
find app/src/test -type f -exec sed -i "" "s/navigateBlockingForAsyncNavGraph/navigate/g" {} \;
git checkout app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker
```
Fix various blame
This is expected to be squashed into the first commit so, if so, it'd
fix the blame.
Move test rule to helpers pkg.
add missing license header
Add import change I missed
fix unused imports
Replace robolectricTestrunner with test rule.
Improve navGraphProvider docs
Remove unnecessary rule as defined by robolectric.
add clarifying comment to robolectric
remove unnecessary space
* For https://github.com/mozilla-mobile/fenix/issues/16900 : nit fixes for MozillaNavigateCheck and lint fixes
3 squash commits:
*Changed violation message and fixed the lint rule for MozillaNavigateCheck
*Added suppression to NavController.kt
*Fixed detekt violations
* For 16900: Fixed failing tests
Co-authored-by: Michael Comella <michael.l.comella@gmail.com>
2021-04-13 20:48:45 -04:00
Mozilla L10n Automation Bot
9d3edcecea
[fenix] Import l10n.
2021-04-14 00:32:38 +00:00
Michael Comella
e7a15807a4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : rename CreatedActivityLogEntry -> LogEntry.ActivityCreated and similar.
...
It's too much work to squash "correctly".
2021-04-13 15:10:36 -07:00
Michael Comella
073a4dc221
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : note refactor in metrics docs.
2021-04-13 15:10:36 -07:00
Michael Comella
c04e4f392d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : replace StartupActivityStateProvider with StartupStateProvider.
...
The StartupActivityStateProvider uses an imperative implementation,
driven by callbacks, to set the state of the application. This is hard
to follow as you need to understand which callbacks will be called in
which order. For example, to make sense of an implementation like this,
COLD, WARM, AND HOT would likely need to be implemented in separate
ActivityLifecycleCallbacks.
I feel the StartupStateProvider is an improvement because it leverages
the StartupActivityLog to query a linear state for a more understandable
implementation. Furthermore, it seems accessible to write COLD, WARM,
and HOT in the same class because they can all be approached the same
way.
2021-04-13 15:10:36 -07:00
Michael Comella
4411a9c84a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add StartupStateProvider.
2021-04-13 15:10:36 -07:00
Michael Comella
7d0024ab93
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : prevent StartupActivityLog from growing infinitely.
...
We do this is as a separate commit over the original implementation
because it's simpler to implement the class without this optimization.
2021-04-13 15:10:36 -07:00
Michael Comella
7286daabe9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add StartupActivityLog, tests.
2021-04-13 15:10:36 -07:00
Jonathan Almeida
5000e54aaf
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18931 : Implement add to collections in interactor
...
We moved the collection dialog code out from the old fragment, because it
had nothing to do with tabs tray, and into the collections package to be
re-usable in other parts of the app.
In addition, we also make use of it in the new tabs tray's
NavigationInteractor.
2021-04-14 01:48:35 +04:00
Jonathan Almeida
e50350db14
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18931 : Move dialog adapter to collections package
2021-04-14 01:48:35 +04:00
Jonathan Almeida
35947762b7
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18931 : Rename class to CollectionsListAdapter
2021-04-14 01:48:35 +04:00
Christian Sadilek
858320fe6b
[fenix] Upgrade to Android Components 75.0.20210413143139
2021-04-13 12:10:36 -04:00
Jonathan Almeida
167d925c12
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18934 : Remove adapter when deataching from window
2021-04-13 19:00:01 +04:00
Jonathan Almeida
4ba99372f2
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18885 : Dismiss FAB icon when tabs tray is closed
2021-04-13 18:59:16 +04:00
mcarare
ed8d36520e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18375 : Add experiment for set default browser New Tab card.
2021-04-13 17:25:51 +03:00
Elise Richards
a5d8e40932
[fenix] Add ignores for intermittent toolbar tests
2021-04-13 13:21:29 +03:00
Mozilla L10n Automation Bot
aae8d26393
[fenix] Import l10n.
2021-04-13 00:55:06 +00:00
Jonathan Almeida
df807cf612
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18973 : Fix references to info banner
2021-04-13 04:15:43 +04:00
Roger Yang
425c9d857b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18522 : Re-add call to action in tabs tray
2021-04-13 02:01:42 +04:00
Elise Richards
856e133f4d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18806 : Show sync tabs or sync account sign in based on feature flag ( https://github.com/mozilla-mobile/fenix/pull/18859 )
...
* Show sync tabs or sync account sign in based on feature flag. Sign in navigates to account settings on click.
* lint and nits
2021-04-12 16:01:33 -05:00
Roger Yang
820f3f1521
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18899 : Update content description string for synced tabs icon ( https://github.com/mozilla-mobile/fenix/pull/18963 )
2021-04-12 15:16:38 -04:00
Jonathan Almeida
5819a7c0a4
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18862 : Add multi-select banner to tabs tray ( https://github.com/mozilla-mobile/fenix/pull/18932 )
...
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Add new addBookmark BookmarksUseCase
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Add class for state binding features
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Add delete multiple tabs to tray interactor
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Add new actions to navigation interactor
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Enable select mode from main tray menu
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Add menu when in select mode
* Close https://github.com/mozilla-mobile/fenix/issues/18862 : Add multi-select banner to tabs tray
* Close https://github.com/mozilla-mobile/fenix/issues/18862 : Add select support for handle UI
We apply various layout changes to the "handle" UI in the tabs tray when
switching modes. It isn't quite clear to my, why we do this, if it's
really needed to meet the end result, and if there is a better way.
For now, we're simplying moving over that logic that we can re-evaluate
at a later time.
2021-04-12 14:57:01 -04:00
Elise Richards
298c4c2814
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18960 : Remove nav in homescreen three dot menu ( https://github.com/mozilla-mobile/fenix/pull/18962 )
...
* Remove nav in homescreen three dot menu
* Remove back and forward items
2021-04-12 13:05:58 -05:00
Arturo Mejia
22176de02c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18608 only show the experiment for set default browser MenuItem when Nightly, Beta, Release are not the default browser
2021-04-12 13:26:52 -04:00
Sören Hentzschel
0344ebb250
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18898 - implement quit button in page menu ( https://github.com/mozilla-mobile/fenix/pull/18942 )
2021-04-12 12:02:14 -05:00
Gabriel Luong
fd09f532a7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18940 - Remove reserved icon spacing for "Nimbus Experiments" setting preference ( https://github.com/mozilla-mobile/fenix/pull/18949 )
...
Co-authored-by: Sören Hentzschel <kontakt@agenedia.com>
2021-04-12 12:32:55 -04:00
Oana Horvath
8a20fdec59
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17979 & https://github.com/mozilla-mobile/fenix/issues/17840 : fix and re-enable UI tests affected by main menu changes
2021-04-12 19:16:17 +03:00
Oana Horvath
7d7f64f839
[fenix] Fix screenshots tests: showDefaultHomeScreen, bookmarksManagementTest
2021-04-12 16:21:35 +03:00
Mozilla L10n Automation Bot
62c179feee
[fenix] Import l10n.
2021-04-12 00:38:10 +00:00
Mozilla L10n Automation Bot
b9678e5dea
[fenix] Import l10n.
2021-04-11 00:25:07 +00:00
Mozilla L10n Automation Bot
ef233b706a
[fenix] Import l10n.
2021-04-10 00:31:18 +00:00
Jonathan Almeida
b543a2bd4b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15372 - Correct one more instance of the onboarding string ( https://github.com/mozilla-mobile/fenix/pull/18906 )
2021-04-09 15:21:26 -04:00
Gabriel Luong
e6912113d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18742 - Resize the top site item sizes ( https://github.com/mozilla-mobile/fenix/pull/18751 )
2021-04-09 11:47:35 -04:00
Mugurell
87b9259885
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18122 - Update browser layout for find in page bar with bottom toolbar
...
With a dynamic bottom toolbar the browser extends all the way to the bottom of
the screen and so when the find in page bar is shown it will be so above the
bottom part of the browser which may contain exactly the searched for items.
To fix the browser must effectively be placed at the top of the newly shown
find in page bar.
2021-04-09 14:48:51 +03:00
Mugurell
a7deb00521
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18616 - Update browser and toolbar layout when toolbar is at top
...
FindInPageIntegration which already updated the toolbar to make room for the
find in page bar now receives more data based on which it will be able to
better update the layout of BrowserFragment to to support showing the find in
page bar.
2021-04-09 14:48:51 +03:00
Sebastian Kaspari
a23da507c5
[fenix] Introduce process lifecycle observer to collect metrics about tabs when app goes to foreground/background.
2021-04-09 12:36:27 +02:00
Sebastian Kaspari
0d5d585dd1
[fenix] Move TelemetryMiddleware to telemetry sub package.
2021-04-09 12:36:27 +02:00
mcarare
44d32189cb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18829 : Adjust bookmark item color to UX specs.
2021-04-09 10:32:33 +03:00
Jonathan Almeida
6acd9c7925
[fenix] Update kdocs of navigation interactor
2021-04-09 06:50:05 +04:00
Jonathan Almeida
ab00590d17
[fenix] Call stop in deattach for feature binding
2021-04-09 06:50:05 +04:00
Jonathan Almeida
d2ca8da836
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18845 : Adds swipe-to-delete to tabs tray refactor
...
Copied the TabsTouchHelper from the `tabtray` package here so we don't
need to re-write our own because there's nothing more to add.
We can hook this up with our tabs tray here by putting it in the
`BaseBrowserTrayList` for our normal and private tabs list.
2021-04-09 06:50:05 +04:00
Mozilla L10n Automation Bot
a02ea9b6ab
[fenix] Import l10n.
2021-04-09 00:27:10 +00:00
Arturo Mejia
09b4cf71ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18608 Add experiment for set default browser MenuItem.
2021-04-08 15:58:43 -04:00
MarcLeclair
7ab0ea8c7f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17759 : Added min SDK 23 to avoid crashes on android 5.0 and 5.1 ( https://github.com/mozilla-mobile/fenix/pull/18832 )
...
* For https://github.com/mozilla-mobile/fenix/issues/17759 : Added min SDK 23 to avoid crashes on android 5.0 and 5.1
* For https://github.com/mozilla-mobile/fenix/issues/17759 : fixed Android code from INT to actual version name
2021-04-08 15:20:18 -04:00
Elise Richards
854bfa20f9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17870 - Enable new three-dot menu redesign on nightly builds ( https://github.com/mozilla-mobile/fenix/pull/18883 )
2021-04-08 15:19:05 -04:00
Elise Richards
f674d42d7a
[fenix] Settings menu item should be tinted if there is an account issue ( https://github.com/mozilla-mobile/fenix/pull/18849 )
2021-04-08 13:10:55 -05:00
Elise Richards
d2ad816af9
[fenix] PWA install to homescreen is available in main menu ( https://github.com/mozilla-mobile/fenix/pull/18850 )
2021-04-08 12:14:28 -05:00
Gabriel Luong
ee594f885e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18268 , https://github.com/mozilla-mobile/fenix/issues/18269 - [Saved cards] Display a list of Saved cards fetched from the credit card storage ( https://github.com/mozilla-mobile/fenix/pull/18808 )
2021-04-08 12:09:57 -04:00
Gabriel Luong
71321acb0e
[fenix] Update app/src/main/java/org/mozilla/fenix/ext/Activity.kt
2021-04-08 14:23:06 +03:00
Arturo Mejia
c057684ecd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18608 made set a default browser functionality publicly available.
2021-04-08 14:23:06 +03:00
rxu
91a05f1dd1
[fenix] Add domestic China FxA service for Mozilla Online builds
...
China fxa related string
Add switch preference in settings to use local/global fxa server
inherit fennec FxA settings
Present or hide fxa switch according to isMozillaonline
Allow China fxa server auto login during migration
2021-04-07 23:40:59 -07:00
Mozilla L10n Automation Bot
585fc80689
[fenix] Import l10n.
2021-04-08 00:39:56 +00:00
Jonathan Almeida
94e39ff584
[fenix] No issue - Enable the tabs tray refactor in nightly ( https://github.com/mozilla-mobile/fenix/pull/18858 )
2021-04-07 19:02:15 -04:00
codrut.topliceanu
dc1f62eb6e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18515 - Added Icon and sync functionality
...
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
2021-04-08 02:45:16 +04:00
codrut.topliceanu
695c777306
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18515 - Adds FAB to TabsTray rewrite
2021-04-08 02:45:16 +04:00
Gabriel Luong
33c1d58580
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18743 - Change the top sites label colour and size ( https://github.com/mozilla-mobile/fenix/pull/18752 )
2021-04-07 17:39:11 -04:00
Roger Yang
eccdb6bf8d
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18068 : Track custom fill link from clipboard clicked ( https://github.com/mozilla-mobile/fenix/pull/18827 )
2021-04-07 16:31:41 -04:00
Jonathan Almeida
1adcbf6b0d
[fenix] No issue: Move UseCase wrappers to the interactor; it's only usage
2021-04-07 21:23:09 +04:00
Jonathan Almeida
a890d0210e
[fenix] No issue: Move menu to separate integrations class
2021-04-07 21:23:09 +04:00
Jonathan Almeida
d18854c54c
[fenix] No issue: Add test for share tab in navigation interactor
...
Co-authored-by: Roger Yang <royang@mozilla.com>
2021-04-07 21:23:09 +04:00
Jonathan Almeida
3c3bf65d93
[fenix] No issue: Observe only normal tabs when updating counter
2021-04-07 21:23:09 +04:00
Jonathan Almeida
398b5823a4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18774 : Fix long parameter warnings in detekt
2021-04-07 19:14:54 +04:00
Jonathan Almeida
16f87e47e3
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18774 : Migrate mutli-selection to store
...
Removes the recyclerview-selection library and replaces it with the
SelectionHolder/SelectionInteractor with a Store.
This is an implementation that's similar to what we have in other UI
lists (library).
2021-04-07 19:14:54 +04:00
Jonathan Almeida
0b1336868c
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18774 : Move SelectionInteractor to new package
...
The interactor and holder are useful outside of the `library` package, so
let's move it up a package level for other components.
2021-04-07 19:14:54 +04:00
Arturo Mejia
d024b9bc93
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/16557 set autoplay block audio only
...
by default
2021-04-07 07:04:59 -04:00
Mozilla L10n Automation Bot
922110c303
[fenix] Import l10n.
2021-04-07 00:26:52 +00:00
Elise Richards
16c4823bef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18770 - Correct addons position in three dot menu based on toolbar position ( https://github.com/mozilla-mobile/fenix/pull/18828 )
2021-04-06 15:40:32 -04:00
Grisha Kruglov
242ea763de
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17361 : Extend perf.awesomebar.* metrics
2021-04-06 11:50:08 -07:00
Gabriel Luong
77a540b659
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18819 - Hide the Credit Card preference by default ( https://github.com/mozilla-mobile/fenix/pull/18820 )
2021-04-06 13:43:51 -04:00
Mozilla L10n Automation Bot
cb30e7fde7
[fenix] Import l10n.
2021-04-06 17:28:45 +00:00
Roger Yang
7b72b9e85b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18513 : Re-add menu to tabs tray ( https://github.com/mozilla-mobile/fenix/pull/18756 )
2021-04-06 10:26:41 -04:00
Jonathan Almeida
3ec3c16c70
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18535 : Set the span count for grid view
2021-04-06 09:57:33 +04:00
Jonathan Almeida
8fa60a67af
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18535 : Do not animate first scroll to position
...
This looks less that ideal with a grid layout that swings by from the
normal tabs to private tabs.
2021-04-06 09:57:33 +04:00
Jonathan Almeida
9e3bd75692
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18535 : Move list/grid viewholders to browser package
2021-04-06 09:57:33 +04:00
Kate Glazko
a5ea92912f
[fenix] For 17798: Sync Menu Item
2021-04-05 14:34:34 -07:00
Jonathan Almeida
94688bf59b
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/17821 : Add TabsTrayStore with actions and reducer ( https://github.com/mozilla-mobile/fenix/pull/18773 )
2021-04-05 15:12:07 -04:00
Jonathan Almeida
5beadfdb15
[fenix] No issue - Make TabLayoutMediator lifecycle aware ( https://github.com/mozilla-mobile/fenix/pull/18779 )
2021-04-05 15:10:29 -04:00
Travis Long
5b26effc9a
[fenix] [SDK-246] Change Nimbus channel
input to use the same method as Glean ( https://github.com/mozilla-mobile/fenix/pull/18766 )
...
* [SDK-246] Change Nimbus `channel` input to use the same method as Glean
* Update app/src/main/java/org/mozilla/fenix/experiments/NimbusSetup.kt
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2021-04-05 12:30:25 -04:00
VaishnaviShri
4536a2a35e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8545 : Fix unnecessary scroll in home screen
...
Changed the height of the recycler view inside the home fragment
to ‘wrap_content’ to avoid scrolling if the viewport is not filled
with elements.
Closes https://github.com/mozilla-mobile/fenix/issues/8545
2021-04-05 09:15:06 +03:00
Mozilla L10n Automation Bot
ddb145b3cb
[fenix] Import l10n.
2021-04-05 00:28:16 +00:00
Mozilla L10n Automation Bot
dba715e17a
[fenix] Import l10n.
2021-04-04 00:29:06 +00:00
Gabriel Luong
d45e4c4e42
[fenix] Use photon colors from ui-color ( https://github.com/mozilla-mobile/fenix/pull/18760 )
2021-04-03 10:26:53 -04:00
Gabriel Luong
46e6ea9e85
[fenix] No issue - Remove generic strings for more specificity ( https://github.com/mozilla-mobile/fenix/pull/18769 )
2021-04-02 15:24:28 -04:00
Mugurell
91cc54d75b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17772 - Collapse browser menu to "Add to Home screen"
...
The menu will start as collapsed.
Users can then swipe up to expand it.
2021-04-02 18:45:27 +03:00
Gabriel Luong
a13c6f3f2d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18265 - [Add card] Integrate the credit card storage and handle adding a new credit card ( https://github.com/mozilla-mobile/fenix/pull/18719 )
2021-04-02 10:40:44 -04:00
Michael Comella
028cfd0597
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18731 : remove anonymous classes from StrictModeManager.
...
After this change, I took 3 profiles: the new code appeared in the profiler
only once and only for one sample (i.e. possibly just got unlucky). It
seems to be improved. Profiles:
- https://share.firefox.dev/3wifiV2 (captured it)
- https://share.firefox.dev/39xgdHz
- https://share.firefox.dev/2QMdlA0
2021-04-01 13:19:49 -07:00
Gabriel Luong
5224c11879
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18729 - Use consistent string naming for generic strings ( https://github.com/mozilla-mobile/fenix/pull/18730 )
2021-03-31 18:20:04 -04:00
Elise Richards
990fe44056
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17770 : New tab three-dot menu reorder ( https://github.com/mozilla-mobile/fenix/pull/18427 )
...
* Create new menu order for new tab
* Add new tab menu navigation. Dynamically update menu when sync auth is needed. Make new tab menu and browser menu consistent.
* Lint
Lint and refactoring tests
* Tests for default toolbar menu
* Feature flag for request desktop site
Add todos for UI test issue 17979
Add todos for UI tests
2021-03-31 16:05:44 -05:00
mcarare
bcbd67bb07
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18717 : Use normal theme color for tab tray synced tabs.
2021-03-31 18:30:05 +04:00
Mugurell
433b0f0bdc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18617 - Use the new EngineView#getInputResultDetail()
...
All functionality should remain the same.
2021-03-31 15:36:38 +03:00
AndiAJ
5f52f0140f
[fenix] Disable failing UI Tests
2021-03-31 13:06:18 +03:00
mcarare
df747ca855
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17797 : Add bookmarks menu item.
2021-03-31 11:12:58 +03:00
Roger Yang
c164b2308b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18706 - Remove unneeded add-on telemetry calls ( https://github.com/mozilla-mobile/fenix/pull/18707 )
2021-03-30 16:19:00 -04:00
rxumoz
305bb7f48a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18386 - Change language display name to traditional/simplified Chinese for Chinese locale ( https://github.com/mozilla-mobile/fenix/pull/18387 )
2021-03-30 16:18:31 -04:00
Mihai Adrian Carare
4da13e56c1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17800 - Request desktop site from home screen. ( https://github.com/mozilla-mobile/fenix/pull/18653 )
2021-03-30 16:12:46 -04:00
Roger Yang
56fcf0e457
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18514 : Re-add tab counter in tabs tray ( https://github.com/mozilla-mobile/fenix/pull/18659 )
2021-03-30 15:43:07 -04:00
Michael Comella
b26d782c2f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18426 : add data review links.
2021-03-30 10:38:44 -07:00
Michael Comella
9c3ad5608a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18426 : warn about flaw in app_opened_all_startup
probe.
2021-03-30 10:38:44 -07:00
Michael Comella
c5bfc690d7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18426 : record cold start duration telemetry.
2021-03-30 10:38:44 -07:00
Michael Comella
f5accce70f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18426 : add StartupActivityStateProvider.
...
This will be used to filter conditions for the start up telemetry we're
adding.
2021-03-30 10:38:44 -07:00
Michael Comella
ee31fe29c2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18426 : add ApplicationStartReasonProvider.
...
We need to know this state to add a correct COLD MAIN probe.
2021-03-30 10:38:44 -07:00
Michael Comella
04af130922
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18426 : add DefaultActivityLifecycleCallbacks.
...
We'll extend this in subsequent commits.
2021-03-30 10:38:44 -07:00
Oana Horvath
6dff34ee33
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18644 : fix metod to verify system notifications
2021-03-30 18:19:02 +03:00
Jonathan Almeida
9feca460c1
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/14117 : Add Synced Tabs as a page in the tabs tray
2021-03-30 19:09:50 +04:00
Oana Horvath
e4614fd8a0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18421 : Ignore the ContextMenusTest class because of test failures
2021-03-30 17:12:49 +03:00
Gabriel Luong
4cab53bb65
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18247 - [Add card] Populate the Credit card expiry year drop down
2021-03-29 21:37:03 -04:00
Gabriel Luong
57c0eb196a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18246 - [Add card] Populate the Credit card expiry month drop down
2021-03-29 21:37:03 -04:00
Gabriel Luong
5f5d03ee19
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18243 - Add a credit card editor screen
2021-03-29 21:37:03 -04:00
Jonathan Almeida
e6d88f4669
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18521 : Focus on page corresponding to selected tab
...
This first part of https://github.com/mozilla-mobile/fenix/issues/18521 is to focus on the correct pager item first
before we land a patch for `scrollToPosition` of the selected tab.
2021-03-30 03:08:01 +04:00
Jonathan Almeida
11b1e0a461
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18668 : Add stable ID cache for TabAdapter.getItemId
2021-03-30 02:58:54 +04:00