David Walsh
7ec4bc9d76
For #10159 - Implement new tab tray colors
4 years ago
Michael Droettboom
c6086103b4
Update generated docs
4 years ago
Michael Droettboom
c373af5d46
Fix glinter errors
4 years ago
Chenxia Liu
390c5a0189
Issue #7996 : fix lint issues
4 years ago
Jovan Gerodetti
4a12f1b6aa
For #7996 : Private mode doesn't play nicely with sites added to home screen
...
Site Controls Notification should reflect the browsing mode of the
currernt web app session.
4 years ago
David Walsh
688c377197
For 10296 - Implement tab tray dimension changes
4 years ago
Arturo Mejia
56bb3e38ec
For issue #10142 Update sitePermissions state when toggling its value
4 years ago
ekager
2e27bbd15d
No issue - Remove unused data class TopSiteItem
4 years ago
Mozilla L10n Automation Bot
6d1a2ca797
Import l10n.
4 years ago
Sawyer Blatz
38e9b34659
For #10071 : Fixes PWA showing toolbar onPause ( #10306 )
4 years ago
mcarare
4006501d41
For #9728 : Add actionbar search for language list.
4 years ago
mcarare
80f74ac611
For #9728 : Change SearchView hint color inside app.
4 years ago
ekager
52d09930a6
No issue - Update new strings for quarantine
4 years ago
Mihai Eduard Badea
02bd0cc203
For issue #8648
4 years ago
Mozilla L10n Automation Bot
cdbaa52cab
Import l10n.
4 years ago
Jonathan Almeida
76002c5987
Fix breaking API changes in CrashReporter
4 years ago
Oana Horvath
2c18c255da
For #9783 : bring app in focus with sendSingleTapToScreen for UI test ( #10136 )
4 years ago
Sören Hentzschel
f0e659bfdb
For #9880 - fixed sync settings style
4 years ago
Falaye Iyanuoluwa
c86209ff98
Closes #9694 Bug when user denies permission
4 years ago
Mozilla L10n Automation Bot
b7ea583250
Import l10n.
4 years ago
mcarare
7409dc2bae
For #10083 : Do not cut off thumb when it is in pressed state
4 years ago
mcarare
3c5d8d31ea
For #10083 : Adjust thumb offset to thumb circumference to avoid cutoff
4 years ago
David Walsh
6afcd2cee6
For #10201 - Provide proper button padding and no tabs message visibility in tabs tray
4 years ago
Christian Sadilek
87c95a64d3
Configure M2 AMO collection for all builds
4 years ago
Mozilla L10n Automation Bot
88f4e5f217
Import l10n.
4 years ago
Arturo Mejia
a8843def6c
Fix CrashReporterService breaking changes
4 years ago
Arturo Mejia
e55a4fd274
No issue: Partially update the add-on manager list
4 years ago
mcarare
1aa473b112
For #9913 , For #9914 : Remove touch delegate when button is disabled.
4 years ago
Oana Horvath
21894a3cea
Added new bookmarks tests ( #9878 )
...
Fix for #7417 : Fix and re-enable disabled tests
4 years ago
ekager
a9692d9bce
For #10204 - Address viewLifecycleOwner IllegalStateException crashes
4 years ago
Mihai Branescu
a16bfb27ef
For #6557 - added unit tests
4 years ago
Mihai Branescu
0c2d22f595
For #6557 - add in_content telemetry class
4 years ago
Mihai Branescu
28496fecc0
For #6557 - split base extension functionality from ads
4 years ago
Mihai Branescu
f09bc4566c
For #6557 - added metric for in_content
4 years ago
Mihai Branescu
f10e202a1e
For #6557 - added web-extension for cookies
4 years ago
mcarare
996dabae8b
For #10188 : Fix layout constraints.
4 years ago
mcarare
0f3d4e4cbe
For #10188 : Fix xml indentations and properties order.
4 years ago
mcarare
e830da59b7
For #10180 : Remove touch delegate when button is disabled.
...
Also refactored multiple if's into a when.
4 years ago
mcarare
3e13927c25
For #10180 : Add extension to remove touch delegate from parent.
4 years ago
ekager
59484208d6
No issue: Update Private Browsing placeholder string
4 years ago
Mihai Branescu
8a80fbe14c
For #6558 - change from modifying event to event listener
...
The initial design replaced the onload method, which was used by others such as Bing.
With listeners it's additive, we do not replace anything.
4 years ago
Mihai Branescu
8e66e19dbb
For #6558 - remove baidu and yahoo from monitored pages
...
These two do not contain ad servers, so we don't need to unnecessarily monitor them
4 years ago
Mihai Branescu
c4d76dce5a
For #6558 - cleanup + added unit tests
4 years ago
Mihai Branescu
f03d65b13d
For #6558 - added logic for ad_clicked metric
4 years ago
Mihai Branescu
93ca1f6d9f
For #6558 - added handling of web extension + sending metric for has_ads
4 years ago
Mihai Branescu
c4f7972f2b
For #6558 - added web extension for extracting document urls
4 years ago
Simon Chae
f1559ed2da
For #10162 : Set switch back to prev state when failed to enable/disable addon ( #10164 )
4 years ago
Oana Horvath
e4764592fd
fix private notification text ( #10192 )
4 years ago
mcarare
2edd4b39a4
For #9913 , For #9914 : Remove button when disabling it.
...
Setting visibility to GONE allows clicks to parent view in that space.
4 years ago
Arturo Mejia
956bf01cd5
For issue #9493 : Reload after cleaning individual site permissions exceptions
4 years ago
David Walsh
6f5f48c30e
For #10148 - Add basic tab tray implementation without exposing to rest of app ( #9934 )
5 years ago
Vlad Filippov
e51e1c878b
Add 'useEmail' and 'useEmailProblem' metrics event
...
Fixes #9834
5 years ago
Simon Chae
b3248ec769
For #6123 : Expose WebExtensions in private browsing control
5 years ago
mcarare
cc67de29bf
For #10091 Also disable play/pause button when hiding it.
5 years ago
mcarare
9dd8314d14
For #10091 Add extension to remove and disable button
5 years ago
mcarare
932fd44823
For #7387 : Change ETP onboarding from popup to a dialog.
...
Recalculated dialog position and offsets.
Changed ETP onboarding dialog to show only once.
5 years ago
mcarare
72fe52fcb8
For #9987 : Set FLAG_SECURE to dialog when flag set in activity.
5 years ago
ValentinTimisica
da3fca0f29
Fixes #10109 : Adds content description for browse privately card content
5 years ago
JLRoberts
26e8d9bcca
For #9550 - Don't overlap search with shortcuts text
...
Private mode search with suggestion onboarding was overlapping "This time, search with: " text. Adjust constraints to allow it to show under onboarding when present.
5 years ago
mcarare
e11f1b62dc
For #10027 : Make toolbar context menu popup dismissible on SDK<23
5 years ago
ekager
c4e83367f6
For #6832 - Fix various fragment not attached to a context crashes
5 years ago
ekager
6457a02a82
For #2818 - Enable PiP for all builds
5 years ago
Sawyer Blatz
95f26f1fdc
For #9946 : Update FennecBeta branding ( #10066 )
5 years ago
Roger Yang
0227e953ae
Close #9760 : Add external app links context menu candidate
5 years ago
Sawyer Blatz
dce16964c0
For #9208 : Adds in-product prompt to homescreen ( #9836 )
5 years ago
Arturo Mejia
0a23d66756
For issue #7566 Handle deny & don't ask again for site permissions
5 years ago
Arturo Mejia
995da59fa8
For issue #9493 : Reload after cleaning all site permissions exceptions
5 years ago
ekager
70755adf6e
For #10036 - Workaround for System Theme changes with config change
5 years ago
Michael
1f8b7ff962
Closes #8541 : Hide find bar when entering fullscreen
5 years ago
Jeff Boek
164e6cd079
For #9816 - Adds SessionObserver to session on selection
5 years ago
Jonathan Almeida
6ad046714d
Close #9338 : Enable WebPush engine integration in all builds
5 years ago
ekager
f3847d0d7c
For #8735 - Adjust fontInflation engine setting when toggling useAutoSize
5 years ago
Mozilla L10n Automation Bot
c702de05f9
Import l10n.
5 years ago
ekager
a1554834f9
Adds destructive colors for private theme
5 years ago
codrut.topliceanu
d80005235f
For #8546 - Overrides for new TextInputLayout colors
5 years ago
ekager
66d9a24b28
Closes #9928 - Updates private browsing text description
5 years ago
ekager
5d51c4f059
Don't use ProcessLifecycleOwner for view-tied consume
5 years ago
ekager
f801f32027
No issue: Fix leaks in BookmarkFragment
5 years ago
ekager
5014cd78ec
No issue: Fix leaking sessionControlInteractor
5 years ago
isabelrios
587bdfbd7b
For #8081 - UI screenshots tests update ( #10023 )
5 years ago
Ryan Kelly
8ebb891bf8
Some cleanups for running the sync integration tests
5 years ago
Grisha Kruglov
853a0acab4
Closes #4046 : Always display 'Desktop' bookmarks folder
...
See https://github.com/mozilla-mobile/fenix/issues/4046 for a detailed discussion of this.
In short, this patch removes code that would conditionally hide desktop bookmarks depending
on the signed-in state of the browser.
5 years ago
Jonathan Almeida
c16283a923
For #9932 : Fix navigation icon theme missing from migration UI
...
Setting the `navigationBarColor` is done in the ThemeManager for the
attached activity. Since the migration UI is separate from that, we did
not get this for free.
5 years ago
Sawyer Blatz
89cfa3ea9a
For #9808 : Fix scrolling cutoff on homescreen
5 years ago
Sawyer Blatz
a8e624959e
For #6940 : Fixes top dynamic toolbar behavior ( #9900 )
5 years ago
Roger Yang
40550e88de
Close #9960 : Launch URI in Fenix if failed to launch in custom tab ( #9964 )
5 years ago
Christian Sadilek
ec1d4e8fca
For #8399 : Hide keyboard to prevent content resizes
...
This hides the keyboard after committing a URL in the
Toolbar right before we navigate from the SearchFragment
to the BrowserFragment. If the BrowserFragment is being
displayed before the keyboard is gone an expensive
resize of the engine view (content) is triggered when the
keyboard finally goes away. This is to prevent that.
5 years ago
Emily Kager
d3093e4afe
For #8428 - move about text from static_strings.xml to strings.xml and fix comment ( #10009 )
...
Co-authored-by: Sören Hentzschel <kontakt@agenedia.com>
5 years ago
Jonathan Almeida
cab0bfc073
For #8422 : Add more misc migration UI fixes
5 years ago
Michael Comella
909ee734bf
For #8803 - post: update metrics & pings data review URL.
5 years ago
Michael Comella
f3ed207bdb
For #8803 - review: Add clarifying comments to onAppInit capture methods.
5 years ago
Michael Comella
2888d66ce0
For #8803 - review: move forward metric expiration date.
...
We primarily want to determine if this is a problem area for us to
investigate rather than a long term measurement to keep so we should set
the expiration date accordingly. Furthermore, this code executes before
crash reporting is init so it's ideal to remove it sooner rather than
later.
5 years ago
Michael Comella
f49fc6dad2
For #8803 : hook up frameworkStart metric.
5 years ago
Michael Comella
dbf733d70a
For #8803 : add StartupFrameworkStartMeasurement.
...
This class controls the central logic around the metrics we want to
record.
5 years ago
Michael Comella
7f618a6a7c
For #8803 : add Stat and test.
...
We need to access the data in stat to get the process start time, so we
can calculate the time from process start until application.init for the
frameworkStart probe.
5 years ago
Michael Comella
a0c4b33b0f
For #8803 : add StartupTimeline ping type and framework_start metrics.
5 years ago
Emily Kager
39107b4036
For #9703 - Exit fullscreen in onPause and onSessionSelected ( #10016 )
...
* For #9703 - Call fullScreenChanged in onPause
* For #10015 - Exit full screen if new session selected
5 years ago
ekager
6f77ec5951
Use HomeFragment viewLifecycleOwner for BrowserSessionsObserver
5 years ago
Grisha Kruglov
0ec6d266e8
Use HomeFragment's viewLifecycleOwner as the lifecycle for accountManager observer registry
...
If we just use the HomeFragment itself, we end up with a memory leak since the lifecycle events
that would clean up the registry (e.g. destroy) won't run (if the fragment is retained in the backstack, for example).
5 years ago
Mihai Adrian
72fe9fad0c
For #9987 : Set FLAG_SECURE to dialog when flag set in activity. ( #9998 )
...
* For #9987 : Add extension to secures dialog if parent activity is secured
* For #9987 : Set FLAG_SECURE to dialog when flag set in activity
5 years ago
mozilla-l10n-automation-bot
dbbd048b6c
Import l10n. ( #10011 )
5 years ago
Emily Kager
1df9c53b9f
Fix: Set correct height for EditText ( #10014 )
...
Created a dimension for the correct height that the EditText in the
fragment_edit_bookmark.xml has to have.
Co-authored-by: DrCesar <josuejacobstercero@gmail.com>
5 years ago
Mihai Eduard Badea
725ba1e856
For #9951 - Removed the extra empty spaces that were causing the spacing issue
5 years ago
mcarare
5a2a779ef5
For #9565 : Adjust padding and height to allow longer text
5 years ago
mcarare
e87ea301ab
For #9536 : Update tests to check opened tab is in same browsing mode
5 years ago
mcarare
83d2208c6b
For #9536 : Open report issue tab depending on current browsing mode.
...
Checking if session is private uses the new browser state API.
5 years ago
mcarare
8440f1867a
For #9989 : Add start & end margin to button.
5 years ago
Sawyer Blatz
1f8f69548a
For #7158 : Fixes browser to search animation fade
5 years ago
ekager
6df11619fd
No issue: Uses NeutralButton for Migration Activity
5 years ago
Jonathan Almeida
2bb1b6edad
For #8422 : Add misc migration UI fixes
5 years ago
Jonathan Almeida
25d5b0d31c
For #8422 : Add spacing between migration items
5 years ago
ekager
4a06a228f3
For #9981 - Make Bookmark Menu UI respond to session selection
5 years ago
mcarare
25e12e2f77
For #9984 : Update addon before settings visibility check
5 years ago
Mozilla L10n Automation Bot
3e8836f71a
Import l10n.
5 years ago
ekager
688a33522b
For #9516 - Adds selectable background to dialog and snackbar buttons
5 years ago
Sawyer Blatz
8185ba793e
For #9857 : Create button style ( #9858 )
...
* For #9857 : Creates text button style
* Adds lint check
* Fixes onboarding cards
5 years ago
Jonathan Almeida
997f6c72d6
For #9409 : Add app icon to Leanplum push notifications
5 years ago
Jonathan Almeida
e97904662c
Remove duplicate FirebasePushService
...
When we moved push to it's own component the class was supposed to have
been moved but git might have only picked it up as an addition.
5 years ago
Mihai Branescu
bded28a017
For #9420 - relaxed custom engine rules ( #9967 )
...
Allow websites that return 404 to be added
Change long query param with one with higher changes of being found
5 years ago
Michael Comella
f0464b9e72
For #9644 : restrict deps to specific repositories ( #9649 )
...
* For #9644 : remove unnecessary leanplum maven repository.
The docs say it is [1] "only needed for Android SDK versions below 4.3.0".
That is API 18 and our min SDK is 21.
[1]: https://docs.leanplum.com/reference#android-setup
* For #9644 : move buildscript block from :app to root project.
This will reduce the amount of duplication we need in specifying
restricted dependencies and centralize repository definitions. Since
we're a one project app, it shouldn't have a significant impact on
performance.
* For #9644 : restrict dependencies following FFTV config.
However, there is a resolution error to be fixed in the next commit.
This is verbatim from FFTV except I removed the no-op "improve security
if code is refactored incorrectly" lines: these lines rarely changed and
I'm not that concerned. It might be better to simplify the
configuration.
Source:
62a2fa680c/buildSrc/src/main/java/org/mozilla/gradle/Dependencies.kt (L7)
62a2fa680c/build.gradle (L31)
* For #9644 : restrict firebase deps to google repo.
This fixes the resolution error from the previous PR.
5 years ago
ValentinTimisica
c7b123cfea
Fixes #9710 : Vertically aligns users_count with rating ( #9950 )
5 years ago
ekager
aef827e607
For #9887 - Respect screenshot setting when resetting window flags in logins
5 years ago
Jeff Boek
06f1b6c992
No Issue - Fixes nav_graph issues ( #9926 )
5 years ago
Arturo Mejia
37a277febb
For issue #9930 Do not assume all add-ons have a settings page
5 years ago
Mozilla L10n Automation Bot
9a298ea6ba
Import l10n.
5 years ago
ekager
2056b6f2ff
Update UI test to match Support Page title
5 years ago
ekager
55b04b9885
Update Server.dev to Server.stage to fix A-S upgrade breaking change
5 years ago
Arturo Mejia
8872baef39
Update Android Components version
5 years ago
Arturo Mejia
7c279b6e1f
No issue: Fix add-on translate() breaking change
5 years ago
ekager
5b1cdbd8bf
For #3194 - Pause media while undo snackbar appears
5 years ago
ekager
9c56a8b387
For #204 - Remove PWA Feature Flag
5 years ago
Mozilla L10n Automation Bot
69c7196e77
Import l10n.
5 years ago
Jeff Boek
4cbb9aebaf
Cleans up nav_graph.xml ( #9829 )
...
* For #9751 - Cleans up homeFragment directions
* For #9751 - Uses global actions for fragments not owned by homeFragment
* For #9751 - Cleans up SearchFragment directions
* For #9751 - Removes settings action from DeleteBrowsingDataFragment
* For #9751 - Removes browser action from SettingsFragment
* For #9751 - Adds ManagePhoneFeature global action
* For #9751 - Clean up unused deletebrowsingfragment actions
* For #9751 - Cleans Up HistoryFragment actions
* For #9751 - Removes Home -> Search action
* For #9751 - Removes the Bookmark -> Browser action
* For #9751 - Cleans up bookmark fragment actions
* For #9751 - Cleans up actions from ShareController
* For #9751 - Removes defaultBrowserFragment to browserFragment action
* For #9751 - Removes about -> browser action
* For #9751 - Adds global action to TrackingProtectionFragment
* For #9751 - Removes exception -> browser action
* For #9751 - Removes login -> browser action
* For #9751 - Fixes LoginFragment directions
* For #9751 - Removes ExternalAppBrowser directions
* for #9751 - Cleans up actions
* For #9751 - Fixes unit tests
* For #9751 - Addresses nits in PR
5 years ago
Arturo Mejia
eace991859
For issue #8520 : Improve add-ons UI
5 years ago
ekager
b8fba63be4
For #9890 - Do not display full screen snackbar with toolbar padding
5 years ago
ekager
ac3a557ddf
For #9703 - Exit full screen on pause if pip not entered
5 years ago
Sawyer Blatz
7c3394ea7c
For #9892 : Set dynamicToolbarMaxHeigtht to 0 for PWAs ( #9893 )
5 years ago
ekager
8c238402e2
For #9692 - Fix "Install" PWA menu item labeling
5 years ago
ekager
5039546dc5
For #7208 For #7212 - Update parameterized strings
5 years ago
Christian Sadilek
152642d98d
Configure M2 AMO collection for Nightly/Debug
5 years ago
Oana Horvath
52857b09d7
fix #9670 intermittent tests ( #9767 )
...
also disabled intermittent closePrivateTabsNotification
5 years ago
mcarare
8cdc523de9
For #9698 : Add unit tests for Context extension getStringWithArgSafe
5 years ago
mcarare
a214f04b4a
For #9698 : Use extension to ensure fallback to English and avoid crash
5 years ago
mcarare
4a1a875233
For #9698 : Add Context extension to avoid format IllegalArgumentException
5 years ago
Mozilla L10n Automation Bot
e1bc8dc190
Import l10n.
5 years ago
Mugurell
b72c223244
For #7157 - Set BrowserMenu width to be max 314 dp ( #9731 )
...
Instead of having a fixed width of 250dp the BrowserMenu will now have a
dynamic width between 250dp and 314dp allowing for a better fit for the menu
items it could display.
5 years ago
mcarare
1881975a31
For #9793 : Adjust relative positions to provide correct a11y traversal
5 years ago
Mozilla L10n Automation Bot
c31c198d54
Import l10n.
5 years ago
mcarare
177baf58a8
For #9798 : Disable buttons on hiding and enable on showing.
...
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
5 years ago
Simon Chae
de311aef85
Update not yet unavailable add-on string ( #9677 )
5 years ago
Roger Yang
c9141c9ae5
Close #9827 : Support display cutouts
5 years ago
Christian Sadilek
7f1ef17d8b
No issue: Re-use existing usecases for addons
5 years ago
ekager
56eb2ec1d7
For #2818 - Adds Picture-in-Picture feature
5 years ago
Mozilla L10n Automation Bot
ed466d34f7
Import l10n.
5 years ago
Michael Comella
4437ddd536
No issue: Move Do and OpenClass to utils pkg.
...
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
5 years ago
mcarare
413af92bc5
For #9797 : Set min height of dialog edit text to 48dp.
5 years ago
Abhay Agarwal
1c65bb8255
Closes #9495 : Dismiss the ShareFragment in onPause()
5 years ago
Sawyer Blatz
12d486bf02
Issue #9682 : Reduces size of branding ( #9784 )
5 years ago
Christian Sadilek
0f1bff7402
No issue: Refactor readerview to use browser-state
5 years ago
Sawyer Blatz
e94af334fc
No issue: Add more settings animations ( #9750 )
5 years ago
Mihai Eduard Badea
d66da53c9a
For #2768 - Prevent screenshots in private mode
...
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.
This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.
The setting is by default set to true (screenshots are allowed to be taken)
5 years ago
Mugurell
29539c458e
For #9770 - Disable pull to refresh pending changes
5 years ago
Mozilla L10n Automation Bot
a12cb5b0c3
Import l10n.
5 years ago
Michael Comella
9305331a56
For #9631 : remove assertk dependency.
5 years ago
Michael Comella
376740cd2c
For #9631 : replace assertk assertions with junit.
...
I created a series of editor macros to do this with minimal errors (and
to do it quickly!).
5 years ago
Jeff Boek
c632b93ee7
For #220 - Removes feature flag for language picker ( #9191 )
...
* For #220 - Removes feature flag for language picker
* For #220 - Updates Android Components
5 years ago
Mihai Adrian
dfded8e69c
For #9687 : Refactor onboarding cards to follow app architecture ( #9743 )
...
* For #9687 : Refactor onboarding cards to follow app architecture
* For #9687 : Update unit test to new controller parameters
5 years ago
Arturo Mejia
025656d8fd
For issue #9647 Crash when tapping settings after quickly
...
enabling/disabling add-on
5 years ago
Michael Droettboom
3789f50423
Fix errors in top_sites_count metric
...
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.
[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
5 years ago
Mozilla L10n Automation Bot
2d55b07935
Import l10n.
5 years ago
mcarare
cac8115e55
For #9663 : Allow more than one line for onboarding card header
5 years ago
Mozilla L10n Automation Bot
9e470c93ca
Import l10n.
5 years ago
Aaron Train
b35704beed
Closes #9688 : Disable ReaderViewTest for intermittent investigation in detection issues
5 years ago
Oana Horvath
b2da0bd922
For #9670 : Disabled intermittent tabMediaControlButton test ( #9679 )
...
and removed file created by mistake -e
added reason for disabled tests
5 years ago
Mugurell
904bfc9ebe
For #3262 - Enable pull down to refresh in Nightly
5 years ago
Michael Comella
51a76651d6
For #9605 - review: clarify comments in new test runner.
5 years ago
Michael Comella
b60a21c08d
For #9605 : Add LintUnitTestRunner gradle task.
...
This will prevent us from regressing on adding older versions of the
unit test runner.
5 years ago
Michael Comella
efef8eaba0
For #9605 : TestApplication -> FenixRobolectricTestApplication.
...
This disambiguates it from the FirefoxTestApplication used in on-device
tests.
5 years ago
Michael Comella
8df49473c0
For #9605 : move TestApplication to the helpers package.
...
The helpers/ package is created to separate the test support code from
the code under test.
5 years ago
Michael Comella
6e0d851da3
For #9605 : replace unit test runners with FenixRobolectricTestRunner.
...
This is how we can apply the new test runner to remove duplication.
This commit was generated programmatically with the following commands:
```
// Replace test runners with new one.
find app/src/test -type f -exec gsed -i "s/@RunWith(RobolectricTestRunner::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
find app/src/test -type f -exec gsed -i "s/@RunWith(AndroidJUnit4::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
// Replace imports of old test runners with new one
find app/src/test -type f -exec gsed -i "s/org.robolectric.RobolectricTestRunner/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
find app/src/test -type f -exec gsed -i "s/androidx.test.ext.junit.runners.AndroidJUnit4/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
// Remove unused imports
find app/src/test -type f -exec gsed -i "/@Config(application = TestApplication::class)/d" {} +
find app/src/test -type f -exec gsed -i "/import org.mozilla.fenix.TestApplication/d" {} +
find app/src/test -type f -exec gsed -i "/import org.robolectric.annotation.Config/d" {} +
```
Where gsed is the GNU version of sed installed via homebrew. After
running these commands, I need to manually clean up the following files:
- FenixRobolectricTestRunner
- LocaleManagerExtensionTest
5 years ago
Michael Comella
b0cfa3ee5c
For #9605 : add FenixRobolectricTestRunner.
...
This class will help us reduce duplication by specifying the
configuration within the test runner rather than each test needing to
specify it itself.
This class is adapted from Firefox for Fire TV:
https://github.com/mozilla-mobile/firefox-tv/blob/master/app/src/test/java/org/mozilla/tv/firefox/helpers/FirefoxRobolectricTestRunner.kt
5 years ago
Michael Comella
392dda5eda
For #9605 : remove unnecessary @RunWith(Robolectric in unit tests.
...
robolectric increases the run time of tests so it's important to remove
them when they're unnecessary.
Between this change and the last one, the unit test runtime was reduced
by ~10s.
5 years ago
Michael Comella
f2acef66b5
For #9605 : remove unnecessary @RunWith(AndroidJUnit4) in unit tests.
...
In unit tests, this annotation annotations defer to robolectric, non-trivially
increasing test runtime so it's important to remove them when they're
unnecessary.
5 years ago
Aaron Train
cb009f915c
No issue: re-enable libraryMenuItemsTest and backButtonTest ( #9639 )
5 years ago
MickeyMoz
f46cfc2ad2
Update Android Components version to 38.0.20200403130109.
5 years ago
Mozilla L10n Automation Bot
8413b8133d
Import l10n.
5 years ago
Michael Comella
4a8dc5b54f
No issue: add kdoc to HomeActivity.
...
We could consider renaming the Activity to make it clearer that it's the
main activity and doesn't just feature the homescreen but I'm concerned
that renaming it will break too many things (e.g. automation that starts
a specific activity). For quick fix, I added this comment.
5 years ago
Sawyer Blatz
e3ed7ed268
Issue #9128 & #9222 & #9499 : Refactors snackbar creation and fixes placement ( #9628 )
5 years ago
Codrut Topliceanu
8c43935ba3
For #7978 - Put views above button in scrollView ( #8819 )
5 years ago
Gabriel Luong
dc6d479da3
For #6174 - Add telemetry for WebExtensions ( #8318 )
5 years ago
Mihai Adrian
7043f9ee4e
For #9604 : Swap and adjust margin with padding to avoid text being cut ( #9617 )
5 years ago
Michael Comella
c15a005ca8
No issue: remove unused FirefoxTestRunner.
...
It would be used for on device tests but it doesn't seem to hooked up
currently.
5 years ago
Mozilla L10n Automation Bot
202172cd04
Import l10n.
5 years ago
mcarare
fac61fbb41
For #9422 : Nit: Fix xml indenting
5 years ago
mcarare
4d0b37a3b8
For #9422 : Align widget text to viewStart to support RTL layouts
5 years ago
Emily Kager
327009efc4
For #768 : Add first time PWA dialog ( #9308 )
...
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
5 years ago
Sebastian Kaspari
045b4a5715
Use same configuration for "forPerformanceTest" builds like we do for "fennec" flavor builds.
5 years ago
David Walsh
26137f63a2
Prevent favicons from flashing when items are selected in History ( #9233 )
5 years ago
Mihai Adrian
8cd6d7460c
For #9336 Check current destination before navigating ( #9353 )
...
* For #9336 Check current destination before navigating
* For #9336 Update unit test to check for navigateSafe
5 years ago
Mihai Adrian
90787cf630
For #9423 : Align preference title and summary to viewStart ( #9426 )
...
* For #9423 : Align preference title and summary to viewStart
* Update checkbox_left_preference_etp.xml
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
5 years ago