This feature allows a private tab to be reopened as a regular tab. The
feature is only enabled for users with the "Open links in a private tab"
option enabled - such users who follow links from external applications
will always have these tabs opened as private, so may wish to "opt-out"
of individual tabs being private.
Users without this option set will not have private tabs opened by
default, so have already opted-in to each private tab - thus, those users
are unlikely to benefit from this feature.
The feature is added to the main menu - however, as above, it will only
be visible when a private tab is open *and* "Open links in a private tab"
is enabled, so will only be seen by a minority of users.
The feature is also enabled only for Nightly while it is polished, but
the intention is that it eventually ride to release.
Rather than tracking that the CFR was shown to the user when the
user explicitly interacts with it (dismiss or action tap),
we will track it when the CFR was shown, not considering how the
user dismissed it.
Added `surface_powered_by_fakespot_link_clicked` telemetry probe
that is sent when the user taps the "Powered by Fakespot by Mozilla"
footer link in Review Checker Sheet.
Using `.inc()` was wrong due to it returning the incremented
value and not incrementing the already existing one. This
patch aims to fix that, therefore showing the CFR correctly
for max 3 times.
This commit:
* Adds an `AwesomeBarView.SearchResultFilter` type, with variants to
only include results for the current search engine (`CurrentEngine`)
and exclude results with a matching query parameter
(`ExcludeSponsored`).
* Adds a `String.urlContainsQueryParameters` extension function for
using the `ExcludeSponsored` filter with the synced tabs provider.
* Refactors the `AwesomeBarView.get*Provider` methods to take an
optional `SearchResultFilter`.
This commit:
* Changes the bookmarks, history, session, and synced tabs suggestion
providers to take an optional predicate that filters matching
suggestions by `Uri` (bookmarks, history, session) or URL string
(synced tabs), instead of comparing the suggestions' URLs directly.
* Hoists the host matching checks out of the providers.
The current onboarding CFR is set to show the first time someone
lands on a product detail page. If the user dismisses the CFR and
does not opt-in, we show it on the next product detail page after at
least 24 hours have elapsed.
This patch changes this to showing the CFR up to 3X (instead of 2)
with at least 12 hrs in-between (instead of 24).
This commit:
* Adds new facts, `wikipedia_suggestion_clicked` and
`wikipedia_suggestion_impressed`, to the `feature-fxsuggest`
component.
* Emits `fx-suggest` Glean pings for those facts in Fenix's
`MetricController`.
