Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-15 18:12:54 +00:00
Code Issues Releases Wiki Activity

Bug 1858882 - Update "Learn More" link in private browsing description

Browse Source
This commit is contained in:
Harrison Oglesby 2023-11-03 10:27:54 -07:00 committed by mergify[bot]
parent 72dbea410c
commit 0f1bd3f7f8
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/src/main/java/org/mozilla/fenix/home/privatebrowsing/controller/PrivateBrowsingController.kt
View File

@ -41,8 +41,11 @@ class DefaultPrivateBrowsingController(
) : PrivateBrowsingController {
override fun handleLearnMoreClicked() {
val learnMoreURL = SupportUtils.getGenericSumoURLForTopic(SupportUtils.SumoTopic.PRIVATE_BROWSING_MYTHS) +
"?as=u&utm_source=inproduct"
activity.openToBrowserAndLoad(
searchTermOrURL = SupportUtils.getGenericSumoURLForTopic(SupportUtils.SumoTopic.PRIVATE_BROWSING_MYTHS),
searchTermOrURL = learnMoreURL,
newTab = true,
from = BrowserDirection.FromHome,
)

6
app/src/test/java/org/mozilla/fenix/home/privatebrowsing/DefaultPrivateBrowsingControllerTest.kt
View File

@ -27,7 +27,6 @@ import org.mozilla.fenix.components.appstate.AppState
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.ext.settings
import org.mozilla.fenix.home.privatebrowsing.controller.DefaultPrivateBrowsingController
import org.mozilla.fenix.settings.SupportUtils
import org.mozilla.fenix.utils.Settings
class DefaultPrivateBrowsingControllerTest {
@ -60,12 +59,13 @@ class DefaultPrivateBrowsingControllerTest {
@Test
fun `WHEN private browsing learn more link is clicked THEN open support page in browser`() {
val learnMoreURL = "https://support.mozilla.org/en-US/kb/common-myths-about-private-browsing?as=u&utm_source=inproduct"
controller.handleLearnMoreClicked()
verify {
activity.openToBrowserAndLoad(
searchTermOrURL = SupportUtils.getGenericSumoURLForTopic
(SupportUtils.SumoTopic.PRIVATE_BROWSING_MYTHS),
searchTermOrURL = learnMoreURL,
newTab = true,
from = BrowserDirection.FromHome,
)