2
0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-15 18:12:54 +00:00
Commit Graph

6245 Commits

Author SHA1 Message Date
Christian Sadilek
0751190582 [fenix] Handle new OptimizedLoadUrlAction in history metadata middleware
Upgrades to A-C 95.0.20211013154351
2021-10-13 15:45:00 -04:00
Jonathan Almeida
4fee8036a0 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21794: Remove rotation; rely on state activated
It seems like we no longer need to use rotation for the chevron, since
we are now using two different icons within the `ic_chevon` that change
depending on the `state_activated`.
2021-10-13 19:27:49 +00:00
sunil9211
45330287b4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17393: Dead code removed around Delete downloads 2021-10-13 15:08:07 +00:00
AndiAJ
7638040a3a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix and re-enable editCustomSearchEngineTest 2021-10-13 14:01:02 +00:00
Arturo Mejia
0658de464f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21791 Adds tab auto-close prompt 2021-10-13 12:08:59 +00:00
AndiAJ
1bb5f1479d [fenix] Disable editCustomSearchEngineTest UI test 2021-10-13 06:37:00 +00:00
Arturo Mejia
d6ae910c74 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21838 wait until experiments have been completely opt-out on the nimbus SDK. 2021-10-12 19:31:35 -04:00
AndiAJ
6a7c42a398 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21620 fix for disabled toggleSearchSuggestions UI test 2021-10-12 16:06:09 +00:00
AndiAJ
f0091a768c [fenix] For https://github.com/mozilla-mobile/fenix/issues/19016 re-enable changeThemeSetting Ui test 2021-10-12 15:14:19 +00:00
Mugurell
ec442f575f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21861 - Ignore the UnusedResources lint check for localized strings 2021-10-12 14:48:47 +00:00
AndiAJ
7f9dab5654 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix disabled editCustomSearchEngineTest 2021-10-12 14:23:33 +00:00
Oana Horvath
3ea7755592 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21006 & https://github.com/mozilla-mobile/fenix/issues/21005: fixed ETP status info display 2021-10-12 06:26:44 +00:00
Elise Richards
897aa4b662 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21522: Wrap section titles on home 2021-10-09 04:16:40 +00:00
Elise Richards
86029b181c [fenix] For https://github.com/mozilla-mobile/fenix/issues/21313: Renew fission metrics expiring in December 2021-10-09 03:42:00 +00:00
Roger Yang
c7232a0bdb [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686: Stop using internally stored tabs list in adapters 2021-10-09 02:43:26 +00:00
Mugurell
f10d226f92 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21806 - Set 1dp elevation for ListItemTabLarge
To get smaller shadows.
2021-10-08 23:22:44 +00:00
Mugurell
cde1c3b911 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Simplify test to not depend on store updates. 2021-10-08 18:45:30 -04:00
Mugurell
e22e33c3c9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Replace mock of an interface with mock of a fake. 2021-10-08 18:45:30 -04:00
Christian Sadilek
b916fc4a85 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21437: Fix default of start_on_home setting in UI 2021-10-08 18:33:55 -04:00
Gabriel Luong
ff62ffe70a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21809 - Adjust the padding between the Pocket section 2021-10-08 20:37:56 +00:00
Jonathan Almeida
d13f0ef797 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21794: Reverse chevron for inactive tabs 2021-10-08 20:04:40 +00:00
MickeyMoz
16ed26781d [fenix] Update Android Components version to 95.0.20211008105820. 2021-10-08 14:17:27 +00:00
AndiAJ
aa6387809d [fenix] Remove openNewTabAndEnterToBrowser() and replace it with enterURLAndEnterToBrowser() in the UI tests 2021-10-08 11:16:54 +00:00
AndiAJ
153bfcce38 [fenix] Remove closeTabViaXButton() and replace it with closeTab() in the UI tests 2021-10-08 11:16:54 +00:00
AndiAJ
3317d98b34 [fenix] Fix for ambiguous mozac_browser_tabstray_close and with content description 2021-10-08 11:16:54 +00:00
AndiAJ
7dd7b2e5b2 [fenix] Fix for ambiguous tabstray_title and with text 2021-10-08 11:16:54 +00:00
AndiAJ
d6755b5580 [fenix] Fix for ambiguous tabstray_close 2021-10-08 11:16:54 +00:00
AndiAJ
75606a8786 [fenix] Fix for ambiguous tab_item 2021-10-08 11:16:54 +00:00
codrut.topliceanu
822775eb9d [fenix] For https://github.com/mozilla-mobile/fenix/issues/20992 - Speculative fix for TopSitesPagerAdapter crash 2021-10-08 07:59:42 +00:00
Jonathan Almeida
363e563fc7 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686: Move submitList calls into TabsAdapter
Co-authored-by: Roger Yang <royang@mozilla.com>
2021-10-08 05:36:48 +00:00
Noah Bond
39a3aacc78 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21773 - Updated "customize homepage" button to go to the new Homepage submenu in Settings 2021-10-07 23:45:43 +00:00
Christian Sadilek
d73ea2cf98 [fenix] Enable pocket stories in CA 2021-10-07 21:57:56 +00:00
Arturo Mejia
185121606c [fenix] Prepare nimbus features default values for release 95 2021-10-07 20:44:44 +00:00
Rohan Maity
2fc70778a9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20579: Fix the normal browing tab re-used unexpectedly when open links in private tab enabled or same tab is already avaialble in normal browsing mode 2021-10-07 19:48:16 +00:00
Arturo Mejia
a4fcc93d0a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21765 only activate pocket by default for the right audience 2021-10-07 15:30:18 +00:00
Mugurell
e6a73b5118 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21623 - Pocket recommended stories telemetry 2021-10-07 08:36:00 +00:00
Michael Comella
257ae4b118 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21424: add marker for StrictMode.resetAfter.
This helps identify file IO. Unfortunately, with this marker, it's
difficult to separate code we own from code we don't own. However, I
wasn't sure what the best implementation would be to address that
(e.g. ideally, we would ignore violations in code we don't own rather than
annotate the markers) so I thought we can land it this simple way and
improve it incrementally.
2021-10-07 07:39:51 +00:00
Gabriel Luong
e3b2309ac2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21756 - Refactor TopSites out of home.sessioncontrol 2021-10-06 21:47:36 +00:00
Noah Bond
b772f6d080 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen (https://github.com/mozilla-mobile/fenix/pull/21722)
* For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen

* For https://github.com/mozilla-mobile/fenix/issues/21437 - Updated show top sites toggle text

* PR: Fixed lint warning. Reverted preference keys

* PR: added ignore for UI test

* PR: Added ignore for UI test
2021-10-06 21:01:16 +00:00
Roger Yang
259b2e5d30 [fenix] No issue: Update Pocket categories spacing to 16dp. 2021-10-06 19:52:55 +00:00
Sebastian Kaspari
a4e21f4fbb [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21102: Set compileSdkVersion to 31. 2021-10-06 17:30:08 +00:00
Roger Yang
c9d8e826ca [fenix] No issue: Small layout update for Pocket Stories 2021-10-06 17:01:32 +00:00
Gabriel Luong
398bdac5aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/21729 - Refactor SectionHeader to use the right font size 2021-10-06 15:38:35 +00:00
Sebastian Kaspari
e487bc6f59 [fenix] SearchDialogFragment: Start to split consumeFrom() into independent observers that trigger less often 2021-10-06 10:32:59 +00:00
Arturo Mejia
3e01e9df25 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21611: Show the jump back in Contextual Hints independently of the home onboarding dialog. 2021-10-06 03:21:41 +00:00
Arturo Mejia
f4f7c1b0e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21574: disabled the homescreen onboarding dialog. 2021-10-06 03:21:41 +00:00
Roger Yang
2594eac89e [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21573: Update design for jump back in section and recently bookmarked section 2021-10-05 21:43:08 +00:00
codrut.topliceanu
bdc54a1465 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21708 - Fixes missing header bottom border
The bottom gray border of the header item from the Inactive Tabs section was correctly set when collapsing or expanding said section, but not on init. So if the section was initialized collapsed the gray border would not be present.
2021-10-05 20:46:16 +00:00
Arturo Mejia
622e713c07 [fenix] Update feature flags for 94. 2021-10-05 18:02:38 +00:00
AndiAJ
09c8890055 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20814 fix flaky tabMediaControlButtonTest UI test 2021-10-05 11:09:29 +00:00
Mugurell
5baa97270c [fenix] For https://github.com/mozilla-mobile/fenix/issues/21599 - Add UTM parameters for Pocket recommendations links 2021-10-05 10:33:45 +00:00
codrut.topliceanu
f372c5c69f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21565 - Adds inactive tabs onboarding popup 2021-10-05 10:00:33 +00:00
Mugurell
e606d8c42a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to home composables.
Added from the ViewHolders, the same as for XML Views.
2021-10-05 07:03:21 +00:00
Mugurell
dc66fea1e6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to all normal browsing home items 2021-10-05 07:03:21 +00:00
Mugurell
07d08eb655 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to the private browsing home description 2021-10-05 07:03:21 +00:00
Mugurell
8f6a6d0980 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to all onboarding items 2021-10-05 07:03:21 +00:00
Mugurell
11b92bbd99 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Remove the parent horizontal padding 2021-10-05 07:03:21 +00:00
Jonathan Almeida
2e597529c8 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21582: Use ThumbnailStorage in recent tabs on home 2021-10-05 06:33:18 +00:00
Gabriel Luong
fde5b755e3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21694 - Remove RoundedCornerShape around the inner Column in RecentlyVisited 2021-10-04 22:48:30 +00:00
Gabriel Luong
8a78101fc4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21694 - Only show the divider line in between items in the Recent Searches 2021-10-04 22:48:30 +00:00
Jonathan Almeida
33cf85203a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21642: Remove in-progress media tab from homescreen 2021-10-04 18:03:34 -04:00
Christian Sadilek
5385b96abe [fenix] Move tabs out of search group if direct load occurs
This regressed in our previous fix that made sure child tabs don't
mistakenly get moved out of the group if their parent is navigated
away, or in case the child tabs are redirected.

However, when a subsequent load occurs in any tab in the group the
search terms need to be cleared and the tab removed from the group
to prevent false positives.
2021-10-04 17:30:49 -04:00
Elise Richards
3db298543e [fenix] CI for Fix description for home_screen_displayed metric (https://github.com/mozilla-mobile/fenix/pull/21697)
* Fix description for `home_screen_displayed` metric

The current description appears to be incorrect by my reading of the source.

* Update app/metrics.yaml

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>

Co-authored-by: Will Lachance <wlachance@mozilla.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2021-10-04 13:59:02 -07:00
Elise Richards
3631014159 [fenix] CI for Docs: Add extra context to events.browser_menu_action (https://github.com/mozilla-mobile/fenix/pull/21696)
* Docs only: Add extra context to `events.browser_menu_action`

This came up as a potential point of confusion in a discussion with DS. This is a docs only change.

* Update metrics.yaml

Co-authored-by: Will Lachance <wrlach@gmail.com>
2021-10-04 20:10:49 +00:00
Gabriel Luong
efab5cbb1d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21658 - Don't pass Client into composable functions 2021-10-04 19:06:30 +00:00
Jonathan Almeida
3d69371557 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21671: Remove Recently Closed from Inactive Tabs 2021-10-04 15:50:27 +00:00
Mugurell
7e65b07930 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor the coroutine from PocketStoriesShown to outside the middleware
In so this code will no longer have access to the MiddlewareContext which only
makes sense in the thread of the Middleware itself.
2021-10-04 11:54:42 +00:00
Mugurell
6261e570c3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Persist stories categories selections in a Proto DataStore
A fast and easy solution with all the ACID requirements.
Also supports easy migrations if later the data we need persisted changes.
2021-10-04 11:54:42 +00:00
Mugurell
4f4586d85f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor out "isSelected" from PocketRecommendedStoriesCategory
Having the list of categories and the list of selected categories separate in
State allows updating them independently.
2021-10-04 11:54:42 +00:00
AndiAJ
7b031b0504 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21644 fix disabled alwaysStartOnHomeTest UI test 2021-10-04 10:34:56 +00:00
Jonathan Almeida
884c8c2224 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21576: Hide 'Other' title when there are no search groups 2021-10-04 08:56:20 +00:00
Mugurell
20f07022d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21626 - Avoid showing story invalid properties 2021-10-04 07:33:31 +00:00
Arturo Mejia
8a4bb26526 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21618: Integrate Nimbus with MR2 Home Page to enable experimentation 2021-10-04 00:39:59 +00:00
Arturo Mejia
21480b89ea [fenix] For https://github.com/mozilla-mobile/fenix/issues/21611: Add jump back in Contextual Hints 2021-10-03 23:16:37 +00:00
Jonathan Almeida
51000bcfa4 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21632: Correct inactive tabs survey string (https://github.com/mozilla-mobile/fenix/pull/21669) 2021-10-03 14:29:39 +00:00
Christian Sadilek
c1f2c33a76 [fenix] Make search term grouping tolerant to (parent tab) navigation
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
2021-10-02 08:51:25 +00:00
Elise Richards
d70d0610d0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21648: match Pocket sections on home to designs 2021-10-02 08:24:09 +00:00
Jonathan Almeida
0c5285cf05 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21641: Do not add a group of only one tab 2021-10-02 04:00:02 -04:00
Elise Richards
ad1cff2300 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21653: pre-land section title for tab preferences 2021-10-02 00:53:00 +00:00
Noah Bond
4f07d1a40f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21360 - Added toggle for search term tab groups (https://github.com/mozilla-mobile/fenix/pull/21615)
* For https://github.com/mozilla-mobile/fenix/issues/21360  - Added toggle for search term tab groups

* For https://github.com/mozilla-mobile/fenix/issues/21360 - Lint cleanup

* PR: Added missing licenses and possibly fixed UI test

* PR: Added a "scrollTo" to potentially fix a UI test

* PR: Added potential fix for alwaysStartOnHomeTest

* PR: Added temporary ignore to alwaysStartOnHomeTest

* PR: added missing ignore comment

* For https://github.com/mozilla-mobile/fenix/issues/21360 - Added missing feature flag driven visibility logic

Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-10-02 00:25:12 +00:00
Elise Richards
f12124b948 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21646: Update section titles and customize button name on home 2021-10-01 23:51:48 +00:00
Elise Richards
b9f5e56c37 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21643: Pre-land strings for inactive tabs CFR. Update section title for normal, non-search group tabs. (https://github.com/mozilla-mobile/fenix/pull/21645) 2021-10-01 14:23:24 -07:00
Noah Bond
44f1f679e7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21635 - Preland strings for tab auto close message (https://github.com/mozilla-mobile/fenix/pull/21636)
* For https://github.com/mozilla-mobile/fenix/issues/21635 - Prelanded strings for tab auto close message

* PR: Updated String descriptions and added temporary tools ignore
2021-10-01 20:37:51 +00:00
Gabriel Luong
33381f78f7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21632 - Preland strings for the inactive tab survey 2021-10-01 19:51:59 +00:00
Biren-Nayak
bd610d394f [fenix] For https://github.com/mozilla-mobile/fenix/issues/16437: Remove unnecessary space for tracking protection exceptions 2021-10-01 19:15:00 +00:00
Mugurell
4e5047d203 [fenix] For https://github.com/mozilla-mobile/fenix/pull/21392 - Update new strings descriptions. 2021-10-01 18:03:12 +00:00
Christian Sadilek
1d537cb332 [fenix] Allow opening pocket stories when search dialog is active 2021-10-01 16:03:59 +00:00
Oana Horvath
1f628f8e52 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540, https://github.com/mozilla-mobile/fenix/issues/21620: disables failing UI tests 2021-10-01 15:03:35 +00:00
Oana Horvath
4967527781 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21441, https://github.com/mozilla-mobile/fenix/issues/21477, https://github.com/mozilla-mobile/fenix/issues/21500, https://github.com/mozilla-mobile/fenix/issues/21499 https://github.com/mozilla-mobile/fenix/issues/21476, https://github.com/mozilla-mobile/fenix/issues/21474: retry dismissing the search bar 2021-10-01 08:38:03 +00:00
Roger Yang
1da6397453 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21610: Update Strings for Tab Settings 2021-10-01 06:31:50 +00:00
Mozilla L10n Automation Bot
2311ac81df [fenix] Import l10n. 2021-10-01 03:27:40 +00:00
Arturo Mejia
5e57ece039 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21611: Add jump back in contextual hint text 2021-09-30 22:40:30 -04:00
Roger Yang
1f11b81bc4 [fenix] No issue: Make sure jump back in group always have more than one tab 2021-09-30 22:33:50 -04:00
Gabriel Luong
4d23db624f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21551 - Add delete history metadata in the History view
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2021-09-30 22:30:19 -04:00
Elise Richards
dc1e5e640e [fenix] For https://github.com/mozilla-mobile/fenix/issues/21287: long press menu on recently visited homescreen groups 2021-09-30 22:00:18 -04:00
Arturo Mejia
e1a2b9ccfa [fenix] For https://github.com/mozilla-mobile/fenix/issues/21608: Update strings for home screen dialog features 2021-10-01 01:51:07 +00:00
Grisha Kruglov
485ca898f2 [fenix] Do not show home screen behind search if we have search terms
Home screen isn't actually visible in case we're displaying awesomebar
search results. The navigation is thus unnecessary and actually causes visual
jankiness as we display home for a moment before covering it up with
search results.
2021-09-30 18:14:16 -04:00
Jan-Erik Rediger
0a08c61e8d [fenix] Don't manually exclude glean-native
The latest geckoview-omni package correctly declares its capabilities,
including the `glean-native` one.
Additionally it is able to pick geckoview-omni over glean-native in all
configurations.
2021-09-30 19:51:29 +00:00
Noah Bond
f2b7eea088 [fenix] Inactive tabs changes (https://github.com/mozilla-mobile/fenix/pull/21524)
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Moved inactive tabs to the top of the normal tabs tray.

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Added a delete icon to delete ALL inactive tabs.

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Changed default inactive time period to 14 days

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Hooked inactive tabs setting to UI code

Inactive tabs setting is also disabled when the user has selected the one day or week auto-close tab setting.

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - File and Lint cleanup

* PR: Fixed bug causing grouped tabs to also show in "Other" when marked as inactive but inactive is OFF in Settings

* PR: Fixed lint warnings

* PR: Removed redundant feature check

* PR - Ignore test until search term tab groups switch is done
2021-09-30 19:01:31 +00:00
Mugurell
4fac910adf [fenix] For https://github.com/mozilla-mobile/fenix/issues/21592 - Don't topup with general stories 2021-09-30 15:54:21 +00:00
Mugurell
92bc5e93b1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21562 - Snap to next item when scrolling
This works by replacing the fling animation with snapping to the next item in
the scroll direction.
2021-09-30 14:57:17 +00:00
Aaron Train
e7b2578a5a [fenix] No issue: Fix AssertionError in openThreeDotMenu
fix: ktlint
2021-09-30 14:06:13 +00:00
AndiAJ
c7658e352d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix flaky editCustomSearchEngineTest UI test 2021-09-30 10:30:27 +00:00
Michael Comella
e7077466ff [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: suppress MaxLineLength in Fact.toEvent.
These double comparisons are easier to read and see the pattern of on one line
so I'd rather keep them on one line. Additionally, it's difficult to
test each change individually so I'd rather not make additional changes.
To do this, I suppressed the max line length warning.
2021-09-30 09:13:53 +00:00
Michael Comella
d0ceaf7a7a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: remove allocations in Fact.toEvent.
This commit was generated primarily by a macro that:
- appends `== component &&`
- appends `== item`
- (if applicable) Skips to the ending brace
- Go down one line and move cursor to the front of the line to prep for repeat

My only intervention was to skip extra lines to line it up to run again
and specify how many times in a row it should run.

---

The `to` in this code is an infix function that calls instantiates a
Pair under the hood. Subjectively observed, when this method is called
it generally hits the else case so 35 Pairs are instantiated each call -
that's 560 bytes. This method is called frequently - for example, an estimated
4 times each time a letter is typed on the homescreen and a measured 116 times
in a simple navigation (see the issue). The latter generates an estimated
63.4 KiB.

It was straightforward to remove these allocations so that's what this
change does.

The primary risk from this change is that it's difficult to test each
case to ensure it's working.
2021-09-30 09:13:53 +00:00
Michael Comella
08a11127aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: change when (condition) { when { in Fact.toEvent.
This will not compile. However, it enables the subsequent PR to remove
allocations from Fact.toEvent.
2021-09-30 09:13:53 +00:00
Michael Comella
32c8709148 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: add partial test for existing factToEvent code.
When we refactor, this will help ensure we've done it correctly.
2021-09-30 09:13:53 +00:00
codrut.topliceanu
ed55813676 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20762 - Adds grey border to inactive tabs 2021-09-30 08:42:46 +00:00
Mozilla L10n Automation Bot
738e7b68d5 [fenix] Import l10n. 2021-09-30 00:43:30 +00:00
Elise Richards
8a77a20614 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21574: Move the homescreen onboarding card behind a feature flag 2021-09-29 22:52:42 +00:00
Mugurell
ad0f428f39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21561 - Enable/Disable the feature from the customization menu 2021-09-29 19:55:26 +00:00
Mugurell
08a71a5366 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21391 - Final design composables
Fonts are not exactly following the Figma design but do better suit the overall
design since the other fonts are also not respecting the latest specs.
2021-09-29 19:15:07 +00:00
Andrei Joltan
710a94b9ed [fenix] For https://github.com/mozilla-mobile/fenix/issues/21442 fix flaky deleteMultipleSelectionTest UI test (https://github.com/mozilla-mobile/fenix/pull/21563)
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-09-29 13:45:08 -04:00
Roger Yang
c0c59f266b [fenix] No issue: Improve rendering of jump back in 2021-09-29 11:43:49 -04:00
AndiAJ
7ed672d7ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/21478 fix flaky verifyOpenTopSiteNormalTab UI test 2021-09-29 15:21:34 +00:00
Oana Horvath
005d0f01a3 [fenix] Fixed verifyAboutFirefoxPreview test according with new steps 2021-09-29 16:01:35 +03:00
Oana Horvath
01e865fee0 [fenix] Fixed disabled UI test openExternalLinksInPrivateTest 2021-09-29 16:01:35 +03:00
Roger Yang
55da682e79 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21552: Remove Extra Subtitle In Jump Back In Item 2021-09-29 02:46:34 +00:00
Roger Yang
f90fd65ccd [fenix] Fix recent tabs intermittent tests (https://github.com/mozilla-mobile/fenix/pull/21557)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-09-28 22:10:47 -04:00
Elise Richards
b777fa32ab [fenix] For https://github.com/mozilla-mobile/fenix/issues/21339: update styles for homescreen show all buttons and jump back in spacing (https://github.com/mozilla-mobile/fenix/pull/21342)
For https://github.com/mozilla-mobile/fenix/issues/21339: Add ignores for intermittent ui tests

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-09-28 14:40:22 -07:00
Mugurell
219561d304 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21275 - Sort items by how many times they were actually shown 2021-09-28 20:25:25 +00:00
Christian Sadilek
4702a66203 [fenix] Do not capture search terms when user navigates away via app (https://github.com/mozilla-mobile/fenix/pull/21527)
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>

Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
2021-09-28 14:20:58 +00:00
AndiAJ
f4a38f0a65 [fenix] Delete browsing data tests UI tests 2021-09-28 09:50:00 +00:00
AndiAJ
c1d3d97cc8 [fenix] Fix disabled toggleSearchSuggestions UI Tets and refactoring work 2021-09-28 07:49:22 +00:00
Elise Richards
32d6ee0dd3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21313: renewing performance awesomebar metrics (https://github.com/mozilla-mobile/fenix/pull/21315) 2021-09-27 15:40:21 -07:00
Roger Yang
f65770a34f [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21451: Add active search term tab groups on home 2021-09-27 21:10:57 +00:00
Arturo Mejia
c4eb7ea28b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21493 show onboarding dialog for home sections 2021-09-27 19:22:34 +00:00
codrut.topliceanu
6da619deb7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20762 - Fixes NPE crash with nullchecks for binding 2021-09-27 13:32:06 -04:00
AndiAJ
012b854d69 [fenix] Fix disabled shortcutButtonTest UI test 2021-09-27 11:15:28 +00:00
Mugurell
d701a81103 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21045: Add categories support 2021-09-27 09:57:15 +00:00
Mugurell
c37f1e550b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21045: Cleanup
- stick to one naming scheme: rename articles to stories and use this all
throughout the app.
- add some spacing above the new section (as per the current design)
2021-09-27 09:57:15 +00:00
Mozilla L10n Automation Bot
5a5507b490 [fenix] Import l10n. 2021-09-27 00:38:26 +00:00
Mozilla L10n Automation Bot
f5588635a2 [fenix] Import l10n. 2021-09-26 00:30:23 +00:00
Mozilla L10n Automation Bot
9dd6d98748 [fenix] Import l10n. 2021-09-25 00:44:49 +00:00
codrut.topliceanu
7ea5cdbe39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21087: Updates Recently Saved design 2021-09-24 07:42:29 +00:00
Christian Sadilek
c9e1bfe3dc [fenix] Fix mapping between history visits and groups to use createdAt
We currently have a 15s buffer to match metadata to its corresponding
visit. However, a existing metadata record can be updated more than
15s after it was created e.g. when closing the tab and updating
the view time.
2021-09-23 21:15:48 +00:00
Aaron Train
7f17484989 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21441: Fix changeAccessibiltySettings 2021-09-23 19:59:59 +00:00
Jonathan Almeida
d7c1238dac [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21366: Speculative fix for failing test in TitleHeaderBindingTest 2021-09-23 18:42:53 +00:00
Christian Sadilek
a6a6b6f257 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20893: Dedupe urls/site in history groups 2021-09-23 16:09:43 +00:00
Gabriel Luong
cb4b5fc613 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21460 - Rename "Delete from history" to "Remove" for recent visit dropdown menu 2021-09-23 14:26:46 +00:00
Oana Horvath
bc452b6adc [fenix] For https://github.com/mozilla-mobile/fenix/issues/17847: adding back editCustomSearchEngineTest UI test 2021-09-23 08:58:52 +00:00
AndiAJ
cc65e13b50 [fenix] Improve coverage verifyEmptyBookmarksMenuTest and undoDeleteMultipleSelectionTest UI tests 2021-09-23 08:04:40 +00:00
AndiAJ
8976e193d9 [fenix] Fix for disabled saveLoginFromPromptTest 2021-09-23 07:09:15 +00:00
Mozilla L10n Automation Bot
ba990dd118 [fenix] Import l10n. 2021-09-23 01:06:49 +00:00
Gabriel Luong
e3bc494414 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21117 - Modify layout for items displayed under "Recently Visited" in the HomeScreen to follow latest UX designs 2021-09-22 21:30:45 +00:00
Arturo Mejia
e87af643cb [fenix] For https://github.com/mozilla-mobile/fenix/issues/21239 improve telemetry values for Allow users to customize their home screen 2021-09-22 16:28:43 +00:00
Oana Horvath
15a3e30bf0 [fenix] No issue: re-enabled swipeToSwitchTabTest 2021-09-22 15:59:28 +00:00
Travis Long
023612b87d [fenix] Fix logic so isFirstRun can be called multiple times on first run 2021-09-22 15:35:28 +00:00
Travis Long
b4886fe546 [fenix] [SDK-344] Pass in first-run information to Nimbus for targeting 2021-09-22 15:35:28 +00:00
Gabriel Luong
450055a729 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21413 - Remove unused OnboardingPrivateBrowsingViewHolder and OnboardingWhatsNewViewHolder 2021-09-22 14:20:16 +00:00