Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-19 09:25:34 +00:00
Code Issues Releases Wiki Activity
2,067 Commits 67 Branches 116 Tags 1.2 GiB
62a25a8d6e
Commit Graph

1774 Commits

Author SHA1 Message Date
Tiger Oakes
b8695ca06b [fenix] Make Settings.instance private 2019-08-22 08:14:08 -07:00
Sebastian Kaspari
14e9fc85da [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4874: Use new build types in FeatureFlags class. 2019-08-22 08:12:49 -07:00
Emily Kager
11b37b2da0 [fenix] Adds experiments preferences strings 2019-08-21 19:55:26 -07:00
Emily Kager
494008a099 [fenix] No issue: Land strings for Delete Browsing Data on Quit 2019-08-21 19:55:26 -07:00
Colin Lee
bd400b8f53 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4064: Dispatchers.Main still has long cold start delay (Phase II) 2019-08-21 14:32:44 -07:00
Tiger Oakes
cf9ace2cc1 [fenix] Move classes out of top-level package 2019-08-21 13:52:30 -07:00
Richard Pappalardo
3e02efef28 [fenix] Stub out Settings tests 2019-08-21 13:52:03 -07:00
Jeff Boek
6ec0801d0c [fenix] For https://github.com/mozilla-mobile/fenix/issues/4326 - Updates codebase to support latest version of detekt 2019-08-21 13:50:51 -07:00
Jeff Boek
40ae66fdbb [fenix] For https://github.com/mozilla-mobile/fenix/issues/4326 - Updates codebase to support latest version of ktlint 2019-08-21 13:50:51 -07:00
Emily Kager
51d4956148 [fenix] No issue: Land new string for delete browsing data prompt (https://github.com/mozilla-mobile/fenix/pull/4859) 2019-08-21 11:17:34 -07:00
Colin Lee
f187762a78 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3869: Switch to A-C SearchLocalizationProvider (https://github.com/mozilla-mobile/fenix/pull/4858) 
* For https://github.com/mozilla-mobile/fenix/issues/3869: Switch to A-C SearchLocalizationProvider

* Fix test
 2019-08-21 11:14:59 -07:00
Nick Alexander
dbb115a551 [fenix] Consume new substitute-local-geckoview.gradle script from Bug 1533465. 2019-08-21 19:52:01 +02:00
Mihai Adrian
71229cdddd [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4795 fixed requestDesktopStateProvider value from private to desktopMode (https://github.com/mozilla-mobile/fenix/pull/4810) 
RequestDesktopStateProvider was taken from private instead of desktopMode
 2019-08-21 09:10:06 -07:00
Sourabh
c50d08d405 [fenix] add tests for DefaultQuickActionSheetController (https://github.com/mozilla-mobile/fenix/pull/4835) 2019-08-21 08:52:01 -07:00
Tiger Oakes
9e9246ada3 [fenix] No issue: Clean up preferences code (https://github.com/mozilla-mobile/fenix/pull/4699) 2019-08-21 08:38:14 -07:00
Emily Kager
409cea2128 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3967 - Invokes pending deletion with more bookmark actions (https://github.com/mozilla-mobile/fenix/pull/4522) 2019-08-21 08:36:41 -07:00
Mitchell Hentges
e7ca5257b4 [fenix] Configure either geckoview beta or nightly at compile-time (https://github.com/mozilla-mobile/fenix/pull/4851) 
* Remove "abi" product flavor and introduce "engine" product flavor.

This patch will allow us to build Fenix against GeckoView Nightly and GeckoView Beta by
introducing a new flavor dimension: engine = [geckoNightly, geckoBeta].

In addition to that it adds a "fenix"  prefix to the nightly, beta and production flavors
to reduce the ambiguity between fenix beta/nightly and GeckoView beta/nightly.

For now the build types have the following engine variants enabled:

**debug**: geckoNightly, geckoBeta
Both variants enabled for local development and testing.

**forPerformanceTest**: geckoNightly, geckoBeta
Both variants enabled unless the perf team only cares about Nightly (tbd)

**fenixNightlyLegacy**: geckoBeta
Uses GeckoView Beta for now - the same version we ship production builds with (same behavior
as before). This release type will eventualyl be decommissioned once we switch to a separate
Nightly app on Google Play.

**fenixNightly**: geckoBeta
Uses GeckoView Beta for now - the same version we ship production builds with (same behavior
as before). Changing this build to use GeckoView Nightly is currently being discussed.

**fenixBeta**: geckoBeta
Fenix Beta uses GeckoView Beta.

**fenixProduction**
Fenix Production uses GeckoView Beta (69) currently.

* gradle.py/variant.py: Replace "abi" with "engine".

* Disable enableUnitTestBinaryResources until we can switch to Android Gradle plugin 3.5.

* Fenix nightly should use both geckoview nightly and beta

* Updates automation to use apk splitting and support different engine
 2019-08-21 08:32:01 -07:00
Jonathan Almeida
584103cdf6 [fenix] Use Mozilla Android Components 10.0.0 2019-08-21 10:06:05 -04:00
Emily Kager
528b8e0d5f [fenix] No issue: Land new strings for ETP and delete browsing data 2019-08-21 10:59:12 +02:00
Yeon Taek Jeong
410bb482b1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2834: Add contentDescription to tabs button icons 2019-08-20 16:34:05 -07:00
Emily Kager
1d3eec6208 [fenix] No issue: Don't show session provider in private mode 2019-08-20 16:09:55 -07:00
Yeon Taek Jeong
86ec7d5d6c [fenix] For https://github.com/mozilla-mobile/fenix/issues/2834: Delete all Private Tabs redesign (https://github.com/mozilla-mobile/fenix/pull/4787) 2019-08-20 13:10:08 -07:00
(´⌣`ʃƪ)
da54bdfe63 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4436: Dismiss onboarding before navigating away from home (https://github.com/mozilla-mobile/fenix/pull/4801) 2019-08-20 10:56:28 -07:00
Tiger Oakes
9882aa6a50 [fenix] Adds setters and property delegates in Settings (https://github.com/mozilla-mobile/fenix/pull/4809) 
* Change Settings to use setters

* Add delegate for shared preferences
 2019-08-20 10:47:55 -07:00
Tiger Oakes
7780821922 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2690 - Clean up CreateCollection viewmodel (https://github.com/mozilla-mobile/fenix/pull/4731) 2019-08-20 10:45:41 -07:00
Tiger Oakes
2fb1bd0283 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4774 - Use vector drawable compat (https://github.com/mozilla-mobile/fenix/pull/4811) 2019-08-20 10:43:02 -07:00
Tiger Oakes
500d557828 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4744 - Extract private browsing button (https://github.com/mozilla-mobile/fenix/pull/4813) 2019-08-20 10:41:18 -07:00
Tiger Oakes
d5e5b73485 [fenix] Color the system bars in custom tabs (https://github.com/mozilla-mobile/fenix/pull/4819) 2019-08-20 10:13:01 -07:00
Tiger Oakes
efe2e2e466 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/1000 - Remove isCustomTab flag (https://github.com/mozilla-mobile/fenix/pull/4656) 2019-08-20 10:00:49 -07:00
Sourabh
0e376bb266 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4399: Create LibState Controller for Search (https://github.com/mozilla-mobile/fenix/pull/4673) 
* For https://github.com/mozilla-mobile/fenix/issues/4399: Create LibState Controller for Search

* fix code format

* add unit tests for DefaultSearchController

* add more test

* fix unit tests
 2019-08-20 09:07:00 -07:00
Mugurell
2634b6dee4 [fenix] For 4827 - Remove TransitionPreDrawListenerTest pending tests refactoring 
New tests for `FragmentPreDrawManager` are to be added in https://github.com/mozilla-mobile/fenix/issues/4828
 2019-08-20 13:45:55 +02:00
Mugurell
fa2abeffe9 [fenix] Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout 
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.

`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
 2019-08-20 13:45:55 +02:00
Emily Kager
9431f611d5 [fenix] Update strings.xml 
Remove space in placeholder for es (temp for release)
 2019-08-19 19:14:22 -07:00
Axel Hecht
7d5d5b7afd [fenix] Import strings from android-l10n 
State: mozilla-l10n/android-l10n@413e05dba4
 2019-08-19 19:14:22 -07:00
Tiger Oakes
1c389d1231 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4744 - Extract TransitionPreDrawListener (https://github.com/mozilla-mobile/fenix/pull/4812) 2019-08-19 16:27:43 -07:00
Tiger Oakes
774d696c92 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4744 - Move search bar icon padding to dimens (https://github.com/mozilla-mobile/fenix/pull/4814) 2019-08-19 16:22:51 -07:00
Emily Kager
0268034e79 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4822 - Update Bookmark State in onResume (https://github.com/mozilla-mobile/fenix/pull/4823) 2019-08-19 16:22:20 -07:00
Mihai Adrian
8a1829b484 [fenix] fixes https://github.com/mozilla-mobile/fenix/issues/4179 removed control highlight from disconnect button (https://github.com/mozilla-mobile/fenix/pull/4806) 
set colorControlHighlight to transparent in activity theme.
property cannot be set in view because it is overwritten by activity theme.
 2019-08-19 16:16:06 -07:00
Sawyer Blatz
1c995d36e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2706: Refactor Glean to reduce errors (https://github.com/mozilla-mobile/fenix/pull/4753) 
* For https://github.com/mozilla-mobile/fenix/issues/2706: Adds recording for untracked events

* For https://github.com/mozilla-mobile/fenix/issues/2706: Adds key alignment to Metrics
 2019-08-19 15:25:48 -07:00
Sawyer Blatz
46eaca2871 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4421: Fixes issues with new glean events (https://github.com/mozilla-mobile/fenix/pull/4816) 2019-08-19 14:49:48 -07:00
Sawyer Blatz
ea193a5472 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4804: Resolves issue with crash reporter stack 2019-08-19 16:40:41 -04:00
Aaron Train
aa9bf1aa6e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4618 - Stub Library UI tests (https://github.com/mozilla-mobile/fenix/pull/4619) 
See https://github.com/mozilla-mobile/fenix/issues/4572
 2019-08-19 14:05:10 -04:00
Arturo Mejia
7f746f6f17 [fenix] Use Mozilla Android Components 9.0.0-SNAPSHOT. (https://github.com/mozilla-mobile/fenix/pull/4750) 2019-08-19 10:29:10 -07:00
Suraj Shah
f3a412e24e [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4704 (https://github.com/mozilla-mobile/fenix/pull/4728) 
* Fixes https://github.com/mozilla-mobile/fenix/issues/4704. Overrides `setEnabled` for DeleteBrowsingDataItem to change view alpha when disabled and to toggle the checkbox `isEnabled` behavior based on the value provided.

* Updates CHANGELOG.md

* Removes unnecessary disabling of checkbox in DeleteBrowsingDataItem.kt
Updates CHANGELOG.md to reflect the component changed.
 2019-08-19 09:23:12 -07:00
Mugurell
43e4bcc0b1 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4396 - Add a Bookmarks Controller (https://github.com/mozilla-mobile/fenix/pull/4593) 
* For https://github.com/mozilla-mobile/fenix/issues/4396 - Rename BookmarkInteractor methods

Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.

Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.

* For https://github.com/mozilla-mobile/fenix/issues/4396 - Add a BookmarkController

It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.

This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.

* For https://github.com/mozilla-mobile/fenix/issues/4396 - Refactored Bookmark related tests

Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`

Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
 2019-08-19 08:34:57 -07:00
Tiger Oakes
84349bda63 [fenix] Extract quick action sheet observer code (https://github.com/mozilla-mobile/fenix/pull/4368) 2019-08-19 08:28:33 -07:00
Emily Kager
80b2c4ee51 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4799 https://github.com/mozilla-mobile/fenix/issues/4790 - Don't use passed in sessions in BrowserToolbarController (https://github.com/mozilla-mobile/fenix/pull/4800) 2019-08-18 20:36:40 -05:00
Colin Lee
47bbb9081d [fenix] For https://github.com/mozilla-mobile/fenix/issues/4686: Fix potential security issue (https://github.com/mozilla-mobile/fenix/pull/4764) 2019-08-16 16:50:54 -05:00
Yeon Taek Jeong
d72c8cf1b6 [fenix] No issue: fixes click failures on search widget icon 2019-08-16 13:58:29 -07:00
Emily Kager
043f8829c9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4688 - Try to use context instead of targetContext (https://github.com/mozilla-mobile/fenix/pull/4765) 2019-08-16 10:12:56 -07:00
Yeon Taek Jeong
b1fdb6a353 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4736: Display search shortcuts only from home or search widget 2019-08-15 12:24:54 -04:00
Emily Kager
52ff9a61f0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4688 - Try slightly different Context class for MockWebServer (https://github.com/mozilla-mobile/fenix/pull/4747) 2019-08-15 08:05:23 -07:00
Emily Kager
b037ddee5a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4680 - Align collection creation text center vertical 2019-08-14 20:17:01 -04:00
Yeon Taek Jeong
6c41d30fd8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4384: Hide mic icon if speech-to-text is unavailable (https://github.com/mozilla-mobile/fenix/pull/4701) 2019-08-14 16:40:21 -07:00
Yeon Taek Jeong
8efb7f9cdb [fenix] For https://github.com/mozilla-mobile/fenix/issues/4516: Use full width for large search widgets (https://github.com/mozilla-mobile/fenix/pull/4659) 2019-08-14 16:00:13 -07:00
Emily Kager
e4f3b39e0b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/3860 - Update description text for collections 2019-08-14 17:13:52 -04:00
Sawyer Blatz
6cfbb2c02b [fenix] For https://github.com/mozilla-mobile/fenix/issues/4421: Adds Leanplum events and attributes (https://github.com/mozilla-mobile/fenix/pull/4626) 
* For https://github.com/mozilla-mobile/fenix/issues/4421: Adds Leanplum events and attributes

* For https://github.com/mozilla-mobile/fenix/issues/4421: Adds Leanplum deep links
 2019-08-14 13:48:45 -07:00
Yeon Taek Jeong
309b86544c [fenix] For https://github.com/mozilla-mobile/fenix/issues/4421: Add search widget attribute to Leanplum (https://github.com/mozilla-mobile/fenix/pull/4694) 2019-08-14 12:00:29 -07:00
Yeon Taek Jeong
468c400ff5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4457: Adds telemetry for search widget actions (https://github.com/mozilla-mobile/fenix/pull/4714) 2019-08-14 11:39:54 -07:00
Yeon Taek Jeong
2c70a18a62 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4732: Fix search engine display issue (https://github.com/mozilla-mobile/fenix/pull/4735) 2019-08-14 11:03:14 -07:00
Mihai Adrian
4835dbb1a8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4434 - made close button for collections more accessible. (https://github.com/mozilla-mobile/fenix/pull/4443) 
* fixes https://github.com/mozilla-mobile/fenix/issues/4434 - made close button for collections more accessible.

set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
implemented same visual solution as for https://github.com/mozilla-mobile/fenix/issues/4193 - close button for tabs

* fixes https://github.com/mozilla-mobile/fenix/issues/4434 - made buttons for collection home list row more accessible and aligned 3 dot menu with individual tabs close button

set buttons sizes to recommended minimum size for accessibility 48x48, while keeping image size the same
removed margins from buttons as they were not needed anymore
aligned center of menu buttons with center of collection icon
constrained description top to bottom of title, instead of share button to reduce empty space. (overlap with share button is already prevented by end constraint of description)
 2019-08-14 10:12:39 -07:00
Michael Cooper
9646181343 [fenix] Add no-op experiment to test service-experiments integration (https://github.com/mozilla-mobile/fenix/pull/4551) 
* Add no-op experiment to test service-experiments integration

* Shorten metric name to meet schema

* Add active_experiment metric to docs

* Add approved data review
 2019-08-14 12:07:41 -05:00
Tiger Oakes
07eda357ba [fenix] Use global navigation action for browser fragment (https://github.com/mozilla-mobile/fenix/pull/4691) 2019-08-14 11:58:29 -05:00
isabelrios
61e400c2d8 [fenix] Fix UI Screenshot TabMenuTest (https://github.com/mozilla-mobile/fenix/pull/4730) 2019-08-14 11:57:36 -05:00
Colin Lee
4987c40d67 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1667: Screen reader can't reach other UI items when QAB expanded (https://github.com/mozilla-mobile/fenix/pull/4695) 2019-08-14 09:56:29 -07:00
Emily Kager
bf76cbe7e6 [fenix] No issue - Autoformatting (https://github.com/mozilla-mobile/fenix/pull/4715) 2019-08-14 09:40:46 -05:00
Sebastian Kaspari
c30700580c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4719: Get rid of fragment-testing dependency and create fragments in StoreProviderTest manually. (https://github.com/mozilla-mobile/fenix/pull/4722) 2019-08-14 09:10:24 -05:00
Colin Lee
2de56210e2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4709: Fix Bugzilla issue 1573549 (https://github.com/mozilla-mobile/fenix/pull/4710) 2019-08-13 22:16:23 -05:00
Sourabh
9c7caab6e3 [fenix] fix https://github.com/mozilla-mobile/fenix/issues/4633: show toast only on first login (https://github.com/mozilla-mobile/fenix/pull/4676) 
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
 2019-08-13 16:28:34 -05:00
(´⌣`ʃƪ)
f292286006 [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/4436: hide onboarding before navigating to settings (https://github.com/mozilla-mobile/fenix/pull/4675) 
* Fix https://github.com/mozilla-mobile/fenix/issues/4436: hide onboarding before navigating to settings

* No issue: Rename emitAccountChanges to emitModeChanges
 2019-08-13 15:49:42 -05:00
Sebastian Kaspari
4cba063e4e [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4431: Integrate feature-media component (Nightly and debug builds only). (https://github.com/mozilla-mobile/fenix/pull/4683) 2019-08-13 15:02:20 -05:00
Colin Lee
de2b2a74c9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4652: HomeFragment Crash "Can not.. after onSaveInstanceState" 2019-08-12 15:51:49 -04:00
Jorge De Los Santos
3cfa2aff96 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3424 - Make talkback ignore ImageButton in Collection Sele… (https://github.com/mozilla-mobile/fenix/pull/3792) 
For https://github.com/mozilla-mobile/fenix/issues/3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
 2019-08-12 11:49:25 -04:00
Grisha Kruglov
caeb3477b9 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4671: Fix a potential NPE in BookmarkFragment 2019-08-12 11:16:28 -04:00
Grisha Kruglov
cd52df3314 [fenix] No issue: add some BookmarkFragmentInteractor tests 2019-08-09 17:27:58 -07:00
Grisha Kruglov
88db14a22f [fenix] No issue: reduce code duplication in BookmarkFragmentInteractor 2019-08-09 17:27:58 -07:00
Christian Sadilek
9b956a3c42 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4125: Suppress coroutine warning to fix release build 2019-08-09 17:30:27 -04:00
Sawyer Blatz
20b0c30640 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4123: Adds telemetry for quick action open in app (https://github.com/mozilla-mobile/fenix/pull/4629) 2019-08-09 13:51:12 -07:00
Yeon Taek Jeong
ae90650052 [fenix] ktlint fix 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
b050218cd6 [fenix] Finish adding tests 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
6517ffed64 [fenix] Fix, add some tests 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
b190e9b80d [fenix] Fix rest of issues 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
b3ef78f3cc [fenix] Fix most issues 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
8391e933be [fenix] For https://github.com/mozilla-mobile/fenix/issues/4125: Migrate Sign in to Sync to Libstate 2019-08-09 13:39:51 -07:00
Axel Hecht
059ee1671d [fenix] Import strings from android-l10n (https://github.com/mozilla-mobile/fenix/pull/4643) 
State: mozilla-l10n/android-l10n@ab580f757c
 2019-08-09 14:55:05 -05:00
Colin Lee
9124321227 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4652: Crash "Can not perform this action after onSaveInstanceState" (https://github.com/mozilla-mobile/fenix/pull/4654) 2019-08-09 14:46:40 -05:00
Jonathan Almeida
d544526692 [fenix] No issue: Disable failing ActivationPingTest 2019-08-09 15:22:38 -04:00
Tiger Oakes
025fc336b1 [fenix] Consodilate private browsing code 2019-08-09 11:00:41 -07:00
Jonathan Almeida
d3ff33d2d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4066: Create InflationAwareFeature for lazy inflation 2019-08-09 11:48:55 -04:00
Colin Lee
45ec0682f5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4066: Provide lazy inflation of Find In Page View 2019-08-09 11:48:55 -04:00
Sawyer Blatz
e4488b1909 [fenix] No issue: Removes deprecated usage of InstrumentationRegistry 2019-08-08 17:35:13 -07:00
Colin Lee
952926509c [fenix] For https://github.com/mozilla-mobile/fenix/issues/4507 Enable codecov (https://github.com/mozilla-mobile/fenix/pull/4520) 2019-08-08 19:09:54 -05:00
Colin Lee
1d4952ddf1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4529: Handle crash initializing CreateCollectionViewModel late (https://github.com/mozilla-mobile/fenix/pull/4628) 2019-08-08 17:40:55 -05:00
ValentinTimisica
9ce027a0a4 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4323: Modified UI of component_collection_creation. 
To fix the overlapping issue I used Guideline and
layout_constraintWidth_default property. I also used the
layout_constraintHorizontal_bias property to make the back_button to
lean to the left and the select_all_button to lean to the right.
 2019-08-08 12:57:19 -07:00
Christian Sadilek
27b574d548 [fenix] Suppress warning in LeanplumMetricsService to fix release builds 2019-08-08 15:17:12 -04:00
Emily Kager
527b52ed71 [fenix] No issue: Update testing dependencies 2019-08-08 11:37:16 -07:00
Mathieu Leplatre
edc8182698 [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/4612: Fetch experiments from Remote Settings CDN 2019-08-08 10:15:01 -07:00
Colin Lee
1648fccc8c [fenix] For https://github.com/mozilla-mobile/fenix/issues/4529, https://github.com/mozilla-mobile/fenix/issues/4427: Resuming after restoring instance state breaks UI (https://github.com/mozilla-mobile/fenix/pull/4571) 
* For https://github.com/mozilla-mobile/fenix/issues/4529, https://github.com/mozilla-mobile/fenix/issues/4427: Resuming after restoring instance state breaks UI

* Clear up warnings
 2019-08-08 11:05:01 -05:00
Emily Kager
03e8f5b054 [fenix] No issue: Update testing dependencies and deprecated method (https://github.com/mozilla-mobile/fenix/pull/4608) 2019-08-08 09:03:39 -07:00
Sawyer Blatz
93a03e892e [fenix] For https://github.com/mozilla-mobile/fenix/issues/4451: Adds tests for DefaultBrowserToolbarController (https://github.com/mozilla-mobile/fenix/pull/4493) 
* For https://github.com/mozilla-mobile/fenix/issues/4451: Adds tests for DefaultBrowserToolbarController

* Continue working

* Large refactoring of test

* Mock analytics

* Fix merge conflicts
 2019-08-08 09:02:42 -07:00
Hakkı Kaan Çalışkan
9f5097b48c [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4562: Add a-c git hash to about page 2019-08-07 16:59:11 -07:00
Emily Kager
2eedb1c015 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4602 - Add back transitions 2019-08-07 16:56:21 -07:00
Sawyer Blatz
c8fd7ba4cd [fenix] Fixes feedback 2019-08-07 16:41:29 -07:00
Sawyer Blatz
364b14f2a7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3060: Adds Leanplum attributes for fxa syncing 2019-08-07 16:41:29 -07:00
Sawyer Blatz
79dfd96a57 [fenix] No issue: Removes deprecated usage of ViewModelProviders 2019-08-07 19:21:41 -04:00
Yeon Taek Jeong
297e0520be [fenix] Fix ktlint 2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
ed4864ce35 [fenix] Remove task flags 2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
dddc36e8ca [fenix] Keep CLEAR_TASK 2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
511b912a79 [fenix] Remove popBackStack 2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
772fcc8f5d [fenix] For https://github.com/mozilla-mobile/fenix/issues/4438: Fix crash when opening any URL from URL bar w/ long press 2019-08-07 19:17:56 -04:00
Sawyer Blatz
e904bd867e [fenix] For https://github.com/mozilla-mobile/fenix/issues/969: Adds more telemetry for collections (https://github.com/mozilla-mobile/fenix/pull/4539) 2019-08-07 16:05:20 -07:00
Tiger Oakes
664d6f2e81 [fenix] Minify the fenix 2019-08-07 14:24:32 -07:00
Sawyer Blatz
8bd4dc98d2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4508: Treats warnings as errors (https://github.com/mozilla-mobile/fenix/pull/4543) 2019-08-07 14:00:53 -07:00
Grisha Kruglov
96f42368b3 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4467: Use a-c version of FirefoxAccountsAuthFeature 2019-08-07 13:42:39 -07:00
ValentinTimisica
f65f57cfbb [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4354: Updated SearchFragment state after returning from SearchEngineFragment. 
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
 2019-08-07 13:19:53 -07:00
Colin Lee
32ec775443 [fenix] No issue: Add OSS licenses link to About page 2019-08-07 12:40:10 -07:00
Sawyer Blatz
2d9475c23d [fenix] For https://github.com/mozilla-mobile/fenix/issues/969: Finalizes collections telemetry (https://github.com/mozilla-mobile/fenix/pull/4592) 2019-08-07 10:26:52 -07:00
Richard Pappalardo
7ea855bda8 [fenix] Stub out tabs tests (https://github.com/mozilla-mobile/fenix/pull/4573) 2019-08-07 09:54:38 -07:00
Emily Kager
f7e64a1d0a [fenix] For https://github.com/mozilla-mobile/fenix/issues/4026 - Update BookmarkDiffUtil to update on Title or URL change 2019-08-07 00:37:16 -04:00
Jeff Boek
b17a8b8091 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4557 https://github.com/mozilla-mobile/fenix/issues/3860 - Add string for collection empty state 2019-08-06 21:36:54 -07:00
Emily Kager
3e475940a9 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/3939 - Adds strings for delete browsing history 2019-08-06 16:06:56 -07:00
Emily Kager
8b05867538 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1749 - Land ETP Strings 2019-08-06 14:55:47 -07:00
ValentinTimisica
8581ab5f6c [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/3922: Added accessibility announcement for history empty state. 
Sent an announcement when the list becomes empty in order to tell the user
that there is no history.
 2019-08-06 12:32:59 -07:00
Tiger Oakes
c128f9bcc4 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/1000 - Split out common browser functions 2019-08-06 12:31:25 -07:00
Emily Kager
f569fef876 [fenix] Fro https://github.com/mozilla-mobile/fenix/issues/4563 - Update delete button alpha when history mode changes 2019-08-06 12:26:25 -07:00
Tiger Oakes
9daf0c9542 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/2379 - Generic library selection 2019-08-06 11:10:50 -07:00
Emily Kager
ad16d1efcd [fenix] No issue: Update UI tests with new engine shortcuts behavior (https://github.com/mozilla-mobile/fenix/pull/4552) 2019-08-06 08:30:15 -07:00
ekager
ae2474323e [fenix] No issue: Removes focusableInTouchMode from home searchbar view 2019-08-05 15:42:21 -07:00
Yeon Taek Jeong
b7fa244d76 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1744: Open search shortcuts when entering search mode (https://github.com/mozilla-mobile/fenix/pull/4536) 2019-08-05 15:07:03 -07:00
Emily Kager
2bbe72a7bd [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4540 - Set correct tint for select bookmark folder icon (https://github.com/mozilla-mobile/fenix/pull/4541) 2019-08-05 14:54:39 -07:00
Emily Kager
56fac45ca3 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4537 - Adds description for onboarding placeholder string (https://github.com/mozilla-mobile/fenix/pull/4542) 2019-08-05 14:51:11 -07:00
ekager
c85692808d [fenix] For https://github.com/mozilla-mobile/fenix/issues/2021 - Update custom preferences' views with email/account changes 2019-08-05 09:53:27 -07:00
Travis Long
4d977e253e [fenix] Integrate service-experiments component (https://github.com/mozilla-mobile/fenix/pull/4098) 2019-08-05 11:14:42 -05:00
Emily Kager
e72e0eb729 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4455 - Rename history headers by hours and days (https://github.com/mozilla-mobile/fenix/pull/4478) 2019-08-05 11:12:22 -05:00
Nikit Bhandari
8f5a167d2b [fenix] For https://github.com/mozilla-mobile/fenix/issues/4530 Reduce build warnings (https://github.com/mozilla-mobile/fenix/pull/4531) 2019-08-05 11:10:57 -05:00
ekager
1034671723 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4495 - Clean up homescreen toolbar focus and content descriptions 2019-08-05 08:58:03 -07:00
Emily Kager
e4ccbeb6ea [fenix] No issue: Fix failing UI tests because of renamed views (https://github.com/mozilla-mobile/fenix/pull/4527) 2019-08-05 10:09:34 -05:00
Sören Hentzschel
ed4fd8c951 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1427 - enter multi select mode with single click on favicon in library 2019-08-03 16:43:51 -07:00
Nikit Bhandari
208c08a9d4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4341 use camelCase for views referenced from code 2019-08-03 09:25:55 -07:00
Nikit Bhandari
919a2791ac [fenix] For https://github.com/mozilla-mobile/fenix/issues/4199 make checkbox disabled when there is no data (https://github.com/mozilla-mobile/fenix/pull/4200) 
* For https://github.com/mozilla-mobile/fenix/issues/4199 make checkbox unclickable when there is no data
 2019-08-02 17:42:39 -07:00
Tiger Oakes
3e3b4dee3e [fenix] Use auto pause with BrowserFragment observers 2019-08-02 17:32:58 -07:00
Tiger Oakes
564cba2065 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1657 - Use Gecko for downloads (https://github.com/mozilla-mobile/fenix/pull/4296) 2019-08-02 17:28:30 -07:00
Tiger Oakes
d4200df79c [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/2379 - Use LibrarySiteItemView in history 2019-08-02 17:15:41 -07:00
mihai-adrian
47e7928dd9 [fenix] fixes https://github.com/mozilla-mobile/fenix/issues/4435 - changed title of menuitem for delete and added content description 
setting menu title should also set content description. I added the setContentDescription programmatically in order to ensure that the content description is being set. If content description matches title it won't be read twice
 2019-08-02 17:09:24 -07:00
Yeon Taek Jeong
f883987800 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3907: Hide 'Go back' button for bad websites from new tabs 2019-08-02 17:00:48 -07:00
ekager
fbb407378a [fenix] No issue: Fix Crash lower API by setting gradient drawables in onBind 2019-08-02 16:18:34 -07:00
ekager
4a677fa719 [fenix] No issue: Just use TextView, not AppCompatTextView 2019-08-02 13:23:55 -07:00
Yeon Taek Jeong
04d9c346f5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/201: Search Widget 2019-08-02 11:26:48 -07:00
Jonathan Almeida
99f4186812 [fenix] No issue: Fix breaking AccountObserver API 2019-08-02 13:40:50 -04:00
Sawyer Blatz
998350a63d [fenix] For https://github.com/mozilla-mobile/fenix/issues/2203: Polishes BrowserToolbarMenu 2019-08-02 13:40:50 -04:00
Colin Lee
76c9056cd4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1539: Only allow delete when folders multi-selected (https://github.com/mozilla-mobile/fenix/pull/4062) 2019-08-02 10:11:21 -07:00
ValentinTimisica
9653149b27 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4410: Modified visibility of 'Add Tab' button. 
I changed the visibility of 'Add Tab' button according to the number of
opened tabs. If there is at least one tab open, the button is displayed.
 2019-08-02 08:49:50 -07:00
Grisha Kruglov
3eb264a247 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2593: FxA automatic sign-in integration 2019-08-01 17:03:45 -07:00
Grisha Kruglov
124a6facb3 [fenix] Reflect current sync status when opening account settings 2019-08-01 17:03:45 -07:00
Sawyer Blatz
190fe7b09b [fenix] No issue: Fixes failing UI test on master 2019-08-01 19:10:51 -04:00
Tiger Oakes
06260f99d3 [fenix] Fix crash for bookmarks 2019-08-01 18:57:35 -04:00
Emily Kager
ee443ac8a8 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4462 - Adjust layout params of select bookmark folder view 2019-08-01 13:31:13 -07:00
Thom Chiovoloni
dc7b4f682d [fenix] Update fenix for new megazord setup 2019-08-01 13:10:20 -07:00
Tiger Oakes
547e94cde8 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/2379 - Use LibraryPageView in history 2019-08-01 15:59:55 -04:00
Jeff Boek
87b08d1057 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4441 - Keeps the ID 0 based for the recyclerview 2019-08-01 10:45:23 -07:00
Christian Sadilek
9b0b917db5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4412: Only consume state change when UI initialized 2019-08-01 11:51:32 -04:00
isabelrios
4e2c157646 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4324 - Add more l10n screenshots tests (https://github.com/mozilla-mobile/fenix/pull/4350) 
* Fixes https://github.com/mozilla-mobile/fenix/issues/4324 - l10n Add more screenshots tests

* change test name

* final changes

* fixing reviewer comments
 2019-08-01 08:35:47 -07:00
Christian Sadilek
a9f5443ee7 [fenix] No issue: Add engine warmup call 2019-08-01 10:53:55 -04:00
Jeff Boek
32143301ef [fenix] For https://github.com/mozilla-mobile/fenix/issues/3886 - Uses defaultDeviceName for the DeviceConfig device name 2019-07-31 21:34:21 -07:00
Jeff Boek
4019019ea3 [fenix] No Issue - Fixes the offset key to prevent endless history bug 2019-07-31 17:58:56 -07:00
Sawyer Blatz
464a5f92cd [fenix] For https://github.com/mozilla-mobile/fenix/issues/2267: Fixes telemetry for reader view (https://github.com/mozilla-mobile/fenix/pull/4328) 2019-07-31 17:58:37 -07:00
Sawyer Blatz
1b027a36e4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/969: Adds more telemetry for collections (https://github.com/mozilla-mobile/fenix/pull/4358) 2019-07-31 17:07:41 -07:00
Jonathan Almeida
0a6752deec [fenix] No issue: Move PublicSuffixList to root component 
With the PublicSuffixList class in Utilities, the first instantiation
of it (prefetching in onCreate), causes the Utilities to instantiate
and thus slowing down startup by needing the SearchEngineManager from
instantiating as well.

Moving this back to the root component fixes the immediate perf issue.

Co-authored-by: Will Hawkins <whh8b@obs.cr>
 2019-07-31 17:01:14 -07:00
Christian Sadilek
1505e5d1bb [fenix] For https://github.com/mozilla-mobile/fenix/issues/4412: SiteSecurityClickedListener set incorrectly 2019-07-31 19:52:53 -04:00
Will Hawkins
ac8a2e24e1 [fenix] No Issue: Move notification manager to member of background services 
Instead of taking notification manager as a parameter
(from the utils class), create one private to the
BackgroundServices class. This means that we do not need
to create the entirety of utilities just to use
the notification manager.
 2019-07-31 16:11:46 -07:00
mihai-adrian
4f554994e7 [fenix] fixes https://github.com/mozilla-mobile/fenix/issues/4221 - The tap area for Open tabs' new tab and 3 dot menu buttons is too small 
changed size of buttons to 48X48 following Material Design Accessibility guidelines.
removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top
 2019-07-31 14:42:43 -07:00
mihai-adrian
b05e618a9e [fenix] fixes https://github.com/mozilla-mobile/fenix/issues/4221 - The tap area for Open tabs' new tab and 3 dot menu buttons is too small 
changes size of buttons to 48X48 following Material Design Accessibility guidelines.
removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top
 2019-07-31 14:42:43 -07:00
Jeff Boek
5cb403b070 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4137 - Fixes HistoryStoreTest 2019-07-31 14:35:33 -07:00
Jeff Boek
a20d0e7b74 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4137 - Fixes HistoryInteractorTest 2019-07-31 14:35:33 -07:00
ekager
cfda0676e7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4137 - Adds pagination to the history view 2019-07-31 14:35:33 -07:00
Emily Kager
ef25fff429 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3829 - Ignore Intents Launched From History 2019-07-31 17:07:54 -04:00
Nikit Bhandari
49eb339d15 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4339 reduce build warnings (https://github.com/mozilla-mobile/fenix/pull/4340) 2019-07-31 11:43:49 -07:00
Emily Kager
853ad4d175 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4265 - Do not pop after all exceptions are removed (https://github.com/mozilla-mobile/fenix/pull/4392) 2019-07-31 11:43:15 -07:00
Christian Sadilek
a320e9568b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4412: BrowserInteractor has not been initialized (https://github.com/mozilla-mobile/fenix/pull/4414) 2019-07-31 09:14:05 -07:00
Afzal Najam
ca4be8ef2a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/3341 - Remove UserAgentRewriter 2019-07-31 11:05:42 -04:00
Emily Kager
1c2b197cb0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4198 - Include Intent.ACTION_SEND to open to browser 2019-07-31 01:11:39 -04:00
Jonathan Almeida
52c077669f [fenix] No issue: Enable Send Tab and Push in production 2019-07-30 22:32:59 -04:00
Jonathan Almeida
ef02584440 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4355: unsubscribe FxA subscription on logout 2019-07-30 22:27:12 -04:00
Maurya Talisetti
0034bfdb02 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/3419: Use better accessibility strings for tab collections 2019-07-30 16:37:49 -04:00
ekager
56c43388a8 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4040 - Remove NestedScrollView from Bookmark Layout 2019-07-30 16:29:12 -04:00
mihai-adrian
082000dd4b [fenix] fixes https://github.com/mozilla-mobile/fenix/issues/4237 - Cannot edit the default name of a collection, only replace it 
changed setting of text to be done before transition, preventing transition to make textView unclickable;
 added renaming situation to showKeyboard in onResume();
 changed title text when renaming, from: "Name collection" to "Rename collection".
 2019-07-30 16:26:10 -04:00
mihai-adrian
a1029884e8 [fenix] fixes https://github.com/mozilla-mobile/fenix/issues/4237 - Cannot edit the default name of a collection, only replace it 
changed setting of text to be done before transition, preventing transition to make textView unclickable;
 added renaming situation to showKeyboard in onResume();
 changed title text when renaming, from: "Name collection" to "Rename collection".
 2019-07-30 16:26:10 -04:00
mihai-adrian
ecfdceed50 [fenix] fixes https://github.com/mozilla-mobile/fenix/issues/4237 - Cannot edit the default name of a collection, only replace it 
made name_collection_edittext field clickable
 2019-07-30 16:26:10 -04:00
Sawyer Blatz
9602f80468 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4376: Removes usage of selectedSessionOrThrow (https://github.com/mozilla-mobile/fenix/pull/4381) 2019-07-30 12:39:58 -07:00
mihai-adrian
b20cbd0566 [fenix] fixes https://github.com/mozilla-mobile/fenix/issues/3843 - (L10N) regression: alignment issue when saving tabs to collection 
changed height to match_constraints instead of wrap_content - this makes for a better calculation of space, avoids setting textView on two lines, with blank line below.
 2019-07-30 13:41:23 -04:00
ekager
8feadabb3b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4240 - Exclude custom tabs from displayed tab count 2019-07-30 13:28:50 -04:00
bloslo
86909b315d [fenix] For https://github.com/mozilla-mobile/fenix/issues/3886 - Change default device name to show the app name. (https://github.com/mozilla-mobile/fenix/pull/3916) 
* Fix default device name to show the app name.

* Add string resource with placeholders.

* Wrap line that triggers MaxLineLength lint issue.
 2019-07-30 10:28:19 -07:00
bloslo
ac175e44d0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3548 - Fix close tab button visibility. (https://github.com/mozilla-mobile/fenix/pull/3801) 
* For https://github.com/mozilla-mobile/fenix/issues/3548 - Fix close tab button visibility.

* Switch to 'wrap_content' instead of fixed values.

* Align close tab button with settings button.

* Change margin top
 2019-07-30 10:25:44 -07:00
Tiger Oakes
98b191f014 [fenix] Minify logo path (https://github.com/mozilla-mobile/fenix/pull/4276) 2019-07-30 09:56:11 -07:00
Sebastian Kaspari
a4add1765d [fenix] Switch to GeckoView 69 Beta. 2019-07-30 18:53:27 +02:00
Tiger Oakes
0fc3134f6c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4012 - Animate quick settings (https://github.com/mozilla-mobile/fenix/pull/4047) 2019-07-30 09:50:50 -07:00
Tiger Oakes
3dbee6b52c [fenix] Create shared custom view for library items 2019-07-30 12:26:15 -04:00
Mihai Adrian
89954dceff [fenix] fixes https://github.com/mozilla-mobile/fenix/issues/3905 - "Go back" button too low on high risk error pages (https://github.com/mozilla-mobile/fenix/pull/4378) 
added to border-box value to box-sizing property for tablets so that the height property includes content and padding
 2019-07-30 09:24:10 -07:00
Sawyer Blatz
3bbc53b35f [fenix] For https://github.com/mozilla-mobile/fenix/issues/1750: Adds gradient to private BrowserToolbar (https://github.com/mozilla-mobile/fenix/pull/4361) 
Also updates the color of quickActionSheet ot be "above" attribute
 2019-07-30 09:19:48 -07:00
Mugurell
4431d23d5f [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/4372 - Set SitePermissionsDetailsExceptionsFragment toolbar title in onResume 
The flow we are currently using involves setting a new title for the containing
Activity when the user navigates to a new Fragment.
This happened for SitePermissionsDetailsExceptionsFragment in it's onCreate().
Opening a permission (SitePermissionsManageExceptionsPhoneFeatureFragment) will
set a new title in it's onCreate() but going back from this new Fragment will
not create again a new SitePermissionsDetailsExceptionsFragment.
As a workaround I moved the call to set Activity's title in onResume().
 2019-07-30 11:56:44 -04:00
Nikit Bhandari
20273fa5ec [fenix] For https://github.com/mozilla-mobile/fenix/issues/3443 - convert textPercentageSeekBar to Kotlin (https://github.com/mozilla-mobile/fenix/pull/4081) 
* convert textPercentageSeekBar to Kotlin

* fix test

* fix test again

* fix test again

* conflicts resolved

* merge multiple kdocs into one
 2019-07-30 10:17:41 -05:00
Axel Hecht
e631cc85ae [fenix] Import strings from android-l10n 
State: mozilla-l10n/android-l10n@1412258878
 2019-07-30 15:35:41 +02:00
Colin Lee
256ba4672a [fenix] For https://github.com/mozilla-mobile/fenix/issues/4359: findBookmarkedUrl blocks the main thread (https://github.com/mozilla-mobile/fenix/pull/4362) 2019-07-29 17:01:02 -05:00
Amaan Marfatia
c2a2e46955 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4192: Private keyboard in private browsing (https://github.com/mozilla-mobile/fenix/pull/4345) 
Sets compliant keyboards to private mode when in private browsing.
 2019-07-29 18:00:48 -04:00
James Hugman
4eb24d1b3c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1331 - Filter consecutive history items using simplified URL 2019-07-29 17:22:19 -04:00
Sawyer Blatz
a8a228e24d [fenix] For https://github.com/mozilla-mobile/fenix/issues/4124: Migrate BrowserToolbar to Libstate (https://github.com/mozilla-mobile/fenix/pull/4279) 
* For https://github.com/mozilla-mobile/fenix/issues/4124: Migrate BrowserToolbar to Libstate

* Restores QuickActionSheetReducer

* Improve tests

* Make QuickActionSheetController

* Finalize tests

* Breaks out QuickActionSheetState

* Fix comments

* Adds BrowserStoreTest
 2019-07-29 12:39:36 -07:00
Tiger Oakes
4aeab46a23 [fenix] Remove redundant super calls 2019-07-29 10:22:53 -07:00
Tiger Oakes
e5ec6b42df [fenix] Use glide-like image loading function 2019-07-29 10:22:23 -07:00
Andrey Mukamolov
8b7e62f821 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2142: Added accessibility focus 2019-07-29 09:26:33 -07:00
Andrey Mukamolov
18bdd3f102 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2142: Added UI test assertion 2019-07-29 09:26:33 -07:00
Andrey Mukamolov
3ebef57230 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2142: Enable private browsing button is focused instead of Search or address 2019-07-29 09:26:33 -07:00
Tiger Oakes
281d9d7df5 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4005 - Move getColorFromAttr to Context 2019-07-26 16:44:11 -04:00
Jonathan Almeida
7e1a74dd06 [fenix] No issue: Reset push subscriptions 2019-07-26 13:50:57 -04:00
Sawyer Blatz
6906cb0f52 [fenix] No issue: Add more useful test output to TaskCluster (https://github.com/mozilla-mobile/fenix/pull/4165) 2019-07-26 08:56:13 -07:00
Richard Pappalardo
1531d6d6ad [fenix] Add taskcluster job for UI tests (https://github.com/mozilla-mobile/fenix/pull/4088) 2019-07-26 08:08:01 -07:00
Colin Lee
d726ec0acb [fenix] For https://github.com/mozilla-mobile/fenix/issues/3695: Make SessionSuggestionProvider link to existing tab (https://github.com/mozilla-mobile/fenix/pull/4280) 2019-07-26 09:49:25 -05:00
Christian Sadilek
4a712031d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4096: Use new A-C API to observe store / state changes 
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
 2019-07-26 10:40:33 -04:00
Colin Lee
526c077529 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4128: Migrate Bookmarks to LibState (https://github.com/mozilla-mobile/fenix/pull/4254) 2019-07-25 21:55:51 -05:00
ValentinTimisica
3eb95adbc7 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4161: Modified style of bookmark_folders_sign_in button. (https://github.com/mozilla-mobile/fenix/pull/4291) 
To make this match the style of the other button I applied the same style to it
and also changed it to be a MaterialButton.
I also decided to extract the margin and padding values of the button.
 2019-07-25 14:10:11 -05:00
chiragmantri
f4522fe0fa [fenix] removed unused import. 2019-07-25 14:36:36 -04:00
chiragmantri
d675a8588d [fenix] [https://github.com/mozilla-mobile/fenix/issues/4089] Moved PublicSuffixList to a sub-component(Utilities) class. 2019-07-25 14:36:36 -04:00
Sawyer Blatz
4b72bc04e8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4262: Updates color and text of buttons (https://github.com/mozilla-mobile/fenix/pull/4250) 2019-07-25 11:01:25 -07:00
isabelrios
87ca3f8e45 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4260 - UITests update data collection string (https://github.com/mozilla-mobile/fenix/pull/4261) 2019-07-24 10:05:28 -07:00
Jonathan Almeida
2ef80d8869 [fenix] Update to use Mozilla Android Components 6.0.0 2019-07-23 17:55:39 -04:00
Jonathan Almeida
1b3d29cb7b [fenix] No issue: Use correct server host and force subscribe for push 2019-07-23 17:55:39 -04:00
Sawyer Blatz
09c388a13b [fenix] For https://github.com/mozilla-mobile/fenix/issues/1944 & https://github.com/mozilla-mobile/fenix/issues/1750: Updates private & night mode colors (https://github.com/mozilla-mobile/fenix/pull/4232) 2019-07-23 09:35:24 -07:00
Tiger Oakes
c37899d403 [fenix] Switch to new intent processors 2019-07-23 12:33:02 -04:00
Sawyer Blatz
3636834626 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4091 & Fixes https://github.com/mozilla-mobile/fenix/issues/4092: Resolve issues with Search UI tests (https://github.com/mozilla-mobile/fenix/pull/4224) 2019-07-23 09:30:57 -07:00
Michael Droettboom
897427326e [fenix] 1567988: Reduce likelihood of invalid URL loading Glean build script 2019-07-23 11:21:19 +02:00
Emily Kager
b3c118d7ba [fenix] For https://github.com/mozilla-mobile/fenix/issues/4127 - Converts Exceptions to LibState and adds tests 2019-07-22 17:21:06 -04:00
Emily Kager
ba9cf5973e [fenix] For https://github.com/mozilla-mobile/fenix/issues/3360 - Adds empty state for TP Exceptions 2019-07-22 17:21:06 -04:00
Sawyer Blatz
8cb4414365 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/3986 & Closes https://github.com/mozilla-mobile/fenix/issues/3661: Migrate QuickActionSheet to LibState & add tests (https://github.com/mozilla-mobile/fenix/pull/4058) 
* Closes https://github.com/mozilla-mobile/fenix/issues/3986: Migrate QuickActionSheet to LibState

* Closes https://github.com/mozilla-mobile/fenix/issues/3661: Add tests for QuickActionSheet

Co-authored-by: boek <jeff@jeffboek.com>

* For https://github.com/mozilla-mobile/fenix/issues/3986: Fix feedback
 2019-07-22 10:31:31 -07:00
Nikit Bhandari
85b152e817 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4201 fix app crash on renaming a collection (https://github.com/mozilla-mobile/fenix/pull/4202) 
* For https://github.com/mozilla-mobile/fenix/issues/4201 fix app crash on renaming a collection

* update
 2019-07-22 10:31:00 -07:00
isabelrios
0dab6ec592 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4094 - Improved original PR to fix screenshots tests API21 (https://github.com/mozilla-mobile/fenix/pull/4144) 
use robot for three dot menu screenshot
 2019-07-22 09:58:53 -07:00
Jonathan Almeida
b9efd29892 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4171: Do not pause deviceEventObserver on lifecycle events 2019-07-19 14:00:26 -07:00
Nikit Bhandari
d65ea7cb2e [fenix] use synthetic binding instead of findviewbyid 2019-07-19 16:51:26 -04:00
Tiger Oakes
9e87335875 [fenix] Update to use Mozilla Android Components 5.0.0 2019-07-19 16:41:38 -04:00
Jeff Boek
98f20218dc [fenix] Forhttps://github.com/mozilla-mobile/fenix/issues/3278 - Updates strings in preferences (https://github.com/mozilla-mobile/fenix/pull/4184) 2019-07-19 12:31:55 -07:00
Mihai Adrian
e8df291be2 [fenix] fixes https://github.com/mozilla-mobile/fenix/issues/4176 (https://github.com/mozilla-mobile/fenix/pull/4175) 
adds content description to 'browse privately' card, replacing placeholder %s with the header_text of card
 2019-07-19 14:23:10 -05:00
Emily Kager
e4502abf64 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4145 - Remove anchor view from fullscreen snackbar (https://github.com/mozilla-mobile/fenix/pull/4160) 2019-07-19 11:18:47 -07:00
Emily Kager
ca31389ba6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4143 - Allow user to rotate to other landscape orientation 2019-07-19 14:12:33 -04:00
Sawyer Blatz
1f301464fb [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/2464: Remove Glide dependency (https://github.com/mozilla-mobile/fenix/pull/4169) 2019-07-19 11:06:49 -07:00
Jonathan Almeida
892014a83e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4075: Add Feature Flag class (https://github.com/mozilla-mobile/fenix/pull/4077) 2019-07-18 17:20:12 -07:00
Sawyer Blatz
2eec24783a [fenix] No issue: Removes unnecessary fragment transitions from accounts 
Co-authored-by: ekager <emilykager@gmail.com>
 2019-07-18 19:56:25 -04:00
Sawyer Blatz
cf87860d78 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/1944 & https://github.com/mozilla-mobile/fenix/issues/1750: Updates private & night mode colors (https://github.com/mozilla-mobile/fenix/pull/4162)" 
This reverts commit e9426179bdd65f682bfd7a849c246e77bd9abf19.
 2019-07-18 19:55:56 -04:00
Axel Hecht
3cf1de1ee6 [fenix] Import strings from android-l10n (https://github.com/mozilla-mobile/fenix/pull/4110) 
State: mozilla-l10n/android-l10n@e521a2aab2
 2019-07-18 16:07:01 -07:00
Sawyer Blatz
9d4312204f [fenix] For https://github.com/mozilla-mobile/fenix/issues/969: Adds telemetry for collections (https://github.com/mozilla-mobile/fenix/pull/3935) 2019-07-18 16:05:42 -07:00
Sawyer Blatz
6dd34ece58 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2267: Adds telemetry for reader mode (https://github.com/mozilla-mobile/fenix/pull/3941) 2019-07-18 15:17:15 -07:00
Tiger Oakes
0e78e740f2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3633 - Update StoreProvider to use a callback 
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
 2019-07-18 18:16:49 -04:00
Jeff Boek
c6c5f6918c [fenix] Fix search metrics (https://github.com/mozilla-mobile/fenix/pull/4150) 
* For https://github.com/mozilla-mobile/fenix/issues/4082 - Changes lifecycles for metrics

* For https://github.com/mozilla-mobile/fenix/issues/4082 - Replaces the SearchEngine name with the identifier for
countLabel
 2019-07-18 14:35:34 -07:00