[fenix] For https://github.com/mozilla-mobile/fenix/issues/4451: Adds tests for DefaultBrowserToolbarController (https://github.com/mozilla-mobile/fenix/pull/4493)
* For https://github.com/mozilla-mobile/fenix/issues/4451: Adds tests for DefaultBrowserToolbarController * Continue working * Large refactoring of test * Mock analytics * Fix merge conflictspull/600/head
parent
9f5097b48c
commit
93a03e892e
@ -0,0 +1,338 @@
|
||||
/* This Source Code Form is subject to the terms of the Mozilla Public
|
||||
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
||||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
||||
|
||||
package org.mozilla.fenix.components.toolbar
|
||||
|
||||
import android.content.Intent
|
||||
import androidx.core.widget.NestedScrollView
|
||||
import androidx.navigation.NavController
|
||||
import com.google.android.material.bottomsheet.BottomSheetBehavior
|
||||
import io.mockk.Runs
|
||||
import io.mockk.every
|
||||
import io.mockk.just
|
||||
import io.mockk.mockk
|
||||
import io.mockk.verify
|
||||
import mozilla.components.browser.session.Session
|
||||
import mozilla.components.browser.session.SessionManager
|
||||
import mozilla.components.concept.engine.EngineView
|
||||
import mozilla.components.feature.session.SessionUseCases
|
||||
import mozilla.components.feature.tabs.TabsUseCases
|
||||
import org.junit.Before
|
||||
import org.junit.Test
|
||||
import org.mozilla.fenix.BrowsingModeManager
|
||||
import org.mozilla.fenix.HomeActivity
|
||||
import org.mozilla.fenix.R
|
||||
import org.mozilla.fenix.browser.BrowserFragment
|
||||
import org.mozilla.fenix.browser.BrowserFragmentDirections
|
||||
import org.mozilla.fenix.collections.CreateCollectionViewModel
|
||||
import org.mozilla.fenix.collections.SaveCollectionStep
|
||||
import org.mozilla.fenix.components.Analytics
|
||||
import org.mozilla.fenix.components.metrics.Event
|
||||
import org.mozilla.fenix.components.metrics.MetricController
|
||||
import org.mozilla.fenix.ext.components
|
||||
import org.mozilla.fenix.ext.metrics
|
||||
import org.mozilla.fenix.ext.nav
|
||||
import org.mozilla.fenix.home.sessioncontrol.Tab
|
||||
import org.mozilla.fenix.home.sessioncontrol.TabCollection
|
||||
|
||||
class DefaultBrowserToolbarControllerTest {
|
||||
|
||||
private var context: HomeActivity = mockk(relaxed = true)
|
||||
private var analytics: Analytics = mockk(relaxed = true)
|
||||
private var navController: NavController = mockk(relaxed = true)
|
||||
private var findInPageLauncher: () -> Unit = mockk(relaxed = true)
|
||||
private val nestedScrollQuickActionView: NestedScrollView = mockk(relaxed = true)
|
||||
private val engineView: EngineView = mockk(relaxed = true)
|
||||
private val currentSession: Session = mockk(relaxed = true)
|
||||
private val viewModel: CreateCollectionViewModel = mockk(relaxed = true)
|
||||
private val getSupportUrl: () -> String = { "https://supportUrl.org" }
|
||||
private val openInFenixIntent: Intent = mockk(relaxed = true)
|
||||
private val currentSessionAsTab: Tab = mockk(relaxed = true)
|
||||
private val bottomSheetBehavior: BottomSheetBehavior<NestedScrollView> = mockk(relaxed = true)
|
||||
private val metrics: MetricController = mockk(relaxed = true)
|
||||
private val sessionUseCases: SessionUseCases = mockk(relaxed = true)
|
||||
|
||||
private lateinit var controller: DefaultBrowserToolbarController
|
||||
|
||||
@Before
|
||||
fun setUp() {
|
||||
controller = DefaultBrowserToolbarController(
|
||||
context = context,
|
||||
navController = navController,
|
||||
findInPageLauncher = findInPageLauncher,
|
||||
nestedScrollQuickActionView = nestedScrollQuickActionView,
|
||||
engineView = engineView,
|
||||
currentSession = currentSession,
|
||||
viewModel = viewModel,
|
||||
getSupportUrl = getSupportUrl,
|
||||
openInFenixIntent = openInFenixIntent,
|
||||
currentSessionAsTab = currentSessionAsTab,
|
||||
bottomSheetBehavior = bottomSheetBehavior
|
||||
)
|
||||
|
||||
every { context.components.analytics } returns analytics
|
||||
every { analytics.metrics } returns metrics
|
||||
every { context.components.useCases.sessionUseCases } returns sessionUseCases
|
||||
}
|
||||
|
||||
@Test
|
||||
fun handleToolbarClick() {
|
||||
every { currentSession.id } returns "1"
|
||||
|
||||
controller.handleToolbarClick()
|
||||
|
||||
verify { metrics.track(Event.SearchBarTapped(Event.SearchBarTapped.Source.BROWSER)) }
|
||||
verify { navController.nav(
|
||||
R.id.browserFragment,
|
||||
BrowserFragmentDirections.actionBrowserFragmentToSearchFragment(currentSession.id)
|
||||
) }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun handleToolbarBackPress() {
|
||||
val item = ToolbarMenu.Item.Back
|
||||
|
||||
controller.handleToolbarItemInteraction(item)
|
||||
|
||||
verify { metrics.track(Event.BrowserMenuItemTapped(Event.BrowserMenuItemTapped.Item.BACK)) }
|
||||
verify { sessionUseCases.goBack }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun handleToolbarForwardPress() {
|
||||
val item = ToolbarMenu.Item.Forward
|
||||
|
||||
controller.handleToolbarItemInteraction(item)
|
||||
|
||||
verify { metrics.track(Event.BrowserMenuItemTapped(Event.BrowserMenuItemTapped.Item.FORWARD)) }
|
||||
verify { sessionUseCases.goForward }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun handleToolbarReloadPress() {
|
||||
val item = ToolbarMenu.Item.Reload
|
||||
|
||||
every { context.components.useCases.sessionUseCases } returns sessionUseCases
|
||||
|
||||
controller.handleToolbarItemInteraction(item)
|
||||
|
||||
verify { metrics.track(Event.BrowserMenuItemTapped(Event.BrowserMenuItemTapped.Item.RELOAD)) }
|
||||
verify { sessionUseCases.reload }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun handleToolbarStopPress() {
|
||||
val item = ToolbarMenu.Item.Stop
|
||||
|
||||
controller.handleToolbarItemInteraction(item)
|
||||
|
||||
verify { metrics.track(Event.BrowserMenuItemTapped(Event.BrowserMenuItemTapped.Item.STOP)) }
|
||||
verify { sessionUseCases.stopLoading }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun handleToolbarSettingsPress() {
|
||||
val item = ToolbarMenu.Item.Settings
|
||||
|
||||
controller.handleToolbarItemInteraction(item)
|
||||
|
||||
verify { metrics.track(Event.BrowserMenuItemTapped(Event.BrowserMenuItemTapped.Item.SETTINGS)) }
|
||||
verify { navController.nav(
|
||||
R.id.settingsFragment,
|
||||
BrowserFragmentDirections.actionBrowserFragmentToSettingsFragment()
|
||||
) }
|
||||
}
|
||||
@Test
|
||||
fun handleToolbarLibraryPress() {
|
||||
val item = ToolbarMenu.Item.Library
|
||||
|
||||
controller.handleToolbarItemInteraction(item)
|
||||
|
||||
verify { metrics.track(Event.BrowserMenuItemTapped(Event.BrowserMenuItemTapped.Item.LIBRARY)) }
|
||||
verify { navController.nav(
|
||||
R.id.libraryFragment,
|
||||
BrowserFragmentDirections.actionBrowserFragmentToSettingsFragment()
|
||||
) }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun handleToolbarRequestDesktopOnPress() {
|
||||
val requestDesktopSiteUseCase: SessionUseCases.RequestDesktopSiteUseCase = mockk(relaxed = true)
|
||||
val item = ToolbarMenu.Item.RequestDesktop(true)
|
||||
|
||||
every { sessionUseCases.requestDesktopSite } returns requestDesktopSiteUseCase
|
||||
|
||||
controller.handleToolbarItemInteraction(item)
|
||||
|
||||
verify { metrics.track(Event.BrowserMenuItemTapped(Event.BrowserMenuItemTapped.Item.DESKTOP_VIEW_ON)) }
|
||||
verify {
|
||||
requestDesktopSiteUseCase.invoke(
|
||||
true,
|
||||
currentSession
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun handleToolbarRequestDesktopOffPress() {
|
||||
val requestDesktopSiteUseCase: SessionUseCases.RequestDesktopSiteUseCase = mockk(relaxed = true)
|
||||
val item = ToolbarMenu.Item.RequestDesktop(false)
|
||||
|
||||
every { sessionUseCases.requestDesktopSite } returns requestDesktopSiteUseCase
|
||||
|
||||
controller.handleToolbarItemInteraction(item)
|
||||
|
||||
verify { metrics.track(Event.BrowserMenuItemTapped(Event.BrowserMenuItemTapped.Item.DESKTOP_VIEW_OFF)) }
|
||||
verify {
|
||||
requestDesktopSiteUseCase.invoke(
|
||||
false,
|
||||
currentSession
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun handleToolbarSharePress() {
|
||||
val item = ToolbarMenu.Item.Share
|
||||
|
||||
every { currentSession.url } returns "https://mozilla.org"
|
||||
|
||||
controller.handleToolbarItemInteraction(item)
|
||||
|
||||
verify { metrics.track(Event.BrowserMenuItemTapped(Event.BrowserMenuItemTapped.Item.SHARE)) }
|
||||
verify {
|
||||
val directions = BrowserFragmentDirections.actionBrowserFragmentToShareFragment(currentSession.url)
|
||||
navController.nav(R.id.browserFragment, directions)
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun handleToolbarNewPrivateTabPress() {
|
||||
val browsingModeManager: BrowsingModeManager = mockk(relaxed = true)
|
||||
val item = ToolbarMenu.Item.NewPrivateTab
|
||||
|
||||
every { context.browsingModeManager } returns browsingModeManager
|
||||
every { browsingModeManager.mode } returns BrowsingModeManager.Mode.Normal
|
||||
|
||||
controller.handleToolbarItemInteraction(item)
|
||||
|
||||
verify { metrics.track(Event.BrowserMenuItemTapped(Event.BrowserMenuItemTapped.Item.NEW_PRIVATE_TAB)) }
|
||||
verify {
|
||||
val directions = BrowserFragmentDirections
|
||||
.actionBrowserFragmentToSearchFragment(null)
|
||||
navController.nav(R.id.browserFragment, directions)
|
||||
}
|
||||
verify { browsingModeManager.mode = BrowsingModeManager.Mode.Private }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun handleToolbarFindInPagePress() {
|
||||
val item = ToolbarMenu.Item.FindInPage
|
||||
|
||||
controller.handleToolbarItemInteraction(item)
|
||||
|
||||
verify { bottomSheetBehavior.state = BottomSheetBehavior.STATE_COLLAPSED }
|
||||
verify { findInPageLauncher() }
|
||||
verify { metrics.track(Event.FindInPageOpened) }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun handleToolbarReportIssuePress() {
|
||||
val tabsUseCases: TabsUseCases = mockk(relaxed = true)
|
||||
val addTabUseCase: TabsUseCases.AddNewTabUseCase = mockk(relaxed = true)
|
||||
|
||||
val item = ToolbarMenu.Item.ReportIssue
|
||||
|
||||
every { currentSession.url } returns "https://mozilla.org"
|
||||
every { context.components.useCases.tabsUseCases } returns tabsUseCases
|
||||
every { tabsUseCases.addTab } returns addTabUseCase
|
||||
|
||||
controller.handleToolbarItemInteraction(item)
|
||||
|
||||
verify { metrics.track(Event.BrowserMenuItemTapped(Event.BrowserMenuItemTapped.Item.REPORT_SITE_ISSUE)) }
|
||||
verify {
|
||||
// Hardcoded URL because this function modifies the URL with an apply
|
||||
addTabUseCase.invoke(String.format(BrowserFragment.REPORT_SITE_ISSUE_URL, "https://mozilla.org"))
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun handleToolbarHelpPress() {
|
||||
val tabsUseCases: TabsUseCases = mockk(relaxed = true)
|
||||
val addTabUseCase: TabsUseCases.AddNewTabUseCase = mockk(relaxed = true)
|
||||
|
||||
val item = ToolbarMenu.Item.Help
|
||||
|
||||
every { context.components.useCases.tabsUseCases } returns tabsUseCases
|
||||
every { tabsUseCases.addTab } returns addTabUseCase
|
||||
|
||||
controller.handleToolbarItemInteraction(item)
|
||||
|
||||
verify { metrics.track(Event.BrowserMenuItemTapped(Event.BrowserMenuItemTapped.Item.HELP)) }
|
||||
verify {
|
||||
addTabUseCase.invoke(getSupportUrl())
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun handleToolbarNewTabPress() {
|
||||
val browsingModeManager: BrowsingModeManager = mockk(relaxed = true)
|
||||
val item = ToolbarMenu.Item.NewTab
|
||||
|
||||
every { context.browsingModeManager } returns browsingModeManager
|
||||
every { browsingModeManager.mode } returns BrowsingModeManager.Mode.Private
|
||||
|
||||
controller.handleToolbarItemInteraction(item)
|
||||
|
||||
verify { metrics.track(Event.BrowserMenuItemTapped(Event.BrowserMenuItemTapped.Item.NEW_TAB)) }
|
||||
verify {
|
||||
val directions = BrowserFragmentDirections
|
||||
.actionBrowserFragmentToSearchFragment(null)
|
||||
navController.nav(R.id.browserFragment, directions)
|
||||
}
|
||||
verify { browsingModeManager.mode = BrowsingModeManager.Mode.Normal }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun handleToolbarSaveToCollectionPress() {
|
||||
val item = ToolbarMenu.Item.SaveToCollection
|
||||
val cachedTabCollections: List<TabCollection> = mockk(relaxed = true)
|
||||
every { context.components.useCases.sessionUseCases } returns sessionUseCases
|
||||
every { context.components.core.tabCollectionStorage.cachedTabCollections } returns cachedTabCollections
|
||||
|
||||
controller.handleToolbarItemInteraction(item)
|
||||
|
||||
verify { metrics.track(Event.BrowserMenuItemTapped(Event.BrowserMenuItemTapped.Item.SAVE_TO_COLLECTION)) }
|
||||
verify { metrics.track(Event.CollectionSaveButtonPressed(DefaultBrowserToolbarController.TELEMETRY_BROWSER_IDENTIFIER)) }
|
||||
verify { viewModel.tabs = listOf(currentSessionAsTab) }
|
||||
verify { viewModel.selectedTabs = mutableSetOf(currentSessionAsTab) }
|
||||
verify { viewModel.tabCollections = cachedTabCollections.reversed() }
|
||||
verify { viewModel.saveCollectionStep = SaveCollectionStep.SelectCollection }
|
||||
verify { viewModel.snackbarAnchorView = nestedScrollQuickActionView }
|
||||
verify { viewModel.previousFragmentId = R.id.browserFragment }
|
||||
verify {
|
||||
val directions = BrowserFragmentDirections
|
||||
.actionBrowserFragmentToSearchFragment(null)
|
||||
navController.nav(R.id.browserFragment, directions)
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun handleToolbarOpenInFenixPress() {
|
||||
val sessionManager: SessionManager = mockk(relaxed = true)
|
||||
val item = ToolbarMenu.Item.OpenInFenix
|
||||
|
||||
every { context.components.core.sessionManager } returns sessionManager
|
||||
every { currentSession.customTabConfig } returns mockk()
|
||||
every { context.startActivity(any()) } just Runs
|
||||
|
||||
controller.handleToolbarItemInteraction(item)
|
||||
|
||||
verify { engineView.release() }
|
||||
verify { currentSession.customTabConfig = null }
|
||||
verify { sessionManager.select(currentSession) }
|
||||
verify { context.startActivity(openInFenixIntent) }
|
||||
verify { context.finish() }
|
||||
}
|
||||
}
|
Loading…
Reference in New Issue