Mugurell
9abf05e7fc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16500 - Ensure CardView clips ImageView on lower APIs ( https://github.com/mozilla-mobile/fenix/pull/16507 )
...
ImageViews are normally not clipped but extend to cover the entire width and
height set.
CardViews as a parent can help with that but on lower APIS they still need a
shapeAppearance which is a property already in the added style.
4 years ago
mcarare
f535d467cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16416 : Remove save to collection button from tab a11y list.
4 years ago
ekager
a197281092
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16132 - Revise multiselect mode UI
4 years ago
mozilla-l10n-automation-bot
9e347d601f
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16468 )
4 years ago
Mugurell
da543114c3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16424 - Focus the right item in tabs tray when using Talkback ( https://github.com/mozilla-mobile/fenix/pull/16472 )
...
To get the index of the current selected browser tab when using reverse layout
we should also account for items placed below of the browser tabs.
The patch here unifies the logic already used for some calls but not all.
4 years ago
Codrut Topliceanu
23ff2851e6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15720 - Remove unused telemetry ( https://github.com/mozilla-mobile/fenix/pull/15887 )
4 years ago
Gabriel Luong
ebc1ba3b50
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15960 - Enable Grid View in Nightly only ( https://github.com/mozilla-mobile/fenix/pull/16462 )
4 years ago
mcarare
85d00ac291
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16426 : Allow multiselect title to be selected by a11y services.
4 years ago
mozilla-l10n-automation-bot
c32bbcc3e8
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16447 )
4 years ago
Christian Sadilek
70852916d6
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16430 : ExternalAppBrowserActivity should not handle incoming intents
4 years ago
mozilla-l10n-automation-bot
3ab61bec1b
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16441 )
4 years ago
Mihai Adrian Carare
489e8cc970
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15764 - Update Tabs summary description. ( https://github.com/mozilla-mobile/fenix/pull/16428 )
4 years ago
Christian Sadilek
0ccff38ebc
[fenix] Update Android Components version to 66.0.20201106143126 ( https://github.com/mozilla-mobile/fenix/pull/16439 )
4 years ago
Oana Horvath
2748519959
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15847 : use Espresso's RecyclerView scrollTo action
4 years ago
Mozilla L10n Automation Bot
77cfcd82c3
[fenix] Import l10n.
4 years ago
Christian Sadilek
80e9e1fa8e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16327 : Refactor MenuPresenter to use browser store
4 years ago
Arturo Mejia
8cc09b5785
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/15934 fix ConcurrentModificationException
...
on WifiConnectionMonitor
4 years ago
Sebastian Kaspari
84770f1f64
[fenix] Fix GeckoProvider for beta and release variant.
4 years ago
rxu
3ec2a3d971
[fenix] Add mozcn safebrowsing
4 years ago
Michael Comella
c481d0504b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 - review: set LazyMonitored to private.
4 years ago
Michael Comella
17b32070dd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : add component init count to StartupExcessiveResourceUseTest.
4 years ago
Michael Comella
7ac4b40fa8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : remove redundant lazy wrapper from storage APIs.
...
They're currently lazy { lazy { value } }. Accessing `lazy.value`
directly allows us to make it lazy { value }. This should be more
performant and prevents us from double-counting these components.
4 years ago
Michael Comella
9e8fd7c6f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : LazyMonitored implement Lazy + update built-in API use.
...
By having LazyMonitored implement Lazy, we can continue to pass these
values directly into the ac APIs that require Lazy references. For some
reason, implementing `Lazy.value` can replace `operator fun getValue`
required for delegates.
4 years ago
Michael Comella
3879697c06
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : replace lazy with lazyMonitored in component groups.
...
By component groups, I mean I applied this to any class with the
class kdoc, "Component group for...".
There are a few instances of lazy we had to keep using the old API to
avoid having to update constructor arguments.
4 years ago
Michael Comella
07e69195f2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : add LazyMonitored and tests.
4 years ago
mozilla-l10n-automation-bot
83cf8baedf
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16380 )
4 years ago
Kate Glazko
88375a2294
[fenix] For https://github.com/mozilla-mobile/fenix/issues/352 : Delete a download
4 years ago
ekager
5344dceead
[fenix] No issue: Update stable androidx and material versions
4 years ago
Mugurell
f3d5862668
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6521 - Remove auto sigin onboarding card ( https://github.com/mozilla-mobile/fenix/pull/16315 )
...
With the Fennec -> Fenix migration complete there is no other Mozilla
application that would serve as a custom account provider hence the automatic
signin would not be possible.
Make this more obvious by commenting out the code that would trigger an
onboarding banner for it but keep the code in the app for when https://github.com/mozilla-mobile/fenix/issues/15694 would add
to Fenix the ability to serve as a custom account provider.
4 years ago
Mugurell
0a8d8cfbf0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16323 - Use 10dp corner radius for the selected outer border of a grid item ( https://github.com/mozilla-mobile/fenix/pull/16364 )
...
This would ensure the corners of the inner and outer borders are aligned, with
no empty gap between them.
4 years ago
Mugurell
2f04b48e7c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14980 - Effectively disable tabs tray STATE_HALF_EXPANDED ( https://github.com/mozilla-mobile/fenix/pull/16052 )
...
STATE_HALF_EXPANDED cannot be disabled while also keeping fitToContents = true
based on which the tabs tray layout is currently set.
To work around this we'll set a a minuscule height for the tab tray when in
this state and then immediately advance to STATE_HIDDEN so to make it
imperceptible to the users.
Since I couldn't write unit tests because of InflateExceptions in Robolectric
I've written UI tests to protect against regressions.
4 years ago
Mihai Adrian Carare
647117ca54
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13172 - Tab swipe order follows text direction from oldest to newest ( https://github.com/mozilla-mobile/fenix/pull/16178 )
4 years ago
Rafał Opiłowski
7dab7b2d53
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12971 - Show collection saved snackbar above FAB ( https://github.com/mozilla-mobile/fenix/pull/16311 )
4 years ago
Oana Horvath
24d2b31b74
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15847 - Disables verifyAboutFirefoxPreview UI test ( https://github.com/mozilla-mobile/fenix/pull/16346 )
4 years ago
Mugurell
5311233fae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16339 - Initialize FxaAccountManager with also a CrashReporter ( https://github.com/mozilla-mobile/fenix/pull/16340 )
4 years ago
Sebastian Kaspari
03343e86ed
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16256 : Introduce build flag for "Mozilla Online" variant.
...
This patch introduces a build flag that can be used on demand on the command line (`./gradlew -PmozillaOnline [..}`) or
permanently when added to local.properties (`mozillaOnline`).
At runtime `Config.channel.isMozillaOnline` will return `true` if the flag was set at build time.
4 years ago
Oana Horvath
4fe05cc97c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13446 UI tests: wait for historyList to exist
4 years ago
Mozilla L10n Automation Bot
9007d8d33e
[fenix] Import l10n.
4 years ago
Gabriel Luong
ba18f60d64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14636 - Update preference section headers to use correct color, spacing and rulers ( https://github.com/mozilla-mobile/fenix/pull/16332 )
4 years ago
Michael Comella
b495ffee53
[fenix] No issue - review: clarify thread safety of suppressionCount.
4 years ago
Michael Comella
6fed5f3177
[fenix] No issue: make StrictMode suppression count thread safe.
4 years ago
Christian Sadilek
ecd79c4d6e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 : Switch to consumeFlow and add tests
4 years ago
ekager
5991d0996e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4652 - Remove activityViewModels workarounds
4 years ago
MarcLeclair
78850c7e3d
[fenix] 15278 detekt rule runblocking ( https://github.com/mozilla-mobile/fenix/pull/15942 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15278 : added CoroutineManager to count runBlocking calls
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added actual detekt rule for runblocking and its config to the yaml
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added unit test for RunblockingCounter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test
* Lint fix
* For https://github.com/mozilla-mobile/fenix/issues/15278 : made runblocking a Long to prevent overflow
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fixed MozRunblocking name, description and moved RunBlockingCounter to perf package
* For https://github.com/mozilla-mobile/fenix/issues/15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added setup for unit test, since it failed without restting counter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Fixed naming for RunBlocking lint check
* For https://github.com/mozilla-mobile/fenix/issues/15278 : removed changes made to test to use runBlockingIncrement
* For https://github.com/mozilla-mobile/fenix/issues/15728 : added test exclusion for runBlocking check
* For https://github.com/mozilla-mobile/fenix/issues/15278 : changed null check and added Synchronized to count setter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fix for nits
* For https://github.com/mozilla-mobile/fenix/issues/15278 : added StartupExcessiveResourceUseTest to CODEOWNERS
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fixed for nits
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Moved increment function to extension function and fixed indentation
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added tests for Atomic Integer extension and nit fix
4 years ago
ekager
e564dda990
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6313 - Remove unneeded delay in BrowserAnimator
4 years ago
Roger Yang
f60df4a976
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16268 - Allowing multiple task while sharing ( https://github.com/mozilla-mobile/fenix/pull/16275 )
4 years ago
Jocelyne Abi Haidar
3139337d7f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15931 : Sort Downloads from newest to oldest ( https://github.com/mozilla-mobile/fenix/pull/15939 )
4 years ago
mcarare
e682cb55cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15430 : Fix StrictMode death on opening app from widget voice search.
4 years ago
mcarare
c66ab231d5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15430 : Fix StrictMode death on opening app from widget text search.
4 years ago
mcarare
87ce122d03
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14552 : Do not display back button when there is no tab history.
4 years ago
Mozilla L10n Automation Bot
a94eca1063
[fenix] Import l10n.
4 years ago
Mugurell
b85522198c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15963 - Increase touch target for the close button in the tabs tray grid layout
...
We need to ensure it has at least 48dp while also not appearing too big.
4 years ago
Mugurell
58a22af103
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15757 - Avoid the double spacing issues for grid items in tabs tray
...
Items should have a 16dp all around padding.
Have them have a 8dp padding that will add to 16 when placed together.
Have the parent have another 8dp that will add to 16 for when items are placed
to the edge of the available screen.
4 years ago
Mugurell
0dd114beb8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15968 - Show a border for the selected tab in the grid based tabs tray
...
The border for the grid item will now be updated in the same method that
updates the background for the list item.
4 years ago
Mugurell
f90db55a2f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15756 - Add a play/pause button in the tabs tray grid layout
...
Moved the previous layout in a new, bigger FrameLayout that would serve as a
buffer space for the play/pause button to be translated to the exterior.
Otherwise the button would be clipped.
4 years ago
Gabriel Luong
949d66da5f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9548 - Ability to rename top sites ( https://github.com/mozilla-mobile/fenix/pull/16285 )
...
* Ability to rename top sites, closes https://github.com/mozilla-mobile/fenix/issues/9548
* Highlight the "Remove" top site action as destructive
With more menu items in the top site contextual menu, it makes sense to differentiate
* Added test for the top site renaming action
* Fixed lint check (wildcard imports, blank spaces)
* Applied suggestions from code review
* Apply suggestions from code review
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
* Implemented dialog click listener with manual dismiss/cancel
Co-authored-by: Lorenzo Stanco <lorenzo.stanco@gmail.com>
4 years ago
ekager
c4d7e19da6
[fenix] No issue: Make sure we are cleaning up test coroutines
4 years ago
mozilla-l10n-automation-bot
0a9821fdbb
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16274 )
4 years ago
ekager
986e28f100
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16161 - Fixes Saved Login toolbar layout
4 years ago
Codrut Topliceanu
2d083e853a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14637 - Fix sitePermissionsFeature breaking change + AC bump ( https://github.com/mozilla-mobile/fenix/pull/16229 )
...
* For https://github.com/mozilla-mobile/fenix/issues/14637 - Compatibility patch for AC - 8554
* Update Android Components version to 65.0.20201029143039
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
4 years ago
mozilla-l10n-automation-bot
f15d1054bb
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16240 )
4 years ago
mcarare
3047ea3601
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16250 : Disable remote USB debugging for SDK <23.
4 years ago
Mihai Adrian Carare
5fb5471df1
[fenix] For # 15929: Remove the search widget discoverability experiment. ( https://github.com/mozilla-mobile/fenix/pull/16081 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove SearchWidgetCFR telemetry.
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove SearchWidgetCFR and search widget experiment.
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove unit tests references to search widget experiment.
4 years ago
mcarare
51018be388
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15413 : Use proper url when bookmarking a page.
4 years ago
Oana Horvath
0f70a8d4fc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10690 : re-enable editBookmarkTest
4 years ago
Mozilla L10n Automation Bot
29e7f50cc3
[fenix] Import l10n.
4 years ago
Arturo Mejia
df0da31c1f
[fenix] Fix AddonsManagementFragment detekt error
4 years ago
Christian Sadilek
79ab29eff2
[fenix] No issue: Fix onConfigurationChange crashes in Debug build
4 years ago
Christian Sadilek
56c98b57b8
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/11285 : Replace Session[Manager] observers in BaseBrowserFragment
4 years ago
Grisha Kruglov
268da65b3f
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15816 - Attempt to handle 'allowInPrivate..' pref with detached context
4 years ago
mcarare
047b712ffe
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15379 : Use proper url when sharing.
4 years ago
ekager
647e73e851
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16199 - Don't pass BrowserToolbarView in onStart when we just need parent
4 years ago
Arturo Mejia
d3faecd59c
[fenix] Fix add-on translation braking changes
4 years ago
Aaron Train
a224f0c546
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8169 - Upgrade Mockwebserver ( https://github.com/mozilla-mobile/fenix/pull/16186 )
...
Upgrades Mockwebserver to 4.9.0
4 years ago
mozilla-l10n-automation-bot
b28b69915e
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16198 )
4 years ago
Lorenzo Stanco
bd068b288a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16122 - Add a dark theme color for the top sites pin icon ( https://github.com/mozilla-mobile/fenix/pull/16180 )
4 years ago
mozilla-l10n-automation-bot
aba1e64d9a
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16163 )
4 years ago
mozilla-l10n-automation-bot
bb2a8acb16
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16154 )
4 years ago
ekager
f3d03c5e73
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6313 - Set session ClearColor through Engine DefaultSettings
4 years ago
mozilla-l10n-automation-bot
18012e4cfc
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16138 )
4 years ago
Jocelyne Abi Haidar
089fe7a9fd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15508 : Show error when trying to save empty or invalid bookmark URL ( https://github.com/mozilla-mobile/fenix/pull/15674 )
4 years ago
mozilla-l10n-automation-bot
6cd2d75989
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16108 )
4 years ago
Mugurell
ebcb172781
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15543 - Adjust the height of the tabs tray depending on the number of tabs ( https://github.com/mozilla-mobile/fenix/pull/15749 )
4 years ago
ekager
6ff5ec846b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 - Feature Flag return to browser ( https://github.com/mozilla-mobile/fenix/pull/16099 )
4 years ago
ekager
f8d0a97210
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16084 - Match elevation of Tab in Collection to header ( https://github.com/mozilla-mobile/fenix/pull/16100 )
4 years ago
ekager
29a179e8c3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15910 - Adds back automatic toggle, disables slider when enabled ( https://github.com/mozilla-mobile/fenix/pull/16070 )
4 years ago
Arturo Mejia
5070c12a7b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16019 - Fix intermittent test failure TrackingProtectionPolicyFactoryTest ( https://github.com/mozilla-mobile/fenix/pull/16056 )
4 years ago
mcarare
7f82d5e052
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14619 : Show half a tab top offset when scrolling to selected tab.
4 years ago
mozilla-l10n-automation-bot
d3cb8d03f0
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16074 )
4 years ago
Mugurell
ebcf7ea907
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16054 - Enable pull to refresh webpage in Nightly and Debug ( https://github.com/mozilla-mobile/fenix/pull/16060 )
4 years ago
Elise Richards
11e73eebfa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15080 : Handle default search engine when editing or removing ( https://github.com/mozilla-mobile/fenix/pull/15768 )
4 years ago
Juan C. Goncalves
a3fce6b92d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11397 - Add lint rule for AppCompatResources instead of ContextCompat ( https://github.com/mozilla-mobile/fenix/pull/16011 )
4 years ago
Sebastian Kaspari
09efe75e27
[fenix] FennecWebAppIntentProcessor: Catch JSONException.
4 years ago
Mihai Adrian Carare
274ab54236
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11631 : Move report site issue extension to main menu. ( https://github.com/mozilla-mobile/fenix/pull/15884 )
...
* For https://github.com/mozilla-mobile/fenix/issues/11631 : Move report site issue extension to main menu.
* For https://github.com/mozilla-mobile/fenix/issues/11631 : Update UI test for installing add-on.
4 years ago
Tom Klein
85d7bb0baf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15480 - Update the UI when a collection is renamed
4 years ago
mcarare
d7c63a63c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15688 : Update UI tests.
4 years ago
mcarare
0c48e945f7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15688 : Update unit tests.
4 years ago
mcarare
ff595c7854
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15688 : Navigate to home screen with arguments on new tab action.
4 years ago
Mozilla L10n Automation Bot
a9e3cb974b
[fenix] Import l10n.
4 years ago
Sebastian Kaspari
9c7e0ad770
[fenix] Update Android Components, Kotlin, Gradle plugin ( https://github.com/mozilla-mobile/fenix/pull/16021 )
...
* Closes https://github.com/mozilla-mobile/fenix/issues/13262 : Update AGP to 4
* Update to Mozilla Android Components 63.0.20201019090011.
* Update Kotlin to 1.4.10 and Coroutines to 1.3.9.
* Fix new compiler warnings.
* Fix compilation of lint rules module.
* Pin JNA version.
* Fix new lint errors.
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
Mihai Adrian Carare
b931723651
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14744 : Also show Fill link from clipboard with search shortcuts. ( https://github.com/mozilla-mobile/fenix/pull/15885 )
4 years ago
Christian Sadilek
5c9e32efda
[fenix] Configure M5 AMO collection for all builds
4 years ago
mozilla-l10n-automation-bot
b763fd4449
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16014 )
4 years ago
mozilla-l10n-automation-bot
0e83246501
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16001 )
4 years ago
mozilla-l10n-automation-bot
0a5089879a
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/15986 )
4 years ago
Gabriel Luong
d1e5785dad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15796 - Use the device locale for the system locale subtitle ( https://github.com/mozilla-mobile/fenix/pull/15975 )
4 years ago
Gabriel Luong
36ab249924
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15937 - Remove topFrecentSite feature flag ( https://github.com/mozilla-mobile/fenix/pull/15967 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15937 - Remove the topFrecentSite feature flag
* For https://github.com/mozilla-mobile/fenix/issues/15937 - Hide the "Pull to refresh" preference since its visibility is managed by a feature flag
4 years ago
ekager
b7cb6aa53c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7345 - Update new shield icons, remove lottie ( https://github.com/mozilla-mobile/fenix/pull/15909 )
4 years ago
Christian Sadilek
8ec056ffb9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/11286 : Add TelemetryMiddleware to remove Session[Manager] observers
4 years ago
Gabriel Luong
96e38a14eb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15796 - show device language under follow device language ( https://github.com/mozilla-mobile/fenix/pull/15966 )
4 years ago
amkcpu
37f4575e58
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10683 : Show longer tab titles
...
Also update tab tray item layout according to specs posted in the issue.
4 years ago
mozilla-l10n-automation-bot
6d9480ec2d
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/15945 )
4 years ago
Jeff Boek
81556c956a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15596 - Removes upgrade faq link from fennec builds ( https://github.com/mozilla-mobile/fenix/pull/15643 )
4 years ago
Gabriel Luong
19b4a4ef5b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14922 : Use padding instead of margin to use the full screen width for the "Add search engine" button
4 years ago
mcarare
5348bed401
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14922 : Adjust margins for add search engine preference.
4 years ago
mcarare
30bd0ed572
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14922 : Add divider above address bar preferences.
4 years ago
mcarare
fcbe467703
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15898 : Add dividers above subheadings in tabs screen.
4 years ago
mcarare
ee99347d3d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15898 : Add dividers above subheadings in customise screen.
4 years ago
Michael Comella
0a83eb56f4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : add comment for why we set the app theme in test.
4 years ago
Michael Comella
aa19f541b2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : change apply to with in GleanMetricsService.
...
While the callback receiver is identical in these two methods, they're
semantically different: apply is for initializing the receiver while with
is anything else benefiting from a new `this` receiver.
I didn't change the usage of apply that has a return statement because I
was afraid my change might change behavior.
4 years ago
Michael Comella
910b7f19aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : mock package inspection dependencies in GleanMetricsService.
...
The new robolectric version changed the behavior such that the app ID
that was returned for our app was `org.mozilla.fenix.debug` instead of
(I guess) `org.mozilla.fenix`. In general, relying on robolectric can be
fragile, such as this case, so it's better to mock. Also, this test
behavior should theoretically have varied between build flavors so
mocking prevents the tests from breaking across flavors.
4 years ago
ekager
69a126cbb6
[fenix] Sets theme in FenixRobolectricTestApplication onCreate
4 years ago
Michael Comella
7cc54078d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : escalate many Performance check severity in lint.xml.
...
I exhaustively looked through the list of checks labeled performance and
marked them accordingly. To see all lint checks, type:
<android-sdk>/tools/bin/lint --show
4 years ago
Michael Comella
106a36bcdc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : remove unnecessary lint ignore.
4 years ago
Michael Comella
fec7662d8e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : escalate InefficientWeight to error.
...
All violations of this type were addressed in the previous commit.
4 years ago
ekager
74b4866e3d
[fenix] Fixes existing lint errors
4 years ago
Gabriel Luong
ef60d82caa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15907 - Remove the usage of the TabTrayGridItemDecorator
4 years ago
ekager
9d876a7076
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15347 - Adds telemetry for tabs settings
4 years ago
ekager
9f67b3df9b
[fenix] fix detekt errors
4 years ago
Sebastian Kaspari
3368ddce5c
[fenix] Use new SearchEngineProvider interface.
4 years ago
Mozilla L10n Automation Bot
d064b26fc0
[fenix] Import l10n.
4 years ago
Michael Comella
2b368b4bff
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 - review: add license to lint-baseline.xml.
4 years ago
Michael Comella
30208f0345
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 : add current ConstraintLayout warnings to lint baseline.
4 years ago
Michael Comella
88cf7184ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 : suppress new lint rule in migration code.
4 years ago
ekager
5baed32e13
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15265 - Save cached top sites for metrics ping
4 years ago
ekager
6ee2d5a8dd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 - Launch back to browser if we previoulsy had tabs
4 years ago
Mugurell
5cdb7f3a73
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15890 - Ensure app locale switcher works for Windows builds
...
A hardcoded unix file separator prevented us from building a proper list of
locales for which we actually have packaged translations.
4 years ago
Mozilla L10n Automation Bot
ad43cd47a2
[fenix] Import l10n.
4 years ago
ekager
3726b8c98b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15853 - Always set fontSizeFactor setting with new text scale
4 years ago
Mihai Adrian Carare
26854525c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14735 : Remove debug logs from release build. ( https://github.com/mozilla-mobile/fenix/pull/15747 )
4 years ago
Mozilla L10n Automation Bot
f0a7f1bce0
[fenix] Import l10n.
4 years ago
Gabriel Luong
312626f8f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15777 - [Grid View] Set the height of the title to 30dp
4 years ago
Gabriel Luong
f977e5af36
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15758 ⁃ [Grid View] Add a divider between the tab item's title and thumbnail
4 years ago
Mozilla L10n Automation Bot
031b4687c6
[fenix] Import l10n.
4 years ago
Mozilla L10n Automation Bot
f1753eed23
[fenix] Import l10n.
4 years ago
Grisha Kruglov
53244870e9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15812 : Check for a null context during onScanResult
4 years ago
Mozilla L10n Automation Bot
993335b296
[fenix] Import l10n.
4 years ago
Shen
c63bc04bd2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13168 - Removed the close button from history navigation bar
4 years ago
Michael Comella
4fedc9d719
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - post: link to issue, data review.
4 years ago
Michael Comella
88268c18a1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - review: clarify init time for External...Activity.
4 years ago
Michael Comella
6c86641cbc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - review: change extra name to firstFramePreDrawNanos.
4 years ago
sraturi
e97a48b48f
[fenix] for https://github.com/mozilla-mobile/fenix/issues/10069 added AppLaunchTimeMeasurement.kt to handle logic of startup time for cold, warm, and hot startup types.
4 years ago
mcarare
69db319601
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13831 : Adjust buttons dimensions to improve a11y.
...
Margins were also adjusted to maintain relative placements.
4 years ago
mcarare
1ca3aab28a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13831 : Add ripple for the copy password button.
4 years ago
ekager
bf2e2d545d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14923 - Removes auto size preference toggle
4 years ago
Sijan Rijal
3aaded4868
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15402 : Hide ETP pop-up if the toolbar is not visible ( https://github.com/mozilla-mobile/fenix/pull/15667 )
...
For https://github.com/mozilla-mobile/fenix/issues/15402 : Hide ETP pop-up when top or bottom toolbar is not visible
4 years ago
Sijan Rijal
17fc28304a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15497 : Hide and remove the three dot menu from the Desktop Bookmarks folder ( https://github.com/mozilla-mobile/fenix/pull/15649 )
...
For https://github.com/mozilla-mobile/fenix/issues/15497 : Remove and disable the three dot menu button
4 years ago
Mozilla L10n Automation Bot
db1ad2ac93
[fenix] Import l10n.
4 years ago
Jonathan Almeida
8281e16c83
[fenix] Fix lint warnings and test in site permissions
4 years ago
Arturo Mejia
4f67095c8b
[fenix] Add support for local storage permission
4 years ago
Gabriel Luong
9b8a3401c8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 9: Fix ui tests for the tabs settings
4 years ago
Gabriel Luong
d7a4925a5a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 8: Add a feature flag for showing the grid view in the tabs setting
4 years ago
Gabriel Luong
c95c4de162
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 7: Draw a border around the selected tab
4 years ago
Gabriel Luong
ca8cc56e32
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 6: Display the tab's favicon in the grid view
4 years ago
Gabriel Luong
8a4b3d85d4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 5: Don't draw any background when swiping to delete a tab
4 years ago
Gabriel Luong
b837358f14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 4: Formatted TabTrayView.kt
4 years ago
Gabriel Luong
d7f46fa9f5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 3: Implement a grid view layout for the tabs
...
Co-authored-by: Abhijit Valluri avalluri2@bloomberg.net
4 years ago
Gabriel Luong
ded4f5cbbb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 2: Remove unused xmlns:mozac in component_tabstray.xml
4 years ago
Gabriel Luong
88ce83d0d2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 1: Convert the CloseTabsSettingsFragment to a general TabsSettingsFragment
...
- Renames CloseTabsSettingsFragment.kt to TabsSettingsFragment.kt
- Renames close_tabs_preferences.xml to tabs_preferences.xml
- Adds preference options for the switching between the Grid and List tab views
4 years ago
Michael Comella
d7ea7c3555
[fenix] No issue: fix tests related to inline change.
...
The difficulty in mocking StrictMode.resetAfter is concerning.
I'm starting to second-guess whether or not making strict mode manager a class
was a good idea.
4 years ago
Michael Comella
d23a1b8274
[fenix] No issue: remove inline from StrictModeManager.resetAfter.
...
I believe this was a premature optimization: it's unclear that it would
actually improve performance and yet we had to add several weird
workarounds to make it work that broke encapsulation. It's also
possible it would be worse for the APK size because of excessive
inlining.
4 years ago
Mozilla L10n Automation Bot
9f2237e6f1
[fenix] Import l10n.
4 years ago
Jonathan Almeida
f4c1a915f5
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/15754 : Disable failing notification UI tests
4 years ago
Jonathan Almeida
848286b7b1
[fenix] Upgrade to Android Component 62.0.20201006190820 with breaking changes
4 years ago
Chenxia Liu
7ad5f26333
[fenix] Adding link data review request
4 years ago
Chenxia Liu
5ffe145425
[fenix] startup.timeline
4 years ago
Chenxia Liu
86db33910d
[fenix] sync, sync_items, telemetry, theme, toolbar_position,
...
tracking_protection, default_engine
4 years ago
Chenxia Liu
073321049c
[fenix] accesssibility, open_links, remote_debugging, search_suggestions,
...
show_search
4 years ago
Chenxia Liu
7f14d314cb
[fenix] search_count, search_widget, tabs_count, toolbar_position
4 years ago
Chenxia Liu
bba0353993
[fenix] has, count: open_tabs, pwa, top_sites
4 years ago
Chenxia Liu
03b5b9f4e8
[fenix] default*browser, mozilla_products
4 years ago
Chenxia Liu
83d6b8d559
[fenix] browser.search, events.total_uri_count, metrics.adjust*
4 years ago
Chenxia Liu
93a4cab155
[fenix] first_session
4 years ago
Chenxia Liu
bf68ea27c5
[fenix] user_specified_search_engine, voice_search
4 years ago
Chenxia Liu
ade609c3ac
[fenix] top_sites, tracking_protection
4 years ago
Chenxia Liu
bb3332478b
[fenix] tab, tabs_tray, toolbar_settings
4 years ago
Chenxia Liu
278ac8007d
[fenix] syenc_account, sync_auth
4 years ago
Chenxia Liu
ed317ac898
[fenix] search_suggestions, search_shortcuts, search_widget
4 years ago
Chenxia Liu
9e4dfdf37c
[fenix] private_browsing, qr_scanner
4 years ago
Chenxia Liu
71b1684c5b
[fenix] pocket, onboarding
4 years ago
Chenxia Liu
41cb9084bf
[fenix] logins, media_notification, media_state
4 years ago
Chenxia Liu
1838f130d1
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/14142 - find_in_page, history, reader_mode, tip
4 years ago
mcarare
4a56121cc4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15711 : Also add custom engines to fallback list.
4 years ago
mozilla-l10n-automation-bot
93b385ba2e
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/15738 )
4 years ago
Elise Richards
f5ff218d46
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8765 : Use shared list widget in collections ( https://github.com/mozilla-mobile/fenix/pull/15733 )
...
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
Michael Comella
8b20c2d8c2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 - post: decrement expected suppression count.
...
Running locally, I get the same error: I think that there legitimately
was an reduction in the number of StrictMode suppressions on start up.
4 years ago
Michael Comella
0934b7fe93
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 - review: add clarifying comments.
4 years ago
Michael Comella
86a44fb728
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add marker when StrictMode is suppressed.
4 years ago
Michael Comella
19904397b2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add MozillaStrictModeSuppression detekt check.
4 years ago
Michael Comella
d253b9060e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add test to prevent increasing StrictMode suppression count.
4 years ago
Michael Comella
3e9f93a0ab
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add HomeActivityTestRule.skipOnboarding.
...
This is more correct, faster, and results in less copy-paste duplication
than the current behavior:
homeScreen { }.dismissOnboarding()
Which opens settings to dismiss onboarding.
4 years ago
Michael Comella
b6609a0747
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : count StrictMode suppressions on startup.
4 years ago
Jocelyne Abi Haidar
efc846d57a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15675 : Disable Save button when editing saved login until something has been changed
...
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
4 years ago
mozilla-l10n-automation-bot
1d8006f733
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/15712 )
4 years ago
Mozilla L10n Automation Bot
ded58ad2b7
[fenix] Import l10n.
4 years ago
mcarare
8668f5a0d6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15632 : Improve checking open tabs logic to show collection button.
...
Check now considers selected tab tray mode.
4 years ago
ekager
c5a6e86f9b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15600 - Move removal of timed out sessions to immediately after restoration
4 years ago
ekager
d9aefd1ce2
[fenix] No issue: Update biometric, core, and recyclerview libraries
4 years ago
mcarare
1add1c7454
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13031 : Show size in KB for smaller downloaded files.
4 years ago
Mozilla L10n Automation Bot
c318e736f9
[fenix] Import l10n.
4 years ago
Jocelyne
cc4d4a14d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10107 : Show Today and Yesterday labels in History ( https://github.com/mozilla-mobile/fenix/pull/15415 )
4 years ago
Michael Comella
e1ffe1108f
[fenix] No issue: replace LintUnitTestRunner with detekt implementation.
...
This should be more performant and easier to maintain.
4 years ago
Jeff Boek
d81eff94bd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15593 - Reverts back to simple UUID creation without Fenix side caching
4 years ago
Jocelyne
635e49092e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15471 : Show Delete button in red in multi-select overflow menu ( https://github.com/mozilla-mobile/fenix/pull/15576 )
4 years ago
Mozilla L10n Automation Bot
482efed8de
[fenix] Import l10n.
4 years ago
Grisha Kruglov
a41022554b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15443 : Use fragment's lifecycleScope for AlertDialog actions
4 years ago
Christian Sadilek
33e49d471b
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/15555 : Set channel to Nightly explicitly for SettingsFragmentTest
4 years ago
mcarare
1589942479
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15559 : Allow tabs to stretch in landscape mode for tablets.
...
This overrides the default tabMaxWidth of 264dp to allow for tabGravity="fill".
4 years ago
Christian Sadilek
a846743af4
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15555 : Intermittent failures in SettingsFragmentTest
4 years ago
Stefan Arentz
a0c00cb3b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15537 - Be more verbose about leanplum identifiers ( https://github.com/mozilla-mobile/fenix/pull/15538 )
4 years ago
mcarare
192e5dc063
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15535 : hasOpenTabs now considers the selected tab mode in tray tab.
4 years ago
Michael Comella
af732f0748
[fenix] No issue: elaborate on Components class doc.
...
This is to clarify a misunderstanding I found in PR review.
4 years ago
Sebastian Kaspari
70dbf0d765
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass metrics to share controller" for debug test failures.
...
This reverts commit 5de145914e9fc10d3d647e6f2856c2df19dd9156.
4 years ago
Sebastian Kaspari
9b598b33d8
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass bookmark storage to controller" for debug test failures.
...
This reverts commit 9825a5d2dfb0f6d3c0235fdf0032e510c34bf20a.
4 years ago
Andrew Gaul
43778cf3cb
[fenix] Show undo snackbars with padding with static bottom toolbar
...
This specifically fixes the close tab snackbar. This commit mirrors
the logic when not using Undo from
e14bf8e791aa56ded47812018f32ee9801a5b4f9. References https://github.com/mozilla-mobile/fenix/issues/14982 .
4 years ago
ekager
1429c5ddaf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15324 - Show tab settings and recently closed items in menu when no tabs
4 years ago
ekager
8caf149ab7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15503 - Change recently closed max to 10
4 years ago
TrianguloY
98f8f3b2ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13856 - Prevent overscroll in swipe to switch tabs gesture
4 years ago
Tiger Oakes
5a3b5af7d9
[fenix] Extract locale settings initial state
4 years ago
Tiger Oakes
be11bfd5b4
[fenix] Add test for initial logins list state
4 years ago
Tiger Oakes
e4bdd355d3
[fenix] Add tests for initial collection creation state
4 years ago
Sören Hentzschel
ac1a2a708a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11561 - changed inactive heading and menu icon color in dark mode
4 years ago
Mozilla L10n Automation Bot
87ecdf8bfb
[fenix] Import l10n.
4 years ago
Tiger Oakes
b55c4af6fb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass bookmark storage to controller
4 years ago
Tiger Oakes
966e13c9aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass metrics to share controller
4 years ago
Michael Comella
a50cf27648
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : fix startup crash by using arg Context.
...
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
4 years ago
Michael Comella
53bd004f55
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : remove resetAfter & port tests to StrictModeManager.
4 years ago
Michael Comella
d0fbe70f10
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : clean up existing StrictMode test names.
4 years ago
Michael Comella
8a9472e540
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : move resetAfter into StrictModeManager.
...
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.
Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```
We're going to have to add a lint check to prevent them from doing that.
4 years ago
Michael Comella
5f8943f76c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : change StrictModeManager to class from object.
...
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
4 years ago
Christian Sadilek
76018e2fe0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14034 : Add debug preference to override AMO collection in Nightly
4 years ago
Michael Comella
9e86e369b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : comment about duplication in logic in StrictMode.
...
I had to drop a commit that addressed the issue because it was too hard
to fix.
4 years ago
Michael Comella
394465e33e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add comment to explain why we only resetAfter in certain build modes.
4 years ago
Michael Comella
c1aa8d396a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : use ac StrictMode.resetAfter rather than duplicating functionality.
4 years ago
Michael Comella
b2c01e442f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : rename to attachListenerToDisablePenaltyDeath for clarity.
4 years ago
Michael Comella
1ec45f33a2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : remove unused penaltyDialog parameter.
...
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
4 years ago
Michael Comella
3b76f2b3fc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : always enable detectNonSdkApiUsage.
...
We don't use penalty death for the VM policy so we theoretically don't
need to disable this check if penalty death is enabled.
4 years ago
Sebastian Kaspari
eca2b8ecf4
[fenix] Use "undo" implementation from Android Components.
...
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.
Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
4 years ago
Mozilla L10n Automation Bot
788b5bb21e
[fenix] Import l10n.
4 years ago
mcarare
3ede6cf544
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15310 : Add test for ActivityNotFoundException when sharing to app.
4 years ago
mcarare
9d9d283dc7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15310 : Also catch ActivityNotFoundException when sharing to app.
4 years ago
ekager
b276e9daca
[fenix] No issue: Update AC to 61.0.20200925190057
4 years ago
ekager
cf0af49d3b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12383 https://github.com/mozilla-mobile/fenix/issues/15407 https://github.com/mozilla-mobile/fenix/issues/12860 - Switch to using shared view model for session to delete on home
4 years ago
Grisha Kruglov
c348e03d0e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15434 : Don't try to display a 'signed in' snackbar in a 'headless' mode
4 years ago
Grisha Kruglov
a0189c8080
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15432 : Invoke UI updates on main thread in response to account events
4 years ago
Grisha Kruglov
5bb231cc70
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15436 : Auto-close tabs during startup on the main thread
4 years ago
Christian Sadilek
146aa075dd
[fenix] Configure M5 AMO collection for Nightly/Debug
4 years ago
mcarare
c5c3b6549d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15130 : Remove "what's new card" check in UI test.
4 years ago
mcarare
1d7b1df0e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15130 : Remove "what's new card" from onboarding screen.
4 years ago
Mozilla L10n Automation Bot
8774b36f49
[fenix] Import l10n.
4 years ago
Kate Glazko
739a3520e1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15320 : Ensure Mimetype Other PDF Shows PDF Icon
4 years ago
Elise Richards
609857c5f1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14280 , https://github.com/mozilla-mobile/fenix/issues/14743 : Remove old search fragment ( https://github.com/mozilla-mobile/fenix/pull/15169 )
...
* Remove search fragment
* Use new folder to search dialog
* Rebase and lint
* Update tests with search dialog nav directions
* Rename interactor to match naming convention. Remove old controller and point everything to the dialog controller.
4 years ago
Jonathan Almeida
2ab099b37b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15349 : Fixes SyncedTabs suggestion not clicking
4 years ago
Grisha Kruglov
bc90bd2f31
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15296 : Allow excluding bookmark subtrees when editing parent folder
...
I'm really not a fan of how title overwriting and structure processing are mangled together,
but will leave clearing that up for another day.
4 years ago
Mozilla L10n Automation Bot
fdb3d6c013
[fenix] Import l10n.
4 years ago
Sawyer Blatz
9d49be285c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14243 : Pre-land visuals for Close Tabs CFR ( https://github.com/mozilla-mobile/fenix/pull/15171 )
4 years ago
Grisha Kruglov
661a48a940
[fenix] Update breaking changes in the FxA/Sync integration
4 years ago
Jocelyne
0638e9b3d1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11800 : Hide reveal and clear password icons if the password is empty when editing a saved login ( https://github.com/mozilla-mobile/fenix/pull/15244 )
...
Co-authored-by: Jocelyne Abi Haidar <jocelyne.abihaidar@gotocme.com>
4 years ago
Sebastian Kaspari
0663cf8916
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/13270 : Do not launch into Fennec's task anymore.
...
Initially we did this to avoid a duplicated task right after the migration from Fennec. We'd end up
with the original task from Fennec and the new one from Fenix; with the Fennec task still showing
Fennec in the app switcher, but launching Fenix once selected.
Anyhow, now on Android 11 this causes the Fenix task to get duplicated. The simple fix is to not
do any of that anymore. This may re-introduce the problem with the Fennec migration, but:
* We are at 100% rollout for quite some time. There are still users migrating, but the impact
of the bug is much lower.
* The bug after the migration was only temporary. This bug here is happening every time you
launch Fenix. So I'd rather fix this than a possible inconvenience right after the migration.
4 years ago
mcarare
deafcc7387
[fenix] https://github.com/mozilla-mobile/fenix/pull/274-android-l10n : Update create account string to avoid partial translations.
4 years ago
Christian Sadilek
d12fa25350
[fenix] Configure M4 AMO collection for all builds
4 years ago
person808
2ddd7950b9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15219 - Fix tab tray handle size.
...
Also use dimens for the tab history handle.
4 years ago
aprabhakara
06036292ae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15262 : Updated margins
4 years ago
ekager
65db93b8b5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15291 - Limit current CFRs to show max one every 3 days
4 years ago
mcarare
9b953c0255
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15263 : Properly update open links in app preference.
4 years ago
ekager
5536851865
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15272 - Remove bottom margin for toolbar on enter fullscreen
4 years ago
ekager
2f7edfe924
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15121 - Ensure tabs removed while on browser select an available parent session
4 years ago
mcarare
f887985405
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15268 : Update unit tests for safe navigation to details fragment.
4 years ago
mcarare
d6f5f88deb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15268 : Use safe navigation to addon details fragments.
4 years ago
Oana Horvath
90ef2c90bf
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/14524 , https://github.com/mozilla-mobile/fenix/issues/12896 , https://github.com/mozilla-mobile/fenix/issues/13830 : re-enabled strict ETP tests after code bug fix
4 years ago
Grisha Kruglov
0b56dd58e4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15284 : Process root titles when creating new folders
...
This also simplifies how we do this. We're no longer creating instances of `DesktopFolder` class
nor creating copies of BookmarkNodes just to display root titles correctly for the 'edit folder' UI.
4 years ago
ekager
e2f534e533
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15089 - Disable recently closed in multiselect
4 years ago
ekager
231bfe6323
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15112 - Still show recently closed when history empty
4 years ago
Grisha Kruglov
4e486c0b40
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15286 : Don't crash when separators are long-touched
4 years ago
Mozilla L10n Automation Bot
3249a5e7f4
[fenix] Import l10n.
4 years ago
ekager
9763d05ef2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13934 - Make TabHistory work on PWA/Custom Tabs
4 years ago
ekager
f4406b2265
[fenix] No issue: Fixes strict mode death in debug custom tab
4 years ago
ekager
0fbfbb5516
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14982 - Show snackbars with padding with static bottom toolbar
4 years ago
ekager
abe4ccd2ea
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14458 - dismiss keyboard on fill link from clipboard
4 years ago
Mozilla L10n Automation Bot
a8ce1d6722
[fenix] Import l10n.
4 years ago
ekager
6b66dbd5cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15245 - Remove margin for toolbar on toolbar-less PWA
4 years ago
Mozilla L10n Automation Bot
ddd8d2b7fd
[fenix] Import l10n.
4 years ago
Grisha Kruglov
4f6213a2dd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2792 : Display bookmark folders at the top of the bookmarks UI
4 years ago
Grisha Kruglov
ec18031057
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15211 : Make sure bookmarks are moved to the end of folders
4 years ago
Grisha Kruglov
ba242fb3b9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15206 : Only track 'move' event if bookmark parent was changed
4 years ago
Grisha Kruglov
fa8af7dcd2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11502 : Make sure to always process root titles for parent folders during edit
...
This also switches to a simpler bookmarks query API ('getBookmark') which doesn't fetch
children. We don't need 'children' for this dialog, and so don't need to do the extra work.
4 years ago
Grisha Kruglov
f79c9733e1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13157 : Filter out folder being edited from 'select folder' dialog
4 years ago
Grisha Kruglov
412ae60537
[fenix] Rename 'visitedAddBookmark' arg to a less confusing name
4 years ago
Grisha Kruglov
2e646b696a
[fenix] Remove unused nav arg from 'select folder'
4 years ago
Mozilla L10n Automation Bot
e4bf6224f6
[fenix] Import l10n.
4 years ago