Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-07 15:20:38 +00:00
Code Issues Releases Wiki Activity
2,682 Commits 67 Branches 115 Tags 1.2 GiB
5ae8bc6f0a
Commit Graph

2301 Commits

Author SHA1 Message Date
ValentinTimisica
2e3d0e1347 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6145: Switch drawableTint to app compat version. (https://github.com/mozilla-mobile/fenix/pull/6151) 
The property android:drawableTint doesn't work on older Android devices,
so I switched to the appcompat version (app:drawableTint).
 2019-10-24 09:38:58 -07:00
Jeff Boek
e6af25acca [fenix] For https://github.com/mozilla-mobile/fenix/issues/2477 - Adjust padding to be visually consistent with the separator 2019-10-24 09:35:21 -07:00
Jeff Boek
212d63ec39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2477 - Adds accessibility setting to force enable zoom 2019-10-24 09:35:21 -07:00
Alessio Placitelli
9d544a27e8 [fenix] Pick up forUnitTest library for the Glean SDK test 2019-10-24 08:57:30 -07:00
Sebastian Kaspari
a81a60183d [fenix] Update to Mozilla Android Components 19.0.0-SNAPSHOT. 2019-10-24 08:57:30 -07:00
Sebastian Kaspari
e9d21e9799 [fenix] Use new toolbar API of AC 18.0.0. 2019-10-24 08:57:30 -07:00
Sawyer Blatz
893c08050f [fenix] No issue: Fixes string issues for l10n (https://github.com/mozilla-mobile/fenix/pull/6158) 
Issues found here: https://github.com/mozilla-l10n/android-l10n/pull/89
 2019-10-24 08:24:19 -07:00
Aaron Train
aa400955a6 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6172 - Convert waitNotNull into extension function for UI tests (https://github.com/mozilla-mobile/fenix/pull/6220) 2019-10-23 17:40:28 -04:00
MozLando
961254df94 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5332 
5332: For https://github.com/mozilla-mobile/fenix/issues/2483 https://github.com/mozilla-mobile/fenix/issues/2629: Close tab with no history on back press and return to parent if available r=ekager a=mawen7



Co-authored-by: mawen7 <mawen7@users.noreply.github.com>
 2019-10-23 18:20:36 +00:00
Severin Rudie
69406b4230 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3676: fix duplicate uri events on first load (https://github.com/mozilla-mobile/fenix/pull/6128) 2019-10-23 10:21:46 -07:00
Aaron Train
16eebc77c9 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6031 - Wrap waits with assert check; adjust timer check (https://github.com/mozilla-mobile/fenix/pull/6084) 
See https://github.com/mozilla-mobile/fenix/issues/6031

- Adjust waits with assert check
- Adjusts timer to speed things up
- Test fix and cleanup

fix: review comments

- fixed proper resource name selectors
- re-added waits for slow devices

fix: ktlint
 2019-10-23 10:55:19 -04:00
mawen7
73f5f00aeb [fenix] Close tab with no history on back press and return to parent if available 2019-10-23 12:54:28 +02:00
liuche
b2419592ad [fenix] For https://github.com/mozilla-mobile/fenix/issues/4947 - Add Fenix Beta icons. (https://github.com/mozilla-mobile/fenix/pull/6173) 2019-10-22 18:10:39 -07:00
Severin Rudie
1c34781659 [fenix] https://github.com/mozilla-mobile/fenix/issues/4596 migrate collections (https://github.com/mozilla-mobile/fenix/pull/5911) 
* For https://github.com/mozilla-mobile/fenix/issues/4596: move code from CollectionCreationComponent to CollectionCreationStore

Other than adding comments, no changes were made. The code will be updated in a following commit. This is in order to make the commit diff more readable.

* For 4596: update CollectionCreateStore to libstate

* For 4596: copied CollectionCreationUIView into CollectionCreationView

Otherwise, no code was changed. The next commit will update this code. This is in order to make the commit diff more readable.

* For 4596: update CollectionCreationView to LibState

Note that the minimal changes possible to enable migration were made.  Refactoring will happen in a later commit.

* For 4596: updated CollectionCreationTabListAdapter to work with the new View

* For 4596: updated SaveCollectionListAdapter to work with the new View

* For 4596: implemented CollectionCreationController

For now, it has an identical interface to the interactor. In a later commit several of its responsibilities will be moved around, some to the interactor and some to the reducer

* For 4596: copied over previous reducer code

No other changes were made. The code will be updated in the following commit. This is done to make changes more readable for the reviewer

* For 4596: update reducer code param names

Otherwise, no changes at this time

* For 4596: add arguments to CreateCollectionFragment in nav_graph

These will be used to replace the current CreateCollectionViewModel, which shares data between fragments in a way that doesn't fit within our architecture.

* For 4596: pass arguments to collection via transaction instead of VM

The VM will be removed in a later commit

* For 4596: update BrowserToolbarController to share state to collection via its Direction

* For 4596: removed CreateCollectionViewModel

* For 4596: test tab retrieval in CreateCollectionFragment

* For 4596: fix crashing CreateCollectionFragmentTest

* For 4596: removed classes create collection classes used by old architecture

* For 4596: collection interactor rename + kdoc

* For 4596: moved collection interactor interface

* For 4596: renamed CreateCollectionFragment

All related classes followed the pattern of CollectionCreationX

* For 4596: kdoc CollectionCreationController

There's no effective difference between these calls and their interactor equivalent, so I linked to them

* For 4596: fix bug that caused rename to not work

* For 4596: removed unused collection actions

These were unused before the LibState refactor

* For 4596: kdoc StepChanged

* For 4596: removed todos about moving logic to the reducer

saveTabsToCollection: this could be moved, but that would involve creating a new action. SaveCollectionStep should probably be refactored out, so adding this layer of indirection seemed counterproductive

handleBackPress: needs to be able to call dismiss(). The reducer doesn't (and shouldn't) be able to do that, so this needs to live here

stepBack: called by handleBackPress. See above

* For 4596: wrote tests for CollectionCreationController#stepback

* For 4596: fixed tests broken by changes to collections

* For 4596: small readability refactor for CollectionController#stepBack

No change to functionality (see tests)

* For 4596: broke apart CollectionView#update

There's probably a lot more that could be done here, but smaller changes were made to reduce scope

* For 4596: remove unnecessary todos

It looks like we don't follow the suggested pattern in this project

* For 4596: test CollectionCreationController#normalSessionSize

* For 4596: updated naming in CollectionCreationController per review
 2019-10-22 17:33:54 -07:00
Pawel Obarzanek
1949400621 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2435 Change edit icon to share icon on the book… (https://github.com/mozilla-mobile/fenix/pull/6137) 
* Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/2435 Change edit icon to share icon on the bookmark toolbar

* Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/2435 Changed raw string to string resources

* Pass bookmark arguments to share fragment

* Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/2435 add orEmpty
 2019-10-22 14:34:05 -07:00
Tiger Oakes
8f91658907 [fenix] Refactor asCamelCase to use string builder (https://github.com/mozilla-mobile/fenix/pull/6141) 2019-10-22 14:33:44 -07:00
Sebastian Kaspari
e4c7bb08d4 [fenix] Issue #36170: BaseBrowserFragment: Use new feature-prompts API. 2019-10-22 16:04:33 -04:00
Grisha Kruglov
3e5c5d9514 [fenix] Perform Fennec data migration within fennecProduction 2019-10-22 16:04:08 -04:00
Tiger Oakes
0af2e9d821 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3366 - Use one layout for edit/add bookmark (https://github.com/mozilla-mobile/fenix/pull/5900) 2019-10-21 10:06:08 -07:00
Mitchell Hentges
cf0265e3b1 [fenix] Removes versionName check from gradle (https://github.com/mozilla-mobile/fenix/pull/5934) 2019-10-21 10:03:21 -07:00
Sören Hentzschel
3bc81481c5 [fenix] for https://github.com/mozilla-mobile/fenix/issues/6008 - fix address bar layout on home fragment for RTL (https://github.com/mozilla-mobile/fenix/pull/6016) 2019-10-21 10:02:13 -07:00
Sören Hentzschel
fe2879ff45 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6011 - fixed truncated clipboard icon in RTL (https://github.com/mozilla-mobile/fenix/pull/6017) 2019-10-21 10:01:51 -07:00
isabelrios
e6e5ab6ffb [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/6004: Add UI sync integration test for Bookmarks (https://github.com/mozilla-mobile/fenix/pull/6019) 
* Fix https://github.com/mozilla-mobile/fenix/issues/6004: Add UI sync integration test for Bookmarks

* fix two typos
 2019-10-21 10:01:17 -07:00
Mihai Adrian
bb0d3150c8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1383: Fix updating description of close button on title change. (https://github.com/mozilla-mobile/fenix/pull/6020) 2019-10-21 10:00:26 -07:00
ValentinTimisica
8790a8a68e [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5030: Modified Dialog to match the others. (https://github.com/mozilla-mobile/fenix/pull/6022) 
I changed the Dialog from permissions exceptions and used AlertDialog
instead of Context.alert extension function.
 2019-10-21 09:59:04 -07:00
Mihai Branescu
4dda232d0f [fenix] For https://github.com/mozilla-mobile/fenix/issues/6063 - changed ETP blocking info title strings (https://github.com/mozilla-mobile/fenix/pull/6082) 2019-10-21 09:58:47 -07:00
Shangeeth Sivan
f274b65859 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5465: Added OnCheckListener to all checkboxes ,when there are no items checked delete button will be disabled (https://github.com/mozilla-mobile/fenix/pull/6098) 2019-10-21 09:57:29 -07:00
ValentinTimisica
8532908d51 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5323: Show a snackbar while browsing data is deleting. (https://github.com/mozilla-mobile/fenix/pull/6105) 2019-10-21 09:57:06 -07:00
Jeffrey Starke
55ed9cbe2c [fenix] Don't show fingerprinters section of the standard tracking policy UI (https://github.com/mozilla-mobile/fenix/pull/6125) 2019-10-21 09:56:46 -07:00
Sören Hentzschel
4ca4f775fb [fenix] fixed alignment of open tabs header for RTL languages (https://github.com/mozilla-mobile/fenix/pull/6138) 2019-10-21 09:53:21 -07:00
Sören Hentzschel
4c2c5c5e21 [fenix] no issue - removed unused feature flags (https://github.com/mozilla-mobile/fenix/pull/6143) 2019-10-21 09:52:01 -07:00
Richard Pappalardo
1839ce12f1 [fenix] Add verify items tests for settings menus 2019-10-21 08:24:47 -07:00
Mozilla L10n Automation Bot
8c048ac40f [fenix] Import l10n. 2019-10-19 17:40:27 +00:00
MozLando
06da598c96 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6102 https://github.com/mozilla-mobile/fenix/pull/6106 
6102: For https://github.com/mozilla-mobile/fenix/issues/6018 Re-add Search Shortcuts Button r=boek a=BranescuMihai



6106: For https://github.com/mozilla-mobile/fenix/issues/5872 & https://github.com/mozilla-mobile/fenix/issues/6075: Set TabHeader buttons to invisible instead of gone. r=boek a=mcarare

At least one button has to be invisible instead of gone to keep layout height.
Tabs overflow button kept gone to avoid empty space on view end in private mode.



Co-authored-by: Mihai Branescu <branescu.mihai2@gmail.com>
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
 2019-10-18 18:59:20 +00:00
MozLando
eefbdfc912 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6107 
6107: Fix https://github.com/mozilla-mobile/fenix/issues/3122 - Hide the "Bookmark saved" Snackbar when user closes BrowserFragment r=boek a=Mugurell

Previously the Snackbar was being inflated in the parent of this Fragment so
surviving it being closed.
Tying the Snackbar with the Fragment from which it is shown ensures it will be
effectively hidden whenever the user navigates from the Fragment.



Co-authored-by: Mugurell <mugurell@users.noreply.github.com>
 2019-10-18 18:34:49 +00:00
Tiger Oakes
1eac564f52 [fenix] Cleanup shortcut code 2019-10-18 10:57:51 -07:00
Tiger Oakes
d5c8f813d3 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5225 - Hide AuthCustomTabActivity 2019-10-18 10:56:06 -07:00
MozLando
cecf51baab [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6046 
6046: Update to Mozilla Android Components 18.0.0-SNAPSHOT. r=Baron-Severin a=pocmo

We haven't updated in a while and therefore some fixes didn't make it into Fenix (Nightly) yet.

Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
 2019-10-18 16:36:33 +00:00
Sebastian Kaspari
82d20a0c40 [fenix] Update to Mozilla Android Components 18.0.0-SNAPSHOT. 2019-10-18 17:54:05 +02:00
mcarare
18779c6f31 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5872 & https://github.com/mozilla-mobile/fenix/issues/6075: Set TabHeader buttons to invisible instead of gone. 
At least one button has to be invisible instead of gone to keep layout height.
Tabs overflow button kept gone to avoid empty space on view end in private mode.
 2019-10-18 17:00:26 +03:00
Mihai Branescu
e5aa6fed30 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6018 - Added unit tests for interactor and controller 2019-10-18 15:43:39 +03:00
mcarare
5cc2013926 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6100: Mirror ETP graphic in RTL 2019-10-18 15:24:49 +03:00
Mihai Branescu
b984591154 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6018 - Added back shortcuts button in awesomebar 
Refactored logic for adding providers, since shortcut providers should
be alone in the list, while all others can be as list
 2019-10-18 14:48:58 +03:00
Mugurell
11acd9849c [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/3122 - Hide the "Bookmark saved" Snackbar when user closes BrowserFragment 
Previously the Snackbar was being inflated in the parent of this Fragment so
surviving it being closed.
Tying the Snackbar with the Fragment from which it is shown ensures it will be
effectively hidden whenever the user navigates from the Fragment.
 2019-10-18 08:11:56 +03:00
MozLando
93bf73cbcd [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6038 
6038: ExtTest for BookmarkNode r=mcomella a=kglazko



Co-authored-by: Kate Glazko <katglazko@gmail.com>
 2019-10-17 20:39:35 +00:00
Kate Glazko
d94c0a22f9 [fenix] ExtTest for BookmarkNode 2019-10-17 12:54:03 -07:00
MozLando
a591094ca2 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6026 
6026: For https://github.com/mozilla-mobile/fenix/issues/5709: Align ETP onboarding popup implementation with original mocks r=ekager a=mcarare



Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
 2019-10-16 17:49:16 +00:00
MozLando
1cc1b164c0 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6024 
6024: For https://github.com/mozilla-mobile/fenix/issues/5749 - Update string for ETP onboarding popup r=ekager a=BranescuMihai



Co-authored-by: Mihai Branescu <branescu.mihai2@gmail.com>
 2019-10-16 00:12:52 +00:00
MozLando
a459011003 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6025 https://github.com/mozilla-mobile/fenix/pull/6032 
6025: For https://github.com/mozilla-mobile/fenix/issues/5063: Added parameter customTabSessionId into ContextMenuFeature r=ekager a=ValentinTimisica

Added parameter customTabSessionId into ContextMenuFeature in
BaseBrowserFragment in order to show the context menu in a custom tab.



6032: For https://github.com/mozilla-mobile/fenix/issues/5990: Revert sessionTokenScope to fix broken QR pairing flow r=ekager a=grigoryk

Seems like addition of sessionTokenScope is causing issues with pairing. For now, we can revert that change until the underlying issue is fixed.

For https://github.com/mozilla-mobile/fenix/issues/5990.



Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro>
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
 2019-10-15 21:31:38 +00:00
MozLando
a7c9ccbedc [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5974 
5974: Ext Test For ImageButton r=mcomella a=kglazko



Co-authored-by: Kate Glazko <katglazko@gmail.com>
 2019-10-15 19:31:47 +00:00
Grisha Kruglov
2f19a82c91 [fenix] Revert sessionScopeToken to fix broken QR pairing flow 2019-10-15 11:19:40 -07:00
mcarare
c1dc44370a [fenix] For https://github.com/mozilla-mobile/fenix/issues/5709: Align ETP onboarding popup implementation with original mocks 2019-10-15 17:07:47 +03:00
ValentinTimisica
c01d3dc000 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5063: Added parameter customTabSessionId into ContextMenuFeature 
Added parameter customTabSessionId into ContextMenuFeature in
BaseBrowserFragment in order to show the context menu in a custom tab.
 2019-10-15 16:28:42 +03:00
Mihai Branescu
71803d9859 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5749 - Update string for ETP onboarding popup 2019-10-15 15:56:59 +03:00
MozLando
d953218319 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5949 
5949: Import strings from android-l10n r=liuche a=mozilla-l10n-automation-bot

n/t

Co-authored-by: Mozilla L10n Automation Bot <release+l10n-automation-bot@mozilla.com>
 2019-10-15 03:53:27 +00:00
MozLando
e70293217c [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5775 
5775: Closes https://github.com/mozilla-mobile/fenix/issues/5233, don't display private-browsing-shortcut creation items if shortcut already exists r=NotWoods a=bswe

Closes issue https://github.com/mozilla-mobile/fenix/issues/5233:

Added doesPrivateBrowsingPinnedShortcutExist() method to the PrivateShortcutCreateManager class to check for the existence of the shortcut.  Code only works on devices with API 25 or higher, so a check for that condition was also included in the new method.

Calls to the new method were added to the SettingsFragment and HomeFragment classes to determine whether the settings menu item and the recommendation dialog should be displayed.

**Quality**: The pre-push test failed to start on my windows 10 OS, but this code has been thoroughly tested manually on simulators and physical devices.

**Tests**: This code only effects UI appearance so not sure how to test for that and no tests were written.

**Screenshots**: This code does not add anything new to the UI, it only controls whether to display existing items.

Co-authored-by: bswe <bbollenbacher@mindspring.com>
 2019-10-14 22:23:45 +00:00
Kate Glazko
9a2bb97270 [fenix] Ext Test For ImageButton 2019-10-14 13:30:39 -07:00
MozLando
48a00a9472 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5976 https://github.com/mozilla-mobile/fenix/pull/5999 
5976: No issue: Update androidx fragment Oct 11 r=boek a=ekager



5999: For https://github.com/mozilla-mobile/fenix/issues/5709: Align ETP Settings Screen implementation with original mocks r=NotWoods a=mcarare



Co-authored-by: ekager <emilykager@gmail.com>
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
 2019-10-14 19:28:43 +00:00
ekager
3978c2d797 [fenix] No issue: Remove black flash workaround 2019-10-14 11:51:01 -07:00
bswe
af12dedbf8 [fenix] Reformatting to simplify use of .any construct as suggested in review 2019-10-14 11:20:19 -07:00
bswe
92e2b65f5e [fenix] Reformatting to use .any construct as suggested in review 2019-10-14 11:20:19 -07:00
bswe
35eabc4579 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/5233: Minor modifications suggested in code review. 2019-10-14 11:20:18 -07:00
bswe
aea1af9c82 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/5233: Added call to doesPrivateBrowsingPinnedShortcutExist function to determine whether the "recommend private browing shortcut" dialog is displayed. 2019-10-14 11:20:17 -07:00
bswe
d9bbb0a486 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/5233: Added call to doesPrivateBrowsingPinnedShortcutExist function to determine whether the "add private browing shortcut" item is visible in the settings menu. 2019-10-14 11:20:17 -07:00
bswe
ba7b54708b [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/5233: Added doesPrivateBrowsingPinnedShortcutExist function to determine whether a shortcut already exists (only available in API >=25). 2019-10-14 11:07:34 -07:00
MozLando
01fb7c04c6 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5908 
5908: Closes https://github.com/mozilla-mobile/fenix/issues/5876: Removed @ObsoleteCoroutinesApi in tests r=sblatz a=shldhll


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [ ] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

Co-authored-by: shldhll <iam.shldhll@gmail.com>
 2019-10-14 16:52:22 +00:00
MozLando
8573e2e13e [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5973 
5973: For https://github.com/mozilla-mobile/fenix/issues/5898: Launch SUMO article properly for default browser r=colintheshots a=sblatz



Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
 2019-10-14 16:16:47 +00:00
mcarare
3bb7e5b662 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5709: Align ETP Settings Screen implementation with original mocks 2019-10-14 15:59:43 +03:00
Mozilla L10n Automation Bot
4d9d1b6585 [fenix] Import l10n. 2019-10-13 20:01:13 +00:00
Sawyer Blatz
43b51ff997 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5898: Launch SUMO article properly for default browser 2019-10-11 14:40:08 -07:00
MozLando
a05afed1dc [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5956 
5956: For https://github.com/mozilla-mobile/fenix/issues/5947 - Fix engineView NullPointerException r=csadilek a=ekager



Co-authored-by: ekager <emilykager@gmail.com>
 2019-10-11 21:08:09 +00:00
MozLando
cd489f765a [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5933 
5933: Removes legacy nightly automation r=johanlorenzo a=mitchhentges



Co-authored-by: Mitchell Hentges <mhentges@mozilla.com>
 2019-10-11 18:28:31 +00:00
MozLando
df858f2f3b [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5507 https://github.com/mozilla-mobile/fenix/pull/5846 
5507: For https://github.com/mozilla-mobile/fenix/issues/1383 Added tab title to close button content description r=ekager a=mcarare


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

5846: For https://github.com/mozilla-mobile/fenix/issues/3604 Snackbar messages for closing tabs use closed instead of deleted r=sblatz a=mcarare


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
 2019-10-11 16:28:36 +00:00
ekager
43b16718af [fenix] For https://github.com/mozilla-mobile/fenix/issues/5947 - Fix engineView NullPointerException 2019-10-11 09:03:24 -07:00
MozLando
66e7638fb7 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5633 
5633: Add fxa/sync integration tests r=csadilek a=isabelrios

 Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [-] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [-] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

This PR tries to add new tests, sync integration tests, to check the sync process Desktop<->Fenix, first for Bookmarks and in the future for more.

Co-authored-by: Isabel Rios <isabelrios@mackbookirios.home>
Co-authored-by: isabelrios <isabelrios@gmail.com>
 2019-10-11 14:43:39 +00:00
MozLando
ffa56e994f [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5882 
5882: For https://github.com/mozilla-mobile/fenix/issues/5873 Added on/off indicator for delete browsing data on exit pref r=sblatz a=mcarare


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
 2019-10-11 13:22:33 +00:00
Mihai Adrian
6875fa017a [fenix] For https://github.com/mozilla-mobile/fenix/issues/2570: Hide 3-dots menu for all library items when in select mode (https://github.com/mozilla-mobile/fenix/pull/5699) 
Removed items from RecyclerView cache to allow setting the new visibility
Disabled hidden buttons, otherwise they could still be clicked
 2019-10-10 23:02:22 -07:00
Mozilla L10n Automation Bot
5e6b47c19b [fenix] Import l10n. 2019-10-10 22:54:54 -07:00
Sawyer Blatz
3cd8b5cf30 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5094: Adds telemetry for show search shortcuts 2019-10-10 22:52:41 -07:00
shldhll
9e04abdaee [fenix] Added required coroutines in tests. Closes https://github.com/mozilla-mobile/fenix/issues/5876 2019-10-11 00:01:07 +05:30
Sawyer Blatz
2bafd3ea24 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5898: Default browser toggle sends user to SUMO on Android 5&6 (https://github.com/mozilla-mobile/fenix/pull/5918) 2019-10-10 11:16:21 -07:00
Mitchell Hentges
4bd3882edb [fenix] Removes legacy nightly automation 2019-10-10 11:13:23 -07:00
Mugurell
68a70eaa77 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3584 - Check if menu is open before showing a new one (https://github.com/mozilla-mobile/fenix/pull/5674) 
Could have implemented this check (if menu is showing) inside the show() method
of BrowserMenu but this would mean the client (us) would go to the process of
building a new menu and then trying to have it displayed only for this to be
ignored by BrowserMenu in a somewhat opaque way.
Having this check done as soon as possible offers us full control and avoids
the unnecessary steps for building an already shown menu.
 2019-10-10 06:37:47 -07:00
shldhll
1b36368c82 [fenix] Removed ObsoleteCoroutinesApi from share tests. Closes https://github.com/mozilla-mobile/fenix/issues/5876 2019-10-10 06:40:20 +05:30
shldhll
d3ddb95701 [fenix] Fixed imports. Closes https://github.com/mozilla-mobile/fenix/issues/5876 2019-10-10 06:27:14 +05:30
Grisha Kruglov
4361ea23c7 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5913: Add new sessionToken scope 2019-10-09 17:44:41 -07:00
shldhll
57a6bf6c7b [fenix] Optimized imports. Closes https://github.com/mozilla-mobile/fenix/issues/5876 2019-10-10 04:17:43 +05:30
shldhll
4e37ba2bcf [fenix] Removed ObsoleteCoroutinesApi in tests. Closes https://github.com/mozilla-mobile/fenix/issues/5876 2019-10-10 04:04:51 +05:30
Jeff Boek
d09494613a [fenix] For https://github.com/mozilla-mobile/fenix/issues/373 - Integrate leanplum-fcm 2019-10-09 14:43:48 -07:00
Christian Sadilek
c853454896 [fenix] For https://github.com/mozilla-mobile/fenix/issues/778: Follow-up to fix find in page 2019-10-09 17:14:14 -04:00
Emily Kager
b36c9c67dd [fenix] For https://github.com/mozilla-mobile/fenix/issues/1901 - Get rid of black flash when leaving GV Engine 2019-10-09 11:02:21 -07:00
Tiger Oakes
90d9e14b9c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/394 - Trusted Web Activities (https://github.com/mozilla-mobile/fenix/pull/5391) 2019-10-09 09:17:49 -07:00
Ahmed I. Khalil
b3ada93697 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5852 - Use createAddedTestFragments in tests. 2019-10-09 08:51:52 -07:00
mcarare
02d018ad89 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5873 Added on/off indicator for delete browsing data on exit pref 2019-10-09 11:55:37 +03:00
Michael Droettboom
eefa0e927f [fenix] Add glinter overrides 2019-10-08 21:40:20 -07:00
Mozilla L10n Automation Bot
fd73db11e4 [fenix] Import l10n. 2019-10-08 21:38:24 -07:00
Roger Yang
03534c00c2 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5847: Use IO thread when submitting crash report 2019-10-08 18:46:14 -07:00
Tiger Oakes
590eff81c6 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/778 - Progressive Web Apps! (https://github.com/mozilla-mobile/fenix/pull/4914) 2019-10-08 16:50:15 -07:00
Sawyer Blatz
129951e3a9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5534: Temporarily disables find in page test 2019-10-08 16:17:38 -07:00
Tiger Oakes
30af9d17cd [fenix] Remove @ObsoleteCoroutinesApi from TestCore 2019-10-08 15:49:40 -07:00
Severin Rudie
1acb0b6ddc [fenix] For 4780: add DefaultBrowsingModeManager tests 2019-10-08 15:13:17 -07:00
Severin Rudie
1d9b41c167 [fenix] For 4780: remove Settings#usePrivateMode and tests 2019-10-08 15:13:17 -07:00
Severin Rudie
691c47d576 [fenix] For 4780: ThemeManager now sends an intent before recreating 
Updating themes recreates the activity, so if we aren't persisting 'usePrivateMode', we need to pass it to the new instance
 2019-10-08 15:13:17 -07:00
Severin Rudie
17e9a4e5c9 [fenix] For 4780: rename 'setPrivateModeIfNecessary' 2019-10-08 15:13:17 -07:00
Severin Rudie
3128209d65 [fenix] For 4780: update HomeActivity to maintain private mode in memory 
As an added bonus, this makes the temporal coupling between `setPrivateModeIfNecessary` and `setupThemeAndBrowsingMode` explicit.  They previously would have broken if called in reverse order, now it will fail to compile.
 2019-10-08 15:13:17 -07:00
Severin Rudie
15cd1c5d9a [fenix] For https://github.com/mozilla-mobile/fenix/issues/4780: remove previous fix for leaking private mode status 
This didn't function when 'open links in a private tab' was set.  Rather than adding another sketchy fix for the edge case, following commits will change `usePrivateMode` to be maintained in memory, instead of in Settings.
 2019-10-08 15:13:17 -07:00
Aaron Train
c5195c9a46 [fenix] No issue: fixes refreshTest (https://github.com/mozilla-mobile/fenix/pull/5792) 2019-10-08 12:20:04 -04:00
Sawyer Blatz
f0751362f4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4190: Removes waterfall animation from awesomebar 2019-10-08 09:14:23 -07:00
Sawyer Blatz
5c43aa6a06 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5787: Fixes shortcuts asking to launch private alias (https://github.com/mozilla-mobile/fenix/pull/5825) 2019-10-08 08:40:28 -07:00
mcarare
57169406de [fenix] For https://github.com/mozilla-mobile/fenix/issues/3604 Snackbar messages for closing tabs use closed instead of deleted 2019-10-08 17:06:02 +03:00
Mihai Adrian
909467184c [fenix] For https://github.com/mozilla-mobile/fenix/issues/5798: Fix info icon pixelation (https://github.com/mozilla-mobile/fenix/pull/5841) 2019-10-08 09:30:32 -04:00
isabelrios
785c89743a [fenix] fixing more reviewers comments 2019-10-08 09:56:29 +02:00
isabelrios
67661747f3 [fenix] fixing reviewers comments 
improve writing email and password in file
 2019-10-08 09:56:29 +02:00
isabelrios
a161afd41e [fenix] Fix TC error and run only ui tests 2019-10-08 09:56:29 +02:00
Isabel Rios
339524226a [fenix] Add fxa/sync integration tests 
fixing Jenkins path to tests and clean tests

commenting future tests and adding doc with info about the tests
 2019-10-08 09:56:29 +02:00
Grisha Kruglov
6e6d2ec9c6 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1022: Auto-publication workflow for android-component 
This patch enabled support for an auto-publication workflow for android-components.

It automates a common pattern seen in local development:

Old way:
- after every change in a-c, publish it locally with a unique version (bumping it manually)
- manually modify Fenix to consume a custom version of a-c from a mavenLocal repository

New way:
- set a flag in fenix's local.properties to enable auto-publication
- run Fenix builds after making changes to a-c. Changes in a-c will be automatically picked up.

Note that no changes are necessary to any Fenix files other than a single flag in local.properties.
Manually bumping android-components version is also not necessary.
 2019-10-07 14:13:33 -07:00
Vipul Asri
a02d73ad4b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5573: fix radio-button spacing in settings 2019-10-07 13:07:53 -07:00
Tiger Oakes
c563798ffe [fenix] Use the new fragment constructor 2019-10-07 11:07:48 -07:00
sv-ohorvath
92ac8a2042 [fenix] Boomkarks UI tests 
Added a comment to the clear all bookmarks method
 2019-10-07 10:45:04 -07:00
Michael Droettboom
1687b09ba0 [fenix] Update bug numbers to URLs 2019-10-07 10:44:11 -07:00
Denys M
55f265945f [fenix] For https://github.com/mozilla-mobile/fenix/issues/3563. Use ListAdapter for App Share list. 2019-10-07 10:41:48 -07:00
Denys M
a179403303 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3563. Use ListAdapter for Bookmark folder selection list. 2019-10-07 10:40:55 -07:00
Madalin Valceleanu
5b82099137 [fenix] Fix the incognito icon looks out of place/misaligned 2019-10-07 10:15:11 -07:00
ekager
d82d16c98c [fenix] For https://github.com/mozilla-mobile/fenix/issues/3846 - Pass in updated session icon to tabs 2019-10-07 09:38:43 -07:00
Tiger Oakes
5987f316a7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5213 - Use support library attributes 2019-10-06 16:17:00 -07:00
Prat T
d5487d6510 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5351 - listen to onIconChanged in HomeFragment 2019-10-06 10:41:34 -07:00
Prat T
30848fa66c [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5351 - use session icon in tab view on home 2019-10-06 10:41:34 -07:00
Emily Kager
ba3359053a [fenix] For https://github.com/mozilla-mobile/fenix/issues/5651 - Set up Standard vs Strict Tracking Protection Experiment 2019-10-05 10:14:09 -07:00
Sawyer Blatz
c95cc76dee [fenix] For https://github.com/mozilla-mobile/fenix/issues/1620: Hide search results when they match URL 2019-10-04 14:05:55 -07:00
mcarare
113af874ea [fenix] For https://github.com/mozilla-mobile/fenix/issues/5784: Fix hiding default browser preference in sdk<=23 2019-10-04 12:41:12 -07:00
Colin Lee
a925cc246d [fenix] For https://github.com/mozilla-mobile/fenix/issues/5599: Remove dependency on fetch_httpurlconnection (https://github.com/mozilla-mobile/fenix/pull/5716) 
* For https://github.com/mozilla-mobile/fenix/issues/5599: Remove dependency on fetch_httpurlconnection

* For https://github.com/mozilla-mobile/fenix/issues/5599: Switch Glean to GeckoViewFetchClient

* Use existing Gecko client for Glean
 2019-10-04 12:28:23 -05:00
Emily Kager
d008018d31 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5442 - Show Delete Browsing Data on Quit option in home menu 2019-10-04 09:26:59 -07:00
Sawyer Blatz
5581b61e60 [fenix] No issue: fixes master (https://github.com/mozilla-mobile/fenix/pull/5777) 2019-10-03 14:42:56 -07:00
Sawyer Blatz
dee2e653dd [fenix] For https://github.com/mozilla-mobile/fenix/issues/514 & https://github.com/mozilla-mobile/fenix/issues/5742: Updates "launch links in private tab" functionality (https://github.com/mozilla-mobile/fenix/pull/5721) 
* For https://github.com/mozilla-mobile/fenix/issues/514 & https://github.com/mozilla-mobile/fenix/issues/5742: Updates "launch links in private tab" functionality

* Fixes comments
 2019-10-03 12:43:33 -07:00
Madalin Valceleanu
320bfabca6 [fenix] Fix too much space under the address bar 2019-10-03 11:30:03 -07:00
Christian Sadilek
edd9e49e01 [fenix] Upgrade to Mozilla Android Components 16.0.0-SNAPSHOT 2019-10-03 11:07:26 -07:00
Severin Rudie
e8aecbb458 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4780 switch off private mode (https://github.com/mozilla-mobile/fenix/pull/5614) 
* Do not launch in Private Mode

When the app launches do not launch in Private Mode in order to prevent usage leaks to other users of the device.

* Issue https://github.com/mozilla-mobile/fenix/issues/4780: add comments to use private mode

* For https://github.com/mozilla-mobile/fenix/issues/4780: write tests for clear private mode on create app

* For https://github.com/mozilla-mobile/fenix/issues/4780: clear private mode when privacy notification is removed
 2019-10-03 10:23:13 -07:00
Sawyer Blatz
d9881d8211 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5094: Adds telemetry for suggestion toggles (https://github.com/mozilla-mobile/fenix/pull/5704) 2019-10-03 10:03:14 -07:00
Sawyer Blatz
f4d0b1043b [fenix] For https://github.com/mozilla-mobile/fenix/issues/5742: Adds strings (https://github.com/mozilla-mobile/fenix/pull/5743) 2019-10-03 09:32:50 -07:00
Sawyer Blatz
e3d58b1676 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5567: Removes search shortcuts button (https://github.com/mozilla-mobile/fenix/pull/5739) 
* For https://github.com/mozilla-mobile/fenix/issues/5567: Removes search shortcut button

* No issue: Simplifies logic for displaying shortcuts
 2019-10-03 08:53:16 -07:00
Richard Pappalardo
ad8e2d1d2f [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5758 - Increase UI test wait time (https://github.com/mozilla-mobile/fenix/pull/5759) 2019-10-03 07:54:10 -07:00
Sawyer Blatz
37254bd908 [fenix] No issue: Updates naming of launch links privately var (https://github.com/mozilla-mobile/fenix/pull/5701) 
The previous name was pretty confusing
 2019-10-02 12:11:21 -07:00
Sawyer Blatz
1b6eb35082 [fenix] No issue: Removes feature flags for delete data (https://github.com/mozilla-mobile/fenix/pull/5738) 2019-10-02 10:43:37 -07:00
Sawyer Blatz
ced9d7f9f4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5712: Updates text color for fill link from clipboard 2019-10-01 16:29:39 -07:00
Emily Kager
b87e6d8267 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3487 - Add back open image in new tab 2019-10-01 12:45:09 -07:00
Michael Droettboom
4cd834ef2a [fenix] 1585250: Initialize metrics off of the main thread 2019-10-01 10:29:54 -07:00
Sawyer Blatz
08ab9e8d47 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5672: Fixes broken send tab link 2019-09-30 16:13:40 -07:00
Axel Hecht
71b89245d7 [fenix] Import strings from android-l10n 
State: mozilla-l10n/android-l10n@10559d774c
 2019-09-30 16:10:08 -07:00
Sawyer Blatz
bc4e241dc6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5681: Sets OPEN_TO_BROWSER false when using new tab shortcut 2019-09-30 14:56:16 -07:00
ekager
4d5fdffdb7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5534 - Make FIP Robot Wait for Text Changes 2019-09-30 13:17:29 -07:00
Emily Kager
1aa1291d0a [fenix] For https://github.com/mozilla-mobile/fenix/issues/2078 - Filter Out Self in Share Sheet (https://github.com/mozilla-mobile/fenix/pull/5641) 2019-09-30 12:43:47 -07:00
Sawyer Blatz
17e0c7a2f2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5679: Hides autoplay behind feature flag (https://github.com/mozilla-mobile/fenix/pull/5685) 2019-09-30 12:01:04 -07:00
ekager
1196a64989 [fenix] Update BackgroundServicesTest, Suppress Complex Method 2019-09-30 10:33:56 -07:00
Grisha Kruglov
8970474e62 [fenix] FxA WebChannels integration 
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes https://github.com/mozilla-mobile/fenix/issues/4971)

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2019-09-30 10:33:56 -07:00
Chenxia Liu
774bf91112 [fenix] For https://github.com/mozilla-mobile/fenix/issues/235 - Add Glean crash count + docs. 2019-09-30 08:32:33 -07:00
Sawyer Blatz
f8e50b6fd0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5656: Fixes nightly major version number crash 2019-09-27 15:06:57 -07:00
Sawyer Blatz
04db9191f2 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5653: Removes crash with null campaign 2019-09-27 15:01:00 -07:00
mcarare
d182550fbc [fenix] For https://github.com/mozilla-mobile/fenix/issues/1071 Added Desktop Mode icon 2019-09-27 09:47:10 -07:00
Sawyer Blatz
a578ad534b [fenix] For https://github.com/mozilla-mobile/fenix/issues/4474: Adds tests and fixes issues 2019-09-27 08:59:05 -07:00
Tiger Oakes
e3d7c77c2f [fenix] No issue: Move signedIn tracking to BookmarksSharedViewModel (https://github.com/mozilla-mobile/fenix/pull/4755) 2019-09-27 08:57:38 -07:00
Sawyer Blatz
a95d6d58d0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1298: Adds adjustCampaignId to core ping (https://github.com/mozilla-mobile/fenix/pull/5579) 2019-09-27 08:56:33 -07:00
Sawyer Blatz
1519dbf668 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5197: Adds telemetry for media notification (https://github.com/mozilla-mobile/fenix/pull/5520) 2019-09-27 08:02:29 -07:00
Tiger Oakes
5a5913265f [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4711 - Extract VoiceSearchActivity (https://github.com/mozilla-mobile/fenix/pull/5502) 2019-09-27 07:54:29 -07:00
Emily Kager
bb48b2d28f [fenix] No issue: Update navigation library 2019-09-26 17:01:13 -07:00
Sawyer Blatz
ad743e6028 [fenix] No issue: Updates fact mapping to use enums 2019-09-26 17:00:51 -07:00
Emily Kager
3f59746bdd [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5624 - Fix crash on preference change listener 2019-09-26 16:56:54 -07:00
Mihai Adrian
04b58326e9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4991:Ensured deleteSelectedBookmarks deletes all selected bookmarks (https://github.com/mozilla-mobile/fenix/pull/5559) 
Moved the deletion to a CoroutineScope(IO) to decouple from fragment lifecycle
Used local val tempStorage to keep reference to bookmarkStorage of outside class
Ran deletions with awaitAll to avoid concurrency issues on storage
 2019-09-26 16:52:59 -07:00
Severin Rudie
fe159a657e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4513: fixes bookmark tests broken by loading change 
Note that BookmarkFragmentStoreTest changes preserve existing behavior, which in many cases is more expansive than the test name implies
 2019-09-26 16:29:14 -07:00
Severin Rudie
319ebf93e4 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4513: adds tests for bookmark loading state 2019-09-26 16:29:14 -07:00
Severin Rudie
b3c31751f5 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4513: show progress bar when loading bookmarks 2019-09-26 16:29:14 -07:00
Severin Rudie
e7ad50b4fe [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4513: added isLoading to bookmark state 
This was added to the state object as a top level param because it could reasonably coexist with any value of `tree` or `mode`. Even if we don't now, we may someday want to display a loading indicator while also showing cached bookmarks.

For now, we set isLoading to false whenever we receive any bookmarks
 2019-09-26 16:29:14 -07:00
Severin Rudie
a2f8c14f03 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4513: add ProgressBar to bookmark component layout 2019-09-26 16:29:14 -07:00
Severin Rudie
e2b3b1bb6f [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4513: fix mismatched bookmark listener lifecycles 
The mismatch here was creating potentially inconsistent states. When first put into a CREATED or STARTED state, the listener would not be active, however after going through onResume it would then stay active until destroyed.

We should only be navigating to bookmarks when in a RESUMED state, so this change should be safe. I tried it a few times to verify. But I've been wrong before!
 2019-09-26 16:29:14 -07:00
Colin Lee
28d64cdd9e [fenix] For https://github.com/mozilla-mobile/fenix/issues/2754 Add tab cards to share sheet (https://github.com/mozilla-mobile/fenix/pull/5493) 
* For https://github.com/mozilla-mobile/fenix/issues/2754 Add tab cards to share sheet

* For https://github.com/mozilla-mobile/fenix/issues/2754: Fix background near rounded corners and ShareButtonAppearanceTest

* Add license to share_tab_item
 2019-09-26 14:25:34 -07:00
Christian Sadilek
462e4c6201 [fenix] Upgrade to A-C 15.0.0-SNAPSHOT (incl. required changes) (https://github.com/mozilla-mobile/fenix/pull/5578) 
* Upgrade to Mozilla Android components 15.0.0-SNAPSHOT

* Update findinpage integration to use browser-state

* Use new UseCases APIs after download migration.
 2019-09-26 12:50:50 -07:00
Mugurell
a87ab2275c [fenix] For 5092 - Show a Snackbar with retry option if sharing to devices fails (https://github.com/mozilla-mobile/fenix/pull/5158) 
* For https://github.com/mozilla-mobile/fenix/issues/5092 - Show a Snackbar with retry option if sharing to devices fails

ShareController will contain all the business logic for checking the result
status of the `share to device` operations. When this fails it will show a
snackbar which also offer the possibility to retry the just failed operation.
To allow this even in the event the user has closed the share fragment we'll
use a GlobalScope's coroutine.
Refactored out the TabsSharedCallback from ShareFragment because otherwise we
would have neede to sent through that the just failed operation. After the
refactor the ShareController is solely responsable for showing the right
snackbar and handling the retry actions.

* For https://github.com/mozilla-mobile/fenix/issues/5092 - Refactor ShareControllerTest

* For https://github.com/mozilla-mobile/fenix/issues/5092: Adds color theming of snackbars
 2019-09-26 12:30:28 -07:00
Yeon Taek Jeong
59c6b7725e [fenix] No issue: Update long-press shortcut strings (https://github.com/mozilla-mobile/fenix/pull/5284) 
* No issue: Update long-press shortcut strings

* Updates identifiers
 2019-09-26 11:57:37 -07:00
ekager
3783f94347 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2874, https://github.com/mozilla-mobile/fenix/issues/5375, https://github.com/mozilla-mobile/fenix/issues/5131 - submitList workaround for Android 5 + 6 2019-09-25 19:59:07 -07:00
Agi Sferro
4d975044c3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5529: Enable about:config in geckoNightly. 2019-09-25 16:17:09 -07:00
ekager
2a99e9c69e [fenix] For https://github.com/mozilla-mobile/fenix/issues/5312 - Send ETP Strict/Standard event 2019-09-25 15:23:30 -07:00
ekager
a5de81d260 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5568 - Don't pass in Session for QuickActionSheetController 2019-09-25 13:33:38 -07:00
Emily Kager
0097d33c9a [fenix] For https://github.com/mozilla-mobile/fenix/issues/5281 - Use TrackerLog for reporting ETP categories (https://github.com/mozilla-mobile/fenix/pull/5556) 2019-09-25 10:48:06 -07:00
Sawyer Blatz
da4b731d0d [fenix] For https://github.com/mozilla-mobile/fenix/issues/561: Fix stutter of search icon & text when animating 2019-09-25 10:06:38 -07:00
Sawyer Blatz
b848e96b53 [fenix] For https://github.com/mozilla-mobile/fenix/issues/561: Fix linting issue 2019-09-25 10:06:38 -07:00
Jeff Boek
cbce90f644 [fenix] For https://github.com/mozilla-mobile/fenix/issues/561 - Fixes snackbar placement on homeview 2019-09-25 10:06:38 -07:00
Jeff Boek
5c9fc79082 [fenix] For https://github.com/mozilla-mobile/fenix/issues/561 - Fixes visual inconsistencies with the search bar 2019-09-25 10:06:38 -07:00
Jeff Boek
36ae60510f [fenix] For https://github.com/mozilla-mobile/fenix/issues/561 - Adds shadow/highlightto the bottom bar 2019-09-25 10:06:38 -07:00
Jeff Boek
984977d7ac [fenix] For https://github.com/mozilla-mobile/fenix/issues/561 - Wires up add tab button inside the bottom bar 2019-09-25 10:06:38 -07:00
Jeff Boek
a7f90a5cdf [fenix] For https://github.com/mozilla-mobile/fenix/issues/561 - Adds add tab and menu button to bottom bar 
- Adds space between wordmark and session control component
 2019-09-25 10:06:38 -07:00
Jeff Boek
d44abbcf93 [fenix] For https://github.com/mozilla-mobile/fenix/issues/561 - Removes the toolbar from the home screen 
- Removes the menu button
- Fixes motionlayout animation with the wordmark/private browsing button
 2019-09-25 10:06:38 -07:00
Axel Hecht
12847eff30 [fenix] Import strings from android-l10n 
State: mozilla-l10n/android-l10n@97355ffcdc
 2019-09-25 09:02:42 -07:00
mcarare
4dec0aba35 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1383 Added tab title to close button content description 2019-09-25 10:34:02 +03:00
Jeff Boek
156d732519 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5552 - Temporary fix for startup crash on es locales 2019-09-24 19:21:47 -07:00
Sawyer Blatz
6b03a6e1f9 [fenix] No issue: Fixes GleanMetricsService nits & broken UI test (https://github.com/mozilla-mobile/fenix/pull/5539) 
* No issue: Fixes GleanMetricsService nits

* No issue: fixes broken UI test
 2019-09-24 16:12:09 -07:00
Alessio Placitelli
819e8d4ebb [fenix] Add basic test coverage for Glean metrics in Fenix 
This introduces test coverage, using the Glean SDK
testing API, for the metrics that are set at startup
by Fenix in the GleanMetricsService.

This additional adds a basic test for the translation
of the `app_opened` event.
 2019-09-24 12:33:14 -07:00
Alessio Placitelli
c43b478447 [fenix] Add the workmanager dependency to enable testing with Glean 2019-09-24 12:33:14 -07:00
Johan Lorenzo
081d9ee296 [fenix] taskgraph: Speed up gradle calls 2019-09-24 11:05:22 -07:00
Emily Kager
37a8bd2c89 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2765 - Run places maintenance daily (https://github.com/mozilla-mobile/fenix/pull/5466) 2019-09-24 10:50:11 -07:00
Mihai Adrian
4f159819e2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5356 Improves private browsing "common myths" link accessibility (https://github.com/mozilla-mobile/fenix/pull/5479) 
Added separate TextView for link text
Used UnderlineSpan to show text as link
Split string private_browsing_placeholder, one for each TextView
Set clickListener on TextView so it can be accessed via Talkback
 2019-09-24 10:46:34 -07:00
Tiger Oakes
778d8285c5 [fenix] Only use Context.settings() function (not getter) (https://github.com/mozilla-mobile/fenix/pull/5335) 
Remove unused String extensions
 2019-09-24 10:33:46 -07:00
Tiger Oakes
d603b06a5a [fenix] Extract UriOpened observer from HomeActivity 2019-09-24 09:37:24 -07:00
Tiger Oakes
e823891c6b [fenix] Move BookmarkNode extensions to helper class (https://github.com/mozilla-mobile/fenix/pull/4752) 2019-09-24 09:17:29 -07:00
Mihai Adrian
c2c758376b [fenix] Forhttps://github.com/mozilla-mobile/fenix/issues/5468 Changed info source for url clipboard copy from view to session (https://github.com/mozilla-mobile/fenix/pull/5514) 2019-09-24 07:56:59 -07:00
Axel Hecht
73a046f597 [fenix] Import strings from android-l10n (https://github.com/mozilla-mobile/fenix/pull/5482) 
State: mozilla-l10n/android-l10n@d10506f569
 2019-09-23 19:53:57 -07:00
Jonathan Almeida
3c3c903fce [fenix] For https://github.com/mozilla-mobile/fenix/issues/5406: Ignore intermittent failing test temporarily 2019-09-23 14:23:21 -07:00
Tiger Oakes
cabac8daca [fenix] No issue: Extract home fragment mode (https://github.com/mozilla-mobile/fenix/pull/5343) 2019-09-23 09:33:55 -07:00
Nicholas
0c640444ec [fenix] For https://github.com/mozilla-mobile/fenix/issues/5474 - Adapt Autoplay icon to theme 2019-09-23 08:56:09 -07:00
Emily Kager
937b18c4ca [fenix] For https://github.com/mozilla-mobile/fenix/issues/5312 - Add Telemetry for Tracking Protection 2019-09-23 08:29:45 -07:00
Richard Pappalardo
867b6485ee [fenix] Move UI tests to x86 devices on Firebase (https://github.com/mozilla-mobile/fenix/pull/5463) 2019-09-22 19:19:10 -07:00
Christian Sadilek
c683e1616a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5444: IntentReceiverActivity: Add tests for intent processing 2019-09-20 19:44:05 -04:00
Sawyer Blatz
4a7df7f3b7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5460: Fixes styling of fill link from clipboard (https://github.com/mozilla-mobile/fenix/pull/5464) 2019-09-20 15:29:16 -07:00
Sawyer Blatz
746016e560 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5197: Adds telemetry for media controls (https://github.com/mozilla-mobile/fenix/pull/5266) 2019-09-20 14:49:27 -07:00
mcarare
5439e2d549 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5383 Refactored ETP layout to keep appearance for larger font size. 
Added paddingTop to layout to maintain similar space above title.
Added image's bottom colour as background color to fill space below image.
Refactored TextViews alignment to chain.
Changed guideline to percent instead of dp for wider screens including tablets.
 2019-09-20 14:01:30 -07:00
Tiger Oakes
139b4514f3 [fenix] Move settings classes to packages 2019-09-20 12:36:15 -07:00
Tiger Oakes
e4e9a44e29 [fenix] For https://github.com/mozilla-mobile/fenix/issues/778 - Rename CustomTabActivity 2019-09-20 12:35:12 -07:00
Tiger Oakes
222adb3656 [fenix] For https://github.com/mozilla-mobile/fenix/issues/394, https://github.com/mozilla-mobile/fenix/issues/778 - Add hide toolbar feature 
And also add CustomTabsServiceStore
 2019-09-20 12:34:49 -07:00
ekager
14aab129d6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5448 - Reload custom tab session when TP is toggled 2019-09-20 12:30:02 -07:00
Michael Droettboom
5a9020df8b [fenix] 1581556: Initialize Glean on the main thread 2019-09-20 12:29:40 -07:00
mihai-adrian
a0ee433397 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5141 Changed "learn more" link to be accessible to Talkback users 2019-09-20 12:29:02 -07:00
Tiger Oakes
5919175a66 [fenix] Extract and test crash reporter code 2019-09-20 11:04:11 -07:00
ekager
d035941a64 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5421 - Make share dialog scrim dismiss fragment 2019-09-20 09:52:39 -07:00
mcarare
d07712148e [fenix] For https://github.com/mozilla-mobile/fenix/issues/4526 Prevent automatic theme summary being cutoff with long text 2019-09-20 09:20:57 -07:00
Dennis Schubert
ebee89cc0f [fenix] No bug - Add WebCompat feature. 2019-09-20 08:33:48 -07:00
Tiger Oakes
35f3c30032 [fenix] Add note about lazy in FeatureFlags 2019-09-20 08:33:29 -07:00
Sawyer Blatz
a18a9af1c7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5396: Adds "always launch in private mode" to settings 2019-09-20 08:33:07 -07:00
Sawyer Blatz
d95e439bab [fenix] Reverts https://github.com/mozilla-mobile/fenix/issues/1151: Removes unused Flipper library 2019-09-20 08:05:14 -07:00
Emily Kager
6b99d7714b [fenix] No issue: Make Shortcut dialog buttons match other dialogs 2019-09-20 08:04:55 -07:00
Mihai Adrian
dfc03d4580 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3731 Improved UX for opening tabs from a Collection (https://github.com/mozilla-mobile/fenix/pull/5427) 
* For https://github.com/mozilla-mobile/fenix/issues/3731 Changed order of items for a collection's overflow menu

* For https://github.com/mozilla-mobile/fenix/issues/3731 Changed the order tabs open to keep same order from collections
 2019-09-20 06:41:04 -07:00
Tiger Oakes
f7983c0384 [fenix] Add tryGetHostFromUrl and update ExceptionDomains 2019-09-19 22:40:35 -04:00
Colin Lee
09fa635075 [fenix] For https://github.com/mozilla-mobile/fenix/issues/255: Toggle Media Autoplay 2019-09-19 15:13:04 -07:00
Sawyer Blatz
3c61270af5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1744: Adds tests for clipboard 2019-09-19 08:24:27 -07:00
Sawyer Blatz
c855e80043 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4155: Adds paste & go for search terms 2019-09-19 08:24:27 -07:00
Sawyer Blatz
85410f47fc [fenix] For https://github.com/mozilla-mobile/fenix/issues/1744: Adds clipboard provider to search engine screen 2019-09-19 08:24:27 -07:00
Tiger Oakes
b01480575b [fenix] Use enum to simplify delete on quit code 2019-09-18 20:20:08 -07:00
Jonathan Almeida
8d8adae0f1 [fenix] No issue: Add Digital Asset Links token for TWAs 2019-09-18 20:19:47 -07:00
Tiger Oakes
03d1034a3d [fenix] For https://github.com/mozilla-mobile/fenix/issues/3440 - Reduce HomeFragment require calls 2019-09-18 17:25:44 -07:00
Jeff Boek
5ecd6a1a9a [fenix] For https://github.com/mozilla-mobile/fenix/issues/3077 - Replaces connect another device dialog with a scree 2019-09-18 17:24:43 -07:00
Unpublished
97abbb9fe9 [fenix] Pass color resource for what's new menu item by id 2019-09-18 16:41:03 -07:00
Sawyer Blatz
cc79eb3a95 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5411: Fixes delete button turning red (https://github.com/mozilla-mobile/fenix/pull/5412) 2019-09-18 15:20:05 -07:00
Sawyer Blatz
320fd1462f [fenix] For https://github.com/mozilla-mobile/fenix/issues/5371: Updates search engine settings string (https://github.com/mozilla-mobile/fenix/pull/5393) 2019-09-18 11:26:44 -07:00
Emily Kager
7c3a8c2e57 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1749 - Update to new ETP Settings Strings (https://github.com/mozilla-mobile/fenix/pull/5395) 2019-09-18 10:36:09 -07:00
Emily Kager
b51c5de5b0 [fenix] No issue: Land strings for login management 2019-09-18 08:06:20 -07:00
Sawyer Blatz
24abe8b9d8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5396: Reverts broken activity alias 2019-09-17 18:35:31 -07:00
Tiger Oakes
b4a7190d1e [fenix] Use .orEmpty() 2019-09-17 11:09:21 -07:00
Emily Kager
44dee734d4 [fenix] No issue: Update androidx libraries Sept 5 2019 2019-09-17 09:50:31 -07:00
Mihai Adrian
028d9fe646 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5174 Changed FindInPage height to toolbar height to cover QAB (https://github.com/mozilla-mobile/fenix/pull/5376) 2019-09-17 05:47:17 -07:00
Emily Kager
2c74a708a0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5258 - Pop AccountProblemFragment if signed out 2019-09-16 21:26:01 -07:00
Grisha Kruglov
27812d19e0 [fenix] Post: Clean up 'push' initialization code 2019-09-16 19:44:13 -07:00
Grisha Kruglov
5fb2eadde8 [fenix] Post: Add experiment flags, push and telemetry tests for BackgroundServices 2019-09-16 19:44:13 -07:00
Grisha Kruglov
ddbfc7b4c1 [fenix] Post: minor cleanup 2019-09-16 19:44:13 -07:00
Grisha Kruglov
6411072f0d [fenix] FxA WebChannels integration 
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes https://github.com/mozilla-mobile/fenix/issues/4971)

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2019-09-16 19:44:13 -07:00
Tiger Oakes
65a6d962b3 [fenix] Separates tracker bucket sorting code 2019-09-16 15:16:12 -07:00
Emily Kager
5c5d3b8ab8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5368 - Make every blocking category gone by default 2019-09-16 15:01:29 -07:00
Emily Kager
b7d6ab40b2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5359 , https://github.com/mozilla-mobile/fenix/issues/5360 - Update ETP Vectors for Android 5+6 2019-09-16 15:01:29 -07:00
Axel Hecht
0434de4d53 [fenix] Import strings from android-l10n 
State: mozilla-l10n/android-l10n@f0d82028ce
 2019-09-16 12:54:44 -07:00
Yeon Taek Jeong
6fdb6d41fa [fenix] For https://github.com/mozilla-mobile/fenix/issues/5296: Fix long-press shortcuts to work across build variants 2019-09-16 12:31:20 -07:00
mawen7
04a72ff834 [fenix] Pass app name to delete browsing data prompt 2019-09-16 09:59:42 -07:00
Sebastian Kaspari
f205820367 [fenix] Use new feature-contextmenu API. 2019-09-16 17:24:13 +02:00
Tiger Oakes
b0f4ecd5a5 [fenix] Change deleteAndQuit to take an activity 2019-09-15 20:03:04 -07:00
ekager
d14d848d51 [fenix] No issue: Fixes UI tests by removing TP onboarding closure 2019-09-15 19:47:16 -07:00
ekager
438fb1ac95 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5338 - Use padding instead of margin for delete browsing item 2019-09-15 19:46:50 -07:00
Emily Kager
ec79707dfe [fenix] For https://github.com/mozilla-mobile/fenix/issues/5279 - Don't use runBlocking in delete and quit 2019-09-14 11:18:43 -07:00
ekager
28b4010b7a [fenix] For https://github.com/mozilla-mobile/fenix/issues/5304 - Align ETP Onboarding Tool Tip PopupWindow 2019-09-13 18:25:26 -07:00
Richard Pappalardo
6b813c0aae [fenix] fix: broken UI tests (https://github.com/mozilla-mobile/fenix/pull/5324) 2019-09-13 17:30:53 -07:00
Yeon Taek Jeong
359619c538 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5254: Fix transition to private browsing mode after sharing a page 2019-09-13 14:44:28 -07:00
Axel Hecht
5acc115b73 [fenix] Import strings from android-l10n (https://github.com/mozilla-mobile/fenix/pull/5300) 
State: mozilla-l10n/android-l10n@e78d5868c7
 2019-09-13 12:15:08 -07:00
Sawyer Blatz
2c4b7d0f61 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5277: Updates string for delete browsing data (https://github.com/mozilla-mobile/fenix/pull/5309) 2019-09-13 10:18:25 -07:00
Oana Horvath
9706df2e2b [fenix] Adds 2 new tests to SearchTest (https://github.com/mozilla-mobile/fenix/pull/4770) 2019-09-13 10:11:33 -07:00
Sebastian Kaspari
e6d6d6ecf6 [fenix] Use new feature-downloads API. 2019-09-13 15:01:25 +02:00
No-Jun Park
d293228b8f [fenix] fix TabbedBrowsingTest.kt failure where Share Tabs element was not found (https://github.com/mozilla-mobile/fenix/pull/5282) 2019-09-12 15:56:35 -07:00
Alessio Placitelli
2edc73ed3f [fenix] Automatically generate metrics docs using the Glean SDK (https://github.com/mozilla-mobile/fenix/pull/5101) 2019-09-12 14:49:49 -07:00
Sawyer Blatz
c9bf807f3e [fenix] For https://github.com/mozilla-mobile/fenix/issues/4155: Adds elevation to copy/paste menu 2019-09-12 14:03:12 -07:00
Mihai Adrian
b0f9621fee [fenix] For https://github.com/mozilla-mobile/fenix/issues/2570: Hide 3-dots menu when in select mode for bookmarks and history (https://github.com/mozilla-mobile/fenix/pull/5173) 
Show or hide overflow menu for entire list is triggered when mode is changed
For bookmarks, due to implementation of selection and diffUtil,
additional check is necessary for current item (last selected) that is redrawn
 2019-09-12 13:56:39 -07:00
Colin Lee
f0fd309d38 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5274: Fix LogTest unit tests (https://github.com/mozilla-mobile/fenix/pull/5275) 2019-09-12 15:41:56 -05:00
Sawyer Blatz
6697a820f9 [fenix] No issue: Slightly changes margin on play/pause button 2019-09-12 13:37:49 -07:00
Emily Kager
9470a74175 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5270 - Adds state list color for delete browsing checkboxes 2019-09-12 13:27:27 -07:00
Emily Kager
c0fd3632c6 [fenix] No issue: Remove recommended from standard ETP option 2019-09-12 12:34:28 -07:00
Emily Kager
92f2692fbf [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5268 - Fix 2 detekt errors 2019-09-12 11:32:33 -07:00
Emily Kager
03b4bc2d32 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5263 - Hide ETP Panel Settings for custom tab 2019-09-12 10:45:35 -07:00
kglazko
58a85d264e [fenix] Issue 4622- Create Unit Tests for Extensions (https://github.com/mozilla-mobile/fenix/pull/4669) 2019-09-12 10:44:37 -07:00
Tiger Oakes
29d73507a9 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5212 - Change tint in onCreateOptionsMenu 
Also fixes https://github.com/mozilla-mobile/fenix/issues/5213
 2019-09-12 10:30:49 -07:00
Colin Lee
c1577cd1f8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3106: Improve granular data deletion margins 2019-09-12 10:25:14 -07:00
Mihai Adrian
2f2d130ad6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3371: Show snackbar message when share fails with crash (https://github.com/mozilla-mobile/fenix/pull/5210) 2019-09-12 09:26:24 -07:00
Emily Kager
b6679bc23d [fenix] For https://github.com/mozilla-mobile/fenix/issues/4458 - Enable font inflation with font auto size setting (https://github.com/mozilla-mobile/fenix/pull/5252) 2019-09-12 09:05:16 -07:00
ekager
9bc95446ca [fenix] For https://github.com/mozilla-mobile/fenix/issues/5229, https://github.com/mozilla-mobile/fenix/issues/5228 - Dismiss ETP panel on back press, don't truncate text 2019-09-12 07:40:49 -07:00
Sebastian Kaspari
509d3c5e20 [fenix] Unbreak Nightly: Get rid of fragment-testing dependency and create fragments in test manually. 2019-09-12 13:44:17 +02:00
Emily Kager
fe01f2f319 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5178 - Polish delete browsing data item layout 2019-09-11 18:11:26 -07:00
Emily Kager
432972dac1 [fenix] No issue: Updates isPWA to isInstallable for AC 13 snapshot 2019-09-11 18:10:52 -07:00
Emily Kager
a22a98243c [fenix] No issue: Fix BreadCrumbReporterTest 2019-09-11 18:10:52 -07:00
Roger Yang
d1011bbfda [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5091: Refactor Sentry BreadCrumbs to use lib-crash BreadCrumbs 2019-09-11 16:14:42 -07:00
Emily Kager
a652723373 [fenix] No issue: Land new ETP Strings 2019-09-11 16:11:42 -07:00
Jeff Boek
5099eaa00f [fenix] For https://github.com/mozilla-mobile/fenix/issues/5047 - Addresses nits 
- Changes MainScope to viewLifecycleScope
- Fixes string name/comment to better describe what it is
- Adds disabled state to the add button
 2019-09-11 16:10:54 -07:00
Jeff Boek
1574f05038 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5047 - Wires up dialog to webAppUseCases 2019-09-11 16:10:54 -07:00
Jeff Boek
410d33a4c8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5047 - Creates dialog ui for naming a shortcut 2019-09-11 16:10:54 -07:00
Emily Kager
e647d7e8c6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3700 - Add Setting to Delete Data on "Quit" menu action 2019-09-11 16:06:18 -07:00
Yeon Taek Jeong
88ecaf12b1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4658: Add private browsing mode shortcut telemetry 2019-09-11 16:03:22 -07:00
Emily Kager
f2ff2c4f32 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1749 - Use Strict ETP by default, use Feature Flag for Settings 2019-09-11 16:03:01 -07:00
Sawyer Blatz
f001f5b6d8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1114: Show playing tab 2019-09-11 15:45:22 -07:00
Jeff Boek
2102e39e4b [fenix] For https://github.com/mozilla-mobile/fenix/issues/5214 - Bumps expiration dates for telemetry 2019-09-11 14:44:13 -07:00
Emily Kager
ee8cd6d08f [fenix] No issue: Set color for toolbar divider (https://github.com/mozilla-mobile/fenix/pull/5221) 2019-09-11 11:46:00 -07:00
Emily Kager
8eb6b616c8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2897 - Add Action States To Share Sheet 2019-09-11 11:32:26 -07:00
Yeon Taek Jeong
c26cca80e7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/419: Create launch icon for private browsing (https://github.com/mozilla-mobile/fenix/pull/4948) 2019-09-11 10:52:33 -07:00
Aaron Train
036b3d239b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5217 - fix androidx.test dep error (https://github.com/mozilla-mobile/fenix/pull/5219) 
See https://github.com/mozilla-mobile/fenix/issues/5217
 2019-09-11 12:55:22 -04:00
Oana Horvath
f36d0c476a [fenix] added LibraryMenuTest, BookmarksRobot, HistoryRobot (https://github.com/mozilla-mobile/fenix/pull/4769) 
ran ktlint

added the goBack()method in  Transition

added the goBack method in Transition
 2019-09-11 09:09:22 -07:00
Sawyer Blatz
e30570dc86 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4155: Handle custom tabs & fix test 2019-09-11 09:03:17 -07:00
Sawyer Blatz
7bee891913 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4155: Sets pastedText default value 2019-09-11 09:03:17 -07:00
Sawyer Blatz
603740cde0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4155: Restyle to custom menu 2019-09-11 09:03:17 -07:00
Sawyer Blatz
8b5a149877 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4155: Adds tests for browser toolbar popup menu 2019-09-11 09:03:17 -07:00
Sawyer Blatz
7daf054b67 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4155: Adds popup menu for browser toolbar 2019-09-11 09:03:17 -07:00
Aaron Train
1465ea335c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5192 - Add UI Test for "What's New" menu option (https://github.com/mozilla-mobile/fenix/pull/5193) 2019-09-11 11:41:05 -04:00
Emily Kager
3b0a3c1643 [fenix] Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
mihai-adrian
40108e53c7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4877: Restored logic for closing tabs when not on browserFragment 
Added base test for CreateCollectionFragment that we can build upon later
 2019-09-10 21:42:16 -07:00
mihai-adrian
ed24b8b0f1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4877: Restored logic for closing tabs when not on browserFragment 
Added return in function when saving collections coming from browser fragment
 2019-09-10 21:42:16 -07:00
Sawyer Blatz
3c746c4b5c [fenix] For https://github.com/mozilla-mobile/fenix/issues/4908: Adds telemetry for send tab 2019-09-10 20:58:12 -07:00
Tiger Oakes
dd2c36c14a [fenix] Move bookmark navigation listener to separate file 2019-09-10 16:53:09 -07:00
Sawyer Blatz
2502dcc4bb [fenix] For https://github.com/mozilla-mobile/fenix/issues/5021: Adds telemetry for what's new button 2019-09-10 14:15:34 -07:00
Tiger Oakes
97bdbdc223 [fenix] Use A-C preferences property delegates 2019-09-10 13:19:00 -07:00
No-Jun Park
5dc8dd7264 [fenix] Create homeview share dialog UITest (https://github.com/mozilla-mobile/fenix/pull/5160) 
Share Button UI test added
Collection test steps created
 2019-09-10 15:03:47 -04:00
ekager
faedf2f638 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5178 - Do not truncate delete browsing text 2019-09-10 10:44:14 -07:00
Tiger Oakes
ebcc6ce414 [fenix] Clean up SupportUtils 2019-09-10 10:16:04 -07:00
Mihai Adrian
72f0d9ce56 [fenix] Code Health https://github.com/mozilla-mobile/fenix/issues/4883: Refactored accessing settings by using Context extensions (https://github.com/mozilla-mobile/fenix/pull/4973) 2019-09-10 10:11:58 -07:00
Sawyer Blatz
e2eb292241 [fenix] No issue: Only use iconTint in XML for bookmark menus (https://github.com/mozilla-mobile/fenix/pull/5145) 2019-09-10 09:04:05 -07:00
Tiger Oakes
0e9d9d82c5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3440 - Reduce BrowserFragment require calls 2019-09-09 21:33:32 -07:00
mihai-adrian
8a5b5682f4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4517: Keep Bookmarks fragment when navigating to browser 
Removed popUp when navigating from bookmarks to browser
 2019-09-09 20:52:36 -07:00
Colin Lee
06d8f42c94 [fenix] Delete AUTH_SESSIONS with COOKIES 2019-09-09 12:32:28 -07:00
Colin Lee
a34b774213 [fenix] Updates per UX and PR feedback 2019-09-09 12:32:28 -07:00
Colin Lee
736fb7fd7c [fenix] For https://github.com/mozilla-mobile/fenix/issues/3106: Granular options for clearing user data 2019-09-09 12:32:28 -07:00
Emily Kager
6103a21747 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4763 - Enable GV logging in debug builds (https://github.com/mozilla-mobile/fenix/pull/5144) 2019-09-09 11:20:51 -07:00
Aaron Train
7f6fdcda4b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5137 - Add Find in Page UI Test (https://github.com/mozilla-mobile/fenix/pull/5138) 2019-09-09 14:16:47 -04:00
Sawyer Blatz
1cfb9cef09 [fenix] No issue: Top aligns close button for tab in collection (https://github.com/mozilla-mobile/fenix/pull/5161) 
See https://github.com/mozilla-mobile/fenix/pull/4442#issuecomment-528580904 for more info
 2019-09-09 11:08:30 -07:00
Petru Lingurar
37308af6b8 [fenix] Code cleanup - Remove unused FindInPageBarBehavior 
There is a "unused" lint suppression in place with the comment
"Referenced from XML". I found no such usage.
It's documentation says that this Behavior will always position FindInPageBar
above BrowserToolbar but the current code ensures
BrowserToolbar.visibility == GONE when FindInPageBar.visibility == VISIBLE
so there's no need for such behavior.
 2019-09-06 14:20:02 -04:00
Petru Lingurar
f911a3d485 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4856 - Refactor InflationAwareFeatureTest 
We previously had a test exactly for checking that "start does nothing" but we
now need to ensure that start actually is propagated to the inner feature that
is to rebind itself to the app to allow for user interactions.
 2019-09-06 14:20:02 -04:00
Petru Lingurar
c6f298f9fb [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/4856 - Propagate LifecycleAwareFeature's onStart() to the inner feature 
FindInPageFeature is used inside the app as a LifecycleAwareFeature and as such
it receives the onStart / onStop lifecycle calls.
The onStart() lifecycle call would not get passed to the feature but in
onStop() FindInPageFeature will detach it's Presenter and Interactor so when
the user comes back to the screen she could not interact anymore with the
feature.
To fix this we'll propagate LifecycleAwareFeature's onStart() to the inner
feature which is to rebind it's Presenter and Interactor in onStart().

This behavior is common to all the other features so all of them who implement
LifecycleAwareFeature will now get the onStart() call also.
 2019-09-06 14:20:02 -04:00
Mihai Adrian
3312a8c307 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4193 - Makes close button for tabs more accessible (https://github.com/mozilla-mobile/fenix/pull/4442) 
* fixes https://github.com/mozilla-mobile/fenix/issues/4193 - made close button for tabs more accessible.

set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button and text as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible

* Fix margins
 2019-09-06 10:33:55 -07:00
Sawyer Blatz
db43c5db32 [fenix] No issue: Removes unused nestedScrollQuickActionView (https://github.com/mozilla-mobile/fenix/pull/5143) 2019-09-06 09:03:24 -07:00
mihai-adrian
9d18725a8b [fenix] For https://github.com/mozilla-mobile/fenix/issues/5142 Removed RadioButton from accessibility keeping one option for Talkback 
Set android:importantForAccessibility = "no" for RadioButton
 2019-09-06 14:09:58 +02:00
Sawyer Blatz
88996e7f0c [fenix] For https://github.com/mozilla-mobile/fenix/issues/964: Adds ability to disable each suggestion provider (https://github.com/mozilla-mobile/fenix/pull/5096) 
* For https://github.com/mozilla-mobile/fenix/issues/964: Adds ability to disable each suggestion provider

* Fix nit
 2019-09-05 14:45:44 -07:00
Jonathan Almeida
5891296994 [fenix] No issue: Add logging for firebase/autopush 2019-09-05 16:03:36 -04:00
Emily Kager
470b943edd [fenix] For https://github.com/mozilla-mobile/fenix/issues/5033 - Update browsing mode when session selected (https://github.com/mozilla-mobile/fenix/pull/5118) 2019-09-05 14:27:30 -05:00
Richard Pappalardo
6a54b74c1e [fenix] Temporarily disable broken UI test (https://github.com/mozilla-mobile/fenix/pull/5136) 2019-09-05 10:22:14 -07:00
Alessio Placitelli
cf76cd9c62 [fenix] Enable Gecko metrics exfiltration through Glean (https://github.com/mozilla-mobile/fenix/pull/5126) 2019-09-05 11:58:35 -05:00
Emily Kager
16d1b63850 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5075 - Fix boolean error for private mode notification persistence (https://github.com/mozilla-mobile/fenix/pull/5120) 2019-09-05 09:21:56 -07:00
Sebastian Kaspari
fcee35b059 [fenix] Remove ThumbnailsFeature. (https://github.com/mozilla-mobile/fenix/pull/5127) 
We currently do not use thumbnails anywhere in the app. Not using the feature means we are
not taking thumbnails on every page load which means we are saving memory and CPU cycles.
 2019-09-05 11:05:37 -05:00
Grisha Kruglov
7cd0e2d290 [fenix] Fix breaking services APIs changes 2019-09-05 13:38:15 +02:00
Sebastian Kaspari
9fdfd82bc0 [fenix] Update to Mozilla Android Components 12.0.0-SNAPSHOT. 2019-09-05 13:38:15 +02:00
Sebastian Kaspari
1ad6f0ea20 [fenix] Add browser-state component. 2019-09-05 13:38:15 +02:00
Alessio Placitelli
0ab76faedb [fenix] Revert "Enable Gecko metrics exfiltration through Glean (https://github.com/mozilla-mobile/fenix/pull/5124)" (https://github.com/mozilla-mobile/fenix/pull/5125) 
This reverts commit ed9c9cffa8033784f9ab3c7391c177ab5b66cf1e.
 2019-09-05 04:26:46 -05:00
Alessio Placitelli
7d25624e16 [fenix] Enable Gecko metrics exfiltration through Glean (https://github.com/mozilla-mobile/fenix/pull/5124) 2019-09-05 04:17:28 -05:00
Emily Kager
a4172aafae [fenix] For https://github.com/mozilla-mobile/fenix/issues/5025 - Do not remove custom tab session with config removed 2019-09-05 10:57:37 +02:00
Sawyer Blatz
d0fa780907 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4155: Adds strings for long press popup (https://github.com/mozilla-mobile/fenix/pull/5112) 2019-09-04 17:15:06 -07:00