Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-03 23:15:31 +00:00
Code Issues Releases Wiki Activity
7,283 Commits 67 Branches 113 Tags 1.2 GiB
5385b96abe
Commit Graph

6084 Commits

Author SHA1 Message Date
Christian Sadilek
5385b96abe [fenix] Move tabs out of search group if direct load occurs 
This regressed in our previous fix that made sure child tabs don't
mistakenly get moved out of the group if their parent is navigated
away, or in case the child tabs are redirected.

However, when a subsequent load occurs in any tab in the group the
search terms need to be cleared and the tab removed from the group
to prevent false positives.
 2021-10-04 17:30:49 -04:00
Elise Richards
3db298543e [fenix] CI for Fix description for home_screen_displayed metric (https://github.com/mozilla-mobile/fenix/pull/21697) 
* Fix description for `home_screen_displayed` metric

The current description appears to be incorrect by my reading of the source.

* Update app/metrics.yaml

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>

Co-authored-by: Will Lachance <wlachance@mozilla.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
 2021-10-04 13:59:02 -07:00
Elise Richards
3631014159 [fenix] CI for Docs: Add extra context to events.browser_menu_action (https://github.com/mozilla-mobile/fenix/pull/21696) 
* Docs only: Add extra context to `events.browser_menu_action`

This came up as a potential point of confusion in a discussion with DS. This is a docs only change.

* Update metrics.yaml

Co-authored-by: Will Lachance <wrlach@gmail.com>
 2021-10-04 20:10:49 +00:00
Gabriel Luong
efab5cbb1d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21658 - Don't pass Client into composable functions 2021-10-04 19:06:30 +00:00
Jonathan Almeida
3d69371557 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21671: Remove Recently Closed from Inactive Tabs 2021-10-04 15:50:27 +00:00
Mugurell
7e65b07930 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor the coroutine from PocketStoriesShown to outside the middleware 
In so this code will no longer have access to the MiddlewareContext which only
makes sense in the thread of the Middleware itself.
 2021-10-04 11:54:42 +00:00
Mugurell
6261e570c3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Persist stories categories selections in a Proto DataStore 
A fast and easy solution with all the ACID requirements.
Also supports easy migrations if later the data we need persisted changes.
 2021-10-04 11:54:42 +00:00
Mugurell
4f4586d85f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor out "isSelected" from PocketRecommendedStoriesCategory 
Having the list of categories and the list of selected categories separate in
State allows updating them independently.
 2021-10-04 11:54:42 +00:00
AndiAJ
7b031b0504 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21644 fix disabled alwaysStartOnHomeTest UI test 2021-10-04 10:34:56 +00:00
Jonathan Almeida
884c8c2224 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21576: Hide 'Other' title when there are no search groups 2021-10-04 08:56:20 +00:00
Mugurell
20f07022d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21626 - Avoid showing story invalid properties 2021-10-04 07:33:31 +00:00
Arturo Mejia
8a4bb26526 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21618: Integrate Nimbus with MR2 Home Page to enable experimentation 2021-10-04 00:39:59 +00:00
Arturo Mejia
21480b89ea [fenix] For https://github.com/mozilla-mobile/fenix/issues/21611: Add jump back in Contextual Hints 2021-10-03 23:16:37 +00:00
Jonathan Almeida
51000bcfa4 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21632: Correct inactive tabs survey string (https://github.com/mozilla-mobile/fenix/pull/21669) 2021-10-03 14:29:39 +00:00
Christian Sadilek
c1f2c33a76 [fenix] Make search term grouping tolerant to (parent tab) navigation 
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
 2021-10-02 08:51:25 +00:00
Elise Richards
d70d0610d0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21648: match Pocket sections on home to designs 2021-10-02 08:24:09 +00:00
Jonathan Almeida
0c5285cf05 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21641: Do not add a group of only one tab 2021-10-02 04:00:02 -04:00
Elise Richards
ad1cff2300 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21653: pre-land section title for tab preferences 2021-10-02 00:53:00 +00:00
Noah Bond
4f07d1a40f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21360 - Added toggle for search term tab groups (https://github.com/mozilla-mobile/fenix/pull/21615) 
* For https://github.com/mozilla-mobile/fenix/issues/21360  - Added toggle for search term tab groups

* For https://github.com/mozilla-mobile/fenix/issues/21360 - Lint cleanup

* PR: Added missing licenses and possibly fixed UI test

* PR: Added a "scrollTo" to potentially fix a UI test

* PR: Added potential fix for alwaysStartOnHomeTest

* PR: Added temporary ignore to alwaysStartOnHomeTest

* PR: added missing ignore comment

* For https://github.com/mozilla-mobile/fenix/issues/21360 - Added missing feature flag driven visibility logic

Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-10-02 00:25:12 +00:00
Elise Richards
f12124b948 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21646: Update section titles and customize button name on home 2021-10-01 23:51:48 +00:00
Elise Richards
b9f5e56c37 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21643: Pre-land strings for inactive tabs CFR. Update section title for normal, non-search group tabs. (https://github.com/mozilla-mobile/fenix/pull/21645) 2021-10-01 14:23:24 -07:00
Noah Bond
44f1f679e7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21635 - Preland strings for tab auto close message (https://github.com/mozilla-mobile/fenix/pull/21636) 
* For https://github.com/mozilla-mobile/fenix/issues/21635 - Prelanded strings for tab auto close message

* PR: Updated String descriptions and added temporary tools ignore
 2021-10-01 20:37:51 +00:00
Gabriel Luong
33381f78f7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21632 - Preland strings for the inactive tab survey 2021-10-01 19:51:59 +00:00
Biren-Nayak
bd610d394f [fenix] For https://github.com/mozilla-mobile/fenix/issues/16437: Remove unnecessary space for tracking protection exceptions 2021-10-01 19:15:00 +00:00
Mugurell
4e5047d203 [fenix] For https://github.com/mozilla-mobile/fenix/pull/21392 - Update new strings descriptions. 2021-10-01 18:03:12 +00:00
Christian Sadilek
1d537cb332 [fenix] Allow opening pocket stories when search dialog is active 2021-10-01 16:03:59 +00:00
Oana Horvath
1f628f8e52 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540, https://github.com/mozilla-mobile/fenix/issues/21620: disables failing UI tests 2021-10-01 15:03:35 +00:00
Oana Horvath
4967527781 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21441, https://github.com/mozilla-mobile/fenix/issues/21477, https://github.com/mozilla-mobile/fenix/issues/21500, https://github.com/mozilla-mobile/fenix/issues/21499 https://github.com/mozilla-mobile/fenix/issues/21476, https://github.com/mozilla-mobile/fenix/issues/21474: retry dismissing the search bar 2021-10-01 08:38:03 +00:00
Roger Yang
1da6397453 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21610: Update Strings for Tab Settings 2021-10-01 06:31:50 +00:00
Mozilla L10n Automation Bot
2311ac81df [fenix] Import l10n. 2021-10-01 03:27:40 +00:00
Arturo Mejia
5e57ece039 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21611: Add jump back in contextual hint text 2021-09-30 22:40:30 -04:00
Roger Yang
1f11b81bc4 [fenix] No issue: Make sure jump back in group always have more than one tab 2021-09-30 22:33:50 -04:00
Gabriel Luong
4d23db624f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21551 - Add delete history metadata in the History view 
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
 2021-09-30 22:30:19 -04:00
Elise Richards
dc1e5e640e [fenix] For https://github.com/mozilla-mobile/fenix/issues/21287: long press menu on recently visited homescreen groups 2021-09-30 22:00:18 -04:00
Arturo Mejia
e1a2b9ccfa [fenix] For https://github.com/mozilla-mobile/fenix/issues/21608: Update strings for home screen dialog features 2021-10-01 01:51:07 +00:00
Grisha Kruglov
485ca898f2 [fenix] Do not show home screen behind search if we have search terms 
Home screen isn't actually visible in case we're displaying awesomebar
search results. The navigation is thus unnecessary and actually causes visual
jankiness as we display home for a moment before covering it up with
search results.
 2021-09-30 18:14:16 -04:00
Jan-Erik Rediger
0a08c61e8d [fenix] Don't manually exclude glean-native 
The latest geckoview-omni package correctly declares its capabilities,
including the `glean-native` one.
Additionally it is able to pick geckoview-omni over glean-native in all
configurations.
 2021-09-30 19:51:29 +00:00
Noah Bond
f2b7eea088 [fenix] Inactive tabs changes (https://github.com/mozilla-mobile/fenix/pull/21524) 
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Moved inactive tabs to the top of the normal tabs tray.

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Added a delete icon to delete ALL inactive tabs.

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Changed default inactive time period to 14 days

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Hooked inactive tabs setting to UI code

Inactive tabs setting is also disabled when the user has selected the one day or week auto-close tab setting.

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - File and Lint cleanup

* PR: Fixed bug causing grouped tabs to also show in "Other" when marked as inactive but inactive is OFF in Settings

* PR: Fixed lint warnings

* PR: Removed redundant feature check

* PR - Ignore test until search term tab groups switch is done
 2021-09-30 19:01:31 +00:00
Mugurell
4fac910adf [fenix] For https://github.com/mozilla-mobile/fenix/issues/21592 - Don't topup with general stories 2021-09-30 15:54:21 +00:00
Mugurell
92bc5e93b1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21562 - Snap to next item when scrolling 
This works by replacing the fling animation with snapping to the next item in
the scroll direction.
 2021-09-30 14:57:17 +00:00
Aaron Train
e7b2578a5a [fenix] No issue: Fix AssertionError in openThreeDotMenu 
fix: ktlint
 2021-09-30 14:06:13 +00:00
AndiAJ
c7658e352d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix flaky editCustomSearchEngineTest UI test 2021-09-30 10:30:27 +00:00
Michael Comella
e7077466ff [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: suppress MaxLineLength in Fact.toEvent. 
These double comparisons are easier to read and see the pattern of on one line
so I'd rather keep them on one line. Additionally, it's difficult to
test each change individually so I'd rather not make additional changes.
To do this, I suppressed the max line length warning.
 2021-09-30 09:13:53 +00:00
Michael Comella
d0ceaf7a7a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: remove allocations in Fact.toEvent. 
This commit was generated primarily by a macro that:
- appends `== component &&`
- appends `== item`
- (if applicable) Skips to the ending brace
- Go down one line and move cursor to the front of the line to prep for repeat

My only intervention was to skip extra lines to line it up to run again
and specify how many times in a row it should run.

---

The `to` in this code is an infix function that calls instantiates a
Pair under the hood. Subjectively observed, when this method is called
it generally hits the else case so 35 Pairs are instantiated each call -
that's 560 bytes. This method is called frequently - for example, an estimated
4 times each time a letter is typed on the homescreen and a measured 116 times
in a simple navigation (see the issue). The latter generates an estimated
63.4 KiB.

It was straightforward to remove these allocations so that's what this
change does.

The primary risk from this change is that it's difficult to test each
case to ensure it's working.
 2021-09-30 09:13:53 +00:00
Michael Comella
08a11127aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: change when (condition) { when { in Fact.toEvent. 
This will not compile. However, it enables the subsequent PR to remove
allocations from Fact.toEvent.
 2021-09-30 09:13:53 +00:00
Michael Comella
32c8709148 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: add partial test for existing factToEvent code. 
When we refactor, this will help ensure we've done it correctly.
 2021-09-30 09:13:53 +00:00
codrut.topliceanu
ed55813676 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20762 - Adds grey border to inactive tabs 2021-09-30 08:42:46 +00:00
Mozilla L10n Automation Bot
738e7b68d5 [fenix] Import l10n. 2021-09-30 00:43:30 +00:00
Elise Richards
8a77a20614 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21574: Move the homescreen onboarding card behind a feature flag 2021-09-29 22:52:42 +00:00
Mugurell
ad0f428f39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21561 - Enable/Disable the feature from the customization menu 2021-09-29 19:55:26 +00:00