Commit Graph

7283 Commits (5385b96abe31646300b2b97d5bde7fe5392dc941)
 

Author SHA1 Message Date
Christian Sadilek 5385b96abe [fenix] Move tabs out of search group if direct load occurs
This regressed in our previous fix that made sure child tabs don't
mistakenly get moved out of the group if their parent is navigated
away, or in case the child tabs are redirected.

However, when a subsequent load occurs in any tab in the group the
search terms need to be cleared and the tab removed from the group
to prevent false positives.
3 years ago
Elise Richards 3db298543e [fenix] CI for Fix description for home_screen_displayed metric (https://github.com/mozilla-mobile/fenix/pull/21697)
* Fix description for `home_screen_displayed` metric

The current description appears to be incorrect by my reading of the source.

* Update app/metrics.yaml

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>

Co-authored-by: Will Lachance <wlachance@mozilla.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
Elise Richards 3631014159 [fenix] CI for Docs: Add extra context to events.browser_menu_action (https://github.com/mozilla-mobile/fenix/pull/21696)
* Docs only: Add extra context to `events.browser_menu_action`

This came up as a potential point of confusion in a discussion with DS. This is a docs only change.

* Update metrics.yaml

Co-authored-by: Will Lachance <wrlach@gmail.com>
3 years ago
Gabriel Luong efab5cbb1d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21658 - Don't pass Client into composable functions 3 years ago
MickeyMoz a1d797e1ee [fenix] Update Android Components version to 94.0.20211003190228. 3 years ago
Jonathan Almeida 3d69371557 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21671: Remove Recently Closed from Inactive Tabs 3 years ago
Mugurell 7e65b07930 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor the coroutine from PocketStoriesShown to outside the middleware
In so this code will no longer have access to the MiddlewareContext which only
makes sense in the thread of the Middleware itself.
3 years ago
Mugurell 6261e570c3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Persist stories categories selections in a Proto DataStore
A fast and easy solution with all the ACID requirements.
Also supports easy migrations if later the data we need persisted changes.
3 years ago
Mugurell 4f4586d85f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor out "isSelected" from PocketRecommendedStoriesCategory
Having the list of categories and the list of selected categories separate in
State allows updating them independently.
3 years ago
AndiAJ 7b031b0504 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21644 fix disabled alwaysStartOnHomeTest UI test 3 years ago
Jonathan Almeida 884c8c2224 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21576: Hide 'Other' title when there are no search groups 3 years ago
Mugurell 20f07022d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21626 - Avoid showing story invalid properties 3 years ago
Arturo Mejia 8a4bb26526 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21618: Integrate Nimbus with MR2 Home Page to enable experimentation 3 years ago
Arturo Mejia 21480b89ea [fenix] For https://github.com/mozilla-mobile/fenix/issues/21611: Add jump back in Contextual Hints 3 years ago
MickeyMoz fd6a61fdfc [fenix] Update Android Components version to 94.0.20211003143215. 3 years ago
Jonathan Almeida 51000bcfa4 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21632: Correct inactive tabs survey string (https://github.com/mozilla-mobile/fenix/pull/21669) 3 years ago
MickeyMoz ddddfa8f4e [fenix] Update Android Components version to 94.0.20211002143316. 3 years ago
Christian Sadilek c1f2c33a76 [fenix] Make search term grouping tolerant to (parent tab) navigation
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
Elise Richards d70d0610d0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21648: match Pocket sections on home to designs 3 years ago
Jonathan Almeida 0c5285cf05 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21641: Do not add a group of only one tab 3 years ago
Elise Richards ad1cff2300 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21653: pre-land section title for tab preferences 3 years ago
Noah Bond 4f07d1a40f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21360 - Added toggle for search term tab groups (https://github.com/mozilla-mobile/fenix/pull/21615)
* For https://github.com/mozilla-mobile/fenix/issues/21360  - Added toggle for search term tab groups

* For https://github.com/mozilla-mobile/fenix/issues/21360 - Lint cleanup

* PR: Added missing licenses and possibly fixed UI test

* PR: Added a "scrollTo" to potentially fix a UI test

* PR: Added potential fix for alwaysStartOnHomeTest

* PR: Added temporary ignore to alwaysStartOnHomeTest

* PR: added missing ignore comment

* For https://github.com/mozilla-mobile/fenix/issues/21360 - Added missing feature flag driven visibility logic

Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Elise Richards f12124b948 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21646: Update section titles and customize button name on home 3 years ago
MickeyMoz 7d33a02cf7 [fenix] Update Android Components version to 94.0.20211001190127. 3 years ago
Elise Richards b9f5e56c37 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21643: Pre-land strings for inactive tabs CFR. Update section title for normal, non-search group tabs. (https://github.com/mozilla-mobile/fenix/pull/21645) 3 years ago
Noah Bond 44f1f679e7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21635 - Preland strings for tab auto close message (https://github.com/mozilla-mobile/fenix/pull/21636)
* For https://github.com/mozilla-mobile/fenix/issues/21635 - Prelanded strings for tab auto close message

* PR: Updated String descriptions and added temporary tools ignore
3 years ago
Gabriel Luong 33381f78f7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21632 - Preland strings for the inactive tab survey 3 years ago
Biren-Nayak bd610d394f [fenix] For https://github.com/mozilla-mobile/fenix/issues/16437: Remove unnecessary space for tracking protection exceptions 3 years ago
Mugurell 4e5047d203 [fenix] For https://github.com/mozilla-mobile/fenix/pull/21392 - Update new strings descriptions. 3 years ago
MickeyMoz 494b5813ed [fenix] Update Android Components version to 94.0.20211001125001. 3 years ago
Christian Sadilek 1d537cb332 [fenix] Allow opening pocket stories when search dialog is active 3 years ago
Oana Horvath 1f628f8e52 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540, https://github.com/mozilla-mobile/fenix/issues/21620: disables failing UI tests 3 years ago
Oana Horvath 4967527781 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21441, https://github.com/mozilla-mobile/fenix/issues/21477, https://github.com/mozilla-mobile/fenix/issues/21500, https://github.com/mozilla-mobile/fenix/issues/21499 https://github.com/mozilla-mobile/fenix/issues/21476, https://github.com/mozilla-mobile/fenix/issues/21474: retry dismissing the search bar 3 years ago
Roger Yang 1da6397453 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21610: Update Strings for Tab Settings 3 years ago
Mozilla L10n Automation Bot 2311ac81df [fenix] Import l10n. 3 years ago
Jeff Klukas fea736a86c [fenix] Update language in adjust docs
Cleaning up a bit in advance of this document being linked from the
[Privacy Notice](https://www.mozilla.org/en-US/privacy/firefox/)
as a replacement for the no-longer-existing
https://firefox-source-docs.mozilla.org/mobile/android/adjust.html
3 years ago
Arturo Mejia 5e57ece039 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21611: Add jump back in contextual hint text 3 years ago
Roger Yang 1f11b81bc4 [fenix] No issue: Make sure jump back in group always have more than one tab 3 years ago
Gabriel Luong 4d23db624f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21551 - Add delete history metadata in the History view
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
Elise Richards dc1e5e640e [fenix] For https://github.com/mozilla-mobile/fenix/issues/21287: long press menu on recently visited homescreen groups 3 years ago
Arturo Mejia e1a2b9ccfa [fenix] For https://github.com/mozilla-mobile/fenix/issues/21608: Update strings for home screen dialog features 3 years ago
MickeyMoz cc9edbf682 [fenix] Update Android Components version to 94.0.20210930211433. 3 years ago
Grisha Kruglov 485ca898f2 [fenix] Do not show home screen behind search if we have search terms
Home screen isn't actually visible in case we're displaying awesomebar
search results. The navigation is thus unnecessary and actually causes visual
jankiness as we display home for a moment before covering it up with
search results.
3 years ago
MickeyMoz 5b7cb3b90f [fenix] Update Android Components version to 94.0.20210930173134. 3 years ago
Jan-Erik Rediger 0a08c61e8d [fenix] Don't manually exclude glean-native
The latest geckoview-omni package correctly declares its capabilities,
including the `glean-native` one.
Additionally it is able to pick geckoview-omni over glean-native in all
configurations.
3 years ago
Noah Bond f2b7eea088 [fenix] Inactive tabs changes (https://github.com/mozilla-mobile/fenix/pull/21524)
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Moved inactive tabs to the top of the normal tabs tray.

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Added a delete icon to delete ALL inactive tabs.

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Changed default inactive time period to 14 days

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Hooked inactive tabs setting to UI code

Inactive tabs setting is also disabled when the user has selected the one day or week auto-close tab setting.

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - File and Lint cleanup

* PR: Fixed bug causing grouped tabs to also show in "Other" when marked as inactive but inactive is OFF in Settings

* PR: Fixed lint warnings

* PR: Removed redundant feature check

* PR - Ignore test until search term tab groups switch is done
3 years ago
MickeyMoz 63cffef317 [fenix] Update Android Components version to 94.0.20210930143139. 3 years ago
Mugurell 4fac910adf [fenix] For https://github.com/mozilla-mobile/fenix/issues/21592 - Don't topup with general stories 3 years ago
Mugurell 92bc5e93b1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21562 - Snap to next item when scrolling
This works by replacing the fling animation with snapping to the next item in
the scroll direction.
3 years ago
Aaron Train e7b2578a5a [fenix] No issue: Fix AssertionError in openThreeDotMenu
fix: ktlint
3 years ago