8a2e4043b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26582 - Renew telemetry expiring in 107
2 years ago
58511263aa
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26997 : convert v1 wallpapers into collection group
2 years ago
3b412f7dc8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11404 - Create alert message when a lot of tabs are to be opened.
...
Current threshold is 15.
2 years ago
ef15f5154c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11404 - Add 'Open all in private tabs' option as requested.
...
https://github.com/mozilla-mobile/fenix/pull/21212#discussion_r739172674
- Add option is tree dot menu
- Edit folder opening to be aware of browsing mode
- Add metrics
- Add unit tests for 'Open all in private tabs'
- Add Android tests for open all in private.
2 years ago
871604943d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11404 - Create open all function
...
- Create element to be displayed
- Update the interface and bind in the view holder
Set the filter to limit this action to FOLDER.
- Create core function
Main logic is done on the controller (has it should be done). The whole
process is done in one coroutine to be non-blocking as many
(sub)folders & links can be present. If folder is empty, a toast is
displayed. Else iterate on items. When item is:
- a FOLDER -> restart process (without toast) on the folder
- a ITEM -> open it
- a SEPARATOR -> do nothing
Once finished, show the tabs tray.
Toast message is defined in fragment to have access to context.
- Create androidTest for openAllInTabs
- Create tests for handleBookmarkFolderOpening
- Display 'open all' options only if folder has at least on child:
A coroutine and suspended functions have to be used, since `getTree`
is async.
2 years ago
2dc6ba974a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26999 : fix disapprearing wallpapers after going back to home screen
2 years ago
0cd97f8f35
[fenix] For https://github.com/mozilla-mobile/fenix/issues/27020 - Correct padding for wallpaper thumbnails
2 years ago
9835d3735d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/27029 - Use placeholder inplace of app name
2 years ago
dd7c2f7eec
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26995 : add sorting of wallpapers on wallpapers onboarding tool
2 years ago
5b035e7fb5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/27024 - Use textAccent for the "Learn more" link in the wallpaper settings
2 years ago
248ef0c172
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/27021 : add wallpaper onboarding downloading error snackbar
2 years ago
a096acc130
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26945 : adds telemetry for learn more link on wallpaper settings
2 years ago
954ed79fa1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26971 : fix wallpaper onboarding display condition
2 years ago
360d443b3f
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26973 : adjust wallpaper onboarding ui ( https://github.com/mozilla-mobile/fenix/pull/26974 )
...
Co-authored-by: mike a <mavduevskiy@gmail.com>
Co-authored-by: Ryan VanderMeulen <rvandermeulen@mozilla.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 years ago
342c9551e4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26424 - Add contrasting text color for migrated Turning Red Wallpapers
2 years ago
bfddfa7177
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26424 - Create wallpaper file migration helper
2 years ago
d94392e534
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26987 - Update MR Onboarding strings for existing users
2 years ago
73ca913323
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26980 : enable task continuity in all channels
2 years ago
27d80e6de0
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26215 : add telemetry events for wallpaper onboarding dialog
2 years ago
3b36328a09
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26908 - Update wallpapers settings page design
2 years ago
e48fd2951e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26737 - Use the body2 for title else caption style in the Pocket section
2 years ago
5202efa275
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26690 - Dismiss search dialog when opening recent synced tab dropdown menu
2 years ago
632a03ff12
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26790 - Dismiss search dialog when opening recent bookmark dropdown menu
2 years ago
49d9032df2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26790 - Dismiss search dialog when opening recent visit dropdown menu
2 years ago
3d949c808f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26790 - Dismiss search dialog when opening recent tab dropdown menu
...
For https://github.com/mozilla-mobile/fenix/issues/26790 - recent tab
2 years ago
03f7ac5328
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26511 : apply wallpapers immediately and observe updates
2 years ago
adb2816dbb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26743 : Update the URL text styling in ClickableSubstringLink used by PoweredByPocketHeader
...
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2 years ago
2600c1d7d0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26888 - Change Home Section Headers to use Headline6
2 years ago
af79653039
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26212 : Download wallpapers when a thumbnail is clicked
2 years ago
8205e6f907
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26750 : add Wallpapers Onboarding dialog
2 years ago
0168388546
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26910 : Enable TCP for all modes
...
Unify the TCP feature with the TCP setting allowing both to be controlled
through the same Nimbus experiment.
Allow changing the default cookie policy to TCP based on the Nimbus experiment.
2 years ago
6c2ce5661e
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/26511 : Parallelize work for setting the wallpaper"
...
This reverts commit e7edeaababfb2828a2c6b200911421f4967a53ac.
2 years ago
028d7e9136
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/26511 : Avoid waiting to set no wallpaper"
...
This reverts commit 5010de1aa7b97c54d53d04744090a1d3f339d508.
2 years ago
83e28ebf0e
[fenix] Revert "Closes https://github.com/mozilla-mobile/fenix/issues/26750 : add Wallpapers Onboarding dialog"
...
This reverts commit 2a96c8ee06377f3103b0d4d3efe82e7b2112d0ac.
2 years ago
6171a8f85b
[fenix] Revert "Closes https://github.com/mozilla-mobile/fenix/issues/26750 : add ktlintFormat changes"
...
This reverts commit d696b7f8b1453816fda7724262a66306e5f32192.
2 years ago
3e06f5b0ca
[fenix] Revert "Closes https://github.com/mozilla-mobile/fenix/issues/26750 : pr review changes"
...
This reverts commit 013c9beaa36741d005b363cfedc7f2412906449e.
2 years ago
cd2c0d4cb8
[fenix] Revert "Closes https://github.com/mozilla-mobile/fenix/issues/26750 : disable wallpapers onboarding in HomeScreenTest.verifyCustomizeHomepageTest"
...
This reverts commit 882bf221df4cc96a054879065801289c92513430.
2 years ago
977ce6fcc8
[fenix] Revert "Closes https://github.com/mozilla-mobile/fenix/issues/26750 : remove unused files from WallpaperOnboarding"
...
This reverts commit a81e069440df10a27dd7ea01ac26a5c1b3d7f64f.
2 years ago
bfd6aac6b4
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26750 : remove unused files from WallpaperOnboarding
2 years ago
ea8bd6b05b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26750 : disable wallpapers onboarding in HomeScreenTest.verifyCustomizeHomepageTest
2 years ago
d123ba20b5
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26750 : pr review changes
2 years ago
7204aa5081
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26750 : add ktlintFormat changes
2 years ago
090060f486
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26750 : add Wallpapers Onboarding dialog
2 years ago
932823c871
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26844 : Fix ktlint issues and remove them from baseline.
2 years ago
f930d3e3cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26511 : Avoid waiting to set no wallpaper
...
This should squeeze the most performance for users who haven't set a wallpaper.
2 years ago
d6330b6dac
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26511 : Parallelize work for setting the wallpaper
...
Split loading the bitmap from storage and actually setting it in two operations
with one that can run in parallel with onCreateView for HomeFragment and one
that can be used serially on the main thread to actually set the wallpaper.
This seems like the best compromise to ensure that everytime the homescreen is
shown it will have the wallpaper set but does affect the performance - there is
a delay in showing HomeFragment to account for waiting for the wallpaper to be
set.
In testing the new delay seems close to the one from the initial wallpapers
implementation. See more in https://github.com/mozilla-mobile/fenix/pull/26794 .
2 years ago
6d330a9d58
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26502 : Add time group and private extras in history telemetry
2 years ago
0bde4cc6ea
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26858 : Remove unused nimbus engine-settings tabs-prioritization-enabled feature.
2 years ago
a31c5edce0
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26858 : Remove unused nimbus engine-settings tabs-prioritization-enabled feature.
2 years ago
6db2c727ec
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26858 : Remove unused nimbus engine-settings total-cookie-protection-enabled feature.
2 years ago
e96a2995ad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26844 : Rename CFRPopupFullscreenLayout class to conform to filename rule.
2 years ago
4a46d19da0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26777 - Part 2: Refactor the Jump Back In onboarding CFR to use the CFRPopup
2 years ago
13e8bf7c45
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26777 - Part 1: Rename SyncCFRPresenter to HomeCFRPresenter
2 years ago
731e0411d0
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26870 : remove layer behind wallpaper thumbnails
2 years ago
46536b7264
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26731 - First run onboarding updates
2 years ago
ff73cb6a4d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26867 - Remove feature flag for first run onboarding updates
2 years ago
f83f448128
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26796 - Fix PocketStoriesComposablesPreview
2 years ago
d25f8c6c43
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26797 - Add optional parameter to customize the background color of ListItemTabLarge
2 years ago
13fc8469f3
[fenix] For https://github.com/mozilla-mobile/fenix/pull/12725 : Suppress UnusedMaterial3ScaffoldPaddingParameter warning.
...
Padding value is not used for placing content.
2 years ago
2bc319e63f
[fenix] For https://github.com/mozilla-mobile/fenix/pull/12725 : Replace removed static "set", "get" methods of ViewTreeSavedStateRegistryOwner.
...
ViewTreeSavedStateRegistryOwner is retrieved/set with new extension methods.
2 years ago
58e6ebb9b8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26830 - Allow the Pocket stories to scroll to the edges of the screen
...
Restore using LazyRow's "contentPadding" property to add padding to just the
items while the entire section is allowed to extend to the edges of the screen
and so have enough room to draw items shadows without them being clipped.
2 years ago
45aa64d39c
[fenix] Added secret debug menu to override the push server URL ( https://github.com/mozilla-mobile/fenix/issues/24170 )
...
- Created a new "sync debug" pref screen to hold the Fxa, Sync, and Push
server override prefs. They were taking a lot of screen space on the
top-level settings menu as individual items
- Added button on that screen to quit FF which is needed to apply the
changes.
- This is definitely not the nicest UI, but hopefully QA can just
override the prefs once save them in an emulator and never have to
go back to this screen.
- I do think this is a nicer UI than before, where FF would quit
after a change to any of the prefs. That forces you to restart FF
3 times if you wanted to override all 3 server URLs.
2 years ago
ec82eb969f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26776 - Don't dim the window when the Jump back in CFR is shown
2 years ago
51b6ea8ea6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26191 - Add telemetry for jump back in onboarding message
2 years ago
6e42dd5236
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26759 - Crash fix for UnsupportedOperationException
2 years ago
d2f7a63214
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26774 - Attempt to show the Synced Tab CFR before the Jump Back In CFR
2 years ago
bdb4bffa35
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26738 - Update MR onboarding with the latest illustrations
2 years ago
6cfe8c9008
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26739 - Display MR onboarding dialog to existing users as soon as the app is opened
2 years ago
87a8175c83
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26609 - Update favicon dark mode background color for recent bookmarks and recent tabs
2 years ago
980594f218
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26756 - Don't show Jump Back In CFR if the synced tab CFR is shown
2 years ago
a5e3c1ab73
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26754 - Avoid showing CFR if the MR onboarding is being displayed
2 years ago
263149bab8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26723 - Fix WallpapersObserver leaking a view from HomeFragment
...
The observer initialized with a fragment View would outlive the fragment and in
that allow for leaking the entire fragment layout.
2 years ago
4662dbd8ab
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26723 - Ensure wallpapers are set on the main thread
...
Using Dispatchers.IO allowed the observer to react faster to wallpaper state
updates but caused issues with updating the wallpaper in fragment layout.
Using Dispatchers.Main.immediate gives us a bit slower reaction time but still
faster than Dispatchers.Main and allows us to still execute before the fragment
is visible.
2 years ago
87469071cd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26717 - Only show the MR onboarding dialog for existing users
2 years ago
e70f6d19af
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26211 : Download wallpapers when thumbnails clicked
2 years ago
a3f055a36e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26213 : Add wallpaper use case to load thumbnails.
2 years ago
3dbb42988f
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26214 : Download wallpaper thumbnails at app startup
2 years ago
5ba048f43b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26607 - Update back plating for recent Bookmarks
2 years ago
05df6af0b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26444 : Adapt Pocket 'powered by' text to wallpaper.
2 years ago
49e8207a93
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26444 : Adapt HomeSectionHeader text colors to wallpaper.
2 years ago
8e99bc1852
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26444 : Replace SectionHeader with HomeSectionHeader for home sections.
2 years ago
e0ec0fdb87
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26444 : Refactor HomeSectionHeader to have optional show all text.
2 years ago
451cb2338c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26450 : Remove the star icon from Pocket sponsored stories
2 years ago
69688b8b9c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26706 - Add sponsored urls filter in BlocklistHandler
2 years ago
ed16051b4f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26706 - Change TopSite.containsQueryParameters as Uri extension function
2 years ago
a33ab6b463
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26551 - Add telemetry for MR Onboarding welcome and sync dialogs.
2 years ago
7827fda4a4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26696 - Enable showSynCFR for Nightly
2 years ago
c909aaea13
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/25919 : Move UpdateFirstFrameDrawn to RecyclerView.onLayoutCompleted
...
As part of a preventitive measure for home page regression loading, we
fixed the UpdateFirstFrameDrawn call to happen after the first layout in
the main RecyclerView is completed. In addition, we also make pocket
aware of this flag so that it renders itself after the first layout.
This helps prioritize current & future features that are visible first
to render before those that are off screen.
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2 years ago
085a3e4af1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26555 - Observe and update the wallpaper before HomeScreen is visible.
...
By using Store.observeManually in a standalone coroutine we can observe the
store and update the wallpapers even before onStart (in manual tests is right
around onStart, certainly before the other widgets shown on homescreen).
Created a new WallpapersObserver to have the functionality easier to reason
about and be easier to test.
2 years ago
73e0b0332c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26693 - Use a new ID for onboarding_home_sync_title
2 years ago
a1a75ee8d4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26511 : load homescreen wallpaper in blocking coroutine
2 years ago
963c40184a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26489 - Add synced tab pickup onboarding message
2 years ago
fe2b4659c3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26227 : Clean up double exclamation operator in BrowserState
2 years ago
1b01210e75
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/26666 : Use correct content scale when displaying recent tab thumbnail and icon
2 years ago
0bda21b782
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21702 : Update host name check in add login
...
Co-Authored-By: joaopmatos <89925580+joaopmatos@users.noreply.github.com>
2 years ago
ce51ec73f8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26190 - Update jump back in cfr logic and message
2 years ago
9dd3c5d4c5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26608 - Update recent bookmarks homepage title
2 years ago
ca9d35f3f7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26169 - MR Home Onboarding Dialog for upgrading users
2 years ago
2cfbe09dbf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26224 - TCP CFR telemetry
2 years ago
8a60292015
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26224 - Use the mr2022.sectionsEnabled.tcp-cfr Nimbus feature to display the cfr
2 years ago
d6967d5ef7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26224 - New TCP CFR popup
...
If Total Cookie Protection is enabled when first accessing a normal tab
(not a custom tab) a new Contextual Feature Recommendation popup will be shown
informing about the added protection and allowing the user to open a support
page with more data about the new option for privacy protection.
2 years ago
38d0eb7a9a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18175 - Add telemetry for cookies option in custom ETP.
2 years ago
733dce16d6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18175 - Add a new total protection ETP cookies policy
...
This should only add the new option in settings based on a Nimbus experiment.
2 years ago
43b99bb586
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26620 - Replace the onboarding nimbus feature with MR2022 nimbus feature
2 years ago
aa78456c88
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26604 - Add missing preview to RecentTabs
2 years ago
ba5f96e680
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26556 - Add skr and tok native/English display names
2 years ago
32710f8101
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26584 - Add vertical offset support to the CFR composable.
2 years ago
262a2128f3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26584 - Add support to align the CFR composable inside a wider anchor
...
Supported anchorings will now be:
- INDICATOR_CENTERED_IN_ANCHOR - previous functionality - allows to have the
indicator point to exactly the middle of a smaller anchor.
- BODY_TO_ANCHOR_CENTER - new default - allows to align the popup inside a
wider anchor
- BODY_TO_ANCHOR_START - new anchoring - allows to align the popup flushed to
it's anchor's start.
2 years ago
35e715b06b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26605 - Clean up RecentTabViewHolder
2 years ago
541a48765b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26400 - Add long-press option to remove tab pickup on homescreen
2 years ago
d14f0e2b6e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26398 - Filter recent synced tabs using the homescreen blocklist
2 years ago
f98b9275da
[fenix] Add updated wallpaper use cases and activate them with feature flag.
2 years ago
0b1667df4b
[fenix] Add updated downloader and file manager
2 years ago
af25894e05
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/26072 : Don't show sync menu item until account manager is available
2 years ago
4daac14987
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26587 - Replace the color in DefaultImagePlaceholder with FirefoxTheme layer2
2 years ago
d808fc60d8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26587 - Fix broken previews using Fenix Image composable
2 years ago
f3f2fadd82
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26399 - Use a list of tabs for recent synced tabs success state
2 years ago
2f6c7c49cf
[fenix] Closes https://github.com/mozilla-mobile/fenix/pull/26530 : add top spacing to header in history list
2 years ago
0cf87d567f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26549 - Add Nimbus feature flag for first run onboarding page updates and Jump back in CFR
2 years ago
133599cbd0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26545 - Update the indicator and the close button of the CFR composable.
2 years ago
622084bad1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26380 - Wait in tests until telemetry is recorded.
2 years ago
b8ee63d226
[fenix] Revert "Closes https://github.com/mozilla-mobile/fenix/issues/25967 : add classes to support multiple viewHolders"
...
This reverts commit 88f0b1962495247959a687f6c403e1e54b4946db.
2 years ago
8e05fb3d63
[fenix] Revert "Closes https://github.com/mozilla-mobile/fenix/issues/24307 : add synced history empty fragment, feature flag and history screen showing only local files
2 years ago
dbb01910ad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26528 - Add a nimbus feature flag for MR Home Onboarding Dialog
2 years ago
5c597031e3
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26502 : add isLocal parameter for history openItem telemetry event
2 years ago
0f62f360ed
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26517 - Create wallpaper v2 feature flag
2 years ago
278a5bbf30
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26423 : add wallpaper metadata fetcher
2 years ago
7e3ede1d3f
[fenix] No issue: Remove code to generate tab group size metrics
2 years ago
adbce1a881
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26335 : Enable sponsored shortcuts by default
2 years ago
c1700709e3
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/26495 : Move Huawei checks to ManufacturerCodes
2 years ago
702aeda47b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26423 : simplify wallpaper types to single data class
2 years ago
c6a17a7883
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/26124 : recent synced tab will use preview image URLs from history
2 years ago
d609299323
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25985 : Remove ability to click the logo to change the wallpaper
2 years ago
5819e532a9
[fenix] Revert "Closes https://github.com/mozilla-mobile/fenix/issues/25942 : use HistoryFragment to show synced history"
...
This reverts commit 4fe9e31ee83b9aa1469fca38459f725971aa92d4.
2 years ago
37acc283c7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26414 - Have the Pocket spocs feature as part of the homescreen sections experiments
2 years ago
7d6c0d1eaf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26421 - Extract synced tabs into it's own viewholder
2 years ago
f6fc1a45d1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26037 : Open shared FireFox tab from another device in Firefox browser
...
This fix will allow the tab that's being shared from a device to open in FireFox browser in the device that receives the tab, even if another browser is set as default in the destination device.
Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
2 years ago
d6a0336b23
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/26150 : Do not show sync tabs in home when sync open tabs setting is disabled
2 years ago
5bceed7dbd
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/26446 : add wallpaper oboarding Nimbus flag
2 years ago
2e5537d9a5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26412 - Remove try catch for NimbusFeatureException from FxNimbus value() getter
2 years ago
dcfcb4dcf5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26308 - Add feature flag for MR onboarding
2 years ago
d0e5ddc6bd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25602 : Lowercase search engine id when recording telemetry
2 years ago
40155f3557
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26115 - Change homescreen Show all button color according to wallpaper
2 years ago
367678cad4
[fenix] change name for isFirstRun to isFirstNimbusRun and move setter to after experiments are set
2 years ago
028c519532
[fenix] update isFirstRun to be manually set and set experiments locally on first run
2 years ago
346427f73a
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/26245 : refactor the WallpaperManager as several WallpaperUseCases
2 years ago
4ee1f0ea64
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/26041 : Remove un-needed Nimbus workaround
...
This workaround was temporary and is not needed with the Nimbus groovy
plugin updates in Android Components.
2 years ago
40509a528e
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/26198 : Add debounce to account manager syncs
2 years ago
6e6d1a658b
[fenix] Add "manage account and devices" button to home menu in mozillaonline builds
2 years ago
33b3f324ac
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22558 - Fix private theme bug in Tabs Tray
2 years ago
85578e498c
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/26041 : Re-set TrackingProtectionPolicy after Nimbus SDK is initialized
...
There are three issues here that we have uncovered while investigating
this bug:
1. Settings.kt has a lazy block around `enabledTotalCookieProtection`
which ends up caching the first result it evaluates.
3. The `FeatureHolder` within FxNimbus caches the incorrectly
evaluated value and returns this value hence forth.
4. Nimbus is not ready to return a result for an engine experiment
when we need it early on in the dependency tree initialization.
There are multiple systems that require engine to be initialized for
them to work (e.g. Glean, Profiler, concept-fetch). In our TCP,
experiment, we need to apply these engine settings during the engine
initialization. So when we try and evaluate Nimbus that early on, it
has not had time to initialize itself correctly or even use the
engine's concept-fetch client to return the correct experiment result.
This bug is made worse because of the first two caching bugs where we
are always holding onto a cached value of the wrong result.
Our temporary solution is to:
1. Remove the `lazy` around `Settings.enabledTotalCookieProtection`.
2. Set the `FxNimbus.api` value right after we are done initializing
`FxNimbus` and `NimbusApi` so that all future queries to FxNimbus
will be made against a real instance of `NimbusApi`. This is a
short-term fix for the `FeatureHolder` caching bug.
3. Set a new TrackingProtectionPolicy that will evaluate Nimbus now
that it is in the correct state when receive the
`NimbusInterface.Observer.onUpdatesApplied`.
Co-authored-by: jhugman <jhugman@users.noreply.github.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2 years ago
4bc96a5e10
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/26377 : re-open already opened recent synced tabs
2 years ago
9968708352
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26289 - Remove search term tab groups metrics and setting
2 years ago
b03ec61ff5
[fenix] Move startup perf measurements to a background thread
...
This is required to avoid loading the Glean core library (provided by libxul) early on.
Fenix needs to do the time measurement itself for now.
2 years ago
26a8f7a155
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26236 : Fix breaking change from AC regarding exitImmersiveModeIfNeeded
...
This will allow Fenix to use the refactored method name 'exitImmersiveMode' in Activity from Android Components library
Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
2 years ago
f55ce61747
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26227 - Remove search term tab groups from Jump Back In
2 years ago
848b8b583d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26172 - New CFR popup composable
...
This will allow for pinpoint accuracy when anchoring and resolve any color
disparities between the popup body and the indicator arrow by having everything
drawn programmatically as one shape.
Because of the async nature of the values for insets and screen rotation
immediately after an orientation change the popup will automatically get
dismissed to prevent any anchoring issues.
While not ideal the effect of this is better than accepting layout issues after
orientation changes and is the same approach used for other of our popups.
2 years ago
c763a8a42e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26239 - Avoid displaying multiple download items for the same file
2 years ago
82e302717e
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/26227 - Remove search term tab groups from Jump Back In"
...
This reverts commit f4e09ba3f2d6a530e8a39a0e18d15fefceb6ee6a.
2 years ago
aed096a6a0
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/26227 - Remove search term tab groups from Recently Visited"
...
This reverts commit e0617080ec0e28b74a2cd8ca1f9b94a521ba17ac.
2 years ago
17d8116525
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26283 : Use message buttonLabel in MessageCard.
2 years ago
35b2c39f0e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26227 - Remove search term tab groups from Recently Visited
2 years ago
c98cdcf0b3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26227 - Remove search term tab groups from Jump Back In
2 years ago
35093573e5
[fenix] Fixes: https://github.com/mozilla-mobile/fenix/issues/26052 remove WallpaperManager::updateWallpaper
2 years ago
a3008766c0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25837 - Invalidate cached nimbusValidation values when changing locale settings
2 years ago
c854e54f03
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/26029 : Add wallpaper state to AppStore
2 years ago
d2ac452fa4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26221 - Use favicon instead of ic_globe for composed tab grid item
2 years ago
6b6223fbd7
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/25942 : use HistoryFragment to show synced history
2 years ago
fe505d58ad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26061 : Make sure favicons are cropped correctly
2 years ago
faef97dad4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26197 : Cancel history list update on fragment destroyed.
2 years ago
739a23b889
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/26101 : add telementry for deleting history time range
2 years ago
34b70ffc9a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22692 : Remove Metropolis font.
2 years ago
76fe8e2d4f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25891 - Move GridViewHolder to compose
2 years ago
21f190b965
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26026 - Refactor the FenixTabCounterMenu creation from HomeFragment to TabCounterBuilder
2 years ago
458537c50e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26089 - Record metrics for save credit card prompt shown
2 years ago
08a57223b6
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/25954 : add a new delete time range confirmation dialog for history screen
2 years ago
f6499a9a2f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/26113 ⁃ Enable address autofill in all channels
2 years ago
205f6cea89
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/26050 : show jump back in when only synced tab available
2 years ago
4f3fe06977
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21898 - Remove search term tab groups from the Tabs Tray
2 years ago
6fb4fc6c8d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22186 - Scroll to collection after creating one
2 years ago
8a24872992
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25894 - Add firefox suggest header for lib suggestions
2 years ago
c12b34a5e6
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/25967 : add classes to support multiple viewHolders
2 years ago
0d61a44d87
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/25955 : refactor RecentSyncedTabsFeature to use SyncStore
2 years ago
4a2fa6be25
[fenix] No issue: remove unused inactive tab auto close dialog controller
2 years ago
7660235e97
[fenix] Fixes 24823: remove recent synced tab when logged out
2 years ago
fb4f6729b7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25994 : Make installToHomescreen item a collapsing menu limit.
...
The item is visible instead of addToHomeScreenItem when
current session can be installed as a PWA.
2 years ago
c1a3625559
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/25982 : Fix check between current and new when adding a bookmark
2 years ago
09349c9496
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25829 - String updates for Sync
2 years ago
9c921c5eb8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25938 : Address MessageCard text not adapting to the dark theme
2 years ago
597aac0c72
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25915 : Remove the hard coded default browser message
2 years ago
6f074ed4b8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25935 - Catch NimbusFeatureException from calling FxNimbus value getter
2 years ago
e0864dda85
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25933 - Ensure sponsored tiles are enable if enrolled in active experiment
2 years ago
3c58b8e405
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25736 : Add experiment for Total cookie protection.
2 years ago
84ddaab605
[fenix] Disable marketing telemetry until privacy pop window approved in Mozillaonline builds
2 years ago
6260f3fc24
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25846 : Save the City field in addresses.
2 years ago
ae62eb26cb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24528 - Remove isPrivate conditional in getTheme in favor of inComposePreview
2 years ago
f00965969a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/25805 : Always anchored unified search menu to the toolbar icon
2 years ago
751f097c0a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25815 : Fix interactor calls for address management.
2 years ago
9e08ecfb89
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25764 - Prevent sponsored shortcut URLs from appearing as `frecent` shortcuts
2 years ago
0c972d3ae9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25401 - Record Pocket sponsored stories telemetry
2 years ago
82003c9071
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25401 - Improve how sponsored stories impressions are reported
...
While testing I observed that the Rect returned from `boundsInWindow()`
- will have the full height and width of the composable even if scrolled
offscreen vertically
- will only have the height and width of what part of the composable is shown
pn the screen.
Possibly because of the interactions of a vertically scrollable RecyclerView
and the LazyRow the composable is shown in.
To account for this the method calculating how much of the composable is shown
on screen will also now receive the real composable size as an argument.
2 years ago
5edcbb7f73
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25538 - Add "metrics" telemetry for if default wallpaper is shown
2 years ago
8c48cca825
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25538 - Add a simple way to check if the default wallpaper is to be shown
...
A previous check for whether the persisted name of the current wallpaper is
empty made checking whether the default wallpaper is to be shown brittle.
Instead of duplicating such a check in multiple places it is now extracted in
one method that can be used in multiple places including the new telemetry.
2 years ago
9b6fd9047d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25213 : Add tabs prioritization experiment
2 years ago
e05daef826
[fenix] No issue: Add number_of_app_launches custom attribute to nimbus messages.
2 years ago
4fe2ec1188
[fenix] Fixed PR review
2 years ago
6294425de6
[fenix] Lint fixes
2 years ago
5e2ee0ae2e
[fenix] Added profiler option to SettingsFragment
2 years ago
48d2188d8c
[fenix] Added ProfilerUtils
2 years ago
e6fa624820
[fenix] Added ProfilerReusableComposable
2 years ago
3d528fa2dd
[fenix] Added ProfilerStopDialogFragment
2 years ago
bc4f52ed63
[fenix] Added ProfilerStartDialogFragment.
2 years ago
27fbf6437c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14854 : Added ProfilerViewModel
2 years ago
74fdb5243a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24967 - Enable address autofill for Nightly and Debug
2 years ago
374ce89abb
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/25545 : wait to draw Pocket until after first frame
2 years ago
c80ac7102a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21894 : Move Tabs Tray to compose: Individual tab viewholders: ListViewHolder.
2 years ago
0ab70f4511
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24857 : Add metrics for addresses autofill.
2 years ago
32d204199c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25750 - Use Headline7 for the expandable list headers that appear in cards
2 years ago
86f589a826
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25750 - Change Headline8 to 14dp
2 years ago
4921a85a24
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25658 - Track the site permissions prompt and user actions
...
Track when the prompt is shown and when the permissions are allowed/denied.
2 years ago
b4fc097cd5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25721 - Remove 'Daylight' from the 'About Firefox' screen
2 years ago
56d367f4fd
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/24740 : Use unified search bar in bookmark search
2 years ago
143d60ebac
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25491 - Refactor InactiveTabs interactors and controllers
2 years ago
6fead550b8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25708 - Change Credit Card preference label to Autofill when address autofill is enabled
2 years ago
81d31cfac8
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/24740 : Use unified search bar in history search
2 years ago
0e5c90103c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23966 - Migrate MessageCardViewHolder to Compose
2 years ago
99fcb7d4d8
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/25622 - PromptFeature use LoginDelegate and CreditCardDelegate as parameters for login and credit card pickers
2 years ago
2b3e9ce6b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25183 - Update the Sentry base URL
...
Update the Sentry base URL to use the new instance
2 years ago
84d848d10f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25435 : Handle ERROR_BAD_HSTS_CERT error.
2 years ago
2e2a86fc32
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25586 - Allow for localized sumo links for the https-only mode
2 years ago
0aff519ba1
[fenix] Adding support for app-services error reporting
2 years ago
7cb57f1b9a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25446 : Ensure for every message shown we have recordExposure
2 years ago
1e3024e560
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24969 - Display address autofill prompt
2 years ago
e3ada9fdea
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25586 - Update HTTPs-only setting sumo link
2 years ago
505fe654c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25490 - Remove PrimaryText and SecondaryText
2 years ago
773326121e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25381 - Add a setting allowing to toggle Pocket sponsored stories
2 years ago
b762e8dcdd
[fenix] Upgrade to Glean v50 and adopt new Glean APIs
2 years ago
de09d907cb
[fenix] for https://github.com/mozilla-mobile/fenix/issues/25545 : turn off task continuity in nightly
2 years ago
2efa6cca39
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25413 : App should not be locked in landscape when a tab or custom tab loads while in pip mode
...
App should not be locked in landscape while in pip mode when a tab or custom tab loads
Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
2 years ago
6318ed91bc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25563 : Avoid showing delete all dialog twice.
2 years ago
48a1fbb3a5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25563 : Ensure popBackStack does not navigate away from HistoryFragment.
2 years ago
3d169a733d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25563 : Show Snackbar only if fragment is still attached.
2 years ago
91153193ac
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24744 - Observe and update selector icon while the View is attached
...
This avoids having to pass another LifecycleOwner from outside and will ensure
the View is update only in the bounds of it being attached.
The observe-update code is moved to bind(..) as that seems like a more
idiomatic callback for updating an already constructed View rather than
createView() which should only create and return a View.
2 years ago
d1c8951434
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/24522 : Add telemetry for unified search
2 years ago
80f38dba6f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25455 : Let A-C handle toolbar expanding when URL changes
...
This fix allows the toolbar to be visible after the user clicks on a link and scrolls
Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
2 years ago
8b7799a3fe
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/pull/24455 - Migrate NoCollectionsMessageViewHolder to Compose"
...
This reverts commit eb9d1a88
2 years ago
71c77e3e6d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21897 - Convert inactive tabs to compose
2 years ago
24e65e06d0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25505 : Clear the stored result in case there is no listener with the same key set.
...
This is the case when the sharing happens outside the tabs tray.
2 years ago
e255de64bc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20848 - Hide Download List delete icon in multiselect mode
2 years ago
7cfdab86d8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25379 - Plug FenixTypography into ListItem, Button, TextButton, and ExpandableListHeader
2 years ago
Gabriel Luong
MatthewTighe
Pg
mike a
sarah541
mavduevskiy
Mugurell
Alexandru2909
mcarare
Christian Sadilek
Roger Yang
Arturo Mejia
Noah Bond
Ben Dean-Kawamura
Jonathan Almeida
Bryan Olsson
sunilk9211
indu
Charlie Humphreys
rxu
Jan-Erik Rediger
Alexandru2909
Marc Leclair
Michael Comella
CHAN, Chak Shing
Jan-Erik Rediger