Commit Graph

5120 Commits (516eb62a765949b16d6d58d94d585e8adfee8b9b)

Author SHA1 Message Date
Alexandru2909 deb08fe581 [fenix] Bug 1808665 - Record toolbar_menu_visible event 2 years ago
MatthewTighe e84f0ee969 [fenix] For https://github.com/mozilla-mobile/fenix/issues/28428: update growth data with new events 2 years ago
Arturo Mejia 31e1a8f34d [fenix] Bug 1797593 - Add re-engagement dialog for cookie banners. 2 years ago
Harrison Oglesby 622908254e [fenix] For https://github.com/mozilla-mobile/fenix/issues/28201 - replace existing night mode preview annotations with LightDarkPreview annotation 2 years ago
Harrison Oglesby e1240855a8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/28201 - Make a LightDarkPreview annotation
Add LightDarkPreview annotation
2 years ago
Noah Bond da02a54f84 [fenix] For https://github.com/mozilla-mobile/fenix/issues/28262 - Refactor InactiveTabsAutoCloseDialogInteractor into InactiveTabsInteractor 2 years ago
Noah Bond 5a507fbb92 [fenix] For https://github.com/mozilla-mobile/fenix/issues/28261 - Rename solo `xInteractor` parameters in the Tabs Tray to `interactor` 2 years ago
rahulsainani d760e57572 [fenix] Closes 28414: NotificationManagerCompat extension to safely check if notifications are enabled 2 years ago
Alexandru2909 03493f4eaf [fenix] Bug 1807727 - Dismiss SearchDialogFragment on editing cancelled 2 years ago
mcarare e7f5d43524 [fenix] Switch to AC implementation for checking device manufacturer. 2 years ago
sunil9211 9aefc0d2a8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23841: Hide keyboard when selecting month or year 2 years ago
sarah541 2c87c3148d [fenix] For https://github.com/mozilla-mobile/fenix/issues/27035 - Add padding around onboarding buttons and content 2 years ago
Alexandru2909 bc8c302026 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25812 - Set the cursor at the end for search terms when switching to toolbar editMode. 2 years ago
Arturo Mejia 7099698afa [fenix] Bug 1796146 - Add learn more link to cookie banner handling settings page 2 years ago
Jeff Boek 895858acf3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3722: Invoke search on long press home button
Co-authored-by: s-ankur <s.ankursonawane@gmail.com>
2 years ago
kycn c364bdd90a [fenix] Bug 1807933 - Enable places storage maintenance feature for the Beta variant.
Places storage maintenance flag is enabled for the Beta variant, previously it was enabled only for Nightly variant. This feature registers a periodic storage maintenance worker that runs to prune and maintain places db.
2 years ago
Zac McKenney c3250f583f [fenix] For bug 1807716: Move engine warmup above Glean initialization to fix crash at launch 2 years ago
DreVla 36fdadac25 [fenix] For https://github.com/mozilla-mobile/fenix/issues/28298: Disable deletion of last element in search engines list
When removing search engines from settings,
the option to delete the last one should not be
available
2 years ago
Mugurell 14875c6129 [fenix] For https://github.com/mozilla-mobile/fenix/issues/28273 - Configure search with the selected search engine before user searching 2 years ago
Alexandru2909 acf1bf3ace [fenix] For https://github.com/mozilla-mobile/fenix/issues/26957 - Allow SearchDialogFragment to be dismissed on homescreen swipe 2 years ago
rahulsainani 7886ec7d7b [fenix] Bug 1796319 - Select existing addon settings tab if already opened 2 years ago
Arturo Mejia 3b80442c40 [fenix] Bug 1804383 - Save as PDF text is missing in Private Mode 2 years ago
sarah541 ef7c0e0fdf [fenix] Bug 1800700 - Add default search suggest header 2 years ago
Alexandru2909 940bf3f353 [fenix] For https://github.com/mozilla-mobile/fenix/issues/28155 - Show search terms in address bar for both edit and display modes 2 years ago
DreVla 7a421d6c05 [fenix] For https://github.com/mozilla-mobile/fenix/issues/27697 - Load icon for unified search engine immediately.
The engine icon was set after the screen was visible leading to a delay.
With this solution, the icon will be set before the screen is visible
eliminating any visible artefacts.
2 years ago
DreVla d3c587635a [fenix] For https://github.com/mozilla-mobile/fenix/issues/27697 - Load icon for browser and history search immediately.
The icon was set after the screen was visible leading to a flicker.
With this solution, the icon will be set before the screen is visible
eliminating any visible artefacts.
2 years ago
DreVla 6794095b5f [fenix] For https://github.com/mozilla-mobile/fenix/issues/28013 - Display correct hint for topic specific search engine
Since the search engines are split into two categories, general and
topic specific, the hint for each category is different.
2 years ago
DreVla c15d2a93b7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/28090: Show QR scanner when general or custom search engine is selected 2 years ago
mike a 960ad784e3 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/28205: fix ripple position over unified search icon 2 years ago
Abdul Basit 3caffd30f4 [fenix] Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/26733 Language search doesn't reset to full list view anymore 2 years ago
Arturo Mejia d36b1b48be [fenix] Bug 1797577 - Clear site data when turning off cookie banner handling. 2 years ago
Alexandru Putanu d05393714a [fenix] For https://github.com/mozilla-mobile/fenix/issues/26957 - Exit search dialog when interacting with home fragment (https://github.com/mozilla-mobile/fenix/pull/27262)
* Revert "For https://github.com/mozilla-mobile/fenix/issues/26790 - Dismiss search dialog when opening recent bookmark dropdown menu"

This reverts commit 5caee27b5530517d88e8a3212a3318f1ed75fba7.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/26790 - Dismiss search dialog when opening recent visit dropdown menu"

This reverts commit b2af04c9

* Revert "For https://github.com/mozilla-mobile/fenix/issues/26790 - Dismiss search dialog when opening recent tab dropdown menu"

This reverts commit bfdf6d202133e31930c1eeb24ff60b7035479653.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/26690 - Dismiss search dialog when opening recent synced tab dropdown menu"

This reverts commit 86d44a46122eafb8bfb7df9cb2f182337cc47aa4.

* For https://github.com/mozilla-mobile/fenix/issues/26957 - Remove code to dismiss search dialog when interacting with homescreen top sites

* For https://github.com/mozilla-mobile/fenix/issues/26957 - Remove code to dismiss search dialog when interacting with homescreen collection

* For https://github.com/mozilla-mobile/fenix/issues/26957 - Remove code to dismiss search dialog when interacting with homescreen recent visits

* For https://github.com/mozilla-mobile/fenix/issues/26957 - Remove code to dismiss search dialog when interacting with homescreen recent tabs

* For https://github.com/mozilla-mobile/fenix/issues/26957 - Remove code to dismiss search dialog when interacting with homescreen recent bookmarks

* For https://github.com/mozilla-mobile/fenix/issues/26957 - Remove code to dismiss search dialog when interacting with pocket stories

* For https://github.com/mozilla-mobile/fenix/issues/26957 - Dismiss search dialog when interacting with home fragment

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 years ago
Arturo Mejia 4280864031 [fenix] No issue: Update Cookie banner handling strings 2 years ago
rahulsainani dcf71a1719 [fenix] Bug 1804690 - Allow emulator to access network of the host machine sidestepping the TLS error on debug channel 2 years ago
Noah Bond d0ba8373c1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/28133 - Fix Pocket story category color mismatch 2 years ago
Arturo Mejia 9be14b069c [fenix] Bug 1797577 - Add cookie banner handling panel to the toolbar. 2 years ago
Mugurell 696f7e3690 [fenix] Bug 1804544 - Disable TCP by default in beta and release 2 years ago
DreVla 89ce37541b [fenix] For https://github.com/mozilla-mobile/fenix/issues/15348: Voice search option appears for all search engines
Voice search was restricted only for google, with the condition removed
it should appear now for all search engines
2 years ago
Zac McKenney aed86b9d30 [fenix] Bug 1804107 - Fix for BaseBrowserFragment toolbar getter null crash and invalidating actions when modifying toolbar 2 years ago
Jonathan Almeida b4b031b8b6 [fenix] Bug 1799996 - Speculative fix checks CFRPopup.anchor is attached to window
We're seeing crashes in the Fenix copy of the `CFRPopup` that are
happening when our activity has already been destroyed, and then we are
trying to add a view to it with the WindowManager.

Our guess from looking at the traces are that the
`BrowserToolbarCFRPresenter` is receiving the `collect call on the main
thread, but further down the event loop. As well as the Runnable in
`CFRPopup#show` that is posting to the end event loop - both of these
calls are putting us in a state where the activity we want has already
been destroyed before we get to the moment where we want to use it.

This is a crash that is difficult to synthesize or write a test for.
As a result, our fix is rather speculative but still straight-forward
and safe to uplift, should it work.

There are three remaining follow-ups to do when fix is confirmed:
1. There is a CFRPopup that was upstreamed which is based on the Fenix
   implementation. We should upstream this patch to that component as
   well.
2. We should remove this copy of the CFRPopup and use the upstreamed
   version to avoid confusion between the two copies.
3. With this change, we are now gracefully failing when our users get
   into this state, however our telemtry and onboarding flows are
   unaware that the CFR was never shown.
   We need to to correct telemetry for `TrackingProtection.tcpCfrShown`
   to stop incorrectly reporting false positives and reset our
   `shouldShowTotalCookieProtectionCFR` pref to false so that we can
   try again at the appropriate time.

Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2 years ago
Roger Yang 067b73eeca [fenix] Close https://github.com/mozilla-mobile/fenix/issues/27949: Add Nimbus exposure event for re-engagement notification 2 years ago
priyanka0906 37307db791 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7924 - added an undo snackbar when a pinned site is removed 2 years ago
Alexandru2909 6f8dbbcc3c [fenix] For https://github.com/mozilla-mobile/fenix/issues/22770 - Use String.toShortUrl from A-C 2 years ago
DreVla 2cba38ea4c [fenix] For https://github.com/mozilla-mobile/fenix/issues/27753 - Update search engines immediately after changing system language 2 years ago
DreVla 910948fac0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/27753 - Update search engines immediately after changing language 2 years ago
Madalin Valceleanu f80ed71b1b [fenix] Fixed link from clipboard open up from same URL on every new tab https://github.com/mozilla-mobile/fenix/issues/15588 2 years ago
Jeff Boek 73918171ba [fenix] For mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/17904 - Increases tap area on the add shortcut button 2 years ago
Zac McKenney a9631f62ab [fenix] For https://github.com/mozilla-mobile/fenix/issues/27540: Add screen size configuration change handling 2 years ago
Rahul Sainani 092a79a195 [fenix] For mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/26736 - fix username validation error state (https://github.com/mozilla-mobile/fenix/pull/28017) 2 years ago
Roger Yang 125be804f5 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/28021: Add ability to opt in to receiving push notifications on Android 13+ devices 2 years ago