2
0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-19 09:25:34 +00:00
Commit Graph

3565 Commits

Author SHA1 Message Date
mcarare
177baf58a8 For #9798: Disable buttons on hiding and enable on showing.
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
2020-04-09 16:06:11 -07:00
Simon Chae
de311aef85
Update not yet unavailable add-on string (#9677) 2020-04-09 15:25:08 -04:00
Roger Yang
c9141c9ae5 Close #9827: Support display cutouts 2020-04-09 10:13:37 -07:00
Christian Sadilek
7f1ef17d8b No issue: Re-use existing usecases for addons 2020-04-09 12:53:47 -04:00
ekager
56eb2ec1d7 For #2818 - Adds Picture-in-Picture feature 2020-04-09 08:56:48 -07:00
Mozilla L10n Automation Bot
ed466d34f7 Import l10n. 2020-04-09 08:20:41 +03:00
Michael Comella
4437ddd536 No issue: Move Do and OpenClass to utils pkg.
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
2020-04-08 12:39:22 -07:00
mcarare
413af92bc5 For #9797: Set min height of dialog edit text to 48dp. 2020-04-08 10:12:20 -04:00
Abhay Agarwal
1c65bb8255 Closes #9495: Dismiss the ShareFragment in onPause() 2020-04-08 13:10:37 +03:00
Sawyer Blatz
12d486bf02
Issue #9682: Reduces size of branding (#9784) 2020-04-07 14:05:07 -07:00
Christian Sadilek
0f1bff7402 No issue: Refactor readerview to use browser-state 2020-04-07 16:31:03 -04:00
Sawyer Blatz
e94af334fc
No issue: Add more settings animations (#9750) 2020-04-07 10:44:23 -07:00
Mihai Eduard Badea
d66da53c9a For #2768 - Prevent screenshots in private mode
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
2020-04-07 17:23:06 +03:00
Mugurell
29539c458e For #9770 - Disable pull to refresh pending changes 2020-04-07 17:06:43 +03:00
Mozilla L10n Automation Bot
a12cb5b0c3 Import l10n. 2020-04-07 10:30:26 +03:00
Michael Comella
9305331a56 For #9631: remove assertk dependency. 2020-04-06 16:56:40 -07:00
Michael Comella
376740cd2c For #9631: replace assertk assertions with junit.
I created a series of editor macros to do this with minimal errors (and
to do it quickly!).
2020-04-06 16:56:40 -07:00
Jeff Boek
c632b93ee7
For #220 - Removes feature flag for language picker (#9191)
* For #220 - Removes feature flag for language picker

* For #220 - Updates Android Components
2020-04-06 14:29:52 -07:00
Mihai Adrian
dfded8e69c
For #9687: Refactor onboarding cards to follow app architecture (#9743)
* For #9687: Refactor onboarding cards to follow app architecture

* For #9687: Update unit test to new controller parameters
2020-04-06 11:00:47 -07:00
Arturo Mejia
025656d8fd For issue #9647 Crash when tapping settings after quickly
enabling/disabling add-on
2020-04-06 13:47:21 -04:00
Michael Droettboom
3789f50423 Fix errors in top_sites_count metric
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.

[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
2020-04-06 10:34:52 -07:00
Mozilla L10n Automation Bot
2d55b07935 Import l10n. 2020-04-06 12:20:41 +03:00
mcarare
cac8115e55 For #9663: Allow more than one line for onboarding card header 2020-04-03 17:47:11 -07:00
Mozilla L10n Automation Bot
9e470c93ca Import l10n. 2020-04-03 17:38:26 -07:00
Aaron Train
b35704beed Closes #9688: Disable ReaderViewTest for intermittent investigation in detection issues 2020-04-03 22:04:43 +03:00
Oana Horvath
b2da0bd922
For #9670: Disabled intermittent tabMediaControlButton test (#9679)
and removed file created by mistake -e

added reason for disabled tests
2020-04-03 20:39:33 +03:00
Mugurell
904bfc9ebe For #3262 - Enable pull down to refresh in Nightly 2020-04-03 19:40:08 +03:00
Michael Comella
51a76651d6 For #9605 - review: clarify comments in new test runner. 2020-04-03 09:27:49 -07:00
Michael Comella
b60a21c08d For #9605: Add LintUnitTestRunner gradle task.
This will prevent us from regressing on adding older versions of the
unit test runner.
2020-04-03 09:27:49 -07:00
Michael Comella
efef8eaba0 For #9605: TestApplication -> FenixRobolectricTestApplication.
This disambiguates it from the FirefoxTestApplication used in on-device
tests.
2020-04-03 09:27:49 -07:00
Michael Comella
8df49473c0 For #9605: move TestApplication to the helpers package.
The helpers/ package is created to separate the test support code from
the code under test.
2020-04-03 09:27:49 -07:00
Michael Comella
6e0d851da3 For #9605: replace unit test runners with FenixRobolectricTestRunner.
This is how we can apply the new test runner to remove duplication.

This commit was generated programmatically with the following commands:
```
  // Replace test runners with new one.
  find app/src/test -type f -exec gsed -i "s/@RunWith(RobolectricTestRunner::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
  find app/src/test -type f -exec gsed -i "s/@RunWith(AndroidJUnit4::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +

  // Replace imports of old test runners with new one
  find app/src/test -type f -exec gsed -i "s/org.robolectric.RobolectricTestRunner/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
  find app/src/test -type f -exec gsed -i "s/androidx.test.ext.junit.runners.AndroidJUnit4/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +

  // Remove unused imports
  find app/src/test -type f -exec gsed -i "/@Config(application = TestApplication::class)/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.mozilla.fenix.TestApplication/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.robolectric.annotation.Config/d" {} +
```

Where gsed is the GNU version of sed installed via homebrew. After
running these commands, I need to manually clean up the following files:
- FenixRobolectricTestRunner
- LocaleManagerExtensionTest
2020-04-03 09:27:49 -07:00
Michael Comella
b0cfa3ee5c For #9605: add FenixRobolectricTestRunner.
This class will help us reduce duplication by specifying the
configuration within the test runner rather than each test needing to
specify it itself.

This class is adapted from Firefox for Fire TV:
  https://github.com/mozilla-mobile/firefox-tv/blob/master/app/src/test/java/org/mozilla/tv/firefox/helpers/FirefoxRobolectricTestRunner.kt
2020-04-03 09:27:49 -07:00
Michael Comella
392dda5eda For #9605: remove unnecessary @RunWith(Robolectric in unit tests.
robolectric increases the run time of tests so it's important to remove
them when they're unnecessary.

Between this change and the last one, the unit test runtime was reduced
by ~10s.
2020-04-03 09:27:49 -07:00
Michael Comella
f2acef66b5 For #9605: remove unnecessary @RunWith(AndroidJUnit4) in unit tests.
In unit tests, this annotation annotations defer to robolectric, non-trivially
increasing test runtime so it's important to remove them when they're
unnecessary.
2020-04-03 09:27:49 -07:00
Aaron Train
cb009f915c
No issue: re-enable libraryMenuItemsTest and backButtonTest (#9639) 2020-04-03 10:37:03 -04:00
MickeyMoz
f46cfc2ad2 Update Android Components version to 38.0.20200403130109. 2020-04-03 16:15:31 +02:00
Mozilla L10n Automation Bot
8413b8133d Import l10n. 2020-04-03 16:19:33 +03:00
Michael Comella
4a8dc5b54f No issue: add kdoc to HomeActivity.
We could consider renaming the Activity to make it clearer that it's the
main activity and doesn't just feature the homescreen but I'm concerned
that renaming it will break too many things (e.g. automation that starts
a specific activity). For quick fix, I added this comment.
2020-04-02 16:27:00 -07:00
Sawyer Blatz
e3ed7ed268
Issue #9128 & #9222 & #9499: Refactors snackbar creation and fixes placement (#9628) 2020-04-02 12:30:13 -07:00
Codrut Topliceanu
8c43935ba3
For #7978 - Put views above button in scrollView (#8819) 2020-04-02 10:13:32 -07:00
Gabriel Luong
dc6d479da3
For #6174 - Add telemetry for WebExtensions (#8318) 2020-04-02 10:12:31 -07:00
Mihai Adrian
7043f9ee4e
For #9604: Swap and adjust margin with padding to avoid text being cut (#9617) 2020-04-02 09:40:29 -07:00
Michael Comella
c15a005ca8 No issue: remove unused FirefoxTestRunner.
It would be used for on device tests but it doesn't seem to hooked up
currently.
2020-04-02 07:57:09 -07:00
Mozilla L10n Automation Bot
202172cd04 Import l10n. 2020-04-02 13:42:58 +03:00
mcarare
fac61fbb41 For #9422: Nit: Fix xml indenting 2020-04-02 09:11:31 +03:00
mcarare
4d0b37a3b8 For #9422: Align widget text to viewStart to support RTL layouts 2020-04-02 09:11:31 +03:00
Emily Kager
327009efc4
For #768: Add first time PWA dialog (#9308)
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
2020-04-01 22:56:12 -04:00
Sebastian Kaspari
045b4a5715 Use same configuration for "forPerformanceTest" builds like we do for "fennec" flavor builds. 2020-04-01 17:51:32 -07:00
David Walsh
26137f63a2
Prevent favicons from flashing when items are selected in History (#9233) 2020-04-01 15:43:21 -07:00
Mihai Adrian
8cd6d7460c
For #9336 Check current destination before navigating (#9353)
* For #9336 Check current destination before navigating

* For #9336 Update unit test to check for navigateSafe
2020-04-01 15:36:56 -07:00
Mihai Adrian
90787cf630
For #9423: Align preference title and summary to viewStart (#9426)
* For #9423: Align preference title and summary to viewStart

* Update checkbox_left_preference_etp.xml

Co-authored-by: Jeff Boek <jeff@jeffboek.com>
2020-04-01 15:36:01 -07:00
ekager
fd60270da8 For #9533 - Switch to using enum for Library Item Selected Telemetry 2020-04-01 15:29:08 -07:00
Grisha Kruglov
8d3d030feb Closes #9553: Only update account UI state once when creating SettingsFragment 2020-04-01 15:28:39 -07:00
ekager
96c6401457 For #8125 - Send top sites count with metrics ping 2020-04-01 15:27:39 -07:00
mcarare
8c398c86ef For #9365: Partially reverse menu items order when using top toolbar 2020-04-01 15:21:22 -07:00
mcarare
b119700820 For #9365: Update naming to reflect history item 2020-04-01 15:21:22 -07:00
Kate Glazko
cca3dae290 NoIssueFixMetropolisAccountPref 2020-04-01 15:13:03 -07:00
Sawyer Blatz
208a58bc58
Issue #9598 & #8697: Fixes force expand crash (#9599) 2020-04-01 12:32:00 -07:00
codrut.topliceanu
3d1d146c94 For #9549 - Scrolling to top sites now includes header. 2020-04-01 10:28:04 -07:00
mcarare
a2ea53d8f2 For #9574: Remove category layout from LeakCanary SwitchPreference 2020-04-01 10:17:21 -07:00
ekager
4159cd3da7 Closes #9564 : Fixes cut off strings in ETP panel 2020-04-01 10:16:51 -07:00
Mihai Branescu
24596fd3cd For #9109 - remove the sync error highlight from three-dot menu 2020-04-01 10:42:00 +03:00
Kate Glazko
d9d5de98c9 For 3687 Use Metropolis Font for Header 2020-03-31 19:31:15 -07:00
Mozilla L10n Automation Bot
9043120dd7 Import l10n. 2020-03-31 17:52:51 -07:00
Grisha Kruglov
54b7fd8834 Make sure reconnect item is displayed in HomeMenu in case of account problems
AccountObserver listeners were being triggered correctly, however, during every time
we open HomeFragment, home menu gets re-created, which causes us to re-run the initialization
block. Before this patch, the init block would never touch the account manager.
After this patch, it will query it if account manager has already been initialized.
2020-03-31 16:07:35 -07:00
Grisha Kruglov
60943df6d9 Closes #9561: Fix initialization order in HomeMenu
`init` blocks are executed before `val` initialization which is declared afterwards
in the class. In this case, we had `quitItem` and `reconnectToSyncItem` as lazy,
but declared after the `init` block which may need them. And so, while this compiles
just fine, in practice we run into an NPE as the `init` block tries to get the lazy's value.

Simply re-ordering initialization fixes the problem.
2020-03-31 16:07:35 -07:00
Arturo Mejia
804eb0f5ba For issue #8520: Polish Add-on manager UIs 2020-03-31 17:20:20 -04:00
Sawyer Blatz
1a2b65d854
Issue #9472: ForceExpand browser toolbar when navigating (#9552) 2020-03-31 11:16:40 -07:00
Oana Horvath
5f68d6cb29
Updated the method to verify system notifications and added new tests for media notifications (#9330) 2020-03-31 21:11:41 +03:00
ValentinTimisica
cee34893ed
For #8412: Passes error handling function to 'CustomTabWindowFeature' (#8903)
* For #8412: Passes error handling function to 'CustomTabWindowFeature'

Change required for showing error message when the app can't handle a specific
scheme. Implemented in AC:
https://github.com/mozilla-mobile/android-components/pull/6122

* Upgrade AC version

Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2020-03-31 10:17:29 -07:00
Grisha Kruglov
f76acc5db1 Closes #9530: Don't crash on failed avatar fetches 2020-03-31 09:17:17 -07:00
Mozilla L10n Automation Bot
fd263d8329 Import l10n. 2020-03-30 22:00:19 -07:00
Grisha Kruglov
6c38b77315 Part 6: Kick-off account manager initialization after visual completeness
In order to hide the time it takes for the account manager to be initialized
(which always involves disk IO, and often network IO), let's kick it off
after "visual completeness".
This makes sure that for most users, by the time they interact with the account
manager-related functionality (e.g. in Settings), it's ready to go.

Also, for signed-in users, this will establish background sync workers.
2020-03-30 21:43:38 -07:00
Grisha Kruglov
057e28d4e4 Part 5: Refactor HomeMenu<->HomeFragment interaction
This refactor "reverses" relationship between these two classes, allowing
HomeMenu to inform its parent, HomeFragment, of any changes to the menu.

Once that's in place, we start observing account manager changes (once its ready)
for account problems.

This solves two problems:
- initialization of the account manager is no longer necessary to build a home menu
- home menu now starts observing changes to the account manager's state (before it was static)
2020-03-30 21:43:38 -07:00
Grisha Kruglov
029fae4559 Part 4: Make sure 'sync is on' snackbar does not initialize account manager 2020-03-30 21:43:38 -07:00
Grisha Kruglov
eb98df4edd Part 3: Mark accountManager as 'lazy' in Mode.kt
This is enough to cause it to be initialized only if we're going through onboarding.
2020-03-30 21:43:38 -07:00
Grisha Kruglov
3efaa516ca Part 2: Do not eagerly initilize account manager within HomeActivity
Instead of always kicking off accountManager's init and telling it to sync right away in
'onResume', we move these tasks to some abstract point later on, whenever account manager
is available.
2020-03-30 21:43:38 -07:00
Grisha Kruglov
0677fc35de Part 1: Add 'accountManagerReady' queue to BackgroundServices
This gives us an ability to perform tasks against 'accountManager' without
causing its immediate initialization.
2020-03-30 21:43:38 -07:00
Grisha Kruglov
be1fa8df7d Pre: introduce a RunWhenReadyQueue
This replaces the StartupTaskManager we had with a more general class.
New implementation is a thread-safe "gated task executor", which either
runs the task right away if it's marked as 'ready', or queries it to be
executed later on.

This ability to either execute or queue a task will be useful later on in the
commit series.
2020-03-30 21:43:38 -07:00
Aaron Train
4d139d52c4
Closes #9189: Fixes "static asset not found" error in doNotSaveLoginFromPromptTest, saveLoginFromPromptTest UI tests (#9439)
AndroidAssetDispatcher class dispatcher was attempting to open a local asset with a query suffix from the request. If query suffix is found, remove it. Re-enable saveLoginFromPromptTest() and doNotSaveLoginFromPromptTest()
2020-03-30 18:01:58 -04:00
David Walsh
9679b91e82 For #9525 - Add bottom margin to top sites header 2020-03-30 14:48:45 -07:00
Sawyer Blatz
4ac29530cd
Issue #9132: Update to search animation for top toolbar (#9524)
* let animation in top toolbar mode play nicely.

* remove duplicate methods, make code readable.

* migrate getToolbarNavOptions method to BrowserAnimator, one method to rule them all.

* Update linting

Co-authored-by: ahmedmamdouh13 <ahmedmamdouh13196@gmail.com>
2020-03-30 12:07:00 -07:00
ekager
3d55578242 Use existing strings for announcement 2020-03-30 11:10:40 -07:00
asavill
c383d4225e Closes #7720:
- Increased atp switch size to be consistent with `dimen/tracking_protection_item_height`(48dp).
- Cut out redundant traversal of TextViews in SwitchWithTraversal as per https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md
- Reuse `QuickSettingsText.Icon` style on the switch component to be consistent with other items in the component_tracking_protection_panel.xml
- Added new string resources for textOff and textOn state to get appropriate screen reader description (unsure of the translation/localisation process here!)
2020-03-30 11:10:40 -07:00
David Walsh
e1187ebf31 For #7059 - Allow search engines to scroll 2020-03-30 10:31:39 -07:00
David Walsh
d989616f62 Add top sites heading to home screen 2020-03-30 10:29:40 -07:00
mcarare
76f15a1f7f For #9498: Update unit tests with new constructor argument 2020-03-30 09:56:51 -07:00
mcarare
f52fa44207 For #9498: Replace navargs with viewModel to remember if scroll to tab 2020-03-30 09:56:51 -07:00
mcarare
ab78951146 For #9496: Vertically align collection name and icons to collection icon 2020-03-30 08:30:06 -07:00
Simon Chae
e820a35f56 Update NotYetSupported add-ons copy 2020-03-30 10:36:49 -04:00
codrut.topliceanu
1e63d6ce76 For #9500 - Revert patch for 8568
The patch for 8568 introduced this regression.
Let's just revert it until we can come up with a better solution.
2020-03-30 07:20:13 -07:00
Sebastian Kaspari
02aabea14a Update to new feature-media API. 2020-03-29 23:13:13 -07:00
Mozilla L10n Automation Bot
cd7c2c4bd5 Import l10n. 2020-03-29 12:32:40 -07:00
Edouard Oger
394f386ac3 Add secret debug menu to override FxA servers 2020-03-27 22:59:14 -07:00
mcarare
18533d3434 For #8764: Use list component for items in collections 2020-03-27 22:14:59 -07:00
mcarare
62bbbd9e37 For #8764: Update collection design, including list elements 2020-03-27 22:14:59 -07:00
mcarare
38a97cd1e0 For #9252: Add progress bar to saved logins view 2020-03-27 22:13:58 -07:00
mcarare
f3bbcc4e17 For #9252: Update views visibility ony when list has finished loading 2020-03-27 22:13:58 -07:00
Arturo Mejia
f9cc2ccfe2 For issue #8017 enable SitePermissionsWifiIntegration 2020-03-27 20:44:16 -04:00
Mozilla L10n Automation Bot
75aba7a2b4 Import l10n. 2020-03-27 17:33:26 -07:00
codrut.topliceanu
ba39a46b88 For #8568 - Refocus URL editText in SearchFragment onResume 2020-03-27 17:24:14 -07:00
Amaan Marfatia
3dcfed3761 AboutPageAdapter doesn't use notifyDataSetChanged()
We make the AboutPageAdapter inherit from a ListAdapter so that we don't use notifyDataSetChanged().
2020-03-27 17:23:27 -07:00
David Walsh
180652deab No issue - Make fill link from clipboard divider stretch full screen 2020-03-28 02:10:18 +02:00
mcarare
677a9da5ec For #8485 Update UI tests after settings reorg 2020-03-27 17:05:49 -07:00
mcarare
edabf9c865 For #8485 Move Remote debugging and LeakCanary to Advanced section 2020-03-27 17:05:49 -07:00
mcarare
012e318724 For #8968: Hide keyboard when navigating away from browser 2020-03-27 16:44:11 -07:00
ValentinTimisica
3647606aae Fixes #9280: Remove tabs fade in animation when pressing on Add new collection 2020-03-27 15:54:24 -07:00
Mugurell
9f3bbf1fb7 For #8651 - Add HistoryInteractor/Controller unit/ui tests 2020-03-27 15:53:31 -07:00
Mugurell
fc0260d6ee For #8651 - Ensure FenixSnackbar has a proper root for inflating into
FenixSnackbar, as the platform Snackbar can only be inflated in either a
`CoordinatorLayout` or a `FrameLayout`.
Ensure our HistoryFragment's layout uses one of these as it's root.
2020-03-27 15:53:31 -07:00
Mugurell
a1cdd31f0c Fix #8651 - Add new menu actions for a history item
We'll now also support:
- Copy url
- Share to another FXA device
- Open in new tab
- Open in private tab
2020-03-27 15:53:31 -07:00
mcarare
b77f92f9d1 For #9435: Adjust margins and paddings to mirror correctly in RTL 2020-03-27 14:45:47 -07:00
Mihai Branescu
3f12c1cdb9 Closes #9352 - changed capitalisation of 'Open in app' 2020-03-27 14:43:32 -07:00
David Walsh
28406eaf3d No issue - Add content descriptions when missing 2020-03-27 14:41:51 -07:00
mcarare
e8ad2389ac For #7356: Scroll to selected tab when pressing tab overview 2020-03-27 14:13:26 -07:00
ekager
414e905b76 Closes #8944 - Adds custom lint checks 2020-03-27 13:59:51 -07:00
Sawyer Blatz
06e5efd03e
No issue: Removes settings entrance animation for now (#9443) 2020-03-27 09:55:24 -07:00
Mihai Eduard Badea
91690d7b48 Replaced name field with search string field 2020-03-27 16:38:59 +02:00
ValentinTimisica
69e8a2f357 Fixes #4987: Remove close tabs functionality when they are added to a collection 2020-03-27 15:42:17 +02:00
ValentinTimisica
a72d50d78f Fixes #7734: Remove animation for back button 2020-03-27 15:37:33 +02:00
Mozilla L10n Automation Bot
5894999f28 Import l10n. 2020-03-27 09:43:08 +02:00
Sawyer Blatz
6065ff85a1
No issue: Fixes indentations on several settings fragments (#9442) 2020-03-26 14:52:08 -07:00
Christian Sadilek
5e9d5dd545 Closes #9414: Make AMO collection configurable 2020-03-26 17:26:20 -04:00
Grisha Kruglov
9e324fa02a Perform storage warm-up after visual completeness 2020-03-26 14:12:35 -07:00
Grisha Kruglov
20f8b97dcb Pass lazy references to FennecMigrator 2020-03-26 11:57:45 -07:00
Sebastian Kaspari
0f0d56e60a Issue #5208: Use new tab/collection restore API. 2020-03-26 10:55:12 -07:00
Mihai Branescu
73a7330b2b For #9395 - Trimmed name for custom search engines 2020-03-26 09:35:23 +02:00
Mozilla L10n Automation Bot
5a9be5e053 Import l10n. 2020-03-26 08:54:04 +02:00
Jonathan Almeida
40ba43311e For #7661: Add deeplink schemas for fennec variants 2020-03-25 15:39:44 -04:00
Arturo Mejia
f785a07ef9 No issue: Add add-on updater information dialog 2020-03-25 13:57:51 -04:00
ValentinTimisica
eb5303fa48 Fixes #8288: Adds content description for ETP back button 2020-03-25 13:18:41 +02:00
Mozilla L10n Automation Bot
d2c23f21cc Import l10n. 2020-03-25 13:12:34 +02:00
Christian Sadilek
d184b99649 Closes #9333: Prevent compression of omni.ja to improve startup time
Co-authored-by: Markus Stange <mstange@themasta.com>
Co-authored-by: Agi Sferro <agi@sferro.dev>
2020-03-24 16:10:11 -07:00
Mihai Branescu
a23bcebb5d For #8972 Replaced purple colors to match the rest of the app 2020-03-25 00:13:59 +02:00
Mihai Branescu
494db56ea5 For #9207 - changed status bar color in home fragment to match gradient background 2020-03-24 23:44:46 +02:00
Arturo Mejia
fa9dae0d72 For issue #9364 Crash when blocking app permissions and returning to
the app
2020-03-24 13:44:54 -07:00
ekager
eea6eb0c4c Add toolbar padding for bookmark snackbar 2020-03-24 13:33:50 -07:00
ekager
16b40992d2 For #9351 - Show snackbars with toolbar padding to work with dynamic toolbar 2020-03-24 13:33:50 -07:00
Arturo Mejia
5e75140b3d For issue #8809 Notification permissions can't be disabled/re-enabled
unless you restart the browser
2020-03-24 15:25:33 -04:00
Arturo Mejia
b484ad38cc No issue: Remove feature flag for removing one TP exception 2020-03-24 11:14:07 -04:00
mcarare
55ea92be5b For #8759 Update Unit tests with activityName instead of packageName 2020-03-24 17:10:19 +02:00
mcarare
7fbb1640b6 For #8759 Use activityName instead of packageName as app identification 2020-03-24 17:10:19 +02:00
Aaron Train
f23b9fcb89
Closes #9346: Add ViewIdlingResource for Reader View UI tests (#9347) 2020-03-24 10:47:11 -04:00
ValentinTimisica
79dc133c9c For #9359: Revert 8491.
In the UX review of 8491 it was discovered that the proposed solution is not
optimal and we should actually better stick with the old implementation.

This ticket comes to help with that and revert the already merged patch for
8491 and so will add same gradient to the top toolbar as the bottom toolbar.
2020-03-24 15:12:56 +02:00
Mozilla L10n Automation Bot
8be6c77695 Import l10n. 2020-03-24 09:44:22 +02:00
Arturo Mejia
301f56d144 For issue #9334 Fix Remove of one exception is deleting all 2020-03-23 20:04:04 -04:00
exobyte101
dee1d92293 Remove extra transparent space from widget preview image 2020-03-23 16:54:35 -07:00
exobyte101
746a11c30f Closes #4766: Adjust search widget min height and width according to guildelines 2020-03-23 16:54:35 -07:00
Sawyer Blatz
9feb44852b
For #9256: Attempts to fix installation ping not being sent (#9331) 2020-03-23 14:27:28 -07:00
Kate Glazko
47b2f6a070 For 7077 Simplify Display Url 2020-03-23 12:36:48 -07:00
codrut.topliceanu
9059a6b465 For #6317 - Applies 3dot menuItem look to quickSettings and tracking panel 2020-03-23 12:26:52 -07:00
Aaron Train
f8048462b5
Closes 9291: Fix shortcutSearchEngineSettingsTest (#9292) 2020-03-23 11:04:10 -04:00
Mozilla L10n Automation Bot
db1a093661 Import l10n. 2020-03-23 10:15:56 +02:00
Amaan Marfatia
7236913d94 Closes #7761: Makes the Parent Folder Selector height 48dp for touch accessibility 2020-03-22 00:10:09 +02:00
Mihai Branescu
ab04155222 For #8653 - changed menu strings 2020-03-22 00:03:26 +02:00
mcarare
14338a3b13 For #8899: Set viable anchor for snackbars in both custom and normal tab 2020-03-20 22:46:59 -07:00
ValentinTimisica
8871c05c9d Fixes #9243: Remove tabs fade in animation when pressing on Save to Collection 2020-03-20 22:44:31 -07:00
David Walsh
681d6cf8a1 For #8652 - Allow sharing multiple bookmarks 2020-03-20 20:28:36 -07:00
David Walsh
27502bdd34 For #9177, #8248 - Hide empty verified by block when no cert 2020-03-20 19:40:51 -07:00
Mozilla L10n Automation Bot
930c74a42a Import l10n. 2020-03-20 19:40:15 -07:00
Severin Rudie
35a132d7ff
8017 advanced autoplay controls. (#8978)
* For #8017: add advanced autoplay controls
2020-03-20 12:10:42 -07:00
Elise Richards
5d8a9bb4be
For #8592: Relocate device name in account preferences. Deactivate device name field while syncing. (#9255) 2020-03-20 12:32:04 -05:00
Sawyer Blatz
a356b4b2c4
For #9136: Send all adjust properties to glean (#9253) 2020-03-20 10:06:55 -07:00
Mugurell
21606bf94f For #8693 - Add rtl onboarding toolbar position picker images 2020-03-20 09:48:04 -07:00
Mugurell
1dca146e4f For #8693 - Add rtl onboarding theme picker images 2020-03-20 09:48:04 -07:00
Aaron Train
8f37977e79
Closes #9262: Add additional waits to LibraryMenuTest (#9263) 2020-03-20 12:16:50 -04:00
ValentinTimisica
fbeff33ef5 Fixes #8491: Changed toolbar background for PBM when is set to top
This change was required so that the background of the toolbar match the
homeFragment gradient
2020-03-20 17:13:19 +02:00
Mozilla L10n Automation Bot
e97387257b Import l10n. 2020-03-20 10:51:47 +02:00
Mozilla L10n Automation Bot
310b3caf70 Import l10n. 2020-03-19 16:25:18 -07:00
Sawyer Blatz
b9059c8208
For #9256: Attempts to fix installation ping not being sent (#9254) 2020-03-19 16:22:28 -07:00
Sebastian Kaspari
0198305bfb MigrationPushRenewer: Remove ExperimentalCoroutinesApi. 2020-03-19 16:11:53 -07:00
Grisha Kruglov
e541e10427 Initialize storage after visual completeness
In order to eat the perceived performance costs, we initialize storage
once we're visually complete. This way, we're reducing chances of user performing
a UI action which will trigger storage init and delay said action.
2020-03-19 15:46:50 -07:00
Grisha Kruglov
eb14532c3c Closes #7450: Lazy storage initialization
Make sure that we actually lazily initialize our storage layers.

With this patch applied, storage layers (history, logins, bookmarks) will be initialized when first
accessed. We will no longer block GeckoEngine init, for example, on waiting for the logins storage
to initialize (which needs to access the costly securePrefStorage).
Similarly, BackgroundServices init will no longer require initialized instances of the storage
components - references to their "lazy wrappers" will suffice.

In practice, this change changes when our storage layers are initialized in the following ways.
Currently, we will initialize everything on startup. This includes loading our megazord, as well.

With this change, init path depends on if the user is signed-into FxA or not.

If user is not an FxA user:
- on startup, none of the storage layers are initialized
- history storage will be initialized once, whenever:
  - first non-customTab page is loaded (access to the HistoryDelegate)
  - first interaction with the awesomebar
  - history UI is accessed
- bookmarks storage will be initialized once, whenever:
  - something is bookmarked, or we need to figure out if something's bookmarked
  - bookmarks UI is accessed
- logins storage will be initialized once, whenever:
  - first page is loaded with a login/password fields that can be autofilled
  - (or some other interaction by GV with the autofill/loginStorage delegates)
  - logins UI is accessed
- all of these storages will be initialized if the user logs into FxA and starts syncing data
  - except, if a storage is not chosen to be synced, it will not be initialized

If user is an FxA user:
- on startup, none of the storage layers are initialized
- sometime shortly after startup is complete, when a sync worker runs in the background, all storage
layers that are enabled to sync will be initialized.

This change also means that we delay loading the megazord until first access (as described above).
2020-03-19 15:46:50 -07:00
mcarare
e4acabb329 For #8600:Increase space below left checkbox preference 2020-03-19 15:41:05 +02:00
mcarare
a098b66d26 For #8591: Allow items in quick_action_sheet to be read by a11y services 2020-03-19 15:18:40 +02:00
mcarare
756b1fbadd For #9140: Remove drawable from title in empty state panes 2020-03-19 14:32:40 +02:00
Ryan Kelly
a0f8be25b6 Add support for application-services autoPublish local dev workflow. 2020-03-19 10:51:08 +02:00
Arturo Mejia
7dff584b82 Remove @ObsoleteCoroutinesApi from tests 2020-03-18 17:25:51 -07:00
Arturo Mejia
823eea44ed No issue: Add serverConfig param to FxaWebChannelFeature 2020-03-18 17:25:51 -07:00
Arturo Mejia
e977486809 Remove @UseExperimental for usages of the flow api 2020-03-18 17:25:51 -07:00
mcarare
4425e7139e For #9200: Remove star icon from empty state icon in toolbar 2020-03-18 10:23:50 -07:00
mcarare
772c7062fd For #8814: Change icon asset for top sites menu option 2020-03-18 08:30:33 -07:00
Mozilla L10n Automation Bot
937e1cd2e6 Import l10n. 2020-03-18 15:02:07 +01:00
Jonathan Almeida
ffd4cdd970 For #7661: Add variant-specific schemas for deep links
In order to target specific variants of Fenix, we're adding schemas that
are specific that app in order to avoid collisions with the other
variants and with other forks of fenix that may have the same schemas.

The current schema for variants:
 - Fenix Nightly: `fenix-nightly://`
 - Fenix Beta: `fenix-beta://`
 - Everything else: `fenix://`
2020-03-17 17:21:09 -04:00
Sawyer Blatz
b4e1360f59
For #3086: Adds settings animations (#9187) 2020-03-17 12:35:00 -07:00
Christian Sadilek
0d974fe262 For #8808 #9139: Add-on should be able to configure how to open options page 2020-03-17 12:34:07 -04:00
Edouard Oger
a1ea94fe76 Prepare for a-c a-s upgrade 2020-03-17 11:49:54 -04:00
Sebastian Kaspari
34144fd254 Use pinned Android Components Nightly version instead of snapshots. 2020-03-17 12:09:36 +01:00
Severin Rudie
3e38b002dd
No issue: fixes test broken by snapshot (#9176)
* No issue: fixes test broken by snapshot

* No issue: ignore flaky tests
2020-03-16 16:44:39 -07:00
Christian Sadilek
63517a52e4 No issue: Remove unneeded logic to adjust TP 2020-03-13 14:08:49 -04:00
isabelrios
74433ba27a
ui-tests-homescreen-fix-to-enable (#9050) 2020-03-13 11:16:47 -04:00
Mozilla L10n Automation Bot
dd38f1df0a Import l10n. 2020-03-13 07:45:13 -07:00
Jonathan Almeida
3d387e2dde Add nightly-only feature flag for WebPush integration 2020-03-12 18:39:32 -07:00
codrut.topliceanu
030bd38631 For #8561 - Scroll to topSites on app cold start 2020-03-12 10:54:58 -07:00
Sawyer Blatz
cc8f34b68b
For #8773: Fixes issue with snackbar placement on ContextMenu (#8942) 2020-03-12 09:54:13 -07:00
Roger Yang
9a582a6983
Closes #9104: Pass release channel information to Socorro service (#9130) 2020-03-12 12:00:14 -04:00
isabelrios
97b5754562
For #9076 - Upddate pipenv to run without error. (#9077)
* For #9076 - Upddate pipenv to run without error

* pipenv fixed the issue after update
2020-03-12 11:36:51 -04:00
Jeff Boek
c862ca93ba No issue - Fixes shadow on top layout 2020-03-11 22:59:42 -07:00
Jeff Boek
74ce62b5c3 For #8949 - Removes old motionlayout code, fixes how shadow is drawn 2020-03-11 17:10:40 -07:00
David Walsh
fc67747409 Show the collections header when there are no collections 2020-03-11 16:26:39 -07:00
ekager
31cc7d9166 For #8897 - Don't remove all external sessions on back press 2020-03-11 14:04:27 -07:00
Michael Comella
5bd0369aed No issue: remove unused HotStartPerformanceMonitor.
This monitor for hot start was intended to be used by FNPRMS to measure
hot start. However, hot start was deprioritized so it's now essentially
unused.
2020-03-11 11:28:38 -07:00
Mihai Branescu
b0e4453fb7 For #8800 - add tests for dismissing highlighted items 2020-03-11 19:05:55 +02:00
Mihai Branescu
485efacd33 For #8800 - dismiss all highlights when menu is closed 2020-03-11 19:05:55 +02:00
Severin Rudie
1381444a52 For #8800: clear menu highlights on use 2020-03-11 19:05:55 +02:00
mcarare
95a89f9dba For #8474 Remove obsolete unit tests for removed menu items 2020-03-11 09:52:28 -07:00
mcarare
2ffbecaefa For #8474 Reorganize browser menu items 2020-03-11 09:52:28 -07:00
Arturo Mejia
ce4293c8c8 For issue #8908 Notify users when previously unsupported add-ons
become available
2020-03-11 11:24:01 -04:00
Severin Rudie
e86120027f For #9091: fix test failure 2020-03-11 14:51:05 +01:00
ekager
709bf6f627 For #7087 - Add SearchView to Logins Fragment 2020-03-10 23:01:51 -07:00
ekager
d5f4444447 No issue: Remove useContentProcessHint from GV beta GeckoProvider 2020-03-10 22:33:11 -07:00
Severin Rudie
8663c479dc
For #8017: remove redundant string per localization team (#9068)
Based on conversation in https://github.com/mozilla-mobile/fenix/pull/8953#issuecomment-594332067
2020-03-10 13:29:24 -07:00
ekager
feb6215fae For #8296 - Adds user account avatar to Account Preference 2020-03-10 11:19:22 -07:00
Emily Kager
93bc87e273
For #7270 - Do not overlap long logins items (#9013) 2020-03-10 09:39:50 -05:00
Oana Horvath
7e9811b20c
Close private tabs tests (#8999) 2020-03-10 11:44:21 +02:00
Jonathan Almeida
ef42becbf9 For #9059: Add WebPush engine integration 2020-03-09 16:50:29 -04:00
ekager
667ebe3142 For #8967 - Remove ability to pref login autofilling by itself 2020-03-09 13:19:47 -07:00
mcarare
320fc4e4ae For #8788 Use Flexbox instead of Grid manager for top sites 2020-03-09 11:01:14 -07:00
mcarare
a581486e1c For #8985 Fix Share Menu display when having recently used list.
Allow for All Actions recyclerview to scroll to end.
Adjust padding for views.
2020-03-09 10:48:02 -07:00
Emily Kager
93cb3c2053
For #8423 - Adds delete login confirmation dialog (#9014) 2020-03-09 15:51:18 +02:00
mozilla-l10n-automation-bot
2563346f07
Import l10n. (#9041) 2020-03-09 14:56:32 +02:00
Mozilla L10n Automation Bot
23456834ba Import l10n. 2020-03-06 20:24:51 -08:00
David Walsh
0436c8d8a4 For #8874 - Update tab deletion colors 2020-03-05 21:21:37 -08:00
Mozilla L10n Automation Bot
2aef886591 Import l10n. 2020-03-05 21:19:42 -08:00
mcarare
7ae1304612 For #8975: Update unit tests for new separator between title and url 2020-03-05 21:17:36 -08:00
mcarare
16e2f20471 For #8975: Separate title from url with line break when sharing links 2020-03-05 21:17:36 -08:00
Sawyer Blatz
28f58eb025
For #7158: Improves home to search animation (#9008) 2020-03-05 13:54:54 -08:00
Christian Sadilek
84afb5d156 Issue #8291: Speculatively create content process in search fragment 2020-03-05 16:02:23 -05:00
Sawyer Blatz
3548e58c00
For #7158: Improves browser to search animation (#8961) 2020-03-05 12:29:23 -08:00
Sebastian
89a260ecd9 Use new MemoryConsumer.onTrimMemory() API. 2020-03-05 20:02:22 +01:00
Mozilla L10n Automation Bot
3be3571dbd Import l10n. 2020-03-05 14:25:13 +01:00
Oana Horvath
0cdb0680e7
UI tests for Private browsing settings sub-menu (#8395) 2020-03-05 12:25:48 +02:00
Jim Porter
ec98fd948b For #7847: Improve startup performance of the Fenix wrapper around Glean 2020-03-04 16:21:45 -08:00
Sebastian
7b170c4428 Update IntentProcessor implementation to comply with new interface. 2020-03-04 09:40:00 -08:00
ekager
e2bfe8d0db For #8621 - Disable failing handlePermissionsChange test 2020-03-04 08:13:46 -08:00
isabelrios
a4d93002a9
sync-integration-tests-fix-paths (#8931)
* sync-integration-tests-fix-paths

* fix Jenkins file to store the report

* address reviewer comments
2020-03-04 10:56:56 -05:00
Mozilla L10n Automation Bot
8296b3e9ff Import l10n. 2020-03-03 23:17:32 -08:00
Mozilla L10n Automation Bot
8b0c1cae4c Import l10n. 2020-03-03 15:29:40 -08:00
ekager
c326130a82 Update UI tests 2020-03-03 14:44:38 -08:00
Josh Vocal
c15469595d For #7554: Add App Services Version to About Page 2020-03-03 14:44:38 -08:00
Gabriel Luong
c1a7bddcd3
For #8593 - Style the add-ons permission dialog to match the Fenix theme 2020-03-03 17:09:09 -05:00
Severin Rudie
8b7dee853e
For #8017: fix wifi string (#8953) 2020-03-03 13:36:13 -08:00
Jonathan Almeida
0d48b65a25 For #8950: Unregister observers in the main scope coroutine 2020-03-03 16:20:20 -05:00
ekager
2603683d42 Match Theme Indepedent Grey 2020-03-03 12:51:58 -08:00
mcarare
f9e85e78af For #6607 Update button theming in no tab pane 2020-03-03 12:51:58 -08:00
mcarare
cfe4f11864 For #6607 Update button theming in no tab pane 2020-03-03 12:51:58 -08:00
Jonathan Almeida
aad041c34c Fix breaking APIs in MigratingFenixApplication 2020-03-03 11:37:38 -08:00
Sawyer Blatz
edd1f013ba For #5308: Show search shortcuts for search term queries 2020-03-03 10:01:52 -08:00
Jonathan Almeida
4ccda4d495 Log push crashes to CrashReporter 2020-03-03 12:46:37 -05:00
Jonathan Almeida
4bbf87d272 Closes #6730: Lazily initialize account manager on new push message 2020-03-03 11:38:58 -05:00
Grisha Kruglov
e6e2dd94c7 Closes #7344: Login storage refactor
The a-c side of this work is in https://github.com/mozilla-mobile/android-components/pull/6128

This switches Fenix to use `SyncableLoginsStorage`, which caches a connection internally
on first access, and doesn't expose any lock/unlock APIs at the public boundary.
2020-03-03 16:58:58 +01:00
Sebastian Kaspari
a890bd4c0c AwesomeBarView: Pass BrowserStore to SessionSuggestionProvider instead of SessionManager. 2020-03-03 14:19:18 +01:00
Christian Sadilek
20387401b1 Issue #7863: Ensure parent process triggers speculative connect 2020-03-03 14:19:18 +01:00
Sawyer Blatz
f20fb50481 For #5346 & For #8859: Fixes textSize & animation on TabCounter 2020-03-02 18:54:20 -08:00
Sawyer Blatz
e38bff8597 For #5308: Display search shortcuts when going from browser to search 2020-03-02 17:54:05 -08:00
David Walsh
063a3b268a For #2271 - Fix hairline color on dark theme and private mode 2020-03-02 16:03:36 -07:00
Andrew Gaul
4ab4733f34 Do not scroll menu when toolbar is on top
Fixes #8838.
2020-03-02 14:56:52 -08:00
Harshal Lele
e318cd7d15 fix #8135 - remove getColorFromAttr 2020-03-02 15:48:33 -07:00
Sawyer Blatz
8e06933e8d For #167: Adds browser -> home animation 2020-03-02 14:45:44 -08:00
Severin Rudie
b717926f72 For 8017: add strings for advanced video autoplay
See https://github.com/mozilla-mobile/fenix/issues/8503#issuecomment-592658604
2020-03-02 14:38:05 -08:00
ekager
a8e41d3b41 No issue: Remove one instance of android:drawableTint 2020-03-02 14:37:39 -08:00
Emily Kager
a61502215b Revert "For #7603 - Temporarily do not show biometric prompt for OnePlus devices"
This reverts commit 17d7928cc9.
2020-03-02 14:31:08 -08:00
Michael Comella
db57e123b9 For #8797: Do not allow nested scrolling on top sites. 2020-03-02 15:24:43 -07:00
mcarare
169a255c7f For #8766: Update UI Tests 2020-03-02 14:27:04 -07:00
mcarare
2bb2061931 For #8766: Show collections only when tabs are open or collection exists 2020-03-02 14:27:04 -07:00
mcarare
0b07f99127 For #8898 Show round progress bar only on end side
This will auto-mirror on RTL so it will also show at progressbar end
2020-03-02 14:01:21 -07:00
Aaron Train
6ac13b3f7b
Re-enable ETP UI tests and update local asset (#8733) 2020-03-02 14:40:52 -05:00
Mihai Adrian
e3d34edfc7
For #8873 - Update snackbar padding for adding top sites 2020-03-02 14:28:14 -05:00
Arturo Mejia
4cf34b47ee
Show a notification when add-on update requires new permissions 2020-03-02 13:46:37 -05:00
Sawyer Blatz
e96732604b For #167: Improves home to browser animation 2020-02-28 18:04:14 -07:00
Michael Comella
9ed43b60b6 For #7781: instrument visual completeness for top sites.
Eyeballing my output in *Debug builds on my P2, this adds approximately 115ms
or slightly less from first frame drawn to visually complete time.
2020-02-28 13:37:06 -08:00
Michael Comella
4605ba9124 No issue: make Performance methods private that can be. 2020-02-28 13:37:06 -08:00
ekager
a6b07afa95 No issue: Fix LeakCanary detected memory leaks
Co-authored-by: Emily Kager <emilykager@gmail.com>
Co-authored-by: Pierre-Yves Ricau <py@squareup.com>
2020-02-28 13:29:16 -08:00
Sebastian Kaspari
83f94cacb5 FennecWebAppIntentProcessor: Handle manifest file not existing. 2020-02-28 13:27:53 -08:00
Sebastian Kaspari
a477f14042 IntentReceiverActivity: Simplify intent handling.
This patch removes the need to process() and then match() on every intent processor.
A successful process() means that we already matched. Doing this in two steps caused
issues when the process() failed but later the simple check in match() returned true.

After this patch lands I intent to remove the match() API from the IntentProcessor
interface in AC:
https://github.com/mozilla-mobile/android-components/issues/6097
2020-02-28 13:27:53 -08:00
Michael Droettboom
bb2c009c16 1592947: Use the Glean Gradle plugin 2020-02-28 13:24:58 -08:00
mcarare
5a6fc02976 For #8773: Set proper anchor and padding for Snackbars on browser screen 2020-02-28 13:23:11 -08:00
mcarare
361e817fb1 For #6607 Update unit test to include parameter openSearchScreen 2020-02-28 13:21:22 -08:00
mcarare
df80a5240b For #6607 Add button to no tab content pane 2020-02-28 13:21:22 -08:00
David Walsh
5b7a800f98 Make 'Redirect to Sync' home menu item go directly to the 'Reconnect to Sync' / error screen 2020-02-28 13:19:06 -08:00
David Walsh
0187669790 Match account problem styling between HomeMenu and BrowserMenu 2020-02-28 13:18:40 -08:00
Sebastian Kaspari
d89fbd7af8 FenixSearchEngineProvider: Use dummy location service in debug builds.
Workaround for issue described in:
https://github.com/mozilla-mobile/android-components/issues/5989

For debug builds it is unnecessary to use the actual location provider since those builds
do not have an API key configured. With that patch we replace the location provider with
a dummy implementation in debug builds.
2020-02-28 13:17:45 -08:00
Arturo Mejia
30f351910a
Make sure all installed extensions are registered for updates 2020-02-28 15:37:08 -05:00
Will Hawkins
f9b716286a For #8034: Create a post-visual completeness executor
Create an object that will execute its enqued tasks
when Fenix is visually complete.
2020-02-28 09:15:06 -08:00
Simon Chae
0def456cac
For #8116: Attach add-on snackbar to activity rootView 2020-02-27 17:47:59 -05:00
isabelrios
b432f5c495
Update UI Sync integration tests and fix TPS preference. (#8489) 2020-02-27 16:32:24 -05:00
Aaron Train
f7aec4c788
No issue: Disable UI test verifyContextCopyLink for intermittent failure (#8833) 2020-02-27 16:03:23 -05:00
David Walsh
b525f2382a
For #7504 - Update sync error display in menus (#8639) 2020-02-27 12:54:14 -08:00
ekager
88bd18b4bf Remove unused color selector resource 2020-02-27 12:40:57 -08:00
ekager
63ddff533d For #8641 - Update addon text selector to use attr colors 2020-02-27 12:40:57 -08:00
Aaron Train
499f38cdaf
No issue: Disable UI test createBookmarkFolderTest for intermittent failure (#8828) 2020-02-27 13:28:06 -05:00
Simon Chae
4854566f94
For #8824: Reset isInstallationInProgress in correct lifecycle (#8825) 2020-02-27 12:33:37 -05:00
Arturo Mejia
cfa6f0cc7a No issue: Submit exceptions while updating add-ons to the crashReporter 2020-02-27 17:44:23 +01:00
Simon Chae
41a84e85a3
For #8699: Add view.settings to setAllInteractiveViewsClickable (#8820) 2020-02-27 11:30:22 -05:00
Mozilla L10n Automation Bot
661f3d491a Import l10n. 2020-02-26 17:37:08 -08:00
Mozilla L10n Automation Bot
12e2bf9e77 Import l10n. 2020-02-26 15:19:59 -08:00
David Walsh
b0a5946d4c For #8792 - Fix display of tabs icon in browser 2020-02-26 14:25:41 -08:00
ekager
1ede724969 No issue: Add UI test wait for Toolbar edit url view 2020-02-26 12:42:13 -08:00
Mihai Adrian
9612c3f16d
For #8540: Fix ETP options not being correctly applied (#8688) 2020-02-26 12:25:40 -08:00
David Walsh
e2b72a9c01 For #8505 - Update tab icon 2020-02-26 12:04:51 -08:00
Simon Chae
f99bad949e
For #8699: Add setAllInteractiveViewsClickable for add-on pending removal (#8776) 2020-02-26 14:22:42 -05:00
mcarare
314bee2abd For #8627: Add proper content description to ETP card clickable areas 2020-02-26 08:31:51 -08:00
Sebastian Kaspari
2096176fa6 Update MigrationService to use correct activity reference. 2020-02-26 11:11:12 +01:00
Grisha Kruglov
7275dd5269 Public API changes related to 0.52.0 A-S bump 2020-02-26 10:15:58 +01:00
Severin Rudie
c87c837865
For #8752: fix invalid AutoplayAction crash 2020-02-26 00:37:44 -05:00
Sawyer Blatz
b8d5dc4551 For #7715: Display search suggestions when pressing allow 2020-02-25 20:14:05 -08:00
Grisha Kruglov
fddf77280c Remove direct A-S dependency; switch to using 'full' megazord
As far as I can tell, we never actually exercise the a-s libraries in Fenix tests currently (this was one of the presumed reasons for having a direct dependency).
In a different branch I've started work on adding end-to-end tests, but currently that's blocked on trying to figure out to load native libraries in tests (somehow, fenix's setup is different than what we have in A-C, not yet clear to me in what way).

Another reason for a direct dependency (i think) is that we needed it to configure a `fenix` megazord. This could be solved via a `support-megazord-fenix` a-c component that provides the correct transient dependencies,
but we can also just switch to use the `full` megazord instead, which is essentially what fenix megazord is at this point. A-S team wants to remove the fenix megazord, so this will help. This is what this patch does.
2020-02-25 17:30:57 -08:00
ekager
7f34204188 For #5843 - Ensure tabs pending deletion are removed 2020-02-25 16:53:52 -08:00
Sawyer Blatz
13c9c39658 For #4383: Add feature flag 2020-02-25 16:45:59 -08:00
Sawyer Blatz
009a7f3020 For #4383: Enable dynamic bottom toolbar 2020-02-25 16:45:59 -08:00
mcarare
09e0c0b447 For #8719: Keep top site item at mock width size, prevent stretching 2020-02-25 16:28:34 -08:00
mcarare
2add077ee3 For #8719: Keep RecyclerView from stretching to fill up parent width 2020-02-25 16:28:34 -08:00
Kadeem M
9f4375fdee
Disable UI test showbookmarksAndHistory (#8749) 2020-02-25 18:58:54 -05:00
ekager
310c43f664 For #7919 - Define colorControlActivated with app namespace 2020-02-25 15:41:28 -08:00
ekager
f569f48b33 For #5696 - Adds basic share action to text selection context menu 2020-02-25 15:39:01 -08:00
Mugurell
4cf74ed44e For #8673 - Don't mirror the onboarding - toolbar position picker tiles
Don't mirror the images and keep the radio buttons fixed in place at the top
left corner of the images.
2020-02-25 15:38:47 -08:00
Mugurell
71aba16cbf For #8673 - Don't mirror the onboarding - theme picker tiles
Don't mirror the images and keep the radio buttons fixed in place at the top
left corner of the images.
2020-02-25 15:38:47 -08:00
ekager
ffc2785c1e No issue: Add back updateThemeForSession in onResume 2020-02-25 15:35:16 -08:00
MarcLeclair
41f9311e20
For #7448: Move LP to IO dispatcher (#8558) 2020-02-25 17:55:43 -05:00
Sawyer Blatz
82979afb48 For #8743: Fix baseBrowserFragment crash 2020-02-25 14:43:59 -08:00
Sparky93
680249f724 Fix for #8722 - Update complete notification is not routing to onboarding screen
Now handling migration completed and clear states as routes to home screen.
2020-02-25 16:50:44 -05:00
ekager
511c36e191 Removes FragmentPreDrawManager changes in BrowserFragment 2020-02-25 13:38:47 -08:00
Sawyer Blatz
dcc1e9fc65 No issue: Fixes swipeRefresh UI test crash 2020-02-25 11:08:41 -08:00
mcarare
cc47bc4e1e For #8655: Show top site context menu below top site title 2020-02-25 10:30:15 -08:00
Arturo Mejia
959e438ff3
Initializes GlobalAddonDependencyProvider 2020-02-25 12:31:05 -05:00
Mihai Adrian
beb323924b
For #8594: Show correct info in Etp settings info (#8687) 2020-02-25 09:18:27 -08:00
Sebastian Kaspari
388c7017d8 Closes #6003: MigrationProgressActivity: Always open browser. 2020-02-25 17:44:18 +01:00
Severin Rudie
69c6de7cd4
For #8411: integrate AC permissions changes (#8618) 2020-02-25 07:36:19 -08:00
Sparky93
0f609b1888 Fix for #8533 - Migration screen's buttons in the wrong place
Made a small refactor on the migration screen layout in order to correctly position the elements.
2020-02-25 13:19:09 +01:00
Simon Chae
0434e53911 For #8637: Remove setActivityTheme outside activity lifecycle scope 2020-02-24 19:48:03 -08:00
Mihai Adrian
4be693255d
For #8565: Fix updating dropdown preferences in ETP settings! (#8573)
* For #8565: Create custom SharedPreferenceUpdater for String Preferences

* For #8565: Use custom updater to correctly update DropDownPreference

* For #8565: Set default values for dropDown preferences

* For 8565: add tests for findEntriesValue

* For 8565: clarified findEntryValue

Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2020-02-24 18:07:02 -08:00
David Walsh
342ad1bfca
For #7604 - Correct header colors in navigation bar (#8661) 2020-02-24 17:39:11 -08:00
Sebastian Kaspari
fdd3d29cd4 Implement new feature-tabs API. 2020-02-24 14:35:36 +01:00
Jeff Boek
cbad832b19 For #8153 - Allow web-extensions to open tabs in correct browsing mode 2020-02-24 00:24:07 -08:00
Jeff Boek
dfde37baf5 Reverts For #7559 - allows changing locale even after setting theme with 2020-02-24 00:24:07 -08:00
Jeff Boek
541bcf072a Reverts all BrowsingModeManager changes 2020-02-24 00:24:07 -08:00
ekager
0d398f7d44 For #8580 - Don't change theme in initialize UI 2020-02-22 20:03:02 -08:00
ekager
37b50e08ea No issue: Disable two intermittent failing tests 2020-02-21 21:10:54 -08:00
David Walsh
72e3d5d22f Add add top margin to No Bookmarks message 2020-02-21 18:52:52 -08:00
Roger Yang
60d38057bb
Closes #8654: Fix breakage from customTabId rename (#8656) 2020-02-21 13:37:46 -08:00
Jeff Boek
26d1bd70d8 Revert "For #8460: Prevent multiple back navigation clicks."
This reverts commit b030d3ac9f.
2020-02-21 09:32:02 -08:00
Sawyer Blatz
d918cfdf38 For #1901: Screenshot engineView to remove GV flash
Co-authored-by: ekager <ekager@mozilla.com>
2020-02-21 08:35:42 -08:00
Roger Yang
0630e2482f
Closes #8544: Activity should be reused when opening intents from other apps (#8547) 2020-02-21 09:02:13 -05:00
Simon Chae
da0148b8bd For #8535 #8498: Allow for multiple browsingModeListeners dispatch 2020-02-20 19:50:35 -08:00
Mugurell
a84b250894 For #8469 - Support rtl for onboarding - toolbar position picker
We'll mirror the toolbar position picker images and make sure the radio button
are positioned correctly in relation to them.
2020-02-20 19:49:42 -08:00
Mugurell
15e1c8dc69 For #8469 - Support rtl for onboarding - theme picker
We'll mirror the theme picker images and make sure the radio buttons are
positioned correctly in relation to them.
2020-02-20 19:49:42 -08:00
Dennis Schubert
be06450dd9 Bug 1613416 - Hide "Report site issue" button in Fenix Production. 2020-02-20 19:24:56 -08:00
mcarare
b030d3ac9f For #8460: Prevent multiple back navigation clicks. 2020-02-20 19:14:45 -08:00
Sawyer Blatz
2a5d774239 For #8315: Fixes flicker of search with text 2020-02-20 19:14:10 -08:00
Arturo Mejia
8b7fd3a1df
For issue #8570: Disabling uBlock and quickly opening the Settings
section cause a crash
2020-02-20 20:31:26 -05:00
Sawyer Blatz
f02e06afae
For #8454 - Removes back button from the search screen 2020-02-20 18:15:47 -05:00
Mozilla L10n Automation Bot
a8d3b635ba Import l10n. 2020-02-20 11:07:38 -08:00
ekager
cb18049c0e For #8524 - Explicitly sets color control normal 2020-02-19 16:51:43 -08:00
ValentinTimisica
6f53020a4a Fixes #7967: Updated accessibility details for 'add search engine' screen 2020-02-19 16:50:52 -08:00
Jeff Boek
f050db517c For #8552 - Fixes bug where "installing/uninstalling" was using the old pref key 2020-02-19 15:20:52 -08:00
Aaron Train
029bbd3726 Closes #8082 - Add UI tests for Top Sites
WIP

wip

WIP

WIP

WIP

WIP

fix: unused import [ktlint]
2020-02-19 11:14:46 -08:00
mcarare
a5ac7304bb For #8523: Also disable radio buttons clickable area when ETP is off 2020-02-19 10:48:01 -08:00
mcarare
2d72027cbd For #8534: Register preference update on first tap 2020-02-19 10:40:17 -08:00
Mihai Branescu
9d972fa1d0 For #4231 added unit tests for most recent apps 2020-02-19 10:36:58 -08:00
Mihai Branescu
fdbf63fb97 For #4231
Added kapt plugin + dependencies in order to be able to use Room
Added recent apps to share fragment (top 6)
Extracted dimens of share_to_apps.xml in the dimens file
2020-02-19 10:36:58 -08:00
Mihai Adrian
3486f30b6a
For #8529: Fix custom ETP preferences visibility update 2020-02-19 11:19:00 -05:00
Sebastian Kaspari
d7e1259e7b
Use Mozilla Android Components 34.0.0-SNAPSHOT. (#8527) 2020-02-19 16:59:34 +02:00
Arturo Mejia
2daa485931
Show internal add-on version when available (#8507) 2020-02-19 09:57:04 -05:00
isabelrios
4582c25208
UITests: New tests for save Login prompt (#8381)
* UITests: New tests for save Login prompt

* fixing firebase timing issues when webpage loads

* adding tests for don't save and check the prompt options

* fix detekt issue

* fix reviewer comments
2020-02-19 14:23:25 +02:00
Jeff Boek
020608275d For #6981 - Fixes tests to support locale aware changes 2020-02-18 18:20:50 -08:00
Jeff Boek
1ba64f9559 For #6981 #6907 - Properly reloads search engines when locale changes 2020-02-18 18:20:50 -08:00
Mozilla L10n Automation Bot
6c2d6e65c3 Import l10n. 2020-02-18 18:13:51 -08:00
ekager
35bf4fbda9 No issue: Fix login for BaseBrowserFragment FragmentPreDrawManager 2020-02-18 17:53:47 -08:00
ekager
57a02a10fc For #8514 - Use state list colors for default disabled states 2020-02-18 17:45:36 -08:00
ekager
1944399f0e For #7796 - Add Gecko Beta GeckoProvider LoginStorageDelegate 2020-02-18 16:31:22 -08:00
Jeff Boek
5c6e6ddfb7 For #4807 - Always navigate to settings after deleting data 2020-02-18 13:30:32 -08:00
Lepiku
8939358f40 For #8449: Update Delete browsing data item minHeight 2020-02-18 12:55:22 -08:00
Mozilla L10n Automation Bot
6150c6bafd Import l10n. 2020-02-18 12:32:11 -08:00
ekager
bb85de5dca For #6737 - Set Logins checkbox default to true 2020-02-18 11:32:50 -08:00
Mihai Adrian
e8913474a0
For #8268 - Update added to top sites snackbar text (#8435) 2020-02-18 13:40:02 -05:00
ValentinTimisica
12ae46343e For #7957: Enable Login management preference for all users 2020-02-18 10:39:04 -08:00
ekager
f52f87f6a4 For #8324 - Only use encrypted storage for Nightly/Debug populations 2020-02-18 10:30:20 -08:00
Jeff Boek
c1f0e7bb33 For #3869 - Fixes unit tests 2020-02-18 10:10:16 -08:00
Jeff Boek
a8746320d7 For #3869 - Uses RegionSearchLocalizationProvider in the search engine provider 2020-02-18 10:10:16 -08:00
mcarare
5fd3894171 For #8354 Fix uppdating theme when coming from external links 2020-02-18 09:34:36 -08:00
mcarare
9d755a877a For #8354 Fix opening custom tabs and links directly in private mode 2020-02-18 09:34:36 -08:00
mcarare
ae13f4b44f For #8354 Remove unsetting open links in private if not default browser 2020-02-18 09:34:36 -08:00
mcarare
ccf4722c5f For #6479: Update UI test for new ETP screen 2020-02-18 09:32:43 -08:00
mcarare
bba563b5f9 For #6479: Add granular ETP settings 2020-02-18 09:32:43 -08:00
Emma Malysz
15ff4726a0 For #8056: remove Experiments.initialize from FenixApplication
Experiments will not be used before GA and are thus being removed
for performance wins.
2020-02-18 08:22:03 -08:00
ValentinTimisica
ba8867c1a9 For #1741: Passes 'showDescription' boolean to SearchSuggestionProvider
Change required for removing description from search suggestion. Implemented
in AC (https://github.com/mozilla-mobile/android-components/pull/5890)
2020-02-18 12:31:40 +02:00
Severin Rudie
cc29c5fe84
For #7896: integrate text selection search from AC (#8295) 2020-02-17 19:20:35 -08:00
Emily Kager
39db8c9557
For #8470 - Fix Unit Tests MockKExceptions (#8471) 2020-02-17 17:13:25 -08:00
Sebastian Kaspari
2a42c30c57 Issue #8277: Move foreground drawable from drawable-v26/ to drawable/ 2020-02-17 11:37:15 +01:00
Sebastian Kaspari
ba54080177 Issue #8277: Reuse app icon in widget layout.
This patch refactors the widget layouts so that we can reuse the app icon and do not have to have
another logo resource with different constraints. This will also make it easier to update the
branding in #8277 and #8278.
2020-02-17 11:37:15 +01:00
Sebastian Kaspari
f1a3dffba2 Issue #5194: Reuse Fennec taskAffinity flag.
Reusing the same taskAffinity makes sure that we are launching into a potentially already
existing task from Fennec. Without that we may spawn a new task and will show up twice
in "Recent apps" - with one entry still having a fennec screenshot.
2020-02-17 11:34:13 +01:00
ekager
324fe64213 No issue: Fix new optional adds on arg error 2020-02-15 17:21:03 -08:00
Jeff Boek
7aeb5f072d For #7295 - Adds more documentation for the installation metrics 2020-02-14 20:56:49 -08:00
codrut.topliceanu
3b64cabc52 For #7295 - Removes some incorrect data-review links 2020-02-14 20:56:49 -08:00
codrut.topliceanu
d6ae3d4abe For #7295 - Adds new custom ping: 'installation' 2020-02-14 20:56:49 -08:00
ekager
b72550c28a For #8126 - Adds default top sites 2020-02-14 14:39:58 -08:00
ekager
2e1202cbd1 For #8348 - Add small delay after biometric auth 2020-02-14 12:36:38 -08:00
Kate Glazko
cec52cb848 For #5073: Fix Cert Text Color 2020-02-14 11:59:00 -08:00
Sebastian Kaspari
371db0777d Optimize PNGs. 2020-02-14 09:41:54 -08:00
Sebastian Kaspari
0260ab6272 Issue #8277: Update widget preview for fennecBeta build type. 2020-02-14 16:54:08 +01:00
Mozilla L10n Automation Bot
c21794408e Import l10n. 2020-02-14 16:19:54 +01:00
Sparky93
5971257669 Fix for #8430 - Migration progress bar too close to text
Reduced the margin start value of the progress bar in order to leave more space between it and the
text.

Moved hardcoded margin values into dimens resources.
2020-02-14 14:22:10 +01:00
Sebastian Kaspari
c45df6ecde Dismiss "migration notification" after leaving migration activity.
For https://github.com/mozilla-mobile/android-components/issues/5886.

With this patch we will dismiss the "migration completed" notification once the users
clicks on the button in the migration activity.
2020-02-14 12:02:58 +01:00
Sparky93
640d24974f Fix for #8426 - Migration steps displayed in a different order than UI specifications
Changed the order of the whitelisted migrations in order to respect the UI specifications.

Now using linked hash map instead of hash map for the whitelisted migrations so we can preserve the
order of the steps upon status changing in the migration process.
2020-02-14 11:48:24 +01:00
Sebastian Kaspari
d65bd4f7cd Issue #8277: Update wordmark for fennecBeta build type. 2020-02-14 07:42:59 +01:00
Sebastian Kaspari
404e1c8e0f Issue #8277: Update launcher icons for fennecBeta build type. 2020-02-14 07:42:59 +01:00
Sebastian Kaspari
893044256a Issue #8277: Update app name of fennecBeta build type. 2020-02-14 07:42:59 +01:00
Sebastian Kaspari
ce309b7f16 Closes #8273: Add shortcuts.xml for fennecProduction variant. 2020-02-14 07:42:23 +01:00
mcarare
3b5eadcc70 For #8372: Set toolbar position relative anchor for url copied snackbar 2020-02-13 20:42:05 -08:00
Severin Rudie
1be812eba0 For #8408: fix requireContext crash in HomeFragment#onViewCreated 2020-02-13 20:15:54 -08:00
Emily Kager
2264e6e1b1 For #6623 - Adds ability to delete a login 2020-02-13 16:04:26 -08:00
Mugurell
b231afb05f For #6577 - Add total_uri_count to the Glean metrics ping
Re-apply the change for #4456.
Keep `total_uri_count` as a CounterMetricType and let Glean manage it's
persistence and reset time (resets with each metrics ping sent).
2020-02-13 15:54:55 -08:00
Mugurell
ad1144c722 For #6577 - Remove the total_uri_count Glean StringMetricType
This was added as a duplicate to an already existing `total_uri_count`
CounterMetricType in #4456.
2020-02-13 15:54:55 -08:00
Kate Glazko
5b28ad68b7 For #8248 Icon Wrong Color 2020-02-13 14:55:55 -08:00
Christian Sadilek
ce96d909d1 No issue: Support basic navigation in add-on popups 2020-02-13 17:26:43 -05:00
mcarare
372b1e7f0e For #6980: Update Private browsing card.
Added test to description.
Added link to settings.
Updated unit tests.
2020-02-13 14:13:57 -08:00
Jeff Boek
127169f5ff For mozilla-mobile#8172: Add a new 'E_Fennec_To_Fenix_Migrated' Leanplum event
This new event will be sent when the user has successfully migrated from Fennec
to Fenix.
This event will only be sent to Leanplum and not to the other telemetry
services like Glean or Adjust.

Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro>
2020-02-13 14:10:24 -08:00
ValentinTimisica
33616e0042 For #8172: Add a new "Fenix" Leanplum attribute 2020-02-13 14:10:24 -08:00
Emily Kager
9bac7ef47b For #8403: Don't postpone transition for view intents 2020-02-13 12:58:28 -08:00
Christian Sadilek
40031e6130 For #8143: Allow add-on popups to display prompts 2020-02-13 14:15:02 -05:00
Emily Kager
9adc617765 For #8358 - Make sure we don't cancel toolbar editing more than once 2020-02-13 10:32:31 -08:00
Mozilla L10n Automation Bot
9eb5fb5adc Import l10n. 2020-02-13 18:51:50 +01:00
Emily Kager
cbc8d3aa45 For #8366 - Move CreateShortcutFragment dismiss after AddToHomescreen 2020-02-12 22:54:30 -08:00
Simon Chae
b5379eb513
Allow fragment to go back when all unsupported add-ons are removed (#8351) 2020-02-12 17:32:03 -05:00
Simon Chae
0dac2fd0f4
For #8346: Update add-on-permissions fragment to be scrollable (#8352) 2020-02-12 17:19:07 -05:00
Simon Chae
2c01022c4b For #8153: Allow web-ext to open new tabs in correct browsing mode 2020-02-12 13:41:16 -08:00
mcarare
5e4ef202b8 For #8262: Set toolbar position relative anchor for collection snackbars 2020-02-12 07:56:17 -08:00
Jeff Boek
1f250a730d For #5905 - Fixes UI tests 2020-02-11 18:14:14 -08:00
Severin Rudie
8288739a60 Fix UI test failures 2020-02-11 18:14:14 -08:00
Jeff Boek
a701988ae9 For #5905 - Creates private browsing settings fragment 2020-02-11 18:14:14 -08:00
Jeff Boek
ef6913ec25 For #5905 - Combine theme and toolbar settings 2020-02-11 18:14:14 -08:00
Jeff Boek
cfb9b16863 No Issue - Fixes breaking snapshot change 2020-02-11 17:59:16 -08:00
mcarare
1168fbd638 For #8299: Select current ETP policy set on card creation 2020-02-11 17:54:09 -08:00
Arturo Mejia
95528c3191 For issues #8310 Disable the remove button while disabling an add-on
and vice versa.
2020-02-11 19:54:48 -05:00
Arturo Mejia
f85994e1cc For issues #8191 Increase text contrast for the "Remove" button
on installed Add-ons fragment
2020-02-11 19:54:48 -05:00
Jeff Boek
9374e66b4d
Import l10n. (#8321)
Co-authored-by: mozilla-l10n-automation-bot <54512241+mozilla-l10n-automation-bot@users.noreply.github.com>
2020-02-11 18:02:45 -05:00
Aaron Train
bf7b23ab99
Closes #8316: Disable animations for instrumented tests (#8317) 2020-02-11 15:24:10 -05:00
isabelrios
ee544dd3f1
sync-integration-history-bookmark-fenix-desktop (#7808)
clean code

remove unused import

fix reviewer comments
2020-02-11 14:19:31 -05:00
MarcLeclair
834d7e13cd
Remove Tracking protection popup for visual testing (#8226)
* For #6903: allow override TP popup for performanceTest

* For #6903: refactored the code
2020-02-11 11:12:39 -05:00
Sparky93
1ed185d4c2 Fix for #7980 - MigrationStore's COMPLETE action now redirects to MigrationProgressActivity
In order to ensure that the user's migration screen is not being bypassed by mistake, we handle the
migration's store COMPLETED state the same way we handle the MIGRATING state.

We can do this because we can treat the initial state (NONE) as being either a fresh start of the
app, either the user's intention of starting the home activity.

Before this change, if the app was being open from the shortcut after the migration was complete,
the user would have been encountered the home activity instead of the migration one.
2020-02-11 16:41:20 +01:00
codrut.topliceanu
705567651f For #7978 - Remove ScrollView from migration activity. 2020-02-11 16:40:15 +01:00
codrut.topliceanu
e193c9c084 For #7975 - Added a progress bar according to specs 2020-02-11 16:40:15 +01:00
Vlad Baicu
0fc9459d99 Fix for #8024 - Provide activity class for the migration's service notification content intent. 2020-02-11 16:27:53 +01:00
Sawyer Blatz
fc295b8855 For #5892: Update horizontal line styling 2020-02-11 12:02:16 +01:00
Arturo Mejia
941c147989 mozilla-mobile/android-components#5867 Fix addonProgressOverlay IllegalStateException 2020-02-10 17:50:55 -05:00
Arturo Mejia
93a68736a3 For issue #8272: Keep the add-ons management ui in sync with add-ons
changes
2020-02-10 16:31:53 -05:00
David Walsh
5c79483c7e Show horizontal divider in error pages 2020-02-10 12:26:15 -08:00
Emily Kager
316215ca54 For #7999 - for Leanplum fxaHasSyncedItems use SyncEnginesStorage 2020-02-10 20:47:46 +01:00
David Walsh
f51069cd82 For #8016 - Prevent duplicate domains from displaying inthe collection description on the home screen 2020-02-10 10:50:07 -08:00
Sawyer Blatz
453231b5fd For #7753: Increases touch target of crash page 2020-02-10 10:36:46 -08:00
Jeff Boek
f9b05e7d5a
For #8212 - Fixes shadow/border when toolbar is on top (#8234) 2020-02-10 12:32:26 -06:00
Simon Chae
cb19c6e868 For #8259: Add scrollview within the nested relative layout 2020-02-10 13:32:04 -05:00
Sebastian Kaspari
f0af6d6f6e Update Mozilla Android Components to 32.0.0-SNAPSHOT. 2020-02-10 17:13:58 +01:00
Johan Lorenzo
a9d06a0b29
Import l10n. 2020-02-10 08:50:51 -05:00
Sparky93
c9313029a8 Fix for #5695 - Migration steps' status displayed before the migration completed
The migration steps' status was already being shown as succeeded instead of showing an "unchecked" list of
steps.
These changes will make the steps being "checked" one by one as the migration advances.
2020-02-10 14:31:42 +01:00
mcarare
b934d95256 For #6980: Show correct image mocks for toolbar positions 2020-02-10 12:02:32 +01:00
Jeff Boek
952c48c8ce For #4674 - Adds ability to toggle metric services by type 2020-02-10 12:33:53 +02:00
Jeff Boek
9f3faa43fe For #4674 - Adds marketing data as a collection choice 2020-02-10 12:33:53 +02:00
Emily Kager
5839f5891c No issue: Update androidx dependencies 02.08.20 2020-02-10 11:33:12 +01:00
Grisha Kruglov
7a272a4564 Enable fennec Pinned Sites migration 2020-02-10 08:19:30 +01:00
Jonathan Almeida
e73b3cfbec
No issue: Simplify migration accessible string (#8249) 2020-02-08 13:19:46 -05:00
Kadeem
fe17e2acbd Updated About Settings Tests to check if a view is completely displayed 2020-02-08 12:35:59 +01:00
Jeff Boek
60a97e6618 For #4674 - Pre lands strings for marketing data collection toggle 2020-02-07 22:13:17 -08:00
Emily Kager
17d7928cc9 For #7603 - Temporarily do not show biometric prompt for OnePlus devices 2020-02-07 20:39:36 -08:00
Emily Kager
ca60e3fbe3
For #8147 - Update to app namespace for drawables (#8217) 2020-02-07 22:07:40 -05:00
Emily Kager
9e4e23eceb
Closes #8176 - Adds new string for add to top sites (#8209) 2020-02-07 22:05:35 -05:00
Christian Sadilek
8a33897f3a For #8201: Enable/Disable uBlock button status isn't updated 2020-02-07 19:55:41 -05:00
mcarare
3ea5b08135 For #8190: Add animation to ETP policy selection 2020-02-07 15:50:39 -08:00
David Walsh
88ed1e4815 For #7207 - Use accessible color for about links in dark mode 2020-02-07 15:50:08 -08:00
Arturo Mejia
2daf7c3142 For issue #8221: Fix crash in the AddonsManagementFragment when binding
the RecyclerView after the fragment is not attached anymore
2020-02-07 18:38:37 -05:00
Emily Kager
e94f5d3dba No issue: Land delete login string 2020-02-07 14:52:16 -08:00
Christian Sadilek
142104dc86 For #8202: Remove settings if add-on disabled
- Also fixes the crash described in #8202.
2020-02-07 16:42:54 -05:00
Gabriel Luong
8a92e15667
For #7924 - Add strings for undo snackbar when removing a top site (#8225) 2020-02-07 16:30:08 -05:00
Emily Kager
aba3c1d3a6
No issue: Land string for Pocket top site label (#8229) 2020-02-07 16:29:41 -05:00
Gabriel Luong
e3df9f0902
For #8167: Don't show the add-ons permission dialog if installation is in progress (#8230) 2020-02-07 16:06:28 -05:00
Emily Kager
1209146788 No issue: Land new share sheet strings 2020-02-07 19:26:54 +01:00
Michael Comella
a896b47cfe For #7820: warm BrowsersCache on background thread.
In an early iteration of his patch on a beta build, I saw no improvement over
6 runs (Pixel 2):
- Before: 401.5ms
- After: 402.17ms

This may be attributed to noise in startup performance. However,
BrowsersCache disappears from profiles completely and results in
theoretical performance gains.

When using the StartupTimeline class (not landed yet), I see a 27.75ms
runtime improvement on beta builds after this patch.
2020-02-07 09:13:29 -08:00
Jeff Boek
a42ad7603b For #5073 - Fixes visual alignment when certificate authority breaks into a new line 2020-02-07 09:10:31 -08:00
Jeff Boek
7a16192fd1 For #5073 - Use string parameter versus concatenating programatically 2020-02-07 09:10:31 -08:00
Kate Glazko
7c00a1ad6b For #5073: View Site Cert 2020-02-07 09:10:31 -08:00
Aaron Train
4fec12b127
Closes #7656: Add UI tests for Reader View (#7829) 2020-02-07 12:07:16 -05:00
mcarare
5bd5f81559 For #6980: Add onboarding Toolbar position picker card 2020-02-07 09:05:03 -08:00
Sawyer Blatz
0a6881d470
For #255: Removes autoplay media feature flag (#8198) 2020-02-07 10:22:37 -05:00
ValentinTimisica
29522d29ed For #1500: Passes resources to SessionSuggestionProvider
Change required for adding 'Switch to tab' description for a suggestion that
represents an opened tab. Implemented in AC
(https://github.com/mozilla-mobile/android-components/pull/5773)
2020-02-07 11:26:58 +01:00
Jeff Boek
62d540257f For #7965 - removed unused strings, reverted changes to radiobutton widget 2020-02-06 18:48:23 -08:00
David Walsh
4b9f07c511 For #7965 - Remove CDATA strings 2020-02-06 18:48:23 -08:00
Kadeem M
095477e0ef
Adding UI tests for the Basic Menu settings. 🎲 !!!! (#6346)
* Added UI tests for the basic settings menu

* Disabled toggleSearchSuggestions test
2020-02-06 12:58:47 -08:00
Christian Sadilek
6019adafac For #6124 #8158: Prevent infinite loop on fast taps on enable switch 2020-02-06 15:03:47 -05:00
Sebastian Kaspari
58e89cd0ec Closes #8162: Add shortcuts.xml for fennecBeta variant. 2020-02-06 11:54:59 -08:00
Tiger Oakes
5faa22d611
Use createBlendModeColorFilterCompat (#8129) 2020-02-06 11:18:08 -08:00
Sebastian Kaspari
5515f1ba5e Closes #4979 - Support Fennec web apps (PWAs). 2020-02-06 10:34:13 -08:00
Emily Kager
eec8ea980b For #8128 - Do not use activity root view for fragment snackbars 2020-02-06 10:33:24 -08:00
Tiger Oakes
2ead67a531
For #7511 - Override private customtab icon tint (#8138) 2020-02-06 09:49:00 -08:00
Kadeem
f4f93e761e NOISSUE - Renamed a misspelled variable. 2020-02-06 18:25:11 +01:00
Emily Kager
a04b595425 For #8147 - Use app:srcCompat instead of android:src 2020-02-06 17:49:30 +01:00
mcarare
9d993cae92 For #8146: Extend radio buttons clickable area to title and description 2020-02-06 16:34:37 +01:00
codrut.topliceanu
f5715df104 For #5694 - Changes migration list item 'Logins' to 'Passwords' 2020-02-06 14:45:10 +01:00
Sebastian Kaspari
75e0baf59c Try to migrate default search engine. 2020-02-06 11:48:10 +01:00
Mozilla L10n Automation Bot
7d7b657874 Import l10n. 2020-02-06 11:53:32 +02:00
Mohammaduvez
00d7f4c91c
Fixes #5711 Added tint to onboarding icons (#8093)
* Added tint to onboarding icons and udpated finish button tint

* Replaced tint parameter with onboarding_card_icon color in setOnboardingIcon
2020-02-05 21:46:12 -08:00
Tiger Oakes
453e7955bb
Add license header to ext tests (#8130) 2020-02-05 20:37:49 -08:00
Marc Leclair
8e61c71a98 reverting linting changes that touched codes that I didn't edit 2020-02-05 16:40:41 -08:00
Marc Leclair
211a8b2583 fixing UI test 2020-02-05 16:40:41 -08:00
Marc Leclair
afab1c0f4e #8085 removed findViewById with actual id 2020-02-05 16:40:41 -08:00
Marc Leclair
9fc5a1b0fe #7700 fixed linting issues 2020-02-05 16:40:41 -08:00
Marc Leclair
92b38206c7 #7700 fixed scrolling, parallax action to match both images and some code clean up 2020-02-05 16:40:41 -08:00
Marc Leclair
72007590f7 #7700 squash commit and fixing toolbar to switxh to top with coordinatorlayout 2020-02-05 16:40:41 -08:00
Tiger Oakes
c0d7bc5bd5 Use navArgs helper in fragments 2020-02-05 16:37:45 -08:00
Tiger Oakes
383a70482c Clean up toolbar menu class 2020-02-06 00:25:42 +01:00
Arturo Mejia
1fef90721a
For issue #8100: Add progress bar to the add-ons manager fragment 2020-02-05 16:32:50 -05:00
Arturo Mejia
be7bd527f6
For issue #8097: Run add-ons callbacks only when the fragment is attached. 2020-02-05 14:22:45 -05:00
Grisha Kruglov
3f9ed2992c Bump to a-s 0.50.0 2020-02-05 13:29:17 -05:00
Emily Kager
46fd1a04f1 For #7456 - For top toolbar set correct progress gravity and background 2020-02-05 19:14:14 +01:00
Alessio Placitelli
99d6dbfca4 Test that 'baseline' pings are sent by Fenix
This is an initial instrumented test for Fenix
that checks if a 'baseline' ping is generated when
going to background.
2020-02-05 19:06:46 +01:00
Mozilla L10n Automation Bot
858db3587a Import l10n. 2020-02-05 17:42:17 +01:00
Christian Sadilek
d10a30e356 Closes #4983: Fennec migration: Keep installed add-ons 2020-02-05 09:14:04 -05:00
Emily Kager
fb80754a4e No issue: Move bookmark delete string to be translated 2020-02-05 11:23:36 +01:00
Mugurell
ac39b420b4 Fix #7613 - Align radio buttons with the theme images 2020-02-05 10:21:23 +01:00
lyrjie
b25a5468ba Added the autoMirrored flag to arrowhead drawable 2020-02-05 09:14:45 +01:00
Arturo Mejia
6191fec0d8
No Issue: Close the web extension popup when we can't get the popup of the session. 2020-02-04 17:17:46 -05:00
Mozilla L10n Automation Bot
fa854f511b Import l10n. 2020-02-04 18:49:15 +01:00
Emily Kager
604ac83d0c For #7999 - Change fxa leanplum metrics to false by default 2020-02-04 09:17:55 +01:00
Gabriel Luong
64a4a7f422
Provide add-on support (#8064)
Closes #5630, #6069, #6092, #6091, #6124, and #6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2020-02-04 01:41:51 -05:00
Mihai Adrian
4eb71ce235
For #6980: Update ETP onboarding card (#7958) 2020-02-03 21:03:15 -08:00
Jonathan Almeida
cbcc56bbba For #373: Implement LeanPlum push messaging
Also closes #6250, since we rely solely on the SDK itself to consume the
messages straight from FCM.
2020-02-04 00:13:56 +01:00
David Walsh
4e6215c0c1 Fix linting issue 2020-02-04 00:12:26 +01:00
Sawyer Blatz
9f342fca9e For #6820: Updates background, shadow, & snackbars of toolbar 2020-02-04 00:12:26 +01:00
David Walsh
4b3effdfab For #6820: Place address bar at top or bottom of the home screen based on user preference 2020-02-04 00:12:26 +01:00
Aaron Train
97915107eb Closes #8066: disable failing UI Bookmarks tests 2020-02-03 23:41:43 +01:00
ValentinTimisica
0a76fdaa58 For #7289: Adds telemetry for selecting dark theme 2020-02-03 23:20:42 +01:00
Kadeem
321251c49c Updates the hide and reveal password icons to use and tint the mozac version. 2020-02-03 23:11:41 +01:00
Mozilla L10n Automation Bot
6b2bf2acb8 Import l10n. 2020-02-03 22:56:11 +01:00
David Walsh
ae445abff3 Small improvements, lint fixes 2020-02-03 21:01:14 +01:00
Sawyer Blatz
030f75b4df For #5892 & #6380: Updates error page template and allows SSL bypassing 2020-02-03 21:01:14 +01:00
ValentinTimisica
2026c60136 For #6834: Adds telemetry for About page items
Didn't change the existing probe for 'whats new' item because we're already
collecting that info.
2020-02-03 19:28:56 +01:00
Mihai Branescu
7b9f74138c For #7559 - added unit test for same locale selected 2020-02-03 19:24:12 +01:00
Mihai Branescu
2a876d5e0f For #7559 - fixes 2 issues:
- The same item now doesn't recreate the activity
- The app context now contains the right locale
2020-02-03 19:24:12 +01:00
Mihai Branescu
1b7cb117ca For #7559 - allows changing locale even after setting theme with
AppCompatDelegate.setDefaultNightMode(mode). The override is necessary because the uiMode needs
to be manually updated after changing theme
2020-02-03 19:24:12 +01:00
Aaron Train
eb2eed1c9c
Closes #8015: fix UI test verifyContextCopyLink (#8026) 2020-01-31 14:58:02 -05:00
Sawyer Blatz
1372ed5837 For #7970: Updates snackbars for accessibility 2020-01-31 16:24:36 +01:00
David Walsh
82c698c818 Fix 5727 - History to browser navigation should go back to history 2020-01-31 16:02:18 +01:00
Aaron Train
89cc5657ce
Closes #8006: Add Close/Undo UI tests (#8007) 2020-01-30 16:15:40 -05:00
David Walsh
f728cdaf05
Bug 7189 - Provide page title in website information dialog (#7255)
* Bug 7189 - Provide page title in website information dialog

* Update QSFS test

* Fix Tiger's nits
2020-01-30 11:24:53 -08:00
Emily Kager
d272623c3d No issue: Add idle for create folder UI test 2020-01-30 16:54:25 +01:00
Sawyer Blatz
94447657c4 No issue: Fixes strings for data migration 2020-01-30 11:29:50 +01:00
Mihai Adrian
24396d174f
For #6980: Add What's new card (#7952) 2020-01-29 08:50:11 -08:00
Jonathan Almeida
202f2b8811 Closes #7788: Route search widget intents through IntentReceiverActivity 2020-01-29 14:27:14 +01:00
Mihai Branescu
b3d99c6bba
For #7679 - Replaced comparison by reference with value, added check for default in order to avoid double checkmark (example: default + English) (#7729) 2020-01-28 19:22:04 +02:00
mcarare
06169433b5 For #5905: Pre-land strings for Settings screen changes 2020-01-28 01:49:29 -08:00
Sören Hentzschel
8a7c7fd06f For #7730 - always show "Add private browsing shortcut" in sett… (#7943) 2020-01-27 08:44:28 -08:00
ValentinTimisica
154e11841a Fixes #7881: Send telemetry event when custom search engine is deleted 2020-01-27 12:04:28 +02:00
Sebastian Kaspari
18244cef51 Closes #7762: Initialize Glean later in Fennec builds. 2020-01-26 11:53:26 +01:00
Jonathan Almeida
40e72a7b28 For #7524: Remove DeviceConstellation polling from onResume (#7908) 2020-01-25 11:04:24 -08:00
Mihai Adrian
622fdadde8 For #7272: Show info when saved logins list is empty. (#7891)
* For #7272: Show info when saved logins list is empty

* For #7272: Updated unit tests
2020-01-24 18:13:44 -08:00
Sebastian Kaspari
10bf49918f Issue #7818: Use different target activities for launcher activity alias (fenix vs. fennec). (#7917)
* With this patch fenix build variants will launch HomeActivity directly from the launcher.
  This will get rid of the performance regression outlined in #7818.

* Fennec build variants will launch into MigrationDecisionActivity which will show the
  migration UI or launch normally into the app. This is faster than going through
  IntentReceiverActivity (measured and perceived).
2020-01-24 18:03:25 -08:00
Sebastian Kaspari
21f342be12 Issue #7890: Make migration screen scrollable. (#7914) 2020-01-24 18:03:02 -08:00
Suraj Shah
2d64cf8e4c Connectivity manager tests (#7317)
* Fixes #7316
Adds tests for ConnectivityManager.isOnline

* Fixes detekt errors.

* Cleaning tests

* Cleaning tests to use boolean checks instead of object equals
2020-01-24 17:43:28 -08:00
Michael Comella
fe105729ad No issue: don't export OssLicense*Activity. (#7909)
afaik, these Activities are only intended to be shown internally and
have no reason to be accessible to other apps on the system.
2020-01-24 17:41:23 -08:00
Jonathan Almeida
2b2ea9eb5e No issue: Update Firefox Logo in Migration UI (#7916) 2020-01-24 17:33:15 -08:00
Emma Malysz
5e9b753acb For #7473, delay inflation of toolbar
Improve performance of HomeActivity.onCreate by delaying this inflation.
We use a ViewStub and inflate the first time the actionbar is accessed.
2020-01-24 15:21:42 -08:00
Gabriel Luong
f93e141d52 For #7525 - Add telemetry for opening a top site in normal and private mode and removing a top site 2020-01-24 15:18:25 -08:00
Gabriel Luong
192eecdf5b For #6758 - Part 7: Add menu for opening a top site in private tab and removing a top site 2020-01-24 15:18:25 -08:00
Gabriel Luong
9ecb67e783 For #6758 - Part 6: Add top site view 2020-01-24 15:18:25 -08:00
Gabriel Luong
f68f89f2bf For #6758 - Part 5: Add top sites to the HomeFragmentStore 2020-01-24 15:18:25 -08:00
Gabriel Luong
e1863dd3c2 For #6758 - Part 4: Implement "Add to Firefox Home" browser menu item
- The "Add to Firefox Home" browser menu item adds a top site to the top site storage.
- Refactors the FenixSnackbar from BaseBrowserFragment into BrowserToolbarController
since there are multiple menu items that need to show a FenixSnackbar.
- Adds metrics for the new browser menu item.
2020-01-24 15:18:25 -08:00
Gabriel Luong
9ddf93eb7d For #6758 - Part 3: Add TopSiteStorage wrapper around AC's TopSiteStorage
This follows the existing pattern around TabCollectionStorage.
2020-01-24 15:18:25 -08:00
Gabriel Luong
584b270aa4 For #6758 - Part 2: Add AC dependencies for top sites feature 2020-01-24 15:18:25 -08:00
Gabriel Luong
0a856d9413 For #6758 - Part 1: Add new strings for top sites feature 2020-01-24 15:18:25 -08:00
Aaron Train
0fa0a84887 Closes #7920 - Disable ETP UI test for investigation into failure in #7907 2020-01-24 12:51:25 -08:00
Sebastian Kaspari
9a15103a20 Issue #7762: Enable glean based on setting for non-fennec builds. 2020-01-23 16:32:15 +01:00
Severin Rudie
44e4d8e12c
No issue: clarify naming for showing a prompt to allow search suggestions (#7870) 2020-01-22 19:08:07 -08:00
Emily Kager
a39a9e5b4e No issue: Enable about:config in beta builds 2020-01-22 16:34:51 -08:00
David Walsh
1ee0243efa Fix 4021 - Provide tab title during share 2020-01-22 14:42:27 -08:00
ekager
c556e819bd For #5586 - Add telemetry for save logins setting 2020-01-22 14:19:12 -08:00
Emily Kager
7adb5b6084 For #6812 - Navigate via openToBrowser to selected session from search 2020-01-22 14:13:16 -08:00
Sawyer Blatz
e1722b95b3 No issue: Fixes ErrorResponse instantiation 2020-01-22 11:47:51 -08:00
Arturo Mejia
310da6c1ea No Issue: Add support for deleting individual tracking protection
exceptions on nightly.
2020-01-22 11:47:51 -08:00
Chenxia Liu
f726b03792 Fix breaking changes from new TrackingProtectionException 2020-01-22 11:47:51 -08:00
Michael Comella
847056b332 Issue #7423: remove redundant bottom_bar ConstraintLayout. 2020-01-22 11:20:47 -08:00
Michael Comella
91a557dc0a For #7423: remove unnecessary CoordinatorLayout in fragment_home.
Co-authored-by: Emma Malysz <emalysz@mozilla.com>
2020-01-22 11:20:47 -08:00
Michael Comella
d7fd8e763a For #7423: remove unnecessary wordmark_spacer view.
Co-authored-by: Emma Malysz <emalysz@mozilla.com>
2020-01-22 11:20:47 -08:00
Sawyer Blatz
20396f78a9
For #7698: Adds search back button animation (#7840)
* For #7698: Adds search back button animation

* Refactor for searchController
2020-01-22 11:15:30 -08:00
Josh Vocal
2372ee6b15 For #4212: Control text not translated 2020-01-22 10:27:46 -08:00
Emily Kager
0b1a67367e
Closes #7814 - Updates dark shield icons (#7838) 2020-01-22 07:42:08 -08:00
Michael Comella
e25ee98d7d No issue: fix typo in Performance.instrumentColdStartup... (#7848) 2020-01-22 02:36:16 -05:00
mozilla-l10n-automation-bot
cf63db20b4 Import l10n. (#7843) 2020-01-21 21:38:51 -08:00
Kaaira Gupta
08cce8cf58 for #7421 :removed collection from clear browsing history 2020-01-21 19:00:59 -08:00
Michael Comella
ffc441f12a For perf-frontend-issues#50: instrument imperfect reportFullyDrawn.
We don't capture the second RV draw yet. Unfortunately, I don't know if
it's the best use of my time to capture that as well.
2020-01-21 18:34:38 -08:00
Chenxia Liu
e5164e3670 For #6980 - Pre-land string changes to onboarding cards. 2020-01-21 16:28:36 -08:00
Mihai Carare
cd853d0d8f For #7029: Navigate to Search Fragment when pressing Start browsing 2020-01-21 16:26:43 -08:00
Kaaira Gupta
e291c6905c For #3813 - Create a save button for bookmark editing 2020-01-21 16:03:33 -08:00
Mozilla L10n Automation Bot
db875ac929 Import l10n. 2020-01-21 14:33:05 -08:00
Severin Rudie
2dc5b397b6
For #7506: show highlight on home 3-dot button (#7665) 2020-01-21 13:02:14 -08:00
mcarare
8274ff6f2b For #7714: Align engine name to viewStart to support RTL layouts 2020-01-21 12:27:19 -08:00
Mihai Adrian
355cb35cb6 For #7574: Send toolbar position metrics in English. (#7712) 2020-01-21 08:24:18 -08:00
Sebastian Kaspari
e5ba74711d MigratingFenixApplication: Pass MigrationStore to FennecMigrator. 2020-01-21 14:38:08 +02:00
mozilla-l10n-automation-bot
5a429b99e9 Import l10n. (#7744) 2020-01-20 11:07:18 -08:00
Jonathan Almeida
02b4582c8d No issue: Update Migration UI with new API 2020-01-20 18:08:38 +01:00
Sebastian Kaspari
af3726a505 Fennec home screen bookmarks: Select new tab. 2020-01-20 15:17:58 +01:00
Sebastian Kaspari
80eb19294b AboutFragment: Use SupportUtils.getWhatsNewUrl(). 2020-01-20 14:15:58 +01:00