Sawyer Blatz
e8216e3079
For #5094 : Adds telemetry for suggestion toggles ( #5704 )
2019-10-03 10:03:14 -07:00
Sawyer Blatz
785b8b9519
For #5567 : Removes search shortcuts button ( #5739 )
...
* For #5567 : Removes search shortcut button
* No issue: Simplifies logic for displaying shortcuts
2019-10-03 08:53:16 -07:00
Sawyer Blatz
2896b36d14
No issue: Updates naming of launch links privately var ( #5701 )
...
The previous name was pretty confusing
2019-10-02 12:11:21 -07:00
Sawyer Blatz
eb3c9f86e2
No issue: Removes feature flags for delete data ( #5738 )
2019-10-02 10:43:37 -07:00
Emily Kager
f7c9ab11eb
For #3487 - Add back open image in new tab
2019-10-01 12:45:09 -07:00
Michael Droettboom
a250241523
1585250: Initialize metrics off of the main thread
2019-10-01 10:29:54 -07:00
Sawyer Blatz
669e694af9
For #5672 : Fixes broken send tab link
2019-09-30 16:13:40 -07:00
Sawyer Blatz
69c42b6192
For #5681 : Sets OPEN_TO_BROWSER false when using new tab shortcut
2019-09-30 14:56:16 -07:00
Emily Kager
e9a0f1f65d
For #2078 - Filter Out Self in Share Sheet ( #5641 )
2019-09-30 12:43:47 -07:00
Sawyer Blatz
c8af16bd47
For #5679 : Hides autoplay behind feature flag ( #5685 )
2019-09-30 12:01:04 -07:00
ekager
ef29fe2584
Update BackgroundServicesTest, Suppress Complex Method
2019-09-30 10:33:56 -07:00
Grisha Kruglov
a4097cd380
FxA WebChannels integration
...
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971 )
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-30 10:33:56 -07:00
Chenxia Liu
8f97d247a6
For #235 - Add Glean crash count + docs.
2019-09-30 08:32:33 -07:00
Sawyer Blatz
3e42114190
For #5656 : Fixes nightly major version number crash
2019-09-27 15:06:57 -07:00
Sawyer Blatz
a38b73f19e
Fixes #5653 : Removes crash with null campaign
2019-09-27 15:01:00 -07:00
mcarare
64923978e6
For #1071 Added Desktop Mode icon
2019-09-27 09:47:10 -07:00
Sawyer Blatz
5e18ead45e
For #4474 : Adds tests and fixes issues
2019-09-27 08:59:05 -07:00
Tiger Oakes
ee1f040e53
No issue: Move signedIn tracking to BookmarksSharedViewModel ( #4755 )
2019-09-27 08:57:38 -07:00
Sawyer Blatz
7f328a6dc4
For #1298 : Adds adjustCampaignId to core ping ( #5579 )
2019-09-27 08:56:33 -07:00
Sawyer Blatz
6babf72352
For #5197 : Adds telemetry for media notification ( #5520 )
2019-09-27 08:02:29 -07:00
Tiger Oakes
88aa519210
Closes #4711 - Extract VoiceSearchActivity ( #5502 )
2019-09-27 07:54:29 -07:00
Emily Kager
3f41a4e9c6
No issue: Update navigation library
2019-09-26 17:01:13 -07:00
Sawyer Blatz
11baabb63a
No issue: Updates fact mapping to use enums
2019-09-26 17:00:51 -07:00
Emily Kager
c3287b17ac
Closes #5624 - Fix crash on preference change listener
2019-09-26 16:56:54 -07:00
Mihai Adrian
62ae025d65
For #4991:Ensured deleteSelectedBookmarks deletes all selected bookmarks ( #5559 )
...
Moved the deletion to a CoroutineScope(IO) to decouple from fragment lifecycle
Used local val tempStorage to keep reference to bookmarkStorage of outside class
Ran deletions with awaitAll to avoid concurrency issues on storage
2019-09-26 16:52:59 -07:00
Severin Rudie
dffa61bf16
Closes #4513 : fixes bookmark tests broken by loading change
...
Note that BookmarkFragmentStoreTest changes preserve existing behavior, which in many cases is more expansive than the test name implies
2019-09-26 16:29:14 -07:00
Severin Rudie
fd7f1b2665
Closes #4513 : adds tests for bookmark loading state
2019-09-26 16:29:14 -07:00
Severin Rudie
fbdd537bc7
Closes #4513 : show progress bar when loading bookmarks
2019-09-26 16:29:14 -07:00
Severin Rudie
ca6c324f29
Issue #4513 : added isLoading to bookmark state
...
This was added to the state object as a top level param because it could reasonably coexist with any value of `tree` or `mode`. Even if we don't now, we may someday want to display a loading indicator while also showing cached bookmarks.
For now, we set isLoading to false whenever we receive any bookmarks
2019-09-26 16:29:14 -07:00
Severin Rudie
96472a533a
Issue #4513 : fix mismatched bookmark listener lifecycles
...
The mismatch here was creating potentially inconsistent states. When first put into a CREATED or STARTED state, the listener would not be active, however after going through onResume it would then stay active until destroyed.
We should only be navigating to bookmarks when in a RESUMED state, so this change should be safe. I tried it a few times to verify. But I've been wrong before!
2019-09-26 16:29:14 -07:00
Colin Lee
de93b05cac
For #2754 Add tab cards to share sheet ( #5493 )
...
* For #2754 Add tab cards to share sheet
* For #2754 : Fix background near rounded corners and ShareButtonAppearanceTest
* Add license to share_tab_item
2019-09-26 14:25:34 -07:00
Christian Sadilek
ac2611d744
Upgrade to A-C 15.0.0-SNAPSHOT (incl. required changes) ( #5578 )
...
* Upgrade to Mozilla Android components 15.0.0-SNAPSHOT
* Update findinpage integration to use browser-state
* Use new UseCases APIs after download migration.
2019-09-26 12:50:50 -07:00
Mugurell
c5330c6880
For 5092 - Show a Snackbar with retry option if sharing to devices fails ( #5158 )
...
* For #5092 - Show a Snackbar with retry option if sharing to devices fails
ShareController will contain all the business logic for checking the result
status of the `share to device` operations. When this fails it will show a
snackbar which also offer the possibility to retry the just failed operation.
To allow this even in the event the user has closed the share fragment we'll
use a GlobalScope's coroutine.
Refactored out the TabsSharedCallback from ShareFragment because otherwise we
would have neede to sent through that the just failed operation. After the
refactor the ShareController is solely responsable for showing the right
snackbar and handling the retry actions.
* For #5092 - Refactor ShareControllerTest
* For #5092 : Adds color theming of snackbars
2019-09-26 12:30:28 -07:00
ekager
0b01635ce0
For #2874 , #5375 , #5131 - submitList workaround for Android 5 + 6
2019-09-25 19:59:07 -07:00
ekager
44bb592b43
For #5312 - Send ETP Strict/Standard event
2019-09-25 15:23:30 -07:00
ekager
24b3ed4384
For #5568 - Don't pass in Session for QuickActionSheetController
2019-09-25 13:33:38 -07:00
Emily Kager
b0b60aa27d
For #5281 - Use TrackerLog for reporting ETP categories ( #5556 )
2019-09-25 10:48:06 -07:00
Sawyer Blatz
b6e6e36ccd
For #561 : Fix stutter of search icon & text when animating
2019-09-25 10:06:38 -07:00
Sawyer Blatz
75a25c9bd0
For #561 : Fix linting issue
2019-09-25 10:06:38 -07:00
Jeff Boek
c592a69aad
For #561 - Fixes snackbar placement on homeview
2019-09-25 10:06:38 -07:00
Jeff Boek
5c092c1ef1
For #561 - Adds shadow/highlightto the bottom bar
2019-09-25 10:06:38 -07:00
Jeff Boek
00d1be97ac
For #561 - Wires up add tab button inside the bottom bar
2019-09-25 10:06:38 -07:00
Jeff Boek
b16754d78a
For #561 - Adds add tab and menu button to bottom bar
...
- Adds space between wordmark and session control component
2019-09-25 10:06:38 -07:00
Jeff Boek
abbb310ce3
For #561 - Removes the toolbar from the home screen
...
- Removes the menu button
- Fixes motionlayout animation with the wordmark/private browsing button
2019-09-25 10:06:38 -07:00
mcarare
bfe8bf4663
For #1383 Added tab title to close button content description
2019-09-25 10:34:02 +03:00
Jeff Boek
1c9c5317eb
For #5552 - Temporary fix for startup crash on es locales
2019-09-24 19:21:47 -07:00
Sawyer Blatz
856399e9e2
No issue: Fixes GleanMetricsService nits & broken UI test ( #5539 )
...
* No issue: Fixes GleanMetricsService nits
* No issue: fixes broken UI test
2019-09-24 16:12:09 -07:00
Alessio Placitelli
1ffdf1cf9b
Add basic test coverage for Glean metrics in Fenix
...
This introduces test coverage, using the Glean SDK
testing API, for the metrics that are set at startup
by Fenix in the GleanMetricsService.
This additional adds a basic test for the translation
of the `app_opened` event.
2019-09-24 12:33:14 -07:00
Emily Kager
25e2a7abfc
For #2765 - Run places maintenance daily ( #5466 )
2019-09-24 10:50:11 -07:00
Mihai Adrian
c7c752cabb
For #5356 Improves private browsing "common myths" link accessibility ( #5479 )
...
Added separate TextView for link text
Used UnderlineSpan to show text as link
Split string private_browsing_placeholder, one for each TextView
Set clickListener on TextView so it can be accessed via Talkback
2019-09-24 10:46:34 -07:00
Tiger Oakes
8c30200ced
Only use Context.settings() function (not getter) ( #5335 )
...
Remove unused String extensions
2019-09-24 10:33:46 -07:00
Tiger Oakes
734d4031e2
Extract UriOpened observer from HomeActivity
2019-09-24 09:37:24 -07:00
Tiger Oakes
e3c60faf24
Move BookmarkNode extensions to helper class ( #4752 )
2019-09-24 09:17:29 -07:00
Mihai Adrian
236f702bbe
For#5468 Changed info source for url clipboard copy from view to session ( #5514 )
2019-09-24 07:56:59 -07:00
Tiger Oakes
cb7701584f
No issue: Extract home fragment mode ( #5343 )
2019-09-23 09:33:55 -07:00
Emily Kager
9d9ff959b5
For #5312 - Add Telemetry for Tracking Protection
2019-09-23 08:29:45 -07:00
Christian Sadilek
c866ae1a1e
Closes #5444 : IntentReceiverActivity: Add tests for intent processing
2019-09-20 19:44:05 -04:00
Sawyer Blatz
f02603be37
For #5460 : Fixes styling of fill link from clipboard ( #5464 )
2019-09-20 15:29:16 -07:00
Sawyer Blatz
4a6e647167
For #5197 : Adds telemetry for media controls ( #5266 )
2019-09-20 14:49:27 -07:00
Tiger Oakes
6c30a94081
Move settings classes to packages
2019-09-20 12:36:15 -07:00
Tiger Oakes
699eacab39
For #778 - Rename CustomTabActivity
2019-09-20 12:35:12 -07:00
Tiger Oakes
e9fd6892ba
For #394 , #778 - Add hide toolbar feature
...
And also add CustomTabsServiceStore
2019-09-20 12:34:49 -07:00
ekager
78ac6fc912
For #5448 - Reload custom tab session when TP is toggled
2019-09-20 12:30:02 -07:00
Michael Droettboom
a63eaa9d67
1581556: Initialize Glean on the main thread
2019-09-20 12:29:40 -07:00
mihai-adrian
47064a68e0
For #5141 Changed "learn more" link to be accessible to Talkback users
2019-09-20 12:29:02 -07:00
Tiger Oakes
172a9cf06c
Extract and test crash reporter code
2019-09-20 11:04:11 -07:00
ekager
464122fda1
For #5421 - Make share dialog scrim dismiss fragment
2019-09-20 09:52:39 -07:00
Dennis Schubert
5577470d0b
No bug - Add WebCompat feature.
2019-09-20 08:33:48 -07:00
Tiger Oakes
f71ec8928b
Add note about lazy in FeatureFlags
2019-09-20 08:33:29 -07:00
Sawyer Blatz
6f3d7b4ee8
For #5396 : Adds "always launch in private mode" to settings
2019-09-20 08:33:07 -07:00
Mihai Adrian
a1c8fc0698
For #3731 Improved UX for opening tabs from a Collection ( #5427 )
...
* For #3731 Changed order of items for a collection's overflow menu
* For #3731 Changed the order tabs open to keep same order from collections
2019-09-20 06:41:04 -07:00
Tiger Oakes
05a4faec78
Add tryGetHostFromUrl and update ExceptionDomains
2019-09-19 22:40:35 -04:00
Colin Lee
1aa4f5a519
For #255 : Toggle Media Autoplay
2019-09-19 15:13:04 -07:00
Sawyer Blatz
2db2d9ceae
For #1744 : Adds tests for clipboard
2019-09-19 08:24:27 -07:00
Sawyer Blatz
fd1fcd8b89
For #4155 : Adds paste & go for search terms
2019-09-19 08:24:27 -07:00
Sawyer Blatz
e961a9d63d
For #1744 : Adds clipboard provider to search engine screen
2019-09-19 08:24:27 -07:00
Tiger Oakes
1777b5a830
Use enum to simplify delete on quit code
2019-09-18 20:20:08 -07:00
Tiger Oakes
106458c2c9
For #3440 - Reduce HomeFragment require calls
2019-09-18 17:25:44 -07:00
Jeff Boek
976c840047
For #3077 - Replaces connect another device dialog with a scree
2019-09-18 17:24:43 -07:00
Unpublished
065ce13999
Pass color resource for what's new menu item by id
2019-09-18 16:41:03 -07:00
Sawyer Blatz
50cd2920d3
For #5371 : Updates search engine settings string ( #5393 )
2019-09-18 11:26:44 -07:00
Sawyer Blatz
e1b84a7a08
For #5396 : Reverts broken activity alias
2019-09-17 18:35:31 -07:00
Tiger Oakes
284cbab9ea
Use .orEmpty()
2019-09-17 11:09:21 -07:00
Emily Kager
3e132f102c
No issue: Update androidx libraries Sept 5 2019
2019-09-17 09:50:31 -07:00
Mihai Adrian
1767bd5569
For #5174 Changed FindInPage height to toolbar height to cover QAB ( #5376 )
2019-09-17 05:47:17 -07:00
Emily Kager
2b71af4087
For #5258 - Pop AccountProblemFragment if signed out
2019-09-16 21:26:01 -07:00
Grisha Kruglov
8a9340fd9d
Post: Clean up 'push' initialization code
2019-09-16 19:44:13 -07:00
Grisha Kruglov
d67fb3eed2
Post: Add experiment flags, push and telemetry tests for BackgroundServices
2019-09-16 19:44:13 -07:00
Grisha Kruglov
eeaeb973ff
Post: minor cleanup
2019-09-16 19:44:13 -07:00
Grisha Kruglov
c2fb99a73f
FxA WebChannels integration
...
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971 )
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-16 19:44:13 -07:00
Tiger Oakes
a61391ef58
Separates tracker bucket sorting code
2019-09-16 15:16:12 -07:00
Emily Kager
140da0dd0f
For #5359 , #5360 - Update ETP Vectors for Android 5+6
2019-09-16 15:01:29 -07:00
mawen7
9ebd4efe70
Pass app name to delete browsing data prompt
2019-09-16 09:59:42 -07:00
Sebastian Kaspari
b8539ccb33
Use new feature-contextmenu API.
2019-09-16 17:24:13 +02:00
Tiger Oakes
42bb3e1410
Change deleteAndQuit to take an activity
2019-09-15 20:03:04 -07:00
Emily Kager
da37dedba3
For #5279 - Don't use runBlocking in delete and quit
2019-09-14 11:18:43 -07:00
ekager
8cd0d8faf3
For #5304 - Align ETP Onboarding Tool Tip PopupWindow
2019-09-13 18:25:26 -07:00
Yeon Taek Jeong
3787dd7b1f
For #5254 : Fix transition to private browsing mode after sharing a page
2019-09-13 14:44:28 -07:00
Sawyer Blatz
e247870b9f
For #5277 : Updates string for delete browsing data ( #5309 )
2019-09-13 10:18:25 -07:00
Sebastian Kaspari
dd85229c41
Use new feature-downloads API.
2019-09-13 15:01:25 +02:00
Sawyer Blatz
42b31f0088
For #4155 : Adds elevation to copy/paste menu
2019-09-12 14:03:12 -07:00
Mihai Adrian
c8bc144114
For #2570 : Hide 3-dots menu when in select mode for bookmarks and history ( #5173 )
...
Show or hide overflow menu for entire list is triggered when mode is changed
For bookmarks, due to implementation of selection and diffUtil,
additional check is necessary for current item (last selected) that is redrawn
2019-09-12 13:56:39 -07:00
Emily Kager
b83ae45c36
For #5263 - Hide ETP Panel Settings for custom tab
2019-09-12 10:45:35 -07:00
Tiger Oakes
4acf48e817
Fixes #5212 - Change tint in onCreateOptionsMenu
...
Also fixes #5213
2019-09-12 10:30:49 -07:00
Mihai Adrian
bc16061939
For #3371 : Show snackbar message when share fails with crash ( #5210 )
2019-09-12 09:26:24 -07:00
Emily Kager
fcb0448fa5
For #4458 - Enable font inflation with font auto size setting ( #5252 )
2019-09-12 09:05:16 -07:00
ekager
4461230e9b
For #5229 , #5228 - Dismiss ETP panel on back press, don't truncate text
2019-09-12 07:40:49 -07:00
Emily Kager
a5859e0028
For #5178 - Polish delete browsing data item layout
2019-09-11 18:11:26 -07:00
Emily Kager
102a36bd7e
No issue: Updates isPWA to isInstallable for AC 13 snapshot
2019-09-11 18:10:52 -07:00
Roger Yang
b3eca65614
Closes #5091 : Refactor Sentry BreadCrumbs to use lib-crash BreadCrumbs
2019-09-11 16:14:42 -07:00
Jeff Boek
e092dfd684
For #5047 - Addresses nits
...
- Changes MainScope to viewLifecycleScope
- Fixes string name/comment to better describe what it is
- Adds disabled state to the add button
2019-09-11 16:10:54 -07:00
Jeff Boek
d18ec49704
For #5047 - Wires up dialog to webAppUseCases
2019-09-11 16:10:54 -07:00
Jeff Boek
faff73b9b3
For #5047 - Creates dialog ui for naming a shortcut
2019-09-11 16:10:54 -07:00
Emily Kager
e3209dcc84
For #3700 - Add Setting to Delete Data on "Quit" menu action
2019-09-11 16:06:18 -07:00
Yeon Taek Jeong
ddc1b2e648
For #4658 : Add private browsing mode shortcut telemetry
2019-09-11 16:03:22 -07:00
Emily Kager
418b1ba890
For #1749 - Use Strict ETP by default, use Feature Flag for Settings
2019-09-11 16:03:01 -07:00
Sawyer Blatz
999d3cb963
For #1114 : Show playing tab
2019-09-11 15:45:22 -07:00
Emily Kager
9a4610f068
For #2897 - Add Action States To Share Sheet
2019-09-11 11:32:26 -07:00
Yeon Taek Jeong
2e2bac4ccd
For #419 : Create launch icon for private browsing ( #4948 )
2019-09-11 10:52:33 -07:00
Sawyer Blatz
5586b18c3e
For #4155 : Handle custom tabs & fix test
2019-09-11 09:03:17 -07:00
Sawyer Blatz
53b3f105ca
For #4155 : Sets pastedText default value
2019-09-11 09:03:17 -07:00
Sawyer Blatz
9d30d7bb03
For #4155 : Restyle to custom menu
2019-09-11 09:03:17 -07:00
Sawyer Blatz
52fd327bc0
For #4155 : Adds tests for browser toolbar popup menu
2019-09-11 09:03:17 -07:00
Sawyer Blatz
fdd2b59fb8
For #4155 : Adds popup menu for browser toolbar
2019-09-11 09:03:17 -07:00
Emily Kager
4485b7f647
Add Tracking Protection Info Panel
2019-09-11 07:47:13 -07:00
mihai-adrian
ef4a6b4154
For #4877 : Restored logic for closing tabs when not on browserFragment
...
Added return in function when saving collections coming from browser fragment
2019-09-10 21:42:16 -07:00
Sawyer Blatz
e240de7e31
For #4908 : Adds telemetry for send tab
2019-09-10 20:58:12 -07:00
Tiger Oakes
d0ef2d40c2
Move bookmark navigation listener to separate file
2019-09-10 16:53:09 -07:00
Sawyer Blatz
f7dde41b3b
For #5021 : Adds telemetry for what's new button
2019-09-10 14:15:34 -07:00
Tiger Oakes
3c07cacf4d
Use A-C preferences property delegates
2019-09-10 13:19:00 -07:00
Tiger Oakes
b77c4d2e2e
Clean up SupportUtils
2019-09-10 10:16:04 -07:00
Mihai Adrian
a31eb1f371
Code Health #4883 : Refactored accessing settings by using Context extensions ( #4973 )
2019-09-10 10:11:58 -07:00
Sawyer Blatz
cd533854e6
No issue: Only use iconTint in XML for bookmark menus ( #5145 )
2019-09-10 09:04:05 -07:00
Tiger Oakes
16115f57d1
For #3440 - Reduce BrowserFragment require calls
2019-09-09 21:33:32 -07:00
Colin Lee
4c2a7ac10e
Delete AUTH_SESSIONS with COOKIES
2019-09-09 12:32:28 -07:00
Colin Lee
758f4c13ec
Updates per UX and PR feedback
2019-09-09 12:32:28 -07:00
Colin Lee
2b9efccfca
For #3106 : Granular options for clearing user data
2019-09-09 12:32:28 -07:00
Petru Lingurar
53341f620a
Code cleanup - Remove unused FindInPageBarBehavior
...
There is a "unused" lint suppression in place with the comment
"Referenced from XML". I found no such usage.
It's documentation says that this Behavior will always position FindInPageBar
above BrowserToolbar but the current code ensures
BrowserToolbar.visibility == GONE when FindInPageBar.visibility == VISIBLE
so there's no need for such behavior.
2019-09-06 14:20:02 -04:00
Petru Lingurar
716cf3995a
Fix #4856 - Propagate LifecycleAwareFeature's onStart() to the inner feature
...
FindInPageFeature is used inside the app as a LifecycleAwareFeature and as such
it receives the onStart / onStop lifecycle calls.
The onStart() lifecycle call would not get passed to the feature but in
onStop() FindInPageFeature will detach it's Presenter and Interactor so when
the user comes back to the screen she could not interact anymore with the
feature.
To fix this we'll propagate LifecycleAwareFeature's onStart() to the inner
feature which is to rebind it's Presenter and Interactor in onStart().
This behavior is common to all the other features so all of them who implement
LifecycleAwareFeature will now get the onStart() call also.
2019-09-06 14:20:02 -04:00
Mihai Adrian
ed0b6bd5ef
For #4193 - Makes close button for tabs more accessible ( #4442 )
...
* fixes #4193 - made close button for tabs more accessible.
set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button and text as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
* Fix margins
2019-09-06 10:33:55 -07:00
Sawyer Blatz
aef087aae0
No issue: Removes unused nestedScrollQuickActionView ( #5143 )
2019-09-06 09:03:24 -07:00
Sawyer Blatz
2653b5966e
For #964 : Adds ability to disable each suggestion provider ( #5096 )
...
* For #964 : Adds ability to disable each suggestion provider
* Fix nit
2019-09-05 14:45:44 -07:00
Jonathan Almeida
ccd9e44a3e
No issue: Add logging for firebase/autopush
2019-09-05 16:03:36 -04:00
Emily Kager
58287cd5bb
For #5033 - Update browsing mode when session selected ( #5118 )
2019-09-05 14:27:30 -05:00
Emily Kager
bb2a685ad9
For #5075 - Fix boolean error for private mode notification persistence ( #5120 )
2019-09-05 09:21:56 -07:00
Sebastian Kaspari
3a35233ac0
Remove ThumbnailsFeature. ( #5127 )
...
We currently do not use thumbnails anywhere in the app. Not using the feature means we are
not taking thumbnails on every page load which means we are saving memory and CPU cycles.
2019-09-05 11:05:37 -05:00
Grisha Kruglov
231924f5eb
Fix breaking services APIs changes
2019-09-05 13:38:15 +02:00
Sebastian Kaspari
2c7fd93c7d
Update to Mozilla Android Components 12.0.0-SNAPSHOT.
2019-09-05 13:38:15 +02:00
Sebastian Kaspari
c2db07acf8
Add browser-state component.
2019-09-05 13:38:15 +02:00
Emily Kager
a5e9da7a55
For #5025 - Do not remove custom tab session with config removed
2019-09-05 10:57:37 +02:00
Sawyer Blatz
09dcdb079d
For #4474 : Adds what's new button to home screen menu ( #5088 )
...
* For #4474 : Adds what's new button to home screen menu
* For #4474 : Adds tests for what's new button
2019-09-03 15:16:29 -05:00
Petru Lingurar
46b09395f8
For #5067 - Refactor ShareControllerTest following the use of SendTabUseCases
2019-09-03 12:01:26 -07:00
Petru Lingurar
f7087e46e3
Fix #5067 - Refactor ShareController to use SendTabUseCases
...
Navigation between app fragments uses ShareTab as arguments. The newly used
SendTabUseCases uses TabData which is not Parcelable.
For minimal changes we'll keep both data classes and ShareController will know
how to map between the two.
Removed the `sessionId` property of ShareTab as it isn't needed anymore.
2019-09-03 12:01:26 -07:00
Sebastian Kaspari
ba05d21657
Fix ktlint MaxLineLength issues.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
38d97fda8b
Stores: Reduce visibility of reducer functions.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
2723a55b03
Rename HistoryStore/State/Action to HistoryFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
f3d8a89c63
Rename AccountSettingsStore/State/Action to AccountSettingsFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
61e84c161d
Rename SearchStore/State/Action to SearchFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
22446263f1
Rename ExceptionsStore/State/Action to ExceptionsFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
ac32a88d45
Rename BrowserStore/State/Action to BrowserFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
76063e307a
Rename BookmarkStore/State/Action to BookmarkFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
mihai-adrian
fc8fc2b33d
Fixes #4997 : Changed navigation to ShareFragment
...
Added global navigation action to share fragment in navigation graph
Changed share action to use global navigation to ShareFragment
2019-09-03 07:08:08 -10:00
Colin Lee
709588572a
For #5055 : Crash when opening bookmarks ( #5058 )
2019-08-31 17:41:50 -05:00
Christian Sadilek
4cf03be236
For #2088 : Use new async API to load default search engine in HomeFragment
2019-08-30 17:56:18 -04:00
Sebastian Kaspari
9b633f7f0f
Move creation of GeckoRuntime to flavor-specific source set.
...
Since we are now able to build against GeckoView Nightly and GeckoView Beta,
we should create the GeckoRuntime from a flavor-specific source set.
Creating the runtime is not covered by the AC abstraction and so API changes
in GeckoView Nightly can break the build and leaves us with no option to fix
it from a shared code base. Separating the creation of GeckoRuntime
allows us to adapt individually and also to configure the runtimes
differently.
2019-08-30 15:16:12 +02:00
Will Hawkins
3abffd5d77
Use new async API to load and access search engines
...
Use the new asynchronous features of the search engine
manager from a-c to avoid the latency required to load
the default search engine.
2019-08-29 18:16:02 -07:00
Mugurell
bf5b0e5cda
For 4007 - Add unit tests for the Share Interactor, Controller and list Adapters
2019-08-29 18:12:50 -07:00
Mugurell
e165868a53
For #4007 - Add ShareController for handling ShareFragment's business logic
...
`ShareController` defines a contract with all possible `ShareFragment`'s
behavior changes and comes with a default implementation -
`DefaultShareController`.
It is to be delegated by all `ShareFragment`s contained Views' Interactors
following any user interactions.
2019-08-29 18:12:50 -07:00
Mugurell
16eba61b25
For #4007 - ShareFragment will set the contained Views' state
...
ShareFragment which acts as a container would contain all business logic needed
for populating it's Views.
Data initialization should be done only once since the app state has no reason
to change after the ShareFragment is created and is done as soon as possible,
in onAttach().
Because of the expected short lifespan of this fragment, given the fact that
the state has no reason to change and we handle orientation changes ourselves
to keep things simple I didn't use a ViewModel to persist the state.
2019-08-29 18:12:50 -07:00
Mugurell
095870145f
For #4007 - Refactor AppShareView in standalone Share Views
...
In an effort to respect the initial MVI architecture I've broken the
complex `AppShareView` in 3 separate Views
- `ShareCloseView`
- `ShareToAccountDevicesView`
- `ShareToAppsView`
They are standalone Views (extending LayoutContainer) which know nothing about
each other or their parent and so offer their container the possibility to
order or display them in any form later.
According to the lib-state contract they are only responsible to
- inflate themselves in their injected containerView
- render a certain state (to be added in later commits)
- delegate all user interaction to an associated Interactor
2019-08-29 18:12:50 -07:00
Mugurell
5e19741ddd
For #4007 - Use camelCase for views referenced from code
...
As per #4341 .
Also reformatted layouts to have a more consistent style.
Also refactored `AppShareRecyclerView` and `AccountDevicesShareRecyclerView` by
defining their LayoutManager in XML to reduce code complexity.
2019-08-29 18:12:50 -07:00
Tiger Oakes
fb907033bb
Add comments to AuthCustomTabActivity
2019-08-29 15:06:34 -07:00
Sawyer Blatz
cea18f31c4
For #3892 : Fixes help link on nightly ( #4956 )
2019-08-29 13:27:50 -07:00
Mihai Adrian
9b911f3276
Fixes #4894 : added workaround for SDK<24 vector drawable with gradient color ( #4944 )
...
Removed drawableStart and added ImageView in layouts
Set ImageView logo programmatically: bitmap for SDK<24, vector for SDK>=24
Added onClickPendingIntent for ImageView in large and medium layouts
2019-08-29 12:55:51 -07:00
Tiger Oakes
f740d4382a
Closes #773 - Add shortcuts to homescreen ( #4925 )
2019-08-29 14:45:11 -05:00
mihai-adrian
5e78420cce
Fixes #3602:navigate to top of home screen after tapping "start browsing"
...
After onboarding.finish(), scrolled homeLayout to top
2019-08-29 07:45:04 -07:00
Jonathan Almeida
f25a9660e8
Closes #4218 : Remove forced registration renewal for push
2019-08-28 21:14:12 -04:00
Jonathan Almeida
18ca62b887
For #4063 : Remove SendTab feature flags
2019-08-28 21:14:12 -04:00
Yeon Taek Jeong
d87b8a8a5c
For #4658 : Add some private browsing mode telemetry ( #4968 )
2019-08-28 14:41:37 -07:00
Sawyer Blatz
09ed721015
For #4969 : Removes erroneous FxA sign up ping ( #4970 )
2019-08-28 14:32:43 -07:00
Yeon Taek Jeong
cc5408d717
For #2053 : Add persistent notification to close all private browsing tabs ( #4913 )
2019-08-28 12:55:24 -07:00
Sebastian Kaspari
aa5069caca
Closes #4215 : CustomTabActivity: Remove attached session if activity is finishing. ( #4985 )
2019-08-28 11:03:04 -07:00
Emily Kager
7b5ed2673b
For #4863 - Remove delay in HomeFragment onPreDraw
2019-08-28 13:48:14 -04:00
Suraj Shah
66a8c04967
Fixes #4488 : Shows snackbar on bookmark deletion from edit fragment ( #4792 )
...
* Fixes #4488
Updates changelog
* Removes wildcard imports.
* Removes custom label in use, replaces with let
2019-08-28 10:12:39 -07:00
Sebastian Kaspari
8608375eac
Use Mozilla Android Components 10.0.1.
2019-08-28 15:31:25 +02:00
Jonathan Almeida
681257bea7
For #4960 : Initialize push only if available ( #4964 )
2019-08-27 14:15:38 -07:00
Jeff Boek
bfb2beabe7
For #4063 - Always enable the push service ( #4932 )
2019-08-27 13:12:29 -07:00
Tiger Oakes
d1964d6536
Fixes #4771 - Add method for sessions of type ( #4782 )
...
Fixes share tabs to use the new method
2019-08-27 13:04:03 -07:00
Emily Kager
1cf8a40059
For #4295 - Adds Experiments Pref to Data Collection Settings ( #4915 )
2019-08-27 12:56:16 -07:00
Sebastian Kaspari
c322343248
Closes #4431 : Enable feature-media component for all builds. ( #4898 )
2019-08-27 12:51:27 -07:00
Emily Kager
a65f220b39
For #4921 - Adds WindowFeature to BaseBrowserFragment
2019-08-27 15:33:59 -04:00
Arturo Mejia
24f79b3263
Fix safe browsing API breaking change. ( #4946 )
2019-08-27 13:43:22 -05:00
Sourabh
091778a4b9
For #4398 - add HistoryController ( #4837 )
2019-08-27 10:33:40 -07:00
Amaan Marfatia
dc9fdd9db3
Fixes #4067 besides snackbar ( #4777 )
...
* Fixes #4067 besides snackbar
Makes layout hierarchy more shallow to increase performance.
* Fix #4067 Feedback
Make sure quick_action_overlay appears on top and use horizontal chain in tab_header.
2019-08-27 10:09:55 -07:00
Tiger Oakes
66e14959ba
Add custom tab fragment
2019-08-23 16:12:19 -04:00
ekager
ffbbe119f3
For #3967 - Invoke pending deletion on back pressed
2019-08-23 15:32:27 -04:00
ekager
b07df9698a
For #4868 - Update content description of tabs button with number of tabs
2019-08-23 09:21:32 -07:00
Grisha Kruglov
282c2dc182
No issue: only sync once on startup
2019-08-23 12:08:11 -04:00
Emily Kager
b9f6f7fa93
For #4779 : Don't double navigate with global directions in HomeActivity
2019-08-23 12:01:28 -04:00
Emily Kager
84b0693fd2
For #4652 : Use workaround for HomeScreenViewModel ( #4887 )
2019-08-22 13:35:51 -05:00
Tiger Oakes
9f154dc3a0
Extract intent processors from HomeActivity ( #4884 )
2019-08-22 13:31:40 -05:00
Tiger Oakes
79e58250fc
Make Settings.instance private
2019-08-22 08:14:08 -07:00
Sebastian Kaspari
f62e295fc6
Closes #4874 : Use new build types in FeatureFlags class.
2019-08-22 08:12:49 -07:00
Tiger Oakes
c475bc87cf
Move classes out of top-level package
2019-08-21 13:52:30 -07:00
Jeff Boek
68f5d211d3
For #4326 - Updates codebase to support latest version of detekt
2019-08-21 13:50:51 -07:00
Colin Lee
051ae9f584
For #3869 : Switch to A-C SearchLocalizationProvider ( #4858 )
...
* For #3869 : Switch to A-C SearchLocalizationProvider
* Fix test
2019-08-21 11:14:59 -07:00
Mihai Adrian
df3e1bf9d3
Fixes #4795 fixed requestDesktopStateProvider value from private to desktopMode ( #4810 )
...
RequestDesktopStateProvider was taken from private instead of desktopMode
2019-08-21 09:10:06 -07:00
Tiger Oakes
aab357845b
No issue: Clean up preferences code ( #4699 )
2019-08-21 08:38:14 -07:00
Emily Kager
c1b1c2f332
For #3967 - Invokes pending deletion with more bookmark actions ( #4522 )
2019-08-21 08:36:41 -07:00
Jonathan Almeida
71a2478f4d
Use Mozilla Android Components 10.0.0
2019-08-21 10:06:05 -04:00
Emily Kager
416e25e8a5
No issue: Don't show session provider in private mode
2019-08-20 16:09:55 -07:00
Yeon Taek Jeong
6f899c7fb5
For #2834 : Delete all Private Tabs redesign ( #4787 )
2019-08-20 13:10:08 -07:00
(´⌣`ʃƪ)
c076cc85f9
For #4436 : Dismiss onboarding before navigating away from home ( #4801 )
2019-08-20 10:56:28 -07:00
Tiger Oakes
33f3b14c29
Adds setters and property delegates in Settings ( #4809 )
...
* Change Settings to use setters
* Add delegate for shared preferences
2019-08-20 10:47:55 -07:00
Tiger Oakes
ac6c1ec2ee
Closes #2690 - Clean up CreateCollection viewmodel ( #4731 )
2019-08-20 10:45:41 -07:00
Tiger Oakes
9ee8c00928
For #4774 - Use vector drawable compat ( #4811 )
2019-08-20 10:43:02 -07:00
Tiger Oakes
ad98b2f3ea
For #4744 - Extract private browsing button ( #4813 )
2019-08-20 10:41:18 -07:00
Tiger Oakes
090e8006b0
Color the system bars in custom tabs ( #4819 )
2019-08-20 10:13:01 -07:00
Tiger Oakes
95ef312b1e
Issue #1000 - Remove isCustomTab flag ( #4656 )
2019-08-20 10:00:49 -07:00
Sourabh
1afc0eacd8
For #4399 : Create LibState Controller for Search ( #4673 )
...
* For #4399 : Create LibState Controller for Search
* fix code format
* add unit tests for DefaultSearchController
* add more test
* fix unit tests
2019-08-20 09:07:00 -07:00
Mugurell
ab6e7dc52b
Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout
...
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.
`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
2019-08-20 13:45:55 +02:00
Tiger Oakes
b8c93107c0
For #4744 - Extract TransitionPreDrawListener ( #4812 )
2019-08-19 16:27:43 -07:00
Tiger Oakes
a632d8f1dc
For #4744 - Move search bar icon padding to dimens ( #4814 )
2019-08-19 16:22:51 -07:00
Emily Kager
fb1d655d96
Closes #4822 - Update Bookmark State in onResume ( #4823 )
2019-08-19 16:22:20 -07:00
Sawyer Blatz
0d4eceed56
For #2706 : Refactor Glean to reduce errors ( #4753 )
...
* For #2706 : Adds recording for untracked events
* For #2706 : Adds key alignment to Metrics
2019-08-19 15:25:48 -07:00
Sawyer Blatz
4731977f5d
For #4421 : Fixes issues with new glean events ( #4816 )
2019-08-19 14:49:48 -07:00
Sawyer Blatz
73e3db8fe0
For #4804 : Resolves issue with crash reporter stack
2019-08-19 16:40:41 -04:00
Arturo Mejia
210868f5bc
Use Mozilla Android Components 9.0.0-SNAPSHOT. ( #4750 )
2019-08-19 10:29:10 -07:00
Suraj Shah
806961094b
Fixes #4704 ( #4728 )
...
* Fixes #4704 . Overrides `setEnabled` for DeleteBrowsingDataItem to change view alpha when disabled and to toggle the checkbox `isEnabled` behavior based on the value provided.
* Updates CHANGELOG.md
* Removes unnecessary disabling of checkbox in DeleteBrowsingDataItem.kt
Updates CHANGELOG.md to reflect the component changed.
2019-08-19 09:23:12 -07:00
Mugurell
645674c9bd
Closes #4396 - Add a Bookmarks Controller ( #4593 )
...
* For #4396 - Rename BookmarkInteractor methods
Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.
Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.
* For #4396 - Add a BookmarkController
It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.
This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.
* For #4396 - Refactored Bookmark related tests
Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`
Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
Tiger Oakes
de14962e3f
Extract quick action sheet observer code ( #4368 )
2019-08-19 08:28:33 -07:00
Emily Kager
7d02354f4f
For #4799 #4790 - Don't use passed in sessions in BrowserToolbarController ( #4800 )
2019-08-18 20:36:40 -05:00
Colin Lee
d1aed157dd
For #4686 : Fix potential security issue ( #4764 )
2019-08-16 16:50:54 -05:00
Yeon Taek Jeong
d4c83f9668
For #4736 : Display search shortcuts only from home or search widget
2019-08-15 12:24:54 -04:00
Yeon Taek Jeong
a680d733c8
For #4384 : Hide mic icon if speech-to-text is unavailable ( #4701 )
2019-08-14 16:40:21 -07:00
Yeon Taek Jeong
2441592ef2
For #4516 : Use full width for large search widgets ( #4659 )
2019-08-14 16:00:13 -07:00
Emily Kager
f71106cb51
Closes #3860 - Update description text for collections
2019-08-14 17:13:52 -04:00
Sawyer Blatz
b7ca520787
For #4421 : Adds Leanplum events and attributes ( #4626 )
...
* For #4421 : Adds Leanplum events and attributes
* For #4421 : Adds Leanplum deep links
2019-08-14 13:48:45 -07:00
Yeon Taek Jeong
67f3b63ae5
For #4421 : Add search widget attribute to Leanplum ( #4694 )
2019-08-14 12:00:29 -07:00
Yeon Taek Jeong
f5ffe3734c
For #4457 : Adds telemetry for search widget actions ( #4714 )
2019-08-14 11:39:54 -07:00
Yeon Taek Jeong
2f265eccbd
For #4732 : Fix search engine display issue ( #4735 )
2019-08-14 11:03:14 -07:00
Michael Cooper
12371ca9c1
Add no-op experiment to test service-experiments integration ( #4551 )
...
* Add no-op experiment to test service-experiments integration
* Shorten metric name to meet schema
* Add active_experiment metric to docs
* Add approved data review
2019-08-14 12:07:41 -05:00
Tiger Oakes
3acabeb6c3
Use global navigation action for browser fragment ( #4691 )
2019-08-14 11:58:29 -05:00
Colin Lee
5b4a441bcb
For #1667 : Screen reader can't reach other UI items when QAB expanded ( #4695 )
2019-08-14 09:56:29 -07:00
Emily Kager
1328d686aa
No issue - Autoformatting ( #4715 )
2019-08-14 09:40:46 -05:00
Sourabh
42e3b2771e
fix #4633 : show toast only on first login ( #4676 )
...
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
2019-08-13 16:28:34 -05:00
(´⌣`ʃƪ)
5aac05859d
Fix #4436 : hide onboarding before navigating to settings ( #4675 )
...
* Fix #4436 : hide onboarding before navigating to settings
* No issue: Rename emitAccountChanges to emitModeChanges
2019-08-13 15:49:42 -05:00
Sebastian Kaspari
d03c15d15c
Issue #4431 : Integrate feature-media component (Nightly and debug builds only). ( #4683 )
2019-08-13 15:02:20 -05:00
Colin Lee
0c8bcd39be
For #4652 : HomeFragment Crash "Can not.. after onSaveInstanceState"
2019-08-12 15:51:49 -04:00
Jorge De Los Santos
337ad1e88e
For #3424 - Make talkback ignore ImageButton in Collection Sele… ( #3792 )
...
For #3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
2019-08-12 11:49:25 -04:00
Grisha Kruglov
b38b94ed79
Closes #4671 : Fix a potential NPE in BookmarkFragment
2019-08-12 11:16:28 -04:00
Grisha Kruglov
634ee184a6
No issue: add some BookmarkFragmentInteractor tests
2019-08-09 17:27:58 -07:00
Grisha Kruglov
f323105163
No issue: reduce code duplication in BookmarkFragmentInteractor
2019-08-09 17:27:58 -07:00
Christian Sadilek
5fe05e919a
For #4125 : Suppress coroutine warning to fix release build
2019-08-09 17:30:27 -04:00
Sawyer Blatz
0ec92d716f
For #4123 : Adds telemetry for quick action open in app ( #4629 )
2019-08-09 13:51:12 -07:00
Yeon Taek Jeong
6c9ce784b1
Fix, add some tests
2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
2a6069bfb7
Fix rest of issues
2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
69434a765f
Fix most issues
2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
faf0ecbcc0
For #4125 : Migrate Sign in to Sync to Libstate
2019-08-09 13:39:51 -07:00
Colin Lee
7f07eabbd8
For #4652 : Crash "Can not perform this action after onSaveInstanceState" ( #4654 )
2019-08-09 14:46:40 -05:00
Tiger Oakes
52542708aa
Consodilate private browsing code
2019-08-09 11:00:41 -07:00
Jonathan Almeida
23f5ac0fb9
For #4066 : Create InflationAwareFeature for lazy inflation
2019-08-09 11:48:55 -04:00
Colin Lee
519c3bde5d
For #4066 : Provide lazy inflation of Find In Page View
2019-08-09 11:48:55 -04:00
Colin Lee
c9c43260c9
For #4529 : Handle crash initializing CreateCollectionViewModel late ( #4628 )
2019-08-08 17:40:55 -05:00
Christian Sadilek
e26570054a
Suppress warning in LeanplumMetricsService to fix release builds
2019-08-08 15:17:12 -04:00
Mathieu Leplatre
04daf21437
Fix #4612 : Fetch experiments from Remote Settings CDN
2019-08-08 10:15:01 -07:00
Colin Lee
ef97173cd9
For #4529 , #4427 : Resuming after restoring instance state breaks UI ( #4571 )
...
* For #4529 , #4427 : Resuming after restoring instance state breaks UI
* Clear up warnings
2019-08-08 11:05:01 -05:00
Sawyer Blatz
ff6e9bccb7
For #4451 : Adds tests for DefaultBrowserToolbarController ( #4493 )
...
* For #4451 : Adds tests for DefaultBrowserToolbarController
* Continue working
* Large refactoring of test
* Mock analytics
* Fix merge conflicts
2019-08-08 09:02:42 -07:00
Hakkı Kaan Çalışkan
0ea595743d
Fixes #4562 : Add a-c git hash to about page
2019-08-07 16:59:11 -07:00
Emily Kager
0b98d43c23
Closes #4602 - Add back transitions
2019-08-07 16:56:21 -07:00
Sawyer Blatz
4566bd6fba
Fixes feedback
2019-08-07 16:41:29 -07:00
Sawyer Blatz
4d14735935
For #3060 : Adds Leanplum attributes for fxa syncing
2019-08-07 16:41:29 -07:00
Sawyer Blatz
9d65e665e5
No issue: Removes deprecated usage of ViewModelProviders
2019-08-07 19:21:41 -04:00
Yeon Taek Jeong
ec4d62c895
Fix ktlint
2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
00bd26abe3
Remove task flags
2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
f952234c57
Keep CLEAR_TASK
2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
c87468d031
Remove popBackStack
2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
a8526a0606
For #4438 : Fix crash when opening any URL from URL bar w/ long press
2019-08-07 19:17:56 -04:00
Sawyer Blatz
969d17b4a9
For #969 : Adds more telemetry for collections ( #4539 )
2019-08-07 16:05:20 -07:00
Sawyer Blatz
da06b0fb15
For #4508 : Treats warnings as errors ( #4543 )
2019-08-07 14:00:53 -07:00
Grisha Kruglov
f23f3b7489
Closes #4467 : Use a-c version of FirefoxAccountsAuthFeature
2019-08-07 13:42:39 -07:00
ValentinTimisica
59c60ef189
Fixes #4354 : Updated SearchFragment state after returning from SearchEngineFragment.
...
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
2019-08-07 13:19:53 -07:00
Colin Lee
a514cb3f8c
No issue: Add OSS licenses link to About page
2019-08-07 12:40:10 -07:00
Sawyer Blatz
f9288c7fbd
For #969 : Finalizes collections telemetry ( #4592 )
2019-08-07 10:26:52 -07:00
Emily Kager
8194e0778e
For #4026 - Update BookmarkDiffUtil to update on Title or URL change
2019-08-07 00:37:16 -04:00
Emily Kager
0604e9858d
Closes #3939 - Adds strings for delete browsing history
2019-08-06 16:06:56 -07:00
ValentinTimisica
71aedc79fe
Fixes #3922 : Added accessibility announcement for history empty state.
...
Sent an announcement when the list becomes empty in order to tell the user
that there is no history.
2019-08-06 12:32:59 -07:00
Tiger Oakes
631b7ba7cb
Issue #1000 - Split out common browser functions
2019-08-06 12:31:25 -07:00
Emily Kager
23bc8f4320
Fro #4563 - Update delete button alpha when history mode changes
2019-08-06 12:26:25 -07:00
Tiger Oakes
3c1ce90f6f
Fixes #2379 - Generic library selection
2019-08-06 11:10:50 -07:00
Yeon Taek Jeong
6f962d3376
For #1744 : Open search shortcuts when entering search mode ( #4536 )
2019-08-05 15:07:03 -07:00
Emily Kager
6f7ae227a8
Closes #4540 - Set correct tint for select bookmark folder icon ( #4541 )
2019-08-05 14:54:39 -07:00
ekager
5edc9d0b4e
For #2021 - Update custom preferences' views with email/account changes
2019-08-05 09:53:27 -07:00
Travis Long
51218bc93e
Integrate service-experiments component ( #4098 )
2019-08-05 11:14:42 -05:00
Emily Kager
a526e0fad3
For #4455 - Rename history headers by hours and days ( #4478 )
2019-08-05 11:12:22 -05:00
Nikit Bhandari
8aecc2b850
For #4530 Reduce build warnings ( #4531 )
2019-08-05 11:10:57 -05:00
ekager
d0071d0177
For #4495 - Clean up homescreen toolbar focus and content descriptions
2019-08-05 08:58:03 -07:00
Sören Hentzschel
bfd4849064
For #1427 - enter multi select mode with single click on favicon in library
2019-08-03 16:43:51 -07:00
Nikit Bhandari
671727c3e8
For #4341 use camelCase for views referenced from code
2019-08-03 09:25:55 -07:00
Nikit Bhandari
1cb9f88787
For #4199 make checkbox disabled when there is no data ( #4200 )
...
* For #4199 make checkbox unclickable when there is no data
2019-08-02 17:42:39 -07:00
Tiger Oakes
1e4399ee38
Use auto pause with BrowserFragment observers
2019-08-02 17:32:58 -07:00
Tiger Oakes
cbd811dcfb
Closes #1657 - Use Gecko for downloads ( #4296 )
2019-08-02 17:28:30 -07:00
Tiger Oakes
6e2ea0750e
Issue #2379 - Use LibrarySiteItemView in history
2019-08-02 17:15:41 -07:00
mihai-adrian
bac2e40eb2
fixes #4435 - changed title of menuitem for delete and added content description
...
setting menu title should also set content description. I added the setContentDescription programmatically in order to ensure that the content description is being set. If content description matches title it won't be read twice
2019-08-02 17:09:24 -07:00
ekager
015922ddd2
No issue: Fix Crash lower API by setting gradient drawables in onBind
2019-08-02 16:18:34 -07:00
Yeon Taek Jeong
83ceec6289
For #201 : Search Widget
2019-08-02 11:26:48 -07:00
Jonathan Almeida
ec96d134ff
No issue: Fix breaking AccountObserver API
2019-08-02 13:40:50 -04:00
Sawyer Blatz
29f089c414
For #2203 : Polishes BrowserToolbarMenu
2019-08-02 13:40:50 -04:00
Colin Lee
33e881ca8a
For #1539 : Only allow delete when folders multi-selected ( #4062 )
2019-08-02 10:11:21 -07:00
ValentinTimisica
da59e36c1b
Fixes #4410 : Modified visibility of 'Add Tab' button.
...
I changed the visibility of 'Add Tab' button according to the number of
opened tabs. If there is at least one tab open, the button is displayed.
2019-08-02 08:49:50 -07:00
Grisha Kruglov
ae33234bbc
Closes #2593 : FxA automatic sign-in integration
2019-08-01 17:03:45 -07:00
Grisha Kruglov
210864186b
Reflect current sync status when opening account settings
2019-08-01 17:03:45 -07:00
Tiger Oakes
c342a680d8
Fix crash for bookmarks
2019-08-01 18:57:35 -04:00
Emily Kager
d42e72fd8b
Closes #4462 - Adjust layout params of select bookmark folder view
2019-08-01 13:31:13 -07:00
Thom Chiovoloni
a1adb2e57f
Update fenix for new megazord setup
2019-08-01 13:10:20 -07:00
Tiger Oakes
ccae66c08a
Issue #2379 - Use LibraryPageView in history
2019-08-01 15:59:55 -04:00
Jeff Boek
2813a3cff7
For #4441 - Keeps the ID 0 based for the recyclerview
2019-08-01 10:45:23 -07:00
Christian Sadilek
9887945296
For #4412 : Only consume state change when UI initialized
2019-08-01 11:51:32 -04:00
Christian Sadilek
b646e87d9e
No issue: Add engine warmup call
2019-08-01 10:53:55 -04:00
Jeff Boek
e4700f76c6
For #3886 - Uses defaultDeviceName for the DeviceConfig device name
2019-07-31 21:34:21 -07:00
Jeff Boek
a75c2f7cfb
No Issue - Fixes the offset key to prevent endless history bug
2019-07-31 17:58:56 -07:00
Sawyer Blatz
97f7d5ba87
For #2267 : Fixes telemetry for reader view ( #4328 )
2019-07-31 17:58:37 -07:00
Sawyer Blatz
2e7a61860a
For #969 : Adds more telemetry for collections ( #4358 )
2019-07-31 17:07:41 -07:00
Jonathan Almeida
4922e5d09d
No issue: Move PublicSuffixList to root component
...
With the PublicSuffixList class in Utilities, the first instantiation
of it (prefetching in onCreate), causes the Utilities to instantiate
and thus slowing down startup by needing the SearchEngineManager from
instantiating as well.
Moving this back to the root component fixes the immediate perf issue.
Co-authored-by: Will Hawkins <whh8b@obs.cr>
2019-07-31 17:01:14 -07:00
Christian Sadilek
59c0005979
For #4412 : SiteSecurityClickedListener set incorrectly
2019-07-31 19:52:53 -04:00
Will Hawkins
ed31d990a4
No Issue: Move notification manager to member of background services
...
Instead of taking notification manager as a parameter
(from the utils class), create one private to the
BackgroundServices class. This means that we do not need
to create the entirety of utilities just to use
the notification manager.
2019-07-31 16:11:46 -07:00
Jeff Boek
af449c84d5
For #4137 - Fixes HistoryInteractorTest
2019-07-31 14:35:33 -07:00
ekager
4494e40dbc
For #4137 - Adds pagination to the history view
2019-07-31 14:35:33 -07:00
Emily Kager
0773069dad
For #3829 - Ignore Intents Launched From History
2019-07-31 17:07:54 -04:00
Nikit Bhandari
46de06d132
For #4339 reduce build warnings ( #4340 )
2019-07-31 11:43:49 -07:00
Emily Kager
95208c84a9
Closes #4265 - Do not pop after all exceptions are removed ( #4392 )
2019-07-31 11:43:15 -07:00
Christian Sadilek
76ed07bd5d
Closes #4412 : BrowserInteractor has not been initialized ( #4414 )
2019-07-31 09:14:05 -07:00
Afzal Najam
8946bf20c4
Closes #3341 - Remove UserAgentRewriter
2019-07-31 11:05:42 -04:00
Emily Kager
ec0bd85f6d
For #4198 - Include Intent.ACTION_SEND to open to browser
2019-07-31 01:11:39 -04:00
Jonathan Almeida
026dcb01f5
No issue: Enable Send Tab and Push in production
2019-07-30 22:32:59 -04:00
Jonathan Almeida
90b1e5c262
Closes #4355 : unsubscribe FxA subscription on logout
2019-07-30 22:27:12 -04:00
mihai-adrian
458632f4bf
fixes #4237 - Cannot edit the default name of a collection, only replace it
...
changed setting of text to be done before transition, preventing transition to make textView unclickable;
added renaming situation to showKeyboard in onResume();
changed title text when renaming, from: "Name collection" to "Rename collection".
2019-07-30 16:26:10 -04:00
mihai-adrian
ef3c813aee
fixes #4237 - Cannot edit the default name of a collection, only replace it
...
changed setting of text to be done before transition, preventing transition to make textView unclickable;
added renaming situation to showKeyboard in onResume();
changed title text when renaming, from: "Name collection" to "Rename collection".
2019-07-30 16:26:10 -04:00
mihai-adrian
2e300fc8cf
fixes #4237 - Cannot edit the default name of a collection, only replace it
...
made name_collection_edittext field clickable
2019-07-30 16:26:10 -04:00
Sawyer Blatz
385dfd2f15
For #4376 : Removes usage of selectedSessionOrThrow ( #4381 )
2019-07-30 12:39:58 -07:00
ekager
0703fdc91f
Closes #4240 - Exclude custom tabs from displayed tab count
2019-07-30 13:28:50 -04:00
bloslo
8ff77b90f3
For #3886 - Change default device name to show the app name. ( #3916 )
...
* Fix default device name to show the app name.
* Add string resource with placeholders.
* Wrap line that triggers MaxLineLength lint issue.
2019-07-30 10:28:19 -07:00
Tiger Oakes
d1651ecf71
Closes #4012 - Animate quick settings ( #4047 )
2019-07-30 09:50:50 -07:00
Tiger Oakes
2467588c4a
Create shared custom view for library items
2019-07-30 12:26:15 -04:00
Mugurell
bf44c50dfd
Fix #4372 - Set SitePermissionsDetailsExceptionsFragment toolbar title in onResume
...
The flow we are currently using involves setting a new title for the containing
Activity when the user navigates to a new Fragment.
This happened for SitePermissionsDetailsExceptionsFragment in it's onCreate().
Opening a permission (SitePermissionsManageExceptionsPhoneFeatureFragment) will
set a new title in it's onCreate() but going back from this new Fragment will
not create again a new SitePermissionsDetailsExceptionsFragment.
As a workaround I moved the call to set Activity's title in onResume().
2019-07-30 11:56:44 -04:00
Nikit Bhandari
5e52fc46b8
For #3443 - convert textPercentageSeekBar to Kotlin ( #4081 )
...
* convert textPercentageSeekBar to Kotlin
* fix test
* fix test again
* fix test again
* conflicts resolved
* merge multiple kdocs into one
2019-07-30 10:17:41 -05:00
Colin Lee
9bc0122ce3
For #4359 : findBookmarkedUrl blocks the main thread ( #4362 )
2019-07-29 17:01:02 -05:00
Amaan Marfatia
4c13f45e9e
Fixes #4192 : Private keyboard in private browsing ( #4345 )
...
Sets compliant keyboards to private mode when in private browsing.
2019-07-29 18:00:48 -04:00
James Hugman
ac359f6970
Closes #1331 - Filter consecutive history items using simplified URL
2019-07-29 17:22:19 -04:00
Sawyer Blatz
6fa022c2f8
For #4124 : Migrate BrowserToolbar to Libstate ( #4279 )
...
* For #4124 : Migrate BrowserToolbar to Libstate
* Restores QuickActionSheetReducer
* Improve tests
* Make QuickActionSheetController
* Finalize tests
* Breaks out QuickActionSheetState
* Fix comments
* Adds BrowserStoreTest
2019-07-29 12:39:36 -07:00
Tiger Oakes
87d8f3b037
Remove redundant super calls
2019-07-29 10:22:53 -07:00
Tiger Oakes
88c05a5f43
Use glide-like image loading function
2019-07-29 10:22:23 -07:00
Andrey Mukamolov
ccfaa3826b
For #2142 : Added accessibility focus
2019-07-29 09:26:33 -07:00
Andrey Mukamolov
d5eeadda66
Closes #2142 : Enable private browsing button is focused instead of Search or address
2019-07-29 09:26:33 -07:00
Tiger Oakes
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
2019-07-26 16:44:11 -04:00
Jonathan Almeida
c8148e61d5
No issue: Reset push subscriptions
2019-07-26 13:50:57 -04:00
Colin Lee
48aeb19db1
For #3695 : Make SessionSuggestionProvider link to existing tab ( #4280 )
2019-07-26 09:49:25 -05:00
Christian Sadilek
1846a61475
For #4096 : Use new A-C API to observe store / state changes
...
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
2019-07-26 10:40:33 -04:00
Colin Lee
3dc20543e3
For #4128 : Migrate Bookmarks to LibState ( #4254 )
2019-07-25 21:55:51 -05:00
ValentinTimisica
4747f2c165
Fixes #4161 : Modified style of bookmark_folders_sign_in button. ( #4291 )
...
To make this match the style of the other button I applied the same style to it
and also changed it to be a MaterialButton.
I also decided to extract the margin and padding values of the button.
2019-07-25 14:10:11 -05:00
chiragmantri
9bbd14a542
removed unused import.
2019-07-25 14:36:36 -04:00
chiragmantri
945b1ee274
[ #4089 ] Moved PublicSuffixList to a sub-component(Utilities) class.
2019-07-25 14:36:36 -04:00
Jonathan Almeida
1026a92f32
Update to use Mozilla Android Components 6.0.0
2019-07-23 17:55:39 -04:00
Jonathan Almeida
2531e9dd62
No issue: Use correct server host and force subscribe for push
2019-07-23 17:55:39 -04:00
Sawyer Blatz
28eb5c541a
For #1944 & #1750 : Updates private & night mode colors ( #4232 )
2019-07-23 09:35:24 -07:00
Tiger Oakes
3c99c8540f
Switch to new intent processors
2019-07-23 12:33:02 -04:00
Emily Kager
be10d427e8
For #4127 - Converts Exceptions to LibState and adds tests
2019-07-22 17:21:06 -04:00
Emily Kager
9b5baa2358
For #3360 - Adds empty state for TP Exceptions
2019-07-22 17:21:06 -04:00
Sawyer Blatz
7588251f8b
Closes #3986 & Closes #3661 : Migrate QuickActionSheet to LibState & add tests ( #4058 )
...
* Closes #3986 : Migrate QuickActionSheet to LibState
* Closes #3661 : Add tests for QuickActionSheet
Co-authored-by: boek <jeff@jeffboek.com>
* For #3986 : Fix feedback
2019-07-22 10:31:31 -07:00
Nikit Bhandari
9d9685625a
For #4201 fix app crash on renaming a collection ( #4202 )
...
* For #4201 fix app crash on renaming a collection
* update
2019-07-22 10:31:00 -07:00
Jonathan Almeida
5ecdce6ba6
Closes #4171 : Do not pause deviceEventObserver on lifecycle events
2019-07-19 14:00:26 -07:00
Nikit Bhandari
f110ba2861
use synthetic binding instead of findviewbyid
2019-07-19 16:51:26 -04:00
Jeff Boek
5630904f93
For#3278 - Updates strings in preferences ( #4184 )
2019-07-19 12:31:55 -07:00
Mihai Adrian
c74cb61455
fixes #4176 ( #4175 )
...
adds content description to 'browse privately' card, replacing placeholder %s with the header_text of card
2019-07-19 14:23:10 -05:00
Emily Kager
fc2bff0fde
For #4145 - Remove anchor view from fullscreen snackbar ( #4160 )
2019-07-19 11:18:47 -07:00
Emily Kager
9f40c25c75
For #4143 - Allow user to rotate to other landscape orientation
2019-07-19 14:12:33 -04:00
Jonathan Almeida
d298b5f2f5
Closes #4075 : Add Feature Flag class ( #4077 )
2019-07-18 17:20:12 -07:00
Sawyer Blatz
e25ceafd1f
No issue: Removes unnecessary fragment transitions from accounts
...
Co-authored-by: ekager <emilykager@gmail.com>
2019-07-18 19:56:25 -04:00
Sawyer Blatz
13198f56df
For #969 : Adds telemetry for collections ( #3935 )
2019-07-18 16:05:42 -07:00
Sawyer Blatz
e544827e83
For #2267 : Adds telemetry for reader mode ( #3941 )
2019-07-18 15:17:15 -07:00
Tiger Oakes
edb0a3ed08
For #3633 - Update StoreProvider to use a callback
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2019-07-18 18:16:49 -04:00
Jeff Boek
e294521c92
Fix search metrics ( #4150 )
...
* For #4082 - Changes lifecycles for metrics
* For #4082 - Replaces the SearchEngine name with the identifier for
countLabel
2019-07-18 14:35:34 -07:00
Sawyer Blatz
9251597e84
For #2362 : Fixes telemetry for history ( #4156 )
2019-07-18 13:36:52 -07:00
Tiger Oakes
981b6b5b02
For #4124 - Remove browser toolbar editing code
2019-07-18 15:40:33 -04:00
James Hugman
62850430b7
Closes AC#3695 - Add UI to open current page in external app
2019-07-18 15:33:31 -04:00
Tiger Oakes
6da6ddb095
Use StateListDrawable & resources w/ TabCollection
2019-07-18 15:29:06 -04:00
Emily Kager
451093fd9e
Closes #2560 - Updates Private Browsing explanation string
2019-07-18 15:27:59 -04:00
Emily Kager
ae3d187909
For #3987 - Convert History to Lib-State and add tests
2019-07-17 17:23:09 -07:00
Emily Kager
9ab67557cf
For #4078 - Request landscape mode when entering fullscreen
2019-07-17 16:06:37 -07:00
Christian Sadilek
c04dcec03f
Closes #4096 : IllegalStateException in SearchFragment ( #4131 )
2019-07-17 15:10:24 -05:00
James Hugman
90dd0ab469
Closes #4114 - Re-enable app-links
2019-07-17 10:39:17 -07:00
Emily Kager
95367c2b50
For #3521 - Show Quick Settings Dialog Entirely in Landscape
2019-07-17 09:52:01 -07:00
Emily Kager
8381025ac5
For #2160 - Hide Keyboard in onPause from EditBookmarkFragment
2019-07-17 09:20:28 -07:00
Emily Kager
68dae52fd1
Closes #3332 - Do not alter text of hosts of tabs in collection
2019-07-17 09:02:30 -07:00
Sawyer Blatz
11d36b5a00
For #2362 : Adds telemetry for history ( #3940 )
2019-07-16 12:21:03 -07:00
Colin Lee
8855af2234
For #3615 : Long pressing the address bar should not copy link ( #4083 )
2019-07-16 13:42:05 -05:00
Emily Kager
6b4c160d18
Closes #4080 - Trim New Bookmark Folder Title Text
2019-07-16 11:02:36 -07:00
Tiger Oakes
52d4c43916
Merge some library UIView code for toolbar
2019-07-16 09:27:30 -07:00
Tiger Oakes
447123367a
Remove unused sessions resources
2019-07-16 09:15:50 -07:00
Emily Kager
13b7e64c9b
For #3134 - Add confirmation dialog to sign out of FxA ( #3959 )
2019-07-15 16:21:13 -07:00
Jeff Boek
ec099a6e11
For #3633 - Creates generic store provider ( #4060 )
2019-07-15 15:54:13 -07:00
Tiger Oakes
7747d5c240
Use tools:text to avoid inflating strings twice ( #3619 )
2019-07-15 17:01:37 -05:00
Jonathan Almeida
fd7ff58ab8
No issue: Add comments on the push flag state
2019-07-15 17:42:58 -04:00
ekager
706f7d5961
For #3554 - Add DiffUtil to HistoryAdapter
2019-07-15 13:46:21 -07:00
Jonathan Almeida
cf9ae87d50
For #3015 : Add push support for send tab
2019-07-15 16:38:49 -04:00
Sebastian Kaspari
9b1e63224c
Closes #4052 : Remove pending intent workaround. ( #4059 )
...
Previously we needed to set a static launch function to be invoked when the find in page
integration should be launched. Now we can access the integration class directly and
can avoid the static property that caused issues when used by multiple activities.
2019-07-15 14:15:59 -05:00
Christian Sadilek
e91a2e61a2
For #3633 : Add unit tests for SearchStore
2019-07-15 13:47:01 -04:00
Sebastian Kaspari
f8ef0225e1
Use updated feature-tab-collections API. ( #4056 )
2019-07-15 09:58:33 -07:00
Christian Sadilek
b91895a81c
Closes #1350 : Use GeckoView fetch client for service-fretboard / kinto
2019-07-15 11:26:40 -04:00
Tiger Oakes
5de1678e65
No issue: Use putCompoundDrawables helper ( #3982 )
2019-07-15 08:24:59 -07:00
Sebastian Kaspari
e4e0d45c1b
Closes #3996 : Remove workaround for opening custom tab in browser.
...
`EngineView` now allows releasing the `Session` so that it can be rendered by an
other `EngineView` instance.
2019-07-15 10:52:57 +02:00
Jeff Boek
e4ff70c542
For #3633 - Refactors the search screen to use lib-state
...
* For #3633 - Adds SearchStore
* For #3633 - Refactors AwesomeBarUIView
* For #3633 - Refactors ToolbarUIView to use lib-state
* For #3633 - Fixes a couple of state bugs
* For #3633 - Moves all user interaction to SearchInteractor
* For #3633 - Adds kdocs to SearchStore and SearchInteractor
* For #3633 - Adds documentation for the properties on SearchState
Also removes uneccessary property
* For #3633 - Creates `StateViewModel` to handle state restoration
* For #3633 - Adds a test for onTextChanged
* For #3633 - Adds tests for SearchInteractor
* For #3633 - Fixes bugs and adds documentation
2019-07-12 16:32:00 -07:00
Emily Kager
867067537a
For #3568 - Use correct styling for QR and Share Alert Dialogs
2019-07-12 11:40:33 -07:00
Tiger Oakes
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
Colin Lee
2feddc9bd6
No issue: Enable Strict Mode in Debug Builds ( #4014 )
2019-07-12 00:23:28 -05:00
Emily Kager
1f108f3c88
For #3806 - Adds corner radius to QAB and dialogs
2019-07-11 12:57:27 -04:00
Grisha Kruglov
fe51bbcf7b
Update FxA integration to new APIs
2019-07-11 13:19:37 +02:00
Emily Kager
c81dd0a4a8
For #3772 - Update FXA sign in UI ( #3933 )
2019-07-10 21:20:06 -05:00
Emily Kager
9e7282cf18
For #1949 - Fixes bookmark separator appearance, removes menu ( #3957 )
2019-07-10 14:23:35 -05:00
Emily Kager
21c75ca1bb
For #3478 - Add Tab sent snackbar confirmation for device sharing
2019-07-10 14:13:10 -04:00
ekager
c6c9818751
For #3240 - Create AuthCustomTabActivity to fix dead end on auth
2019-07-10 12:23:01 -04:00
Colin Lee
5a204f0bbc
For #3818 : Handle crashes accessing view after onDestroyView ( #3942 )
2019-07-08 18:42:17 -05:00
Sawyer Blatz
83312b38aa
For #3175 : Correctly grabs focus in search fragment ( #3938 )
2019-07-08 14:44:30 -07:00
Tiger Oakes
9901514766
Replace deprecated pxToDp ( #3932 )
2019-07-08 14:45:07 -05:00
Colin Lee
15d887e41f
For #2251 - Add bookmark adapter diffutil ( #3936 )
...
* For #2251 - Add bookmark adapter diffutil
* For #2251 - Fix unit tests for bookmark adapter diffutil
2019-07-08 14:00:25 -05:00
afr30010
c92eabdd64
Modify the order of Privacy Policy and About in Settings ( #2760 )
2019-07-08 12:16:18 -05:00
Emily Kager
d168d52516
For #3772 - Remove Create an Account Option on TurnOnSyncFragment ( #3928 )
2019-07-08 12:07:09 -05:00
ekager
003837eb4f
Closes #3879 - Remove attributeSetId from AccountPreference
2019-07-07 18:06:17 -07:00
ekager
57ca75139b
For #3201 - Update bookmark state when session selected
2019-07-03 11:38:14 -07:00
Emily Kager
f60536b13c
For #3829 - Add pop up to nav_graph to browser to home nav
2019-07-03 11:29:49 -07:00
Colin Lee
6bb67a9de7
For #3364 : Set bookmark root titles onResume ( #3828 )
2019-07-03 13:13:53 -05:00
Jeff Boek
20993462e9
For #3869 - Creates a SearchLocalizationProvider that sets the region to get the correct default search engine based on a locale
2019-07-03 08:57:59 -07:00
Yeon Taek Jeong
29402a297e
For #3317 : Prepopulate FxA device name field with existing name ( #3733 )
2019-07-03 08:38:09 -07:00
Emily Kager
7a51ee3915
For #3734 - Don't SwipeToDelete RecyclerView without windowfocus ( #3839 )
2019-07-02 14:42:50 -07:00
Emily Kager
99209aa9da
Closes #3268 - Change Tab Favicon Border Radius to 4 ( #3856 )
2019-07-02 14:42:20 -07:00
Emily Kager
ce2d597af3
For #203 - Adds find in page and request desktop site to custom tab menu ( #3835 )
2019-07-02 14:41:29 -07:00
Colin Lee
eedb0fa3b2
For #2945 : Launches to blank screen and hangs on Nexus 10 ( #3854 )
2019-07-02 14:58:28 -05:00
Mitchell Hentges
aebcc92080
Re-enables pushing nightly to org.mozilla.fenix ( #3823 )
...
* Re-enables pushing nightly to org.mozilla.fenix
* Publishes org.mozilla.fenix.nightly releases on internal track
2019-07-02 11:34:04 -07:00
Sawyer Blatz
dbe29ebbda
For #3174 : Adds telemetry for bookmarks ( #3724 )
2019-07-02 08:41:20 -07:00
Sawyer Blatz
ece0e30655
For #2054 : Collapses quick action bar when opening find in page ( #3837 )
2019-07-02 08:22:34 -07:00
Emily Kager
bed926c317
For #3834 - Initialize job in init
2019-07-01 16:26:46 -07:00
Colin Lee
50052c9b9b
For #3551 : Tapping a bookmark/history from Library should open new tab ( #3832 )
2019-07-01 16:31:30 -05:00
Colin Lee
161e7b3b57
No issue: Fix master builds ( #3825 )
2019-07-01 14:15:54 -05:00
Tiger Oakes
8cd1a0cb38
Move adapter Job setup code to helper class ( #3407 )
2019-07-01 13:34:25 -05:00
Sören Hentzschel
eb1ea882cf
For #2425 - QAB showed wrong text for bookmarked pages ( #3794 )
...
* For #2425 - QAB showed wrong text for bookmarked pages
* fixed linting issue
2019-07-01 11:45:52 -05:00
Sawyer Blatz
7e46e71d00
For #3005 : Closes tabs when saving to collection ( #3723 )
2019-07-01 11:39:48 -05:00
Weverson Nascimento
887102d215
For #3645 : Fix search engine selection ( #3665 )
...
* Remove RadioButton drawable applied in runtime
* Add default RadioButton layout
2019-07-01 11:08:58 -05:00
Emily Kager
654c2b12df
No issue: Remove attributeSetId from DefaultBrowserPreference ( #3712 )
2019-07-01 09:02:40 -07:00
Colin Lee
7473126f7c
For #3784 : Crash loading bookmarks while detached ( #3787 )
2019-07-01 10:57:31 -05:00
Colin Lee
386a3f3acc
For #3785 : Crash onDestroy of BookmarkFragment when detached ( #3786 )
2019-07-01 10:57:16 -05:00
Tiger Oakes
d42052079a
No issue: Remove duplicate wordmark and update about page ( #3590 )
2019-07-01 08:54:16 -07:00
Yeon Taek Jeong
219b5f3d01
For #3381 : Fix 'Remove account' returning app to home screen ( #3778 )
...
* For #3381 : Fix 'Remove account' returning app to home screen
* Remove unused import
* Move popBackStack() outside lifecycleScope instead
2019-07-01 08:32:06 -07:00
Arturo Mejia
b82340bf1f
For #3750 : Crash when tapping "Blocked" on Google Maps after disabling
...
location requests.
2019-06-29 18:39:19 -07:00
ekager
7fa4cf4487
Use sessionId in FIP Integration, use pendingIntent for startActivity
2019-06-28 14:00:59 -07:00
ekager
6d0a4fdb4d
Revert "For #3609 - Remove FIP Integration, Use FIP Feature"
...
This reverts commit 428643d598e938f58a2fe4abfee417c46edec167.
2019-06-28 14:00:59 -07:00
Emily Kager
2d6ebb986d
Revert "For #3135 - Reduce swipe to delete sensitivity"
...
This reverts commit 94881f8241
2019-06-28 12:47:36 -07:00
Colin Lee
f375eac6bd
For #3732 : Race Condition Crash in HomeFragment onPreDraw ( #3737 )
2019-06-27 20:33:21 -05:00
Emily Kager
9142e2279c
For #1968 - Adds menu option to add new folder in BookmarkFragment menu
2019-06-27 15:17:00 -07:00
Tiger Oakes
606e66219c
No issue: Use chains for bookmark items ( #3696 )
...
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2019-06-27 13:47:42 -07:00
Emily Kager
c9962a7ad0
Closes #3701 - When deleted use bookmark title if url is null in snackbar ( #3716 )
2019-06-27 13:39:00 -05:00
Sawyer Blatz
13df8d7ddd
For #3711 : Fixes save to collection from browser crash ( #3714 )
2019-06-27 11:29:00 -07:00
Sawyer Blatz
66eb4fd03b
No issue: Fixes master compilation
2019-06-27 09:05:57 -07:00
Colin Lee
7481d52c4b
For #3505 : Opening a sent tab crashes Fenix ( #3507 )
2019-06-27 10:47:54 -05:00
Nikit Bhandari
6ccd32f093
For #3496 : dismiss share fragment when clicking outside content ( #3513 )
...
* dismiss share fragment when clicking outside content
* add logic in view layer
2019-06-27 10:43:13 -05:00
Emily Kager
77edb7afe1
For #2960 Closes #3671 - Fixes bookmark deletion with undo, wraps list
2019-06-26 18:59:13 -07:00
ekager
61a8795576
For #1211 - Hide keyboard on fling suggestions list
2019-06-26 16:44:35 -07:00
Tiger Oakes
e8bd090a8e
No issue: Use ImageView rather than rebuilding drawable ( #3616 )
...
HomeFragment's onboarding items included drawableStart values, but also
built drawables in the view holders to replace them. Instead, we should
just use ImageViews so that work isn't duplicated.
2019-06-26 16:03:06 -07:00
Tiger Oakes
4994554576
No issue: Adds lint exception for when statement ( #3685 )
2019-06-26 15:52:24 -07:00
Sawyer Blatz
309014139d
For #3488 : Cleans up edit mode calls ( #3689 )
2019-06-26 15:40:07 -05:00
Yeon Taek Jeong
2cafd5bba6
For #3678 : Fix crash when tapping on your account ( #3688 )
2019-06-26 13:33:27 -07:00
Emily Kager
427bc5c1e6
Revert "For #1211 - Hide keyboard on fling suggestions list"
...
This reverts commit cb6fd83c9879c268cb739fb768187d5276c5af66.
2019-06-26 11:19:09 -07:00
Tiger Oakes
a78d36354a
Switch RadioButtonPreference to ConstraintLayout
...
Also ensure that RTL works properly.
2019-06-26 09:45:55 -07:00
Sawyer Blatz
d28168ac64
For #2940 : Hides send tab header on FxA error
2019-06-25 17:08:46 -07:00
Tiger Oakes
30930cdc88
Import variables referred to by path
2019-06-25 13:57:34 -07:00
Tiger Oakes
55f5c5d049
Use lifecycleScope for settings fragments
2019-06-25 13:56:33 -07:00
Tiger Oakes
d01bb8c442
Use lifecycleScope for collections fragments
2019-06-25 13:56:15 -07:00
Tiger Oakes
6bf8d6be34
Use @JvmOverloads instead of multiple constructors
2019-06-25 13:55:31 -07:00
Colin Lee
94e99cf877
For #3364 : Edit bookmarks should show corrected bookmarks tree ( #3446 )
2019-06-25 14:19:33 -05:00
Emily Kager
74111c75de
For #3639 - Remove fontInflationEnabled ( #3640 )
2019-06-25 10:24:32 -05:00
Emily Kager
ddebc98718
No issue: Follow up on optional filter style
2019-06-24 17:03:38 -07:00
Colin Lee
ea7841b8c5
No issue: Add Sentry breadcrumbs to ease crash investigations
2019-06-24 16:21:43 -07:00
Denys M
6d6b240e48
Add unit tests for Settings.
...
Add unit tests for `Settings`.
2019-06-24 16:02:34 -07:00
Emily Kager
718ac5612c
For #3593 For #3581 - Pass sessions to delete to delete all with undo ( #3594 )
2019-06-24 15:41:38 -07:00
Emily Kager
084fab77d4
For #3609 - Remove FIP Integration, Use FIP Feature ( #3637 )
2019-06-24 15:31:32 -07:00
Emily Kager
6e3197f61c
For #3622 - Add ID to engine shortcut suggestions ( #3636 )
2019-06-24 15:30:27 -07:00
royang51
e244aae104
For #3214 - History multi-selection aborted, the same item can't be selected again ( #3607 )
2019-06-24 15:27:06 -07:00
Sawyer Blatz
07516f47c3
For #3215 : Adds collection restoration with unique IDs ( #3635 )
2019-06-24 14:12:51 -07:00
vmbaicu
021900e7ad
Fixes #3527 - Set Collection name max length ( #3531 )
2019-06-24 13:58:04 -07:00
Nikit Bhandari
cfefc5632b
For #3489 : Disables blank collection names ( #3490 )
2019-06-24 13:44:02 -07:00
Andrei Teslovan
2ebe0a2a48
Fixes #3529 - Display "Edit folder" title when editing a bookmark folder ( #3549 )
2019-06-24 13:34:15 -07:00
Emily Kager
03a5cb2fb4
For #3620 - Adds automatic theme onboarding content description ( #3629 )
2019-06-24 13:15:38 -07:00
Sawyer Blatz
a5a518f4a5
For #2940 : Hides send tab on FxA error ( #3595 )
2019-06-24 12:52:20 -07:00
Sawyer Blatz
721908ade6
For #3055 : Adds android components version to about page ( #3596 )
2019-06-24 12:52:04 -07:00
Colin Lee
22bcd70edc
For #3213 : Fix multi-select bookmarks on return to fragment ( #3413 )
2019-06-24 10:10:49 -07:00
Emily Kager
afb59251c1
For #3588 - Preload the content process when starting Gecko ( #3589 )
2019-06-20 13:00:22 -07:00
Emily Kager
b1102c2e76
For #3544 - Set SearchSuggestions preference value from settings
2019-06-18 16:56:34 -07:00
Tiger Oakes
ab6101b0f4
Fixes #3539 - vectordrawablecompat for gradients ( #3541 )
2019-06-18 16:38:56 -07:00
Tiger Oakes
b70dced16e
Fixes #3538 - Fix ic_tabs icon path ( #3540 )
2019-06-18 16:38:42 -07:00
Colin Lee
0135424883
For #3508 : "Send crash report" checkbox is ignored ( #3512 )
2019-06-18 16:38:29 -07:00
Grisha Kruglov
521312c6f8
Disable send tab for non-nightly, non-debug builds ( #3542 )
...
* Put deviceCapabilities list behind a SEND_TAB_ENABLED flag
* Disable SEND_TAB for non-debug, non-nightly builds
2019-06-18 16:37:50 -07:00
Mihai Tabara
ccc5b91992
Import PR 3500 from ekager
2019-06-14 18:52:27 -07:00
Stefan Arentz
6e6e662c47
Update HomeFragment.kt
2019-06-14 18:34:58 -07:00
Jeff Boek
90bdbd04e0
No Issue - Capture session manager in scope before creating the delete operation
2019-06-14 18:34:58 -07:00
Emily Kager
ac5c4a0f79
Closes #3493 - Show tab saved to collection snackbar in BrowserFragment
2019-06-14 15:49:56 -07:00
Jeff Boek
7ebdfcc87b
For #1116 - Uses alias link for help
2019-06-14 15:33:34 -07:00
Jeff Boek
5540230e3d
For #1116 - Changes help link ( #3491 )
2019-06-14 15:29:10 -05:00
Jeff Boek
3b848393f7
For #981 - Adds link to mma.md to telemetry.md
2019-06-14 13:27:50 -07:00
Jeff Boek
45b096c84f
For #981 - mma docs
2019-06-14 13:27:50 -07:00
Jeff Boek
f323c38be0
For #981 - Adds missing Leanplum events
2019-06-14 13:27:50 -07:00
Emily Kager
6bd9b82385
No issue: Remove flash of tab adapter updating data in create collection
2019-06-14 11:01:54 -07:00
Colin Lee
d5c5587a0c
For #3209 : Disable shared element animations for crash temporarily ( #3482 )
2019-06-14 12:13:13 -05:00
Sawyer Blatz
041eaa2a5c
For #3275 : Cleans up feedback from James ( #3398 )
2019-06-14 08:59:57 -07:00
Emily Kager
e28277693b
Closes #3428 - Make + in collection creation selection stage clickable
2019-06-13 22:37:47 -07:00
Jonathan Almeida
986bc91347
For #3401 : Update toolbar tab counter when view is attached
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2019-06-13 16:12:19 -07:00
vladikoff
dfe181aa0a
Add application-services fretboard feature flags
2019-06-13 15:29:59 -07:00
Emily Kager
8b4c2db4e4
For #3433 - Add checkbox hide changes to change payload
2019-06-13 13:01:44 -07:00
Emily Kager
1f1320920f
For #3275 - Invoke pending single session delete job on close all ( #3438 )
2019-06-13 12:58:45 -05:00
Jeff Boek
1212887e08
For #1242 - properly record metrics ( #3437 )
2019-06-13 09:57:56 -07:00
Emily Kager
510b6f7373
For #2899 - Improve collections scroll and highlight animations
2019-06-13 09:21:12 -07:00
Andrei Teslovan
e458d8b6a1
Fixes #3365 - Set selectedFolder to null if it's already selected ( #3415 )
2019-06-13 10:52:35 -05:00
Emily Kager
5eb2bc6d55
For #3138 - Sets height of toolbar in SearchFragment to match_parent ( #3400 )
2019-06-12 19:44:44 -05:00
Sawyer Blatz
381a5e6089
For #3403 : Subscribes to tab collections in BrowserFragment
2019-06-12 16:44:35 -07:00
Jeff Boek
227a80957e
For #382 - Include Marshmellow in the guard..
2019-06-12 15:45:58 -07:00
Jeff Boek
dad671ca3c
For #382 - Hides default browser switch for older versions of Android
2019-06-12 15:07:58 -07:00
Jonathan Almeida
1b7a9817e2
For #2905 : Remove device name during sync logout
2019-06-12 17:07:56 -04:00
Jonathan Almeida
f71bdcfd10
For #3388 : Set max length for device name ( #3397 )
2019-06-12 15:35:06 -05:00
Colin Lee
f1088222b4
For #3203 : Updates edit bookmarks to have user friendly names ( #3372 )
...
Co-authored-by: Colin Lee <mncolinlee@gmail.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>"
2019-06-12 14:10:43 -05:00
Emily Kager
186983b786
For #3275 - Adds PendingSessionDeletion data class to handle multiple emit session calls ( #3393 )
2019-06-12 10:49:20 -07:00
Jonathan Almeida
80e7868fd7
For #1134 : Set UA to GeckoView 69.0 for whitelisted domains
2019-06-12 13:27:42 -04:00
Sawyer Blatz
7bcc8d576e
For #2219 : Inflates toolbar menu from bottom ( #3389 )
2019-06-12 11:17:33 -05:00
Colin Lee
66a836cf3a
For #3314 : Toolbar and QAB unresponsive after Android 6 perms check ( #3373 )
2019-06-12 10:08:39 -05:00
Jeff Boek
332b4c4da5
For #3278 - makes the string a constant
2019-06-11 16:24:28 -07:00
Jeff Boek
fc603e65a5
For #3278 - Removed redundant override
2019-06-11 16:24:28 -07:00
Jeff Boek
fead5183c8
For #3278 - pin the default search engine to the top
2019-06-11 16:24:28 -07:00
Jeff Boek
a86ec60f8f
For #3278 - Fixes search engine selector layout
2019-06-11 16:24:28 -07:00
Emily Kager
71f2b0bdaa
For #2253 - Use toolbar as anchorView with fullscreen snackbar
2019-06-11 15:09:07 -07:00
Christian Sadilek
ccc7c70967
For #3252 : Reader mode appearance buttons are not visible in PB
...
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2019-06-11 18:02:29 -04:00
a79014
d2c3427f1e
Doesn't print gecko emoji on android ver < 7 (android N) ( #3115 )
...
* Doesnt print gecko emoji on android ver < 7
* fixed typo on maybeGecko variable
* Closes #3076 : Lizard char now doesn't appear if not supported androidver
* Closes #3115 : Prints string instead of gecko emoji in unsupported
android versions
2019-06-11 16:40:51 -05:00
Emily Kager
edc1422b68
For #3288 - call setChecked after calling setOnCheckedChangeListener ( #3357 )
2019-06-11 16:38:32 -05:00
Colin Lee
b498f5559b
For #3333 : Only show desktop bookmarks if logged in ( #3356 )
2019-06-11 16:37:34 -05:00
jhugman
26d0ddda98
Fixes #3358 - disable feature-app-links ( #3359 )
2019-06-11 16:34:28 -05:00
Emily Kager
de45dfd98a
For #3131 - Add new task and clear task flags when opening intent ( #3363 )
2019-06-11 16:33:38 -05:00
Gabriel Luong
f05eb032d4
For #2684 : Add an extension function Session.toTab to map Session to Tab and clean up their usage
2019-06-11 13:14:23 -07:00
vmbaicu
a2f2a23a15
Fixes #3281 - Fix Report and onboarding lint errors and issues ( #3339 )
2019-06-11 12:33:12 -05:00
Sawyer Blatz
3e5b6ca007
For #975 : Removes leakcanary and default browser telemetry ( #3350 )
2019-06-11 12:30:25 -05:00
Emily Kager
82cf81242f
For #3331 - Delay restoring layout while list restores ( #3354 )
2019-06-11 12:27:32 -05:00
Sawyer Blatz
decacbfc97
For #3323 Runs PublicSuffixList synchronously
2019-06-11 09:19:51 -07:00
Grisha Kruglov
a58a77317e
Automatically close the 'auth-problems fragment' once we're through the auth flow ( #3340 )
2019-06-11 09:36:05 -05:00
Emily Kager
e57e7b50ee
For #2899 - Scroll to Collections on change, animate new collections ( #3279 )
...
* For #2899 - Scroll to Collections on change, animate new collections
* For #2899 - Scroll to tabs when tabs opened from collection
2019-06-11 09:01:00 -05:00
Emily Kager
975975e789
For #3326 - Remove open image in tab from context menu ( #3327 )
2019-06-11 08:59:00 -05:00
Sawyer Blatz
c17d024452
For #975 : Adds preferenceToggled event ( #3316 )
...
🤦🏼♂️
2019-06-10 13:56:12 -07:00
Sawyer Blatz
ab000d2e51
For #3280 : Revert "For #3215 : Restores collections properly" ( #3320 )
...
This reverts commit 3e9ee79c00f4a6b34af74ce7c179e0cbe37decf5.
2019-06-10 13:54:03 -07:00
Arturo Mejia
5df726715f
Revert "For #3008 , For #2162 Add Simple Logic for Menu Orientation" ( #3310 )
...
#3114
2019-06-10 10:58:18 -05:00
Colin Lee
f7b5fc3e18
For #3186 : Add environment to Sentry reports ( #3261 )
2019-06-10 10:55:39 -05:00
Tiger Oakes
82d2a0661b
Remove deprecatd support-ktx methods ( #3305 )
2019-06-10 09:12:11 -05:00
Denys M
c9570fd6ff
Use Drawable.toBitmap() from androidx-ktx. ( #3286 )
2019-06-10 08:50:37 -04:00
Nikit Bhandari
d814e95794
fix crash on renaming a collection
2019-06-08 06:44:15 -07:00
Sawyer Blatz
86aac3e313
For #3176 : Hides camera options on devices without cameras ( #3273 )
2019-06-07 19:37:43 -05:00
Emily Kager
bf4916418a
For #1998 - Removes stable flag in entering fullscreen navigation
2019-06-07 15:20:30 -07:00
Sawyer Blatz
b2ca77269b
For #3251 : Fixes shortcut typing ( #3271 )
2019-06-07 15:07:46 -07:00
Sawyer Blatz
054635735a
For #2750 : Removes unecessary invalidate CollectionViewHolder call ( #3264 )
2019-06-07 13:38:18 -07:00
Sawyer Blatz
45c509fbce
For #2648 : Updates trimming of url hostname ( #3191 )
...
* For #2648 : Updates trimming of url hostname
* For #2648 : Fix nits
2019-06-07 09:33:07 -07:00
Emily Kager
7368a95d29
No issue: Sets up observers for tab collection changes ( #3248 )
2019-06-07 09:45:38 -05:00
Jonathan Almeida
f7bd39da77
For #3138 : Fix white background on search bar
2019-06-06 17:11:06 -07:00
Colin Lee
1e6da54263
For #3238 : fixes race condition crash, nav destination unknown
2019-06-06 15:46:34 -07:00
Jonathan Almeida
0a3b001abe
For #3167 : Show help page in browser menu ( #3230 )
2019-06-06 16:55:15 -05:00
Emily Kager
acea0d5668
For #2785 - Adds back item animator session control ( #3233 )
2019-06-06 16:54:49 -05:00
Emily Kager
ed39b7828b
For #3234 - Updates labels of fragments in the nav graph to avoid flash ( #3235 )
2019-06-06 16:52:25 -05:00
Jeff Boek
0fefbbf5fb
For #1809 - Restore all crashed tabs
2019-06-06 12:58:32 -07:00
Sawyer Blatz
8537ff10a8
For #3215 : Restores collections properly ( #3219 )
2019-06-06 14:26:05 -05:00
Emily Kager
4954aadd84
For #3156 - If only one tab adding to collection make it selected ( #3222 )
2019-06-06 14:24:25 -05:00
Colin Lee
28ecf241f5
For #1301 : Always observe sessions to keep uri_count ( #3172 )
2019-06-06 14:16:31 -05:00
Sawyer Blatz
6682386fc8
For #1242 & #975 : Fixes camelcase of telemetry
2019-06-06 10:59:09 -07:00
Denys M
605a552f16
For #1366 . Update toolbar search state when typing. ( #2908 )
2019-06-06 08:16:22 -07:00
Emily Kager
33eb26861d
For #3141 For #3142 Do not try to fade BrowserFragment in transitions ( #3195 )
2019-06-05 20:37:58 -05:00
Emily Kager
9624964bc3
For #3087 - Adds disabled color attr ( #3192 )
...
* For #3087 - Adds disabled color attr
* Change alpha to 40%
2019-06-05 20:37:16 -05:00
Emily Kager
93a5456785
For #2253 - Shorten Fullscreen snackbar length ( #3190 )
2019-06-05 20:36:13 -05:00
Emily Kager
704f1e6a3d
For #3004 - Restore MotionLayout on Home View only in onCreateView
2019-06-05 14:46:38 -07:00
Grisha Kruglov
fe3c163a20
Fix how we reflect FxA state in preference
...
This cleans up how we're displaying account state in the main preference UI.
Before when it worked, it worked mostly accidentally.
'launch' wrapper around "update ui" methods would trigger a race condition
between binding the account pref view holder and actually updating that view
with values. Sometimes the "update view with values" would happen after view
was bound, and the UI will be correct. Most of the time it would happen before,
and so there will be nothing to update and we'd get into an inconsistent state.
This also splits up the "accountpreference" into two: account is good,
and account needs re-auth. This greatly simplifies their management.
2019-06-05 14:38:06 -07:00
Grisha Kruglov
0e1d81126d
Make 'remove account' work on the "reconnect to sync" screen
...
This seems to have been copy-pasted and wasn't hooked up correctly.
2019-06-05 14:38:06 -07:00
Grisha Kruglov
7af61b1560
Navigate away from account settings after encountering auth problems
2019-06-05 14:38:06 -07:00
Sawyer Blatz
47c14b07dd
For #1190 : Removes syncing items from FxA telemetry
2019-06-05 13:57:18 -07:00
Sawyer Blatz
c4c5d44430
For #975 : Updates telemetry for settings ( #3171 )
2019-06-05 13:34:42 -05:00
Sebastian Kaspari
b2d81aba43
Issue #2381 : Add feature-media component and enable notification for recording devices.
2019-06-05 20:20:44 +02:00
Jeff Boek
27fdd9605b
For #2395 - Adds an early return statement and documents why we copy a feature
2019-06-05 10:47:21 -07:00
Jeff Boek
f26c402f0a
For #2395 - Properly takes you back to where you start authentication on completion
2019-06-05 10:47:21 -07:00
Sawyer Blatz
12eabd5eb3
For #977 : Listens to correct custom tab open menu fact
2019-06-05 09:34:50 -07:00
mythio
2daa75db2c
Closes #3000 : Replace deprecated method
2019-06-05 09:33:58 -07:00
Emily Kager
14c581c012
For #3004 - Do not restore motionlayout state in ReloadData
2019-06-05 09:33:07 -07:00
Emily Kager
94881f8241
For #3135 - Reduce swipe to delete sensitivity
2019-06-04 16:10:28 -07:00
Sawyer Blatz
0b3a8b7a54
For #2316 : Adds confirmation dialog to delete bookmark
2019-06-04 14:47:11 -07:00
Sawyer Blatz
8e24feefc2
For #1192 : Updates detection for Lockwise
2019-06-04 11:23:18 -07:00
ekager
87f6268816
For #3101 - Do not show tab selection screen for 1 tab
2019-06-04 10:08:43 -07:00
Emily Kager
dc0d153580
For #3008 , For #2162 Add Simple Logic for Menu Orientation ( #3114 )
...
* For #3008 - Adjust orientation of collections menu based on view location
* For #2162 - Add simple menu orientation logic to bookmark menu
2019-06-04 10:37:57 -05:00
Emily Kager
ef0618a3d1
For #3103 - Exit fullscreen on pause ( #3112 )
2019-06-04 10:36:16 -05:00
Emily Kager
ca186c8776
Closes #1618 - Add fade to awesome bar list instead of shadow ( #3110 )
...
* Closes #1618 - Add fade to awesome bar list instead of shadow
* For #1211 - Hide keyboard on fling suggestions list
2019-06-04 10:35:47 -05:00
Colin Lee
5fb100debd
For #1966 : Up button should cancel multi-selection first ( #3108 )
2019-06-04 10:08:06 -05:00
Jeff Boek
40a3246c32
Adds dialog style for Firefox Accounts
2019-06-03 19:08:26 -07:00
Colin Lee
04a759f0b0
For #2693 : Launching Fenix via adb with URL crashes ( #3099 )
2019-06-03 16:24:37 -05:00
Tiger Oakes
94c4013810
Closes #3091 - Hide Pull to Refresh under flag ( #3092 )
...
This was merged in after feature freeze so we're pulling it out for
now. Pull to refresh will continue to work in debug mode so that the
design can be iterated on easily.
2019-06-03 14:10:53 -05:00
Colin Lee
04bbeb5ae6
For #3073 'Open in Firefox Preview' no longer opens in app
...
Saving and restoring the custom tab session ID fixed one problem while causing another. I added code to only restore the ID if the session has a customTabConfig associated.
2019-06-03 10:04:17 -07:00
Mitchell Hentges
62473e5e86
Migrates "raptor" build type to work for chrome-perf-testing, too ( #2926 )
2019-06-03 16:32:38 +02:00
ekager
d285e799b9
Clean up logic to return margin pairs for readability
2019-06-03 10:00:00 -04:00
ekager
14fe356d62
For #2794 - Adjust engine margins when enter/exit fullscreen
2019-06-03 10:00:00 -04:00
ekager
98a40aabd7
For #2223 , For #371 - Replace Toolbar with FIP when opened
2019-06-01 10:24:55 -07:00
ekager
388581f76f
For #3056 - Filter sessions on invoke for pending delete all job
2019-05-31 18:52:02 -07:00
Jeff Boek
e15ab3f958
For #1158 - Use a dot instead of an underscore to seperate values
2019-05-31 18:15:07 -07:00
Colin Lee
532483498a
No issue: Store the Custom Tab Session ID to avoid a crash ( #3062 )
2019-05-31 17:03:58 -05:00
Arturo Mejia
038aecc0ee
For #1919- Websites' icons are not displayed on Site permissions ( #3050 )
...
Exceptions.
2019-05-31 16:27:12 -05:00
Emily Kager
d5a9627273
For #2941 - Remove Delete Dialog, Theme Dialogs ( #3052 )
2019-05-31 16:26:34 -05:00
Emily Kager
0327b1146b
For #2977 - Update add new collections flow ( #2991 )
...
* For #2977 - Update add new collections flow
* Rename shared elements to be more general
* Make tab list not clickable in other modes
* For #2577 - Stop Flickering in List
* Add extensions function for next step with collections list size
2019-05-31 12:59:51 -05:00
Emily Kager
f48db90716
No issue: Always try to pop to browser when navigating to browser ( #3043 )
2019-05-31 12:57:34 -05:00
Jeff Boek
14f1d40e10
Fixes #3041 - Fixes the string that gets displayed in the FxA Onboarding card
2019-05-31 10:44:14 -07:00
James Hugman
060cd646c8
Fixes #1570 - Enable app-links feature
2019-05-31 10:39:47 -07:00
Sawyer Blatz
35a745d67d
For #2836 : Fixes custom tab close button color
2019-05-31 09:50:46 -07:00
Jeff Boek
301984733a
For #225 - Adds completion snackbar
2019-05-31 09:42:44 -07:00
Jeff Boek
eda70ab74c
Fixes #3037 - Unchecks boxes after deletion
2019-05-31 09:42:44 -07:00
Jeff Boek
0036938312
For #225 - Fixes crash by moving GeckoView calls t othe main thread
2019-05-31 09:42:44 -07:00
Emily Kager
1bb4d72fd1
For #3027 , For #2858 Pass in Fenix Snackbar for Context Menu Candidate ( #3028 )
2019-05-31 10:16:08 -05:00
Jonathan Almeida
ab39a5088a
For #2052 : Fix BrowserToolbar overlapping web content
2019-05-30 20:40:56 -04:00
Jeff Boek
209b50016e
For #2723 - Cleans up code formatting
2019-05-30 16:38:31 -07:00
Jeff Boek
f9d70dbc92
For #2723 - Creates callbacks to wire up the mode and theme manager together
2019-05-30 16:38:31 -07:00
Jeff Boek
a7d5cdcb9d
For #2723 - Fixes theme manager
2019-05-30 16:38:31 -07:00
Emily Kager
18cd9e58f9
Fixes Crash: Pop up to Browser Fragment if exists when coming from Search
2019-05-30 16:30:06 -07:00
Emily Kager
8dbed67f7f
No issue: Simplify and speed up shared element transitions
2019-05-30 16:30:06 -07:00
Emily Kager
43a961fe73
For #1973 - Toggle QR button on deny permissions, fix engineView crashes
2019-05-30 16:06:37 -07:00
Colin Lee
72c5cb304c
For #2893 , #2673 , #2916 , #2314 : Fix race condition navigating to browser ( #3023 )
...
Since the Navigation library restores the fragment after memory eviction, if we're already on the BrowserFragment and we deep link navigate to the BrowserFragment, we briefly get two of them. This crashes GeckoView.
2019-05-30 17:43:32 -05:00
Emily Kager
4c970a545d
For #2230 - Fix theme selection radio button for Android 6 ( #3019 )
2019-05-30 17:06:46 -05:00
Tiger Oakes
74dd2a5f23
Issue #103 - Pull to refresh ( #3020 )
2019-05-30 17:05:49 -05:00
Sawyer Blatz
cd19f36b96
For #2227 : Fixes issue with bookmark selection ( #3021 )
2019-05-30 17:01:51 -05:00
Sawyer Blatz
9e0e5d95d9
For #2931 : Show browser snackbar above quick action sheet
2019-05-30 14:52:09 -07:00
Sawyer Blatz
5e0771a6f0
For #2327 : Fix early return from displayAccountError
2019-05-30 13:45:56 -07:00
Sawyer Blatz
7fff475fd8
For #1679 : Pause media playback when backgrounded
2019-05-30 13:06:37 -07:00
Jeff Boek
0054e017ea
For #255 - Moves all deletion operations to the same coroutine
2019-05-30 13:05:51 -07:00
Christian Sadilek
0b00c0ce9b
No issue: ClipboardProvider no longer needs to be added/removed based on input
2019-05-30 13:03:50 -07:00
Emily Kager
3685b05586
For #3011 - Size EngineView for Custom Tab Fixed Toolbar
2019-05-30 12:40:54 -07:00
Emily Kager
c027feecd0
For #3011 - Size EngineView for Custom Tab Fixed Toolbar
2019-05-30 12:40:54 -07:00
Sawyer Blatz
b8c04e02e9
For #2327 : Fixes nits
2019-05-30 11:45:39 -07:00
Sawyer Blatz
fe50e88fc8
For #2327 : Adds error state syncing
2019-05-30 11:45:39 -07:00
Emily Kager
caa36c31cd
For #2979 - Prevent double navigation to Create Collection Fragment
2019-05-30 10:58:56 -07:00
Grisha Kruglov
5f42a65c2a
No issue: improve allowUndo
...
This patch fixes a few issues:
- it was an extension on a CoroutineScope, but that was quite misleading
since the Main dispatcher would be always used regardless of what dispatcher
the owning CoroutineScope was configured with.
- timing was reliant on exact value of the undocumented Snackbar.LENGTH_LONG duration
- coroutine cancellation relied on cooperation of the 'operation' suspend function,
which we can't depend on
New 'allowUndo' fully controls its timing, doesn't imply a dispatcher to its consumers,
and doesn't rely on cooperation of passed-in suspend blocks for cancellation to work.
2019-05-30 10:48:59 -07:00
Emily Kager
3560e1793c
For #2980 - Pop to home if no session exists in Browser Fragment
2019-05-30 09:05:10 -07:00
Emily Kager
c589e4d4c3
For #2938 - Remove save to collection from PB browsing menu
2019-05-30 08:42:20 -07:00
Emily Kager
e61cebf38d
No issue: Check search engine icon exists before setting drawable
2019-05-30 08:33:30 -07:00
Denys M
8bed44819d
Fixes #2254/#2709. Observe browser sessions changes on HomeFragment.
2019-05-29 15:13:15 -07:00
Jeff Boek
6527e05405
For #2738 - Re-throws exceptions to send better data into the crash reporters
2019-05-29 13:33:36 -07:00
Emily Kager
f142be8c92
Refactor new param to startInEditMode
2019-05-29 12:27:48 -07:00
Emily Kager
d6c1f65d72
Start MotionLayout animation to end while navigating to search fragment
2019-05-29 12:27:48 -07:00
Emily Kager
8181705b58
Init Toolbar in edit mode so we don't see the flash
2019-05-29 12:27:48 -07:00
ekager
dee3c059dc
Adds Shared Transition between Home and Search
2019-05-29 12:27:48 -07:00
Jeff Boek
3920cda693
For #2419 - Adds a deletion state to the history component
2019-05-29 12:20:19 -07:00
Denys M
39df4c8522
For #747 . Improve HistoryFragment readability.
2019-05-29 10:21:48 -07:00
Denys M
13f144f212
For #747 . Fix coroutines leaks in HistoryFragment.
2019-05-29 10:21:48 -07:00
Jonathan Almeida
b05e9ab14b
Closes #2968 : Specify the activity name in the share item
2019-05-29 13:12:46 -04:00
Grisha Kruglov
70453ef2d5
No issue: increase likelyhood of notification showing up as 'heads-up'
2019-05-29 09:52:35 -07:00
Grisha Kruglov
fda0f1de97
No issue: sync and refresh device state on foreground
2019-05-29 09:52:35 -07:00
Emily Kager
039990f608
For #2972 - Call session feature back press before custom tab back press
2019-05-29 09:40:52 -07:00
Grisha Kruglov
9e7269214c
Closes #2835 : Do not assume bookmarks fragment is attached while processing operations
...
This is mostly necessary when we're running stuff in a coroutine, so the patch likely goes
overboard a bit with the nullability checks... but it shouldn't hurt.
2019-05-29 09:19:03 -07:00
Sawyer Blatz
6a53127ef9
For #2948 : Adds menu button add tab to collection
2019-05-29 09:08:11 -07:00
Sawyer Blatz
3fd831cc4d
Fixes #2942 : Updates strings for l10n ( #2950 )
2019-05-29 10:47:19 -05:00
Emily Kager
1ef85433b4
For #2891 - Make checkbox invisible so text isn't cut off
2019-05-28 20:57:02 -07:00
Emily Kager
6290d7b890
For #2110 - Pressing back on external link should close the tab
2019-05-28 17:55:17 -07:00
Emily Kager
cae95c0ee1
For #2952 - Delete All Tabs should run on Main Thread
2019-05-28 16:25:39 -07:00
Arturo Mejia
b2e27d26dc
Closes #2903 : Fixed crash when trying to rate the app on a devices without
...
the play store app.
2019-05-28 15:14:56 -07:00
Jonathan Almeida
540b0939d2
Closes #2878 : Cleanup with card-like styling
2019-05-28 15:11:41 -07:00
Arturo Mejia
b5d1d04d88
Closes #2900 : Fix crash when trying to show site info panel with
...
a null session.
2019-05-28 15:05:49 -07:00
Jonathan Almeida
3da6cfd98a
For #2886 : Fix sending multiple tabs to another device ( #2923 )
...
* For #2886 : Fix sending multiple tabs to another device
* Update share methods to use new API
2019-05-28 15:05:16 -07:00
Arturo Mejia
ba6bb916e4
Closes #2789 : Custom tabs is not covering the full screen size.
2019-05-28 15:01:18 -07:00
Emily Kager
bfc0fa36b1
For #2133 - Add destructive text color to delete history button
2019-05-28 14:59:21 -07:00
Emily Kager
506f332b85
For #2919 - Invoke Pending Delete Jobs in onPause
2019-05-28 14:59:05 -07:00
Emily Kager
a6a72885d2
For #2898 - Adds Deselect All in Collection Creation Select Tabs Step
2019-05-28 14:58:16 -07:00
Emily Kager
e0ceb195ff
For #2337 - Open Report Site in Browser from Custom Tab
2019-05-28 14:56:01 -07:00
Emily Kager
7d65e21b83
For #2941 - Creates delete dialog style
2019-05-28 13:41:38 -07:00
Emily Kager
250548a72f
For #2823 - Invoke pending jobs with context on switch to private mode
2019-05-28 12:48:02 -07:00
Jonathan Almeida
06bf7a4da7
For #2890 : Sending tab from another device shows empty title
2019-05-27 16:39:56 -04:00
Jonathan Almeida
d825011fc0
Fixes #2872 : Send tab notification never dismisses ( #2889 )
2019-05-27 19:31:59 +02:00
Harsh Shandilya
7d9c8726c5
treewide: Resolve compilation warnings ( #2859 )
...
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-05-27 19:04:17 +02:00
Jonathan Almeida
db2eba9762
For #2876 : Fix crash on sync now button clicked
2019-05-27 12:38:11 -04:00
Jeff Boek
d24aa8a772
For #927 - Adds build type to glean to report the channel
2019-05-24 17:43:24 -07:00
Sawyer Blatz
9aa4f48e77
For #1190 : Adds additional telemetry for FxA login
2019-05-24 17:39:19 -07:00
Sawyer Blatz
62bed0cd06
For #1190 : Adds telemetry for FxA login
2019-05-24 17:39:19 -07:00
Emily Kager
2ad6875f09
No issue: Correct material dependency and anchor snackbar above toolbar
2019-05-24 17:38:20 -07:00
Jeff Boek
e3031378bc
For #225 - Address small nits, changes default color of ic_delete
2019-05-24 17:16:03 -07:00
Jeff Boek
0cbaeaffdc
For #225 - Properly delete collections
2019-05-24 17:16:03 -07:00
Jeff Boek
51451ff002
For #225 - Deletes data on button press
2019-05-24 17:16:03 -07:00
Jeff Boek
3cf91fc303
For #225 - Adds button to delete browsing data
2019-05-24 17:16:03 -07:00
Jeff Boek
072ef5785d
For #225 -Adds checkbox listener to data items
2019-05-24 17:16:03 -07:00
Jeff Boek
e9c7943fe8
For #225 - Adds icons for list items
2019-05-24 17:16:03 -07:00
Jeff Boek
3006b21508
For #225 - Adds list items for delete browsing data
2019-05-24 17:16:03 -07:00
Jeff Boek
182bbdf359
For #225 - Adds delete browsing data fragment
2019-05-24 17:16:03 -07:00
Emily Kager
01c9317be0
For #2843 - Improve Collections UI and UX ( #2851 )
2019-05-24 17:06:17 -07:00
Jonathan Almeida
1de2e58644
No issue: Add device name to account page
2019-05-24 15:29:34 -07:00
Tiger Oakes
207a8d6772
Use a ListAdapter for SessionControl
2019-05-24 13:13:52 -07:00
Jonathan Almeida
2fd91daa5b
No issue: Fix NotificationManager icon color
2019-05-24 11:32:55 -07:00
Sawyer Blatz
36f4b97712
For #658 : Adds your rights page link
2019-05-24 11:32:27 -07:00
Emily Kager
09588dfda6
For #2529 - Remove "Delete Collection" button from private browsing
2019-05-24 10:53:15 -07:00
Emily Kager
4e13de3ffd
No issue: Register observers with owner view
2019-05-24 10:53:05 -07:00
Emily Kager
a676e964b5
For #966 - Preserve CustomTab history when opening in browser
2019-05-24 10:50:20 -07:00
Sawyer Blatz
549292d06e
For #2732 : Removes view model usage from collection creation
2019-05-24 10:40:32 -07:00
ekager
2f46345954
Cancel pending findBookmarkJob if another is started
2019-05-24 09:42:22 -07:00
