Commit Graph

2040 Commits (180652deab3a7f93df3568a51874fdb66bf0448c)

Author SHA1 Message Date
Mihai Branescu 432d5fbff4 For #5848 Wrong toolbar colour - edit bookmark fragment (#6047)
- Moved toolbar coloring to extension method
- Refactored classes using it
- Removed selection mode colouring for EditBookmarkFragment toolbar,
making it only black and white (normal mode)
5 years ago
Mihai Branescu 4efc661db8 For #5733 - Private mode notification - wrong home screen (#6188)
- added PRIVATE MODE intent extra to the notification action
 (could use also the OPEN_FROM_NOTIFICATION, but I considered this one to
 be more explicit. Kept the old one in case other checks will be done
 filtering for it)
- added intent? param to the getPrivateModeFromIntent method, because
onNewIntent() method does not set the activities intent, and it was needed
to be used both in onCreate() and onNewIntent()
5 years ago
ekager fb17ae2258 For #6229 - Remove all tab options from custom tab context menu 5 years ago
Emily Kager 6435a503ca For #6219 - Reset default setting if user opts out of experiments 5 years ago
Jonathan Almeida 59c0fb504e Revert "For #373 - Integrate leanplum-fcm"
This reverts commit ed239ec250.

We're choosing to revert LeanPlum push messaging integration since we believe
that this has introduced a crash in Firebase push messaging. To verify
this assumption we're reverting this change, and when confirmed, we can
re-introduce Leamplum in a safer manner.

See #6250 and #6251 for related info.
5 years ago
Sawyer Blatz 4359c215e6 For #5737: Adds telemetry for open links in a private tab (#5975) 5 years ago
Denys M 6290c0c826 Closes #2441. Update LeakCanary to `2.0-beta-3` version. 5 years ago
ekager f49331de55 For #5544: Bare Minimum Logins UI 5 years ago
Jeff Boek d1643b785e For #2477 - Adds accessibility setting to force enable zoom 5 years ago
Sebastian Kaspari b3ce0b421b Update to Mozilla Android Components 19.0.0-SNAPSHOT. 5 years ago
Sebastian Kaspari 9543f38978 Use new toolbar API of AC 18.0.0. 5 years ago
Sawyer Blatz 2cba624609
No issue: Fixes string issues for l10n (#6158)
Issues found here: https://github.com/mozilla-l10n/android-l10n/pull/89
5 years ago
MozLando cc9ee5a3d8 Merge #5332
5332: For #2483 #2629: Close tab with no history on back press and return to parent if available r=ekager a=mawen7



Co-authored-by: mawen7 <mawen7@users.noreply.github.com>
5 years ago
Severin Rudie f812ae4259 For #3676: fix duplicate uri events on first load (#6128) 5 years ago
mawen7 3af307b47f Close tab with no history on back press and return to parent if available 5 years ago
Severin Rudie aa8642f534
#4596 migrate collections (#5911)
* For #4596: move code from CollectionCreationComponent to CollectionCreationStore

Other than adding comments, no changes were made. The code will be updated in a following commit. This is in order to make the commit diff more readable.

* For 4596: update CollectionCreateStore to libstate

* For 4596: copied CollectionCreationUIView into CollectionCreationView

Otherwise, no code was changed. The next commit will update this code. This is in order to make the commit diff more readable.

* For 4596: update CollectionCreationView to LibState

Note that the minimal changes possible to enable migration were made.  Refactoring will happen in a later commit.

* For 4596: updated CollectionCreationTabListAdapter to work with the new View

* For 4596: updated SaveCollectionListAdapter to work with the new View

* For 4596: implemented CollectionCreationController

For now, it has an identical interface to the interactor. In a later commit several of its responsibilities will be moved around, some to the interactor and some to the reducer

* For 4596: copied over previous reducer code

No other changes were made. The code will be updated in the following commit. This is done to make changes more readable for the reviewer

* For 4596: update reducer code param names

Otherwise, no changes at this time

* For 4596: add arguments to CreateCollectionFragment in nav_graph

These will be used to replace the current CreateCollectionViewModel, which shares data between fragments in a way that doesn't fit within our architecture.

* For 4596: pass arguments to collection via transaction instead of VM

The VM will be removed in a later commit

* For 4596: update BrowserToolbarController to share state to collection via its Direction

* For 4596: removed CreateCollectionViewModel

* For 4596: test tab retrieval in CreateCollectionFragment

* For 4596: fix crashing CreateCollectionFragmentTest

* For 4596: removed classes create collection classes used by old architecture

* For 4596: collection interactor rename + kdoc

* For 4596: moved collection interactor interface

* For 4596: renamed CreateCollectionFragment

All related classes followed the pattern of CollectionCreationX

* For 4596: kdoc CollectionCreationController

There's no effective difference between these calls and their interactor equivalent, so I linked to them

* For 4596: fix bug that caused rename to not work

* For 4596: removed unused collection actions

These were unused before the LibState refactor

* For 4596: kdoc StepChanged

* For 4596: removed todos about moving logic to the reducer

saveTabsToCollection: this could be moved, but that would involve creating a new action. SaveCollectionStep should probably be refactored out, so adding this layer of indirection seemed counterproductive

handleBackPress: needs to be able to call dismiss(). The reducer doesn't (and shouldn't) be able to do that, so this needs to live here

stepBack: called by handleBackPress. See above

* For 4596: wrote tests for CollectionCreationController#stepback

* For 4596: fixed tests broken by changes to collections

* For 4596: small readability refactor for CollectionController#stepBack

No change to functionality (see tests)

* For 4596: broke apart CollectionView#update

There's probably a lot more that could be done here, but smaller changes were made to reduce scope

* For 4596: remove unnecessary todos

It looks like we don't follow the suggested pattern in this project

* For 4596: test CollectionCreationController#normalSessionSize

* For 4596: updated naming in CollectionCreationController per review
5 years ago
Pawel Obarzanek 40cda1d758 Closes #2435 Change edit icon to share icon on the book… (#6137)
* Closes mozilla-mobile#2435 Change edit icon to share icon on the bookmark toolbar

* Closes mozilla-mobile#2435 Changed raw string to string resources

* Pass bookmark arguments to share fragment

* Closes mozilla-mobile#2435 add orEmpty
5 years ago
Tiger Oakes cbc449d3b6 Refactor asCamelCase to use string builder (#6141) 5 years ago
Sebastian Kaspari 5d5358ae45 Issue #36170: BaseBrowserFragment: Use new feature-prompts API. 5 years ago
Tiger Oakes 4e3a3665d6 For #3366 - Use one layout for edit/add bookmark (#5900) 5 years ago
Mihai Adrian fbec001e28 For #1383: Fix updating description of close button on title change. (#6020) 5 years ago
ValentinTimisica ef42d3e4dc Fixes #5030: Modified Dialog to match the others. (#6022)
I changed the Dialog from permissions exceptions and used AlertDialog
instead of Context.alert extension function.
5 years ago
Mihai Branescu e23528291a For #6063 - changed ETP blocking info title strings (#6082) 5 years ago
Shangeeth Sivan d223a0bd35 Closes #5465: Added OnCheckListener to all checkboxes ,when there are no items checked delete button will be disabled (#6098) 5 years ago
ValentinTimisica 485ccba189 Fixes #5323: Show a snackbar while browsing data is deleting. (#6105) 5 years ago
Jeffrey Starke 2de6a9aca7 Don't show fingerprinters section of the standard tracking policy UI (#6125) 5 years ago
Sören Hentzschel a76cd9cc67 no issue - removed unused feature flags (#6143) 5 years ago
MozLando b963a3eab5 Merge #6102 #6106
6102: For #6018 Re-add Search Shortcuts Button r=boek a=BranescuMihai



6106: For #5872 & #6075: Set TabHeader buttons to invisible instead of gone. r=boek a=mcarare

At least one button has to be invisible instead of gone to keep layout height.
Tabs overflow button kept gone to avoid empty space on view end in private mode.



Co-authored-by: Mihai Branescu <branescu.mihai2@gmail.com>
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
5 years ago
MozLando a5755d131f Merge #6107
6107: Fix #3122 - Hide the "Bookmark saved" Snackbar when user closes BrowserFragment r=boek a=Mugurell

Previously the Snackbar was being inflated in the parent of this Fragment so
surviving it being closed.
Tying the Snackbar with the Fragment from which it is shown ensures it will be
effectively hidden whenever the user navigates from the Fragment.



Co-authored-by: Mugurell <mugurell@users.noreply.github.com>
5 years ago
Tiger Oakes e572562c7a Cleanup shortcut code 5 years ago
Tiger Oakes a598148b29 Fixes #5225 - Hide AuthCustomTabActivity 5 years ago
mcarare 86217eb105 For #5872 & #6075: Set TabHeader buttons to invisible instead of gone.
At least one button has to be invisible instead of gone to keep layout height.
Tabs overflow button kept gone to avoid empty space on view end in private mode.
5 years ago
Mihai Branescu 2be4d08228 For #6018 - Added back shortcuts button in awesomebar
Refactored logic for adding providers, since shortcut providers should
be alone in the list, while all others can be as list
5 years ago
Mugurell faddf368e1 Fix #3122 - Hide the "Bookmark saved" Snackbar when user closes BrowserFragment
Previously the Snackbar was being inflated in the parent of this Fragment so
surviving it being closed.
Tying the Snackbar with the Fragment from which it is shown ensures it will be
effectively hidden whenever the user navigates from the Fragment.
5 years ago
MozLando aa1a5f3d32 Merge #6026
6026: For #5709: Align ETP onboarding popup implementation with original mocks r=ekager a=mcarare



Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
5 years ago
MozLando 610a70a8bc Merge #6024
6024: For #5749 - Update string for ETP onboarding popup r=ekager a=BranescuMihai



Co-authored-by: Mihai Branescu <branescu.mihai2@gmail.com>
5 years ago
MozLando a1f96a0ec7 Merge #6025 #6032
6025: For #5063: Added parameter customTabSessionId into ContextMenuFeature r=ekager a=ValentinTimisica

Added parameter customTabSessionId into ContextMenuFeature in
BaseBrowserFragment in order to show the context menu in a custom tab.



6032: For #5990: Revert sessionTokenScope to fix broken QR pairing flow r=ekager a=grigoryk

Seems like addition of sessionTokenScope is causing issues with pairing. For now, we can revert that change until the underlying issue is fixed.

For #5990.



Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro>
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
5 years ago
Grisha Kruglov 031f923273 Revert sessionScopeToken to fix broken QR pairing flow 5 years ago
mcarare b82a794908 For #5709: Align ETP onboarding popup implementation with original mocks 5 years ago
ValentinTimisica 6fa9572ccf Fixes #5063: Added parameter customTabSessionId into ContextMenuFeature
Added parameter customTabSessionId into ContextMenuFeature in
BaseBrowserFragment in order to show the context menu in a custom tab.
5 years ago
Mihai Branescu 1490c0178f For #5749 - Update string for ETP onboarding popup 5 years ago
MozLando 9d3dc2b6dc Merge #5775
5775: Closes #5233, don't display private-browsing-shortcut creation items if shortcut already exists r=NotWoods a=bswe

Closes issue #5233:

Added doesPrivateBrowsingPinnedShortcutExist() method to the PrivateShortcutCreateManager class to check for the existence of the shortcut.  Code only works on devices with API 25 or higher, so a check for that condition was also included in the new method.

Calls to the new method were added to the SettingsFragment and HomeFragment classes to determine whether the settings menu item and the recommendation dialog should be displayed.

**Quality**: The pre-push test failed to start on my windows 10 OS, but this code has been thoroughly tested manually on simulators and physical devices.

**Tests**: This code only effects UI appearance so not sure how to test for that and no tests were written.

**Screenshots**: This code does not add anything new to the UI, it only controls whether to display existing items.

Co-authored-by: bswe <bbollenbacher@mindspring.com>
5 years ago
ekager 663126f696 No issue: Remove black flash workaround 5 years ago
bswe a570b910c2 Reformatting to simplify use of .any construct as suggested in review 5 years ago
bswe 6bc5d96f92 Reformatting to use .any construct as suggested in review 5 years ago
bswe 052695ffa1 Issue #5233: Minor modifications suggested in code review. 5 years ago
bswe 7ec714552f Issue #5233: Added call to doesPrivateBrowsingPinnedShortcutExist function to determine whether the "recommend private browing shortcut" dialog is displayed. 5 years ago
bswe 9913a024d8 Issue #5233: Added call to doesPrivateBrowsingPinnedShortcutExist function to determine whether the "add private browing shortcut" item is visible in the settings menu. 5 years ago
bswe dcebd83e9f Issue #5233: Added doesPrivateBrowsingPinnedShortcutExist function to determine whether a shortcut already exists (only available in API >=25). 5 years ago
MozLando 8e4d7248ac Merge #5908
5908: Closes #5876: Removed @ObsoleteCoroutinesApi in tests r=sblatz a=shldhll


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [ ] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

Co-authored-by: shldhll <iam.shldhll@gmail.com>
5 years ago
MozLando 2856e6b8c7 Merge #5973
5973: For #5898: Launch SUMO article properly for default browser r=colintheshots a=sblatz



Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
5 years ago
Sawyer Blatz 2395b9b941 For #5898: Launch SUMO article properly for default browser 5 years ago
MozLando 6b6c752fa9 Merge #5956
5956: For #5947 - Fix engineView NullPointerException r=csadilek a=ekager



Co-authored-by: ekager <emilykager@gmail.com>
5 years ago
MozLando fba375135f Merge #5933
5933: Removes legacy nightly automation r=johanlorenzo a=mitchhentges



Co-authored-by: Mitchell Hentges <mhentges@mozilla.com>
5 years ago
MozLando bb22fb3092 Merge #5507 #5846
5507: For #1383 Added tab title to close button content description r=ekager a=mcarare


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

5846: For #3604 Snackbar messages for closing tabs use closed instead of deleted r=sblatz a=mcarare


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
5 years ago
ekager e8bb765ad7 For #5947 - Fix engineView NullPointerException 5 years ago
MozLando f66b9f3e8f Merge #5633
5633: Add fxa/sync integration tests r=csadilek a=isabelrios

 Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [-] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [-] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

This PR tries to add new tests, sync integration tests, to check the sync process Desktop<->Fenix, first for Bookmarks and in the future for more.

Co-authored-by: Isabel Rios <isabelrios@mackbookirios.home>
Co-authored-by: isabelrios <isabelrios@gmail.com>
5 years ago
MozLando 8cf54f773b Merge #5882
5882: For #5873 Added on/off indicator for delete browsing data on exit pref r=sblatz a=mcarare


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
5 years ago
Mihai Adrian 167c6dca93 For #2570: Hide 3-dots menu for all library items when in select mode (#5699)
Removed items from RecyclerView cache to allow setting the new visibility
Disabled hidden buttons, otherwise they could still be clicked
5 years ago
Sawyer Blatz 980b11610b For #5094: Adds telemetry for show search shortcuts 5 years ago
Sawyer Blatz b0d796ccee
For #5898: Default browser toggle sends user to SUMO on Android 5&6 (#5918) 5 years ago
Mitchell Hentges a497d2bcd0
Removes legacy nightly automation 5 years ago
Mugurell 8f0325c05b For #3584 - Check if menu is open before showing a new one (#5674)
Could have implemented this check (if menu is showing) inside the show() method
of BrowserMenu but this would mean the client (us) would go to the process of
building a new menu and then trying to have it displayed only for this to be
ignored by BrowserMenu in a somewhat opaque way.
Having this check done as soon as possible offers us full control and avoids
the unnecessary steps for building an already shown menu.
5 years ago
Grisha Kruglov 17d183ea0b Closes #5913: Add new sessionToken scope 5 years ago
shldhll 8e17ac05b1 Optimized imports. Closes #5876 5 years ago
shldhll f907ec52f0 Removed ObsoleteCoroutinesApi in tests. Closes #5876 5 years ago
Jeff Boek ed239ec250 For #373 - Integrate leanplum-fcm 5 years ago
Christian Sadilek 7552bacb32 For #778: Follow-up to fix find in page 5 years ago
Emily Kager f9afd97a68 For #1901 - Get rid of black flash when leaving GV Engine 5 years ago
Tiger Oakes 6ec0d46f6b Closes #394 - Trusted Web Activities (#5391) 5 years ago
mcarare 788e52be0c For #5873 Added on/off indicator for delete browsing data on exit pref 5 years ago
Roger Yang e9760fb185 Closes #5847: Use IO thread when submitting crash report 5 years ago
Tiger Oakes 78bc829735 Closes #778 - Progressive Web Apps! (#4914) 5 years ago
Severin Rudie 411ccc8f1f For 4780: add DefaultBrowsingModeManager tests 5 years ago
Severin Rudie c9e68bda31 For 4780: remove Settings#usePrivateMode and tests 5 years ago
Severin Rudie dd6439269b For 4780: ThemeManager now sends an intent before recreating
Updating themes recreates the activity, so if we aren't persisting 'usePrivateMode', we need to pass it to the new instance
5 years ago
Severin Rudie 693034951c For 4780: rename 'setPrivateModeIfNecessary' 5 years ago
Severin Rudie d1d20b544e For 4780: update HomeActivity to maintain private mode in memory
As an added bonus, this makes the temporal coupling between `setPrivateModeIfNecessary` and `setupThemeAndBrowsingMode` explicit.  They previously would have broken if called in reverse order, now it will fail to compile.
5 years ago
Severin Rudie 10f334303d For #4780: remove previous fix for leaking private mode status
This didn't function when 'open links in a private tab' was set.  Rather than adding another sketchy fix for the edge case, following commits will change `usePrivateMode` to be maintained in memory, instead of in Settings.
5 years ago
Sawyer Blatz 4045fb0107 For #4190: Removes waterfall animation from awesomebar 5 years ago
Sawyer Blatz 6484a48147
For #5787: Fixes shortcuts asking to launch private alias (#5825) 5 years ago
mcarare 1c6aefd82b For #3604 Snackbar messages for closing tabs use closed instead of deleted 5 years ago
isabelrios 0e3148f0da fixing more reviewers comments 5 years ago
Isabel Rios 44f4cedefd Add fxa/sync integration tests
fixing Jenkins path to tests and clean tests

commenting future tests and adding doc with info about the tests
5 years ago
Tiger Oakes d5c3433041 Use the new fragment constructor 5 years ago
Denys M a4439ff373 For #3563. Use `ListAdapter` for App Share list. 5 years ago
Denys M e55eda30fb For #3563. Use `ListAdapter` for Bookmark folder selection list. 5 years ago
ekager f6285ad5f8 For #3846 - Pass in updated session icon to tabs 5 years ago
Tiger Oakes d028c97112 For #5213 - Use support library attributes 5 years ago
Prat T 80a1e6dd2c Fixes #5351 - listen to onIconChanged in HomeFragment 5 years ago
Prat T fe648a0b99 Fixes #5351 - use session icon in tab view on home 5 years ago
Emily Kager 2b19b28d25 For #5651 - Set up Standard vs Strict Tracking Protection Experiment 5 years ago
Sawyer Blatz 19a2d9df4f For #1620: Hide search results when they match URL 5 years ago
mcarare 22eb207cef For #5784: Fix hiding default browser preference in sdk<=23 5 years ago
Colin Lee b7647a454f
For #5599: Remove dependency on fetch_httpurlconnection (#5716)
* For #5599: Remove dependency on fetch_httpurlconnection

* For #5599: Switch Glean to GeckoViewFetchClient

* Use existing Gecko client for Glean
5 years ago
Emily Kager 40e6284aef For #5442 - Show Delete Browsing Data on Quit option in home menu 5 years ago
Sawyer Blatz 841b06b02f
No issue: fixes master (#5777) 5 years ago
Sawyer Blatz 371e2ac3d8
For #514 & #5742: Updates "launch links in private tab" functionality (#5721)
* For #514 & #5742: Updates "launch links in private tab" functionality

* Fixes comments
5 years ago
Christian Sadilek b733e4fa8f Upgrade to Mozilla Android Components 16.0.0-SNAPSHOT 5 years ago
Severin Rudie 3be06953d6 For #4780 switch off private mode (#5614)
* Do not launch in Private Mode

When the app launches do not launch in Private Mode in order to prevent usage leaks to other users of the device.

* Issue #4780: add comments to use private mode

* For #4780: write tests for clear private mode on create app

* For #4780: clear private mode when privacy notification is removed
5 years ago
Sawyer Blatz e8216e3079
For #5094: Adds telemetry for suggestion toggles (#5704) 5 years ago
Sawyer Blatz 785b8b9519
For #5567: Removes search shortcuts button (#5739)
* For #5567: Removes search shortcut button

* No issue: Simplifies logic for displaying shortcuts
5 years ago
Sawyer Blatz 2896b36d14
No issue: Updates naming of launch links privately var (#5701)
The previous name was pretty confusing
5 years ago
Sawyer Blatz eb3c9f86e2
No issue: Removes feature flags for delete data (#5738) 5 years ago
Emily Kager f7c9ab11eb For #3487 - Add back open image in new tab 5 years ago
Michael Droettboom a250241523 1585250: Initialize metrics off of the main thread 5 years ago
Sawyer Blatz 669e694af9 For #5672: Fixes broken send tab link 5 years ago
Sawyer Blatz 69c42b6192 For #5681: Sets OPEN_TO_BROWSER false when using new tab shortcut 5 years ago
Emily Kager e9a0f1f65d For #2078 - Filter Out Self in Share Sheet (#5641) 5 years ago
Sawyer Blatz c8af16bd47
For #5679: Hides autoplay behind feature flag (#5685) 5 years ago
ekager ef29fe2584 Update BackgroundServicesTest, Suppress Complex Method 5 years ago
Grisha Kruglov a4097cd380 FxA WebChannels integration
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971)

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
5 years ago
Chenxia Liu 8f97d247a6 For #235 - Add Glean crash count + docs. 5 years ago
Sawyer Blatz 3e42114190 For #5656: Fixes nightly major version number crash 5 years ago
Sawyer Blatz a38b73f19e Fixes #5653: Removes crash with null campaign 5 years ago
mcarare 64923978e6 For #1071 Added Desktop Mode icon 5 years ago
Sawyer Blatz 5e18ead45e For #4474: Adds tests and fixes issues 5 years ago
Tiger Oakes ee1f040e53 No issue: Move signedIn tracking to BookmarksSharedViewModel (#4755) 5 years ago
Sawyer Blatz 7f328a6dc4
For #1298: Adds adjustCampaignId to core ping (#5579) 5 years ago
Sawyer Blatz 6babf72352
For #5197: Adds telemetry for media notification (#5520) 5 years ago
Tiger Oakes 88aa519210 Closes #4711 - Extract VoiceSearchActivity (#5502) 5 years ago
Emily Kager 3f41a4e9c6 No issue: Update navigation library 5 years ago
Sawyer Blatz 11baabb63a No issue: Updates fact mapping to use enums 5 years ago
Emily Kager c3287b17ac Closes #5624 - Fix crash on preference change listener 5 years ago
Mihai Adrian 62ae025d65 For #4991:Ensured deleteSelectedBookmarks deletes all selected bookmarks (#5559)
Moved the deletion to a CoroutineScope(IO) to decouple from fragment lifecycle
Used local val tempStorage to keep reference to bookmarkStorage of outside class
Ran deletions with awaitAll to avoid concurrency issues on storage
5 years ago
Severin Rudie dffa61bf16 Closes #4513: fixes bookmark tests broken by loading change
Note that BookmarkFragmentStoreTest changes preserve existing behavior, which in many cases is more expansive than the test name implies
5 years ago
Severin Rudie fd7f1b2665 Closes #4513: adds tests for bookmark loading state 5 years ago
Severin Rudie fbdd537bc7 Closes #4513: show progress bar when loading bookmarks 5 years ago
Severin Rudie ca6c324f29 Issue #4513: added isLoading to bookmark state
This was added to the state object as a top level param because it could reasonably coexist with any value of `tree` or `mode`. Even if we don't now, we may someday want to display a loading indicator while also showing cached bookmarks.

For now, we set isLoading to false whenever we receive any bookmarks
5 years ago
Severin Rudie 96472a533a Issue #4513: fix mismatched bookmark listener lifecycles
The mismatch here was creating potentially inconsistent states. When first put into a CREATED or STARTED state, the listener would not be active, however after going through onResume it would then stay active until destroyed.

We should only be navigating to bookmarks when in a RESUMED state, so this change should be safe. I tried it a few times to verify. But I've been wrong before!
5 years ago
Colin Lee de93b05cac For #2754 Add tab cards to share sheet (#5493)
* For #2754 Add tab cards to share sheet

* For #2754: Fix background near rounded corners and ShareButtonAppearanceTest

* Add license to share_tab_item
5 years ago
Christian Sadilek ac2611d744 Upgrade to A-C 15.0.0-SNAPSHOT (incl. required changes) (#5578)
* Upgrade to Mozilla Android components 15.0.0-SNAPSHOT

* Update findinpage integration to use browser-state

* Use new UseCases APIs after download migration.
5 years ago
Mugurell c5330c6880 For 5092 - Show a Snackbar with retry option if sharing to devices fails (#5158)
* For #5092 - Show a Snackbar with retry option if sharing to devices fails

ShareController will contain all the business logic for checking the result
status of the `share to device` operations. When this fails it will show a
snackbar which also offer the possibility to retry the just failed operation.
To allow this even in the event the user has closed the share fragment we'll
use a GlobalScope's coroutine.
Refactored out the TabsSharedCallback from ShareFragment because otherwise we
would have neede to sent through that the just failed operation. After the
refactor the ShareController is solely responsable for showing the right
snackbar and handling the retry actions.

* For #5092 - Refactor ShareControllerTest

* For #5092: Adds color theming of snackbars
5 years ago
ekager 0b01635ce0 For #2874, #5375, #5131 - submitList workaround for Android 5 + 6 5 years ago
ekager 44bb592b43 For #5312 - Send ETP Strict/Standard event 5 years ago
ekager 24b3ed4384 For #5568 - Don't pass in Session for QuickActionSheetController 5 years ago
Emily Kager b0b60aa27d For #5281 - Use TrackerLog for reporting ETP categories (#5556) 5 years ago
Sawyer Blatz b6e6e36ccd For #561: Fix stutter of search icon & text when animating 5 years ago
Sawyer Blatz 75a25c9bd0 For #561: Fix linting issue 5 years ago
Jeff Boek c592a69aad For #561 - Fixes snackbar placement on homeview 5 years ago
Jeff Boek 5c092c1ef1 For #561 - Adds shadow/highlightto the bottom bar 5 years ago
Jeff Boek 00d1be97ac For #561 - Wires up add tab button inside the bottom bar 5 years ago
Jeff Boek b16754d78a For #561 - Adds add tab and menu button to bottom bar
- Adds space between wordmark and session control component
5 years ago
Jeff Boek abbb310ce3 For #561 - Removes the toolbar from the home screen
- Removes the menu button
- Fixes motionlayout animation with the wordmark/private browsing button
5 years ago
mcarare bfe8bf4663 For #1383 Added tab title to close button content description 5 years ago
Jeff Boek 1c9c5317eb For #5552 - Temporary fix for startup crash on es locales 5 years ago
Sawyer Blatz 856399e9e2
No issue: Fixes GleanMetricsService nits & broken UI test (#5539)
* No issue: Fixes GleanMetricsService nits

* No issue: fixes broken UI test
5 years ago
Alessio Placitelli 1ffdf1cf9b Add basic test coverage for Glean metrics in Fenix
This introduces test coverage, using the Glean SDK
testing API, for the metrics that are set at startup
by Fenix in the GleanMetricsService.

This additional adds a basic test for the translation
of the `app_opened` event.
5 years ago
Emily Kager 25e2a7abfc For #2765 - Run places maintenance daily (#5466) 5 years ago
Mihai Adrian c7c752cabb For #5356 Improves private browsing "common myths" link accessibility (#5479)
Added separate TextView for link text
Used UnderlineSpan to show text as link
Split string private_browsing_placeholder, one for each TextView
Set clickListener on TextView so it can be accessed via Talkback
5 years ago
Tiger Oakes 8c30200ced Only use Context.settings() function (not getter) (#5335)
Remove unused String extensions
5 years ago
Tiger Oakes 734d4031e2 Extract UriOpened observer from HomeActivity 5 years ago
Tiger Oakes e3c60faf24 Move BookmarkNode extensions to helper class (#4752) 5 years ago
Mihai Adrian 236f702bbe For#5468 Changed info source for url clipboard copy from view to session (#5514) 5 years ago
Tiger Oakes cb7701584f No issue: Extract home fragment mode (#5343) 5 years ago
Emily Kager 9d9ff959b5 For #5312 - Add Telemetry for Tracking Protection 5 years ago
Christian Sadilek c866ae1a1e Closes #5444: IntentReceiverActivity: Add tests for intent processing 5 years ago
Sawyer Blatz f02603be37
For #5460: Fixes styling of fill link from clipboard (#5464) 5 years ago
Sawyer Blatz 4a6e647167
For #5197: Adds telemetry for media controls (#5266) 5 years ago
Tiger Oakes 6c30a94081 Move settings classes to packages 5 years ago
Tiger Oakes 699eacab39 For #778 - Rename CustomTabActivity 5 years ago
Tiger Oakes e9fd6892ba For #394, #778 - Add hide toolbar feature
And also add CustomTabsServiceStore
5 years ago
ekager 78ac6fc912 For #5448 - Reload custom tab session when TP is toggled 5 years ago
Michael Droettboom a63eaa9d67 1581556: Initialize Glean on the main thread 5 years ago
mihai-adrian 47064a68e0 For #5141 Changed "learn more" link to be accessible to Talkback users 5 years ago
Tiger Oakes 172a9cf06c Extract and test crash reporter code 5 years ago
ekager 464122fda1 For #5421 - Make share dialog scrim dismiss fragment 5 years ago
Dennis Schubert 5577470d0b No bug - Add WebCompat feature. 5 years ago
Tiger Oakes f71ec8928b Add note about lazy in FeatureFlags 5 years ago
Sawyer Blatz 6f3d7b4ee8 For #5396: Adds "always launch in private mode" to settings 5 years ago
Mihai Adrian a1c8fc0698 For #3731 Improved UX for opening tabs from a Collection (#5427)
* For #3731 Changed order of items for a collection's overflow menu

* For #3731 Changed the order tabs open to keep same order from collections
5 years ago
Tiger Oakes 05a4faec78 Add tryGetHostFromUrl and update ExceptionDomains 5 years ago
Colin Lee 1aa4f5a519 For #255: Toggle Media Autoplay 5 years ago
Sawyer Blatz 2db2d9ceae For #1744: Adds tests for clipboard 5 years ago
Sawyer Blatz fd1fcd8b89 For #4155: Adds paste & go for search terms 5 years ago
Sawyer Blatz e961a9d63d For #1744: Adds clipboard provider to search engine screen 5 years ago
Tiger Oakes 1777b5a830 Use enum to simplify delete on quit code 5 years ago
Tiger Oakes 106458c2c9 For #3440 - Reduce HomeFragment require calls 5 years ago
Jeff Boek 976c840047 For #3077 - Replaces connect another device dialog with a scree 5 years ago
Unpublished 065ce13999 Pass color resource for what's new menu item by id 5 years ago
Sawyer Blatz 50cd2920d3
For #5371: Updates search engine settings string (#5393) 5 years ago
Sawyer Blatz e1b84a7a08 For #5396: Reverts broken activity alias 5 years ago
Tiger Oakes 284cbab9ea Use .orEmpty() 5 years ago
Emily Kager 3e132f102c No issue: Update androidx libraries Sept 5 2019 5 years ago
Mihai Adrian 1767bd5569 For #5174 Changed FindInPage height to toolbar height to cover QAB (#5376) 5 years ago
Emily Kager 2b71af4087 For #5258 - Pop AccountProblemFragment if signed out 5 years ago
Grisha Kruglov 8a9340fd9d Post: Clean up 'push' initialization code 5 years ago
Grisha Kruglov d67fb3eed2 Post: Add experiment flags, push and telemetry tests for BackgroundServices 5 years ago
Grisha Kruglov eeaeb973ff Post: minor cleanup 5 years ago
Grisha Kruglov c2fb99a73f FxA WebChannels integration
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971)

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
5 years ago
Tiger Oakes a61391ef58 Separates tracker bucket sorting code 5 years ago
Emily Kager 140da0dd0f For #5359 , #5360 - Update ETP Vectors for Android 5+6 5 years ago
mawen7 9ebd4efe70 Pass app name to delete browsing data prompt 5 years ago
Sebastian Kaspari b8539ccb33 Use new feature-contextmenu API. 5 years ago
Tiger Oakes 42bb3e1410 Change deleteAndQuit to take an activity 5 years ago
Emily Kager da37dedba3 For #5279 - Don't use runBlocking in delete and quit 5 years ago
ekager 8cd0d8faf3 For #5304 - Align ETP Onboarding Tool Tip PopupWindow 5 years ago
Yeon Taek Jeong 3787dd7b1f For #5254: Fix transition to private browsing mode after sharing a page 5 years ago
Sawyer Blatz e247870b9f
For #5277: Updates string for delete browsing data (#5309) 5 years ago
Sebastian Kaspari dd85229c41 Use new feature-downloads API. 5 years ago
Sawyer Blatz 42b31f0088 For #4155: Adds elevation to copy/paste menu 5 years ago
Mihai Adrian c8bc144114 For #2570: Hide 3-dots menu when in select mode for bookmarks and history (#5173)
Show or hide overflow menu for entire list is triggered when mode is changed
For bookmarks, due to implementation of selection and diffUtil,
additional check is necessary for current item (last selected) that is redrawn
5 years ago
Emily Kager b83ae45c36 For #5263 - Hide ETP Panel Settings for custom tab 5 years ago
Tiger Oakes 4acf48e817 Fixes #5212 - Change tint in onCreateOptionsMenu
Also fixes #5213
5 years ago
Mihai Adrian bc16061939 For #3371: Show snackbar message when share fails with crash (#5210) 5 years ago
Emily Kager fcb0448fa5 For #4458 - Enable font inflation with font auto size setting (#5252) 5 years ago
ekager 4461230e9b For #5229, #5228 - Dismiss ETP panel on back press, don't truncate text 5 years ago
Emily Kager a5859e0028 For #5178 - Polish delete browsing data item layout 5 years ago
Emily Kager 102a36bd7e No issue: Updates isPWA to isInstallable for AC 13 snapshot 5 years ago
Roger Yang b3eca65614 Closes #5091: Refactor Sentry BreadCrumbs to use lib-crash BreadCrumbs 5 years ago
Jeff Boek e092dfd684 For #5047 - Addresses nits
- Changes MainScope to viewLifecycleScope
- Fixes string name/comment to better describe what it is
- Adds disabled state to the add button
5 years ago
Jeff Boek d18ec49704 For #5047 - Wires up dialog to webAppUseCases 5 years ago
Jeff Boek faff73b9b3 For #5047 - Creates dialog ui for naming a shortcut 5 years ago
Emily Kager e3209dcc84 For #3700 - Add Setting to Delete Data on "Quit" menu action 5 years ago
Yeon Taek Jeong ddc1b2e648 For #4658: Add private browsing mode shortcut telemetry 5 years ago
Emily Kager 418b1ba890 For #1749 - Use Strict ETP by default, use Feature Flag for Settings 5 years ago
Sawyer Blatz 999d3cb963 For #1114: Show playing tab 5 years ago
Emily Kager 9a4610f068 For #2897 - Add Action States To Share Sheet 5 years ago
Yeon Taek Jeong 2e2bac4ccd
For #419: Create launch icon for private browsing (#4948) 5 years ago
Sawyer Blatz 5586b18c3e For #4155: Handle custom tabs & fix test 5 years ago
Sawyer Blatz 53b3f105ca For #4155: Sets pastedText default value 5 years ago
Sawyer Blatz 9d30d7bb03 For #4155: Restyle to custom menu 5 years ago
Sawyer Blatz 52fd327bc0 For #4155: Adds tests for browser toolbar popup menu 5 years ago
Sawyer Blatz fdd2b59fb8 For #4155: Adds popup menu for browser toolbar 5 years ago
Emily Kager 4485b7f647 Add Tracking Protection Info Panel 5 years ago
mihai-adrian ef4a6b4154 For #4877: Restored logic for closing tabs when not on browserFragment
Added return in function when saving collections coming from browser fragment
5 years ago
Sawyer Blatz e240de7e31 For #4908: Adds telemetry for send tab 5 years ago
Tiger Oakes d0ef2d40c2 Move bookmark navigation listener to separate file 5 years ago
Sawyer Blatz f7dde41b3b For #5021: Adds telemetry for what's new button 5 years ago
Tiger Oakes 3c07cacf4d Use A-C preferences property delegates 5 years ago
Tiger Oakes b77c4d2e2e Clean up SupportUtils 5 years ago
Mihai Adrian a31eb1f371 Code Health #4883: Refactored accessing settings by using Context extensions (#4973) 5 years ago
Sawyer Blatz cd533854e6
No issue: Only use iconTint in XML for bookmark menus (#5145) 5 years ago
Tiger Oakes 16115f57d1 For #3440 - Reduce BrowserFragment require calls 5 years ago
Colin Lee 4c2a7ac10e Delete AUTH_SESSIONS with COOKIES 5 years ago
Colin Lee 758f4c13ec Updates per UX and PR feedback 5 years ago
Colin Lee 2b9efccfca For #3106: Granular options for clearing user data 5 years ago
Petru Lingurar 53341f620a Code cleanup - Remove unused FindInPageBarBehavior
There is a "unused" lint suppression in place with the comment
"Referenced from XML". I found no such usage.
It's documentation says that this Behavior will always position FindInPageBar
above BrowserToolbar but the current code ensures
BrowserToolbar.visibility == GONE when FindInPageBar.visibility == VISIBLE
so there's no need for such behavior.
5 years ago
Petru Lingurar 716cf3995a Fix #4856 - Propagate LifecycleAwareFeature's onStart() to the inner feature
FindInPageFeature is used inside the app as a LifecycleAwareFeature and as such
it receives the onStart / onStop lifecycle calls.
The onStart() lifecycle call would not get passed to the feature but in
onStop() FindInPageFeature will detach it's Presenter and Interactor so when
the user comes back to the screen she could not interact anymore with the
feature.
To fix this we'll propagate LifecycleAwareFeature's onStart() to the inner
feature which is to rebind it's Presenter and Interactor in onStart().

This behavior is common to all the other features so all of them who implement
LifecycleAwareFeature will now get the onStart() call also.
5 years ago
Mihai Adrian ed0b6bd5ef For #4193 - Makes close button for tabs more accessible (#4442)
* fixes #4193 - made close button for tabs more accessible.

set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button and text as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible

* Fix margins
5 years ago
Sawyer Blatz aef087aae0
No issue: Removes unused nestedScrollQuickActionView (#5143) 5 years ago
Sawyer Blatz 2653b5966e
For #964: Adds ability to disable each suggestion provider (#5096)
* For #964: Adds ability to disable each suggestion provider

* Fix nit
5 years ago
Jonathan Almeida ccd9e44a3e No issue: Add logging for firebase/autopush 5 years ago
Emily Kager 58287cd5bb For #5033 - Update browsing mode when session selected (#5118) 5 years ago
Emily Kager bb2a685ad9 For #5075 - Fix boolean error for private mode notification persistence (#5120) 5 years ago
Sebastian Kaspari 3a35233ac0 Remove ThumbnailsFeature. (#5127)
We currently do not use thumbnails anywhere in the app. Not using the feature means we are
not taking thumbnails on every page load which means we are saving memory and CPU cycles.
5 years ago
Grisha Kruglov 231924f5eb Fix breaking services APIs changes 5 years ago
Sebastian Kaspari 2c7fd93c7d Update to Mozilla Android Components 12.0.0-SNAPSHOT. 5 years ago
Sebastian Kaspari c2db07acf8 Add browser-state component. 5 years ago
Emily Kager a5e9da7a55 For #5025 - Do not remove custom tab session with config removed 5 years ago
Sawyer Blatz 09dcdb079d For #4474: Adds what's new button to home screen menu (#5088)
* For #4474: Adds what's new button to home screen menu

* For #4474: Adds tests for what's new button
5 years ago
Petru Lingurar 46b09395f8 For #5067 - Refactor ShareControllerTest following the use of SendTabUseCases 5 years ago
Petru Lingurar f7087e46e3 Fix #5067 - Refactor ShareController to use SendTabUseCases
Navigation between app fragments uses ShareTab as arguments. The newly used
SendTabUseCases uses TabData which is not Parcelable.
For minimal changes we'll keep both data classes and ShareController will know
how to map between the two.
Removed the `sessionId` property of ShareTab as it isn't needed anymore.
5 years ago
Sebastian Kaspari ba05d21657 Fix ktlint MaxLineLength issues. 5 years ago
Sebastian Kaspari 38d97fda8b Stores: Reduce visibility of reducer functions. 5 years ago
Sebastian Kaspari 2723a55b03 Rename HistoryStore/State/Action to HistoryFragmentStore/State/Action. 5 years ago
Sebastian Kaspari f3d8a89c63 Rename AccountSettingsStore/State/Action to AccountSettingsFragmentStore/State/Action. 5 years ago
Sebastian Kaspari 61e84c161d Rename SearchStore/State/Action to SearchFragmentStore/State/Action. 5 years ago
Sebastian Kaspari 22446263f1 Rename ExceptionsStore/State/Action to ExceptionsFragmentStore/State/Action. 5 years ago
Sebastian Kaspari ac32a88d45 Rename BrowserStore/State/Action to BrowserFragmentStore/State/Action. 5 years ago
Sebastian Kaspari 76063e307a Rename BookmarkStore/State/Action to BookmarkFragmentStore/State/Action. 5 years ago
mihai-adrian fc8fc2b33d Fixes #4997: Changed navigation to ShareFragment
Added global navigation action to share fragment in navigation graph
Changed share action to use global navigation to ShareFragment
5 years ago
Colin Lee 709588572a
For #5055: Crash when opening bookmarks (#5058) 5 years ago
Christian Sadilek 4cf03be236 For #2088: Use new async API to load default search engine in HomeFragment 5 years ago
Sebastian Kaspari 9b633f7f0f Move creation of GeckoRuntime to flavor-specific source set.
Since we are now able to build against GeckoView Nightly and GeckoView Beta,
we should create the GeckoRuntime from a flavor-specific source set.

Creating the runtime is not covered by the AC abstraction and so API changes
in GeckoView Nightly can break the build and leaves us with no option to fix
it from a shared code base. Separating the creation of GeckoRuntime
allows us to adapt individually and also to configure the runtimes
differently.
5 years ago
Will Hawkins 3abffd5d77 Use new async API to load and access search engines
Use the new asynchronous features of the search engine
manager from a-c to avoid the latency required to load
the default search engine.
5 years ago
Mugurell bf5b0e5cda For 4007 - Add unit tests for the Share Interactor, Controller and list Adapters 5 years ago
Mugurell e165868a53 For #4007 - Add ShareController for handling ShareFragment's business logic
`ShareController` defines a contract with all possible `ShareFragment`'s
behavior changes and comes with a default implementation -
`DefaultShareController`.
It is to be delegated by all `ShareFragment`s contained Views' Interactors
following any user interactions.
5 years ago
Mugurell 16eba61b25 For #4007 - ShareFragment will set the contained Views' state
ShareFragment which acts as a container would contain all business logic needed
for populating it's Views.
Data initialization should be done only once since the app state has no reason
to change after the ShareFragment is created and is done as soon as possible,
in onAttach().
Because of the expected short lifespan of this fragment, given the fact that
the state has no reason to change and we handle orientation changes ourselves
to keep things simple I didn't use a ViewModel to persist the state.
5 years ago
Mugurell 095870145f For #4007 - Refactor AppShareView in standalone Share Views
In an effort to respect the initial MVI architecture I've broken the
complex `AppShareView` in 3 separate Views
- `ShareCloseView`
- `ShareToAccountDevicesView`
- `ShareToAppsView`
They are standalone Views (extending LayoutContainer) which know nothing about
each other or their parent and so offer their container the possibility to
order or display them in any form later.
According to the lib-state contract they are only responsible to
- inflate themselves in their injected containerView
- render a certain state (to be added in later commits)
- delegate all user interaction to an associated Interactor
5 years ago
Mugurell 5e19741ddd For #4007 - Use camelCase for views referenced from code
As per #4341.
Also reformatted layouts to have a more consistent style.
Also refactored `AppShareRecyclerView` and `AccountDevicesShareRecyclerView` by
defining their LayoutManager in XML to reduce code complexity.
5 years ago
Tiger Oakes fb907033bb Add comments to AuthCustomTabActivity 5 years ago
Sawyer Blatz cea18f31c4
For #3892: Fixes help link on nightly (#4956) 5 years ago
Mihai Adrian 9b911f3276 Fixes #4894: added workaround for SDK<24 vector drawable with gradient color (#4944)
Removed drawableStart and added ImageView in layouts
Set ImageView logo programmatically: bitmap for SDK<24, vector for SDK>=24
Added onClickPendingIntent for ImageView in large and medium layouts
5 years ago
Tiger Oakes f740d4382a Closes #773 - Add shortcuts to homescreen (#4925) 5 years ago
mihai-adrian 5e78420cce Fixes #3602:navigate to top of home screen after tapping "start browsing"
After onboarding.finish(), scrolled homeLayout to top
5 years ago
Jonathan Almeida f25a9660e8 Closes #4218: Remove forced registration renewal for push 5 years ago
Jonathan Almeida 18ca62b887 For #4063: Remove SendTab feature flags 5 years ago
Yeon Taek Jeong d87b8a8a5c
For #4658: Add some private browsing mode telemetry (#4968) 5 years ago
Sawyer Blatz 09ed721015 For #4969: Removes erroneous FxA sign up ping (#4970) 5 years ago
Yeon Taek Jeong cc5408d717
For #2053: Add persistent notification to close all private browsing tabs (#4913) 5 years ago
Sebastian Kaspari aa5069caca Closes #4215: CustomTabActivity: Remove attached session if activity is finishing. (#4985) 5 years ago
Emily Kager 7b5ed2673b For #4863 - Remove delay in HomeFragment onPreDraw 5 years ago
Suraj Shah 66a8c04967 Fixes #4488: Shows snackbar on bookmark deletion from edit fragment (#4792)
* Fixes #4488
Updates changelog

* Removes wildcard imports.

* Removes custom label in use, replaces with let
5 years ago
Sebastian Kaspari 8608375eac Use Mozilla Android Components 10.0.1. 5 years ago
Jonathan Almeida 681257bea7 For #4960: Initialize push only if available (#4964) 5 years ago
Jeff Boek bfb2beabe7
For #4063 - Always enable the push service (#4932) 5 years ago
Tiger Oakes d1964d6536 Fixes #4771 - Add method for sessions of type (#4782)
Fixes share tabs to use the new method
5 years ago
Emily Kager 1cf8a40059 For #4295 - Adds Experiments Pref to Data Collection Settings (#4915) 5 years ago
Sebastian Kaspari c322343248 Closes #4431: Enable feature-media component for all builds. (#4898) 5 years ago
Emily Kager a65f220b39 For #4921 - Adds WindowFeature to BaseBrowserFragment 5 years ago
Arturo Mejia 24f79b3263 Fix safe browsing API breaking change. (#4946) 5 years ago
Sourabh 091778a4b9 For #4398 - add HistoryController (#4837) 5 years ago
Amaan Marfatia dc9fdd9db3 Fixes #4067 besides snackbar (#4777)
* Fixes #4067 besides snackbar

Makes layout hierarchy more shallow to increase performance.

* Fix #4067 Feedback

Make sure quick_action_overlay appears on top and use horizontal chain in tab_header.
5 years ago
Tiger Oakes 66e14959ba Add custom tab fragment 5 years ago
ekager ffbbe119f3 For #3967 - Invoke pending deletion on back pressed 5 years ago
ekager b07df9698a For #4868 - Update content description of tabs button with number of tabs 5 years ago
Grisha Kruglov 282c2dc182 No issue: only sync once on startup 5 years ago
Emily Kager b9f6f7fa93 For #4779 : Don't double navigate with global directions in HomeActivity 5 years ago
Emily Kager 84b0693fd2 For #4652 : Use workaround for HomeScreenViewModel (#4887) 5 years ago
Tiger Oakes 9f154dc3a0 Extract intent processors from HomeActivity (#4884) 5 years ago
Tiger Oakes 79e58250fc Make `Settings.instance` private 5 years ago
Sebastian Kaspari f62e295fc6 Closes #4874: Use new build types in FeatureFlags class. 5 years ago
Tiger Oakes c475bc87cf Move classes out of top-level package 5 years ago
Jeff Boek 68f5d211d3 For #4326 - Updates codebase to support latest version of detekt 5 years ago
Colin Lee 051ae9f584 For #3869: Switch to A-C SearchLocalizationProvider (#4858)
* For #3869: Switch to A-C SearchLocalizationProvider

* Fix test
5 years ago
Mihai Adrian df3e1bf9d3 Fixes #4795 fixed requestDesktopStateProvider value from private to desktopMode (#4810)
RequestDesktopStateProvider was taken from private instead of desktopMode
5 years ago
Tiger Oakes aab357845b No issue: Clean up preferences code (#4699) 5 years ago
Emily Kager c1b1c2f332 For #3967 - Invokes pending deletion with more bookmark actions (#4522) 5 years ago
Jonathan Almeida 71a2478f4d Use Mozilla Android Components 10.0.0 5 years ago
Emily Kager 416e25e8a5 No issue: Don't show session provider in private mode 5 years ago
Yeon Taek Jeong 6f899c7fb5
For #2834: Delete all Private Tabs redesign (#4787) 5 years ago
(´⌣`ʃƪ) c076cc85f9 For #4436: Dismiss onboarding before navigating away from home (#4801) 5 years ago
Tiger Oakes 33f3b14c29 Adds setters and property delegates in `Settings` (#4809)
* Change Settings to use setters

* Add delegate for shared preferences
5 years ago
Tiger Oakes ac6c1ec2ee Closes #2690 - Clean up CreateCollection viewmodel (#4731) 5 years ago
Tiger Oakes 9ee8c00928 For #4774 - Use vector drawable compat (#4811) 5 years ago
Tiger Oakes ad98b2f3ea For #4744 - Extract private browsing button (#4813) 5 years ago
Tiger Oakes 090e8006b0 Color the system bars in custom tabs (#4819) 5 years ago
Tiger Oakes 95ef312b1e Issue #1000 - Remove isCustomTab flag (#4656) 5 years ago
Sourabh 1afc0eacd8 For #4399: Create LibState Controller for Search (#4673)
* For #4399: Create LibState Controller for Search

* fix code format

* add unit tests for DefaultSearchController

* add more test

* fix unit tests
5 years ago
Mugurell ab6e7dc52b Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.

`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
5 years ago
Tiger Oakes b8c93107c0 For #4744 - Extract TransitionPreDrawListener (#4812) 5 years ago
Tiger Oakes a632d8f1dc For #4744 - Move search bar icon padding to dimens (#4814) 5 years ago
Emily Kager fb1d655d96 Closes #4822 - Update Bookmark State in onResume (#4823) 5 years ago
Sawyer Blatz 0d4eceed56 For #2706: Refactor Glean to reduce errors (#4753)
* For #2706: Adds recording for untracked events

* For #2706: Adds key alignment to Metrics
5 years ago
Sawyer Blatz 4731977f5d
For #4421: Fixes issues with new glean events (#4816) 5 years ago
Sawyer Blatz 73e3db8fe0 For #4804: Resolves issue with crash reporter stack 5 years ago
Arturo Mejia 210868f5bc Use Mozilla Android Components 9.0.0-SNAPSHOT. (#4750) 5 years ago
Suraj Shah 806961094b Fixes #4704 (#4728)
* Fixes #4704. Overrides `setEnabled` for DeleteBrowsingDataItem to change view alpha when disabled and to toggle the checkbox `isEnabled` behavior based on the value provided.

* Updates CHANGELOG.md

* Removes unnecessary disabling of checkbox in DeleteBrowsingDataItem.kt
Updates CHANGELOG.md to reflect the component changed.
5 years ago
Mugurell 645674c9bd Closes #4396 - Add a Bookmarks Controller (#4593)
* For #4396 - Rename BookmarkInteractor methods

Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.

Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.

* For #4396 - Add a BookmarkController

It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.

This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.

* For #4396 - Refactored Bookmark related tests

Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`

Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
5 years ago
Tiger Oakes de14962e3f Extract quick action sheet observer code (#4368) 5 years ago
Emily Kager 7d02354f4f For #4799 #4790 - Don't use passed in sessions in BrowserToolbarController (#4800) 5 years ago
Colin Lee d1aed157dd
For #4686: Fix potential security issue (#4764) 5 years ago
Yeon Taek Jeong d4c83f9668 For #4736: Display search shortcuts only from home or search widget 5 years ago
Yeon Taek Jeong a680d733c8 For #4384: Hide mic icon if speech-to-text is unavailable (#4701) 5 years ago
Yeon Taek Jeong 2441592ef2 For #4516: Use full width for large search widgets (#4659) 5 years ago
Emily Kager f71106cb51 Closes #3860 - Update description text for collections 5 years ago
Sawyer Blatz b7ca520787 For #4421: Adds Leanplum events and attributes (#4626)
* For #4421: Adds Leanplum events and attributes

* For #4421: Adds Leanplum deep links
5 years ago
Yeon Taek Jeong 67f3b63ae5
For #4421: Add search widget attribute to Leanplum (#4694) 5 years ago
Yeon Taek Jeong f5ffe3734c
For #4457: Adds telemetry for search widget actions (#4714) 5 years ago
Yeon Taek Jeong 2f265eccbd
For #4732: Fix search engine display issue (#4735) 5 years ago
Michael Cooper 12371ca9c1 Add no-op experiment to test service-experiments integration (#4551)
* Add no-op experiment to test service-experiments integration

* Shorten metric name to meet schema

* Add active_experiment metric to docs

* Add approved data review
5 years ago
Tiger Oakes 3acabeb6c3 Use global navigation action for browser fragment (#4691) 5 years ago
Colin Lee 5b4a441bcb For #1667: Screen reader can't reach other UI items when QAB expanded (#4695) 5 years ago
Emily Kager 1328d686aa No issue - Autoformatting (#4715) 5 years ago
Sourabh 42e3b2771e fix #4633: show toast only on first login (#4676)
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
5 years ago
(´⌣`ʃƪ) 5aac05859d Fix #4436: hide onboarding before navigating to settings (#4675)
* Fix #4436: hide onboarding before navigating to settings

* No issue: Rename emitAccountChanges to emitModeChanges
5 years ago
Sebastian Kaspari d03c15d15c Issue #4431: Integrate feature-media component (Nightly and debug builds only). (#4683) 5 years ago
Colin Lee 0c8bcd39be For #4652: HomeFragment Crash "Can not.. after onSaveInstanceState" 5 years ago
Jorge De Los Santos 337ad1e88e For #3424 - Make talkback ignore ImageButton in Collection Sele… (#3792)
For #3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
5 years ago
Grisha Kruglov b38b94ed79 Closes #4671: Fix a potential NPE in BookmarkFragment 5 years ago
Grisha Kruglov 634ee184a6 No issue: add some BookmarkFragmentInteractor tests 5 years ago
Grisha Kruglov f323105163 No issue: reduce code duplication in BookmarkFragmentInteractor 5 years ago
Christian Sadilek 5fe05e919a For #4125: Suppress coroutine warning to fix release build 5 years ago
Sawyer Blatz 0ec92d716f
For #4123: Adds telemetry for quick action open in app (#4629) 5 years ago
Yeon Taek Jeong 6c9ce784b1 Fix, add some tests 5 years ago
Yeon Taek Jeong 2a6069bfb7 Fix rest of issues 5 years ago
Yeon Taek Jeong 69434a765f Fix most issues 5 years ago
Yeon Taek Jeong faf0ecbcc0 For #4125: Migrate Sign in to Sync to Libstate 5 years ago
Colin Lee 7f07eabbd8
For #4652: Crash "Can not perform this action after onSaveInstanceState" (#4654) 5 years ago
Tiger Oakes 52542708aa Consodilate private browsing code 5 years ago
Jonathan Almeida 23f5ac0fb9 For #4066: Create InflationAwareFeature for lazy inflation 5 years ago
Colin Lee 519c3bde5d For #4066: Provide lazy inflation of Find In Page View 5 years ago
Colin Lee c9c43260c9
For #4529: Handle crash initializing CreateCollectionViewModel late (#4628) 5 years ago
Christian Sadilek e26570054a Suppress warning in LeanplumMetricsService to fix release builds 5 years ago
Mathieu Leplatre 04daf21437 Fix #4612: Fetch experiments from Remote Settings CDN 5 years ago
Colin Lee ef97173cd9
For #4529, #4427: Resuming after restoring instance state breaks UI (#4571)
* For #4529, #4427: Resuming after restoring instance state breaks UI

* Clear up warnings
5 years ago
Sawyer Blatz ff6e9bccb7
For #4451: Adds tests for DefaultBrowserToolbarController (#4493)
* For #4451: Adds tests for DefaultBrowserToolbarController

* Continue working

* Large refactoring of test

* Mock analytics

* Fix merge conflicts
5 years ago
Hakkı Kaan Çalışkan 0ea595743d Fixes #4562: Add a-c git hash to about page 5 years ago
Emily Kager 0b98d43c23 Closes #4602 - Add back transitions 5 years ago
Sawyer Blatz 4566bd6fba Fixes feedback 5 years ago
Sawyer Blatz 4d14735935 For #3060: Adds Leanplum attributes for fxa syncing 5 years ago
Sawyer Blatz 9d65e665e5 No issue: Removes deprecated usage of ViewModelProviders 5 years ago
Yeon Taek Jeong ec4d62c895 Fix ktlint 5 years ago
Yeon Taek Jeong 00bd26abe3 Remove task flags 5 years ago
Yeon Taek Jeong f952234c57 Keep CLEAR_TASK 5 years ago
Yeon Taek Jeong c87468d031 Remove popBackStack 5 years ago
Yeon Taek Jeong a8526a0606 For #4438: Fix crash when opening any URL from URL bar w/ long press 5 years ago
Sawyer Blatz 969d17b4a9
For #969: Adds more telemetry for collections (#4539) 5 years ago
Sawyer Blatz da06b0fb15
For #4508: Treats warnings as errors (#4543) 5 years ago
Grisha Kruglov f23f3b7489 Closes #4467: Use a-c version of FirefoxAccountsAuthFeature 5 years ago
ValentinTimisica 59c60ef189 Fixes #4354: Updated SearchFragment state after returning from SearchEngineFragment.
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
5 years ago
Colin Lee a514cb3f8c No issue: Add OSS licenses link to About page 5 years ago
Sawyer Blatz f9288c7fbd
For #969: Finalizes collections telemetry (#4592) 5 years ago
Emily Kager 8194e0778e For #4026 - Update BookmarkDiffUtil to update on Title or URL change 5 years ago
Emily Kager 0604e9858d Closes #3939 - Adds strings for delete browsing history 5 years ago
ValentinTimisica 71aedc79fe Fixes #3922: Added accessibility announcement for history empty state.
Sent an announcement when the list becomes empty in order to tell the user
that there is no history.
5 years ago
Tiger Oakes 631b7ba7cb Issue #1000 - Split out common browser functions 5 years ago
Emily Kager 23bc8f4320 Fro #4563 - Update delete button alpha when history mode changes 5 years ago
Tiger Oakes 3c1ce90f6f Fixes #2379 - Generic library selection 5 years ago
Yeon Taek Jeong 6f962d3376
For #1744: Open search shortcuts when entering search mode (#4536) 5 years ago
Emily Kager 6f7ae227a8 Closes #4540 - Set correct tint for select bookmark folder icon (#4541) 5 years ago
ekager 5edc9d0b4e For #2021 - Update custom preferences' views with email/account changes 5 years ago
Travis Long 51218bc93e Integrate service-experiments component (#4098) 5 years ago
Emily Kager a526e0fad3 For #4455 - Rename history headers by hours and days (#4478) 5 years ago
Nikit Bhandari 8aecc2b850 For #4530 Reduce build warnings (#4531) 5 years ago
ekager d0071d0177 For #4495 - Clean up homescreen toolbar focus and content descriptions 5 years ago
Sören Hentzschel bfd4849064 For #1427 - enter multi select mode with single click on favicon in library 5 years ago
Nikit Bhandari 671727c3e8 For #4341 use camelCase for views referenced from code 5 years ago
Nikit Bhandari 1cb9f88787 For #4199 make checkbox disabled when there is no data (#4200)
* For #4199 make checkbox unclickable when there is no data
5 years ago
Tiger Oakes 1e4399ee38 Use auto pause with BrowserFragment observers 5 years ago
Tiger Oakes cbd811dcfb Closes #1657 - Use Gecko for downloads (#4296) 5 years ago
Tiger Oakes 6e2ea0750e Issue #2379 - Use LibrarySiteItemView in history 5 years ago
mihai-adrian bac2e40eb2 fixes #4435 - changed title of menuitem for delete and added content description
setting menu title should also set content description. I added the setContentDescription programmatically in order to ensure that the content description is being set. If content description matches title it won't be read twice
5 years ago
ekager 015922ddd2 No issue: Fix Crash lower API by setting gradient drawables in onBind 5 years ago
Yeon Taek Jeong 83ceec6289 For #201: Search Widget 5 years ago
Jonathan Almeida ec96d134ff No issue: Fix breaking AccountObserver API 5 years ago
Sawyer Blatz 29f089c414 For #2203: Polishes BrowserToolbarMenu 5 years ago
Colin Lee 33e881ca8a For #1539: Only allow delete when folders multi-selected (#4062) 5 years ago
ValentinTimisica da59e36c1b Fixes #4410: Modified visibility of 'Add Tab' button.
I changed the visibility of 'Add Tab' button according to the number of
opened tabs. If there is at least one tab open, the button is displayed.
5 years ago
Grisha Kruglov ae33234bbc Closes #2593: FxA automatic sign-in integration 5 years ago
Grisha Kruglov 210864186b Reflect current sync status when opening account settings 5 years ago
Tiger Oakes c342a680d8 Fix crash for bookmarks 5 years ago
Emily Kager d42e72fd8b Closes #4462 - Adjust layout params of select bookmark folder view 5 years ago
Thom Chiovoloni a1adb2e57f Update fenix for new megazord setup 5 years ago
Tiger Oakes ccae66c08a Issue #2379 - Use LibraryPageView in history 5 years ago
Jeff Boek 2813a3cff7 For #4441 - Keeps the ID 0 based for the recyclerview 5 years ago
Christian Sadilek 9887945296 For #4412: Only consume state change when UI initialized 5 years ago
Christian Sadilek b646e87d9e No issue: Add engine warmup call 5 years ago
Jeff Boek e4700f76c6 For #3886 - Uses `defaultDeviceName` for the `DeviceConfig` device name 5 years ago
Jeff Boek a75c2f7cfb No Issue - Fixes the offset key to prevent endless history bug 5 years ago
Sawyer Blatz 97f7d5ba87 For #2267: Fixes telemetry for reader view (#4328) 5 years ago
Sawyer Blatz 2e7a61860a For #969: Adds more telemetry for collections (#4358) 5 years ago
Jonathan Almeida 4922e5d09d No issue: Move PublicSuffixList to root component
With the PublicSuffixList class in Utilities, the first instantiation
of it (prefetching in onCreate), causes the Utilities to instantiate
and thus slowing down startup by needing the SearchEngineManager from
instantiating as well.

Moving this back to the root component fixes the immediate perf issue.

Co-authored-by: Will Hawkins <whh8b@obs.cr>
5 years ago
Christian Sadilek 59c0005979 For #4412: SiteSecurityClickedListener set incorrectly 5 years ago
Will Hawkins ed31d990a4 No Issue: Move notification manager to member of background services
Instead of taking notification manager as a parameter
(from the utils class), create one private to the
BackgroundServices class. This means that we do not need
to create the entirety of utilities just to use
the notification manager.
5 years ago
Jeff Boek af449c84d5 For #4137 - Fixes HistoryInteractorTest 5 years ago
ekager 4494e40dbc For #4137 - Adds pagination to the history view 5 years ago
Emily Kager 0773069dad For #3829 - Ignore Intents Launched From History 5 years ago
Nikit Bhandari 46de06d132 For #4339 reduce build warnings (#4340) 5 years ago
Emily Kager 95208c84a9 Closes #4265 - Do not pop after all exceptions are removed (#4392) 5 years ago
Christian Sadilek 76ed07bd5d Closes #4412: BrowserInteractor has not been initialized (#4414) 5 years ago
Afzal Najam 8946bf20c4 Closes #3341 - Remove UserAgentRewriter 5 years ago
Emily Kager ec0bd85f6d For #4198 - Include Intent.ACTION_SEND to open to browser 5 years ago
Jonathan Almeida 026dcb01f5 No issue: Enable Send Tab and Push in production 5 years ago
Jonathan Almeida 90b1e5c262 Closes #4355: unsubscribe FxA subscription on logout 5 years ago
mihai-adrian 458632f4bf fixes #4237 - Cannot edit the default name of a collection, only replace it
changed setting of text to be done before transition, preventing transition to make textView unclickable;
 added renaming situation to showKeyboard in onResume();
 changed title text when renaming, from: "Name collection" to "Rename collection".
5 years ago
mihai-adrian ef3c813aee fixes #4237 - Cannot edit the default name of a collection, only replace it
changed setting of text to be done before transition, preventing transition to make textView unclickable;
 added renaming situation to showKeyboard in onResume();
 changed title text when renaming, from: "Name collection" to "Rename collection".
5 years ago
mihai-adrian 2e300fc8cf fixes #4237 - Cannot edit the default name of a collection, only replace it
made name_collection_edittext field clickable
5 years ago
Sawyer Blatz 385dfd2f15
For #4376: Removes usage of selectedSessionOrThrow (#4381) 5 years ago
ekager 0703fdc91f Closes #4240 - Exclude custom tabs from displayed tab count 5 years ago
bloslo 8ff77b90f3 For #3886 - Change default device name to show the app name. (#3916)
* Fix default device name to show the app name.

* Add string resource with placeholders.

* Wrap line that triggers MaxLineLength lint issue.
5 years ago
Tiger Oakes d1651ecf71 Closes #4012 - Animate quick settings (#4047) 5 years ago
Tiger Oakes 2467588c4a Create shared custom view for library items 5 years ago
Mugurell bf44c50dfd Fix #4372 - Set SitePermissionsDetailsExceptionsFragment toolbar title in onResume
The flow we are currently using involves setting a new title for the containing
Activity when the user navigates to a new Fragment.
This happened for SitePermissionsDetailsExceptionsFragment in it's onCreate().
Opening a permission (SitePermissionsManageExceptionsPhoneFeatureFragment) will
set a new title in it's onCreate() but going back from this new Fragment will
not create again a new SitePermissionsDetailsExceptionsFragment.
As a workaround I moved the call to set Activity's title in onResume().
5 years ago
Nikit Bhandari 5e52fc46b8 For #3443 - convert textPercentageSeekBar to Kotlin (#4081)
* convert textPercentageSeekBar to Kotlin

* fix test

* fix test again

* fix test again

* conflicts resolved

* merge multiple kdocs into one
5 years ago
Colin Lee 9bc0122ce3
For #4359: findBookmarkedUrl blocks the main thread (#4362) 5 years ago
Amaan Marfatia 4c13f45e9e Fixes #4192: Private keyboard in private browsing (#4345)
Sets compliant keyboards to private mode when in private browsing.
5 years ago
James Hugman ac359f6970 Closes #1331 - Filter consecutive history items using simplified URL 5 years ago
Sawyer Blatz 6fa022c2f8
For #4124: Migrate BrowserToolbar to Libstate (#4279)
* For #4124: Migrate BrowserToolbar to Libstate

* Restores QuickActionSheetReducer

* Improve tests

* Make QuickActionSheetController

* Finalize tests

* Breaks out QuickActionSheetState

* Fix comments

* Adds BrowserStoreTest
5 years ago
Tiger Oakes 87d8f3b037 Remove redundant super calls 5 years ago
Tiger Oakes 88c05a5f43 Use glide-like image loading function 5 years ago
Andrey Mukamolov ccfaa3826b For #2142: Added accessibility focus 5 years ago
Andrey Mukamolov d5eeadda66 Closes #2142: Enable private browsing button is focused instead of Search or address 5 years ago
Tiger Oakes c2e6e25bef Fixes #4005 - Move getColorFromAttr to Context 5 years ago
Jonathan Almeida c8148e61d5 No issue: Reset push subscriptions 5 years ago
Colin Lee 48aeb19db1
For #3695: Make SessionSuggestionProvider link to existing tab (#4280) 5 years ago
Christian Sadilek 1846a61475 For #4096: Use new A-C API to observe store / state changes
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
5 years ago
Colin Lee 3dc20543e3
For #4128: Migrate Bookmarks to LibState (#4254) 5 years ago
ValentinTimisica 4747f2c165 Fixes #4161: Modified style of bookmark_folders_sign_in button. (#4291)
To make this match the style of the other button I applied the same style to it
and also changed it to be a MaterialButton.
I also decided to extract the margin and padding values of the button.
5 years ago
chiragmantri 9bbd14a542 removed unused import. 5 years ago
chiragmantri 945b1ee274 [#4089] Moved PublicSuffixList to a sub-component(Utilities) class. 5 years ago
Jonathan Almeida 1026a92f32 Update to use Mozilla Android Components 6.0.0 5 years ago
Jonathan Almeida 2531e9dd62 No issue: Use correct server host and force subscribe for push 5 years ago
Sawyer Blatz 28eb5c541a
For #1944 & #1750: Updates private & night mode colors (#4232) 5 years ago
Tiger Oakes 3c99c8540f Switch to new intent processors 5 years ago
Emily Kager be10d427e8 For #4127 - Converts Exceptions to LibState and adds tests 5 years ago
Emily Kager 9b5baa2358 For #3360 - Adds empty state for TP Exceptions 5 years ago
Sawyer Blatz 7588251f8b
Closes #3986 & Closes #3661: Migrate QuickActionSheet to LibState & add tests (#4058)
* Closes #3986: Migrate QuickActionSheet to LibState

* Closes #3661: Add tests for QuickActionSheet

Co-authored-by: boek <jeff@jeffboek.com>

* For #3986: Fix feedback
5 years ago
Nikit Bhandari 9d9685625a For #4201 fix app crash on renaming a collection (#4202)
* For #4201 fix app crash on renaming a collection

* update
5 years ago
Jonathan Almeida 5ecdce6ba6 Closes #4171: Do not pause deviceEventObserver on lifecycle events 5 years ago
Nikit Bhandari f110ba2861 use synthetic binding instead of findviewbyid 5 years ago
Jeff Boek 5630904f93
For#3278 - Updates strings in preferences (#4184) 5 years ago
Mihai Adrian c74cb61455 fixes #4176 (#4175)
adds content description to 'browse privately' card, replacing placeholder %s with the header_text of card
5 years ago
Emily Kager fc2bff0fde For #4145 - Remove anchor view from fullscreen snackbar (#4160) 5 years ago
Emily Kager 9f40c25c75 For #4143 - Allow user to rotate to other landscape orientation 5 years ago
Jonathan Almeida d298b5f2f5 Closes #4075: Add Feature Flag class (#4077) 5 years ago
Sawyer Blatz e25ceafd1f No issue: Removes unnecessary fragment transitions from accounts
Co-authored-by: ekager <emilykager@gmail.com>
5 years ago
Sawyer Blatz 13198f56df For #969: Adds telemetry for collections (#3935) 5 years ago
Sawyer Blatz e544827e83 For #2267: Adds telemetry for reader mode (#3941) 5 years ago
Tiger Oakes edb0a3ed08 For #3633 - Update StoreProvider to use a callback
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
5 years ago
Jeff Boek e294521c92
Fix search metrics (#4150)
* For #4082 - Changes lifecycles for metrics

* For #4082 - Replaces the SearchEngine name with the identifier for
countLabel
5 years ago
Sawyer Blatz 9251597e84 For #2362: Fixes telemetry for history (#4156) 5 years ago
Tiger Oakes 981b6b5b02 For #4124 - Remove browser toolbar editing code 5 years ago
James Hugman 62850430b7 Closes AC#3695 - Add UI to open current page in external app 5 years ago
Tiger Oakes 6da6ddb095 Use StateListDrawable & resources w/ TabCollection 5 years ago
Emily Kager 451093fd9e Closes #2560 - Updates Private Browsing explanation string 5 years ago
Emily Kager ae3d187909 For #3987 - Convert History to Lib-State and add tests 5 years ago
Emily Kager 9ab67557cf For #4078 - Request landscape mode when entering fullscreen 5 years ago
Christian Sadilek c04dcec03f Closes #4096: IllegalStateException in SearchFragment (#4131) 5 years ago
James Hugman 90dd0ab469 Closes #4114 - Re-enable app-links 5 years ago
Emily Kager 95367c2b50 For #3521 - Show Quick Settings Dialog Entirely in Landscape 5 years ago
Emily Kager 8381025ac5 For #2160 - Hide Keyboard in onPause from EditBookmarkFragment 5 years ago
Emily Kager 68dae52fd1 Closes #3332 - Do not alter text of hosts of tabs in collection 5 years ago
Sawyer Blatz 11d36b5a00
For #2362: Adds telemetry for history (#3940) 5 years ago
Colin Lee 8855af2234
For #3615: Long pressing the address bar should not copy link (#4083) 5 years ago
Emily Kager 6b4c160d18 Closes #4080 - Trim New Bookmark Folder Title Text 5 years ago
Tiger Oakes 52d4c43916 Merge some library UIView code for toolbar 5 years ago
Tiger Oakes 447123367a Remove unused sessions resources 5 years ago
Emily Kager 13b7e64c9b For #3134 - Add confirmation dialog to sign out of FxA (#3959) 5 years ago
Jeff Boek ec099a6e11
For #3633 - Creates generic store provider (#4060) 5 years ago
Tiger Oakes 7747d5c240 Use tools:text to avoid inflating strings twice (#3619) 5 years ago
Jonathan Almeida fd7ff58ab8 No issue: Add comments on the push flag state 5 years ago
ekager 706f7d5961 For #3554 - Add DiffUtil to HistoryAdapter 5 years ago
Jonathan Almeida cf9ae87d50 For #3015: Add push support for send tab 5 years ago
Sebastian Kaspari 9b1e63224c Closes #4052: Remove pending intent workaround. (#4059)
Previously we needed to set a static launch function to be invoked when the find in page
integration should be launched. Now we can access the integration class directly and
can avoid the static property that caused issues when used by multiple activities.
5 years ago
Christian Sadilek e91a2e61a2 For #3633: Add unit tests for SearchStore 5 years ago
Sebastian Kaspari f8ef0225e1 Use updated feature-tab-collections API. (#4056) 5 years ago
Christian Sadilek b91895a81c Closes #1350: Use GeckoView fetch client for service-fretboard / kinto 5 years ago
Tiger Oakes 5de1678e65 No issue: Use putCompoundDrawables helper (#3982) 5 years ago
Sebastian Kaspari e4e0d45c1b Closes #3996: Remove workaround for opening custom tab in browser.
`EngineView` now allows releasing the `Session` so that it can be rendered by an
other `EngineView` instance.
5 years ago
Jeff Boek e4ff70c542
For #3633 - Refactors the search screen to use lib-state
* For #3633 - Adds SearchStore

* For #3633 - Refactors AwesomeBarUIView

* For #3633 - Refactors ToolbarUIView to use lib-state

* For #3633 - Fixes a couple of state bugs

* For #3633 - Moves all user interaction to SearchInteractor

* For #3633 - Adds kdocs to SearchStore and SearchInteractor

* For #3633 - Adds documentation for the properties on SearchState
Also removes uneccessary property

* For #3633 - Creates `StateViewModel` to handle state restoration

* For #3633 - Adds a test for onTextChanged

* For #3633 - Adds tests for SearchInteractor

* For #3633 - Fixes bugs and adds documentation
5 years ago
Emily Kager 867067537a For #3568 - Use correct styling for QR and Share Alert Dialogs 5 years ago
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 5 years ago
Colin Lee 2feddc9bd6
No issue: Enable Strict Mode in Debug Builds (#4014) 5 years ago
Emily Kager 1f108f3c88 For #3806 - Adds corner radius to QAB and dialogs 5 years ago
Grisha Kruglov fe51bbcf7b Update FxA integration to new APIs 5 years ago
Emily Kager c81dd0a4a8 For #3772 - Update FXA sign in UI (#3933) 5 years ago
Emily Kager 9e7282cf18 For #1949 - Fixes bookmark separator appearance, removes menu (#3957) 5 years ago
Emily Kager 21c75ca1bb For #3478 - Add Tab sent snackbar confirmation for device sharing 5 years ago
ekager c6c9818751 For #3240 - Create AuthCustomTabActivity to fix dead end on auth 5 years ago
Colin Lee 5a204f0bbc
For #3818: Handle crashes accessing view after onDestroyView (#3942) 5 years ago
Sawyer Blatz 83312b38aa
For #3175: Correctly grabs focus in search fragment (#3938) 5 years ago
Tiger Oakes 9901514766 Replace deprecated pxToDp (#3932) 5 years ago
Colin Lee 15d887e41f
For #2251 - Add bookmark adapter diffutil (#3936)
* For #2251 - Add bookmark adapter diffutil

* For #2251 - Fix unit tests for bookmark adapter diffutil
5 years ago
afr30010 c92eabdd64 Modify the order of Privacy Policy and About in Settings (#2760) 5 years ago
Emily Kager d168d52516 For #3772 - Remove Create an Account Option on TurnOnSyncFragment (#3928) 5 years ago
ekager 003837eb4f Closes #3879 - Remove attributeSetId from AccountPreference 5 years ago
ekager 57ca75139b For #3201 - Update bookmark state when session selected 5 years ago
Emily Kager f60536b13c For #3829 - Add pop up to nav_graph to browser to home nav 5 years ago
Colin Lee 6bb67a9de7
For #3364: Set bookmark root titles onResume (#3828) 5 years ago
Jeff Boek 20993462e9 For #3869 - Creates a SearchLocalizationProvider that sets the region to get the correct default search engine based on a locale 5 years ago
Yeon Taek Jeong 29402a297e For #3317: Prepopulate FxA device name field with existing name (#3733) 5 years ago
Emily Kager 7a51ee3915 For #3734 - Don't SwipeToDelete RecyclerView without windowfocus (#3839) 5 years ago
Emily Kager 99209aa9da Closes #3268 - Change Tab Favicon Border Radius to 4 (#3856) 5 years ago
Emily Kager ce2d597af3 For #203 - Adds find in page and request desktop site to custom tab menu (#3835) 5 years ago
Colin Lee eedb0fa3b2
For #2945: Launches to blank screen and hangs on Nexus 10 (#3854) 5 years ago
Mitchell Hentges aebcc92080
Re-enables pushing nightly to org.mozilla.fenix (#3823)
* Re-enables pushing nightly to org.mozilla.fenix

* Publishes org.mozilla.fenix.nightly releases on internal track
5 years ago
Sawyer Blatz dbe29ebbda
For #3174: Adds telemetry for bookmarks (#3724) 5 years ago
Sawyer Blatz ece0e30655
For #2054: Collapses quick action bar when opening find in page (#3837) 5 years ago
Emily Kager bed926c317 For #3834 - Initialize job in init 5 years ago
Colin Lee 50052c9b9b
For #3551: Tapping a bookmark/history from Library should open new tab (#3832) 5 years ago
Colin Lee 161e7b3b57
No issue: Fix master builds (#3825) 5 years ago
Tiger Oakes 8cd1a0cb38 Move adapter Job setup code to helper class (#3407) 5 years ago
Sören Hentzschel eb1ea882cf For #2425 - QAB showed wrong text for bookmarked pages (#3794)
* For #2425 - QAB showed wrong text for bookmarked pages

* fixed linting issue
5 years ago
Sawyer Blatz 7e46e71d00 For #3005: Closes tabs when saving to collection (#3723) 5 years ago
Weverson Nascimento 887102d215 For #3645: Fix search engine selection (#3665)
* Remove RadioButton drawable applied in runtime

* Add default RadioButton layout
5 years ago
Emily Kager 654c2b12df No issue: Remove attributeSetId from DefaultBrowserPreference (#3712) 5 years ago
Colin Lee 7473126f7c
For #3784: Crash loading bookmarks while detached (#3787) 5 years ago
Colin Lee 386a3f3acc
For #3785: Crash onDestroy of BookmarkFragment when detached (#3786) 5 years ago
Tiger Oakes d42052079a No issue: Remove duplicate wordmark and update about page (#3590) 5 years ago
Yeon Taek Jeong 219b5f3d01 For #3381: Fix 'Remove account' returning app to home screen (#3778)
* For #3381: Fix 'Remove account' returning app to home screen

* Remove unused import

* Move popBackStack() outside lifecycleScope instead
5 years ago
Arturo Mejia b82340bf1f For #3750: Crash when tapping "Blocked" on Google Maps after disabling
location requests.
5 years ago
ekager 7fa4cf4487 Use sessionId in FIP Integration, use pendingIntent for startActivity 5 years ago
ekager 6d0a4fdb4d Revert "For #3609 - Remove FIP Integration, Use FIP Feature"
This reverts commit 428643d598e938f58a2fe4abfee417c46edec167.
5 years ago
Emily Kager 2d6ebb986d Revert "For #3135 - Reduce swipe to delete sensitivity"
This reverts commit 94881f8241.
5 years ago
Colin Lee f375eac6bd
For #3732: Race Condition Crash in HomeFragment onPreDraw (#3737) 5 years ago
Emily Kager 9142e2279c For #1968 - Adds menu option to add new folder in BookmarkFragment menu 5 years ago
Tiger Oakes 606e66219c No issue: Use chains for bookmark items (#3696)
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
5 years ago
Emily Kager c9962a7ad0 Closes #3701 - When deleted use bookmark title if url is null in snackbar (#3716) 5 years ago
Sawyer Blatz 13df8d7ddd
For #3711: Fixes save to collection from browser crash (#3714) 5 years ago
Sawyer Blatz 66eb4fd03b No issue: Fixes master compilation 5 years ago
Colin Lee 7481d52c4b
For #3505: Opening a sent tab crashes Fenix (#3507) 5 years ago
Nikit Bhandari 6ccd32f093 For #3496: dismiss share fragment when clicking outside content (#3513)
* dismiss share fragment when clicking outside content

* add logic in view layer
5 years ago
Emily Kager 77edb7afe1 For #2960 Closes #3671 - Fixes bookmark deletion with undo, wraps list 5 years ago
ekager 61a8795576 For #1211 - Hide keyboard on fling suggestions list 5 years ago
Tiger Oakes e8bd090a8e No issue: Use ImageView rather than rebuilding drawable (#3616)
HomeFragment's onboarding items included drawableStart values, but also
built drawables in the view holders to replace them. Instead, we should
just use ImageViews so that work isn't duplicated.
5 years ago
Tiger Oakes 4994554576 No issue: Adds lint exception for when statement (#3685) 5 years ago
Sawyer Blatz 309014139d For #3488: Cleans up edit mode calls (#3689) 5 years ago
Yeon Taek Jeong 2cafd5bba6 For #3678: Fix crash when tapping on your account (#3688) 5 years ago
Emily Kager 427bc5c1e6 Revert "For #1211 - Hide keyboard on fling suggestions list"
This reverts commit cb6fd83c9879c268cb739fb768187d5276c5af66.
5 years ago
Tiger Oakes a78d36354a Switch RadioButtonPreference to ConstraintLayout
Also ensure that RTL works properly.
5 years ago
Sawyer Blatz d28168ac64 For #2940: Hides send tab header on FxA error 5 years ago
Tiger Oakes 30930cdc88 Import variables referred to by path 5 years ago
Tiger Oakes 55f5c5d049 Use lifecycleScope for settings fragments 5 years ago
Tiger Oakes d01bb8c442 Use lifecycleScope for collections fragments 5 years ago
Tiger Oakes 6bf8d6be34 Use @JvmOverloads instead of multiple constructors 5 years ago
Colin Lee 94e99cf877
For #3364: Edit bookmarks should show corrected bookmarks tree (#3446) 5 years ago
Emily Kager 74111c75de For #3639 - Remove fontInflationEnabled (#3640) 5 years ago
Emily Kager ddebc98718 No issue: Follow up on optional filter style 5 years ago
Colin Lee ea7841b8c5 No issue: Add Sentry breadcrumbs to ease crash investigations 5 years ago
Denys M 6d6b240e48 Add unit tests for `Settings`.
Add unit tests for `Settings`.
5 years ago
Emily Kager 718ac5612c For #3593 For #3581 - Pass sessions to delete to delete all with undo (#3594) 5 years ago
Emily Kager 084fab77d4 For #3609 - Remove FIP Integration, Use FIP Feature (#3637) 5 years ago
Emily Kager 6e3197f61c For #3622 - Add ID to engine shortcut suggestions (#3636) 5 years ago
royang51 e244aae104 For #3214 - History multi-selection aborted, the same item can't be selected again (#3607) 5 years ago
Sawyer Blatz 07516f47c3
For #3215: Adds collection restoration with unique IDs (#3635) 5 years ago
vmbaicu 021900e7ad Fixes #3527 - Set Collection name max length (#3531) 5 years ago
Nikit Bhandari cfefc5632b For #3489: Disables blank collection names (#3490) 5 years ago
Andrei Teslovan 2ebe0a2a48 Fixes #3529 - Display "Edit folder" title when editing a bookmark folder (#3549) 5 years ago
Emily Kager 03a5cb2fb4 For #3620 - Adds automatic theme onboarding content description (#3629) 5 years ago
Sawyer Blatz a5a518f4a5
For #2940: Hides send tab on FxA error (#3595) 5 years ago
Sawyer Blatz 721908ade6
For #3055: Adds android components version to about page (#3596) 5 years ago
Colin Lee 22bcd70edc
For #3213: Fix multi-select bookmarks on return to fragment (#3413) 5 years ago
Emily Kager afb59251c1 For #3588 - Preload the content process when starting Gecko (#3589) 5 years ago
Emily Kager b1102c2e76 For #3544 - Set SearchSuggestions preference value from settings 5 years ago
Tiger Oakes ab6101b0f4 Fixes #3539 - vectordrawablecompat for gradients (#3541) 5 years ago
Tiger Oakes b70dced16e Fixes #3538 - Fix ic_tabs icon path (#3540) 5 years ago
Colin Lee 0135424883 For #3508: "Send crash report" checkbox is ignored (#3512) 5 years ago
Grisha Kruglov 521312c6f8 Disable send tab for non-nightly, non-debug builds (#3542)
* Put deviceCapabilities list behind a SEND_TAB_ENABLED flag

* Disable SEND_TAB for non-debug, non-nightly builds
5 years ago