2
0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-03 23:15:31 +00:00

Fix #4856 - Propagate LifecycleAwareFeature's onStart() to the inner feature

FindInPageFeature is used inside the app as a LifecycleAwareFeature and as such
it receives the onStart / onStop lifecycle calls.
The onStart() lifecycle call would not get passed to the feature but in
onStop() FindInPageFeature will detach it's Presenter and Interactor so when
the user comes back to the screen she could not interact anymore with the
feature.
To fix this we'll propagate LifecycleAwareFeature's onStart() to the inner
feature which is to rebind it's Presenter and Interactor in onStart().

This behavior is common to all the other features so all of them who implement
LifecycleAwareFeature will now get the onStart() call also.
This commit is contained in:
Petru Lingurar 2019-09-03 10:56:05 +03:00 committed by Jonathan Almeida
parent ed0b6bd5ef
commit 716cf3995a

View File

@ -49,7 +49,7 @@ abstract class InflationAwareFeature(
* when the view is inflated.
*/
override fun start() {
// We don't do anything because we only want to start the feature when it's being used.
feature?.start()
}
override fun stop() {