Mozilla L10n Automation Bot
396c51d569
Import l10n.
3 years ago
Mozilla L10n Automation Bot
708b78d3a0
Import l10n.
3 years ago
AndiAJ
378ac03e30
Improve privateTabsTrayWithOpenedTabTest UI test coverage
3 years ago
AndiAJ
ec31faef7a
Improve verifyOpenTabDetails UI test coverage
3 years ago
AndiAJ
4261ca7ea6
Refactor and improve coverage for empty tabs tray UI tests
3 years ago
Mozilla L10n Automation Bot
f0a3653d7b
Import l10n.
3 years ago
Grisha Kruglov
63154a18f9
Closes #22484 - Track direct loads per tab; fix search term lookup
...
This patch fixes two problems:
1) We were treating "direct tab load" as an event which applies
uniformally to all tabs, even though it's actually an event which
happens for a specific tab. This lead to background tabs (pages opened as new tab)
setting the direct load flag, and then a simultaneously loading
parent tab would incorrectly interpret that flag for itself.
The patch switches this tracking from a simple boolean (are we direct
loading?) to a set of tab IDs that are currently direct loading.
2) In a case when a background tab was loading with a parent who's
search terms were cleared by a direct load, we were not trying to
lookup search terms on the background tab's historyMetadata key,
which exists to capture search terms for this exact scenario.
The patch adds an additional fallback lookup for that path.
3 years ago
Oana Horvath
4892f0ddbe
For #21002 : add missing steps to selectSearchEnginesShortcutTest, addPredefinedSearchEngineTest
3 years ago
Grisha Kruglov
77672dfa15
Post: move group removal logic into PagedHistoryProvider
...
This moves the group removal logic to the place where the groups are
actually formed. This helps clean-up the fragment code a bit, and
removes the awkward 'allow mutate some random internal state' API from
the provider.
3 years ago
Grisha Kruglov
45d4807bfe
Closes #22472 : Filter out redirects from History search groups
3 years ago
AndiAJ
2c9efac286
Improve mainMenuAddToHomeScreenTest UI test coverage
3 years ago
AndiAJ
e265da0cb4
startOnLastTab UI smoke test
3 years ago
AndiAJ
4ff64ad7ca
recentBookmarksOption UI smoke test
3 years ago
AndiAJ
eee83c9cbd
jumpBackInOption UI smoke test
3 years ago
AndiAJ
7460461e16
startOnHomepageTest refactoring work
3 years ago
Mozilla L10n Automation Bot
364fecf9d4
Import l10n.
3 years ago
Christian Sadilek
8c88561d4b
Update lastAccess timestamp of selected tab when launching to home
3 years ago
Roger Yang
24e4452cb5
Close #22402 : Add top placeholder for home
3 years ago
Noah Bond
dde916038d
MR2 Telemetry: Homescreen view count ( #22377 )
...
* For #22146 - Added counter for home screen views
* For #22146 - Added PR number to metrics
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Mugurell
d4a6facd81
For #22155 - Store inactive tabs count telemetry when user opens tabs tray
...
Setting this value in FenixApplication.onCreate was buggy because of a race
with restoring BrowserState.
Setting it here would ensure a better granularity of the events and so to more
accurate reporting.
3 years ago
Mugurell
17865bdf66
For #22147 - New search term groups telemetry
3 years ago
AndiAJ
f91285881d
Improve homeThreeDotMenuItemsTest UI test coverage
3 years ago
Mozilla L10n Automation Bot
f466d65256
Import l10n.
3 years ago
Arturo Mejia
94a543a403
For #22271 Improve URL accessing from the clipboard for Android 12 and above.
3 years ago
Mugurell
c42ccb4966
For #22388 - Update content description of the delete button
3 years ago
Mozilla L10n Automation Bot
abcafa55f0
Import l10n.
3 years ago
Mozilla L10n Automation Bot
d29fd55c8b
Import l10n.
3 years ago
Oana Horvath
ba91180e85
No issue: creates new SmokeTest annotation.
...
Updates smoke tests list according to the ones in TestRail.
3 years ago
Mozilla L10n Automation Bot
b0ad98a204
Import l10n.
3 years ago
Noah Bond
811f255b71
MR2 Telemetry: Opening screen preference ( #22333 )
...
* For #22145 - Added telemetry to the opening screen preference.
* For #22145 - Added PR number to metric
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Noah Bond
2e5555d034
MR2 telemetry - Inactive tabs CFR ( #22301 )
...
* For #22298 - Added telemetry to inactive tabs CFR
* For #22298 - added PR issue number to metrics
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Jonathan Almeida
e3b6e00331
Close #22223 : Move to the selected page when switching modes
3 years ago
Mozilla L10n Automation Bot
210587b735
Import l10n.
3 years ago
Grisha Kruglov
9a4a4713ac
No issue: clean up code duplication in PagedHistoryProvider
3 years ago
AndiAJ
1ade096145
For #22256 re-enable editCustomSearchEngineTest UI test
3 years ago
Ben Dean-Kawamura
df953b0021
Make findDuplicate() suspend
...
findLoginToUpdate() should be suspend, but I didn't get mark it that way
on the initial logins work. Let's make this one suspend, then I can
update findLoginToUpdate() in a-c.
3 years ago
Mozilla L10n Automation Bot
e52000bb20
Import l10n.
3 years ago
Jonathan Almeida
8ced675817
No issue: Correct TabsTrayAction naming
3 years ago
Jonathan Almeida
08b15689b1
Close #22305 : Use TabsTrayStore for populating adapters
3 years ago
Jonathan Almeida
f16300392d
Close #22305 : Add tab state into the TabsTrayStore
3 years ago
Michael Comella
c026d8b28a
For #21084 : put git hash on About screen in release builds.
3 years ago
AndiAJ
f4e7547190
Improve verifyEmptyTabTray Ui test coverage
3 years ago
Mugurell
953f6feb17
For #22155 - The inactiveTabsCount probe reports actualInactiveTabs number
3 years ago
Mugurell
f9b67091c6
For #22155 - New BrowserState.actualInactiveTabs public method
...
This allows querying from all throughout the app which of the current tabs are
inactive while taking into consideration whether the feature is enabled or not
such that when the feature is disabled it will always return an empty result.
3 years ago
Mozilla L10n Automation Bot
2089c29fea
Import l10n.
3 years ago
Grisha Kruglov
81b70122d4
No issue: rename test resource file that was causing issues on Windows
3 years ago
Mozilla L10n Automation Bot
8c2cdaa3ff
Import l10n.
3 years ago
Mozilla L10n Automation Bot
06f57fdcfe
Import l10n.
3 years ago
mike a
d69b5ed456
For #21816 : Filename in "Open" PDF dialog overflows screen
...
Changing the download file name length to the max allowed by AS (251 char, won’t compile if more; max would be 260 for latest windows versions, but generally it is 255), and changing the UI test to check if the long file name is fully visible.
Changing the downloaded dialog layout to properly display really long file names.
3 years ago
Grisha Kruglov
5b889fdb96
For #22342 : Make layout constraint for 'recent bookmarks' the same as other sections
3 years ago
Sebastian Kaspari
8c9f0c835a
Closes #21695 : ThreadPenaltyDeathWithIgnoresListener: Ignore stack traces containing InstrumentationHooks class
3 years ago
Mozilla L10n Automation Bot
7e66c02363
Import l10n.
3 years ago
Roger Yang
04618983aa
Close #22299 : Add history search term group telemetry
3 years ago
Grisha Kruglov
294997e559
No issue: history view search group missing
...
Our boundary conditions for matching search groups to visits was wrong.
This change switches the boundary buffer to only be applied to history
items, not the metadata items.
In other words, when checking if any of the metadata items match the
current "page" of history, we'll be looking to see if the item falls
within this time window:
buffer - oldest history item <= metadata item <= newest history item +
buffer
There's a separate problem with buffer though: it's reset to 0 when requested
offset is >0, but that requires a larger refactor of this code, for a
separate PR.
3 years ago
Oana Horvath
4d88c521ac
For #22304 & #22256 : Disabled failing visitedUrlHistoryTest & editCustomSearchEngineTest tests
3 years ago
Mozilla L10n Automation Bot
ed0389abe3
Import l10n.
3 years ago
Michael Comella
7d67b84a92
For #22177 : add SearchDialogFragmentConstraintLayout; has markers.
...
Here's a profile with these changes: https://share.firefox.dev/3vTpZha
3 years ago
Michael Comella
bc6d8be9c1
For #22177 : change onMeasure/onLayout markers into a single track + draw.
...
When you want to look at one of these markers, you usually want to look
at all three so I found that having them on a single track was easier to
follow. Since they run in sequence, they should never overlap and that
should minimize confusion.
3 years ago
Michael Comella
ed8f2c0bc3
For #22177 : rename RootLinearLayout -> HomeActivityRoot...
...
This is so we can be more specific with the detail text in our markers.
3 years ago
Elise Richards
4f55f16bd7
For #21313 : Remove expiring/unused metrics for December ( #21789 )
...
* Remove crash reporter metrics
* Remove tab counter menu item probe
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Christian Sadilek
76bb0c3b37
Closes #21659 : Add SERPs to history search groups
3 years ago
Noah Bond
8caefbe2d5
Recent bookmark count telemetry ( #22293 )
...
* For #22075 - Added event to track the count of recent bookmarks
* For #22075 - Added data review issue number
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Arturo Mejia
cff78afe27
For #22078 Selecting search group in Jump back in switches active tab
3 years ago
Matt Boris
1809bea49d
For #22281 Fix studies opt out learn more link
3 years ago
Gabriel Luong
6747e9d554
For #21973 - Remove @color/search_suggestion_indicator_icon_color_dark_theme redirection
3 years ago
Gabriel Luong
baa8c6582a
For #21973 - Remove @color/accent_dark_theme redirection
3 years ago
Gabriel Luong
6770a70bdd
For #21973 - Remove @color/foundation_dark_theme redirection
3 years ago
Gabriel Luong
f7f942f2d9
For #21973 - Remove @color/tab_tray_selected_mask_dark_theme redirection
3 years ago
Gabriel Luong
d6002f3307
For #21973 - Remove @color/tab_tray_item_thumbnail_icon_dark_theme redirection
3 years ago
Gabriel Luong
b7c3d0ec5a
For #21973 - Remove @color/tab_tray_item_thumbnail_background_dark_theme redirection
3 years ago
Gabriel Luong
e304885581
For #21973 - Remove @color/tab_tray_heading_icon_menu_dark_theme redirection
3 years ago
Gabriel Luong
8d9550a6a7
For #21973 - Remove @color/tab_tray_item_media_background_dark_them redirection
3 years ago
Gabriel Luong
2b996a607c
For #21973 - Remove @color/tab_tray_item_divider_dark_theme redirection
3 years ago
Gabriel Luong
19a947240b
For #21973 - Remove @color/tab_tray_toolbar_background_dark_theme redirection
3 years ago
Gabriel Luong
3fd6f4c420
For #21973 - Remove @color/tab_tray_item_background_dark_theme redirection
3 years ago
Gabriel Luong
ee59848064
For #21973 - Remove @color/tab_tray_item_url_dark_theme redirection
3 years ago
Gabriel Luong
498d8ccc19
For #21973 - Remove @color/tab_tray_item_text_dark_theme redirection
3 years ago
Michael Comella
0c079fde91
Closes #22213 : add marker for LayoutInflater.inflate.
...
Here is a profile with this change: https://share.firefox.dev/3mlQSHu
3 years ago
Arturo Mejia
5a11985d22
No issue: Address tracking protection exceptions breaking changes
3 years ago
AndiAJ
1066acbe1e
Improve deleteBookmarkInEditModeTest UI test coverage
3 years ago
Mozilla L10n Automation Bot
3f7cd1be8c
Import l10n.
3 years ago
Arturo Mejia
2061779938
For #22170 record auto-close prompt telemetry events
3 years ago
Roger Yang
930599407c
No issue: Show snackbar when opening non-http URL
3 years ago
Noah Bond
a06b04ec6d
MR2 Telemetry: Recent tabs section probe ( #22166 )
...
* For #22107 - Added probe to track if the Recent tabs / jump back in section is visible
* For #22107 - Fixed lint errors
* For #22107 - added data review number to metric
* For #22166 - fixed expiration date
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Gabriel Luong
9a53a12c57
For #21973 - Remove @color/onboarding_illustration_deselected_dark_theme redirection
3 years ago
Gabriel Luong
e586d27983
For #21973 - Remove @color/search_suggestion_indicator_icon_bookmark_color_dark_theme redirection
3 years ago
Gabriel Luong
5c32efa9a3
For #21973 - Remove @color/preference_section_header_dark_theme redirection
3 years ago
Gabriel Luong
0cb91151b1
For #21973 - Remove @color/prompt_login_edit_text_cursor_color_dark_theme redirection
3 years ago
Gabriel Luong
f436d3ef02
For #21973 - Remove @color/add_on_private_browsing_interior_icon_background_dark_theme redirection
3 years ago
Gabriel Luong
90fd1ea363
For #21973 - Remove @color/add_on_private_browsing_exterior_circle_background_dark_theme redirection
3 years ago
Gabriel Luong
830ade29f9
For #21973 - Remove @color/sync_disconnected_background_dark_theme redirection
3 years ago
Gabriel Luong
eb6de2b21c
For #21973 - Remove @color/sync_disconnected_icon_fill_dark_theme redirection
3 years ago
Gabriel Luong
c9afe46dd6
For #21973 - Remove @color/toolbar_[start|center|end]_gradient_dark_theme redirection
3 years ago
Gabriel Luong
6923a27be7
For #21973 - Remove @color/toolbar_divider_color_dark_theme redirection
3 years ago
Gabriel Luong
37058f596e
For #21973 - Remove @color/swipe_delete_background_dark_theme redirection
3 years ago
Gabriel Luong
3cf985d09c
For #21973 - Remove @color/onboarding_illustration_selected_dark_theme redirection
3 years ago
Gabriel Luong
d71447a691
For #21973 - Remove @color/onboarding_card_background_[start|end]_gradient_dark_theme redirection
3 years ago
Gabriel Luong
075f3a3dd9
For #21973 - Remove @color/disabled_dark_theme redirection
3 years ago
Gabriel Luong
25592dc25c
For #21973 - Remove @color/shadow_dark_theme redirection
3 years ago
Gabriel Luong
35a235c598
For #21973 - Remove @color/neutral_faded_dark_theme redirection
3 years ago
Gabriel Luong
2f4e0e14ba
For #21973 - Remove @color/neutral_dark_theme redirection
3 years ago
Gabriel Luong
b682f2d5c5
For #21973 - Remove @color/tab_ring_dark_theme redirection
3 years ago
Gabriel Luong
7019e32f40
For #21973 - Remove @color/scrimEnd_dark_theme redirection
3 years ago
Gabriel Luong
ee96021f19
For #21973 - Remove @color/scrimStart_dark_theme redirection
3 years ago
Gabriel Luong
d516eefb1d
For #21973 - Remove @color/recently_used_share_menu_dark_theme redirection
3 years ago
Gabriel Luong
ec259fbfd7
For #21973 - Remove @color/tab_history_item_selected_background_light_theme redirection
3 years ago
Gabriel Luong
dff26e0ce1
For #21973 - Remove @color/menu_item_button_light_theme redirection
3 years ago
Gabriel Luong
e50a2b3cb3
For #21973 - Remove @color/search_suggestion_indicator_icon_bookmark_color_light_theme redirection
3 years ago
Gabriel Luong
f5f96d8766
For #21973 - Remove @color/search_suggestion_indicator_icon_color_light_them redirection
3 years ago
Gabriel Luong
679d7e5161
For #21973 - Remove @color/prompt_login_edit_text_cursor_color_light_them redirection
3 years ago
Jonathan Almeida
9bb49585ea
No issue: Merge our inactive tab interactor/controllers
3 years ago
Jonathan Almeida
f363b145f2
No issue: Remove unused InactiveTabState code
3 years ago
Mugurell
207e85e59d
For #22155 - Inactive tabs count telemetry
...
A quantity probe in the metrics ping means we'll loose the granularity events
provided but it will be easier to extract the values.
For reporting whether the inactive tabs feature is enabled or not we already
have the "preferences.inactive_tabs_enabled" probe so I didn't duplicate this.
3 years ago
Roger Yang
a46905b5e7
Issue #22057 : Add search term groups telemetry
3 years ago
Christian Sadilek
687209fee8
Introduce test rule to work around intermittent mockk failures
3 years ago
AndiAJ
ff0befdd1d
Improve coverage for cancelCreateBookmarkFolderTest UI test
3 years ago
AndiAJ
979d8a79cd
For #18421 re-enable verifyContextOpenImageNewTab, verifyContextOpenLinkNewTab & verifyContextOpenLinkPrivateTab UI tests
3 years ago
Mugurell
018fe15072
For #22138 - Install source metrics probe
3 years ago
Mugurell
9cce30b824
For #22226 - Open grouped history entries the same as individual ones
3 years ago
Roger Yang
4e5c9a3440
Close #22172 : Add Recent searches telemetry
3 years ago
Roger Yang
9c970a5276
Close #22103 : Add recent bookmarks telemetry
3 years ago
Mozilla L10n Automation Bot
b698d6ac77
Import l10n.
3 years ago
Elise Richards
e4cc22fb71
For #22175 : Telemetry event for deleting a search term group from the recent searches section on home
3 years ago
Jonathan Almeida
8c43ccc0f6
Issue #20704 : Use AppStore for inactive expanded state
3 years ago
Jonathan Almeida
9cef9357b1
Close #20704 : Add AppStore to Components
3 years ago
Oana Horvath
cee72a965b
For #21397 : disabled homescreen features to improve collections visibility
3 years ago
Arturo Mejia
940af156eb
For #22192 add telemetry for studies
3 years ago
Mozilla L10n Automation Bot
f3bf56ac60
Import l10n.
3 years ago
Mozilla L10n Automation Bot
ef43107e67
Import l10n.
3 years ago
Mozilla L10n Automation Bot
57c375cea2
Import l10n.
3 years ago
Gabriel Luong
e3e0b9c207
For #21973 - Reduce redirection of colors variables between dark and light theme - Part 3 ( #22220 )
...
* For #21973 - Remove @color/disabled_light_theme redirection
* For #21973 - Remove @color/scrimStart_light_theme redirection
* For #21973 - Remove @color/scrimEnd_light_theme reddirection
* For #21973 - Remove @color/synced_tabs_separator_light_theme redirection
* For #21973 - Remove @color/toolbar_[start/center/end]_gradient_light_theme redirection
* For #21973 - Remove @color/toolbar_divider_color_light_theme redirection
* For #21973 - Remove @color/fill_link_from_clipboard_light_theme redirection
* For #21973 - Remove @color/sync_disconnected_icon_fill_light_theme redirection
* For #21973 - Remove @color/sync_disconnected_background_light_theme redirection
* For #21973 - Remove @color/swipe_delete_background_light_theme redirection
* For #21973 - Remove @color/onboarding_illustration_selected_light_theme redirection
* For #21973 - Remove @color/onboarding_illustration_deselected_light_theme redirection
* For #21973 - Remove @color/add_on_private_browsing_exterior_circle_background_light_theme redirection
* For #21973 - Remove @color/add_on_private_browsing_interior_icon_background_light_theme redirection
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Mozilla L10n Automation Bot
c2f0b574fd
Import l10n.
3 years ago
Oana Horvath
f6b83e37b1
For #15624 & #17484 : improves tab drawer locator & avoids homescreen refreshing
3 years ago
Gabriel Luong
a99b7d3f71
For #21973 - Remove @color/destructive_light_theme redirection
3 years ago
Gabriel Luong
1eb41ff558
For #21973 - Remove @color/shadow_light_theme redirection
3 years ago
Gabriel Luong
9331b971f8
For #21973 - Remove @color/neutral_faded_light_theme redirection
3 years ago
Gabriel Luong
58e9d3dd08
For #21973 - Remove @color/neutral_light_theme redirection
3 years ago
Gabriel Luong
7c9ae669aa
For #21973 - Remove @color/tab_ring_light_theme redirection
3 years ago
Gabriel Luong
00b4688fd5
For #21973 - Remove @color/accent_high_contrast_light_theme redirection
3 years ago
Gabriel Luong
cb92e48c0d
For #21973 - Remove @color/about_link_dark_theme redirection
3 years ago
Gabriel Luong
fe0affa167
For #21973 - Remove @color/above_light_theme redirection
3 years ago
Gabriel Luong
2336f9d9d6
For #21973 - Remove @color/caption_text_light_theme redirection
3 years ago
Gabriel Luong
b510a6d0ca
For #21973 - Remove @color/secondary_text_light_theme redirection
3 years ago
Christian Sadilek
3e6cd7d821
Closes #21355 : Fix intermittent test failures in BookmarkItemMenuTest
3 years ago
Christian Sadilek
75c70ff814
Closes #21952 : Ignore intermittently failing FenixSnackbarKtTest
3 years ago
Christian Sadilek
f4be38dafc
Closes #21438 : Ignore intermittently failing ExceptionsListItemViewHolderTest
3 years ago
Christian Sadilek
5d7bb70f55
Closes #22081 : Ignore intermittently failing DefaultBrowsingModeManagerTest
3 years ago
Christian Sadilek
99f0aaa834
Closes #21332 : Ignore intermittently failing WebPushEngineIntegrationTest
3 years ago
Christian Sadilek
3ffb11fd3b
Closes #21952 : Ignore intermittently failing FenixSnackbarDelegateTest
3 years ago
Gabriel Luong
09bd9e7ba2
For #21888 - Use Hero images for Jump back in
3 years ago
Arturo Mejia
d0d87a6d6d
No issue update strings ids
3 years ago
AndiAJ
71d151ef18
For #18421 re-enable verifyContextCopyLink and verifyContextCopyImageLocation UI tests
3 years ago
Gabriel Luong
8f85ef2d5b
For #21973 - Remove @color/top_site_title_text_light_theme redirection
3 years ago
Gabriel Luong
28883384a7
For #21973 - Remove @color/inset_dark_theme redirection
3 years ago
Gabriel Luong
9a85545da5
For #21973 - Remove @color/top_site_title_text_dark_theme redirection
3 years ago
Gabriel Luong
59f725d2fb
For #21973 - Remove @color/synced_tabs_separator_dark_theme redirection
3 years ago
Gabriel Luong
35c7ef6bb6
For #21973 - Remove @color/toggle_off_knob_light_theme and @color/toggle_off_track_light_theme redirection
3 years ago
Gabriel Luong
e2093f2054
For #21973 - Remove redirection of color variables for the collection color variables
3 years ago
Gabriel Luong
4001f4ee6f
For #21973 - Remove redirection of color variables for the tabs tray color variables
3 years ago
Gabriel Luong
1a472c3507
For #21973 - Remove @color/caption_text_dark_theme redirection
3 years ago
Gabriel Luong
78e90d5f0e
For #21973 - Remove @color/contrast_text_dark_theme redirection
3 years ago
Gabriel Luong
2456e9b5f5
For #21973 - Remove @color/secondary_text_dark_theme redirection
3 years ago
Gabriel Luong
959a142c92
For #21973 - Use destructive_normal_theme in place of R.color.design_color
3 years ago
Mozilla L10n Automation Bot
b7bdd94e71
Import l10n.
3 years ago
Michael Comella
9721723af5
For android-components#11161: pass profiler into AwesomeBar.
...
This will add two new markers:
- SuggestionFetcher.fetch
- Suggestion update
This is a profile with the markers: https://share.firefox.dev/3E4PbEk
3 years ago
AndiAJ
4fe8921a82
For #18421 fix and re-enable verifyContextShareLink, verifyContextSaveImage and verifyContextMixedVariations UI tests
3 years ago
Arturo Mejia
a2c7dfb26e
For #22170 : Add telemetry for the auto-close prompt
3 years ago
Arturo Mejia
9154371ba5
For #21906 ⁃ Update strings removal version
3 years ago
Mozilla L10n Automation Bot
59a069882d
Import l10n.
3 years ago
Grisha Kruglov
04a35c81b8
Closes #22083 - Match history groups to history pages by all items within the group
...
When deciding if we should include a history group within the "page of
history" results on the History View UI, we used to look at the most
recent timestamp of the metadata items within the group, and see if that
falls within the range of the timestamps of the history page, +/- some
buffer.
This assumes that each metadata entry will have a corresponding history
item. However, that's not true - when restarting the app, the selected
tab will be restored, and when opening History View right after we'll
record some metadata for it. However, we won't record a history visit
during the app restore for the selected tab.
That's all correct, but the assumption around group matching to history is now incorrect.
This patch changes the logic to instead look at every item within the
group, and see if any of them match the time window of the current
history page. This has a side-effect of also displaying search groups
multiple times on diffenent pages of history, if it makes sense to do so chronologically.
I think that's fine, it reflects reality at least (e.g. items within the
group may have been visited at very different points in time).
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
Arturo Mejia
d943be0e53
For #22034 : Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
3 years ago
MickeyMoz
a4bcecf8c5
Update Android Components version to 95.0.20211026143215.
...
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
Gabriel Luong
44666ca2ca
For #21776 - Call chain on collection type may be simplified
3 years ago
Gabriel Luong
100547130e
For #21776 - Add package path to TabGroupViewHolder
3 years ago
Gabriel Luong
b04bf99b7d
For #21776 - Remove unused symbols
3 years ago
Gabriel Luong
b54698a3f2
For #21776 - Class member can have 'private' visibility
3 years ago
Gabriel Luong
3115f1343f
For #21776 - Replace Java static method with Kotlin analog
3 years ago
Gabriel Luong
660300f770
For #21776 - Replace 'isEmpty' with 'ifEmpty'
3 years ago
Gabriel Luong
603ba63962
For #21776 - 'protected' visibility is effectively 'private' in a final class
3 years ago
Gabriel Luong
da395d1038
For #21776 - Local 'var' is never modified and can be declared as 'val'
3 years ago
Gabriel Luong
5afe393b8f
For #21776 - Remove unused imports
3 years ago
Gabriel Luong
76c746b982
For #21776 - Remove unnecessary type argument
3 years ago
Gabriel Luong
272d31b2b4
For #21776 - Remove unnecessary parentheses from function call with lambda
3 years ago
Gabriel Luong
6d1d4bea93
For #21776 - Remove redundant qualifier name
3 years ago
Gabriel Luong
1039a92281
For #21776 - Remove reductant SAM constructor
3 years ago
Gabriel Luong
ed48dc934a
For #21776 - Remove reductant 'suspend' modifier from SecurePrefsTelemetry
3 years ago
Gabriel Luong
d854c282da
For #21776 - Remove val from constructor parameter that are never used as a property
3 years ago
codrut.topliceanu
bba787e87e
For #21732 - Adds inactive tabs survey on disable + telemetry
3 years ago
Mugurell
6d62aed35f
For #21933 - Refresh history items everytime the fragment is opened
3 years ago
Mozilla L10n Automation Bot
c9e769544f
Import l10n.
3 years ago
Jonathan Almeida
7666f0e4c2
No issue: Replace TabsTray.Tab with TabSessionState
...
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
Jonathan Almeida
b2a7877c83
No issue: Disable FenixSnackbarDelegateTest intermittents
3 years ago
AndiAJ
6149f9faf8
Use identifiers instead of hard coded strings
3 years ago
AndiAJ
d3651eb0fc
For #21747 re-enable start on homepage UI test and refactoring work
3 years ago
AndiAJ
b10835992d
For #21754 re-enable general settings UI test and refactoring work
3 years ago
AndiAJ
4c343b8b3a
For #21004 fix and refactor verifyBasicNavigationToolbarFunctionality UI test
3 years ago
Roger Yang
367c5f42d8
No issue: Add external load flag
3 years ago
Sebastian Kaspari
170fa9705e
Update Kotlin and Jetpack Compose versions.
3 years ago
Oana Horvath
52facc9723
For #21628 : catch ComposeNotIdleException
3 years ago
Arturo Mejia
ee8c4de62d
For #21986 Confirmation when people set tabs to auto-close
...
For #22034 Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
3 years ago
Mayank Agarwal
1a7b486808
Issue #21714 : Login button visibility fix on saved logins page
3 years ago
Mugurell
e0bf4f31fa
For #21771 - Show url when recent tab's title is not available
...
This is the same previously used approach and the same used for tabs tray.
3 years ago
Mozilla L10n Automation Bot
df2652f9b5
Import l10n.
3 years ago
Mozilla L10n Automation Bot
a8f42cd363
Import l10n.
3 years ago
Mozilla L10n Automation Bot
9e1f596c1e
Import l10n.
3 years ago
Michael Comella
ec1a25dfcf
For #21921 - post: switch generic marker skip to BaseBrowserFragment.
...
Since we instrument the marker with the duration in BaseBrowserFragment,
we should skip on BaseBrowserFragment too, not its subclass,
BrowserFragment.
3 years ago
Michael Comella
788eb2c5de
For #21921 : add duration for some BrowserFragment lifecycle markers.
...
Here is a sample profile with all the new markers:
https://share.firefox.dev/3lCGoD2
3 years ago
Michael Comella
3a3c39406a
For #21921 : add durations for some HomeFragment lifecycle markers.
3 years ago
Michael Comella
f65ea1e972
For #21921 : add and register MarkersFragmentLifecycleCallbacks.
3 years ago
Michael Comella
99533626f1
For #21921 : rename MarkersLifecycleCallbacks to ...ActivityLifecycle...
...
This is to disamibugate with the MarkersFragmentLifecycleCallbacks that
we'll be adding.
3 years ago
Michael Comella
623914bd89
For #22054 : add marker for root view layout/measure.
...
The onLayout marker may be redundant to onGlobalLayout marker but I'm not
sure yet so let's leave them both in and observe if that's the case.
Here's a profile with the markers: https://share.firefox.dev/3lZaOQb
3 years ago
Oana Horvath
1234d8f518
For #22095 : fix intermittent click failure in verifyRateOnGooglePlayRedirect UI test
3 years ago
Mugurell
acdde511d3
For #22070 - Prevent crash for when a selected topic does not exist anymore
...
The list of selected topics overwrites old data whenever user selects or
deselects another so the old selections will not leak for long.
3 years ago
Roger Yang
70fc6fc20f
Close #22061 : Let TabSorter decide if title header should be shown in tabs tray
3 years ago
Mozilla L10n Automation Bot
2d8492d33f
Import l10n.
3 years ago
Roger Yang
b5c15280f7
No issue: Only report telemetry when tabs tray is first opened
3 years ago
Mugurell
c4278bfbf6
For #21841 - New telemetry for Google and Baidu top sites removal
3 years ago
Michael Comella
a1ace964de
No issue - post: fix ProfilerMarkerFactProcessor tests.
3 years ago
Michael Comella
0faa61b744
No issue: use Fact.value as detailText for markers.
...
This allows Facts emitted from ac to provide more details in markers.
3 years ago
Michael Comella
01e3b4b984
No issue: cache SearchDialogFragment.InlineAutocompleteEditText.
...
Assuming the InlineAutocompleteEditText is not being recreated (and I
did not verify this), it's unnecessary to traverse the view hierarchy
to find it more than once so this patch removes the unnecessary
traversals.
3 years ago
Oana Horvath
34ca959661
For #20754 : fix intermittent click failure in verifyAboutFirefoxPreview test
3 years ago
Andrei Joltan
3af6abff18
For #22065 fix flaky privateTabsTrayWithOpenedTabTest UI test ( #22068 )
...
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
3 years ago
AndiAJ
560de4f396
For #21207 fix flaky updateSavedLoginTest UI test
3 years ago
Mozilla L10n Automation Bot
c0ab0cb1c5
Import l10n.
3 years ago
Gabriel Luong
64ca94b8fa
For #22022 - Composify Customize Home Button and update the background color
3 years ago
Gabriel Luong
ada3da59ec
For #22022 - Update SelectableChip button background colors
3 years ago
xlog-null
edd1fd9f2c
For #22032 - Fix horizontal margin on private home screen
3 years ago
Gabriel Luong
07a6a386f8
For #21753 - Refactor Pocket out of sessioncontrol
3 years ago
Noah Bond
826249497a
MR2 Inactive tabs telemetry ( #21908 )
...
* For #21903 - Added telemetry for interacting with inactive tabs
* For #21903 - Added missing inactive tab delete count event to delete all event
* For #21903 - Added PR numbers to metrics
* For #21903 - Updated broken unit tests. Resolved critical lint warning.
* For #21903 - Fixed inactive tabs setting toggle metric
* For #21903 - Updated FenixApp unit test
* For #21903 - Updated newline character in Metrics. Set inactive tab metrics' lifetime to default. Updated expiration to Nov 2022. Refactored inactive tabs metric to be a single metric.
* PR: addendum for last commit that missed a file
* For #21903 - Changed logic check for reporting inactive tab count
* PR: fixed merge conflict
* For #21903 - Removed tab close tracking when the user closes ALL inactive tabs
* For #21903 - Removed individual tab close metric verify from CLOSE ALL test
* For #21903 - Updated inactive tabs toggle setting expiration to match the expiration of the other events
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Gabriel Luong
af48553418
For #21935 - Use photonBlue40 in place of #0090ED
3 years ago
Gabriel Luong
8b3d39f0c0
For #21935 - Use photonDarkGrey20 in place of #4A4A55
3 years ago
Gabriel Luong
541ed5cec6
For #21935 - Use photonPink30 in place of #FF6BBA
3 years ago
Gabriel Luong
5a5ba1c095
For #21935 - Use photonBlue30 in place of #00B3F4
3 years ago
Gabriel Luong
a81912bd98
For #21935 - Use photonViolet30 in place of #C689FF
3 years ago
Gabriel Luong
475d59b781
For #21935 - Use photonYellow90 in place of #960E18
3 years ago
Gabriel Luong
5a7890497f
For #21935 - Use photonRed40 in place of #FF6A75
3 years ago
Gabriel Luong
dfd9f7c1ea
For #21935 - Use photonDarkGrey50 in place oof #32313C
3 years ago
Gabriel Luong
6010767da7
For #21935 - Use photonBlue50 in place of #0060DF
3 years ago
Gabriel Luong
0e8b797014
For #21935 - Use photonGreen70 in place of #.008787
3 years ago
Gabriel Luong
c379d75c7f
For #21935 - Use photonInk20 in place of #312A64
3 years ago
Gabriel Luong
4d61277e88
For #21935 - Use photonViolet50 in place of #9059ff
3 years ago
Gabriel Luong
a31d638191
For #21935 - Use photonYellow70 in place of #C45A27
3 years ago
Gabriel Luong
a02d58dd48
For #21935 - Use photonYellow60 in place of #E27F2E
3 years ago
Gabriel Luong
cd6bcb3d47
For #21935 - Use photonGreen60 in place of #2AC3A2
3 years ago
Gabriel Luong
9048af04be
For #21935 - Use photonPink60 in place of #E31587
3 years ago
Gabriel Luong
bd7ced5867
For #21935 - Use photonDarkGrey90 in place of #15141A
3 years ago
Gabriel Luong
e119b8b590
For #21935 - Use photonViolet40 in place of #AB71FF
3 years ago
Gabriel Luong
ff829f9f25
For #21935 - Use photonBlue60 in place of #0250BB
3 years ago
Gabriel Luong
26920baf47
For #21935 - Use photonRed70 in place of #C50042
3 years ago
Gabriel Luong
624afa9e53
For #21935 - Use photonPurple50 in place of #B833E1
3 years ago