For #21841 - New telemetry for Google and Baidu top sites removal

upstream-sync
Mugurell 3 years ago committed by mergify[bot]
parent a1ace964de
commit c4278bfbf6

@ -3715,6 +3715,32 @@ top_sites:
notification_emails:
- android-probes@mozilla.com
expires: "2022-02-01"
google_top_site_removed:
type: event
description: |
A user removed the default Google top site
bugs:
- https://github.com/mozilla-mobile/fenix/issues/21841
data_reviews:
- https://github.com/mozilla-mobile/fenix/pull/21845#issuecomment-944608568
data_sensitivity:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: "2022-02-01"
baidu_top_site_removed:
type: event
description: |
A user removed the default Baidu top site
bugs:
- https://github.com/mozilla-mobile/fenix/issues/21841
data_reviews:
- https://github.com/mozilla-mobile/fenix/pull/21845#issuecomment-944608568
data_sensitivity:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: "2022-02-01"
app_theme:
dark_theme_selected:

@ -113,6 +113,8 @@ sealed class Event {
object TopSiteOpenInNewTab : Event()
object TopSiteOpenInPrivateTab : Event()
object TopSiteRemoved : Event()
object GoogleTopSiteRemoved : Event()
object BaiduTopSiteRemoved : Event()
object TrackingProtectionTrackerList : Event()
object TrackingProtectionIconPressed : Event()
object TrackingProtectionSettingsPanel : Event()

@ -479,6 +479,12 @@ private val Event.wrapper: EventWrapper<*>?
is Event.TopSiteRemoved -> EventWrapper<NoExtraKeys>(
{ TopSites.remove.record(it) }
)
is Event.GoogleTopSiteRemoved -> EventWrapper<NoExtraKeys>(
{ TopSites.googleTopSiteRemoved.record(it) }
)
is Event.BaiduTopSiteRemoved -> EventWrapper<NoExtraKeys>(
{ TopSites.baiduTopSiteRemoved.record(it) }
)
is Event.TopSiteLongPress -> EventWrapper(
{ TopSites.longPress.record(it) },
{ TopSites.longPressKeys.valueOf(it) }

@ -347,8 +347,10 @@ class DefaultSessionControlController(
override fun handleRemoveTopSiteClicked(topSite: TopSite) {
metrics.track(Event.TopSiteRemoved)
if (topSite.url == SupportUtils.POCKET_TRENDING_URL) {
metrics.track(Event.PocketTopSiteRemoved)
when (topSite.url) {
SupportUtils.POCKET_TRENDING_URL -> metrics.track(Event.PocketTopSiteRemoved)
SupportUtils.GOOGLE_URL -> metrics.track(Event.GoogleTopSiteRemoved)
SupportUtils.BAIDU_URL -> metrics.track(Event.BaiduTopSiteRemoved)
}
viewLifecycleScope.launch(Dispatchers.IO) {

Loading…
Cancel
Save