Sebastian Kaspari
ec29bdbc78
[fenix] Rename HistoryStore/State/Action to HistoryFragmentStore/State/Action.
5 years ago
Sebastian Kaspari
a682a16b25
[fenix] Rename AccountSettingsStore/State/Action to AccountSettingsFragmentStore/State/Action.
5 years ago
Sebastian Kaspari
0a46f6d16a
[fenix] Rename SearchStore/State/Action to SearchFragmentStore/State/Action.
5 years ago
Sebastian Kaspari
5a3bfb2b77
[fenix] Rename ExceptionsStore/State/Action to ExceptionsFragmentStore/State/Action.
5 years ago
Sebastian Kaspari
52d15c5be7
[fenix] Rename BrowserStore/State/Action to BrowserFragmentStore/State/Action.
5 years ago
Sebastian Kaspari
c0b76b338f
[fenix] Rename BookmarkStore/State/Action to BookmarkFragmentStore/State/Action.
5 years ago
mihai-adrian
309495f15a
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4997 : Changed navigation to ShareFragment
...
Changed test for new global navigation to share fragment.
5 years ago
mihai-adrian
0f119aae4e
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4997 : Changed navigation to ShareFragment
...
Added global navigation action to share fragment in navigation graph
Changed share action to use global navigation to ShareFragment
5 years ago
Sebastian Kaspari
61c2a0878f
[fenix] Issue https://github.com/mozilla-mobile/fenix/pull/4907 : Link to usage of sharedUserId in Fennec code.
5 years ago
Sebastian Kaspari
720589cbb0
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873 : Use manifest placeholder to inject sharedUserId.
5 years ago
Sebastian Kaspari
7a554f2f4e
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873 : Reuse sharedUserId from Fennec for fennecProduction build type.
5 years ago
Sebastian Kaspari
9a01bb2639
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873 : Use Fennec version code mechanism for fennecProduction build type.
5 years ago
Sebastian Kaspari
b4b87eb165
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873 : Only build fennecProduction build types with GeckoView Beta.
5 years ago
Sebastian Kaspari
c91a28030f
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873 : Reuse Firefox application id for fennecProduction build type.
5 years ago
Sebastian Kaspari
7061d22246
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873 : Introduce "fennecProduction" build type.
5 years ago
Colin Lee
b5615b600d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5055 : Crash when opening bookmarks ( https://github.com/mozilla-mobile/fenix/pull/5058 )
5 years ago
Christian Sadilek
c1d104a193
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2088 : Use new async API to load default search engine in HomeFragment
5 years ago
Sebastian Kaspari
6ac2509131
[fenix] Move creation of GeckoRuntime to flavor-specific source set.
...
Since we are now able to build against GeckoView Nightly and GeckoView Beta,
we should create the GeckoRuntime from a flavor-specific source set.
Creating the runtime is not covered by the AC abstraction and so API changes
in GeckoView Nightly can break the build and leaves us with no option to fix
it from a shared code base. Separating the creation of GeckoRuntime
allows us to adapt individually and also to configure the runtimes
differently.
5 years ago
Will Hawkins
2127d42c9d
[fenix] Use new async API to load and access search engines
...
Use the new asynchronous features of the search engine
manager from a-c to avoid the latency required to load
the default search engine.
5 years ago
Mugurell
23f1395585
[fenix] For 4007 - Add unit tests for the Share Interactor, Controller and list Adapters
5 years ago
Mugurell
00a0d8db5e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4007 - Add ShareController for handling ShareFragment's business logic
...
`ShareController` defines a contract with all possible `ShareFragment`'s
behavior changes and comes with a default implementation -
`DefaultShareController`.
It is to be delegated by all `ShareFragment`s contained Views' Interactors
following any user interactions.
5 years ago
Mugurell
051f09a15a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4007 - ShareFragment will set the contained Views' state
...
ShareFragment which acts as a container would contain all business logic needed
for populating it's Views.
Data initialization should be done only once since the app state has no reason
to change after the ShareFragment is created and is done as soon as possible,
in onAttach().
Because of the expected short lifespan of this fragment, given the fact that
the state has no reason to change and we handle orientation changes ourselves
to keep things simple I didn't use a ViewModel to persist the state.
5 years ago
Mugurell
a8cbf8b1d8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4007 - Refactor AppShareView in standalone Share Views
...
In an effort to respect the initial MVI architecture I've broken the
complex `AppShareView` in 3 separate Views
- `ShareCloseView`
- `ShareToAccountDevicesView`
- `ShareToAppsView`
They are standalone Views (extending LayoutContainer) which know nothing about
each other or their parent and so offer their container the possibility to
order or display them in any form later.
According to the lib-state contract they are only responsible to
- inflate themselves in their injected containerView
- render a certain state (to be added in later commits)
- delegate all user interaction to an associated Interactor
5 years ago
Mugurell
4168f278f2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4007 - Use camelCase for views referenced from code
...
As per https://github.com/mozilla-mobile/fenix/issues/4341 .
Also reformatted layouts to have a more consistent style.
Also refactored `AppShareRecyclerView` and `AccountDevicesShareRecyclerView` by
defining their LayoutManager in XML to reduce code complexity.
5 years ago
Tiger Oakes
09ca0c9e48
[fenix] Add comments to AuthCustomTabActivity
5 years ago
Sawyer Blatz
90a79b82f7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3892 : Fixes help link on nightly ( https://github.com/mozilla-mobile/fenix/pull/4956 )
5 years ago
Mihai Adrian
d091cb2c1c
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4894 : added workaround for SDK<24 vector drawable with gradient color ( https://github.com/mozilla-mobile/fenix/pull/4944 )
...
Removed drawableStart and added ImageView in layouts
Set ImageView logo programmatically: bitmap for SDK<24, vector for SDK>=24
Added onClickPendingIntent for ImageView in large and medium layouts
5 years ago
Tiger Oakes
e4abe9cace
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/773 - Add shortcuts to homescreen ( https://github.com/mozilla-mobile/fenix/pull/4925 )
5 years ago
Colin Lee
b472ab03be
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4064 : Old R8 & keep rules are inhibiting optimizations ( https://github.com/mozilla-mobile/fenix/pull/4930 )
5 years ago
mihai-adrian
46aec58767
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/3602:navigate to top of home screen after tapping "start browsing"
...
After onboarding.finish(), scrolled homeLayout to top
5 years ago
Jonathan Almeida
d8489d7350
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4218 : Remove forced registration renewal for push
5 years ago
Jonathan Almeida
818a6693f9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4063 : Remove SendTab feature flags
5 years ago
Yeon Taek Jeong
b4fa37b231
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4658 : Add some private browsing mode telemetry ( https://github.com/mozilla-mobile/fenix/pull/4968 )
5 years ago
Sawyer Blatz
0356d7c3ec
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4969 : Removes erroneous FxA sign up ping ( https://github.com/mozilla-mobile/fenix/pull/4970 )
5 years ago
Yeon Taek Jeong
cc75c0df87
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2053 : Add persistent notification to close all private browsing tabs ( https://github.com/mozilla-mobile/fenix/pull/4913 )
5 years ago
Sebastian Kaspari
a63606870c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4215 : CustomTabActivity: Remove attached session if activity is finishing. ( https://github.com/mozilla-mobile/fenix/pull/4985 )
5 years ago
Emily Kager
6527ff2fcd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4863 - Remove delay in HomeFragment onPreDraw
5 years ago
Suraj Shah
bde36a6d45
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4488 : Shows snackbar on bookmark deletion from edit fragment ( https://github.com/mozilla-mobile/fenix/pull/4792 )
...
* Fixes https://github.com/mozilla-mobile/fenix/issues/4488
Updates changelog
* Removes wildcard imports.
* Removes custom label in use, replaces with let
5 years ago
Sebastian Kaspari
5db6464268
[fenix] Use Mozilla Android Components 10.0.1.
5 years ago
Jonathan Almeida
dec7d9a442
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4960 : Initialize push only if available ( https://github.com/mozilla-mobile/fenix/pull/4964 )
5 years ago
Afzal Najam
e0f503fe0c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4718 - Update site permissions layout ( https://github.com/mozilla-mobile/fenix/pull/4953 )
5 years ago
Jeff Boek
03babccbf6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4063 - Always enable the push service ( https://github.com/mozilla-mobile/fenix/pull/4932 )
5 years ago
Tiger Oakes
6fa3cf4a26
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4771 - Add method for sessions of type ( https://github.com/mozilla-mobile/fenix/pull/4782 )
...
Fixes share tabs to use the new method
5 years ago
Emily Kager
d3cbb93b88
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4295 - Adds Experiments Pref to Data Collection Settings ( https://github.com/mozilla-mobile/fenix/pull/4915 )
5 years ago
Sebastian Kaspari
dc70e530cc
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4431 : Enable feature-media component for all builds. ( https://github.com/mozilla-mobile/fenix/pull/4898 )
5 years ago
Mihai Adrian
1e2fdf5cae
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4211 changed SeekBar height to wrap_content to prevent misaligned dot ( https://github.com/mozilla-mobile/fenix/pull/4832 )
...
Changed height from match_constrained to wrap_content.
5 years ago
Emily Kager
018086c9ae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4921 - Adds WindowFeature to BaseBrowserFragment
5 years ago
Arturo Mejia
eb53d10047
[fenix] Fix safe browsing API breaking change. ( https://github.com/mozilla-mobile/fenix/pull/4946 )
5 years ago
Aaron Train
da02c6f228
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4926 : Add basic UI test for regular/private tabs ( https://github.com/mozilla-mobile/fenix/pull/4928 )
5 years ago
Sourabh
d47dc7b29d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4398 - add HistoryController ( https://github.com/mozilla-mobile/fenix/pull/4837 )
5 years ago
Mihai Adrian
c68c8a4374
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4440 changed padding for account_preference ( https://github.com/mozilla-mobile/fenix/pull/4830 )
...
Changed padding to default value in @android:style/Preference.Material.Category.
Also changed paddingEnd value to default value.
5 years ago
Amaan Marfatia
f42c71ccfe
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4067 besides snackbar ( https://github.com/mozilla-mobile/fenix/pull/4777 )
...
* Fixes https://github.com/mozilla-mobile/fenix/issues/4067 besides snackbar
Makes layout hierarchy more shallow to increase performance.
* Fix https://github.com/mozilla-mobile/fenix/issues/4067 Feedback
Make sure quick_action_overlay appears on top and use horizontal chain in tab_header.
5 years ago
Axel Hecht
118c704270
[fenix] Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@349efdbc8f
5 years ago
Colin Lee
cdc611fec5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4885 : D8 Build failure on attempt to execute UI test ( https://github.com/mozilla-mobile/fenix/pull/4903 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4885 : D8 Build failure on attempt to execute UI test
* Disabled screengrab tests until AndroidX fix is available
5 years ago
Tiger Oakes
df7dc6523c
[fenix] Add custom tab fragment
5 years ago
ekager
eb3c357f61
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3967 - Invoke pending deletion on back pressed
5 years ago
ekager
2f11d83ca4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4868 - Update content description of tabs button with number of tabs
5 years ago
Grisha Kruglov
a9288459fa
[fenix] No issue: only sync once on startup
5 years ago
Emily Kager
ea577bdf3a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4779 : Don't double navigate with global directions in HomeActivity
5 years ago
Axel Hecht
86cd4a78ba
[fenix] Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@90a28fd458
5 years ago
Sebastian Kaspari
456cfb5bfb
[fenix] Use version name/code override. ( https://github.com/mozilla-mobile/fenix/pull/4895 )
5 years ago
Emily Kager
c87829be14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4652 : Use workaround for HomeScreenViewModel ( https://github.com/mozilla-mobile/fenix/pull/4887 )
5 years ago
Tiger Oakes
63814821eb
[fenix] Extract intent processors from HomeActivity ( https://github.com/mozilla-mobile/fenix/pull/4884 )
5 years ago
Sebastian Kaspari
11a92537ce
[fenix] Rename "nightly" source folder to "fenixNightly".
5 years ago
Tiger Oakes
b8695ca06b
[fenix] Make `Settings.instance` private
5 years ago
Sebastian Kaspari
14e9fc85da
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4874 : Use new build types in FeatureFlags class.
5 years ago
Emily Kager
11b37b2da0
[fenix] Adds experiments preferences strings
5 years ago
Emily Kager
494008a099
[fenix] No issue: Land strings for Delete Browsing Data on Quit
5 years ago
Colin Lee
bd400b8f53
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4064 : Dispatchers.Main still has long cold start delay (Phase II)
5 years ago
Tiger Oakes
cf9ace2cc1
[fenix] Move classes out of top-level package
5 years ago
Richard Pappalardo
3e02efef28
[fenix] Stub out Settings tests
5 years ago
Jeff Boek
6ec0801d0c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4326 - Updates codebase to support latest version of detekt
5 years ago
Jeff Boek
40ae66fdbb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4326 - Updates codebase to support latest version of ktlint
5 years ago
Emily Kager
51d4956148
[fenix] No issue: Land new string for delete browsing data prompt ( https://github.com/mozilla-mobile/fenix/pull/4859 )
5 years ago
Colin Lee
f187762a78
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3869 : Switch to A-C SearchLocalizationProvider ( https://github.com/mozilla-mobile/fenix/pull/4858 )
...
* For https://github.com/mozilla-mobile/fenix/issues/3869 : Switch to A-C SearchLocalizationProvider
* Fix test
5 years ago
Nick Alexander
dbb115a551
[fenix] Consume new `substitute-local-geckoview.gradle` script from Bug 1533465.
5 years ago
Mihai Adrian
71229cdddd
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4795 fixed requestDesktopStateProvider value from private to desktopMode ( https://github.com/mozilla-mobile/fenix/pull/4810 )
...
RequestDesktopStateProvider was taken from private instead of desktopMode
5 years ago
Sourabh
c50d08d405
[fenix] add tests for DefaultQuickActionSheetController ( https://github.com/mozilla-mobile/fenix/pull/4835 )
5 years ago
Tiger Oakes
9e9246ada3
[fenix] No issue: Clean up preferences code ( https://github.com/mozilla-mobile/fenix/pull/4699 )
5 years ago
Emily Kager
409cea2128
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3967 - Invokes pending deletion with more bookmark actions ( https://github.com/mozilla-mobile/fenix/pull/4522 )
5 years ago
Mitchell Hentges
e7ca5257b4
[fenix] Configure either geckoview beta or nightly at compile-time ( https://github.com/mozilla-mobile/fenix/pull/4851 )
...
* Remove "abi" product flavor and introduce "engine" product flavor.
This patch will allow us to build Fenix against GeckoView Nightly and GeckoView Beta by
introducing a new flavor dimension: engine = [geckoNightly, geckoBeta].
In addition to that it adds a "fenix" prefix to the nightly, beta and production flavors
to reduce the ambiguity between fenix beta/nightly and GeckoView beta/nightly.
For now the build types have the following engine variants enabled:
**debug**: geckoNightly, geckoBeta
Both variants enabled for local development and testing.
**forPerformanceTest**: geckoNightly, geckoBeta
Both variants enabled unless the perf team only cares about Nightly (tbd)
**fenixNightlyLegacy**: geckoBeta
Uses GeckoView Beta for now - the same version we ship production builds with (same behavior
as before). This release type will eventualyl be decommissioned once we switch to a separate
Nightly app on Google Play.
**fenixNightly**: geckoBeta
Uses GeckoView Beta for now - the same version we ship production builds with (same behavior
as before). Changing this build to use GeckoView Nightly is currently being discussed.
**fenixBeta**: geckoBeta
Fenix Beta uses GeckoView Beta.
**fenixProduction**
Fenix Production uses GeckoView Beta (69) currently.
* gradle.py/variant.py: Replace "abi" with "engine".
* Disable enableUnitTestBinaryResources until we can switch to Android Gradle plugin 3.5.
* Fenix nightly should use both geckoview nightly and beta
* Updates automation to use apk splitting and support different engine
5 years ago
Jonathan Almeida
584103cdf6
[fenix] Use Mozilla Android Components 10.0.0
5 years ago
Emily Kager
528b8e0d5f
[fenix] No issue: Land new strings for ETP and delete browsing data
5 years ago
Yeon Taek Jeong
410bb482b1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2834 : Add contentDescription to tabs button icons
5 years ago
Emily Kager
1d3eec6208
[fenix] No issue: Don't show session provider in private mode
5 years ago
Yeon Taek Jeong
86ec7d5d6c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2834 : Delete all Private Tabs redesign ( https://github.com/mozilla-mobile/fenix/pull/4787 )
5 years ago
(´⌣`ʃƪ)
da54bdfe63
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4436 : Dismiss onboarding before navigating away from home ( https://github.com/mozilla-mobile/fenix/pull/4801 )
5 years ago
Tiger Oakes
9882aa6a50
[fenix] Adds setters and property delegates in `Settings` ( https://github.com/mozilla-mobile/fenix/pull/4809 )
...
* Change Settings to use setters
* Add delegate for shared preferences
5 years ago
Tiger Oakes
7780821922
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2690 - Clean up CreateCollection viewmodel ( https://github.com/mozilla-mobile/fenix/pull/4731 )
5 years ago
Tiger Oakes
2fb1bd0283
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4774 - Use vector drawable compat ( https://github.com/mozilla-mobile/fenix/pull/4811 )
5 years ago
Tiger Oakes
500d557828
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4744 - Extract private browsing button ( https://github.com/mozilla-mobile/fenix/pull/4813 )
5 years ago
Tiger Oakes
d5e5b73485
[fenix] Color the system bars in custom tabs ( https://github.com/mozilla-mobile/fenix/pull/4819 )
5 years ago
Tiger Oakes
efe2e2e466
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/1000 - Remove isCustomTab flag ( https://github.com/mozilla-mobile/fenix/pull/4656 )
5 years ago
Sourabh
0e376bb266
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4399 : Create LibState Controller for Search ( https://github.com/mozilla-mobile/fenix/pull/4673 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4399 : Create LibState Controller for Search
* fix code format
* add unit tests for DefaultSearchController
* add more test
* fix unit tests
5 years ago
Mugurell
2634b6dee4
[fenix] For 4827 - Remove TransitionPreDrawListenerTest pending tests refactoring
...
New tests for `FragmentPreDrawManager` are to be added in https://github.com/mozilla-mobile/fenix/issues/4828
5 years ago
Mugurell
fa2abeffe9
[fenix] Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout
...
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.
`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
5 years ago
Emily Kager
9431f611d5
[fenix] Update strings.xml
...
Remove space in placeholder for es (temp for release)
5 years ago
Axel Hecht
7d5d5b7afd
[fenix] Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@413e05dba4
5 years ago
Tiger Oakes
1c389d1231
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4744 - Extract TransitionPreDrawListener ( https://github.com/mozilla-mobile/fenix/pull/4812 )
5 years ago
Tiger Oakes
774d696c92
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4744 - Move search bar icon padding to dimens ( https://github.com/mozilla-mobile/fenix/pull/4814 )
5 years ago
Emily Kager
0268034e79
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4822 - Update Bookmark State in onResume ( https://github.com/mozilla-mobile/fenix/pull/4823 )
5 years ago
Mihai Adrian
8a1829b484
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/4179 removed control highlight from disconnect button ( https://github.com/mozilla-mobile/fenix/pull/4806 )
...
set colorControlHighlight to transparent in activity theme.
property cannot be set in view because it is overwritten by activity theme.
5 years ago
Sawyer Blatz
1c995d36e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2706 : Refactor Glean to reduce errors ( https://github.com/mozilla-mobile/fenix/pull/4753 )
...
* For https://github.com/mozilla-mobile/fenix/issues/2706 : Adds recording for untracked events
* For https://github.com/mozilla-mobile/fenix/issues/2706 : Adds key alignment to Metrics
5 years ago
Sawyer Blatz
46eaca2871
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4421 : Fixes issues with new glean events ( https://github.com/mozilla-mobile/fenix/pull/4816 )
5 years ago
Sawyer Blatz
ea193a5472
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4804 : Resolves issue with crash reporter stack
5 years ago
Aaron Train
aa9bf1aa6e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4618 - Stub Library UI tests ( https://github.com/mozilla-mobile/fenix/pull/4619 )
...
See https://github.com/mozilla-mobile/fenix/issues/4572
5 years ago
Arturo Mejia
7f746f6f17
[fenix] Use Mozilla Android Components 9.0.0-SNAPSHOT. ( https://github.com/mozilla-mobile/fenix/pull/4750 )
5 years ago
Suraj Shah
f3a412e24e
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4704 ( https://github.com/mozilla-mobile/fenix/pull/4728 )
...
* Fixes https://github.com/mozilla-mobile/fenix/issues/4704 . Overrides `setEnabled` for DeleteBrowsingDataItem to change view alpha when disabled and to toggle the checkbox `isEnabled` behavior based on the value provided.
* Updates CHANGELOG.md
* Removes unnecessary disabling of checkbox in DeleteBrowsingDataItem.kt
Updates CHANGELOG.md to reflect the component changed.
5 years ago
Mugurell
43e4bcc0b1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4396 - Add a Bookmarks Controller ( https://github.com/mozilla-mobile/fenix/pull/4593 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4396 - Rename BookmarkInteractor methods
Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.
Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.
* For https://github.com/mozilla-mobile/fenix/issues/4396 - Add a BookmarkController
It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.
This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.
* For https://github.com/mozilla-mobile/fenix/issues/4396 - Refactored Bookmark related tests
Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`
Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
5 years ago
Tiger Oakes
84349bda63
[fenix] Extract quick action sheet observer code ( https://github.com/mozilla-mobile/fenix/pull/4368 )
5 years ago
Emily Kager
80b2c4ee51
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4799 https://github.com/mozilla-mobile/fenix/issues/4790 - Don't use passed in sessions in BrowserToolbarController ( https://github.com/mozilla-mobile/fenix/pull/4800 )
5 years ago
Colin Lee
47bbb9081d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4686 : Fix potential security issue ( https://github.com/mozilla-mobile/fenix/pull/4764 )
5 years ago
Yeon Taek Jeong
d72c8cf1b6
[fenix] No issue: fixes click failures on search widget icon
5 years ago
Emily Kager
043f8829c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4688 - Try to use context instead of targetContext ( https://github.com/mozilla-mobile/fenix/pull/4765 )
5 years ago
Yeon Taek Jeong
b1fdb6a353
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4736 : Display search shortcuts only from home or search widget
5 years ago
Emily Kager
52ff9a61f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4688 - Try slightly different Context class for MockWebServer ( https://github.com/mozilla-mobile/fenix/pull/4747 )
5 years ago
Emily Kager
b037ddee5a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4680 - Align collection creation text center vertical
5 years ago
Yeon Taek Jeong
6c41d30fd8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4384 : Hide mic icon if speech-to-text is unavailable ( https://github.com/mozilla-mobile/fenix/pull/4701 )
5 years ago
Yeon Taek Jeong
8efb7f9cdb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4516 : Use full width for large search widgets ( https://github.com/mozilla-mobile/fenix/pull/4659 )
5 years ago
Emily Kager
e4f3b39e0b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/3860 - Update description text for collections
5 years ago
Sawyer Blatz
6cfbb2c02b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4421 : Adds Leanplum events and attributes ( https://github.com/mozilla-mobile/fenix/pull/4626 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4421 : Adds Leanplum events and attributes
* For https://github.com/mozilla-mobile/fenix/issues/4421 : Adds Leanplum deep links
5 years ago
Yeon Taek Jeong
309b86544c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4421 : Add search widget attribute to Leanplum ( https://github.com/mozilla-mobile/fenix/pull/4694 )
5 years ago
Yeon Taek Jeong
468c400ff5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4457 : Adds telemetry for search widget actions ( https://github.com/mozilla-mobile/fenix/pull/4714 )
5 years ago
Yeon Taek Jeong
2c70a18a62
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4732 : Fix search engine display issue ( https://github.com/mozilla-mobile/fenix/pull/4735 )
5 years ago
Mihai Adrian
4835dbb1a8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4434 - made close button for collections more accessible. ( https://github.com/mozilla-mobile/fenix/pull/4443 )
...
* fixes https://github.com/mozilla-mobile/fenix/issues/4434 - made close button for collections more accessible.
set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
implemented same visual solution as for https://github.com/mozilla-mobile/fenix/issues/4193 - close button for tabs
* fixes https://github.com/mozilla-mobile/fenix/issues/4434 - made buttons for collection home list row more accessible and aligned 3 dot menu with individual tabs close button
set buttons sizes to recommended minimum size for accessibility 48x48, while keeping image size the same
removed margins from buttons as they were not needed anymore
aligned center of menu buttons with center of collection icon
constrained description top to bottom of title, instead of share button to reduce empty space. (overlap with share button is already prevented by end constraint of description)
5 years ago
Michael Cooper
9646181343
[fenix] Add no-op experiment to test service-experiments integration ( https://github.com/mozilla-mobile/fenix/pull/4551 )
...
* Add no-op experiment to test service-experiments integration
* Shorten metric name to meet schema
* Add active_experiment metric to docs
* Add approved data review
5 years ago
Tiger Oakes
07eda357ba
[fenix] Use global navigation action for browser fragment ( https://github.com/mozilla-mobile/fenix/pull/4691 )
5 years ago
isabelrios
61e400c2d8
[fenix] Fix UI Screenshot TabMenuTest ( https://github.com/mozilla-mobile/fenix/pull/4730 )
5 years ago
Colin Lee
4987c40d67
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1667 : Screen reader can't reach other UI items when QAB expanded ( https://github.com/mozilla-mobile/fenix/pull/4695 )
5 years ago
Emily Kager
bf76cbe7e6
[fenix] No issue - Autoformatting ( https://github.com/mozilla-mobile/fenix/pull/4715 )
5 years ago
Sebastian Kaspari
c30700580c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4719 : Get rid of fragment-testing dependency and create fragments in StoreProviderTest manually. ( https://github.com/mozilla-mobile/fenix/pull/4722 )
5 years ago
Colin Lee
2de56210e2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4709 : Fix Bugzilla issue 1573549 ( https://github.com/mozilla-mobile/fenix/pull/4710 )
5 years ago
Sourabh
9c7caab6e3
[fenix] fix https://github.com/mozilla-mobile/fenix/issues/4633 : show toast only on first login ( https://github.com/mozilla-mobile/fenix/pull/4676 )
...
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
5 years ago
(´⌣`ʃƪ)
f292286006
[fenix] Fix https://github.com/mozilla-mobile/fenix/issues/4436 : hide onboarding before navigating to settings ( https://github.com/mozilla-mobile/fenix/pull/4675 )
...
* Fix https://github.com/mozilla-mobile/fenix/issues/4436 : hide onboarding before navigating to settings
* No issue: Rename emitAccountChanges to emitModeChanges
5 years ago
Sebastian Kaspari
4cba063e4e
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4431 : Integrate feature-media component (Nightly and debug builds only). ( https://github.com/mozilla-mobile/fenix/pull/4683 )
5 years ago
Colin Lee
de2b2a74c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4652 : HomeFragment Crash "Can not.. after onSaveInstanceState"
5 years ago
Jorge De Los Santos
3cfa2aff96
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3424 - Make talkback ignore ImageButton in Collection Sele… ( https://github.com/mozilla-mobile/fenix/pull/3792 )
...
For https://github.com/mozilla-mobile/fenix/issues/3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
5 years ago
Grisha Kruglov
caeb3477b9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4671 : Fix a potential NPE in BookmarkFragment
5 years ago
Grisha Kruglov
cd52df3314
[fenix] No issue: add some BookmarkFragmentInteractor tests
5 years ago
Grisha Kruglov
88db14a22f
[fenix] No issue: reduce code duplication in BookmarkFragmentInteractor
5 years ago
Christian Sadilek
9b956a3c42
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4125 : Suppress coroutine warning to fix release build
5 years ago
Sawyer Blatz
20b0c30640
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4123 : Adds telemetry for quick action open in app ( https://github.com/mozilla-mobile/fenix/pull/4629 )
5 years ago
Yeon Taek Jeong
ae90650052
[fenix] ktlint fix
5 years ago
Yeon Taek Jeong
b050218cd6
[fenix] Finish adding tests
5 years ago
Yeon Taek Jeong
6517ffed64
[fenix] Fix, add some tests
5 years ago
Yeon Taek Jeong
b190e9b80d
[fenix] Fix rest of issues
5 years ago
Yeon Taek Jeong
b3ef78f3cc
[fenix] Fix most issues
5 years ago
Yeon Taek Jeong
8391e933be
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4125 : Migrate Sign in to Sync to Libstate
5 years ago
Axel Hecht
059ee1671d
[fenix] Import strings from android-l10n ( https://github.com/mozilla-mobile/fenix/pull/4643 )
...
State: mozilla-l10n/android-l10n@ab580f757c
5 years ago
Colin Lee
9124321227
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4652 : Crash "Can not perform this action after onSaveInstanceState" ( https://github.com/mozilla-mobile/fenix/pull/4654 )
5 years ago
Jonathan Almeida
d544526692
[fenix] No issue: Disable failing ActivationPingTest
5 years ago
Tiger Oakes
025fc336b1
[fenix] Consodilate private browsing code
5 years ago
Jonathan Almeida
d3ff33d2d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4066 : Create InflationAwareFeature for lazy inflation
5 years ago
Colin Lee
45ec0682f5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4066 : Provide lazy inflation of Find In Page View
5 years ago
Sawyer Blatz
e4488b1909
[fenix] No issue: Removes deprecated usage of InstrumentationRegistry
5 years ago
Colin Lee
952926509c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4507 Enable codecov ( https://github.com/mozilla-mobile/fenix/pull/4520 )
5 years ago
Colin Lee
1d4952ddf1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4529 : Handle crash initializing CreateCollectionViewModel late ( https://github.com/mozilla-mobile/fenix/pull/4628 )
5 years ago
ValentinTimisica
9ce027a0a4
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4323 : Modified UI of component_collection_creation.
...
To fix the overlapping issue I used Guideline and
layout_constraintWidth_default property. I also used the
layout_constraintHorizontal_bias property to make the back_button to
lean to the left and the select_all_button to lean to the right.
5 years ago
Christian Sadilek
27b574d548
[fenix] Suppress warning in LeanplumMetricsService to fix release builds
5 years ago
Emily Kager
527b52ed71
[fenix] No issue: Update testing dependencies
5 years ago
Mathieu Leplatre
edc8182698
[fenix] Fix https://github.com/mozilla-mobile/fenix/issues/4612 : Fetch experiments from Remote Settings CDN
5 years ago
Colin Lee
1648fccc8c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4529 , https://github.com/mozilla-mobile/fenix/issues/4427 : Resuming after restoring instance state breaks UI ( https://github.com/mozilla-mobile/fenix/pull/4571 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4529 , https://github.com/mozilla-mobile/fenix/issues/4427 : Resuming after restoring instance state breaks UI
* Clear up warnings
5 years ago
Emily Kager
03e8f5b054
[fenix] No issue: Update testing dependencies and deprecated method ( https://github.com/mozilla-mobile/fenix/pull/4608 )
5 years ago
Sawyer Blatz
93a03e892e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4451 : Adds tests for DefaultBrowserToolbarController ( https://github.com/mozilla-mobile/fenix/pull/4493 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4451 : Adds tests for DefaultBrowserToolbarController
* Continue working
* Large refactoring of test
* Mock analytics
* Fix merge conflicts
5 years ago
Hakkı Kaan Çalışkan
9f5097b48c
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4562 : Add a-c git hash to about page
5 years ago
Emily Kager
2eedb1c015
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4602 - Add back transitions
5 years ago
Sawyer Blatz
c8fd7ba4cd
[fenix] Fixes feedback
5 years ago
Sawyer Blatz
364b14f2a7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3060 : Adds Leanplum attributes for fxa syncing
5 years ago
Sawyer Blatz
79dfd96a57
[fenix] No issue: Removes deprecated usage of ViewModelProviders
5 years ago
Yeon Taek Jeong
297e0520be
[fenix] Fix ktlint
5 years ago
Yeon Taek Jeong
ed4864ce35
[fenix] Remove task flags
5 years ago
Yeon Taek Jeong
dddc36e8ca
[fenix] Keep CLEAR_TASK
5 years ago
Yeon Taek Jeong
511b912a79
[fenix] Remove popBackStack
5 years ago
Yeon Taek Jeong
772fcc8f5d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4438 : Fix crash when opening any URL from URL bar w/ long press
5 years ago
Sawyer Blatz
e904bd867e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/969 : Adds more telemetry for collections ( https://github.com/mozilla-mobile/fenix/pull/4539 )
5 years ago
Tiger Oakes
664d6f2e81
[fenix] Minify the fenix
5 years ago
Sawyer Blatz
8bd4dc98d2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4508 : Treats warnings as errors ( https://github.com/mozilla-mobile/fenix/pull/4543 )
5 years ago
Grisha Kruglov
96f42368b3
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4467 : Use a-c version of FirefoxAccountsAuthFeature
5 years ago
ValentinTimisica
f65f57cfbb
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4354 : Updated SearchFragment state after returning from SearchEngineFragment.
...
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
5 years ago
Colin Lee
32ec775443
[fenix] No issue: Add OSS licenses link to About page
5 years ago
Sawyer Blatz
2d9475c23d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/969 : Finalizes collections telemetry ( https://github.com/mozilla-mobile/fenix/pull/4592 )
5 years ago
Richard Pappalardo
7ea855bda8
[fenix] Stub out tabs tests ( https://github.com/mozilla-mobile/fenix/pull/4573 )
5 years ago
Emily Kager
f7e64a1d0a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4026 - Update BookmarkDiffUtil to update on Title or URL change
5 years ago
Jeff Boek
b17a8b8091
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4557 https://github.com/mozilla-mobile/fenix/issues/3860 - Add string for collection empty state
5 years ago
Emily Kager
3e475940a9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/3939 - Adds strings for delete browsing history
5 years ago
Emily Kager
8b05867538
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1749 - Land ETP Strings
5 years ago
ValentinTimisica
8581ab5f6c
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/3922 : Added accessibility announcement for history empty state.
...
Sent an announcement when the list becomes empty in order to tell the user
that there is no history.
5 years ago
Tiger Oakes
c128f9bcc4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/1000 - Split out common browser functions
5 years ago
Emily Kager
f569fef876
[fenix] Fro https://github.com/mozilla-mobile/fenix/issues/4563 - Update delete button alpha when history mode changes
5 years ago
Tiger Oakes
9daf0c9542
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/2379 - Generic library selection
5 years ago
Emily Kager
ad16d1efcd
[fenix] No issue: Update UI tests with new engine shortcuts behavior ( https://github.com/mozilla-mobile/fenix/pull/4552 )
5 years ago
ekager
ae2474323e
[fenix] No issue: Removes focusableInTouchMode from home searchbar view
5 years ago
Yeon Taek Jeong
b7fa244d76
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1744 : Open search shortcuts when entering search mode ( https://github.com/mozilla-mobile/fenix/pull/4536 )
5 years ago
Emily Kager
2bbe72a7bd
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4540 - Set correct tint for select bookmark folder icon ( https://github.com/mozilla-mobile/fenix/pull/4541 )
5 years ago
Emily Kager
56fac45ca3
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4537 - Adds description for onboarding placeholder string ( https://github.com/mozilla-mobile/fenix/pull/4542 )
5 years ago
ekager
c85692808d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2021 - Update custom preferences' views with email/account changes
5 years ago
Travis Long
4d977e253e
[fenix] Integrate service-experiments component ( https://github.com/mozilla-mobile/fenix/pull/4098 )
5 years ago
Emily Kager
e72e0eb729
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4455 - Rename history headers by hours and days ( https://github.com/mozilla-mobile/fenix/pull/4478 )
5 years ago
Nikit Bhandari
8f5a167d2b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4530 Reduce build warnings ( https://github.com/mozilla-mobile/fenix/pull/4531 )
5 years ago
ekager
1034671723
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4495 - Clean up homescreen toolbar focus and content descriptions
5 years ago