Gabriel Luong
41ddc9226c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21888 - Use Hero images for Jump back in
3 years ago
Arturo Mejia
a529140c8d
[fenix] No issue update strings ids
3 years ago
AndiAJ
e62c814006
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18421 re-enable verifyContextCopyLink and verifyContextCopyImageLocation UI tests
3 years ago
Gabriel Luong
43d6e2234d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/top_site_title_text_light_theme redirection
3 years ago
Gabriel Luong
8aa133339d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/inset_dark_theme redirection
3 years ago
Gabriel Luong
7a0b6301d8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/top_site_title_text_dark_theme redirection
3 years ago
Gabriel Luong
10c1bbd3e7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/synced_tabs_separator_dark_theme redirection
3 years ago
Gabriel Luong
7b26640382
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/toggle_off_knob_light_theme and @color/toggle_off_track_light_theme redirection
3 years ago
Gabriel Luong
d5d302da69
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove redirection of color variables for the collection color variables
3 years ago
Gabriel Luong
6b38dd5259
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove redirection of color variables for the tabs tray color variables
3 years ago
Gabriel Luong
7a494b556a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/caption_text_dark_theme redirection
3 years ago
Gabriel Luong
57e117e9b1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/contrast_text_dark_theme redirection
3 years ago
Gabriel Luong
cbe4de50ad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/secondary_text_dark_theme redirection
3 years ago
Gabriel Luong
5408bc5178
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Use destructive_normal_theme in place of R.color.design_color
3 years ago
Mozilla L10n Automation Bot
a08a575365
[fenix] Import l10n.
3 years ago
Michael Comella
da44c15a49
[fenix] For https://github.com/mozilla-mobile/android-components/issues/11161 : pass profiler into AwesomeBar.
...
This will add two new markers:
- SuggestionFetcher.fetch
- Suggestion update
This is a profile with the markers: https://share.firefox.dev/3E4PbEk
3 years ago
AndiAJ
ba3f51814c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18421 fix and re-enable verifyContextShareLink, verifyContextSaveImage and verifyContextMixedVariations UI tests
3 years ago
Arturo Mejia
ecb13fa173
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22170 : Add telemetry for the auto-close prompt
3 years ago
Arturo Mejia
abb1c2631e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21906 ⁃ Update strings removal version
3 years ago
Mozilla L10n Automation Bot
22bfc8897a
[fenix] Import l10n.
3 years ago
Grisha Kruglov
ef375069eb
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22083 - Match history groups to history pages by all items within the group
...
When deciding if we should include a history group within the "page of
history" results on the History View UI, we used to look at the most
recent timestamp of the metadata items within the group, and see if that
falls within the range of the timestamps of the history page, +/- some
buffer.
This assumes that each metadata entry will have a corresponding history
item. However, that's not true - when restarting the app, the selected
tab will be restored, and when opening History View right after we'll
record some metadata for it. However, we won't record a history visit
during the app restore for the selected tab.
That's all correct, but the assumption around group matching to history is now incorrect.
This patch changes the logic to instead look at every item within the
group, and see if any of them match the time window of the current
history page. This has a side-effect of also displaying search groups
multiple times on diffenent pages of history, if it makes sense to do so chronologically.
I think that's fine, it reflects reality at least (e.g. items within the
group may have been visited at very different points in time).
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
Elise Richards
1de688e7d7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21313 : Renew metrics for December - never expire updates ( https://github.com/mozilla-mobile/fenix/pull/21788 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21313 : Renew metrics for December - never expire updates
* For https://github.com/mozilla-mobile/fenix/issues/21313 : data review
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Arturo Mejia
07742ec701
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22034 : Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
3 years ago
MickeyMoz
a68de609c2
[fenix] Update Android Components version to 95.0.20211026143215.
...
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
Gabriel Luong
b8bf426e4e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Call chain on collection type may be simplified
3 years ago
Gabriel Luong
d46da02cde
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Add package path to TabGroupViewHolder
3 years ago
Gabriel Luong
45e9bf6693
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unused symbols
3 years ago
Gabriel Luong
759194a625
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Class member can have 'private' visibility
3 years ago
Gabriel Luong
230536c9b7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Replace Java static method with Kotlin analog
3 years ago
Gabriel Luong
999f0ab3c1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Replace 'isEmpty' with 'ifEmpty'
3 years ago
Gabriel Luong
853e159476
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - 'protected' visibility is effectively 'private' in a final class
3 years ago
Gabriel Luong
71bfe46ac2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Local 'var' is never modified and can be declared as 'val'
3 years ago
Gabriel Luong
6be34a4023
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unused imports
3 years ago
Gabriel Luong
29dfb8ee7f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unnecessary type argument
3 years ago
Gabriel Luong
314d61d21e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unnecessary parentheses from function call with lambda
3 years ago
Gabriel Luong
cd77dbce96
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove redundant qualifier name
3 years ago
Gabriel Luong
5fbd63386d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove reductant SAM constructor
3 years ago
Gabriel Luong
4bcb6d7796
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove reductant 'suspend' modifier from SecurePrefsTelemetry
3 years ago
Gabriel Luong
2defb17c08
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove val from constructor parameter that are never used as a property
3 years ago
codrut.topliceanu
4b726e786b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21732 - Adds inactive tabs survey on disable + telemetry
3 years ago
Mugurell
6a5a2b842c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21933 - Refresh history items everytime the fragment is opened
3 years ago
Mozilla L10n Automation Bot
217570edff
[fenix] Import l10n.
3 years ago
Jonathan Almeida
a6d7128c7e
[fenix] No issue: Replace TabsTray.Tab with TabSessionState
...
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
Jonathan Almeida
a672d27ca6
[fenix] No issue: Disable FenixSnackbarDelegateTest intermittents
3 years ago
Michael Droettboom
7d5bac64d4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21025 : Set long term business-critical metrics as non-expiring ( https://github.com/mozilla-mobile/fenix/pull/21038 )
...
* Set long term business-critical metrics as non-expiring.
* Remove quotes around "never"
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
AndiAJ
8daaca51af
[fenix] Use identifiers instead of hard coded strings
3 years ago
AndiAJ
eaed414831
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21747 re-enable start on homepage UI test and refactoring work
3 years ago
AndiAJ
20541aab38
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21754 re-enable general settings UI test and refactoring work
3 years ago
AndiAJ
7a4658627e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21004 fix and refactor verifyBasicNavigationToolbarFunctionality UI test
3 years ago
Roger Yang
0c5e1f3442
[fenix] No issue: Add external load flag
3 years ago
Sebastian Kaspari
6f4c47613a
[fenix] Update Kotlin and Jetpack Compose versions.
3 years ago
Oana Horvath
775929a293
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21628 : catch ComposeNotIdleException
3 years ago
Arturo Mejia
8a2df4be14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21986 Confirmation when people set tabs to auto-close
...
For https://github.com/mozilla-mobile/fenix/issues/22034 Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
3 years ago
Mayank Agarwal
af4a03a0f3
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21714 : Login button visibility fix on saved logins page
3 years ago
Mugurell
bf76a1871c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21771 - Show url when recent tab's title is not available
...
This is the same previously used approach and the same used for tabs tray.
3 years ago
Mozilla L10n Automation Bot
b566e3ed7f
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
e7695f25ef
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
3516c38f1f
[fenix] Import l10n.
3 years ago
Michael Comella
2a52bffeae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 - post: switch generic marker skip to BaseBrowserFragment.
...
Since we instrument the marker with the duration in BaseBrowserFragment,
we should skip on BaseBrowserFragment too, not its subclass,
BrowserFragment.
3 years ago
Michael Comella
1336a4f72d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : add duration for some BrowserFragment lifecycle markers.
...
Here is a sample profile with all the new markers:
https://share.firefox.dev/3lCGoD2
3 years ago
Michael Comella
9926c27e43
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : add durations for some HomeFragment lifecycle markers.
3 years ago
Michael Comella
9a784f8484
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : add and register MarkersFragmentLifecycleCallbacks.
3 years ago
Michael Comella
91e7121fa8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : rename MarkersLifecycleCallbacks to ...ActivityLifecycle...
...
This is to disamibugate with the MarkersFragmentLifecycleCallbacks that
we'll be adding.
3 years ago
Michael Comella
2f7d5c03f6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22054 : add marker for root view layout/measure.
...
The onLayout marker may be redundant to onGlobalLayout marker but I'm not
sure yet so let's leave them both in and observe if that's the case.
Here's a profile with the markers: https://share.firefox.dev/3lZaOQb
3 years ago
Oana Horvath
888e9365cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22095 : fix intermittent click failure in verifyRateOnGooglePlayRedirect UI test
3 years ago
Mugurell
fe8c112513
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22070 - Prevent crash for when a selected topic does not exist anymore
...
The list of selected topics overwrites old data whenever user selects or
deselects another so the old selections will not leak for long.
3 years ago
Roger Yang
593b08780f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22061 : Let TabSorter decide if title header should be shown in tabs tray
3 years ago
Mozilla L10n Automation Bot
d09f8d1a00
[fenix] Import l10n.
3 years ago
Roger Yang
53db79d50e
[fenix] No issue: Only report telemetry when tabs tray is first opened
3 years ago
Mugurell
18127e2f5d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21841 - New telemetry for Google and Baidu top sites removal
3 years ago
Michael Comella
ad1bcec0d9
[fenix] No issue - post: fix ProfilerMarkerFactProcessor tests.
3 years ago
Michael Comella
8fc6c5952f
[fenix] No issue: use Fact.value as detailText for markers.
...
This allows Facts emitted from ac to provide more details in markers.
3 years ago
Michael Comella
9688a90c29
[fenix] No issue: cache SearchDialogFragment.InlineAutocompleteEditText.
...
Assuming the InlineAutocompleteEditText is not being recreated (and I
did not verify this), it's unnecessary to traverse the view hierarchy
to find it more than once so this patch removes the unnecessary
traversals.
3 years ago
Oana Horvath
e17721e795
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20754 : fix intermittent click failure in verifyAboutFirefoxPreview test
3 years ago
Andrei Joltan
99988cd74f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22065 fix flaky privateTabsTrayWithOpenedTabTest UI test ( https://github.com/mozilla-mobile/fenix/pull/22068 )
...
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
3 years ago
AndiAJ
c4bce2422e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21207 fix flaky updateSavedLoginTest UI test
3 years ago
Mozilla L10n Automation Bot
231ee9a9c3
[fenix] Import l10n.
3 years ago
Gabriel Luong
2e7f52f63a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22022 - Composify Customize Home Button and update the background color
3 years ago
Gabriel Luong
f3f8f717f5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22022 - Update SelectableChip button background colors
3 years ago
xlog-null
6f80d2871f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22032 - Fix horizontal margin on private home screen
3 years ago
Gabriel Luong
2c4ccea6cd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21753 - Refactor Pocket out of sessioncontrol
3 years ago
Noah Bond
1c21e2face
[fenix] MR2 Inactive tabs telemetry ( https://github.com/mozilla-mobile/fenix/pull/21908 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added telemetry for interacting with inactive tabs
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added missing inactive tab delete count event to delete all event
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added PR numbers to metrics
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated broken unit tests. Resolved critical lint warning.
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Fixed inactive tabs setting toggle metric
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated FenixApp unit test
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated newline character in Metrics. Set inactive tab metrics' lifetime to default. Updated expiration to Nov 2022. Refactored inactive tabs metric to be a single metric.
* PR: addendum for last commit that missed a file
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Changed logic check for reporting inactive tab count
* PR: fixed merge conflict
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed tab close tracking when the user closes ALL inactive tabs
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed individual tab close metric verify from CLOSE ALL test
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated inactive tabs toggle setting expiration to match the expiration of the other events
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Gabriel Luong
e8cd66b619
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue40 in place of #0090ED
3 years ago
Gabriel Luong
e7f6b6fc14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey20 in place of https://github.com/mozilla-mobile/fenix/pull/4A4A55
3 years ago
Gabriel Luong
0abac59277
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPink30 in place of #FF6BBA
3 years ago
Gabriel Luong
f928428f5b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue30 in place of #00B3F4
3 years ago
Gabriel Luong
c3d86f8dc5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet30 in place of #C689FF
3 years ago
Gabriel Luong
1a01f638c0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow90 in place of https://github.com/mozilla-mobile/fenix/issues/960E18
3 years ago
Gabriel Luong
4783442368
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonRed40 in place of #FF6A75
3 years ago
Gabriel Luong
98dd4016ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey50 in place oof #32313C
3 years ago
Gabriel Luong
521b564fd0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue50 in place of #0060DF
3 years ago
Gabriel Luong
a77c5b8fad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonGreen70 in place of #.008787
3 years ago
Gabriel Luong
18a9ffed66
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonInk20 in place of https://github.com/mozilla-mobile/fenix/pull/312A64
3 years ago
Gabriel Luong
013530110e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet50 in place of https://github.com/mozilla-mobile/fenix/issues/9059ff
3 years ago
Gabriel Luong
2e762f0327
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow70 in place of #C45A27
3 years ago
Gabriel Luong
9a901e0cff
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow60 in place of #E27F2E
3 years ago
Gabriel Luong
453c6f9f8d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonGreen60 in place of https://github.com/mozilla-mobile/fenix/pull/2AC3A2
3 years ago
Gabriel Luong
e5a197c402
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPink60 in place of #E31587
3 years ago
Gabriel Luong
bfce9bc796
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey90 in place of https://github.com/mozilla-mobile/fenix/issues/15141A
3 years ago
Gabriel Luong
a8cdbb4524
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet40 in place of #AB71FF
3 years ago