Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-02 03:40:16 +00:00
Code Issues Releases Wiki Activity
5,652 Commits 67 Branches 113 Tags 1.2 GiB
04495bb1cc
Commit Graph

4816 Commits

Author SHA1 Message Date
Christian Sadilek
70852916d6 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16430: ExternalAppBrowserActivity should not handle incoming intents 2020-11-09 09:29:55 +01:00
mozilla-l10n-automation-bot
3ab61bec1b [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/16441) 2020-11-06 19:48:10 -05:00
Mihai Adrian Carare
489e8cc970 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15764 - Update Tabs summary description. (https://github.com/mozilla-mobile/fenix/pull/16428) 2020-11-06 17:30:59 -05:00
Christian Sadilek
0ccff38ebc [fenix] Update Android Components version to 66.0.20201106143126 (https://github.com/mozilla-mobile/fenix/pull/16439) 2020-11-06 17:22:46 -05:00
Oana Horvath
2748519959 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15847: use Espresso's RecyclerView scrollTo action 2020-11-06 15:28:31 +02:00
Mozilla L10n Automation Bot
77cfcd82c3 [fenix] Import l10n. 2020-11-06 14:19:41 +01:00
Christian Sadilek
80e9e1fa8e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16327: Refactor MenuPresenter to use browser store 2020-11-05 16:45:10 -05:00
Arturo Mejia
8cc09b5785 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/15934 fix ConcurrentModificationException 
on WifiConnectionMonitor
 2020-11-05 14:24:37 -05:00
Sebastian Kaspari
84770f1f64 [fenix] Fix GeckoProvider for beta and release variant. 2020-11-05 14:23:25 -05:00
rxu
3ec2a3d971 [fenix] Add mozcn safebrowsing 2020-11-05 18:02:30 +01:00
Michael Comella
c481d0504b [fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 - review: set LazyMonitored to private. 2020-11-05 07:48:17 -08:00
Michael Comella
17b32070dd [fenix] For https://github.com/mozilla-mobile/fenix/issues/15279: add component init count to StartupExcessiveResourceUseTest. 2020-11-05 07:48:17 -08:00
Michael Comella
7ac4b40fa8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15279: remove redundant lazy wrapper from storage APIs. 
They're currently lazy { lazy { value } }. Accessing `lazy.value`
directly allows us to make it lazy { value }. This should be more
performant and prevents us from double-counting these components.
 2020-11-05 07:48:17 -08:00
Michael Comella
9e8fd7c6f0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15279: LazyMonitored implement Lazy + update built-in API use. 
By having LazyMonitored implement Lazy, we can continue to pass these
values directly into the ac APIs that require Lazy references. For some
reason, implementing `Lazy.value` can replace `operator fun getValue`
required for delegates.
 2020-11-05 07:48:17 -08:00
Michael Comella
3879697c06 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15279: replace lazy with lazyMonitored in component groups. 
By component groups, I mean I applied this to any class with the
class kdoc, "Component group for...".

There are a few instances of lazy we had to keep using the old API to
avoid having to update constructor arguments.
 2020-11-05 07:48:17 -08:00
Michael Comella
07e69195f2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15279: add LazyMonitored and tests. 2020-11-05 07:48:17 -08:00
mozilla-l10n-automation-bot
83cf8baedf [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/16380) 2020-11-04 18:58:23 -08:00
Kate Glazko
88375a2294 [fenix] For https://github.com/mozilla-mobile/fenix/issues/352: Delete a download 2020-11-04 13:32:24 -08:00
ekager
5344dceead [fenix] No issue: Update stable androidx and material versions 2020-11-04 12:00:32 -08:00
Mugurell
f3d5862668 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6521 - Remove auto sigin onboarding card (https://github.com/mozilla-mobile/fenix/pull/16315) 
With the Fennec -> Fenix migration complete there is no other Mozilla
application that would serve as a custom account provider hence the automatic
signin would not be possible.
Make this more obvious by commenting out the code that would trigger an
onboarding banner for it but keep the code in the app for when https://github.com/mozilla-mobile/fenix/issues/15694 would add
to Fenix the ability to serve as a custom account provider.
 2020-11-04 17:23:19 +02:00
Mugurell
0a8d8cfbf0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/16323 - Use 10dp corner radius for the selected outer border of a grid item (https://github.com/mozilla-mobile/fenix/pull/16364) 
This would ensure the corners of the inner and outer borders are aligned, with
no empty gap between them.
 2020-11-04 10:03:43 -05:00
Mugurell
2f04b48e7c [fenix] For https://github.com/mozilla-mobile/fenix/issues/14980 - Effectively disable tabs tray STATE_HALF_EXPANDED (https://github.com/mozilla-mobile/fenix/pull/16052) 
STATE_HALF_EXPANDED cannot be disabled while also keeping fitToContents = true
based on which the tabs tray layout is currently set.
To work around this we'll set a a minuscule height for the tab tray when in
this state and then immediately advance to STATE_HIDDEN so to make it
imperceptible to the users.
Since I couldn't write unit tests because of InflateExceptions in Robolectric
I've written UI tests to protect against regressions.
 2020-11-04 11:22:46 +02:00
Mihai Adrian Carare
647117ca54 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13172 - Tab swipe order follows text direction from oldest to newest (https://github.com/mozilla-mobile/fenix/pull/16178) 2020-11-03 15:48:00 -05:00
Rafał Opiłowski
7dab7b2d53 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12971 - Show collection saved snackbar above FAB (https://github.com/mozilla-mobile/fenix/pull/16311) 2020-11-03 15:45:23 -05:00
Oana Horvath
24d2b31b74 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15847 - Disables verifyAboutFirefoxPreview UI test (https://github.com/mozilla-mobile/fenix/pull/16346) 2020-11-03 15:31:36 -05:00
Mugurell
5311233fae [fenix] For https://github.com/mozilla-mobile/fenix/issues/16339 - Initialize FxaAccountManager with also a CrashReporter (https://github.com/mozilla-mobile/fenix/pull/16340) 2020-11-03 14:46:08 +02:00
Sebastian Kaspari
03343e86ed [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16256: Introduce build flag for "Mozilla Online" variant. 
This patch introduces a build flag that can be used on demand on the command line (`./gradlew -PmozillaOnline [..}`) or
permanently when added to local.properties (`mozillaOnline`).

At runtime `Config.channel.isMozillaOnline` will return `true` if the flag was set at build time.
 2020-11-03 10:34:25 +01:00
Oana Horvath
4fe05cc97c [fenix] For https://github.com/mozilla-mobile/fenix/issues/13446 UI tests: wait for historyList to exist 2020-11-03 10:59:33 +02:00
Mozilla L10n Automation Bot
9007d8d33e [fenix] Import l10n. 2020-11-02 19:44:47 -08:00
Gabriel Luong
ba18f60d64 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14636 - Update preference section headers to use correct color, spacing and rulers (https://github.com/mozilla-mobile/fenix/pull/16332) 2020-11-02 19:56:41 -05:00
Michael Comella
b495ffee53 [fenix] No issue - review: clarify thread safety of suppressionCount. 2020-11-02 15:37:04 -08:00
Michael Comella
6fed5f3177 [fenix] No issue: make StrictMode suppression count thread safe. 2020-11-02 15:37:04 -08:00
Christian Sadilek
ecd79c4d6e [fenix] For https://github.com/mozilla-mobile/fenix/issues/12062: Switch to consumeFlow and add tests 2020-11-02 14:23:33 -08:00
ekager
5991d0996e [fenix] For https://github.com/mozilla-mobile/fenix/issues/4652 - Remove activityViewModels workarounds 2020-11-02 11:30:37 -08:00
MarcLeclair
78850c7e3d [fenix] 15278 detekt rule runblocking (https://github.com/mozilla-mobile/fenix/pull/15942) 
* For https://github.com/mozilla-mobile/fenix/issues/15278: added CoroutineManager to count runBlocking calls

* For https://github.com/mozilla-mobile/fenix/issues/15278: Added actual detekt rule for runblocking and its config to the yaml

* For https://github.com/mozilla-mobile/fenix/issues/15278: Added unit test for RunblockingCounter

* For https://github.com/mozilla-mobile/fenix/issues/15278: renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test

* Lint fix

* For https://github.com/mozilla-mobile/fenix/issues/15278: made runblocking a Long to prevent overflow

* For https://github.com/mozilla-mobile/fenix/issues/15278: fixed MozRunblocking name, description and moved RunBlockingCounter to perf package

* For https://github.com/mozilla-mobile/fenix/issues/15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck

* For https://github.com/mozilla-mobile/fenix/issues/15278: Added setup for unit test, since it failed without restting counter

* For https://github.com/mozilla-mobile/fenix/issues/15278: Fixed naming for RunBlocking lint check

* For https://github.com/mozilla-mobile/fenix/issues/15278: removed changes made to test to use runBlockingIncrement

* For https://github.com/mozilla-mobile/fenix/issues/15728: added test exclusion for runBlocking check

* For https://github.com/mozilla-mobile/fenix/issues/15278: changed null check and added Synchronized to count setter

* For https://github.com/mozilla-mobile/fenix/issues/15278: fix for nits

* For https://github.com/mozilla-mobile/fenix/issues/15278: added StartupExcessiveResourceUseTest to CODEOWNERS

* For https://github.com/mozilla-mobile/fenix/issues/15278: fixed for nits

* For https://github.com/mozilla-mobile/fenix/issues/15278: Moved increment function to extension function and fixed indentation

* For https://github.com/mozilla-mobile/fenix/issues/15278: Added tests for Atomic Integer extension and nit fix
 2020-11-02 12:49:17 -05:00
ekager
e564dda990 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6313 - Remove unneeded delay in BrowserAnimator 2020-11-02 09:38:15 -08:00
Roger Yang
f60df4a976 [fenix] For https://github.com/mozilla-mobile/fenix/issues/16268 - Allowing multiple task while sharing (https://github.com/mozilla-mobile/fenix/pull/16275) 2020-11-02 11:16:29 -05:00
Jocelyne Abi Haidar
3139337d7f [fenix] For https://github.com/mozilla-mobile/fenix/issues/15931: Sort Downloads from newest to oldest (https://github.com/mozilla-mobile/fenix/pull/15939) 2020-11-02 11:06:30 -05:00
mcarare
e682cb55cc [fenix] For https://github.com/mozilla-mobile/fenix/issues/15430: Fix StrictMode death on opening app from widget voice search. 2020-11-02 15:50:12 +02:00
mcarare
c66ab231d5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15430: Fix StrictMode death on opening app from widget text search. 2020-11-02 15:50:12 +02:00
mcarare
87ce122d03 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14552: Do not display back button when there is no tab history. 2020-11-02 14:25:49 +02:00
Mozilla L10n Automation Bot
a94eca1063 [fenix] Import l10n. 2020-11-02 00:12:21 -05:00
Mugurell
b85522198c [fenix] For https://github.com/mozilla-mobile/fenix/issues/15963 - Increase touch target for the close button in the tabs tray grid layout 
We need to ensure it has at least 48dp while also not appearing too big.
 2020-10-30 18:13:50 -04:00
Mugurell
58a22af103 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15757 - Avoid the double spacing issues for grid items in tabs tray 
Items should have a 16dp all around padding.
Have them have a 8dp padding that will add to 16 when placed together.
Have the parent have another 8dp that will add to 16 for when items are placed
to the edge of the available screen.
 2020-10-30 18:13:50 -04:00
Mugurell
0dd114beb8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15968 - Show a border for the selected tab in the grid based tabs tray 
The border for the grid item will now be updated in the same method that
updates the background for the list item.
 2020-10-30 18:13:50 -04:00
Mugurell
f90db55a2f [fenix] For https://github.com/mozilla-mobile/fenix/issues/15756 - Add a play/pause button in the tabs tray grid layout 
Moved the previous layout in a new, bigger FrameLayout that would serve as a
buffer space for the play/pause button to be translated to the exterior.
Otherwise the button would be clipped.
 2020-10-30 18:13:50 -04:00
Gabriel Luong
949d66da5f [fenix] For https://github.com/mozilla-mobile/fenix/issues/9548 - Ability to rename top sites (https://github.com/mozilla-mobile/fenix/pull/16285) 
* Ability to rename top sites, closes https://github.com/mozilla-mobile/fenix/issues/9548

* Highlight the "Remove" top site action as destructive

With more menu items in the top site contextual menu, it makes sense to differentiate

* Added test for the top site renaming action

* Fixed lint check (wildcard imports, blank spaces)

* Applied suggestions from code review

* Apply suggestions from code review

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>

* Implemented dialog click listener with manual dismiss/cancel

Co-authored-by: Lorenzo Stanco <lorenzo.stanco@gmail.com>
 2020-10-30 15:08:04 -04:00
ekager
c4d7e19da6 [fenix] No issue: Make sure we are cleaning up test coroutines 2020-10-29 18:57:23 -07:00
mozilla-l10n-automation-bot
0a9821fdbb [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/16274) 2020-10-29 21:40:40 -04:00
ekager
986e28f100 [fenix] For https://github.com/mozilla-mobile/fenix/issues/16161 - Fixes Saved Login toolbar layout 2020-10-29 16:10:06 -07:00
Codrut Topliceanu
2d083e853a [fenix] For https://github.com/mozilla-mobile/fenix/issues/14637 - Fix sitePermissionsFeature breaking change + AC bump (https://github.com/mozilla-mobile/fenix/pull/16229) 
* For https://github.com/mozilla-mobile/fenix/issues/14637 - Compatibility patch for AC - 8554

* Update Android Components version to 65.0.20201029143039

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2020-10-29 19:08:31 -04:00
mozilla-l10n-automation-bot
f15d1054bb [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/16240) 2020-10-29 10:42:14 -04:00
mcarare
3047ea3601 [fenix] For https://github.com/mozilla-mobile/fenix/issues/16250: Disable remote USB debugging for SDK <23. 2020-10-29 15:02:02 +01:00
Mihai Adrian Carare
5fb5471df1 [fenix] For # 15929: Remove the search widget discoverability experiment. (https://github.com/mozilla-mobile/fenix/pull/16081) 
* For https://github.com/mozilla-mobile/fenix/issues/15929: Remove SearchWidgetCFR telemetry.

* For https://github.com/mozilla-mobile/fenix/issues/15929: Remove SearchWidgetCFR and search widget experiment.

* For https://github.com/mozilla-mobile/fenix/issues/15929: Remove unit tests references to search widget experiment.
 2020-10-28 13:46:02 -07:00
mcarare
51018be388 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15413: Use proper url when bookmarking a page. 2020-10-28 16:33:48 +02:00
Oana Horvath
0f70a8d4fc [fenix] For https://github.com/mozilla-mobile/fenix/issues/10690: re-enable editBookmarkTest 2020-10-28 16:09:52 +02:00
Mozilla L10n Automation Bot
29e7f50cc3 [fenix] Import l10n. 2020-10-28 10:54:41 +01:00
Arturo Mejia
df0da31c1f [fenix] Fix AddonsManagementFragment detekt error 2020-10-27 19:23:32 -04:00
Christian Sadilek
79ab29eff2 [fenix] No issue: Fix onConfigurationChange crashes in Debug build 2020-10-27 18:54:07 -04:00
Christian Sadilek
56c98b57b8 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/11285: Replace Session[Manager] observers in BaseBrowserFragment 2020-10-27 17:40:58 -04:00
Grisha Kruglov
268da65b3f [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15816 - Attempt to handle 'allowInPrivate..' pref with detached context 2020-10-27 16:18:19 -04:00
mcarare
047b712ffe [fenix] For https://github.com/mozilla-mobile/fenix/issues/15379: Use proper url when sharing. 2020-10-27 14:15:56 -04:00
ekager
647e73e851 [fenix] For https://github.com/mozilla-mobile/fenix/issues/16199 - Don't pass BrowserToolbarView in onStart when we just need parent 2020-10-27 09:13:13 -07:00
Arturo Mejia
d3faecd59c [fenix] Fix add-on translation braking changes 2020-10-27 11:33:18 -04:00
Aaron Train
a224f0c546 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8169 - Upgrade Mockwebserver (https://github.com/mozilla-mobile/fenix/pull/16186) 
Upgrades Mockwebserver to 4.9.0
 2020-10-27 10:19:24 -04:00
mozilla-l10n-automation-bot
b28b69915e [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/16198) 2020-10-26 20:28:45 -04:00
Lorenzo Stanco
bd068b288a [fenix] For https://github.com/mozilla-mobile/fenix/issues/16122 - Add a dark theme color for the top sites pin icon (https://github.com/mozilla-mobile/fenix/pull/16180) 2020-10-26 18:50:41 -04:00
mozilla-l10n-automation-bot
aba1e64d9a [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/16163) 2020-10-26 12:07:02 -04:00
mozilla-l10n-automation-bot
bb2a8acb16 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/16154) 2020-10-23 22:18:34 -04:00
ekager
f3d03c5e73 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6313 - Set session ClearColor through Engine DefaultSettings 2020-10-22 20:36:04 -07:00
mozilla-l10n-automation-bot
18012e4cfc [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/16138) 2020-10-22 23:12:05 -04:00
Jocelyne Abi Haidar
089fe7a9fd [fenix] For https://github.com/mozilla-mobile/fenix/issues/15508: Show error when trying to save empty or invalid bookmark URL (https://github.com/mozilla-mobile/fenix/pull/15674) 2020-10-22 17:22:37 -04:00
mozilla-l10n-automation-bot
6cd2d75989 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/16108) 2020-10-21 21:01:50 -04:00
Mugurell
ebcb172781 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15543 - Adjust the height of the tabs tray depending on the number of tabs (https://github.com/mozilla-mobile/fenix/pull/15749) 2020-10-21 19:21:37 -04:00
ekager
6ff5ec846b [fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 - Feature Flag return to browser (https://github.com/mozilla-mobile/fenix/pull/16099) 2020-10-21 16:29:06 -04:00
ekager
f8d0a97210 [fenix] For https://github.com/mozilla-mobile/fenix/issues/16084 - Match elevation of Tab in Collection to header (https://github.com/mozilla-mobile/fenix/pull/16100) 2020-10-21 15:47:25 -04:00
ekager
29a179e8c3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15910 - Adds back automatic toggle, disables slider when enabled (https://github.com/mozilla-mobile/fenix/pull/16070) 2020-10-21 12:20:04 -04:00
Arturo Mejia
5070c12a7b [fenix] For https://github.com/mozilla-mobile/fenix/issues/16019 - Fix intermittent test failure TrackingProtectionPolicyFactoryTest (https://github.com/mozilla-mobile/fenix/pull/16056) 2020-10-21 10:25:25 -04:00
mcarare
7f82d5e052 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14619: Show half a tab top offset when scrolling to selected tab. 2020-10-21 13:31:59 +03:00
mozilla-l10n-automation-bot
d3cb8d03f0 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/16074) 2020-10-20 20:41:54 -04:00
Mugurell
ebcf7ea907 [fenix] For https://github.com/mozilla-mobile/fenix/issues/16054 - Enable pull to refresh webpage in Nightly and Debug (https://github.com/mozilla-mobile/fenix/pull/16060) 2020-10-20 20:41:14 -04:00
Elise Richards
11e73eebfa [fenix] For https://github.com/mozilla-mobile/fenix/issues/15080: Handle default search engine when editing or removing (https://github.com/mozilla-mobile/fenix/pull/15768) 2020-10-20 16:00:00 -07:00
Juan C. Goncalves
a3fce6b92d [fenix] For https://github.com/mozilla-mobile/fenix/issues/11397 - Add lint rule for AppCompatResources instead of ContextCompat (https://github.com/mozilla-mobile/fenix/pull/16011) 2020-10-20 13:23:43 -07:00
Sebastian Kaspari
09efe75e27 [fenix] FennecWebAppIntentProcessor: Catch JSONException. 2020-10-20 15:46:18 +02:00
Mihai Adrian Carare
274ab54236 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11631: Move report site issue extension to main menu. (https://github.com/mozilla-mobile/fenix/pull/15884) 
* For https://github.com/mozilla-mobile/fenix/issues/11631: Move report site issue extension to main menu.

* For https://github.com/mozilla-mobile/fenix/issues/11631: Update UI test for installing add-on.
 2020-10-20 09:34:54 +03:00
Tom Klein
85d7bb0baf [fenix] For https://github.com/mozilla-mobile/fenix/issues/15480 - Update the UI when a collection is renamed 2020-10-19 19:32:11 -07:00
mcarare
d7c63a63c6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15688: Update UI tests. 2020-10-19 17:45:46 -07:00
mcarare
0c48e945f7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15688: Update unit tests. 2020-10-19 17:45:46 -07:00
mcarare
ff595c7854 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15688: Navigate to home screen with arguments on new tab action. 2020-10-19 17:45:46 -07:00
Mozilla L10n Automation Bot
a9e3cb974b [fenix] Import l10n. 2020-10-19 17:37:17 -07:00
Sebastian Kaspari
9c7e0ad770 [fenix] Update Android Components, Kotlin, Gradle plugin (https://github.com/mozilla-mobile/fenix/pull/16021) 
* Closes https://github.com/mozilla-mobile/fenix/issues/13262: Update AGP to 4

* Update to Mozilla Android Components 63.0.20201019090011.

* Update Kotlin to 1.4.10 and Coroutines to 1.3.9.

* Fix new compiler warnings.

* Fix compilation of lint rules module.

* Pin JNA version.

* Fix new lint errors.

Co-authored-by: Tiger Oakes <toakes@mozilla.com>
 2020-10-19 14:07:47 -04:00
Mihai Adrian Carare
b931723651 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14744: Also show Fill link from clipboard with search shortcuts. (https://github.com/mozilla-mobile/fenix/pull/15885) 2020-10-19 13:58:54 -04:00
Christian Sadilek
5c9e32efda [fenix] Configure M5 AMO collection for all builds 2020-10-19 11:19:47 -04:00
mozilla-l10n-automation-bot
b763fd4449 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/16014) 2020-10-18 23:26:52 -04:00
mozilla-l10n-automation-bot
0e83246501 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/16001) 2020-10-17 21:54:08 -04:00
mozilla-l10n-automation-bot
0a5089879a [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/15986) 2020-10-17 09:41:31 -04:00
Gabriel Luong
d1e5785dad [fenix] For https://github.com/mozilla-mobile/fenix/issues/15796 - Use the device locale for the system locale subtitle (https://github.com/mozilla-mobile/fenix/pull/15975) 2020-10-17 09:40:28 -04:00
Gabriel Luong
36ab249924 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15937 - Remove topFrecentSite feature flag (https://github.com/mozilla-mobile/fenix/pull/15967) 
* For https://github.com/mozilla-mobile/fenix/issues/15937 - Remove the topFrecentSite feature flag

* For https://github.com/mozilla-mobile/fenix/issues/15937 - Hide the "Pull to refresh" preference since its visibility is managed by a feature flag
 2020-10-16 18:37:27 -07:00
ekager
b7cb6aa53c [fenix] For https://github.com/mozilla-mobile/fenix/issues/7345 - Update new shield icons, remove lottie (https://github.com/mozilla-mobile/fenix/pull/15909) 2020-10-16 16:01:38 -07:00
Christian Sadilek
8ec056ffb9 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/11286: Add TelemetryMiddleware to remove Session[Manager] observers 2020-10-16 11:05:34 -07:00
Gabriel Luong
96e38a14eb [fenix] For https://github.com/mozilla-mobile/fenix/issues/15796 - show device language under follow device language (https://github.com/mozilla-mobile/fenix/pull/15966) 2020-10-16 12:47:56 -04:00
amkcpu
37f4575e58 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10683: Show longer tab titles 
Also update tab tray item layout according to specs posted in the issue.
 2020-10-16 15:50:29 +03:00
mozilla-l10n-automation-bot
6d9480ec2d [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/15945) 2020-10-15 17:29:04 -07:00
Jeff Boek
81556c956a [fenix] For https://github.com/mozilla-mobile/fenix/issues/15596 - Removes upgrade faq link from fennec builds (https://github.com/mozilla-mobile/fenix/pull/15643) 2020-10-15 15:02:51 -07:00
Gabriel Luong
19b4a4ef5b [fenix] For https://github.com/mozilla-mobile/fenix/issues/14922: Use padding instead of margin to use the full screen width for the "Add search engine" button 2020-10-15 16:09:13 -04:00
mcarare
5348bed401 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14922: Adjust margins for add search engine preference. 2020-10-15 16:09:13 -04:00
mcarare
30bd0ed572 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14922: Add divider above address bar preferences. 2020-10-15 16:09:13 -04:00
mcarare
fcbe467703 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15898: Add dividers above subheadings in tabs screen. 2020-10-15 13:13:52 -04:00
mcarare
ee99347d3d [fenix] For https://github.com/mozilla-mobile/fenix/issues/15898: Add dividers above subheadings in customise screen. 2020-10-15 13:13:52 -04:00
Michael Comella
0a83eb56f4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15644: add comment for why we set the app theme in test. 2020-10-15 09:53:13 -07:00
Michael Comella
aa19f541b2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15644: change apply to with in GleanMetricsService. 
While the callback receiver is identical in these two methods, they're
semantically different: apply is for initializing the receiver while with
is anything else benefiting from a new `this` receiver.

I didn't change the usage of apply that has a return statement because I
was afraid my change might change behavior.
 2020-10-15 09:53:13 -07:00
Michael Comella
910b7f19aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/15644: mock package inspection dependencies in GleanMetricsService. 
The new robolectric version changed the behavior such that the app ID
that was returned for our app was `org.mozilla.fenix.debug` instead of
(I guess) `org.mozilla.fenix`. In general, relying on robolectric can be
fragile, such as this case, so it's better to mock. Also, this test
behavior should theoretically have varied between build flavors so
mocking prevents the tests from breaking across flavors.
 2020-10-15 09:53:13 -07:00
ekager
69a126cbb6 [fenix] Sets theme in FenixRobolectricTestApplication onCreate 2020-10-15 09:53:13 -07:00
Michael Comella
7cc54078d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15644: escalate many Performance check severity in lint.xml. 
I exhaustively looked through the list of checks labeled performance and
marked them accordingly. To see all lint checks, type:
  <android-sdk>/tools/bin/lint --show
 2020-10-15 09:53:13 -07:00
Michael Comella
106a36bcdc [fenix] For https://github.com/mozilla-mobile/fenix/issues/15644: remove unnecessary lint ignore. 2020-10-15 09:53:13 -07:00
Michael Comella
fec7662d8e [fenix] For https://github.com/mozilla-mobile/fenix/issues/15644: escalate InefficientWeight to error. 
All violations of this type were addressed in the previous commit.
 2020-10-15 09:53:13 -07:00
ekager
74b4866e3d [fenix] Fixes existing lint errors 2020-10-15 09:53:13 -07:00
Gabriel Luong
ef60d82caa [fenix] For https://github.com/mozilla-mobile/fenix/issues/15907 - Remove the usage of the TabTrayGridItemDecorator 2020-10-15 10:02:07 -04:00
ekager
9d876a7076 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15347 - Adds telemetry for tabs settings 2020-10-14 22:53:31 -04:00
ekager
9f67b3df9b [fenix] fix detekt errors 2020-10-14 18:22:02 -07:00
Sebastian Kaspari
3368ddce5c [fenix] Use new SearchEngineProvider interface. 2020-10-14 18:22:02 -07:00
Mozilla L10n Automation Bot
d064b26fc0 [fenix] Import l10n. 2020-10-14 17:49:27 -07:00
Michael Comella
2b368b4bff [fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 - review: add license to lint-baseline.xml. 2020-10-14 15:20:28 -07:00
Michael Comella
30208f0345 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15280: add current ConstraintLayout warnings to lint baseline. 2020-10-14 15:20:28 -07:00
Michael Comella
88cf7184ca [fenix] For https://github.com/mozilla-mobile/fenix/issues/15280: suppress new lint rule in migration code. 2020-10-14 15:20:28 -07:00
ekager
5baed32e13 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15265 - Save cached top sites for metrics ping 2020-10-14 15:08:54 -07:00
ekager
6ee2d5a8dd [fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 - Launch back to browser if we previoulsy had tabs 2020-10-14 15:05:20 -07:00
Mugurell
5cdb7f3a73 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15890 - Ensure app locale switcher works for Windows builds 
A hardcoded unix file separator prevented us from building a proper list of
locales for which we actually have packaged translations.
 2020-10-14 15:34:39 +02:00
Mozilla L10n Automation Bot
ad43cd47a2 [fenix] Import l10n. 2020-10-13 20:54:10 -04:00
ekager
3726b8c98b [fenix] For https://github.com/mozilla-mobile/fenix/issues/15853 - Always set fontSizeFactor setting with new text scale 2020-10-13 09:40:43 -07:00
Mihai Adrian Carare
26854525c6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14735: Remove debug logs from release build. (https://github.com/mozilla-mobile/fenix/pull/15747) 2020-10-13 09:17:58 -04:00
Mozilla L10n Automation Bot
f0a7f1bce0 [fenix] Import l10n. 2020-10-12 17:50:57 -07:00
Gabriel Luong
312626f8f0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15777 - [Grid View] Set the height of the title to 30dp 2020-10-12 10:38:54 -07:00
Gabriel Luong
f977e5af36 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15758 ⁃ [Grid View] Add a divider between the tab item's title and thumbnail 2020-10-12 10:38:54 -07:00
Mozilla L10n Automation Bot
031b4687c6 [fenix] Import l10n. 2020-10-11 22:55:02 -04:00
Mozilla L10n Automation Bot
f1753eed23 [fenix] Import l10n. 2020-10-11 10:04:34 -04:00
Grisha Kruglov
53244870e9 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15812: Check for a null context during onScanResult 2020-10-09 20:40:03 -07:00
Mozilla L10n Automation Bot
993335b296 [fenix] Import l10n. 2020-10-09 20:42:16 -04:00
Shen
c63bc04bd2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13168 - Removed the close button from history navigation bar 2020-10-09 20:33:37 -04:00
Michael Comella
4fedc9d719 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - post: link to issue, data review. 2020-10-09 15:47:55 -07:00
Michael Comella
88268c18a1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - review: clarify init time for External...Activity. 2020-10-09 15:47:55 -07:00
Michael Comella
6c86641cbc [fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - review: change extra name to firstFramePreDrawNanos. 2020-10-09 15:47:55 -07:00
sraturi
e97a48b48f [fenix] for https://github.com/mozilla-mobile/fenix/issues/10069 added AppLaunchTimeMeasurement.kt to handle logic of startup time for cold, warm, and hot startup types. 2020-10-09 15:47:55 -07:00
mcarare
69db319601 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13831: Adjust buttons dimensions to improve a11y. 
Margins were also adjusted to maintain relative placements.
 2020-10-09 15:39:31 -07:00
mcarare
1ca3aab28a [fenix] For https://github.com/mozilla-mobile/fenix/issues/13831: Add ripple for the copy password button. 2020-10-09 15:39:31 -07:00
ekager
bf2e2d545d [fenix] For https://github.com/mozilla-mobile/fenix/issues/14923 - Removes auto size preference toggle 2020-10-09 15:04:57 -07:00
Sijan Rijal
3aaded4868 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15402: Hide ETP pop-up if the toolbar is not visible (https://github.com/mozilla-mobile/fenix/pull/15667) 
For https://github.com/mozilla-mobile/fenix/issues/15402: Hide ETP pop-up when top or bottom toolbar is not visible
 2020-10-09 16:22:57 +03:00
Sijan Rijal
17fc28304a [fenix] For https://github.com/mozilla-mobile/fenix/issues/15497: Hide and remove the three dot menu from the Desktop Bookmarks folder (https://github.com/mozilla-mobile/fenix/pull/15649) 
For https://github.com/mozilla-mobile/fenix/issues/15497: Remove and disable the three dot menu button
 2020-10-09 14:39:03 +03:00
Mozilla L10n Automation Bot
db1ad2ac93 [fenix] Import l10n. 2020-10-08 21:20:56 -04:00
Jonathan Almeida
8281e16c83 [fenix] Fix lint warnings and test in site permissions 2020-10-08 19:37:56 -04:00
Arturo Mejia
4f67095c8b [fenix] Add support for local storage permission 2020-10-08 19:37:56 -04:00
Gabriel Luong
9b8a3401c8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 9: Fix ui tests for the tabs settings 2020-10-08 12:50:43 -04:00
Gabriel Luong
d7a4925a5a [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 8: Add a feature flag for showing the grid view in the tabs setting 2020-10-08 12:50:43 -04:00
Gabriel Luong
c95c4de162 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 7: Draw a border around the selected tab 2020-10-08 12:50:43 -04:00
Gabriel Luong
ca8cc56e32 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 6: Display the tab's favicon in the grid view 2020-10-08 12:50:43 -04:00
Gabriel Luong
8a4b3d85d4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 5: Don't draw any background when swiping to delete a tab 2020-10-08 12:50:43 -04:00
Gabriel Luong
b837358f14 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 4: Formatted TabTrayView.kt 2020-10-08 12:50:43 -04:00
Gabriel Luong
d7f46fa9f5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 3: Implement a grid view layout for the tabs 
Co-authored-by: Abhijit Valluri avalluri2@bloomberg.net
 2020-10-08 12:50:43 -04:00
Gabriel Luong
ded4f5cbbb [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 2: Remove unused xmlns:mozac in component_tabstray.xml 2020-10-08 12:50:43 -04:00
Gabriel Luong
88ce83d0d2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 1: Convert the CloseTabsSettingsFragment to a general TabsSettingsFragment 
- Renames CloseTabsSettingsFragment.kt to TabsSettingsFragment.kt
- Renames close_tabs_preferences.xml to tabs_preferences.xml
- Adds preference options for the switching between the Grid and List tab views
 2020-10-08 12:50:43 -04:00
Michael Comella
d7ea7c3555 [fenix] No issue: fix tests related to inline change. 
The difficulty in mocking StrictMode.resetAfter is concerning.
I'm starting to second-guess whether or not making strict mode manager a class
was a good idea.
 2020-10-08 07:24:21 -07:00
Michael Comella
d23a1b8274 [fenix] No issue: remove inline from StrictModeManager.resetAfter. 
I believe this was a premature optimization: it's unclear that it would
actually improve performance and yet  we had to add several weird
workarounds to make it work that broke encapsulation. It's also
possible it would be worse for the APK size because of excessive
inlining.
 2020-10-08 07:24:21 -07:00
Mozilla L10n Automation Bot
9f2237e6f1 [fenix] Import l10n. 2020-10-07 21:56:24 -07:00
Jonathan Almeida
f4c1a915f5 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/15754: Disable failing notification UI tests 2020-10-07 20:01:35 -04:00
Jonathan Almeida
848286b7b1 [fenix] Upgrade to Android Component 62.0.20201006190820 with breaking changes 2020-10-07 20:01:35 -04:00
Chenxia Liu
7ad5f26333 [fenix] Adding link data review request 2020-10-07 11:02:42 -07:00
Chenxia Liu
5ffe145425 [fenix] startup.timeline 2020-10-07 11:02:42 -07:00
Chenxia Liu
86db33910d [fenix] sync, sync_items, telemetry, theme, toolbar_position, 
tracking_protection, default_engine
 2020-10-07 11:02:42 -07:00
Chenxia Liu
073321049c [fenix] accesssibility, open_links, remote_debugging, search_suggestions, 
show_search
 2020-10-07 11:02:42 -07:00
Chenxia Liu
7f14d314cb [fenix] search_count, search_widget, tabs_count, toolbar_position 2020-10-07 11:02:42 -07:00
Chenxia Liu
bba0353993 [fenix] has, count: open_tabs, pwa, top_sites 2020-10-07 11:02:42 -07:00
Chenxia Liu
03b5b9f4e8 [fenix] default*browser, mozilla_products 2020-10-07 11:02:42 -07:00
Chenxia Liu
83d6b8d559 [fenix] browser.search, events.total_uri_count, metrics.adjust* 2020-10-07 11:02:42 -07:00
Chenxia Liu
93a4cab155 [fenix] first_session 2020-10-07 11:02:42 -07:00
Chenxia Liu
bf68ea27c5 [fenix] user_specified_search_engine, voice_search 2020-10-07 11:02:42 -07:00
Chenxia Liu
ade609c3ac [fenix] top_sites, tracking_protection 2020-10-07 11:02:42 -07:00
Chenxia Liu
bb3332478b [fenix] tab, tabs_tray, toolbar_settings 2020-10-07 11:02:42 -07:00
Chenxia Liu
278ac8007d [fenix] syenc_account, sync_auth 2020-10-07 11:02:42 -07:00
Chenxia Liu
ed317ac898 [fenix] search_suggestions, search_shortcuts, search_widget 2020-10-07 11:02:42 -07:00
Chenxia Liu
9e4dfdf37c [fenix] private_browsing, qr_scanner 2020-10-07 11:02:42 -07:00
Chenxia Liu
71b1684c5b [fenix] pocket, onboarding 2020-10-07 11:02:42 -07:00
Chenxia Liu
41cb9084bf [fenix] logins, media_notification, media_state 2020-10-07 11:02:42 -07:00
Chenxia Liu
1838f130d1 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/14142 - find_in_page, history, reader_mode, tip 2020-10-07 11:02:42 -07:00
mcarare
4a56121cc4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15711: Also add custom engines to fallback list. 2020-10-07 10:19:26 -07:00
mozilla-l10n-automation-bot
93b385ba2e [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/15738) 2020-10-06 18:19:11 -07:00
Elise Richards
f5ff218d46 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8765: Use shared list widget in collections (https://github.com/mozilla-mobile/fenix/pull/15733) 
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
 2020-10-06 16:24:08 -05:00
Michael Comella
8b20c2d8c2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 - post: decrement expected suppression count. 
Running locally, I get the same error: I think that there legitimately
was an reduction in the number of StrictMode suppressions on start up.
 2020-10-06 14:11:53 -07:00
Michael Comella
0934b7fe93 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 - review: add clarifying comments. 2020-10-06 14:11:53 -07:00
Michael Comella
86a44fb728 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add marker when StrictMode is suppressed. 2020-10-06 14:11:53 -07:00
Michael Comella
19904397b2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add MozillaStrictModeSuppression detekt check. 2020-10-06 14:11:53 -07:00
Michael Comella
d253b9060e [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add test to prevent increasing StrictMode suppression count. 2020-10-06 14:11:53 -07:00
Michael Comella
3e9f93a0ab [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add HomeActivityTestRule.skipOnboarding. 
This is more correct, faster, and results in less copy-paste duplication
than the current behavior:
  homeScreen { }.dismissOnboarding()

Which opens settings to dismiss onboarding.
 2020-10-06 14:11:53 -07:00
Michael Comella
b6609a0747 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: count StrictMode suppressions on startup. 2020-10-06 14:11:53 -07:00
Jocelyne Abi Haidar
efc846d57a [fenix] For https://github.com/mozilla-mobile/fenix/issues/15675: Disable Save button when editing saved login until something has been changed 
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
 2020-10-06 11:47:12 +03:00
mozilla-l10n-automation-bot
1d8006f733 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/15712) 2020-10-05 18:08:06 -07:00
Mozilla L10n Automation Bot
ded58ad2b7 [fenix] Import l10n. 2020-10-05 12:19:48 +02:00
mcarare
8668f5a0d6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15632: Improve checking open tabs logic to show collection button. 
Check now considers selected tab tray mode.
 2020-10-02 20:46:29 -04:00
ekager
c5a6e86f9b [fenix] For https://github.com/mozilla-mobile/fenix/issues/15600 - Move removal of timed out sessions to immediately after restoration 2020-10-02 13:22:49 -07:00
ekager
d9aefd1ce2 [fenix] No issue: Update biometric, core, and recyclerview libraries 2020-10-02 08:47:40 -07:00
mcarare
1add1c7454 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13031: Show size in KB for smaller downloaded files. 2020-10-02 11:04:48 -04:00
Mozilla L10n Automation Bot
c318e736f9 [fenix] Import l10n. 2020-10-01 17:46:57 -07:00
Jocelyne
cc4d4a14d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10107: Show Today and Yesterday labels in History (https://github.com/mozilla-mobile/fenix/pull/15415) 2020-10-01 16:42:50 -07:00
Michael Comella
e1ffe1108f [fenix] No issue: replace LintUnitTestRunner with detekt implementation. 
This should be more performant and easier to maintain.
 2020-10-01 16:06:53 -07:00
Jeff Boek
d81eff94bd [fenix] For https://github.com/mozilla-mobile/fenix/issues/15593 - Reverts back to simple UUID creation without Fenix side caching 2020-10-01 15:51:30 -07:00
Jocelyne
635e49092e [fenix] For https://github.com/mozilla-mobile/fenix/issues/15471: Show Delete button in red in multi-select overflow menu (https://github.com/mozilla-mobile/fenix/pull/15576) 2020-10-01 13:10:33 -07:00
Mozilla L10n Automation Bot
482efed8de [fenix] Import l10n. 2020-10-01 20:13:40 +02:00
Grisha Kruglov
a41022554b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15443: Use fragment's lifecycleScope for AlertDialog actions 2020-09-30 17:42:40 -07:00
Christian Sadilek
33e49d471b [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/15555: Set channel to Nightly explicitly for SettingsFragmentTest 2020-09-30 18:35:20 -04:00
mcarare
1589942479 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15559: Allow tabs to stretch in landscape mode for tablets. 
This overrides the default tabMaxWidth of 264dp to allow for tabGravity="fill".
 2020-09-30 14:46:22 -07:00
Christian Sadilek
a846743af4 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15555: Intermittent failures in SettingsFragmentTest 2020-09-30 14:53:18 -04:00
Stefan Arentz
a0c00cb3b4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15537 - Be more verbose about leanplum identifiers (https://github.com/mozilla-mobile/fenix/pull/15538) 2020-09-30 13:05:28 -04:00
mcarare
192e5dc063 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15535: hasOpenTabs now considers the selected tab mode in tray tab. 2020-09-30 08:33:38 -07:00
Michael Comella
af732f0748 [fenix] No issue: elaborate on Components class doc. 
This is to clarify a misunderstanding I found in PR review.
 2020-09-29 15:39:10 -07:00
Sebastian Kaspari
70dbf0d765 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565: Pass metrics to share controller" for debug test failures. 
This reverts commit 5de145914e9fc10d3d647e6f2856c2df19dd9156.
 2020-09-29 10:59:31 +02:00
Sebastian Kaspari
9b598b33d8 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565: Pass bookmark storage to controller" for debug test failures. 
This reverts commit 9825a5d2dfb0f6d3c0235fdf0032e510c34bf20a.
 2020-09-29 10:59:17 +02:00
Andrew Gaul
43778cf3cb [fenix] Show undo snackbars with padding with static bottom toolbar 
This specifically fixes the close tab snackbar.  This commit mirrors
the logic when not using Undo from
e14bf8e791aa56ded47812018f32ee9801a5b4f9.  References https://github.com/mozilla-mobile/fenix/issues/14982.
 2020-09-29 10:15:30 +02:00
ekager
1429c5ddaf [fenix] For https://github.com/mozilla-mobile/fenix/issues/15324 - Show tab settings and recently closed items in menu when no tabs 2020-09-28 21:09:30 -07:00
ekager
8caf149ab7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15503 - Change recently closed max to 10 2020-09-29 00:03:49 -04:00
TrianguloY
98f8f3b2ca [fenix] For https://github.com/mozilla-mobile/fenix/issues/13856 - Prevent overscroll in swipe to switch tabs gesture 2020-09-28 20:43:44 -07:00
Tiger Oakes
5a3b5af7d9 [fenix] Extract locale settings initial state 2020-09-28 20:39:49 -07:00
Tiger Oakes
be11bfd5b4 [fenix] Add test for initial logins list state 2020-09-28 20:39:49 -07:00
Tiger Oakes
e4bdd355d3 [fenix] Add tests for initial collection creation state 2020-09-28 20:39:49 -07:00
Sören Hentzschel
ac1a2a708a [fenix] For https://github.com/mozilla-mobile/fenix/issues/11561 - changed inactive heading and menu icon color in dark mode 2020-09-28 20:24:12 -07:00
Mozilla L10n Automation Bot
87ecdf8bfb [fenix] Import l10n. 2020-09-28 20:18:50 -07:00
Tiger Oakes
b55c4af6fb [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Pass bookmark storage to controller 2020-09-28 20:05:50 -07:00
Tiger Oakes
966e13c9aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Pass metrics to share controller 2020-09-28 20:05:50 -07:00
Michael Comella
a50cf27648 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: fix startup crash by using arg Context. 
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
 2020-09-28 18:01:19 -07:00
Michael Comella
53bd004f55 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: remove resetAfter & port tests to StrictModeManager. 2020-09-28 18:01:19 -07:00
Michael Comella
d0fbe70f10 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: clean up existing StrictMode test names. 2020-09-28 18:01:19 -07:00
Michael Comella
8a9472e540 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: move resetAfter into StrictModeManager. 
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.

Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```

We're going to have to add a lint check to prevent them from doing that.
 2020-09-28 18:01:19 -07:00
Michael Comella
5f8943f76c [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: change StrictModeManager to class from object. 
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
 2020-09-28 18:01:19 -07:00
Christian Sadilek
76018e2fe0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14034: Add debug preference to override AMO collection in Nightly 2020-09-28 17:25:52 -04:00
Michael Comella
9e86e369b6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: comment about duplication in logic in StrictMode. 
I had to drop a commit that addressed the issue because it was too hard
to fix.
 2020-09-28 13:52:40 -07:00
Michael Comella
394465e33e [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add comment to explain why we only resetAfter in certain build modes. 2020-09-28 13:52:40 -07:00
Michael Comella
c1aa8d396a [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: use ac StrictMode.resetAfter rather than duplicating functionality. 2020-09-28 13:52:40 -07:00
Michael Comella
b2c01e442f [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: rename to attachListenerToDisablePenaltyDeath for clarity. 2020-09-28 13:52:40 -07:00
Michael Comella
1ec45f33a2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: remove unused penaltyDialog parameter. 
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
 2020-09-28 13:52:40 -07:00
Michael Comella
3b76f2b3fc [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: always enable detectNonSdkApiUsage. 
We don't use penalty death for the VM policy so we theoretically don't
need to disable this check if penalty death is enabled.
 2020-09-28 13:52:40 -07:00
Sebastian Kaspari
eca2b8ecf4 [fenix] Use "undo" implementation from Android Components. 
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.

Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
 2020-09-28 10:04:46 -07:00
Mozilla L10n Automation Bot
788b5bb21e [fenix] Import l10n. 2020-09-28 17:16:11 +02:00
mcarare
3ede6cf544 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15310: Add test for ActivityNotFoundException when sharing to app. 2020-09-28 13:29:17 +03:00
mcarare
9d9d283dc7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15310: Also catch ActivityNotFoundException when sharing to app. 2020-09-28 13:29:17 +03:00
ekager
b276e9daca [fenix] No issue: Update AC to 61.0.20200925190057 2020-09-26 12:21:10 +02:00
ekager
cf0af49d3b [fenix] For https://github.com/mozilla-mobile/fenix/issues/12383 https://github.com/mozilla-mobile/fenix/issues/15407 https://github.com/mozilla-mobile/fenix/issues/12860 - Switch to using shared view model for session to delete on home 2020-09-25 16:54:54 -07:00
Grisha Kruglov
c348e03d0e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15434: Don't try to display a 'signed in' snackbar in a 'headless' mode 2020-09-25 15:31:07 -07:00
Grisha Kruglov
a0189c8080 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15432: Invoke UI updates on main thread in response to account events 2020-09-25 15:30:48 -07:00
Grisha Kruglov
5bb231cc70 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15436: Auto-close tabs during startup on the main thread 2020-09-25 15:11:21 -07:00
Christian Sadilek
146aa075dd [fenix] Configure M5 AMO collection for Nightly/Debug 2020-09-25 11:18:07 -04:00
mcarare
c5c3b6549d [fenix] For https://github.com/mozilla-mobile/fenix/issues/15130: Remove "what's new card" check in UI test. 2020-09-25 18:04:48 +03:00
mcarare
1d7b1df0e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15130: Remove "what's new card" from onboarding screen. 2020-09-25 18:04:48 +03:00