Revert "For #13336: Open bookmarks in current tab (#23169)"

This reverts commit e73deb23ac.
upstream-sync
Roger Yang 3 years ago committed by mergify[bot]
parent 1b44f47cd8
commit d1c0e9bf9b

@ -77,7 +77,7 @@ class DefaultBookmarkController(
val flags = EngineSession.LoadUrlFlags.select(EngineSession.LoadUrlFlags.ALLOW_JAVASCRIPT_URL) val flags = EngineSession.LoadUrlFlags.select(EngineSession.LoadUrlFlags.ALLOW_JAVASCRIPT_URL)
openInNewTabAndShow( openInNewTabAndShow(
item.url!!, item.url!!,
false, true,
BrowserDirection.FromBookmarks, BrowserDirection.FromBookmarks,
activity.browsingModeManager.mode, activity.browsingModeManager.mode,
flags flags

@ -110,7 +110,7 @@ class BookmarkControllerTest {
} }
@Test @Test
fun `handleBookmarkTapped should load the bookmark in the current tab`() { fun `handleBookmarkTapped should load the bookmark in a new tab`() {
var invokePendingDeletionInvoked = false var invokePendingDeletionInvoked = false
val flags = EngineSession.LoadUrlFlags.select(EngineSession.LoadUrlFlags.ALLOW_JAVASCRIPT_URL) val flags = EngineSession.LoadUrlFlags.select(EngineSession.LoadUrlFlags.ALLOW_JAVASCRIPT_URL)
@ -124,7 +124,7 @@ class BookmarkControllerTest {
verify { verify {
homeActivity.openToBrowserAndLoad( homeActivity.openToBrowserAndLoad(
item.url!!, item.url!!,
false, true,
BrowserDirection.FromBookmarks, BrowserDirection.FromBookmarks,
flags = flags flags = flags
) )
@ -290,7 +290,7 @@ class BookmarkControllerTest {
verify { verify {
homeActivity.openToBrowserAndLoad( homeActivity.openToBrowserAndLoad(
item.url!!, item.url!!,
false, true,
BrowserDirection.FromBookmarks, BrowserDirection.FromBookmarks,
flags = flags flags = flags
) )

Loading…
Cancel
Save