27954 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
PeterN	6d675c8acf	Fix: #11329: Don't assert vehicle list length is non-zero when only asked to set string parameter. (#11330) ... Since #11321, the vehicle list is not yet initialized when SetStringParameters is called, so a test that the vehicle list size is zero is triggered. However, doing this check in the SetStringParameters function is a bit out of its remit, so just remove it.	2023-09-21 13:24:53 +01:00
PeterN	cef6a5f79c	Fix #11326: Update autoreplace scrollbar count after clearing engine list. (#11327)	2023-09-21 07:42:49 +01:00
Joan Josep	6b7537646d	Fix: Allow NewGRF inspection of road tiles. (#11323)	2023-09-20 22:54:34 +01:00
Peter Nelson	122bfa2afd	Codechange: Use less locals for station free names bitmask.	2023-09-20 21:57:51 +01:00
Peter Nelson	aeaa552385	Codechange: Use std::bitset instead of bool array. ... This avoids use of C-style pointers and memset.	2023-09-20 21:57:51 +01:00
Peter Nelson	2eacf36d0a	Codechange: List fallback station names by ID instead of magic number. ... This improves readability and intention of the station name generator.	2023-09-20 21:57:51 +01:00
frosch	f40816503f	Codechange: Add enum items for dynmically created setting dropdowns.	2023-09-20 22:35:32 +02:00
frosch	39e67b6f4c	Codechange: Use existing widget ids instead of raw numbers.	2023-09-20 22:35:32 +02:00
frosch	e0df937247	Fix b5885295: NewGRF preset dropdown was broken.	2023-09-20 22:35:32 +02:00
translators	72323ae9e6	Update: Translations from eints ... danish: 20 changes by bscargo	2023-09-20 18:38:51 +00:00
Joan Josep	b9a1cb5d7c	Fix: Spelling of NIHAirport. (#11322)	2023-09-20 20:22:37 +02:00
PeterN	a0c6259e33	Codechange: Don't access cargo filter before it is initialized. (#11321) ... The cargo filter list is initialized during window OnInit, but the first build of the filtered list occurred before this.	2023-09-20 08:58:08 +01:00
PeterN	48dc4219ea	Codechange: Don't pass GUI cargo filter constants to command system. (#11320) ... CMD_BUILD_VEHICLE expects CT_INVALID to indicate a new vehicle should not be refitted on build, but the code passed CF_NONE instead. CF_NONE has the same numeric value at CT_INVALID, so the test passed, but...	2023-09-20 08:56:53 +01:00
frosch	6b586dddad	Cleanup: TransmitNotesOff is only called with buffer==_buffer.	2023-09-19 22:49:59 +02:00
frosch	c84fd30317	Codechange: Add missing 'override'.	2023-09-19 22:49:59 +02:00
frosch	2ff4248032	Codechange: Enable more warnings.	2023-09-19 22:49:59 +02:00
frosch	a7707302e6	Codechange: silence false warning.	2023-09-19 22:49:59 +02:00
frosch	55da426d44	Codechange: All ParagraphLayoutFactory::AppendToBuffer assume that the buffer has at least some space. ... Assert on that.	2023-09-19 22:49:59 +02:00
frosch	baf7cc858b	Codechange: Rename ship docking tile related functions.	2023-09-19 22:49:59 +02:00
frosch	5733145c59	Cleanup: Remove unneeded parameters.	2023-09-19 22:49:59 +02:00
frosch	b5885295f0	Codechange: Use parameters, which should be used.	2023-09-19 22:49:59 +02:00
frosch	b6c8f301be	Codechange: Silence warnings about intentionally unused parameters.	2023-09-19 22:49:59 +02:00
Patric Stout	df400ef84a	Fix: only count distance traveled in vehicles for cargo payment (#11283) ... No longer you can utilize the free (and instant) labour of station workers, transporting your cargo from one part of the station to the other. No more! Based on patch by dP.	2023-09-19 22:16:31 +02:00
translators	710722e3c1	Update: Translations from eints ... korean: 1 change by telk5093	2023-09-19 18:38:46 +00:00
Peter Nelson	6fb89b189f	Fix #11315: Sort industries and cargoes by name* in industry chain window. ... *Cargo types are sorted by the normal method so it's not strictly alphabetical.	2023-09-19 12:25:20 +01:00
Peter Nelson	106f29f761	Codechange: Use iteration to copy cargo list into CFT_CARGO.	2023-09-19 12:25:20 +01:00
Peter Nelson	4f8d06ff73	Codechange: Use uint8_t instead of byte for numeric values.	2023-09-19 12:25:20 +01:00
Peter Nelson	9457bda614	Codechange: Use std::fill instead of memset when initializing GUI cargo fields.	2023-09-19 12:25:20 +01:00
PeterN	18e75dbc88	Fix: Don't produce invalid cargo. (#11314) ... Production for secondary industries did not always check that the produced cargo type isn't valid.	2023-09-18 22:43:03 +01:00
Peter Nelson	fd2dd4397f	Codechange: Use range-for and iterator to populate default cargo table.	2023-09-17 21:26:01 +01:00
Peter Nelson	280dce9543	Codechange: Reorder CargoSpec to reduce alignment padding.	2023-09-17 21:26:01 +01:00
Peter Nelson	e8cbc3c2c7	Codechange: Simplify initialization of default cargoes.	2023-09-17 21:26:01 +01:00
Patric Stout	c6864637fb	Add: [GitHub] also test if release builds without asserts are warning-free (#11309)	2023-09-17 19:47:55 +02:00
Rubidium	3a2509198f	Codechange: use better location for the "invalid" action sentinel value ... It used to be a random sentinel for end-of-(widget-)list that was used to tell that no action has taken place yet. Since the last action is practically the widget that was pressed, add the sentinel to that enumeration.	2023-09-17 19:44:20 +02:00
Rubidium	09a7902d36	Fix 8ab0936: missed WIDGET_LIST_END removals	2023-09-17 19:44:20 +02:00
Jonathan G Rennison	3afb732c37	Fix #11307: Incorrect GroupStatistics after selling leading wagon ... When this results in a countable consist	2023-09-17 18:42:37 +01:00
Peter Nelson	14bcfff6f5	Codechange: Rename INVALID_CARGO to INVALID_CARGO_BITNUM ... ... to avoid future ambiguity.	2023-09-17 16:56:07 +01:00
Peter Nelson	9d1b131c44	Codechange: Use correct constant for invalid cargo type.	2023-09-17 16:56:07 +01:00
Rubidium	7ef22af2bb	Codechange: introduce and use function to raise and dirty a set of widgets when they are lowered	2023-09-17 16:03:01 +02:00
PeterN	6580ff1adb	Fix #11230: Widget layout also failed for group-less vehicle list window. (#11310)	2023-09-17 10:03:24 +00:00
Rubidium	4cf88e068a	Remove: unused include of cstdarg/stdarg.h	2023-09-16 23:09:53 +02:00
Rubidium	8ab0936491	Codechange: use parameter pack/folding instead of va_arg macros for widget states	2023-09-16 23:09:53 +02:00
translators	30eba33f1e	Update: Translations from eints ... english (us): 20 changes by 2TallTyler	2023-09-16 18:37:38 +00:00
frosch	c6f5b57f13	Fix #11297, 4e9a871: SCC_GENDER_LIST tried to determine the gender from the wrong sub-string. (#11299)	2023-09-15 15:25:25 -04:00
Patric Stout	39ef4b503f	Fix: also apply cargo filters on shared groups in vehicle listing (#11294)	2023-09-15 21:22:58 +02:00
translators	8d90448153	Update: Translations from eints ... romanian: 18 changes by bnegrut turkish: 22 changes by densxd dutch: 20 changes by Afoklala portuguese: 21 changes by azulcosta	2023-09-15 18:37:57 +00:00
Jonathan G Rennison	42170e6c2b	Codechange: Rename RoadType parameter of MakeRoadDepot ... See: #9642	2023-09-15 18:21:12 +02:00
frosch	a3f661cb66	Fix: compilation failed on gcc 10.2 due to missing include. (#11300) ... '_exit' is defined in 'unistd.h'.	2023-09-15 09:26:03 +01:00
translators	ba51a34b4c	Update: Translations from eints ... english (au): 20 changes by krysclarke korean: 25 changes by telk5093 russian: 20 changes by Ln-Wolf finnish: 20 changes by hpiirai french: 20 changes by glx22 portuguese (brazilian): 20 changes by pasantoro	2023-09-14 18:37:08 +00:00
Patric Stout	37e2f99c09	Change: store crash logs in JSON format (#11232)	2023-09-14 20:13:27 +02:00