385326943d
(svn r3901) Remove the last user of FindEdgesOfBridge() by using functions with similar functionality
19 years ago
633870df94
(svn r3900) When clearing a bridge determine the bridge direction and tile offset once instead of all over the place; also use UpdateSignalsOnSegment() instead of SetSignalsOnBothDir(), because this is sufficient
19 years ago
666c0a379d
(svn r3899) Use wrapper functions to make more clear how deleting stuff under bridges works; also remove an unnecessary local variable
19 years ago
1ac97fe008
(svn r3898) Add functions to find a bridge end starting at a middle tile
19 years ago
a390b6e4d1
(svn r3893) - Fix: Properly set back the owner of a crossing/road-under bridge after removing it. For crossings we can always use .m2 because it is already 0 when not owned by a town.
19 years ago
8208ee5ea2
(svn r3891) Fix r3885
19 years ago
0c9a269bd3
(svn r3890) Simplify deleting a bridge by handling the ramps outside of the removal loop
19 years ago
23d5188b7b
(svn r3889) Change a part of the bridge drawing code to make it more comprehensible and add the needed accessors
19 years ago
e74d77211f
(svn r3888) If you think you've checked everything, check once more. *sigh* Fix r3887
19 years ago
626109f3f9
(svn r3887) Add a function to get the other bridge end when you're at a bridge ramp
19 years ago
bd5def0092
(svn r3885) Simplify DoConvertTunnelBridgeRail() a bit
19 years ago
c515c34008
(svn r3877) Add functions to turn a tile into a rail/road bridge ramp/middle part
19 years ago
273533d4c7
(svn r3857) Add and use GetBridgeRampDirection()
...
Note: This slightly changes the behavior of GetAnyRoadBits() to only return a road piece for the start of the bridge ramp instead of a full ROAD_[XY]
19 years ago
23ae850484
(svn r3849) Fix bug in r3846
19 years ago
26815f7405
(svn r3846) Add functions to set the type of stuff (clear, water, rail, road) under bridges
19 years ago
3e932a0a4f
(svn r3838) Demystify building bridge middle parts a bit by removing some magic numbers and generic names
19 years ago
8259a29ead
(svn r3837) Partially unmagicfy restoring the tiles when deleting a bridge
...
Existing bug: When restoring a road piece which belongs to a town the town index unconditionally gets set to 0
19 years ago
0100871412
(svn r3830) Move IsTunnelTile() from tile.h to tunnel_map.h and add IsTunnel(), which just checks for a tunnel, but not the tile type as IsTunnelTile() does
19 years ago
7a0071cc53
(svn r3829) Reduce the use of _error_message by directly returning error codes instead of using this global variable
19 years ago
6c30c9ae4d
(svn r3823) Remove dead code: A value for 'image' gets calculated and overwritten just a few lines later without being used in between
19 years ago
86491ca257
(svn r3820) Be a bit more strict with types: use special types instead of generic byte and don't fill arbitrary data into inappropriate types
19 years ago
0e4ee1241f
(svn r3814) Remove another call to FindLandscapeHeight()
19 years ago
ee03f15f27
(svn r3803) Change the second parameter of UpdateSignalsOnSegment() from Direction to DiagDirection as that's what it really operates on
19 years ago
8cfcdaa733
(svn r3783) Replace further ints and magic numbers by Direction, DiagDirection and friends
19 years ago
3027b8673e
(svn r3779) Move CheckTunnelInWay() to a more appropriate place, invert its result and give it a less ambiguous name (IsTunnelInWay)
19 years ago
af42610321
(svn r3777) Add some functions to handle tunnels
19 years ago
49cb8eb470
(svn r3776) Replace many ints and magic numbers by Direction, DiagDirection and friends
19 years ago
4efa560ffc
(svn r3763) Adapt to the new 'map accessors go in foo_map.h'-scheme
19 years ago
2f8e3dcc05
(svn r3658) Add functions and symbolic names to retrieve road tile types and road pieces
19 years ago
251f519d26
(svn r3654) Turn another if-cascade into a switch
19 years ago
c9d540c0f0
(svn r3653) -Fix: You didn't pay for terraforming at the end tile when building a tunnel
19 years ago
9d4400c89f
(svn r3652) Rewrite CmdBuildTunnel in the hope to make it a bit more comprehensible
...
This implementation is also significantly shorter because it removes many redundant checks
19 years ago
08f132fef2
(svn r3645) Fix stupid typos in last (r3644) commit *sigh*
19 years ago
b8b6084da2
(svn r3644) Don't use FindLandscapeHeightByTile() when it's overkill - often it was just a complicated way of writing GetTileSlope(tile, NULL)
19 years ago
7692556c62
(svn r3613) Some more const, indentation, whitespace and similar stuff
19 years ago
5352e9fbcb
(svn r3597) Miscellaneous (I like that word) changes: Fix some indentation, add consts, reduce indentation level by short-circuit logic, convert if cascades to switch, whitespace, bracing, plus some minor stuff
19 years ago
087fe86ed2
(svn r3564) Several smaller changes:
...
- Don't treat non-booleans as booleans
- Reduce variable scope
- Bracing
- Use DeMorgan's law to make conditionals easier to read
- if cascade -> switch
- Replace some magic numbers by symbolic names
- Avoid assignments within other statements
19 years ago
17ec6ed70d
(svn r3520) Remove unused parameters from some functions
19 years ago
1c3e8630fe
(svn r3511) More whitespace ([FS#46] by Rubidium)
19 years ago
9712d6f639
(svn r3510) Fiddle with whitespace and parentheses
19 years ago
244d4ab5cb
(svn r3490) -Fix: A bunch (10) of off-by-one errors when checking if a TileIndex points to a tile on the map
19 years ago
a56ab08f3b
(svn r3487) -Fix: Price for demolishing a bridge was dependent on orientation and map size
19 years ago
4014e36aec
(svn r3472) - [PBS] Remove from trunk. Anyone interested can still find it in branch/pbs. This reverts revisions r3158, r3140, r3075, r2977, r2674, r2625, r2621, r2529, r2528, r2525, r2524, r2519, r2517, r2516, r2507, r2499. (in conjunction with Tron)
...
- The only change is that the nsignalsw.grf file is kept and that existing nightlies with PBS signals get those signals converted to combo-signals.
19 years ago
bea2d63154
(svn r3418) - Fix: When removing a town-owned tunnel the player's rating was not reduced, as it checked the ownership of the tunnel after clearing it. Now we perform the rating adjustment before clearing the tiles. (spotted by glx)
19 years ago
7ae5e344a2
(svn r3391) - PBS Fix: Keep PBS reservation state when building a bridge over rail.
19 years ago
49f0691c1a
(svn r3308) BAD
...
foo.h: int bar;
GOOD
foo.h: extern int bar;
foo.c: int bar;
19 years ago
80986fcd32
(svn r3282) - Codechange: Replace tests against CMD_ERROR with CmdFailed()
19 years ago
16e65960b9
(svn r3218) -Feature: Multiheaded train engines will now stay in the same train
...
This means that any user attempt to remove a rear engine will tell the user to move the front engine instead
This fixes the assert when moving multiheaded engines (introduced in r3144)
Note: to make old savegames use this feature, some engines might be turned around in order to link engines in pairs
-Codechange: train subtype is now a bitmask
This allows fast access to info like if it is a wagon or engine and if it is in front and so on
Note: savegame version bump
19 years ago
ef7fb8b515
(svn r3205) Some more uses for GB/SB
19 years ago
ca1dfe94d2
(svn r3186) Unnecessary casts and truncation
19 years ago
tron
Darkvater
peter1138
bjarni