smatz
50624d5c0f
(svn r16378) -Codechange: replace OldPool with simpler Pool. Compilation time, binary size and run time (with asserts disabled) should be improved
2009-05-22 15:13:50 +00:00
smatz
70d3ed15c8
(svn r16376) -Codechange: Vehicle::Tick() now returns false if the vehicle was deleted
2009-05-22 13:53:14 +00:00
smatz
512db5248e
(svn r16352) -Codechange: use PoolItem::GetIfValid() instead of PoolItem::IsValidID() and PoolItem::Get()
2009-05-18 16:21:28 +00:00
smatz
05db91dc65
(svn r16349) -Codechange: rename IsPlainRailTile() to IsPlainRail(), introduce shiny new IsPlainRailTile()
2009-05-18 01:26:23 +00:00
smatz
0c10daa243
(svn r16327) -Codechange: replace IsValidPoolItemID(index) by PoolItem::IsValidID(index)
2009-05-17 01:00:56 +00:00
smatz
d495dc5dbc
(svn r16325) -Codechange: replace GetPoolItem(index) by PoolItem::Get(index)
2009-05-16 23:34:14 +00:00
rubidium
3ab3cfcff3
(svn r16322) -Fix [FS#2873]: trains could get stuck in a depot when they wanted to go to the same depot again.
2009-05-16 20:08:49 +00:00
frosch
2431cc099e
(svn r16303) -Codechange: Use the question mark as default sprite when creating vehicles, instead of arbitrary sprites not related to the vehicle. (though that also applies to the question mark)
2009-05-13 21:45:56 +00:00
smatz
c189a15e3e
(svn r16302) -Codechange: remove Vehicle::AllocateList
2009-05-13 21:38:23 +00:00
smatz
3b6900baa8
(svn r16301) -Cleanup: remove unused parameter
2009-05-13 20:30:46 +00:00
frosch
8bb92c110d
(svn r16260) -Codechange: Add Vehicle::IncrementOrderIndex() to deduplicate some code.
2009-05-09 13:37:18 +00:00
rubidium
241af768f0
(svn r16242) -Codechange: rework pausing
...
-Fix [FS#2864]: autopause and manual pausing conflict with eachother
-Fix: new game + pause on new game + autopause make the game not unpause on the first join
2009-05-06 15:06:57 +00:00
rubidium
5c5b357043
(svn r16118) -Change/cleanup: remove the hexadecimal 'in TTD the string had this ID' from 'some' strings and replace the string name with something more sensible.
2009-04-21 23:40:56 +00:00
rubidium
a166a300aa
(svn r16087) -Fix (r16079): slow trains wouldn't crash into eachother anymore
2009-04-19 04:36:53 +00:00
rubidium
51288dee9d
(svn r16079) -Fix [FS#2824]: insanely fast trains would not stop in time for stations
...
-Fix: insanely fast trains would sometimes 'jump' over waypoints/via stations within a tick, which would cause the order not to be processed causing the train to go in loops until (with luck) it 'hit' the tile
2009-04-18 13:43:05 +00:00
frosch
6731a8f1b8
(svn r16075) -Fix (r15792)[FS#2844]: Mixed up TRACK_BIT_X/Y.
2009-04-17 23:16:01 +00:00
rubidium
3d5a7496c7
(svn r16057) -Fix [FS#2834] (r16037): division by zero when having an order with only one station that has either middle or near end stop location and where the platform is (significantly) longer than the train.
2009-04-13 22:27:21 +00:00
rubidium
4c707c7414
(svn r16037) -Feature: allow (per order) to let a train stop at the near end, middle or far end of a platform from the point of view of the driver of the train that enters the station.
2009-04-12 14:11:14 +00:00
frosch
6900854383
(svn r15793) -Feature: Allow train vehicles to be shorten to 1/8 length, even if not at the end of the train.
2009-03-21 22:32:51 +00:00
frosch
12dbe1dd0f
(svn r15792) -Codechange: Use a different algorithm for train vehicles to follow the vehicle in front of them.
2009-03-21 22:25:38 +00:00
frosch
25b70e8c0d
(svn r15789) -Codechange: Add DiagdirBetweenTiles() and use it.
2009-03-21 21:43:23 +00:00
rubidium
c3e87f345d
(svn r15718) -Cleanup: apply some comment coding style on the rest of the sources too
2009-03-15 00:32:18 +00:00
frosch
d86e821f53
(svn r15701) -Fix [FS#2595]: Blame NewGRFs returning inconsistent information in purchase-list/after building before users have a chance to blame OpenTTD for incorrectly autorenewing/-replacing.
2009-03-13 21:28:40 +00:00
rubidium
404cff525b
(svn r15677) -Fix [FS#2546]: vehicle images would be determined during the process of moving the vehicle which means that only the (orientation) data for the vehicles in front of it is valid. Now the data for the vehicles behind the vehicle are valid too.
2009-03-11 23:23:08 +00:00
rubidium
b003536ea8
(svn r15676) -Codechange: remove the need for BeginVehicleMove and merge VehiclePositionChanged and EndVehicleMove.
2009-03-11 20:43:14 +00:00
rubidium
b9aa5e17f2
(svn r15617) -Change [FS#2694]: vehicle variables 40-43 weren't cached (though spec stated they are). Caching these variables can yield a 10+% speed increase when those vehicle variables are queried often.
2009-03-04 23:32:23 +00:00
frosch
abe4692da2
(svn r15541) -Revert (r15399): 'v->cargo_type' is also used in other places, which cannot accept CT_INVALID.
...
-Codechange: Add Engine::GetDefaultCargoType() and Engine::CanCarryCargo() and use them.
-Fix [FS#2617]: When articulated parts have no available default cargo, use the cargo type of the first part for livery selection.
-Change: To decide whether a vehicle is refittable do not test its current capacity for being zero, but always use the 'capacity property'.
Note: The property is used unmodifed without calling CB 15/36. By setting it to a non-zero value and returning zero in the callback vehicles can be refitted to/from zero capacity for e.g. livery effects.
Note: It is intentional that you cannot control refittability by CB 36.
2009-02-21 12:52:41 +00:00
smatz
ff706b1e63
(svn r15497) -Fix (r15027): when trains crashed, AIEvent was created only for one train
2009-02-16 17:16:58 +00:00
smatz
26cdcb2dd5
(svn r15496) -Codechange: one division less in the train acceleration code
2009-02-16 01:57:55 +00:00
smatz
2c317b7321
(svn r15439) -Fix [FS#2626]: call Vehicle::LeaveStation() before reversing overlength loading train (station triggers were missed, PBS reservation could cause crash)
2009-02-10 12:49:12 +00:00
rubidium
5c8cf85613
(svn r15434) -Codechange: bit of type safety for the DC_xxx flags.
2009-02-09 21:20:05 +00:00
rubidium
89e1afdaa0
(svn r15428) -Codechange: consistently use colour instead of having both color and colour.
2009-02-09 02:57:15 +00:00
frosch
f6fa77d5f9
(svn r15358) -Add [NoAI]: AIEventVehicleCrashed::GetCrashReason()
2009-02-05 17:28:37 +00:00
peter1138
d9c143669b
(svn r15320) -Codechange: Increase 'realistic' acceleration 'resolution' by one bit by reducing a division and removing a multiplication: 3/4*2 = 0; 3/2 = 1. And a smidgeon less CPU usage, hah.
2009-02-02 21:38:36 +00:00
michi_cc
c875cb18d6
(svn r15313) -Cleanup: Use helper functions we already have and add some documentation.
2009-02-02 01:28:42 +00:00
smatz
9021c20b5e
(svn r15299) -Cleanup: remove many redundant includes
2009-01-31 20:16:06 +00:00
glx
1310ddf5b5
(svn r15269) -Codechange: reduced indentation in CmdBuildRail*
2009-01-25 15:35:21 +00:00
frosch
69766242b8
(svn r15268) -Fix: AIEventVehicleLost triggered at every pbs signal independent of the vehicle being lost.
2009-01-25 13:20:13 +00:00
glx
470da22ac3
(svn r15263) -Codechange: added Engine::GetCost() to remove some code duplication.
2009-01-25 00:57:03 +00:00
peter1138
598fdab47e
(svn r15236) -Codechange: Rename realistic_acceleration patch option to train_acceleration_model, and change from boolean to value. Don't forget to update your settings.
2009-01-23 20:53:43 +00:00
peter1138
d7d7a55060
(svn r15208) -Codechange: Remove some kind (undocumented, so who really knows) of original attempt to limit maximum tractive effort from 'realistic' acceleration.
2009-01-22 14:34:29 +00:00
peter1138
4d8c467067
(svn r15205) -Revert (r7421, partial): Support for MaxTE solves problem in a better way
2009-01-22 09:57:31 +00:00
frosch
3940ed7e6f
(svn r15125) -Fix [FS#2544]: Do not try to determine the next order destination, if there are no orders.
2009-01-17 16:25:32 +00:00
smatz
ca45774160
(svn r15077) -Codechange: enumify DAYS_IN_YEAR and DAYS_IN_LEAP_YEAR
...
-Change: when computing daily running cost, divide by 365 (instead of 364). Since r12134, the rounding errors don't need this correction anymore
2009-01-13 22:58:03 +00:00
truebrain
c2406cd42d
(svn r15027) -Merge: tomatos and bananas left to be, here is NoAI for all to see.
...
NoAI is an API (a framework) to build your own AIs in. See:
http://wiki.openttd.org/wiki/index.php/AI:Main_Page
With many thanks to:
- glx and Rubidium for their syncing, feedback and hard work
- Yexo for his feedback, patches, and AIs which tested the system very deep
- Morloth for his feedback and patches
- TJIP for hosting a challenge which kept NoAI on track
- All AI authors for testing our AI API, and all other people who helped in one way or another
-Remove: all old AIs and their cheats/hacks
2009-01-12 17:11:45 +00:00
frosch
69877b356f
(svn r15009) -Fix [FS#2528]: No need to extent the reserved path when the vehicle is still loading.
2009-01-12 14:56:31 +00:00
frosch
83467061b7
(svn r14994) -Fix [FS#Aali]: Better handling of OT_LOADING and OT_LEAVESTATION in ChooseTrainTrack.
2009-01-11 16:33:03 +00:00
frosch
5719596ce2
(svn r14993) -Fix (r14957, r14975): Do not reverse the train with OT_LEAVESTATION as that breaks PBS prediction.
2009-01-11 15:39:49 +00:00
frosch
1fdd53e428
(svn r14975) -Fix (r14957): Do not immediatelly move the train when leaving the station and the destination is not yet known.
2009-01-10 17:39:43 +00:00
frosch
818b162b35
(svn r14957) -Fix [FS#2516]: Do not abort train movement, when we are just about to reach the end of the platform.
2009-01-10 15:27:57 +00:00
rubidium
28ea38ae55
(svn r14949) -Cleanup: pointer coding style
2009-01-10 00:31:47 +00:00
rubidium
054787f082
(svn r14943) -Cleanup: remove some rogue spaces/replace some rogue tabs with spaces
2009-01-09 22:48:57 +00:00
michi_cc
b201fb1226
(svn r14852) -Feature: Automatic reversing in front of block signals can now be disabled by setting pf.wait_oneway_signal respectively pf.wait_twoway_signal to 255.
2009-01-05 20:29:05 +00:00
michi_cc
fc9b6b8872
(svn r14851) -Fix: A train reversing in a non-PBS block can't be stuck.
2009-01-05 20:29:00 +00:00
michi_cc
b4289b40f4
(svn r14850) -Fix [FS#2503]: Reversing a stuck train that is then not stuck anymore did not always reset the waiting timer.
2009-01-05 20:28:56 +00:00
smatz
ec7ebf2170
(svn r14835) -Change: apply the 'warn if train's income is negative' setting to other vehicle types, too
2009-01-04 18:34:23 +00:00
smatz
b1f7ef7076
(svn r14831) -Codechange: use {VEHICLE} instead of Train/Ship/Road veh/Aircraft/{STRING} {COMMA} in lang files (part by Swallow)
2009-01-04 17:42:46 +00:00
smatz
91233ea596
(svn r14828) -Codechange: move most of save/load-specific code to separate files
2009-01-04 15:32:25 +00:00
rubidium
183f8df552
(svn r14826) -Fix [FS#2494]: infinite loop in order lookahead when reserving a path (Swallow)
2009-01-04 14:36:19 +00:00
rubidium
f316796629
(svn r14803) -Codechange: move order list management into it's own class and remove the order count from the savegame as we can easily count that (PhilSophus)
2009-01-03 13:52:06 +00:00
rubidium
abd3b8e0d7
(svn r14801) -Codechange: don't reference Vehicle::num_orders directly but through a method GetNumOrders() (PhilSophus)
2009-01-03 13:20:32 +00:00
rubidium
d91baac764
(svn r14785) -Fix [FS#2132]: vehicle list for station gets closed when station view is closed even when the vehicle list is stickied. Other vehicle lists are not deleted when their 'opening' window gets closed so do the same with the station view.
2009-01-02 20:59:04 +00:00
rubidium
56d108edf8
(svn r14779) -Fix (r14747) [FS#2485]: selling an articulated vehicle removed only the first part and not the rest.
2008-12-31 17:52:42 +00:00
rubidium
e83cca7d13
(svn r14754) -Codechange: get rid of _cmd_text and just pass it as (optional) parameter.
2008-12-28 14:37:19 +00:00
rubidium
0c6c3311c9
(svn r14748) -Codechange: unduplicate window updating when deleting vehicles.
2008-12-26 21:08:51 +00:00
rubidium
c34ce32f26
(svn r14747) -Codechange: remove DeleteVehicleChain in favour of the vehicle destructor as that was already doing the same for a few vehicle types.
2008-12-26 20:45:02 +00:00
smatz
c88a6199a7
(svn r14743) -Codechange: use INVALID_TILE to indicate station doesn't have queried facility (or station/roadstop is invalid) instead of 0 (Yexo)
2008-12-26 18:01:15 +00:00
frosch
6afd6a450f
(svn r14699) -Fix (r14483): Do not use v->dest_tile for trains heading to a station. Reaching that tile does not mean reaching the station.
2008-12-20 00:16:23 +00:00
frosch
d64b89838e
(svn r14695) -Cleanup: When NTP is not active there is no need to set up TrainTrackFollowerData.
2008-12-19 22:26:43 +00:00
rubidium
33008f5d8b
(svn r14594) -Fix [FS#2412]: trains could get their their last visited station reset when still (un)loading causing an invalid state.
2008-11-19 14:48:12 +00:00
frosch
24bd9866f8
(svn r14578) -Fix (r2389, r10811)[FS#Vikthor]: Allow capacity callbacks (15, 36) to return zero capacity.
2008-11-13 20:26:06 +00:00
michi_cc
023ce24b1a
(svn r14559) -Fix [FS#2387]: A train could be blocked inside a depot if it was reversed just after leaving the depot.
2008-11-02 19:32:24 +00:00
michi_cc
147304b83d
(svn r14550) -Fix [FS#2391]: Don't assert on path look-ahead when processing a not-part-of-orders depot-order.
2008-10-31 16:46:34 +00:00
rubidium
33203c67c1
(svn r14526) -Fix [FS#2379]: make sure trains stop at the end of a station; a 3/8th length train did stop 2/8th of it's length too early causing a 63/8th long train not to fit in a 4 tile station.
2008-10-24 20:53:57 +00:00
glx
f28957bcc4
(svn r14521) -Fix [FS#2378]: fast trains could continue to move after a crash
2008-10-22 23:06:36 +00:00
michi_cc
4424c2e6fb
(svn r14492) -Fix [FS#2366] (r14482): Conditional orders could lead to an infinite loop on path look-ahead.
...
Don't refactor things that don't want to be refactored, folks. And some comments can't hurt either.
2008-10-19 17:16:26 +00:00
michi_cc
5c781a921a
(svn r14483) -Fix [FS#2340]: On reaching a waypoint a train could falsely be reported as lost when doing the look ahead for a path.
2008-10-18 13:13:31 +00:00
michi_cc
9a7270d147
(svn r14482) -Codechange: Use a class for saving the current train order when extending the reserved path beyond the current destination during pathfinding.
...
The class' destructor will make sure that the order is restored on function exit in all cases.
2008-10-18 13:13:27 +00:00
rubidium
b5e467978b
(svn r14464) -Codechange: replace (uint)-1 with UINT_MAX (PhilSophus)
2008-10-14 18:38:51 +00:00
rubidium
3113cc17b9
(svn r14436) -Fix [FS#1793]: (fast) trains would sometimes move one time too often/little when moving from diagonal<->non-diagonal tracks (iguannab)
2008-10-03 12:55:39 +00:00
rubidium
e589c7e580
(svn r14422) -Codechange: also reflect the changes of r14421 in the filenames.
2008-09-30 20:51:04 +00:00
rubidium
f56e630e5c
(svn r14421) -Codechange: rename all player variables/types to company *or* client so it is immediatelly clear which one you are working with.
2008-09-30 20:39:50 +00:00
frosch
423160f946
(svn r14405) -Fix [FS#2289]: Correct handling of selling free wagons while the following vehicle is an engine (i.e. a new train is created).
2008-09-26 19:25:49 +00:00
frosch
5fd49a8cd2
(svn r14403) -Fix (r14384): The condition was too restrictive.
2008-09-26 19:01:57 +00:00
peter1138
21a5c6bb7d
(svn r14401) -Fix (r11724): Don't check articulated parts or rear multihead parts for callback 1D when moving a chain of wagons.
2008-09-26 06:52:06 +00:00
rubidium
48ece47bd9
(svn r14397) -Fix: possible buffer overrun, wrong parameter type passed to printf and && where || is meant. Found by MSVC's code analysis (Darkvater)
2008-09-24 23:25:24 +00:00
frosch
fb1fae001a
(svn r14384) -Fix: Moving the first vehicle of a train elsewhere might require a new unitnumber for the remaining chain.
2008-09-22 19:28:53 +00:00
rubidium
7935517470
(svn r14371) -Fix [FS#2313]: loading indicator didn't stay with the front engine when turning a train in a station.
2008-09-21 18:28:35 +00:00
frosch
a4fd962adf
(svn r14366) -Fix (r14362): Match multiheaded parts starting from the first vehicle in a chain.
2008-09-20 18:31:31 +00:00
frosch
6782d81142
(svn r14362) -Fix (r3403): Also connect multiheaded parts in free wagon chains.
2008-09-20 10:53:08 +00:00
smatz
7e4e999a97
(svn r14307) -Fix: when deleting a station, remove news items regarding it
2008-09-13 10:19:51 +00:00
michi_cc
5a28d3a54f
(svn r14285) -Fix [FS#2263]: A train inside a wormhole could free the reservation of another train inside the wormhole.
2008-09-09 19:02:47 +00:00
michi_cc
e008f58350
(svn r14284) -Fix (r13958): Trains would not look ahead and extend their reservation on a waypoint tile in all cases.
2008-09-09 18:47:53 +00:00
rubidium
6e67ea1f9d
(svn r14258) -Codechange: rework the way to query the vehicle hash to make sure it always results in the same irregardless of the order of the hash-linked-list.
...
-Fix: desync in PBS reservation following, vehicle flooding and road vehicle overtake/follow code.
2008-09-07 11:23:10 +00:00
frosch
f932e81127
(svn r14149) -Fix: When selling the front engine of a train consist with another engine at the second position, not all 'important' data was copied to the new head.
2008-08-23 23:31:27 +00:00
frosch
b66b3937ed
(svn r14148) -Fix (r14096) [FS#2239]: Orders were freed while they were still shared by other vehicles.
2008-08-23 23:15:04 +00:00
frosch
2dd9bc672a
(svn r14131) -Fix (r13952) [FS#2250]: The reservation of adjacent stations was sometimes not freed correctly. (michi_cc)
2008-08-22 22:42:21 +00:00
frosch
7020a48ea0
(svn r14130) -Fix (r13961) [FS#2248]: Clear the stuck state of a train that is reversing with the first vehicle inside a depot. (michi_cc)
2008-08-22 22:28:26 +00:00
rubidium
66b9ea9a5a
(svn r14096) -Codechange: merge the shared order's vehicle list management to a single location.
2008-08-17 19:56:17 +00:00
rubidium
38905d596f
(svn r14089) -Fix [FS#2219]: trains not being able to find a route to a depot when the front is already in the depot.
2008-08-17 11:04:37 +00:00