Commit Graph

967 Commits

Author SHA1 Message Date
Robin Hu
1621b83e7a Cleaning up code in interactiveLayer -> mousemove, regarding
the IE 10 hack. It turns out that d3.event.offsetX/Y contains
the relative mouse coordinates needed. Using those instead.
2013-07-12 20:32:04 -04:00
Robin Hu
3266bc369d Fixing bug on cumulative line chart where point hover circles
were not disappearing after moving the index line.
This is due to commit 065c8eb84d.
2013-07-12 18:10:54 -04:00
Robin Hu
7f24fe8d1f Rebuilding nv.d3.js 2013-07-12 17:56:19 -04:00
Robin Hu
7bfc19b21f Adding IE9+ fix so that mousing over a tooltip does not trigger
the elementMouseout dispatch. Without this, tooltips on IE are very buggy.
2013-07-12 17:55:31 -04:00
Robin Hu
0443d7c779 Removing some code I added in tooltip.js that clamped the svg bound top. Wasn't actually working. 2013-07-12 17:23:39 -04:00
Robin Hu
4b21903740 Adding unique ID to each tooltip in nv.models.tooltip. 2013-07-12 17:17:47 -04:00
Robin Hu
d8ba26dc06 Cleaning up code for the MSIE svg.getScreenCTM issue.
REbuilding nv.d3.js
2013-07-11 17:42:28 -04:00
Robin Hu
410569110e Average lines on cumulative line chart had ability to go
off the <SVG> bounding rectangle. This caused issues on Firefox.
Changed code so that the average lines are 'clamped' within
the <SVG> bounding rect, and if they go off bounds, make them transparent.
2013-07-10 23:01:49 -04:00
Robin Hu
8608819e0d Cumulative line chart old tooltips working again.
Needed to modify pointer-events depending on whether
useInteractiveGuideline was set to true or false.
2013-07-10 22:31:36 -04:00
Robin Hu
729d57cda8 Rebuilding nv.d3.js 2013-07-10 12:24:19 -04:00
Robin Hu
678beb63ef Fixing issue where the 'IndexLine' in cumulative line chart was not draggable.
Needed to move interactive layer to the bottom of the SVG layer stack, and change pointer-events to none
for things above it.
2013-07-10 12:23:12 -04:00
Robin Hu
e6ea912eb6 Merge branch 'development' of https://github.com/novus/nvd3 into development
Conflicts:
	nv.d3.min.js
2013-07-10 09:20:26 -04:00
frank shao
c0a0c8b2f0 make 2013-07-09 18:11:14 -04:00
frank shao
69c42a52a4 Fixed update issue with scatterplusline 2013-07-09 18:10:13 -04:00
Robin Hu
874e068d9f The code to create the interactive guideline is now placed after
the code that creates the legend.
This fixes an issue where the guideline would extend past
the X-axis, when the legend was more than two lines.
2013-07-09 17:20:20 -04:00
Robin Hu
5e5ba5c34b Merge branch 'development' into nvd3-UI-134
Conflicts:
	nv.d3.min.js
2013-07-09 11:06:44 -04:00
Robin Hu
4c3554db5d Rebuilt nv.d3.js 2013-07-09 11:05:51 -04:00
Robin Hu
1a6b5dab13 Adding more inline comments to tooltip.js.
Removed an unused feature for bolding a row in the tooltip.
2013-07-08 22:05:48 -04:00
Robin Hu
3a75b583ca Created more robust tooltip solution. Tooltips render inside the SVG's parent DIV.
They can be positioned, even if there are relative positioned elements above it.
2013-07-08 17:19:10 -04:00
Robin Hu
8dea03da44 Converted tooltip.js getTooltipContainer function to use d3.select.
Rebuilt nv.d3.js
2013-07-08 15:38:56 -04:00
Robin Hu
6e84a6845c Tooltips are no longer rendered on document.body.
Instead, they are rendered inside the chart container.
Added some CSS styles to nvtooltip
2013-07-08 15:06:22 -04:00
Robin Hu
e1e9144e5f Updating lineChartSVGResize example to use interactive guideline.
Rebuilding nv.d3.js.
2013-07-08 11:25:58 -04:00
Robin Hu
6c2f19a044 Updating CSS styling around table.td 2013-07-08 09:48:52 -04:00
Robin Hu
c13be39c12 Added inline comments.
Changed style td.legend to td.legend-color-guide, becuase it conflicts with another .legend style being used elsewhere.
2013-07-08 09:36:29 -04:00
Robin Hu
1ff26f5fab Optimizing interactive layer code, so d3.mouse(this) is called only once per mousemove. 2013-07-08 09:07:06 -04:00
Robin Hu
6ab5b447d4 Adding unit test page (very crude) for nv.interactiveBisect, since it is a
very important function.
2013-07-07 00:02:34 -04:00
Robin Hu
75ff9267c8 Finally resolving the nagging issue in IE where tooltips
were not showing up in the right place, due to issue with d3.mouse.

The solution is to take the svg.getBoundingClientRect(), and
taking 25% of it's top and left values.
2013-07-06 23:32:28 -04:00
Robin Hu
792a36262d Removed transitions from nv-point on hover. 2013-07-06 23:32:11 -04:00
Robin Hu
ca769e706d Using svg.getBoundingClientRect() instead of elem.offsetLeft
when calculating tooltip position.  Also replaced window.scollY with
pageYOffset.  This is for Firefox and MSIE compatibility.
2013-07-06 17:12:19 -04:00
Robin Hu
14117b32de Fixing a NASTY Microsoft IE bug I found during cross browser testing.
Mousing over SVG.rect returns wrong X,Y coordinates, but only in IE.
2013-07-06 16:44:06 -04:00
Robin Hu
8b870e6b0a Created function to get the first non-svg parent element in tooltip.js.
Needed because in Firefox and IE, SVG.offsetParent does not exist.
2013-07-06 15:28:05 -04:00
Robin Hu
4b8ad322cf Updating algorithm for calculating the tooltip offset positioning. 2013-07-06 14:59:19 -04:00
Robin Hu
79b196cb41 Added simple navigation links between lineChart, StackedAreaChart and
CumulativeChart test examples.
2013-07-06 14:58:50 -04:00
Robin Hu
65edf27199 Fixed bug in nv.interactiveBisect, for situations where the xAccessor is
function(d,i) { return i}
2013-07-06 13:25:52 -04:00
Robin Hu
fa89918faf Removed trailing commas in interactiveLayer code. Caused javascript error/warning. 2013-07-06 12:47:03 -04:00
Robin Hu
3c6d1b65ee Added historicalBar.interactive. If set to false, tooltips/hoverovers don't work. 2013-07-06 11:25:29 -04:00
Robin Hu
81bf049daa The .nvd3 .nv-bars rect:hover style was incorrect. it needs to be "rect.hover",
because we are applying the hover class when we mouse over a bar.
2013-07-06 11:16:26 -04:00
Robin Hu
8479f5fce1 Exposed 'highlightPoint' and 'clearHighlights' in historicalBar. 2013-07-06 11:12:19 -04:00
Robin Hu
817340cff5 Instead of using a dispatch for handling 'highlightPoint' and 'clearHighlights', I am making
those functions a direct method of nv.models.scatter.  So you just say scatter.highlightPoint,
instead of scatter.dispatch.highlightPoint.
2013-07-06 11:05:23 -04:00
Robin Hu
b07d1f2a87 Added back the 'tooltips' boolean flag to lineChart.dispatch.tooltipShow.
REbuilt nv.d3.js and minified version.
2013-07-06 10:46:17 -04:00
Robin Hu
5f3e6d5691 Fixed merge conflicts when merging with origin/nvd3-UI-134 2013-07-06 10:33:54 -04:00
Robin Hu
1eb01d703d Turning off Voronoi point path creation, if using the new interactive
guideline and tooltip.

Turns out, Voronoi is not needed in this new interactive mode!
2013-07-05 18:35:16 -04:00
Robin Hu
93a26c53c9 Fixing issue in scatterPlusLineChart where tooltips don't activate on
chart initial load.
2013-07-05 18:08:45 -04:00
Robin Hu
28d708d09d Adding unit test on lineChartTest.html for when points are NaN, undefined,
etc.
Found a few edge cases where errors happen. Creating nv.utils.NaNtoZero()
function, to be used in places where points and lines are rendered.

Using NantoZero in scatter.js and interactiveGuideline.
2013-07-05 16:14:48 -04:00
Robin Hu
9b3858e926 Created new general stylesheet for the nvd3 chart test pages.
Added test page for stacked area chart.
2013-07-05 15:32:47 -04:00
Robin Hu
cdb9ea83ab Integrated interactive guideline into stacked area charts. Updated the
stacked area example.
2013-07-04 23:04:58 -04:00
Robin Hu
d974556d05 Cleaned up interactive guideline dispatch code.
Integrated interactive guideline into cumulativeLineChart and updated
example.
2013-07-04 22:18:02 -04:00
Robin Hu
575ed7950e Fixed tooltip display edge case, where if the tooltip is very large, it
will render off window if too close to the bottom.
2013-07-04 21:27:58 -04:00
Robin Hu
02da71c944 Added six more important line chart test cases. Changed tests to include
area charts.
2013-07-04 17:45:42 -04:00
Robin Hu
defaf765e8 Created nv.interactiveBisect utility function, and integrated it into the
interactiveGuideline logic.  This function is used to find the x point
position given a mouseX location. It's a more robust solution. Made sure
chart tests passed.
2013-07-04 12:21:12 -04:00