Remove unknown provisioner WARNning and leave TODO

pull/97/head
max furman 5 years ago
parent ca8daf5f12
commit ac234771c7

@ -3,7 +3,6 @@ package provisioner
import ( import (
"crypto/x509" "crypto/x509"
"encoding/json" "encoding/json"
"log"
"net/url" "net/url"
"strings" "strings"
@ -155,11 +154,11 @@ func (l *List) UnmarshalJSON(data []byte) error {
// compiled with a version of smallstep/certificates that does not // compiled with a version of smallstep/certificates that does not
// support a specific provisioner type. If we don't skip unknown // support a specific provisioner type. If we don't skip unknown
// provisioners, a client encountering an unknown provisioner will // provisioners, a client encountering an unknown provisioner will
// break. Rather than break the client, we skip the provisioner but // break. Rather than break the client, we skip the provisioner.
// TODO: accept a pluggable logger (depending on client) that can
// warn the user that an unknown provisioner was found and suggest // warn the user that an unknown provisioner was found and suggest
// that the user update their client's dependency on // that the user update their client's dependency on
// step/certificates and recompile. // step/certificates and recompile.
log.Printf("[WARN] Unknown provisioner of type '%s' found. Please update your client.", typ.Type)
continue continue
} }
if err := json.Unmarshal(data, p); err != nil { if err := json.Unmarshal(data, p); err != nil {

Loading…
Cancel
Save