Commit Graph

154 Commits

Author SHA1 Message Date
Gijs Kruitbosch
8ddba60425 Fix script parsing to ignore closing tags in comments 2015-04-01 11:12:16 +01:00
Gijs
87e4fbb612 Merge pull request #82 from mozilla/keep-images
Fixes #81 - Keep article images.
2015-03-31 18:27:20 +01:00
Nicolas Perriault
f8d37e4276 Don't remove elements containing figures or having them as a parent. 2015-03-31 19:12:45 +02:00
Nicolas Perriault
b6730703a1 Fixes #81 - Keep article images. 2015-03-31 18:46:04 +02:00
Margaret Leibovic
0b3bce57bf Merge pull request #86 from gijsk/fix-innerHTML-children
Fix innerHTML's children setter
2015-03-31 09:47:26 -04:00
Gijs Kruitbosch
cdcbd94cd5 Add tests for the lifehacker page 2015-03-30 20:52:05 +02:00
Gijs Kruitbosch
bc7873d313 Fix innerHTML children assignments to help fix issue #76. 2015-03-30 15:57:16 +02:00
Gijs
194a5376c8 Merge pull request #63 from mozilla/preserve-embedded-tweets
Preserve inline tweets as they're part of article contents.
2015-03-25 13:57:34 +00:00
Nicolas Perriault
ec491127f4 Merge pull request #70 from gijsk/fix-parent-score-nullcheck
Fix an issue where we don't track scores for the parents appropriately.
2015-03-23 16:08:43 +01:00
Gijs
5eebd57d71 Merge pull request #69 from mozilla/print-err-stack-on-generation-failure
Log the exception stack trace when a test case generation fails
2015-03-23 15:02:05 +00:00
Nicolas Perriault
aeeabb7c79 Print exception stack when generating a test case fails. 2015-03-23 15:59:06 +01:00
Gijs Kruitbosch
b4332328f3 Fix an issue where we don't track scores for the parents appropriately. 2015-03-23 14:57:04 +00:00
Gijs
14b33b69db Merge pull request #65 from mozilla/support-embed-videos
Fixes #56 - Updated support for embedded Youtube & Vimeo videos.
2015-03-23 14:48:00 +00:00
Gijs
b8b620631d Merge pull request #68 from mozilla/fix-base-urls
Fixes #53 - Fixed dot-slash relative URI resolution.
2015-03-23 14:45:00 +00:00
Nicolas Perriault
ad52d8ee30 Fixes #53 - Fixed dot-slash relative URI resolution. 2015-03-23 12:54:46 +01:00
Nicolas Perriault
2d5f59f3eb Fixes #56 - Updated support for embedded Youtube & Vimeo videos. 2015-03-23 10:07:04 +01:00
Gijs
f9ea568f3f Merge pull request #64 from mozilla/fix-readme-with-tests
Updated README about tests.
2015-03-22 22:08:49 +00:00
Nicolas Perriault
c24821c247 Updated README about tests. 2015-03-22 18:29:05 +01:00
Nicolas Perriault
d83763c8a1 Preserve inline tweets as they're part of article contents. 2015-03-22 18:19:34 +01:00
Nicolas Perriault
9510715723 Merge pull request #61 from mozilla/strip-embed-tags
Refs #58 - Stripped embed tags.
2015-03-22 18:10:50 +01:00
Nicolas Perriault
cf3dce6cf2 Refs #58 - Stripped embed tags. 2015-03-22 17:52:23 +01:00
Gijs
6ad9dd9952 Merge pull request #52 from mozilla/forEach-loops
Use forEach when it makes sense.
2015-03-22 09:25:50 -07:00
Nicolas Perriault
eee224560b Addressed review comments from @Gijsk. 2015-03-21 18:05:58 +01:00
Nicolas Perriault
4f9615cb9a Use forEach when it makes sense. 2015-03-21 15:10:00 +01:00
Gijs
f7c0e4713f Merge pull request #51 from gijsk/fix-medium-title
Fix the title to not update when we already have one
2015-03-20 20:34:38 -07:00
Gijs Kruitbosch
14afc21b96 Fix code to ignore titles when we already have one. 2015-03-20 20:34:12 -07:00
Gijs Kruitbosch
a924e31729 Add testcase for current Medium behaviour including SVG that desktop sees. 2015-03-20 20:20:45 -07:00
Gijs
98d35fc306 Merge pull request #50 from gijsk/fix-herald-sun
Bug 1143725 - fix the Herald Sun website
2015-03-20 20:08:21 -07:00
Gijs Kruitbosch
955951659d Bug 1143725 - fix the Herald Sun website 2015-03-20 17:49:42 -07:00
Gijs
a77dcab362 Merge pull request #49 from gijsk/improve-logic-to-use-children-instead-of-childnodes
Improve logic to rely on children instead of childNodes
2015-03-20 17:12:45 -07:00
Gijs Kruitbosch
eb81444946 Improve logic to rely on children instead of childNodes 2015-03-20 17:10:45 -07:00
Margaret Leibovic
4e92d7c1ac Merge pull request #46 from gijsk/tests-for-jsdomparser
Write a bunch of tests for jsdomparser
2015-03-20 11:18:58 -07:00
Gijs Kruitbosch
f9e770ad3b Write a bunch of tests for jsdomparser 2015-03-20 10:32:28 -07:00
Margaret Leibovic
d0df9d8479 Merge pull request #40 from leibovic/byline
Improve byline algorithm. r=Gijs
2015-03-20 09:18:57 -07:00
Margaret Leibovic
3c2d93cd09 Improve byline algorithm 2015-03-20 09:16:28 -07:00
Gijs
32e7702ea4 Merge pull request #44 from DavidBruant/patch-1
Update package.json
2015-03-20 08:54:38 -07:00
Gijs
3e287a90d5 Merge pull request #42 from mozilla/better-test-docs
Better test docs.
2015-03-20 08:52:22 -07:00
David Bruant
3f16d5bd92 Update package.json 2015-03-20 16:48:34 +01:00
Nicolas Perriault
f4670a1531 Better test docs. 2015-03-20 16:42:18 +01:00
Gijs
afa61e33cc Merge pull request #41 from mozilla/detailed-test-reports
More detailed test reports.
2015-03-20 05:57:57 -07:00
Nicolas Perriault
df02218905 More detailed test reports. 2015-03-20 11:28:10 +01:00
Gijs
c2a733fa46 Merge pull request #37 from gijsk/remove-reliance-on-inert-nodecollection
Remove reliance on inert nodecollection
2015-03-19 18:42:34 -07:00
Gijs Kruitbosch
2b09db3300 Improve logging for errors in test runs, add a way to run just some tests (using an env var because mocha doesn't support passing arguments) 2015-03-19 18:29:08 -07:00
Gijs Kruitbosch
d94f3158d3 Fix readability.js to do a DOM traversal rather than relying on a wonky DOMCollection, fix trims, fix a potential null access, etc. 2015-03-19 18:28:48 -07:00
Gijs Kruitbosch
9c4648193c Fix JSDOMParser to have support for X-Element-Y (for X from first, last, next, previous; Y from Child, Element) 2015-03-19 17:04:42 -07:00
Gijs
4903846104 Merge pull request #35 from leibovic/metatest
Check metadata in tests
2015-03-19 15:19:48 -07:00
Margaret Leibovic
639c878af5 Generate expected-metadata.json in generate-testcase.js 2015-03-19 14:47:36 -07:00
Margaret Leibovic
1b5d896b8b Add expected-metadata.json for existing tests 2015-03-19 14:39:50 -07:00
Margaret Leibovic
6490d7205d Update test to check metadata 2015-03-19 14:39:50 -07:00
Margaret Leibovic
fc53e1a315 Set 'name' variable to null in _getExcerpt to avoid old values in future for loop iterations 2015-03-19 14:37:47 -07:00