Gijs Kruitbosch
225adef137
Turn off JS when using JSDOM in tests.
10 years ago
Gijs Kruitbosch
b1f6c62b25
Fix tests for readability to also work with jsdom
...
For instance, jsdom's more spec-compliant parsing causes issues with auto-closing elements (lifehacker article) and with not having self-closing <img> and <br> tags. The former was fixed by removing offending markup, the latter by adjusting JSDOMParser to be more sane, and the expected outputs to cope with this.
Finally, JSDOMParser automatically drops comments. The test code needed to manually do this in the jsdom case.
10 years ago
Gijs Kruitbosch
7c60dba3b6
Fix Readability.js to work with jsdom's DOM implementation (in particular: no firstElementChild implementation...)
10 years ago
Gijs Kruitbosch
62801faa0e
Fix JSDOMParser to do some HTML escaping and identify as JSDOMParser + add tests
10 years ago
Margaret Leibovic
0f2f61d0a6
Merge pull request #96 from mozilla/isprob
...
Bug 1150695 - Move isProbablyReaderable function to Readability.js
10 years ago
Nicolas Perriault
3b636b59f0
Added readerable value to test pages metadata.
10 years ago
Margaret Leibovic
6b7834f798
add test for isProbablyReaderable
10 years ago
Margaret Leibovic
eb3a8e8dc4
Bug 1150695 - Move isProbablyReaderable function to Readability.js
10 years ago
Gijs
7430df7f23
Merge pull request #94 from mozilla/benchmark-folder
...
Fixed broken benchmark reporter code, moved benchmark code to its own folder
10 years ago
Nicolas Perriault
360c648579
Fixed broken benchmark reporter code, moved benchmark code to its own folder.
10 years ago
Gijs
c2b40ab630
Merge pull request #91 from gijsk/benchmark-avg-ops-and-readability
...
Add benchmark for readability and show averages by using custom reporter
10 years ago
Gijs Kruitbosch
02b7db3f7e
Add benchmark for readability itself instead of just JSDOMParser, add averages so the results are scannable.
10 years ago
Gijs
e51457d787
Merge pull request #90 from mozilla/benchmarks
...
Added benchmarks to be able to keep track of the speed of the parser and readability.
10 years ago
Nicolas Perriault
2bfa678cab
Added separate command for reference benchmark.
10 years ago
Nicolas Perriault
1e14d47bb7
Added benchmarks.
10 years ago
Gijs
f2b04930c1
Merge pull request #87 from gijsk/script-parsing-should-deal-with-comments
...
Fix script parsing to ignore closing tags in comments
10 years ago
Gijs Kruitbosch
8ddba60425
Fix script parsing to ignore closing tags in comments
10 years ago
Gijs
87e4fbb612
Merge pull request #82 from mozilla/keep-images
...
Fixes #81 - Keep article images.
10 years ago
Nicolas Perriault
f8d37e4276
Don't remove elements containing figures or having them as a parent.
10 years ago
Nicolas Perriault
b6730703a1
Fixes #81 - Keep article images.
10 years ago
Margaret Leibovic
0b3bce57bf
Merge pull request #86 from gijsk/fix-innerHTML-children
...
Fix innerHTML's children setter
10 years ago
Gijs Kruitbosch
cdcbd94cd5
Add tests for the lifehacker page
10 years ago
Gijs Kruitbosch
bc7873d313
Fix innerHTML children assignments to help fix issue #76 .
10 years ago
Gijs
194a5376c8
Merge pull request #63 from mozilla/preserve-embedded-tweets
...
Preserve inline tweets as they're part of article contents.
10 years ago
Nicolas Perriault
ec491127f4
Merge pull request #70 from gijsk/fix-parent-score-nullcheck
...
Fix an issue where we don't track scores for the parents appropriately.
10 years ago
Gijs
5eebd57d71
Merge pull request #69 from mozilla/print-err-stack-on-generation-failure
...
Log the exception stack trace when a test case generation fails
10 years ago
Nicolas Perriault
aeeabb7c79
Print exception stack when generating a test case fails.
10 years ago
Gijs Kruitbosch
b4332328f3
Fix an issue where we don't track scores for the parents appropriately.
10 years ago
Gijs
14b33b69db
Merge pull request #65 from mozilla/support-embed-videos
...
Fixes #56 - Updated support for embedded Youtube & Vimeo videos.
10 years ago
Gijs
b8b620631d
Merge pull request #68 from mozilla/fix-base-urls
...
Fixes #53 - Fixed dot-slash relative URI resolution.
10 years ago
Nicolas Perriault
ad52d8ee30
Fixes #53 - Fixed dot-slash relative URI resolution.
10 years ago
Nicolas Perriault
2d5f59f3eb
Fixes #56 - Updated support for embedded Youtube & Vimeo videos.
10 years ago
Gijs
f9ea568f3f
Merge pull request #64 from mozilla/fix-readme-with-tests
...
Updated README about tests.
10 years ago
Nicolas Perriault
c24821c247
Updated README about tests.
10 years ago
Nicolas Perriault
d83763c8a1
Preserve inline tweets as they're part of article contents.
10 years ago
Nicolas Perriault
9510715723
Merge pull request #61 from mozilla/strip-embed-tags
...
Refs #58 - Stripped embed tags.
10 years ago
Nicolas Perriault
cf3dce6cf2
Refs #58 - Stripped embed tags.
10 years ago
Gijs
6ad9dd9952
Merge pull request #52 from mozilla/forEach-loops
...
Use forEach when it makes sense.
10 years ago
Nicolas Perriault
eee224560b
Addressed review comments from @Gijsk.
10 years ago
Nicolas Perriault
4f9615cb9a
Use forEach when it makes sense.
10 years ago
Gijs
f7c0e4713f
Merge pull request #51 from gijsk/fix-medium-title
...
Fix the title to not update when we already have one
10 years ago
Gijs Kruitbosch
14afc21b96
Fix code to ignore titles when we already have one.
10 years ago
Gijs Kruitbosch
a924e31729
Add testcase for current Medium behaviour including SVG that desktop sees.
10 years ago
Gijs
98d35fc306
Merge pull request #50 from gijsk/fix-herald-sun
...
Bug 1143725 - fix the Herald Sun website
10 years ago
Gijs Kruitbosch
955951659d
Bug 1143725 - fix the Herald Sun website
10 years ago
Gijs
a77dcab362
Merge pull request #49 from gijsk/improve-logic-to-use-children-instead-of-childnodes
...
Improve logic to rely on children instead of childNodes
10 years ago
Gijs Kruitbosch
eb81444946
Improve logic to rely on children instead of childNodes
10 years ago
Margaret Leibovic
4e92d7c1ac
Merge pull request #46 from gijsk/tests-for-jsdomparser
...
Write a bunch of tests for jsdomparser
10 years ago
Gijs Kruitbosch
f9e770ad3b
Write a bunch of tests for jsdomparser
10 years ago
Margaret Leibovic
d0df9d8479
Merge pull request #40 from leibovic/byline
...
Improve byline algorithm. r=Gijs
10 years ago