Commit Graph

114 Commits (0449dbf186aef03274936a80d2dd116363a76885)

Author SHA1 Message Date
Gijs Kruitbosch f782bc5f06 Avoid global flag when looking for metadata using regexes 6 years ago
David A Roberts ea4165721f Remove single-cell tables 6 years ago
David A Roberts bf64b58d90 Update tests 6 years ago
Gijs Kruitbosch d4b842c82a Match headings on trimmed strings to avoid whitespace causing mismatches 6 years ago
Gijs Kruitbosch 8c02a0d34c Fix #283 and remove hidden nodes 6 years ago
David A Roberts 656a6673d9 Don't put non-phrasing content into paragraphs 6 years ago
David A Roberts 5ae90930cd Don't convert DIVs to Ps when more than 25% links 6 years ago
David A Roberts 9f2c5cb42e Put phrasing content into paragraphs
This removes the need for `p.readability-styled` elements.
6 years ago
David A Roberts 7a24801958 Don't include root html node in candidates
Fixes #435
6 years ago
Andres Rey 3c76104adb Fix engadget test case 7 years ago
Andres Rey 4b99f41ec9 Add engadget test case 7 years ago
Andres Rey 6c5bc62959 Remove aside tags on test cases 7 years ago
David A Roberts f8d9b1c224 Update test expectations 7 years ago
David A Roberts 8414158fa9 Fix _replaceBrs
Previously, `nextElem` was not actually proceeding to the next element, and therefore aborting the paragraph at the first `<br>` (rather than the first `<br><br>` as the comment indicates).
7 years ago
Brad Philips 8525c6af36 Fix relative URIs given <base> tags (#422) 7 years ago
Andres Rey 834672ef86 Return longest text after failing to detect text longer than the configured value (#423)
Save extracted text across attempts and return the longest one when all attempts fail, and add a test case from hukumusume
7 years ago
Tom Z?hner 264b8e8968 Remove link elements when preparing article for display 7 years ago
Andres Rey fa9d8bda48 Add la-nacion test case 7 years ago
Gijs Kruitbosch 807bf05aa3 Fix className usage so it deals correctly with SVG nodes (fixes #412). 7 years ago
Gijs Kruitbosch ad4dd26448 Update test expectations 7 years ago
Andres Rey eb895b97a2 Add test case for title and h1 discrepancy 7 years ago
Andres Rey c2e370c2c7 Add telegraph test case 7 years ago
Cameron McCormack 5ad448f831 Update test expectations. 7 years ago
Taylor Hunt b7c32feb25 Remove presentational HTML attributes (#385)
* Remove presentational HTML attributes

Fixes #383

This patch loops through a list of known-presentational attributes in HTML, attempting to remove each from each cleaned element. (Checking for the attribute's existence first seems to just add needless overhead.)

The extra check for the HTML namespace is to avoid removing attributes that inline SVG needs.

* Only remove `width`/`height` for certain elements

Embedded media elements are allowed to have them, but not others.

* Address PR feedback

* Fix loop index formatting
* Only remove `width`/`height` from certain elements
* Combine logic into a single check/remove

* Attempt fixing my recursion

* One weird trick to get your loops to run

* Add inline SVG bailout

Try not to touch any styles for `<svg>`, because it's inherently presentational.

* Update tests to match newly-removed attributes

* Oh those wacky SVGs

The `position:absolute` is a trick to import clipping paths into the document without putting a big 300×150 empty space in it. (`display:none` and such disable the clipPath in some browsers.)

* Whoops, missed some `width`s

* Normalize SVG tagName

JSDOMParser differs from the official DOM here
7 years ago
Evan Tseng 924017c686 Merge pull request #370 from evanxd/bug-1347472
Bug 1347472 - Tests for WordPress blogs, r=Gijs
8 years ago
Evan Tseng f6d0840b82 Bug 1347472 - Tests for WordPress blogs, r=Gijs 8 years ago
Evan Tseng 0e147aa722 Bug 1346717 - Tests for youth.cn, r=Gijs 8 years ago
Evan Tseng 630a0b7367 Bug 1346155 - Tests for gmw.cn, r=Gijs 8 years ago
Evan Tseng 8976fb08bf Bug 1345797 - Tests for yahoo.co.jp, r=Gijs 8 years ago
Evan Tseng e48451c48c Bug 1342355 - Add tests for wikia.com, r=Gijs 8 years ago
Evan Tseng c7c26382b9 Bug 1217007 - Remove nodes without any content, r=Gijs 8 years ago
Evan Tseng 0f147374b7 Bug 1323861 - Remove the readScript method, r=Gijs 8 years ago
Evan Tseng 27b97434a3 Merge pull request #352 from evanxd/bug-1338468
Bug 1338468 - Tests for tumblr.com, r=Gijs
8 years ago
Evan Tseng b46e316034 Bug 1338468 - Tests for tumblr.com, r=Gijs 8 years ago
Evan Tseng bd2d9f8100 Bug 1338475 - Tests for pixnet.net, r=Gijs 8 years ago
Evan Tseng 1369f923db Merge pull request #348 from gijsk/1322674-table-divs
Fix bug 1322674 by only conditionally removing content from tables when the tables are layout tables, r=evanxd
8 years ago
Gijs Kruitbosch 9baea36169 Fix bug 1322674 by not removing content in data tables 8 years ago
Evan Tseng 19f2124c82 Bug 1259763 - Remove h2 when there is only one h2 and its text content substantially equals article title, r=Gijs 8 years ago
Evan Tseng ccc8e9bf4c Bug 1330931 - Add tests for nytimes.com, r=Gijs 8 years ago
Evan Tseng 15e1f03261 Bug 1300697 - Reader View missed first few paragraphs on New York Times website, r=Gijs 8 years ago
Evan Tseng a58913d975 Bug 1300697 - Add test for New York Times website 8 years ago
Evan Tseng ad13a63065 Bug 1332236 - Add tests for cnet.com, r=Gijs 8 years ago
Evan Tseng 131d923d38 Bug 1167568 - Find a better topCandidate if there are other nodes scores are high enough, r=Gijs 8 years ago
Sebastian Hengst 5e9c7a3910 Bug 1322327 - Only remove images which are not descendants of a figure if there is more than one image, update affected tests 8 years ago
andrei-ch c5ff44d8fe Clean <input>,<textarea>,<select>,<button> elements 8 years ago
Evan Tseng a34d054f45 Merge pull request #332 from gijsk/fix-readability-determination-in-generate-testcase
Use jsdom for parsing the document to determine readability (fixes #325), r=evanxd
8 years ago
Evan Tseng 63230a307a Bug 1142312 - Add two more types of unlikely candidates: cover-wrap and yom-remote, r=Gijs 8 years ago
Gijs Kruitbosch 46842048c1 Use jsdom for parsing the document to determine readability (fixes #325) 8 years ago
Evan Tseng e84c0c3f07 Bug 1285543 - Only use "og:title" or "twitter:title" if _getArticleTitle does not return a valid title, r=Gijs 8 years ago
Evan Tseng 33dc8fa023 Bug 1255978 - Remove legends candidate, r=Gijs 8 years ago