Commit Graph

118 Commits

Author SHA1 Message Date
Yawning Angel
594d45be02 Update the ChangeLog (No functional changes). 2015-03-22 12:57:55 +00:00
Daniel Martí
398b795c87 Simplify some err and return logic 2015-03-22 00:24:44 +01:00
Daniel Martí
ced244c09f Reduce some if err != nil logic lines 2015-03-18 13:44:59 +01:00
Yawning Angel
6d1b69d299 Update the ChangeLog (No functional changes). 2015-03-16 21:32:17 +00:00
Daniel Martí
19dcb424be Fix all go vet issues 2015-03-16 19:47:37 +01:00
Daniel Martí
08647ec580 Run go fmt 2015-03-16 19:43:02 +01:00
Yawning Angel
714581df51 Do the release ritual for obfs4proxy-0.0.4. 2015-02-17 11:45:41 +00:00
Yawning Angel
0066cfc393 Add support for acting as a ScrambleSuit client.
This allows obfs4proxy to be used as a ScrambleSuit client that is wire
compatible with the obfs4proxy implementation, including session ticket
support, and length obfuscation.

The current implementation has the following limitations:
 * IAT obfuscation is not supported (and is disabled in all other
   ScrambleSuit implementations by default).
 * The length distribution and probabilites are different from those
   generated by obfsproxy and obfsclient due to a different DRBG.
 * Server support is missing and is unlikely to be implemented.
2015-02-17 11:33:29 +00:00
Yawning Angel
0f038ca4fa Document the obfs4 NaCl secretbox nonce generation.
Forgot to include this in the spec, though it was documented as a
comment in the framing code.
2015-01-14 20:49:56 +00:00
Yawning Angel
cdeda57241 Change the import path for go.crypto.
The Go developers decided to move the go.crypto repository to
golang.org/x/crypto, and also to transition from hg to git.  The tip of
tree code.google.com copy of the code is broken due to the import paths
pointing at the new repository.

While the change here is simple (just update the import location), this
affects packagers as it now expects the updated package.  Sorry for the
inconveneince, I blame the Go people.
2015-01-14 20:43:04 +00:00
Yawning Angel
6ba5b4921f Fix minor issues pointed out by "go vet". 2014-10-24 22:02:23 +00:00
Yawning Angel
4932821bda Improve the performance of the obfs4 handshake test.
Exhaustively testing padding combinations is really slow, and was
causing timeouts during the Debian ARM package build process.  Attempt
to improve the situation by:

 * Reusing the client and server keypair for all of the tests, to cut
   runtime down by  ~50%.
 * Splitting the client side and server side tests up, as it appears
   the timeout is per-test case.

If this doesn't fix things, the next thing to try would be to reduce
the actual number of padding lengths tested, but that is a last resort
at the moment.
2014-10-03 18:27:38 +00:00
Yawning Angel
fc00015ee2 Do the release ritual for obfs4proxy-0.0.3. 2014-10-01 19:29:22 +00:00
Yawning Angel
6cd81ec42f Change the bridge line format to be more compact.
Instead of "node-id" and "public-key" that are Base16 encoded, use
"cert" which contains the "node-id" and "public-key" in Base64 encoded
form.  This is more compact and cuts the length down by 49 characters.
2014-10-01 19:00:30 +00:00
Yawning Angel
213495d3b9 Do the release ritual for obfs4proxy-0.0.2. 2014-09-26 09:51:26 +00:00
Yawning Angel
514c3c6053 Write an example obfs4 bridge line to "obfs4_bridgeline.txt".
Write an example client bridge line suitable for use with the running
obfs4 server instance to "obfs4_bridgeline.txt" for the convenience of
bridge operators.
2014-09-24 16:00:42 +00:00
Yawning Angel
c4378cc0d3 Fix spelling error in man page, no functional changes. 2014-09-06 17:30:55 +00:00
Yawning Angel
1436720b12 Minor documentation cleanups, no functional changes. 2014-09-06 16:47:57 +00:00
Yawning Angel
09633500b3 Add a man page for obfs4proxy. 2014-09-06 16:40:37 +00:00
Yawning Angel
cedd6a5fa9 Do the release ritual for obfs4proxy-0.0.1. 2014-09-03 17:12:53 +00:00
Yawning Angel
ce86fa4348 Change the default logLevel to ERROR, upgrade some client warnings.
Client side logs are less spammy than server side in general, so more
messages should be visible at the default logLevel when running as a
client.

Server side logging will be spammy basically no matter what unless
obfs4proxy gets into the (arguably dangerous) business of figuring out
which errors are people being evil vs which ones are transient network
issues, so most logging is suppressed by default, unless the admin
choses to open the floodgates.
2014-09-03 12:50:43 +00:00
Yawning Angel
fb13cf1241 Add a prolog/epilog to the logging that always gets logged.
The prolog prints the version as soon as logging is enabled, but before
the pluggable transport configuration is done.  The epilog is printed as
the code returns from main, as long as either client or server pt
configuration succeded.
2014-09-03 11:55:16 +00:00
Yawning Angel
79e94103d6 Update the README.md (No functional changes). 2014-09-03 09:44:18 +00:00
Yawning Angel
d5f59458fe Change the version command line arg from -v to -version.
For consistency with the rest of the arguments.
2014-09-03 09:09:13 +00:00
Yawning Angel
25178c6a95 Add support for "logLevel" to reduce log spam.
By default logging will be done at the "WARN" level.  Fatal
initialization errors will always be logged as long as logging
is enabled regardless of logLevel.
2014-09-03 09:05:18 +00:00
Yawning Angel
ce39988b11 Add elideError(error) that knows how to sanitize net.Errors.
Instead of omitting errors entirely when running with the log scrubber,
filter common network errors through elideError() that can scrub the
common net.Error types and remove sensitive information.
2014-08-31 14:30:14 +00:00
Yawning Angel
bfca92cf16 Various IAT related changes.
* Unbreak inbound TYPE_PRNG_SEED processing.

 * IAT obfuscation is now a per-bridge argument (iat-mode).
   * 0 (default) = Disabled.
   * 1 = Enabled, ScrambleSuit-style with bulk throughput optimizations.
   * 2 = Paranoid, Each IAT write will send a length sampled from the
     length distribution. (EXPENSIVE).

The "iat-mode" argument is mandatory on the Bridge lines, and as a
ServerTransportOption.  Old statefiles will continue to load and use
the default value, edit it if your hat is made of tin foil.
2014-08-27 12:30:11 +00:00
Yawning Angel
94d3fe9a08 Change the TYPE_PRNG_SEED length to 24.
This matches what the code actually sends.  It's shorter than the
ScrambleSuit PRNG seed, but that's because the SipHash-2-4 based
Hash_DRBG has 24 bytes of internal state (key + initial output).
2014-08-27 12:26:09 +00:00
Yawning Angel
468cd4bde8 Display a more useful error on JSON Unmarshall failure. 2014-08-27 03:52:22 +00:00
Yawning Angel
83c9e3b9a0 Add a ChangeLog and dump the version when invoked with "-v". 2014-08-27 03:46:23 +00:00
Yawning Angel
1e574942d5 Change all the arguments to use base16 from base64.
WARNING: THIS BREAKS BACKWARD COMPATIBILITY.

This is primarily to work around bug #12930.  Base16 was chosen over
unpadded Base64 because the go runtime Base64 decoder does not handle
omitting the padding.

May $deity have mercy on anyone who needs to hand-enter an obfs4 bridge
line because I will not.
2014-08-23 05:33:23 +00:00
Yawning Angel
596cc85073 Elide the error out from most logs unless unsafeLogging is set.
The Golang runtime will happily splatter the remote IP address and port
in the error's string representation for network related errors.  While
useful for debugging, this is unacceptable from a privacy standpoint.
2014-08-20 22:44:07 +00:00
Yawning Angel
dd9fdee55d Add a missing "continue" statement.
Caught by asn, thanks.
2014-08-20 13:43:43 +00:00
Yawning Angel
f32f01ba01 Change the drbg seed field in the state file.
Changing from "drbgSeed" to "drbg-seed" to be consistent with the
ServerTransportOptions to allow for easier copy/paste.
2014-08-18 11:54:39 +00:00
Yawning Angel
22c9dc3f48 Add support for enabling IAT obfuscation and biased WDist.
Golang's command line parser is slightly cumbersome to use with
subcommands, so the arguments are "obfs4-iatObufscation" and
"obfs-distBias" instead of obfsproxy style subcommands.
2014-08-18 11:53:22 +00:00
Yawning Angel
339c63f0c8 Massive cleanup/code reorg.
* Changed obfs4proxy to be more like obfsproxy in terms of design,
   including being an easy framework for developing new TCP/IP style
   pluggable transports.
 * Added support for also acting as an obfs2/obfs3 client or bridge
   as a transition measure (and because the code itself is trivial).
 * Massively cleaned up the obfs4 and related code to be easier to
   read, and more idiomatic Go-like in style.
 * To ease deployment, obfs4proxy will now autogenerate the node-id,
   curve25519 keypair, and drbg seed if none are specified, and save
   them to a JSON file in the pt_state directory (Fixes Tor bug #12605).
2014-08-17 17:11:03 +00:00
Yawning Angel
8a3eb4b309 Change the import paths to point to the tp.o repository. 2014-06-25 16:03:18 +00:00
Yawning Angel
0fa8adc752 Use delete to remove entries from the replay filter. 2014-06-20 08:42:36 +00:00
Yawning Angel
5abad1571c Use Vose's Alias Method to sample the weighted distribution.
The weight generation code also was cleaned up (and now can support
generating distributions that look like what ScrambleSuit does as
a compile time change).

Per: http://www.keithschwarz.com/darts-dice-coins/
2014-06-19 06:29:12 +00:00
Yawning Angel
6245391c93 Document dependencies, add LICENSE (No functional changes). 2014-06-07 20:03:29 +00:00
Yawning Angel
b19b6de31f Allow randomly generating node-ids instead of requiring the fingerprint.
To ease delopyment, "-genServerParams has changed".

 * "-genServerParams" is now a bool, and will by default generate a
   random node-id.
 * "-genServerParams -genServerParamsFP=<Base16 blob>" will convert the
   supplied bridge fingerprint to a node-id (the old behavior).

Either way of deriving node-id is belived to be secure.

 * https://lists.torproject.org/pipermail/tor-dev/2014-May/006929.html
 * https://lists.torproject.org/pipermail/tor-dev/2014-June/006936.html

The extra parameter was added because golang's flags library doesn't
support distinguishing between "set but used the default value" and
"not set, so you go the default value".
2014-06-07 00:26:36 +00:00
Yawning Angel
d9c6ecbf8f Use goptlib's MakeStateDir instead of the one in pt_extras.
This requires changes in goptlib from last night, people may need to
run "go get -u" to update dependencies before building.
2014-06-02 18:15:02 +00:00
Yawning Angel
5bdc376e2a Change how the length obfsucation mask is derived.
Instead of using the nonce for the secret box, just use SipHash-2-4 in
OFB mode instead.  The IV is generated as part of the KDF.  This
simplifies the code a decent amount and also is better on the off
chance that SipHash-2-4 does not avalanche as well as it is currently
assumed.

While here, also decouple the fact that *this implementation* of obfs4
uses a PRNG with 24 bytes of internal state for protocol polymorphism
instead of 32 bytes (that the spec requires).

THIS CHANGE BREAKS WIRE PROTCOL COMPATIBILITY.
2014-06-02 17:50:01 +00:00
Yawning Angel
5cb3369e20 Move the SipHash DRBG off into it's own package. 2014-06-02 16:47:30 +00:00
Yawning Angel
36228437c4 Move the server keypair generation to right after Accept().
Instead of threading the code, move the keypair generation to right
after Accept() is called.  This should mask the timing differential due
to the rejection sampling with the noise from the variablity in how
long it takes for the server to get around to pulling a connection out
of the backlog, and the time taken for the client to send it's portion
of the handshake.

The downside is that anyone connecting to the obfs4 port does force us
to do a bunch of math, but the obfs4 math is relatively cheap compared
to it's precursors.

Fixes #9.
2014-06-01 05:22:07 +00:00
Yawning Angel
2001f0b698 Generate client keypairs before connecting, instead of after.
Part of issue #9.
2014-06-01 04:51:33 +00:00
Yawning Angel
697b51b4bd Fix minor style issues pointed out by golint. 2014-05-28 04:25:47 +00:00
Yawning Angel
9fe9959c76 Change the weighted distribution algorithm be uniform.
The old way was biasted towards the earlier values.  Thanks to asn for
pointing this out and suggesting an alternative.

As an additional tweak, do not reuse the drbg seed when calculating the
IAT distribution, but instead run the seed through SHA256 first, for
extra tinfoil goodness.
2014-05-28 04:22:36 +00:00
Yawning Angel
bd2bef2ead Fix import lines so other people using go get works. 2014-05-26 16:20:33 +00:00
Yawning Angel
b579f6f4d4 Use io.ReadFull in places where it is appropriate. 2014-05-26 04:43:46 +00:00