only manage ncvisual in toplayer with no media implementation #1711

src/lib/visual.c

@@ -962,13 +962,14 @@ ncvisual* ncvisual_from_plane(const ncplane* n, ncblitter_e blit, int begy, int
 
 void ncvisual_destroy(ncvisual* ncv){
   if(ncv){
-    if(visual_implementation){
+    if(visual_implementation == NULL){
+      if(ncv->owndata){
+        free(ncv->data);
+      }
+      free(ncv);
+    }else{
       visual_implementation->visual_destroy(ncv);
     }
-    if(ncv->owndata){
-      free(ncv->data);
-    }
-    free(ncv);
   }
 }
 

src/media/ffmpeg.c

@@ -647,6 +647,10 @@ void ffmpeg_details_destroy(ncvisual_details* deets){
 void ffmpeg_destroy(ncvisual* ncv){
   if(ncv){
     ffmpeg_details_destroy(ncv->details);
+    if(ncv->owndata){
+      free(ncv->data);
+    }
+    free(ncv);
   }
 }
 

src/media/none.cpp

@@ -78,10 +78,6 @@ void none_details_seed(ncvisual* ncv){
   (void)ncv;
 }
 
-void none_details_destroy(struct ncvisual_details* ncv){
-  (void)ncv;
-}
-
 int none_init(int loglevel __attribute__ ((unused))) {
   return 0; // allow success here
 }