ncvisual_destroy: free up structure on all paths #1711

src/lib/visual.c

@@ -961,8 +961,14 @@ ncvisual* ncvisual_from_plane(const ncplane* n, ncblitter_e blit, int begy, int
 }
 
 void ncvisual_destroy(ncvisual* ncv){
-  if(visual_implementation){
-    visual_implementation->visual_destroy(ncv);
+  if(ncv){
+    if(visual_implementation){
+      visual_implementation->visual_destroy(ncv);
+    }
+    if(ncv->owndata){
+      free(ncv->data);
+    }
+    free(ncv);
   }
 }
 

src/media/ffmpeg.c

@@ -647,10 +647,6 @@ void ffmpeg_details_destroy(ncvisual_details* deets){
 void ffmpeg_destroy(ncvisual* ncv){
   if(ncv){
     ffmpeg_details_destroy(ncv->details);
-    if(ncv->owndata){
-      free(ncv->data);
-    }
-    free(ncv);
   }
 }
 

src/media/oiio.cpp

@@ -197,10 +197,6 @@ auto ncvisual_rotate(ncvisual* ncv, double rads) -> int {
 auto oiio_destroy(ncvisual* ncv) -> void {
   if(ncv){
     oiio_details_destroy(ncv->details);
-    if(ncv->owndata){
-      free(ncv->data);
-    }
-    delete ncv;
   }
 }