C++ wrappers: kill Visual::destroy_plane() #299

ncvisual_destroy() already calls ncplane_destroy() when
appropriate. There's never a need for the C++ wrappers
to explicitly free the Visual's underlying Plane. With
this change, valgrind no longer complains upon exiting
notcurses-view(1).
pull/312/head
nick black 5 years ago committed by Nick Black
parent 89b95981b2
commit 09d2e35372

@ -36,7 +36,6 @@ namespace ncpp
~Visual () noexcept ~Visual () noexcept
{ {
destroy_plane (get_plane ());
if (!is_notcurses_stopped ()) if (!is_notcurses_stopped ())
ncvisual_destroy (visual); ncvisual_destroy (visual);
} }
@ -73,9 +72,6 @@ namespace ncpp
Plane* get_plane () const noexcept; Plane* get_plane () const noexcept;
private:
static void destroy_plane (Plane *plane) noexcept;
private: private:
ncvisual *visual = nullptr; ncvisual *visual = nullptr;
}; };

@ -7,8 +7,3 @@ Plane* Visual::get_plane () const noexcept
{ {
return Plane::map_plane (ncvisual_plane (visual)); return Plane::map_plane (ncvisual_plane (visual));
} }
void Visual::destroy_plane (Plane *plane) noexcept
{
delete plane;
}

Loading…
Cancel
Save